diff options
| author | JP Abgrall <jpa@google.com> | 2014-02-15 00:52:54 +0000 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2014-02-15 00:52:54 +0000 |
| commit | f7cf1a062ef27b6579b9afb876d635a307b3d5d3 (patch) | |
| tree | 4dd4f4f5cb43c520464070a8a3188691f652fab9 | |
| parent | d0307beeef57b9db06b82f1ffba746c5decb0b72 (diff) | |
| parent | 80b435a3f35795600654e9705f4b3fbbcc427a9d (diff) | |
| download | system_core-f7cf1a062ef27b6579b9afb876d635a307b3d5d3.zip system_core-f7cf1a062ef27b6579b9afb876d635a307b3d5d3.tar.gz system_core-f7cf1a062ef27b6579b9afb876d635a307b3d5d3.tar.bz2 | |
Merge "sdcard: direct I/O file access fix"
| -rw-r--r-- | sdcard/sdcard.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/sdcard/sdcard.c b/sdcard/sdcard.c index 4722708..3bc8cd3 100644 --- a/sdcard/sdcard.c +++ b/sdcard/sdcard.c @@ -232,7 +232,7 @@ struct fuse_handler { * buffer at the same time. This allows us to share the underlying storage. */ union { __u8 request_buffer[MAX_REQUEST_SIZE]; - __u8 read_buffer[MAX_READ]; + __u8 read_buffer[MAX_READ + PAGESIZE]; }; }; @@ -1218,6 +1218,7 @@ static int handle_read(struct fuse* fuse, struct fuse_handler* handler, __u32 size = req->size; __u64 offset = req->offset; int res; + __u8 *read_buffer = (__u8 *) ((uintptr_t)(handler->read_buffer + PAGESIZE) & ~((uintptr_t)PAGESIZE-1)); /* Don't access any other fields of hdr or req beyond this point, the read buffer * overlaps the request buffer and will clobber data in the request. This @@ -1225,14 +1226,14 @@ static int handle_read(struct fuse* fuse, struct fuse_handler* handler, TRACE("[%d] READ %p(%d) %u@%llu\n", handler->token, h, h->fd, size, offset); - if (size > sizeof(handler->read_buffer)) { + if (size > MAX_READ) { return -EINVAL; } - res = pread64(h->fd, handler->read_buffer, size, offset); + res = pread64(h->fd, read_buffer, size, offset); if (res < 0) { return -errno; } - fuse_reply(fuse, unique, handler->read_buffer, res); + fuse_reply(fuse, unique, read_buffer, res); return NO_STATUS; } |
