diff options
author | Dan Albert <danalbert@google.com> | 2015-04-03 16:52:01 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2015-04-03 16:52:02 +0000 |
commit | 8ea5dd8c6e14e889e917a7e51a1b62bd49ca1dab (patch) | |
tree | a52a30b208c5d3b425e521c3644d65d05a455eb4 /base | |
parent | cc71951a8a6ffac2bd70d99fe25860f7bb71c5ec (diff) | |
parent | 0cc351b1a7e37c61821a8601aa8dfc713a0d584a (diff) | |
download | system_core-8ea5dd8c6e14e889e917a7e51a1b62bd49ca1dab.zip system_core-8ea5dd8c6e14e889e917a7e51a1b62bd49ca1dab.tar.gz system_core-8ea5dd8c6e14e889e917a7e51a1b62bd49ca1dab.tar.bz2 |
Merge "Remove LogMessage::LogLineLowStack."
Diffstat (limited to 'base')
-rw-r--r-- | base/include/base/logging.h | 4 | ||||
-rw-r--r-- | base/logging.cpp | 44 |
2 files changed, 0 insertions, 48 deletions
diff --git a/base/include/base/logging.h b/base/include/base/logging.h index 5e115fe..0283217 100644 --- a/base/include/base/logging.h +++ b/base/include/base/logging.h @@ -241,10 +241,6 @@ class LogMessage { static void LogLine(const char* file, unsigned int line, LogSeverity severity, const char* msg); - // A variant of the above for use with little stack. - static void LogLineLowStack(const char* file, unsigned int line, - LogSeverity severity, const char* msg); - private: const std::unique_ptr<LogMessageData> data_; diff --git a/base/logging.cpp b/base/logging.cpp index 38ee2af..144388a 100644 --- a/base/logging.cpp +++ b/base/logging.cpp @@ -245,50 +245,6 @@ void LogMessage::LogLine(const char* file, unsigned int line, #endif } -void LogMessage::LogLineLowStack(const char* file, unsigned int line, - LogSeverity log_severity, const char* message) { -#ifdef __ANDROID__ - // Use android_writeLog() to avoid stack-based buffers used by - // android_printLog(). - const char* tag = ProgramInvocationShortName(); - int priority = kLogSeverityToAndroidLogPriority[log_severity]; - char* buf = nullptr; - size_t buf_size = 0u; - if (priority == ANDROID_LOG_FATAL) { - // Allocate buffer for snprintf(buf, buf_size, "%s:%u] %s", file, line, - // message) below. If allocation fails, fall back to printing only the - // message. - buf_size = strlen(file) + 1 /* ':' */ + - std::numeric_limits<typeof(line)>::max_digits10 + 2 /* "] " */ + - strlen(message) + 1 /* terminating 0 */; - buf = reinterpret_cast<char*>(malloc(buf_size)); - } - if (buf != nullptr) { - snprintf(buf, buf_size, "%s:%u] %s", file, line, message); - android_writeLog(priority, tag, buf); - free(buf); - } else { - android_writeLog(priority, tag, message); - } -#else - static const char* log_characters = "VDIWEF"; - CHECK_EQ(strlen(log_characters), FATAL + 1U); - - const char* program_name = ProgramInvocationShortName(); - write(STDERR_FILENO, program_name, strlen(program_name)); - write(STDERR_FILENO, " ", 1); - write(STDERR_FILENO, &log_characters[log_severity], 1); - write(STDERR_FILENO, " ", 1); - // TODO: pid and tid. - write(STDERR_FILENO, file, strlen(file)); - // TODO: line. - UNUSED(line); - write(STDERR_FILENO, "] ", 2); - write(STDERR_FILENO, message, strlen(message)); - write(STDERR_FILENO, "\n", 1); -#endif -} - ScopedLogSeverity::ScopedLogSeverity(LogSeverity level) { old_ = gMinimumLogSeverity; gMinimumLogSeverity = level; |