diff options
author | Dmitriy Ivanov <dimitry@google.com> | 2014-08-08 16:30:13 -0700 |
---|---|---|
committer | Dmitriy Ivanov <dimitry@google.com> | 2014-08-11 10:01:58 -0700 |
commit | a639b97d4ac9f22b64fd4aa8d5ac24177817a0dc (patch) | |
tree | 0e427adbeebd2541624cba97efb6c1b373b0871c /debuggerd | |
parent | cc2566f12760d66837b52213e5ffd2cb30cce19e (diff) | |
download | system_core-a639b97d4ac9f22b64fd4aa8d5ac24177817a0dc.zip system_core-a639b97d4ac9f22b64fd4aa8d5ac24177817a0dc.tar.gz system_core-a639b97d4ac9f22b64fd4aa8d5ac24177817a0dc.tar.bz2 |
Do not suppress maps dump when si_addr<PAGE_SIZE
Also remove alignment of si_addr.
(cherry picked from commit f10aa3ae9d58269465c579e4c286ccef6be4c2d0)
Bug: 16950250
Change-Id: I60170b9eb7dd8fe99c0eeeaec74d13cfbaa920d9
Diffstat (limited to 'debuggerd')
-rw-r--r-- | debuggerd/tombstone.cpp | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/debuggerd/tombstone.cpp b/debuggerd/tombstone.cpp index df982a9..a7e1524 100644 --- a/debuggerd/tombstone.cpp +++ b/debuggerd/tombstone.cpp @@ -64,6 +64,7 @@ static bool signal_has_si_addr(int sig) { case SIGFPE: case SIGILL: case SIGSEGV: + case SIGTRAP: return true; default: return false; @@ -350,16 +351,12 @@ static void dump_nearby_maps(BacktraceMap* map, log_t* log, pid_t tid) { return; } - bool is_running = (si.si_code == SI_USER); + bool has_fault_address = signal_has_si_addr(si.si_signo); uintptr_t addr = reinterpret_cast<uintptr_t>(si.si_addr); - addr &= ~0xfff; // round to 4K page boundary - if (!is_running && addr == 0) { // null-pointer deref - return; - } - _LOG(log, logtype::MAPS, "\nmemory map: %s\n", is_running? "" : "(fault address prefixed with --->)"); + _LOG(log, logtype::MAPS, "\nmemory map: %s\n", has_fault_address ? "(fault address prefixed with --->)" : ""); - if(!is_running && (addr < map->begin()->start)) { + if (has_fault_address && (addr < map->begin()->start)) { _LOG(log, logtype::MAPS, "--->Fault address falls at %" PRIPTR " before any mapped regions\n", addr); } @@ -369,10 +366,10 @@ static void dump_nearby_maps(BacktraceMap* map, log_t* log, pid_t tid) { _LOG(log, logtype::MAPS, "--->Fault address falls at %" PRIPTR " between mapped regions\n", addr); } prev = it; - bool in_map = !is_running && (addr >= (*it).start) && (addr < (*it).end); + bool in_map = has_fault_address && (addr >= (*it).start) && (addr < (*it).end); dump_map(log, &*it, in_map); } - if (!is_running && (addr >= (*prev).end)) { + if (has_fault_address && (addr >= (*prev).end)) { _LOG(log, logtype::MAPS, "--->Fault address falls at %" PRIPTR " after any mapped regions\n", addr); } } |