diff options
author | Colin Cross <ccross@android.com> | 2012-06-19 16:45:48 -0700 |
---|---|---|
committer | Colin Cross <ccross@android.com> | 2012-07-09 22:09:37 -0700 |
commit | 13a560659381b34ce3edbfa8dbe6c0aa6c076f20 (patch) | |
tree | cb0b3473d61f63a73e8832c182970939e29a736c /libsparse | |
parent | be8ddcb35a459481c0bcf5bfe645c1fefe963f5c (diff) | |
download | system_core-13a560659381b34ce3edbfa8dbe6c0aa6c076f20.zip system_core-13a560659381b34ce3edbfa8dbe6c0aa6c076f20.tar.gz system_core-13a560659381b34ce3edbfa8dbe6c0aa6c076f20.tar.bz2 |
libsparse: fix windows image writing
Fix write_fd_chunk on windows. Uses malloc and read instead of mmap.
Change-Id: I75f10db2e04f19e7f3a6ff46b6978d143cb5254e
Diffstat (limited to 'libsparse')
-rw-r--r-- | libsparse/output_file.c | 39 | ||||
-rw-r--r-- | libsparse/output_file.h | 2 |
2 files changed, 38 insertions, 3 deletions
diff --git a/libsparse/output_file.c b/libsparse/output_file.c index 4193fd1..5e8a68c 100644 --- a/libsparse/output_file.c +++ b/libsparse/output_file.c @@ -168,6 +168,28 @@ static struct output_file_ops gz_file_ops = { .close = gz_file_close, }; +int read_all(int fd, void *buf, size_t len) +{ + size_t total = 0; + int ret; + char *ptr = buf; + + while (total < len) { + ret = read(fd, ptr, len - total); + + if (ret < 0) + return -errno; + + if (ret == 0) + return -EINVAL; + + ptr += ret; + total += ret; + } + + return 0; +} + static int write_sparse_skip_chunk(struct output_file *out, int64_t skip_len) { chunk_header_t chunk_header; @@ -518,6 +540,7 @@ int write_fd_chunk(struct output_file *out, unsigned int len, int64_t aligned_offset; int aligned_diff; int buffer_size; + char *ptr; aligned_offset = offset & ~(4096 - 1); aligned_diff = offset - aligned_offset; @@ -529,15 +552,25 @@ int write_fd_chunk(struct output_file *out, unsigned int len, if (data == MAP_FAILED) { return -errno; } + ptr = data + aligned_diff; #else - char *data = malloc(buffer_size); + off64_t pos; + char *data = malloc(len); if (!data) { return -errno; } - memset(data, 0, buffer_size); + pos = lseek64(fd, offset, SEEK_SET); + if (pos < 0) { + return -errno; + } + ret = read_all(fd, data, len); + if (ret < 0) { + return ret; + } + ptr = data; #endif - ret = out->sparse_ops->write_data_chunk(out, len, data + aligned_diff); + ret = out->sparse_ops->write_data_chunk(out, len, ptr); #ifndef USE_MINGW munmap(data, buffer_size); diff --git a/libsparse/output_file.h b/libsparse/output_file.h index d23abf3..b86528b 100644 --- a/libsparse/output_file.h +++ b/libsparse/output_file.h @@ -36,4 +36,6 @@ int write_fd_chunk(struct output_file *out, unsigned int len, int write_skip_chunk(struct output_file *out, int64_t len); void close_output_file(struct output_file *out); +int read_all(int fd, void *buf, size_t len); + #endif |