summaryrefslogtreecommitdiffstats
path: root/libsysutils
diff options
context:
space:
mode:
authorJosef Kindberg <josef.kindberg@stericsson.com>2011-02-23 12:40:44 +0100
committerPatrik Ryd <patrik.ryd@stericsson.com>2012-11-12 14:40:21 +0100
commit6d358ae44ccfbcd5b89511d142f334b2cc1b67b1 (patch)
treeab3c1035f273adc03b7cd01f13028cf9f4a59780 /libsysutils
parenta6fb0e05aa95995445c6f2b65f07db26bdbfd46c (diff)
downloadsystem_core-6d358ae44ccfbcd5b89511d142f334b2cc1b67b1.zip
system_core-6d358ae44ccfbcd5b89511d142f334b2cc1b67b1.tar.gz
system_core-6d358ae44ccfbcd5b89511d142f334b2cc1b67b1.tar.bz2
libsysutils: Increase command buffersize and command args
Needed to support tethering of multiple remote Bluetooth devices. Change-Id: I9f736affd83226e8b2fa4f0faacd3654175dd8c9 Signed-off-by: Patrik Ryd <patrik.ryd@stericsson.com>
Diffstat (limited to 'libsysutils')
-rw-r--r--libsysutils/src/FrameworkListener.cpp10
1 files changed, 7 insertions, 3 deletions
diff --git a/libsysutils/src/FrameworkListener.cpp b/libsysutils/src/FrameworkListener.cpp
index 6731cf1..02a401d 100644
--- a/libsysutils/src/FrameworkListener.cpp
+++ b/libsysutils/src/FrameworkListener.cpp
@@ -25,6 +25,8 @@
#include <sysutils/FrameworkCommand.h>
#include <sysutils/SocketClient.h>
+static const int CMD_BUF_SIZE = 1024;
+
FrameworkListener::FrameworkListener(const char *socketName, bool withSeq) :
SocketListener(socketName, true, withSeq) {
init(socketName, withSeq);
@@ -43,7 +45,7 @@ void FrameworkListener::init(const char *socketName, bool withSeq) {
}
bool FrameworkListener::onDataAvailable(SocketClient *c) {
- char buffer[255];
+ char buffer[CMD_BUF_SIZE];
int len;
len = TEMP_FAILURE_RETRY(read(c->getSocket(), buffer, sizeof(buffer)));
@@ -52,6 +54,8 @@ bool FrameworkListener::onDataAvailable(SocketClient *c) {
return false;
} else if (!len)
return false;
+ if(buffer[len-1] != '\0')
+ SLOGW("String is not zero-terminated");
int offset = 0;
int i;
@@ -63,6 +67,7 @@ bool FrameworkListener::onDataAvailable(SocketClient *c) {
offset = i + 1;
}
}
+
return true;
}
@@ -74,7 +79,7 @@ void FrameworkListener::dispatchCommand(SocketClient *cli, char *data) {
FrameworkCommandCollection::iterator i;
int argc = 0;
char *argv[FrameworkListener::CMD_ARGS_MAX];
- char tmp[255];
+ char tmp[CMD_BUF_SIZE];
char *p = data;
char *q = tmp;
char *qlimit = tmp + sizeof(tmp) - 1;
@@ -180,7 +185,6 @@ void FrameworkListener::dispatchCommand(SocketClient *cli, char *data) {
goto out;
}
}
-
cli->sendMsg(500, "Command not recognized", false);
out:
int j;