summaryrefslogtreecommitdiffstats
path: root/logd/LogBuffer.cpp
diff options
context:
space:
mode:
authorMark Salyzyn <salyzyn@google.com>2015-06-04 13:35:30 -0700
committerMark Salyzyn <salyzyn@google.com>2015-06-05 10:20:55 -0700
commitc1e9d6dada4fe20c0537c13cf3ff5a010d208ba1 (patch)
tree12f49bb34b85a86c9f6724c87ca4eb41d325eda2 /logd/LogBuffer.cpp
parent5a9233444b519cb866cc657a4dce27c45f089a97 (diff)
downloadsystem_core-c1e9d6dada4fe20c0537c13cf3ff5a010d208ba1.zip
system_core-c1e9d6dada4fe20c0537c13cf3ff5a010d208ba1.tar.gz
system_core-c1e9d6dada4fe20c0537c13cf3ff5a010d208ba1.tar.bz2
logd: filters remove leading expire messages and rate
(cherry pick from commit 047cc0729fd837a03b99db901941c1421ef15f96) - Cleanup resulting from experience and feedback - When filtering inside logd, drop any leading expire messages, they are cluttering up leading edge of tombstones (which filter by pid) - Increase and introduce EXPIRE_RATELIMIT from 1 to 10 seconds - Increase EXPIRE_THRESHOLD from 4 to 10 count - Improve the expire messages from: logd : uid=1000(system) too chatty comm=com.google.android.phone, expire 2800 lines change tag to be more descriptive, and reduce accusatory tone to: chatty : uid=1000(system) com.google.android.phone expire 2800 lines - if the UID name forms a prefix for comm name, then drop UID name Change-Id: Ied7cc04c0ab3ae02167649a0b97378e44ef7b588
Diffstat (limited to 'logd/LogBuffer.cpp')
-rw-r--r--logd/LogBuffer.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/logd/LogBuffer.cpp b/logd/LogBuffer.cpp
index 80fc9f5..4373e2a 100644
--- a/logd/LogBuffer.cpp
+++ b/logd/LogBuffer.cpp
@@ -281,7 +281,8 @@ public:
}
void clear(LogBufferElement *e) {
- uint64_t current = e->getRealTime().nsec() - NS_PER_SEC;
+ uint64_t current = e->getRealTime().nsec()
+ - (EXPIRE_RATELIMIT * NS_PER_SEC);
for(LogBufferElementMap::iterator it = map.begin(); it != map.end();) {
LogBufferElement *l = it->second;
if ((l->getDropped() >= EXPIRE_THRESHOLD)