summaryrefslogtreecommitdiffstats
path: root/libsysutils
Commit message (Collapse)AuthorAgeFilesLines
* Fix formatting in 4df4dfedf6beef891d05d4e80704f5f4a594a885.Elliott Hughes2014-11-101-1/+2
| | | | Change-Id: I1ad219285cb1f4a39cfe2bdef224b78eff843317
* When new error happend,then errno should be updated accordingly.Bo Huang2014-11-101-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise, need to keep previous errno. Reproduced steps: pre-condition: DUT support external SDcard or Usb mass storage; 1. Insert blank(no partition) SDcard or UMS to DUT; Expected result: Should prompt user with storage error. Test result: There is no notification for error. Error log: 01-01 01:06:49.239 I/fsck_msdos( 200): fsck_msdos terminated by exit(8) 01-01 01:06:49.239 E/Vold ( 200): /dev/block/vold/179:16 failed FS checks (I/O error) 01-01 01:06:49.239 D/Vold ( 200): Volume sdcard1 state changing 3 (Checking) -> 1 (Idle-Unmounted) 01-01 01:06:49.239 W/Vold ( 200): Returning OperationFailed - no handler for errno 0) Root cause analysis: 1.Volume::setState will call senBroadcase to send out state notification; 2.Finally, SocketClient::sendDataLockedv was called to sent message. In sendDataLockedv funtion, when current == iovcnt, e is 0 by default. So Vold get incorrect errno. Change-Id: Icb32a4193f02f22b5e3feaba177bc278f8f1f41b Signed-off-by: Bo Huang <bo.b.huang@intel.com>
* Support parsing netlink route messages.Lorenzo Colitti2014-06-211-0/+99
| | | | | Bug: 9180552 Change-Id: I4a36d869ac692647fb226d0912285bdf2ffcb1fa
* Improvements to netlink event parsing.Lorenzo Colitti2014-06-212-107/+157
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Accept that parseNetlinkMessage can only parse one netlink message, because its way of returning output is to modify its member variables (mAction, mParams, etc.). Currently, it loops through all the messages it finds, updating its member variables as it goes along, and always returns true at the end of the buffer. This has the following problems: 1. Since the function always returns true even when no messages were parsed, the caller has no way to know if parsing succeeded, and we get lots of "No subsystem found in netlink event" logs if the buffer did not contain any valid messages we were interested in. 2. If there are multiple messages in the buffer, all but the last message will be silently ignored. 3. If there are multiple messages and previous messages have more parameters than the last one, the resulting event will have a mixture of parameters from multiple messages. Instead of doing all this, change the contract to "parse the first valid message of interest in the buffer and return true, or return false if there were no such messages", and update the code and the comments accordingly. 2. Modify the caller (NetlinkListener) so it doesn't log an error when parseBinaryNetlinkMessage returns false, because this can now simply mean that we weren't interested in that particular message. parseBinaryNetlinkMessage already logs more informative errors. 3. Provide utility functions to check received message lengths and to convert message types to message names. 4. Simplify logging duplicate attributes. 5. Use the appropriate IFLA_xxx macros instead of rolling our own code to parse link state messages. 6. Move all the parsing code out to per-message-type parsing functions to order to simplify parseBinaryNetlinkMessage. Bug: 9180552 Change-Id: I6bbc2f7a104f618674dde2369c1fd5e93ea49430
* libsysutil: turn on -Werror (part deux)Mark Salyzyn2014-05-012-5/+4
| | | | | | - x86_64 format warnings Change-Id: I81c2702f564bcada946f6a10f34bbf34c90f766b
* libsysutil: turn off -WerrorMark Salyzyn2014-04-301-1/+1
| | | | | | temporary to work out issue with git_mirror-asop-master build Change-Id: Ie65c65abb0a70dc134fded15db8b9d98e1701edd
* libsysutils: turn on -WerrorMark Salyzyn2014-04-303-4/+2
| | | | | | - Deal with some -Wunused / -Wunused-variable issues Change-Id: I428a0032a8743c68c97f528d5f305ba63fee1d29
* Add prefx to netlink failure and dispatchCommand overflow logs.William Luh2014-04-291-2/+2
| | | | | | | | | Prefix ensures proper user-consent filter. (cherry picked from commit 564244cd3809aee58c7e18114970bb88bce9e9e9) Bug:5848002 Change-Id: Iee7287773f0af52c225a821ee0e9d643c83cc060
* logd: libsysutils: logd startup outside init environmentMark Salyzyn2014-04-171-0/+5
| | | | Change-Id: I3426b6c3eebdd0c8258e966dcaaaa2825d7a23d1
* set /proc/sys/net/unix/max_dgram_qlen to large valueMark Salyzyn2014-03-031-1/+5
| | | | | | | | - init: set /proc/sys/net/unix/max_dgram_qlen to 300 - libsysutils: Add listen backlog argument to startListener - logd: set listen backlog to 300 Change-Id: Id6d37d6c937ba2d221e76258d89c9516619caeec
* libsysutil: frequent native crash /system/bin/voldMark Salyzyn2014-01-311-12/+24
| | | | | | | | | | | | regression from commit a6e965578e44f9ae5f98de822ba5decec381dffc * wrap writev with sigaction SIG_IGN SIGPIPE to emulate the send(,,,MSG_NOSIGNAL) call it had replaced. (cherry pick from commit 83fc720785c4e40f3341daf7c0bf5ee99261fee9) BUG: 12796279 Change-Id: I14363630ada79c0a5b85bb6b2afd0a1c4d5c3109
* libsysutils: SocketListener export releaseMark Salyzyn2014-01-271-26/+50
| | | | | | | | | | | | * Foreground thread (legacy) closes connection by reporting false return value for onDataAvailable. * Background thread can choose instead to close the connection asynchronously by calling release, must return true for the onDataAvailable method. (cherry picked from commit d7ad4e409eaac53db3a9789060097b712850b337) Change-Id: I70ab37d5c22b02804aa3b4dfb26cc9b75291f8b6
* libsysutils: Add iovec/runOnEachSocketMark Salyzyn2014-01-272-23/+89
| | | | | | | | | | | | | | | | | | | | SocketClient: * Replace sendDataLocked with sendDataLockedv which takes an iovec. * Add a version of sendData, sendDatav, which takes an iovec. * do not preserve iovec content through sendDatav SocketListener: * Add runOnEachSocket, which allows to to specify a SocketClientCommand to run individually on each socket. This allows you to do broadcast-like actions customized for each individual socket. * Client safe list reference counting for sendBroadcast & runOnEach Socket (cherry picked from commit a6e965578e44f8ae5f98de822ba5decec381d5fc) Signed-off-by: Nick Kralevich <nnk@google.com> Signed-off-by: Mark Salyzyn <salyzyn@google.com> Change-Id: I716f89c01b4cb7af900045c7e41fac1492defb06
* libsysutils: Get rid of warningsMark Salyzyn2014-01-273-4/+7
| | | | | | | | | - UNUSED argument warnings - Remove LOG_NDEBUG define (cherry picked from commit 696f267ff5a1e6227c2f5784dae60c190e0228b8) Change-Id: I48b0942adfdb7a46a7693e580bc6ed5a685b0d5b
* system/core: remove $(KERNEL_HEADERS) from includesColin Cross2014-01-221-1/+1
| | | | | | | | The kernel headers are already in the include path, and manually adding them again will break on a multiarch build, where the kernel headers may be different for each arch. Change-Id: Ib13d96543f2c97b1b487a46e1748ceb2c5724169
* Merge commit '536dea9d61a032e64bbe584a97463c6638ead009' into HEADThe Android Open Source Project2013-11-221-0/+1
|\ | | | | | | Change-Id: I5c469a4b738629d99d721cad7ded02d6c35f56d5
| * Switch back to subsystem "net" for netlink events.Lorenzo Colitti2013-09-031-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | The change to enable address tracking via netlink incorrectly changed the subsystem of rtnetlink events from "net" to "interface". This broke interface add/delete notifications, which come from the kernel with subsystem "net". Switch back to "net" and deal with address tracking via new action codes instead of a new subsystem. Bug: 10433320 Change-Id: Ibf30efb426949dfd02304cc1d9adb1c005a539a6
| * Get rid of an infinite loop in NetlinkEvent.cpp.Lorenzo Colitti2013-08-171-8/+7
| | | | | | | | | | | | | | Bug: 10358527 Bug: 10263310 Bug: 10232006 Change-Id: I750e4bdf2000040adf214d6a772591d7bd25b350
| * Parse IP address changes in NetlinkEvent.Lorenzo Colitti2013-08-141-1/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | This adds support for parsing RTM_NEWADDR and RTM_DELADDR netlink messages received on netd's netlink socket and formatting them them so NetlinkHandler can process them. Address changes are notified in subsystem "address". Interface changes, which used to be notified in subsystem "net", are now notified in subsystem "interface" to avoid confusion. Bug: 10232006 Change-Id: I93a50e8de17014e118a42f5cc0eb90a0cbfa73cc
* | Support parsing RDNSS ND options from netlink.Lorenzo Colitti2013-11-201-4/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The RDNSS options (RFC 6106) used to configure DNS servers via router advertisements are passed from the kernel to userspace via RTM_NEWNDUSEROPT netlink messages. Add code to NetlinkEvent to parse them. Also fix a compiler warning and a couple of style issues. [Cherry-pick of b185e90dcc6ac111bff908edcc6d89fd6b37dc11] Bug: 9180552 Change-Id: I6c532c8f0ceef3afdc977a431a036df398013e1a
* | Switch back to subsystem "net" for netlink events.Lorenzo Colitti2013-11-201-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The change to enable address tracking via netlink incorrectly changed the subsystem of rtnetlink events from "net" to "interface". This broke interface add/delete notifications, which come from the kernel with subsystem "net". Switch back to "net" and deal with address tracking via new action codes instead of a new subsystem. [Cherry-pick of f34861346d5c207912075fba9874090e4c947869] Bug: 10433320 Change-Id: Ibf30efb426949dfd02304cc1d9adb1c005a539a6
* | Get rid of an infinite loop in NetlinkEvent.cpp.Lorenzo Colitti2013-11-201-8/+7
| | | | | | | | | | | | | | | | | | [Cherry-pick of 3984276ce47c965ad02a522280a139e0a0c7e5cf] Bug: 10358527 Bug: 10263310 Bug: 10232006 Change-Id: I750e4bdf2000040adf214d6a772591d7bd25b350
* | Parse IP address changes in NetlinkEvent.Lorenzo Colitti2013-11-201-1/+116
|/ | | | | | | | | | | | | | | This adds support for parsing RTM_NEWADDR and RTM_DELADDR netlink messages received on netd's netlink socket and formatting them them so NetlinkHandler can process them. Address changes are notified in subsystem "address". Interface changes, which used to be notified in subsystem "net", are now notified in subsystem "interface" to avoid confusion. [Cherry-pick of a4b4e9ad8e35ab424e61d76ebe6654445fc61e63] Bug: 10232006 Change-Id: I93a50e8de17014e118a42f5cc0eb90a0cbfa73cc
* am 51a2e4d5: Merge "libsysutils: fix null pointer and memory leak issue"Colin Cross2013-05-211-1/+8
|\ | | | | | | | | * commit '51a2e4d5d44a6f788da207dff301356e16b4e283': libsysutils: fix null pointer and memory leak issue
| * libsysutils: fix null pointer and memory leak issueHong-Mei Li2013-05-201-1/+8
| | | | | | | | | | | | | | | | | | In SocketClient::quoteArg function 1. Fix potential null pointer accessing issue 2. Fix potential memory leak introduced by realloc fail Change-Id: I1ca0f9089290d43452e9a71428244545f4ed866b Signed-off-by: Hong-Mei Li <a21834@motorola.com>
* | Add liblogYing Wang2013-04-091-3/+3
|/ | | | | Bug: 8580410 Change-Id: Iab3a9b4307f207c14a04a922cc7350c54e60e9ad
* libsysutils: Increase command buffersize and command argsJosef Kindberg2012-11-121-3/+7
| | | | | | | Needed to support tethering of multiple remote Bluetooth devices. Change-Id: I9f736affd83226e8b2fa4f0faacd3654175dd8c9 Signed-off-by: Patrik Ryd <patrik.ryd@stericsson.com>
* am 7bb1b958: am ff856a2b: Merge "Add error handling to SocketClient::sendData"Robert Greenwalt2012-05-301-5/+5
|\ | | | | | | | | * commit '7bb1b9585d2d61beaf05c997971aee27f87ad3f7': Add error handling to SocketClient::sendData
| * Add error handling to SocketClient::sendDataMattias Falk2012-05-291-5/+5
| | | | | | | | | | | | Return failure and set errno if mSocket isn't valid. Change-Id: I579114d435db46d0bb5682167ef34bebe061a8f8
* | Revert "libsysutils: NetlinkEvent: add support for interface xt_IDLETIMER ↵JP Abgrall2012-04-261-13/+1
| | | | | | | | | | | | | | | | | | events." This reverts commit 731d831e91d5d9f8b15ca95367977abe35967166. Now that the xt_IDLETIMER uses the KOBJECT_UEVENT netlink, this change is not needed anymore.
* | Add ability to quote responses as needed.Robert Greenwalt2012-04-201-0/+23
| | | | | | | | | | | | | | | | It's up to the protocol to know when quotes are required. In the future the response should probably all be binary blobs with lengths. bug:6353048 Change-Id: I3f9b48ab0f4e6746d75cdc9c0c84d33f38f63661
* | libsysutils: NetlinkEvent: add support for interface xt_IDLETIMER events.Ashish Sharma2012-04-111-1/+13
| | | | | | | | | | | | | | xt_IDLETIMER events are used to infer the interface (radio) state based on a inactivity timeout value. Change-Id: I755eb54a048ca1c6ce0c646564d61188d8241851
* | Added netlink failure logging to NetlinkListener.cppGeremy Condra2012-03-292-1/+6
| | | | | | | | | | | | This depends on If2f00708a1dd6196c415b1ebc2a7eeb72399a90e Change-Id: If6c63e46f906b94f4778eb5e78123d8efe1710d4
* | Do not generate SIGPIPE errors in SocketCLient.Selim Gurun2012-03-121-1/+1
| | | | | | | | | | | | | | This change is to make sure the users of library does not crash if they are not handling SIGPIPE properly. Change-Id: I4ea80d6bfc26a4bca6b901959ae3060b059d46d3
* | Fix pointer arith.Robert Greenwalt2012-03-091-8/+8
| | | | | | | | | | | | | | | | | | Sending 3digit code, null, binary-length and data. Current code sends 3digit code, space, null, binary-length, binary-data. The space should not be sent. Change-Id: I1df00a3e70805b39b6105966c7f3c613461a6858
* | Add a utility function to send a code + binary msgSelim Gurun2012-03-071-4/+39
| | | | | | | | | | | | | | | | | | Add a utility function to SocketClient to send a c-string code prepended to a binary message. This is necessary to be able to send a binary message while keeping compatible with underlying text-based protocol. Change-Id: Ifc6562003a687577d7deb50260533a5147ae4f97
* | New NativeDaemonConnector protocol adds a seqnum.Robert Greenwalt2012-03-053-49/+93
| | | | | | | | | | | | | | | | | | | | Allows for one socket to be multiplexed for multiple requests. Doesn't use command sequence numbers for broadcasts - would make no sense. Doesn't alter current default behavior so OEM's using these classes won't notice a difference. bug:5864209 Change-Id: Ie3b19c4f81eea868569229a365c8cb7de249c2dd
* | Revert "New NativeDaemonConnector protocol adds a seqnum."Guang Zhu2012-02-073-45/+21
| | | | | | | | | | | | | | | | Reverting because it seems to break `adb reboot` This reverts commit dc58e73071aa829a5038caf37211f6b3e2d7b275. Change-Id: Ib8cc4379254694398cbb7f3e7a64c20e1ed8c1ba
* | New NativeDaemonConnector protocol adds a seqnum.Robert Greenwalt2012-02-073-21/+45
| | | | | | | | | | | | | | Allows for one socket to be multiplexed for multiple requests. bug:5864209 Change-Id: I934c88da25d95e093371f455442bdf2f0ed7a4f4
* | libsysutils: log dispatchCommand overflow.Nick Kralevich2011-11-183-0/+6
|/ | | | Change-Id: Iefd3f7cc170c1fe65209c6ffe10debc21aed0c7f
* Remove log spamIrfan Sheriff2011-10-281-1/+0
| | | | | Bug: 5533986 Change-Id: I3d8108e2f65ce6513ac8b2d14541eaa5e4fc5da1
* Fix SocketListener socket leak issue.Xianzhu Wang2011-09-292-9/+13
| | | | | | | | | | | | The problem was: if a socket is shared between SocketListener and another thread, only if the last reference is removed by SocketListener can the socket be closed, otherwise the socket will leak. This sometimes happens in netd's dnsproxyd. This change let the SocketClient own the socket and close the socket when the SocketClient is destructed. Change-Id: I2865fbfe9ee4d8b3e43d7e02919dbb2d261f70de
* NetlinkEvents: adding support for iptables' quota2 NFLOG messages.JP Abgrall2011-07-141-25/+54
| | | | | | | | | | | It passes the quota2 name and the device at the time the quota was reached. ALERT_NAME=... INTERFACE=... This needs the new kernel in which xt_quota2 can log. Change-Id: Icf5045374e1e33bdd1da0d2a2c183e70903a1fea
* Remove the simulator target from all makefiles.Jeff Brown2011-07-111-11/+0
| | | | | | Bug: 5010576 Change-Id: I2fcf31af681d92880e5d31a46d5f6777f7ca1977
* Workaround Motorola ril.so incompatiblity with Netlink changesMike J. Chen2011-06-231-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | To workaround a binary incompatiblity with Motorola's ril.so, I had to temporarily provide the old constructor for NetlinkListener as well as a new contructor that takes an additional format argument. There's still a slight chance of a problem because the size of the NetlinkListener has changed with the addition of the mFormat member, but so far I've not seen any obvious problem with that incompatiblity. Another way we could have worked around the incompatiblity is to have netd (the main user of the new format argument to NetlinkListener) keep track of the format itself in it's NetlinkHandler (derived from NetlinkListener) and supply it's own version of onDataAvailable() that's almost 100% identical to NetlinkListener's except for the decode() call. That would allow us not to modify NetlinkListener at all. Worth considering but I think it's more properly divided right now and we just have to make Motorola fix their code (and ideally not use our private APIs). This change should be reverted when Motorola's has fixed their ril to either not use our private APIs or to use our updated ones. Change-Id: I255cca6908444e56cbbbed7eef1fa0cf1d8f0918 Signed-off-by: Mike J. Chen <mjchen@google.com>
* Cleanup NetlinkListener and NetlinkEventMike J. Chen2011-06-232-15/+10
| | | | | | | | | | | | | To make it easier to be compatible with older existing code, use default parameters instead of separate functions for setting. Also, reintroduce the const usage that was not in the original changes by Stan. Also fix some indent spacing. Change-Id: Ice9ec7f0d5c4a0673037e2e04a764d88a98f68eb Signed-off-by: Mike J. Chen <mjchen@google.com>
* Revert "Revert "Add NETLINK_ROUTE processing to the netlink client code, so ↵Mike J. Chen2011-06-232-8/+75
| | | | | | | | | | | | | | | | | | | | | | | | that Ethernet"" This reverts commit 1d504eeb50d980c222572629383bb76315f32ca0. Conflicts: libsysutils/src/NetlinkEvent.cpp Bring back the changes from Stan Chesnutt regarding adding NETLINK_ROUTE processing. The original commit message description was: Add NETLINK_ROUTE processing to the netlink client code, so that Ethernet physical-layer up/down events can be tracked. Upper layers will use these events to enable/disable Ethernet connectivity. The original change was reverted due to an incompatiblity with Motorola's ril.so binary. I'll submit a patch to workaround that incompatiblity separately. Change-Id: I4e97ac98833b10543e654c63ecae3b9b8c7db44f Signed-off-by: Mike J. Chen <mjchen@google.com>
* rename uevent_checked_recv to uevent_kernel_multicast_recvNick Kralevich2011-05-111-1/+1
| | | | Change-Id: I1839627490080efcbb7269699709064856312f8b
* NetlinkListener: eliminate duplicate codeNick Kralevich2011-04-291-23/+2
| | | | | | | The checks in this code duplicate uevent_checked_recv(). Use that instead. Change-Id: I2c48bcf4372f0975c27a63d929cae73e16422faf
* am 18f6d964: am f819d023: Merge "libsysutils: SocketListener: handle recv ↵Nick Kralevich2011-04-271-2/+3
|\ | | | | | | | | | | | | errors more gracefully." * commit '18f6d964cbee483106da5c96a8c067a948324da7': libsysutils: SocketListener: handle recv errors more gracefully.
generated by cgit v1.1 at 2024-07-08 02:40:54 +0000