diff options
| author | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2009-12-03 01:49:56 +0000 |
|---|---|---|
| committer | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2009-12-03 01:49:56 +0000 |
| commit | 26f2fb73faa4634ef52b931f6581f127c79bc2f2 (patch) | |
| tree | 153665bdacd141fe6f21f3a950a5eb691c6247b6 /lib/CodeGen/PostRASchedulerList.cpp | |
| parent | 5c17063f8a9795289eee9454110f066e225a72bd (diff) | |
| download | external_llvm-26f2fb73faa4634ef52b931f6581f127c79bc2f2.zip external_llvm-26f2fb73faa4634ef52b931f6581f127c79bc2f2.tar.gz external_llvm-26f2fb73faa4634ef52b931f6581f127c79bc2f2.tar.bz2 | |
Don't hang on to pointers or references after vector::push_back.
The MO reference to a MachineOperand can be invalidated by
MachineInstr::addOperand. Don't even use it for debugging.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@90381 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/PostRASchedulerList.cpp')
| -rw-r--r-- | lib/CodeGen/PostRASchedulerList.cpp | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/lib/CodeGen/PostRASchedulerList.cpp b/lib/CodeGen/PostRASchedulerList.cpp index 9101fce..6995e9d 100644 --- a/lib/CodeGen/PostRASchedulerList.cpp +++ b/lib/CodeGen/PostRASchedulerList.cpp @@ -510,12 +510,9 @@ void SchedulePostRATDList::FixupKills(MachineBasicBlock *MBB) { } if (MO.isKill() != kill) { - bool removed = ToggleKillFlag(MI, MO); - if (removed) { - DEBUG(errs() << "Fixed <removed> in "); - } else { - DEBUG(errs() << "Fixed " << MO << " in "); - } + DEBUG(errs() << "Fixing " << MO << " in "); + // Warning: ToggleKillFlag may invalidate MO. + ToggleKillFlag(MI, MO); DEBUG(MI->dump()); } |