diff options
author | John Reck <jreck@google.com> | 2010-11-04 12:00:17 -0700 |
---|---|---|
committer | John Reck <jreck@google.com> | 2010-11-09 11:35:04 -0800 |
commit | e14391e94c850b8bd03680c23b38978db68687a8 (patch) | |
tree | 3fed87e6620fecaf3edc7259ae58a11662bedcb2 /WebCore/ChangeLog | |
parent | 1bd705833a68f07850cf7e204b26f8d328d16951 (diff) | |
download | external_webkit-e14391e94c850b8bd03680c23b38978db68687a8.zip external_webkit-e14391e94c850b8bd03680c23b38978db68687a8.tar.gz external_webkit-e14391e94c850b8bd03680c23b38978db68687a8.tar.bz2 |
Merge Webkit at r70949: Initial merge by git.
Change-Id: I77b8645c083b5d0da8dba73ed01d4014aab9848e
Diffstat (limited to 'WebCore/ChangeLog')
-rw-r--r-- | WebCore/ChangeLog | 6987 |
1 files changed, 6986 insertions, 1 deletions
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index 83f63cc..44714b7 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,3 +1,6988 @@ +2010-10-29 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Darin Adler. + + Remove RenderTextControl::setSelectionRange + https://bugs.webkit.org/show_bug.cgi?id=47870 + + Made RenderTextControl::setSelectionRange a global function. + Removed setSelectionStart, setSelectionEnd, and select from RenderTextControl. + + No new tests are added since there is no behavioral change. + + * accessibility/AccessibilityRenderObject.cpp: + (WebCore::AccessibilityRenderObject::setSelectedTextRange): Calls setSelectedTextRange. + * dom/InputElement.cpp: + (WebCore::InputElement::updateSelectionRange): Ditto. + * html/HTMLFormControlElement.cpp: + (WebCore::HTMLTextFormControlElement::setSelectionStart): Ditto. + (WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto. + (WebCore::HTMLTextFormControlElement::select): Ditto. + (WebCore::HTMLTextFormControlElement::setSelectionRange): Ditto. + * rendering/RenderTextControl.cpp: + (WebCore::RenderTextControl::hasVisibleTextArea): Added. + (WebCore::setSelectionRange): See above. + * rendering/RenderTextControl.h: + +2010-10-29 Carlos Garcia Campos <cgarcia@igalia.com> + + Reviewed by Andreas Kling. + + [GTK] Crash in TextEncoding.cpp when using glib unicode + https://bugs.webkit.org/show_bug.cgi?id=48521 + + When the conversion to UTF-8 fails, try to encode the original string + without normalizing. Fixes tests cases: + fast/url/anchor.html + fast/url/query.html + fast/url/standard-url.html + + * platform/text/TextEncoding.cpp: + (WebCore::TextEncoding::encode): + +2010-10-29 Benjamin Poulain <benjamin.poulain@nokia.com> + + Reviewed by Antonio Gomes. + + TextureMapperGL get the driver info log but do not use it + https://bugs.webkit.org/show_bug.cgi?id=48247 + + Remove the call to glGetProgramInfoLog(). + + * platform/graphics/opengl/TextureMapperGL.cpp: + (WebCore::TexmapShaderInfo::createShaderProgram): + +2010-10-29 Benjamin Kalman <kalman@google.com> + + Reviewed by Tony Chang. + + Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder <br/> + https://bugs.webkit.org/show_bug.cgi?id=48658 + + * WebCore.exp.in: Update is{Start,End}OfParagraph symbols. + * editing/DeleteSelectionCommand.cpp: + (WebCore::DeleteSelectionCommand::doApply): Cross editability boundaries when determining whether to insert placeholder. + * editing/visible_units.cpp: Allow editability boundary to be crossed in {start,end,isStart,isEnd}OfParagraph. + (WebCore::startOfParagraph): Also, avoid returning a position where renderer can't accept caret, like in endOfParagraph. + (WebCore::endOfParagraph): + (WebCore::isStartOfParagraph): + (WebCore::isEndOfParagraph): + * editing/visible_units.h: Ditto. + +2010-10-29 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: last active panel is not restored upon opening inspector. + https://bugs.webkit.org/show_bug.cgi?id=48668 + + * inspector/Inspector.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::InspectorController): + (WebCore::InspectorController::inspect): + (WebCore::InspectorController::showPanel): + (WebCore::InspectorController::disconnectFrontend): + (WebCore::InspectorController::populateScriptObjects): + * inspector/InspectorController.h: + * inspector/InspectorState.cpp: + (WebCore::InspectorState::InspectorState): + * inspector/front-end/Settings.js: + (WebInspector.Settings): + * inspector/front-end/inspector.js: + (WebInspector.set currentPanel): + (WebInspector.doLoadedDone.onPopulateScriptObjects): + (WebInspector.doLoadedDone): + (WebInspector.documentClick.followLink): + (WebInspector.documentClick): + +2010-10-28 Michael Nordman <michaeln@google.com> + + Reviewed by ap. + + [Chrome] Fix an appcache regression introduced in r69226 + https://bugs.webkit.org/show_bug.cgi?id=48592 + Define a new ApplicationCacheHost method for the specific case of main resource redirect handling. + + Tests: the existing layout test applies + + * loader/MainResourceLoader.cpp: use the newly introduced method + (WebCore::MainResourceLoader::willSendRequest): + * loader/appcache/ApplicationCacheHost.cpp: + (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect): + * loader/appcache/ApplicationCacheHost.h: + +2010-10-29 Eric Carlson <eric.carlson@apple.com> + + Reviewed by Adam Roben. + + Navigating to a .wav file creates a plugin document but should create a media document + https://bugs.webkit.org/show_bug.cgi?id=48546 + <rdar://problem/8606105> + + Test: media/media-can-play-wav-audio.html + + * platform/MIMETypeRegistry.cpp: Add mapping from ".wav" to "audio/x-wav". + +2010-10-29 Aaron Colwell <acolwell@chromium.org> + + Reviewed by James Robinson. + + Created helper method WebCore::PlatformContextSkia::getNormalizedAlpha() + to centralize alpha rounding & clipping logic. + https://bugs.webkit.org/show_bug.cgi?id=48094 + + Test: media/video-canvas-alpha.html + + * platform/graphics/skia/ImageSkia.cpp: + (WebCore::paintSkBitmap): + * platform/graphics/skia/PlatformContextSkia.cpp: + (WebCore::PlatformContextSkia::getNormalizedAlpha): + * platform/graphics/skia/PlatformContextSkia.h: + +2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Dirk Schulze. + + ASSERT when SVGAnimatedProperty instance is assigned to multiple elements. + https://bugs.webkit.org/show_bug.cgi?id=48555 + + Test: svg/custom/insertItemBefore-from-non-list-origin.svg + + * bindings/scripts/CodeGeneratorJS.pm: Include SVGAnimatedPropertyTearOff.h instead of SVGPropertyTearOff.h + * bindings/scripts/CodeGeneratorObjC.pm: Ditto. + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + * svg/properties/SVGAnimatedListPropertyTearOff.h: + (WebCore::SVGAnimatedListPropertyTearOff::isAnimatedListTearOff): Return true. + (WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList): Devirtualize function. + * svg/properties/SVGAnimatedProperty.h: + (WebCore::SVGAnimatedProperty::isAnimatedListTearOff): Return false. + * svg/properties/SVGListPropertyTearOff.h: + (WebCore::SVGListPropertyTearOff::removeItemFromListIfNeeded): Only try to remove the passed item from its list, if its actually a list and not just a SVGAnimatedProperty. + +2010-10-29 David Hyatt <hyatt@apple.com> + + Reviewed by Adam Roben. + + https://bugs.webkit.org/show_bug.cgi?id=48444 + + Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox, InlineTextBox. They were still assuming horizontal-tb writing-mode. + This patch makes the checks directionally abstract and also refactors the checks in RenderLineBoxList to share code. + + No tests yet, since the invalidation code for inlines still assumes horizontal-tb. That will be fixed in a follow-up bug, + and then repaint tests will be easy to write. + + * rendering/InlineBox.cpp: + (WebCore::InlineBox::adjustForFlippedBlocksWritingMode): + * rendering/InlineBox.h: + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::paint): + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::paint): + * rendering/RenderBox.cpp: + (WebCore::RenderBox::convertFromFlippedWritingMode): + * rendering/RenderBox.h: + * rendering/RenderLineBoxList.cpp: + (WebCore::RenderLineBoxList::rangeIntersectsDirtyRect): + (WebCore::RenderLineBoxList::anyLineIntersectsDirtyRect): + (WebCore::RenderLineBoxList::lineIntersectsDirtyRect): + (WebCore::RenderLineBoxList::paint): + (WebCore::RenderLineBoxList::hitTest): + * rendering/RenderLineBoxList.h: + +2010-10-29 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Roben. + + Cleanup createGlobalImageFileDescriptor in ClipboardWin + https://bugs.webkit.org/show_bug.cgi?id=48189 + + * platform/win/ClipboardWin.cpp: + (WebCore::createGlobalURLContent): + (WebCore::createGlobalUrlFileDescriptor): + (WebCore::ClipboardWin::writeURL): + +2010-10-29 Dmitry Titov <dimich@chromium.org> + + [Chromium clang] Unreviewed fix removing compiler warning. + If GIFImageReader is a struct, don't call it a class. + + * platform/image-decoders/gif/GIFImageDecoder.h: + +2010-10-29 Alexey Proskuryakov <ap@apple.com> + + Fix the world (d'oh!) + + https://bugs.webkit.org/show_bug.cgi?id=48576 + Let WebKit2 client know when a frame is a frameset + + * html/HTMLFrameSetElement.cpp: + (WebCore::HTMLFrameSetElement::insertedIntoDocument): + (WebCore::HTMLFrameSetElement::removedFromDocument): + Call base class version. + +2010-10-29 Jian Li <jianli@chromium.org> + + Unreviewed. Fix chromium build break. + + * bindings/v8/custom/V8FileReaderCustom.cpp: + (WebCore::V8FileReader::resultAccessorGetter): + +2010-10-29 Jian Li <jianli@chromium.org> + + Reviewed by David Levin. + + Support readAsArrayBuffer in FileReader and FileReaderSync + https://bugs.webkit.org/show_bug.cgi?id=47691 + + Merge the similar code in FileReader and FileReaderSync into + FileReaderLoader. + + Test cases have been added to read-file-test-cases.js. + + * Android.jscbindings.mk: + * CMakeLists.txt: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/v8/custom/V8FileReaderCustom.cpp: Added. + * fileapi/FileReader.cpp: + (WebCore::FileReader::FileReader): + (WebCore::FileReader::readAsArrayBuffer): + (WebCore::FileReader::readAsBinaryString): + (WebCore::FileReader::readAsText): + (WebCore::FileReader::readAsDataURL): + (WebCore::FileReader::readInternal): + (WebCore::FileReader::doAbort): + (WebCore::FileReader::terminate): + (WebCore::FileReader::start): + (WebCore::FileReader::didStartLoading): + (WebCore::FileReader::didReceiveData): + (WebCore::FileReader::didFinishLoading): + (WebCore::FileReader::didFail): + (WebCore::FileReader::fireEvent): + (WebCore::FileReader::arrayBufferResult): + (WebCore::FileReader::stringResult): + * fileapi/FileReader.h: + (WebCore::FileReader::readType): + * fileapi/FileReader.idl: + * fileapi/FileReaderLoader.cpp: Added. + * fileapi/FileReaderLoader.h: Added. + * fileapi/FileReaderLoaderClient.h: Added. + * fileapi/FileReaderSync.cpp: + (WebCore::FileReaderSync::FileReaderSync): + (WebCore::FileReaderSync::readAsArrayBuffer): + (WebCore::FileReaderSync::readAsBinaryString): + (WebCore::FileReaderSync::readAsText): + (WebCore::FileReaderSync::readAsDataURL): + (WebCore::FileReaderSync::startLoading): + * fileapi/FileReaderSync.h: + * fileapi/FileReaderSync.idl: + * html/canvas/ArrayBuffer.cpp: + (WebCore::ArrayBuffer::create): + * html/canvas/ArrayBuffer.h: + * loader/ThreadableLoaderClient.h: + +2010-10-29 Tony Chang <tony@chromium.org> + + Unreviewed, rolling out r70850. + http://trac.webkit.org/changeset/70850 + https://bugs.webkit.org/show_bug.cgi?id=45640 + + chromium and qt pixel test regressions + + * dom/Document.cpp: + * dom/Document.h: + * page/FrameView.cpp: + (WebCore::FrameView::invalidateRect): + (WebCore::FrameView::repaintContentRectangle): + (WebCore::FrameView::doDeferredRepaints): + * page/FrameView.h: + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::paintContents): + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::paintLayer): + +2010-10-29 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=48576 + Let WebKit2 client know when a frame is a frameset + + This can change in two cases, when document changes, and when frame is navigated to another + document. + + * dom/Document.cpp: (WebCore::Document::documentDidBecomeActive): Update the client when + a document is restored from page cache. + + * loader/FrameLoaderClient.h: Added a new client call to notify client. + + * html/HTMLFrameSetElement.h: + * html/HTMLFrameSetElement.cpp: + (WebCore::HTMLFrameSetElement::insertedIntoDocument): + (WebCore::HTMLFrameSetElement::removedFromDocument): + Update the client when document changes, potentially becoming a frameset. Per WebCore + definition, a document is a frameset when it has a FRAMESET element as direct child of + document element (it may also have body elements). + + * loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidBecomeFrameset): + Added an empty implementation. + +2010-10-29 Csaba Osztrogonác <ossy@webkit.org> + + Unreviewed fix. Touch WebCorePrefix.h to fix incremental build failure after r70878. + + * WebCorePrefix.h: + +2010-10-29 Carlos Garcia Campos <cgarcia@igalia.com> + + Reviewed by Martin Robinson. + + [GTK] Handle surrogate pairs in TextBreakIteratorGtk + https://bugs.webkit.org/show_bug.cgi?id=48227 + + TextBreakIteratorGtk uses UTF-8 because it's what pango expects, but we + need to return indices for the given input string that are in UTF-16. + The number of characters is the same for both UTF-16 and UTF-8 except when + the input string contains surrogate pairs. We need to keep both, the + index for the UTF-8 string to be used internally, and the index for the + UTF-16 string to be used as return value of the iterator interface. It + fixes test fast/forms/textarea-maxlength.html + + * platform/text/gtk/TextBreakIteratorGtk.cpp: + (WebCore::CharacterIterator::getText): + (WebCore::CharacterIterator::getLength): + (WebCore::CharacterIterator::getSize): + (WebCore::CharacterIterator::getIndex): + (WebCore::CharacterIterator::getUTF16Index): + (WebCore::CharacterIterator::getUTF16Length): + (WebCore::CharacterIterator::characterSize): + (WebCore::CharacterIterator::setText): + (WebCore::CharacterIterator::setIndex): + (WebCore::CharacterIterator::setUTF16Index): + (WebCore::CharacterIterator::first): + (WebCore::CharacterIterator::last): + (WebCore::CharacterIterator::next): + (WebCore::CharacterIterator::previous): + (WebCore::setUpIterator): + (WebCore::textBreakFirst): + (WebCore::textBreakLast): + (WebCore::textBreakNext): + (WebCore::textBreakPrevious): + (WebCore::textBreakPreceding): + (WebCore::textBreakFollowing): + (WebCore::textBreakCurrent): + (WebCore::isTextBreak): + +2010-10-29 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: [REGRESSION] Addition of a new (blank) style property does not work + https://bugs.webkit.org/show_bug.cgi?id=48631 + + Test: inspector/styles-add-blank-property.html + + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): + (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate): + +2010-10-29 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: add close button to network view, make tests pass for + resource manager on all ports. + https://bugs.webkit.org/show_bug.cgi?id=48628 + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::didCommitLoad): + (WebCore::InspectorController::frameDetachedFromParent): + (WebCore::InspectorController::didLoadResourceFromMemoryCache): + (WebCore::InspectorController::identifierForInitialRequest): + (WebCore::InspectorController::willSendRequest): + (WebCore::InspectorController::markResourceAsCached): + (WebCore::InspectorController::didReceiveResponse): + (WebCore::InspectorController::didReceiveContentLength): + (WebCore::InspectorController::didFinishLoading): + (WebCore::InspectorController::didFailLoading): + (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): + (WebCore::InspectorController::scriptImported): + (WebCore::InspectorController::didCreateWebSocket): + (WebCore::InspectorController::willSendWebSocketHandshakeRequest): + (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): + (WebCore::InspectorController::didCloseWebSocket): + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel.prototype.addResourceToFrame): + * inspector/front-end/inspector.js: + (WebInspector._createPanels): + * inspector/front-end/networkPanel.css: + (.network-close-button): + +2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Dirk Schulze. + + Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept + https://bugs.webkit.org/show_bug.cgi?id=48623 + + Besides converting SVGAnimatedEnumeration/Integer to the new animated property tear off concept, fix support + for multiple wrappers within the new concept, which was broken - covered by existing svg/dynamic-updates/ tests. + + Replace all 'extern char[]' usage when using the multiple wrappers macro, by static AtomicStrings. + + * GNUmakefile.am: Add SVGAnimatedEnumeration.h / SVGAnimatedInteger.h to build. + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedEnumeration / SVGAnimatedInteger as animated types using the new concept. + * bindings/scripts/CodeGeneratorObjC.pm: Touched, to force regenerating ObjC bindings, dependency tracking is obviously broken. + * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedBoolean/Enumeration/Integer handling. + * svg/DeprecatedSVGAnimatedTemplate.h: Ditto. + * svg/SVGAnimatedEnumeration.h: Added. + * svg/SVGAnimatedEnumeration.idl: + * svg/SVGAnimatedInteger.h: Added. + * svg/SVGClipPathElement.h: Adapted all code to create new style animated property tear offs for long & int types. + * svg/SVGComponentTransferFunctionElement.h: + * svg/SVGFEBlendElement.h: + * svg/SVGFEColorMatrixElement.h: + * svg/SVGFECompositeElement.h: + * svg/SVGFEConvolveMatrixElement.h: + * svg/SVGFEDiffuseLightingElement.cpp: + (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Replaced extern[] char hack using a static AtomicString. + (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto. + * svg/SVGFEDiffuseLightingElement.h: + * svg/SVGFEDisplacementMapElement.h: + * svg/SVGFEGaussianBlurElement.cpp: + (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Ditto. + (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto. + * svg/SVGFEGaussianBlurElement.h: + * svg/SVGFEMorphologyElement.h: + * svg/SVGFESpecularLightingElement.cpp: + (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Ditto. + (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto. + * svg/SVGFESpecularLightingElement.h: + * svg/SVGFETurbulenceElement.cpp: + (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Ditto. + (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto. + * svg/SVGFETurbulenceElement.h: + * svg/SVGFilterElement.cpp: + (WebCore::SVGFilterElement::filterResXIdentifier): Ditto. + (WebCore::SVGFilterElement::filterResYIdentifier): Ditto. + * svg/SVGFilterElement.h: + * svg/SVGGradientElement.h: + * svg/SVGMarkerElement.cpp: + (WebCore::SVGMarkerElement::orientTypeIdentifier): Ditto. + (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto. + * svg/SVGMarkerElement.h: + * svg/SVGMaskElement.h: + * svg/SVGPatternElement.h: + * svg/SVGTextContentElement.h: + * svg/SVGTextPathElement.h: + * svg/properties/SVGAnimatedPropertyMacros.h: Add new macro for multiple wrappers using static properties. + +2010-10-29 Andreas Kling <kling@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Make GraphicsContext cheaper to construct + https://bugs.webkit.org/show_bug.cgi?id=48626 + + Do less unnecessary things when creating the Qt GraphicsContext: + - Don't create a black QBrush that's immediately discarded. + - Don't call setPlatform*(), set the painter brush and pen directly. + - Call setRenderHints() once instead of multiple setRenderHint(). + + * platform/graphics/qt/GraphicsContextQt.cpp: + (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): + (WebCore::GraphicsContext::GraphicsContext): + +2010-10-29 Andreas Kling <kling@webkit.org> + + Reviewed by Simon Hausmann. + + [Qt] GraphicsLayer: Don't notifySyncRequired() more than necessary + https://bugs.webkit.org/show_bug.cgi?id=48624 + + Don't queue multiple meta method invocations for notifySyncRequired() + + 4% speedup on <http://ariya.github.com/clock.htm> + + * platform/graphics/qt/GraphicsLayerQt.cpp: + (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): + (WebCore::GraphicsLayerQtImpl::notifySyncRequired): + (WebCore::GraphicsLayerQtImpl::notifyChange): + +2010-10-29 Zhenyao Mo <zmo@google.com> + + Reviewed by Chris Marrin. + + drawArrays/drawElements with first/offset out of range but size==0 should generate no error + https://bugs.webkit.org/show_bug.cgi?id=48601 + + * html/canvas/WebGLRenderingContext.cpp: + (WebCore::WebGLRenderingContext::drawArrays): + (WebCore::WebGLRenderingContext::drawElements): + +2010-10-29 Leandro Gracia Gil <leandrogracia@google.com> + + Reviewed by Jeremy Orlow. + + Patch the current speech input implementation to use the nearest + language tag. The language is now passed to the startRecognition + methods so that language-specific recognition could be used. Also added + a second parameter to setMockSpeechInputResult for the language used in + speech recognition. + https://bugs.webkit.org/show_bug.cgi?id=47089 + + This is the 2nd of a 4-sided patch in Chromium and WebKit. For more + details see http://codereview.chromium.org/3615005/show, + http://codereview.chromium.org/3595018/show and + https://bugs.webkit.org/show_bug.cgi?id=47420. + + Test: fast/speech/input-text-language-tag.html + + * page/SpeechInput.cpp: + (WebCore::SpeechInput::startRecognition): + * page/SpeechInput.h: + * page/SpeechInputClient.h: + * platform/mock/SpeechInputClientMock.cpp: + (WebCore::SpeechInputClientMock::startRecognition): + (WebCore::SpeechInputClientMock::setRecognitionResult): + (WebCore::SpeechInputClientMock::timerFired): + * platform/mock/SpeechInputClientMock.h: + * rendering/TextControlInnerElements.cpp: + (WebCore::TextControlInnerElement::attachInnerElement): + (WebCore::SearchFieldCancelButtonElement::detach): + (WebCore::SpinButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::detach): + +2010-10-29 Mads Ager <ager@chromium.org> + + Reviewed by Pavel Feldman. + + [V8] The DateExtension cannot handle overwritten Date + https://bugs.webkit.org/show_bug.cgi?id=48621 + + Check that the Date property is an object before attempting to get + hidden properties from it. + + Test: fast/dom/Window/slow-unload-handler-overwritten-date.html + + * bindings/v8/DateExtension.cpp: + (WebCore::DateExtension::setAllowSleep): + +2010-10-27 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Dirk Schulze. + + Convert SVGAnimatedBoolean to the new SVGAnimatedPropertyTearOff concept + https://bugs.webkit.org/show_bug.cgi?id=48469 + + Convert the next SVG animated primitive type to use the SVGAnimatedPropertyTearOff concept: SVGAnimatedBoolean. + Added new test verifying that StrictTypeChecking is enabled for SVGAnimatedBooleans. It also tests that this type is "static", see LayoutTests/ChangeLog for details. + + Add support for StrictTypeChecking for boolean types. + + Test: svg/dom/SVGExternalResourcesRequired.html + + * GNUmakefile.am: Add SVGAnimatedBoolean.h and SVGAnimatedStaticPropertyTearOff.h to build. + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * bindings/scripts/CodeGenerator.pm: Add SVGAnimatedBoolean to the new style svg animated bindings list. + * bindings/scripts/CodeGeneratorJS.pm: Add StrictTypeChecking support for boolean types. + * bindings/scripts/CodeGeneratorObjC.pm: Ditto. Only generate kit() usage for new style animated types, if the wrapped type needs a tear off. + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + * svg/DeprecatedSVGAnimatedTemplate.h: Remove SVGAnimatedBoolean handling. + * svg/SVGAElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_STATIC_PROPERTY_NEW/ for boolean types everywhere. Include SVGAnimatedPropertyMacros.h where needed. + * svg/SVGAnimatedBoolean.h: Added. + * svg/SVGAnimatedBoolean.idl: + * svg/SVGAnimationElement.h: + * svg/SVGCircleElement.h: + * svg/SVGClipPathElement.h: + * svg/SVGCursorElement.h: + * svg/SVGDefsElement.h: + * svg/SVGEllipseElement.h: + * svg/SVGExternalResourcesRequired.cpp: + * svg/SVGExternalResourcesRequired.h: + (WebCore::SVGExternalResourcesRequired::~SVGExternalResourcesRequired): + * svg/SVGFEConvolveMatrixElement.h: + * svg/SVGFEImageElement.h: + * svg/SVGFilterElement.h: + * svg/SVGFontElement.h: + * svg/SVGForeignObjectElement.h: + * svg/SVGGElement.h: + * svg/SVGGradientElement.h: + * svg/SVGImageElement.h: + * svg/SVGLineElement.h: + * svg/SVGMPathElement.h: + * svg/SVGMarkerElement.h: + * svg/SVGMaskElement.h: + * svg/SVGPathElement.h: + * svg/SVGPatternElement.h: + * svg/SVGPolyElement.h: + * svg/SVGRectElement.h: + * svg/SVGSVGElement.h: + * svg/SVGScriptElement.h: + * svg/SVGSwitchElement.h: + * svg/SVGSymbolElement.h: + * svg/SVGTextContentElement.h: + * svg/SVGUseElement.h: + * svg/SVGViewElement.h: + * svg/properties/SVGAnimatedListPropertyTearOff.h: Moved RefPtr<SVGProperty> m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them. + * svg/properties/SVGAnimatedProperty.h: Remove m_baseVal/m_animVal. + (WebCore::SVGAnimatedProperty::commitChange): New method to share code between the SVGAnimated*PropertyTearOff classes. + * svg/properties/SVGAnimatedPropertyMacros.h: Add new DECLARE_ANIMATED_STATIC_PROPERTY_NEW macro which creates SVGAnimatedStaticPropertyTearOff types. + * svg/properties/SVGAnimatedPropertyTearOff.h: Moved RefPtr<SVGProperty> m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them. + * svg/properties/SVGAnimatedStaticPropertyTearOff.h: Added. + (WebCore::SVGAnimatedStaticPropertyTearOff::baseVal): Directly returns the stored m_property as reference, no tear off is created. + (WebCore::SVGAnimatedStaticPropertyTearOff::animVal): Ditto. + (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Directly updates the stored m_property reference, and invalidates the SVG attributes. + (WebCore::SVGAnimatedStaticPropertyTearOff::setAnimVal): Not implemented. + (WebCore::SVGAnimatedStaticPropertyTearOff::create): + (WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff): + * svg/properties/SVGListPropertyTearOff.h: + (WebCore::SVGListPropertyTearOff::commitChange): Share code, use SVGAnimatedProperty::commitChange. + * svg/properties/SVGPropertyTearOff.h: + (WebCore::SVGPropertyTearOff::commitChange): Ditto. + +2010-10-28 MORITA Hajime <morrita@google.com> + + Reviewed by Kent Tamura. + + <meter min=0 max=100 value=100> should be optimum. + https://bugs.webkit.org/show_bug.cgi?id=48613 + + Changed to make the condition inclusive for better case consistently. + - Values on the border between optimum and subsequntial go optimum. + - Values on the border between suboptimal and even-less-than-good go suboptimal. + + Test: fast/dom/HTMLMeterElement/meter-boundary-values.html + + * html/HTMLMeterElement.cpp: + (WebCore::HTMLMeterElement::gaugeRegion): + +2010-10-29 Kenichi Ishibashi <bashi@google.com> + + Reviewed by Kent Tamura. + + [HTML5] Add DOMSettableTokenList + https://bugs.webkit.org/show_bug.cgi?id=47810 + + Adds DOMSettableTokenList interface to support <output> element. + The DOMTokenList interface was refactored since its was tightly coupled + with HTMLElement.classList property. + + * Android.derived.jscbindings.mk: Added JSDOMSettableTokenList.h file. + * Android.derived.v8bindings.mk: Added V8DOMSettableTokenList.h file. + * Android.jscbindings.mk: Added JSDOMSettableTokenList.cpp file. + * Android.mk: Added ClassList.cpp file. + * CMakeLists.txt: Added DOMSettableTokenList.{cpp,idl} and ClassList.cpp files. + * DerivedSources.cpp: Added JSDOMSettableTokenList.cpp file. + * DerivedSources.make: Added DOMSettableTokenList entry. + * GNUmakefile.am: Added JSDOMSettableTokenList.{h,cpp} and ClassList.{h,cpp} files. + * WebCore.gypi: Added DOMSettableTokenList.{h,cpp,idl}, V8DOMSettableTokenListCustom.cpp and ClassList.{h,cpp} files. + * WebCore.pri: Added DOMSettableTokenList.idl file. + * WebCore.pro: Added V8DOMSettableTokenListCustom.cpp, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files. + * WebCore.vcproj/WebCore.vcproj: Added JSDOMSettableTokenList.{h,cpp}, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files. + * WebCore.xcodeproj/project.pbxproj: Added ClassList.{h,cpp}, DOMSettabletokenList.{h,cpp} and JSDOMSettableTokenList.{h,cpp} + * bindings/gobject/GNUmakefile.am: Added WebKitDOMDOMSettableTokenList.{h,cpp} and WebKitDOMDOMSettableTokenListPrivate.cpp files. + * bindings/scripts/CodeGeneratorJS.pm: Modified IndexGetterReturnsStrings() returns 1 for DOMSettableTokenList. + * bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Added. + (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): + * dom/Element.cpp: Replaced DOMTokenList to ClassList. + (WebCore::Element::classList): + * dom/ElementRareData.h: ditto. + * dom/SpaceSplitString.cpp: Added add() and remove() functions. + (WebCore::SpaceSplitStringData::add): + (WebCore::SpaceSplitStringData::remove): + (WebCore::SpaceSplitString::add): + (WebCore::SpaceSplitString::remove): + * dom/SpaceSplitString.h: Added add() and remove() functions. + * dom/StyledElement.cpp: Replaced DOMTokenList to ClassList. + (WebCore::StyledElement::classAttributeChanged): + * dom/StyledElement.h: ditto. + * html/ClassList.cpp: Added, mostly from original DOMTokenList.cpp. + (WebCore::ClassList::ClassList): + (WebCore::ClassList::ref): + (WebCore::ClassList::deref): + (WebCore::ClassList::length): + (WebCore::ClassList::item): + (WebCore::ClassList::contains): + (WebCore::ClassList::containsInternal): + (WebCore::ClassList::add): + (WebCore::ClassList::addInternal): + (WebCore::ClassList::remove): + (WebCore::ClassList::removeInternal): + (WebCore::ClassList::toggle): + (WebCore::ClassList::toString): + (WebCore::ClassList::reset): + (WebCore::ClassList::classNames): + * html/ClassList.h: Added, mostly from original DOMTokenList.h. + (WebCore::ClassList::create): + (WebCore::ClassList::element): + * html/DOMSettableTokenList.cpp: Added. + (WebCore::DOMSettableTokenList::DOMSettableTokenList): + (WebCore::DOMSettableTokenList::~DOMSettableTokenList): + (WebCore::DOMSettableTokenList::item): + (WebCore::DOMSettableTokenList::contains): + (WebCore::DOMSettableTokenList::add): + (WebCore::DOMSettableTokenList::addInternal): + (WebCore::DOMSettableTokenList::remove): + (WebCore::DOMSettableTokenList::removeInternal): + (WebCore::DOMSettableTokenList::toggle): + (WebCore::DOMSettableTokenList::setValue): + * html/DOMSettableTokenList.h: Added. + (WebCore::DOMSettableTokenList::create): + (WebCore::DOMSettableTokenList::ref): + (WebCore::DOMSettableTokenList::deref): + (WebCore::DOMSettableTokenList::length): + (WebCore::DOMSettableTokenList::toString): + (WebCore::DOMSettableTokenList::value): + * html/DOMSettableTokenList.idl: Added. + * html/DOMTokenList.cpp: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList. + (WebCore::DOMTokenList::validateToken): Changed to be a static member function of DOMTokenList. + (WebCore::DOMTokenList::addToken): Added, mostly from original DOMTokenList::addInternal(). + (WebCore::DOMTokenList::removeToken): Added, mostly from original DOMTokenList::removeInternal(). + * html/DOMTokenList.h: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList. + (WebCore::DOMTokenList::~DOMTokenList): + (WebCore::DOMTokenList::element): + * page/DOMWindow.cpp: Added an entry for DOMSettableTokenList. + * page/DOMWindow.idl: ditto. + +2010-10-29 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: make legacy resource tracking optional in the native code, + make cookeis work against new resource manager. + https://bugs.webkit.org/show_bug.cgi?id=48532 + + * inspector/InspectorCSSStore.cpp: + (WebCore::InspectorCSSStore::resourceStyleSheetText): + * inspector/InspectorController.cpp: + (WebCore::InspectorController::InspectorController): + (WebCore::InspectorController::~InspectorController): + (WebCore::InspectorController::connectFrontend): + (WebCore::InspectorController::releaseFrontendLifetimeAgents): + (WebCore::InspectorController::populateScriptObjects): + (WebCore::InspectorController::unbindAllResources): + (WebCore::InspectorController::didCommitLoad): + (WebCore::InspectorController::frameDetachedFromParent): + (WebCore::InspectorController::didLoadResourceFromMemoryCache): + (WebCore::InspectorController::identifierForInitialRequest): + (WebCore::InspectorController::willSendRequest): + (WebCore::InspectorController::markResourceAsCached): + (WebCore::InspectorController::didReceiveResponse): + (WebCore::InspectorController::didReceiveContentLength): + (WebCore::InspectorController::didFinishLoading): + (WebCore::InspectorController::didFailLoading): + (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): + (WebCore::InspectorController::scriptImported): + (WebCore::InspectorController::setResourceTrackingEnabled): + (WebCore::InspectorController::getCookies): + (WebCore::InspectorController::deleteCookie): + (WebCore::InspectorController::didCreateWebSocket): + (WebCore::InspectorController::willSendWebSocketHandshakeRequest): + (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): + (WebCore::InspectorController::didCloseWebSocket): + (WebCore::InspectorController::breakpointsSettingKey): + (WebCore::InspectorController::getResourceContent): + * inspector/InspectorController.h: + * inspector/InspectorResource.cpp: + (WebCore::InspectorResource::updateScriptObject): + (WebCore::InspectorResource::markFailed): + * inspector/InspectorResource.h: + * inspector/InspectorResourceAgent.cpp: + (WebCore::populateObjectWithFrameResources): + * inspector/front-end/CookieItemsView.js: + (WebInspector.CookieItemsView.prototype._updateWithCookies): + (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): + * inspector/front-end/Resource.js: + (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): + (WebInspector.Resource.prototype._checkWarning): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager.prototype._updateResourceWithResponse): + (WebInspector.ResourceManager.prototype.didFailLoading): + * inspector/front-end/inspector.js: + (WebInspector.forAllResources): + (WebInspector.updateResource): + +2010-10-29 MORITA Hajime <morrita@google.com> + + Unreviewed attempt for fixing build break for http://trac.webkit.org/changeset/70847 + + * editing/EditingAllInOne.cpp: + +2010-10-29 Mihai Parparita <mihaip@chromium.org> + + Reviewed by Adam Barth. + + Support RegExp in V8 implementation of SerializedScriptValue + https://bugs.webkit.org/show_bug.cgi?id=44809 + + Add RegExp serialization/deserialization now that V8 provides API access + to the RegExp type. + + * bindings/v8/SerializedScriptValue.cpp: + (WebCore::ZigZag::Writer::writeRegExp): + (WebCore::ZigZag::Serializer::writeRegExp): + (WebCore::ZigZag::Serializer::doSerialize): + (WebCore::ZigZag::Reader::read): + (WebCore::ZigZag::Reader::readRegExp): + +2010-10-13 MORITA Hajime <morrita@google.com> + + Reviewed by David Hyatt. + + Navigating dark background websites results in blinding white flashes between pages. + https://bugs.webkit.org/show_bug.cgi?id=45640 + + This FOUC is caused by an early layout request before the <body> is ready, + and the page's background style given for <body>, instead of <html>. + So many sites have such stylesheets that we should care them. + + - Some DOM operation such as 'element.offsetLeft' causes page layout. + - The page layout results page repaint + - The page page repaint makes a white screen. because there is nothing to paint + before <body> is available. + + This change: + - extracted existing FOUC check on RenderBlock and RenderLayer to + Document::mayCauseFlashOfUnstyledContent(), + - checked <body> availability on mayCauseFlashOfUnstyledContent(), and + - added FOUC guards before requesting reapint on FrameView. + + No new tests. The data loading speed matters and it cannot be + captured by DRT. + + * dom/Document.cpp: + (WebCore::Document::mayCauseFlashOfUnstyledContent): Added. + * dom/Document.h: + * page/FrameView.cpp: + (WebCore::FrameView::invalidateRect): Added a guard. + (WebCore::FrameView::repaintContentRectangle): Added a guard. + (WebCore::FrameView::doDeferredRepaints): Added a guard. + (WebCore::FrameView::shouldUpdate): Added. + * page/FrameView.h: + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::paintContents): Replaced FOUC check to use mayCauseFlashOfUnstyledContent + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::paintLayer): Replaced FOUC check to use mayCauseFlashOfUnstyledContent + +2010-10-29 David Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=48618 + + Backgrounds should clip to the border radius properly for vertical lines. The code that does this still assumes horizontal lines. + The testcase to cover this used nested spans, which also exposed a bug in the propagation of the vertical bit through the line + box tree. + + Added fast/blockflow/border-radius-clipping-vertical-lr.html. + + * rendering/RenderBlockLineLayout.cpp: + (WebCore::RenderBlock::createLineBoxes): + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::paintFillLayerExtended): + +2010-10-26 MORITA Hajime <morrita@google.com> + + Reviewed by Kent Tamura. + + Refactoring: Spellchecking related static functions could form a class + https://bugs.webkit.org/show_bug.cgi?id=48287 + + Extracted spellcheck related static functions to TextCheckingHelper class, + which has EditorClient and Range as its member. + + No new tests. Just a refactoring. + + * CMakeLists.txt: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * editing/Editor.cpp: + (WebCore::Editor::advanceToNextMisspelling): + (WebCore::Editor::isSelectionUngrammatical): + (WebCore::Editor::guessesForUngrammaticalSelection): + (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): + (WebCore::Editor::markMisspellingsAfterTypingToPosition): + (WebCore::Editor::markMisspellingsOrBadGrammar): + (WebCore::Editor::markMisspellings): + (WebCore::Editor::markBadGrammar): + (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): + (WebCore::Editor::changeBackToReplacedString): + * editing/Editor.h: + * editing/TextCheckingHelper.cpp: Added. + (WebCore::TextCheckingHelper::TextCheckingHelper): + (WebCore::TextCheckingHelper::~TextCheckingHelper): + (WebCore::TextCheckingHelper::paragraphAlignedRange): + (WebCore::TextCheckingHelper::findFirstMisspelling): + (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): + (WebCore::TextCheckingHelper::findFirstGrammarDetail): + (WebCore::TextCheckingHelper::findFirstBadGrammar): + (WebCore::TextCheckingHelper::isUngrammatical): + (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): + (WebCore::TextCheckingHelper::markAllMisspellings): + (WebCore::TextCheckingHelper::markAllBadGrammar): + * editing/TextCheckingHelper.h: Added. + +2010-10-28 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher. + (Eric reviewed the CoreGraphics interactions, Peter reviewed the image + decoder interaction, and Darin Fisher SGTMed the policy decision.) + + [chromium] Chromium Mac should use WebKit's image decoders + https://bugs.webkit.org/show_bug.cgi?id=47974 + + This patch teaches WebKit's image decoders how to talk to CoreGraphics. + This patch doesn't handle color profiles, but that will come in a + subsequent patch. + + * WebCore.gyp/WebCore.gyp: + * WebCore.gypi: + * loader/CachedImage.cpp: + (WebCore::CachedImage::createImage): + * platform/graphics/ImageSource.h: + * platform/image-decoders/ImageDecoder.cpp: + (WebCore::RGBA32Buffer::clear): + (WebCore::RGBA32Buffer::zeroFill): + (WebCore::RGBA32Buffer::copyBitmapData): + (WebCore::RGBA32Buffer::setSize): + * platform/image-decoders/ImageDecoder.h: + (WebCore::RGBA32Buffer::getAddr): + * platform/image-decoders/cg: Added. + * platform/image-decoders/cg/ImageDecoderCG.cpp: Added. + (WebCore::RGBA32Buffer::copyBitmapData): + (WebCore::RGBA32Buffer::setSize): + (WebCore::RGBA32Buffer::asNewNativeImage): + +2010-10-28 Sergio Villar Senin <svillar@igalia.com> + + Reviewed by Xan Lopez. + + [GTK] GObject bindings generator issues + https://bugs.webkit.org/show_bug.cgi?id=48135 + + GObject code generator must not generate conditional API's. This + patch also adds an alternative return value for non-void + conditional methods. With this change the conditionalMethods hack + is no longer needed. + + * bindings/scripts/CodeGeneratorGObject.pm: + +2010-10-28 David Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=48569 + + Box shadows on vertical inlines don't paint properly. Fix the paintBoxShadow method to treat the edges to include as + logical (so that top/bottom are used instead of left/right for vertical lines). In order to make my box-shadow tests + work I had to fix a bug in the transform code of InlineTextBox that was causing the baselines of vertical lines to + be wrong. + + Added fast/blockflow/box-shadow-* tests + + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::paint): + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::paintBoxShadow): + * rendering/RenderBoxModelObject.h: + +2010-10-28 James Robinson <jamesr@chromium.org> + + Reviewed by Simon Fraser. + + iframes forced into slow scrolling mode by containing RenderLayer sometimes + https://bugs.webkit.org/show_bug.cgi?id=48570 + + Only performs the overlap test for RenderLayers that paint themselves. This + prevents marking RenderWidgets as being overlapped unnecessarily. + + Test: fast/repaint/iframe-scroll-repaint.html + + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::paintLayer): + +2010-10-28 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r70814. + http://trac.webkit.org/changeset/70814 + https://bugs.webkit.org/show_bug.cgi?id=48612 + + Caused media/controls-drag-timebar.html to fail on multiple + platforms (Requested by aroben on #webkit). + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::seek): + * platform/graphics/MediaPlayer.cpp: + * platform/graphics/MediaPlayer.h: + * platform/graphics/MediaPlayerPrivate.h: + * platform/graphics/mac/MediaPlayerPrivateQTKit.h: + * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: + * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: + * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h: + * platform/graphics/win/QTMovie.cpp: + * platform/graphics/win/QTMovie.h: + +2010-10-28 Dan Bernstein <mitz@apple.com> + + Reviewed by Simon Fraser. + + <rdar://problem/8597430> Crash triggered by incremental layout of block truncated by line-clamp + https://bugs.webkit.org/show_bug.cgi?id=48602 + + Test: fast/flexbox/line-clamp-crash.html + + * rendering/RenderFlexibleBox.cpp: + (WebCore::RenderFlexibleBox::applyLineClamp): Even if the child needs layout, call clearTruncation(), + since layout itself may be partial and not touch the truncated line (but touch its markup box). + +2010-10-28 Jian Li <jianli@chromium.org> + + Reviewed by Dmitry Titov. + + [chromium] UUID generation does not work in Linux that has sandbox + turned on + https://bugs.webkit.org/show_bug.cgi?id=48571 + + This is because we cannot access /proc when sandbox is on. The fix is to + use random numbers to construct UUID. + + * platform/UUID.cpp: + (WebCore::createCanonicalUUIDString): + +2010-10-28 Jia Pu <jpu@apple.com> + + Reviewed by Dan Bernstein. + + Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word. + https://bugs.webkit.org/show_bug.cgi?id=48078 + <rdar://problem/8579155> + + Tests: platform/mac/editing/spelling/editing-multiple-words-with-markers.html + platform/mac/editing/spelling/editing-word-with-marker-1.html + platform/mac/editing/spelling/editing-word-with-marker-2.html + + This patch is part of on-going improvement of autocorrection feature on Mac OS X. When an editing + occurs, if it affects words (by deleting/inserting characters, spliting word, merging words) that + have Spelling and/or CorrectionIndicator markers, we want to remove the markers. If subsequntial + spelling checking finds spelling error in newlly formed words, it will add the markers back in. + + * dom/DocumentMarker.h: Changed MarkerType to bit masks to make search multiple types easier. + + * dom/DocumentMarkerController.cpp: Refactored two removeMarkers() methods to support remove + markers with specific type from a node. + (WebCore::DocumentMarkerController::removeMarkers): Changed signature to remove marker with specific type. + (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Refactoring. + (WebCore::DocumentMarkerController::hasMarkers): Convenience method to search markers in range. + + * dom/DocumentMarkerController.h: Added new methods and matched new signature of removeMarkers(). + + * editing/Editor.cpp: + (WebCore::Editor::respondToChangedContents): Remove existing markers if the change formed new word. + (WebCore::Editor::cut): Remove markers on words that will be modified by this editing. + (WebCore::Editor::paste): Ditto. + (WebCore::Editor::pasteAsPlainText): Ditto. + (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): Main logic for removing + markers on words affected by editing. + + * editing/Editor.h: Added removeSpellAndCorrectionMarkersFromWordsToBeEdited(). Added + REMOVE_MARKERS_UPON_EDITING and SUPPORT_AUTOCORRECTION_PANEL macro to improve readability. + + * editing/TypingCommand.cpp: + (WebCore::TypingCommand::insertText): Remove markers on words that will be modified by this editing. + (WebCore::TypingCommand::deleteKeyPressed): Ditto. + (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. + +2010-10-28 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Brady Eidson. + + Part of <https://bugs.webkit.org/show_bug.cgi?id=45980> + userscripts/user-script-*-document.html tests are flaky on Windows + + In WebFrameLoaderClient::committedLoad on Windows, we call through to PluginStream::didRecieveData + if our manual loader is a plugin stream, and we can call didRecieveData with a 0 length. + + We shouldn't ASSERT that length is 0, because code paths exists where we call it with a 0 length. + + This is tested by re-enabling user-script-plugin-document.html on Windows. + + * plugins/PluginStream.cpp: + (WebCore::PluginStream::didReceiveData): + +2010-10-28 Mihai Parparita <mihaip@chromium.org> + + Reviewed by Darin Adler. + + [Chromium] History related tests REGRESSED after r70723 + https://bugs.webkit.org/show_bug.cgi?id=48513 + + Remove backItem(), forwardItem() and currentItem() from the Chromium + BackForwardList implementation, since they can use the base class + behavior now (which call itemAtIndex with -1, 1, and 0 respectively). + + * history/BackForwardList.h: + * history/BackForwardListChromium.cpp: + +2010-10-28 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Tony Chang. + + chrome.dll!WebCore::Node::shadowAncestorNode ReadAV@NULL (98643190851b5662363449cc7303d8a5) + https://bugs.webkit.org/show_bug.cgi?id=47888 + + The crash was caused by the while loop in ApplyStyleCommand::fixRangeAndApplyInlineStyle + not considering the case where startNode is the root editable element. + Fixed the bug by not entering the loop when startNode is the editable root. + + Test: editing/style/fix-range-from-root-editable-crash.html + + * editing/ApplyStyleCommand.cpp: + (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): + +2010-10-28 Noam Rosenthal <noam.rosenthal@nokia.com> + + Reviewed by Ariya Hidayat. + + [Texmap] [Qt] Texture mapper initial implementation + https://bugs.webkit.org/show_bug.cgi?id=47070 + + Build fix, some wrong changes slipped into the previous patch. + No new tests: build fix. + + * platform/graphics/GraphicsLayer.h: + * platform/graphics/opengl/TextureMapperGL.cpp: + (WebCore::BitmapTextureGL::setContentsToImage): + * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: + (WebCore::TextureMapperNode::uploadTextureFromContent): + (WebCore::TextureMapperNode::paintRecursive): + * platform/qt/QWebPageClient.h: + (QWebPageClient::setRootGraphicsLayer): + +2010-10-28 David Hyatt <hyatt@apple.com> + + Reviewed by James Robinson. + + https://bugs.webkit.org/show_bug.cgi?id=48568 + + Backgrounds don't work right with vertical RenderInlines. Make background painting + do the right thing for vertical strips. + + Added fast/blockflow/background-* tests + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::paintFillLayer): + +2010-10-28 Eric Carlson <eric.carlson@apple.com> + + Reviewed by Adam Roben. + + Seeking by very small increment doesn't generate 'seeked' event + https://bugs.webkit.org/show_bug.cgi?id=48530 + + Test: media/video-seek-by-small-increment.html + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::seek): Ask the media engine for its closest time value so we can + avoid asking it to seek to the current time. + + * platform/graphics/MediaPlayer.cpp: + (WebCore::MediaPlayer::mediaTimeForTimeValue): New. + * platform/graphics/MediaPlayer.h: + * platform/graphics/MediaPlayerPrivate.h: + (WebCore::MediaPlayerPrivateInterface::mediaTimeForTimeValue): Ditto. + + * platform/graphics/mac/MediaPlayerPrivateQTKit.h: + * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: + (WebCore::MediaPlayerPrivate::mediaTimeForTimeValue): Return the closest value in the movie's time scale. + + * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: + (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): Ditto + * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h: + + * platform/graphics/win/QTMovie.cpp: + (QTMovie::timeScale): Return the movie's time scale. + * platform/graphics/win/QTMovie.h: + +2010-10-28 David Hyatt <hyatt@apple.com> + + Reviewed by Beth Dakin. + + https://bugs.webkit.org/show_bug.cgi?id=48443 + + Border images don't work right with vertical RenderInlines. Make border/mask/background painting + do the right thing for vertical strips. + + Added fast/blockflow/border-image-* tests. + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::paintBoxDecorations): + (WebCore::InlineFlowBox::paintMask): + +2010-10-28 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Roben. + + Port ContextMenuItemWin.cpp to WinCE + https://bugs.webkit.org/show_bug.cgi?id=48407 + + * platform/win/ContextMenuItemWin.cpp: + +2010-10-28 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Darin Adler. + + queryCommandValue should fall back to queryCommandState + https://bugs.webkit.org/show_bug.cgi?id=48479 + + Added a fallback to Command::value so that commands with a state function without a value function + returns the value returned by the state function as a string. + + * editing/EditorCommand.cpp: + (WebCore::Editor::Command::value): + +2010-10-28 Pavel Feldman <pfeldman@chromium.org> + + Not reviewed. Rolling out r70800. + +2010-10-28 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=48551 + HTMLDocument::isFrameSet() should not depend on renderer + + No change in functionality, so no new tests. + + * html/HTMLDocument.cpp: (WebCore::HTMLDocument::isFrameSet): Omit the check for renderer. + + * rendering/RenderLayer.h: Removed unneeded includes and forward declarations. + +2010-10-28 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: make legacy resource tracking optional in the native code, + make cookeis work against new resource manager. + https://bugs.webkit.org/show_bug.cgi?id=48532 + + * inspector/InspectorCSSStore.cpp: + (WebCore::InspectorCSSStore::resourceStyleSheetText): + * inspector/InspectorController.cpp: + (WebCore::InspectorController::InspectorController): + (WebCore::InspectorController::~InspectorController): + (WebCore::InspectorController::connectFrontend): + (WebCore::InspectorController::releaseFrontendLifetimeAgents): + (WebCore::InspectorController::populateScriptObjects): + (WebCore::InspectorController::unbindAllResources): + (WebCore::InspectorController::didCommitLoad): + (WebCore::InspectorController::frameDetachedFromParent): + (WebCore::InspectorController::didLoadResourceFromMemoryCache): + (WebCore::InspectorController::identifierForInitialRequest): + (WebCore::InspectorController::willSendRequest): + (WebCore::InspectorController::markResourceAsCached): + (WebCore::InspectorController::didReceiveResponse): + (WebCore::InspectorController::didReceiveContentLength): + (WebCore::InspectorController::didFinishLoading): + (WebCore::InspectorController::didFailLoading): + (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): + (WebCore::InspectorController::scriptImported): + (WebCore::InspectorController::setResourceTrackingEnabled): + (WebCore::InspectorController::getCookies): + (WebCore::InspectorController::deleteCookie): + (WebCore::InspectorController::didCreateWebSocket): + (WebCore::InspectorController::willSendWebSocketHandshakeRequest): + (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): + (WebCore::InspectorController::didCloseWebSocket): + (WebCore::InspectorController::breakpointsSettingKey): + (WebCore::InspectorController::getResourceContent): + * inspector/InspectorController.h: + * inspector/InspectorResource.cpp: + (WebCore::InspectorResource::updateScriptObject): + (WebCore::InspectorResource::markFailed): + * inspector/InspectorResource.h: + * inspector/InspectorResourceAgent.cpp: + (WebCore::populateObjectWithFrameResources): + * inspector/front-end/Resource.js: + (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager.prototype._updateResourceWithResponse): + (WebInspector.ResourceManager.prototype.didFailLoading): + * inspector/front-end/inspector.js: + (WebInspector.updateResource): + +2010-10-28 Pavel Podivilov <podivilov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: fix pausing on next JavaScript statement + https://bugs.webkit.org/show_bug.cgi?id=48534 + + * inspector/InspectorDebuggerAgent.cpp: + (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): + (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): + (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): + (WebCore::InspectorDebuggerAgent::pause): + (WebCore::InspectorDebuggerAgent::didPause): + * inspector/InspectorDebuggerAgent.h: + +2010-10-28 Yuzo Fujishima <yuzo@google.com> + + Reviewed by David Hyatt. + + Fix for Bug 14550 - Non-layout style change does not update nested first-letter + https://bugs.webkit.org/show_bug.cgi?id=14550 + + If a render text fragment is accompanied by a first letter, update the + first letter's style when the fragment's style is changed. + + Test: fast/css/first-letter-nested.html + + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::styleDidChange): Stop calling updateFirstLetter + from here. + * rendering/RenderBlock.h: Make updateFirstLetter accessbile from + RenderTextFragment. + * rendering/RenderTextFragment.cpp: + (WebCore::RenderTextFragment::styleDidChange): If appropriate, update + first letter after removing stale cached pseudo style. + (WebCore::RenderTextFragment::blockForAccompanyingFirstLetter): Helper + to get the block for the first letter. + * rendering/RenderTextFragment.h: + * rendering/style/RenderStyle.cpp: + (WebCore::RenderStyle::removeCachedPseudoStyle): Remove the specified + pseudo style from cache. + * rendering/style/RenderStyle.h: + +2010-10-28 Benoit Jacob <bjacob@mozilla.com> + + Reviewed by Kenneth Russell. + + Ensure that WebGL stencil buffers are correctly initialized + https://bugs.webkit.org/show_bug.cgi?id=48351 + + * html/canvas/WebGLFramebuffer.cpp: + (WebCore::WebGLFramebuffer::initializeRenderbuffers): + +2010-10-28 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Adele Peterson. + + AX: multi select group option does not handle setting of AXSelectedChildren correctly + https://bugs.webkit.org/show_bug.cgi?id=48464 + + Ensure that when selecting an item from a <select> element, it accounts for <optgroups>. + + Test: platform/mac/accessibility/select-element-selection-with-optgroups.html + + * accessibility/AccessibilityListBoxOption.cpp: + (WebCore::AccessibilityListBoxOption::setSelected): + +2010-10-28 Dan Bernstein <mitz@apple.com> + + Reviewed by Adam Roben. + + No longer soft-link zlib + https://bugs.webkit.org/show_bug.cgi?id=48004 + + * platform/graphics/WOFFFileFormat.cpp: + (WebCore::convertWOFFToSfnt): Removed Windows-speciific code to soft-link + zlib. + +2010-10-27 Zhenyao Mo <zmo@google.com> + + Reviewed by Kenneth Russell. + + Work around a Mac driver bug in generateMipmap + https://bugs.webkit.org/show_bug.cgi?id=48489 + + * html/canvas/WebGLRenderingContext.cpp: + (WebCore::WebGLRenderingContext::generateMipmap): Make sure minFilter is set to NEAREST_MIPMAP_LINEAR before generateMipmap, and after the call, set it back to the original value. + * html/canvas/WebGLTexture.h: + (WebCore::WebGLTexture::getMinFilter): Return the cached minFilter value. + +2010-10-28 Mikhail Naganov <mnaganov@chromium.org> + + [Chromium clang] Unreviewed. Fix forward declaration of 'struct FileMetadata'. + + See http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Debug%20Clang/builds/753/steps/compile/logs/stdio + + * fileapi/FileSystemCallbacks.h: + * platform/AsyncFileSystemCallbacks.h: + +2010-10-28 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: Bring backend-frontend message format to follow the protocol specification + https://bugs.webkit.org/show_bug.cgi?id=48406 + + * inspector/InspectorDOMAgent.cpp: + (WebCore::InspectorDOMAgent::getStyles): + (WebCore::InspectorDOMAgent::applyStyleText): + (WebCore::InspectorDOMAgent::buildObjectForStyle): + (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): + (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): + (WebCore::InspectorDOMAgent::buildObjectForRule): + * inspector/InspectorDOMAgent.h: + * inspector/front-end/AuditRules.js: + (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): + (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): + * inspector/front-end/CSSStyleModel.js: + (WebInspector.CSSStyleModel.parseRuleArrayPayload): + (WebInspector.CSSStyleModel.prototype.getStylesAsync): + (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): + (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): + (WebInspector.CSSStyleModel.prototype.setCSSText): + * inspector/front-end/DOMAgent.js: + (WebInspector.CSSStyleDeclaration): + (WebInspector.CSSStyleDeclaration.parsePayload): + (WebInspector.CSSStyleDeclaration.prototype.get allProperties): + (WebInspector.CSSStyleDeclaration.prototype.getLiveProperty): + (WebInspector.CSSStyleDeclaration.prototype.getPropertyValue): + (WebInspector.CSSStyleDeclaration.prototype.getPropertyPriority): + (WebInspector.CSSStyleDeclaration.prototype.getPropertyShorthand): + (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit): + (WebInspector.CSSStyleDeclaration.prototype.getShorthandValue): + (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority): + (WebInspector.CSSStyleDeclaration.prototype.appendProperty): + (WebInspector.CSSStyleDeclaration.prototype.propertyAt): + (WebInspector.CSSRule): + (WebInspector.CSSRule.parsePayload): + (WebInspector.CSSRule.prototype.get isUserAgent): + (WebInspector.CSSRule.prototype.get isUser): + (WebInspector.CSSRule.prototype.get isViaInspector): + (WebInspector.CSSRule.prototype.get isRegular): + (WebInspector.CSSProperty): + (WebInspector.CSSProperty.parsePayload): + (WebInspector.CSSProperty.prototype.get propertyText): + (WebInspector.CSSProperty.prototype.get isLive): + (WebInspector.CSSProperty.prototype.get active): + (WebInspector.CSSProperty.prototype.get styleBased): + (WebInspector.CSSProperty.prototype.get inactive): + (WebInspector.CSSProperty.prototype.get disabled): + (WebInspector.CSSProperty.prototype.setText): + (WebInspector.CSSProperty.prototype.setValue): + (WebInspector.CSSProperty.prototype.setDisabled.callback): + (WebInspector.CSSProperty.prototype.setDisabled): + * inspector/front-end/MetricsSidebarPane.js: + (WebInspector.MetricsSidebarPane.prototype.update.callback): + (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback): + (WebInspector.MetricsSidebarPane.prototype.update): + (WebInspector.MetricsSidebarPane.prototype._update): + (WebInspector.MetricsSidebarPane.prototype.editingCommitted.callback): + (WebInspector.MetricsSidebarPane.prototype.editingCommitted.setEnabledValueCallback): + (WebInspector.MetricsSidebarPane.prototype.editingCommitted): + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylesSidebarPane.prototype.update): + (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): + (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): + (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules): + (WebInspector.StylesSidebarPane.prototype._markUsedProperties): + (WebInspector.StylesSidebarPane.prototype._containsInherited): + (WebInspector.StylePropertiesSection): + (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): + (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): + (WebInspector.StylePropertiesSection.prototype.onpopulate): + (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): + (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback): + (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): + (WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited): + (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate): + (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace): + (WebInspector.StylePropertyTreeElement): + (WebInspector.StylePropertyTreeElement.prototype.get disabled): + (WebInspector.StylePropertyTreeElement.prototype.get name): + (WebInspector.StylePropertyTreeElement.prototype.get priority): + (WebInspector.StylePropertyTreeElement.prototype.get value): + (WebInspector.StylePropertyTreeElement.prototype.get parsedOk): + (WebInspector.StylePropertyTreeElement.prototype): + (WebInspector.StylePropertyTreeElement.prototype.): + +2010-10-27 MORITA Hajime <morrita@google.com> + + Reviewed by Kent Tamura. + + WebKit needs to expose an Element::spellcheck attribute to javascript. + https://bugs.webkit.org/show_bug.cgi?id=25536 + + Published Element.spellcheck property on IDL, implemented it. + + Tests: editing/spelling/spelling-attribute-change.html + fast/dom/HTMLElement/spellcheck.html + + * html/HTMLElement.cpp: + (WebCore::HTMLElement::spellcheck): + (WebCore::HTMLElement::setSpellcheck): + * html/HTMLElement.h: + * html/HTMLElement.idl: + +2010-10-27 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: make debugger work against new resource manager. + https://bugs.webkit.org/show_bug.cgi?id=48376 + + * inspector/Inspector.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::identifierForInitialRequest): + * inspector/InspectorResourceAgent.cpp: + (WebCore::InspectorResourceAgent::identifierForInitialRequest): + * inspector/InspectorResourceAgent.h: + * inspector/front-end/ExtensionServer.js: + (WebInspector.ExtensionServer.prototype._onGetResourceContent): + * inspector/front-end/Resource.js: + (WebInspector.Resource.prototype.set content): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager): + (WebInspector.ResourceManager.prototype.identifierForInitialRequest): + (WebInspector.ResourceManager.prototype._createResource): + (WebInspector.ResourceManager.prototype.willSendRequest): + (WebInspector.ResourceManager.prototype._updateResourceWithRequest): + (WebInspector.ResourceManager.prototype.didFinishLoading): + (WebInspector.ResourceManager.prototype.didFailLoading): + (WebInspector.ResourceManager.prototype.setOverrideContent): + (WebInspector.ResourceManager.prototype._processCachedResources): + (WebInspector.ResourceManager.prototype._addFramesRecursively): + (WebInspector.ResourceManager.prototype.resourceForURL): + (WebInspector.ResourceManager.prototype.addConsoleMessage): + (WebInspector.ResourceManager.prototype.clearConsoleMessages): + (WebInspector.ResourceManager.prototype.forAllResources): + (WebInspector.ResourceManager.prototype._bindResourceURL): + (WebInspector.ResourceManager.prototype._unbindResourceURL): + (WebInspector.ResourceManager.getContent): + (WebInspector.ResourceTreeModel): + (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): + (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): + (WebInspector.ResourceTreeModel.prototype._clearResources): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel.prototype.addOrUpdateFrame): + * inspector/front-end/networkPanel.css: + (.network.panel .resources-dividers): + +2010-10-28 Andy Estes <aestes@apple.com> + + One more Qt fix due to r70754. + + * html/HTMLObjectElement.cpp: + (WebCore::HTMLObjectElement::hasValidClassId): + +2010-10-28 Pascal Massimino <pascal.massimino@gmail.com> + + Reviewed by Adam Barth. + + fix setSize() call flow: it was only called the first + time (when onlySize is true) + Bug URL: https://bugs.webkit.org/show_bug.cgi?id=48494 + + Testing: difficult to exercise the bug, as it requires + some manual flow (change tab, scroll,...) + + * platform/image-decoders/webp/WEBPImageDecoder.cpp: + (WebCore::WEBPImageDecoder::decode): + fix: call setSize() even when onlySize is false + +2010-10-28 Andy Estes <aestes@apple.com> + + Fix the Qt build after r70754. + + * html/HTMLObjectElement.cpp: + (WebCore::HTMLObjectElement::hasValidClassId): + (WebCore::HTMLObjectElement::updateWidget): + * html/HTMLObjectElement.h: + +2010-10-28 Andy Estes <aestes@apple.com> + + Reviewed by Adam Barth. + + Fix a test failure introduced in r70748 by supporting Qt's non-standard + use of classid. + https://bugs.webkit.org/show_bug.cgi?id=45679 + + * html/HTMLObjectElement.cpp: + (WebCore::objectHasSupportedClassId): Return true if the object's + serviceType is 'application/x-qt-plugin'. + (WebCore::HTMLObjectElement::updateWidget): Do not render fallback + content if a non-empty classid is specified for a Qt plugin object. + +2010-10-28 Ivan Krstić <ike@apple.com> + + Reviewed by Mark Rowe. + + Remove unused experimental proxied panel interface. + <rdar://problem/7237059> + + * WebCore.exp.in: + * platform/mac/WebCoreSystemInterface.h: + * platform/mac/WebCoreSystemInterface.mm: + +2010-10-27 Andy Estes <aestes@apple.com> + + Reviewed by Adam Barth. + + r66156 broke AtlasCT library, formerly affected http://map.d.co.il/ + https://bugs.webkit.org/show_bug.cgi?id=45679 + + This patch removes WebKit's map of classid values to MIME types. It also + changes the behavior of object elements to render fallback content when + a non-empty classid attribute is specified, which is the behavior HTML5 + specifies when a UA encounters a classid it doesn't understand. + + Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html + + * html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), + createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. + (WebCore::HTMLObjectElement::updateWidget): Do not call + serviceTypeForClassId() when there is no type attribute, and render + fallback content if the classid attribute is non-empty. + +2010-10-27 Eric Uhrhane <ericu@chromium.org> + + Reviewed by David Levin. + + [Chromium] Metadata queries should return full file info, not just modification time + https://bugs.webkit.org/show_bug.cgi?id=48098 + + LayoutTests that use this functionality via WorkerAsyncFileWriter are in review. + + Build file changes to add FileMetadata. + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + + The rest of the changes here just pass the new FileMetadata object through calls that used to take a modification time. + * platform/FileMetadata.h: Added. + (WebCore::FileMetadata::FileMetadata): + * fileapi/FileSystemCallbacks.cpp: + (WebCore::FileSystemCallbacksBase::didReadMetadata): + (WebCore::MetadataCallbacks::didReadMetadata): + * fileapi/FileSystemCallbacks.h: + * platform/AsyncFileSystemCallbacks.h: + +2010-10-27 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Add VectorMath files + https://bugs.webkit.org/show_bug.cgi?id=48467 + + No new tests since audio API is not yet implemented. + + * platform/audio/VectorMath.cpp: Added. + (WebCore::VectorMath::vsmul): + (WebCore::VectorMath::vadd): + * platform/audio/VectorMath.h: Added. + +2010-10-27 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Fixup files affected by VectorMath and related API changes + https://bugs.webkit.org/show_bug.cgi?id=48481 + + No new tests since audio API is not yet implemented. + + * platform/audio/AudioBus.cpp: + * platform/audio/AudioChannel.cpp: + * platform/audio/Biquad.cpp: + * platform/audio/FFTConvolver.cpp: + * platform/audio/FFTConvolver.h: + * platform/audio/Panner.cpp: + (WebCore::Panner::create): + * platform/audio/Reverb.cpp: + (WebCore::calculateNormalizationScale): + (WebCore::Reverb::initialize): + (WebCore::Reverb::process): + * platform/audio/ReverbAccumulationBuffer.cpp: + * platform/audio/ReverbAccumulationBuffer.h: + * platform/audio/ReverbConvolver.cpp: + (WebCore::ReverbConvolver::ReverbConvolver): + (WebCore::ReverbConvolver::process): + * platform/audio/ReverbConvolver.h: + * platform/audio/ReverbConvolverStage.cpp: + (WebCore::ReverbConvolverStage::ReverbConvolverStage): + * platform/audio/ReverbConvolverStage.h: + * platform/audio/ReverbInputBuffer.h: + +2010-10-27 Kinuko Yasuda <kinuko@chromium.org> + + Reviewed by Dumitru Daniliuc. + + DOMFileSystem's reference should be kept while there're any active Entries/callbacks + https://bugs.webkit.org/show_bug.cgi?id=47535 + + Changed to keep DOMFileSystem's reference in each EntryBase, DirectoryReaderBase, EntryCallbacks and EntriesCallbacks. + + Test: fast/filesystem/filesystem-reference.html + + * fileapi/DOMFileSystemBase.cpp: + (WebCore::DOMFileSystemBase::readDirectory): Changed to pass/take + PassRefPtr but not a raw pointer. + * fileapi/DOMFileSystemBase.h: + * fileapi/DirectoryEntry.cpp: + (WebCore::DirectoryEntry::DirectoryEntry): Ditto. + (WebCore::DirectoryEntry::createReader): + * fileapi/DirectoryEntry.h: + (WebCore::DirectoryEntry::create): Ditto. + * fileapi/DirectoryEntrySync.cpp: + (WebCore::DirectoryEntrySync::DirectoryEntrySync): Ditto. + * fileapi/DirectoryEntrySync.h: + (WebCore::DirectoryEntrySync::create): Ditto. + * fileapi/DirectoryReader.h: + (WebCore::DirectoryReader::filesystem): + * fileapi/DirectoryReaderBase.h: + (WebCore::DirectoryReaderBase::filesystem): + * fileapi/Entry.cpp: + (WebCore::Entry::Entry): Ditto. + * fileapi/Entry.h: + (WebCore::Entry::filesystem): + * fileapi/EntryBase.h: + (WebCore::EntryBase::filesystem): + (WebCore::EntryBase::EntryBase): Ditto. + * fileapi/EntrySync.cpp: + (WebCore::EntrySync::create): Ditto. + (WebCore::EntrySync::getParent): + (WebCore::EntrySync::EntrySync): Ditto. + * fileapi/EntrySync.h: + (WebCore::EntrySync::filesystem): + * fileapi/FileEntry.cpp: + (WebCore::FileEntry::FileEntry): Ditto. + * fileapi/FileEntry.h: + (WebCore::FileEntry::create): Ditto. + * fileapi/FileEntrySync.cpp: + (WebCore::FileEntrySync::FileEntrySync): Ditto. + * fileapi/FileEntrySync.h: + (WebCore::FileEntrySync::create): Ditto. + * fileapi/FileSystemCallbacks.cpp: + (WebCore::EntriesCallbacks::create): Ditto. + (WebCore::EntriesCallbacks::EntriesCallbacks): Ditto. + * fileapi/FileSystemCallbacks.h: + +2010-10-27 Yuzo Fujishima <yuzo@google.com> + + Reviewed by Eric Seidel. + + Fix for Bug 48310 - SVG font-face-name without name attribute causes a crash + https://bugs.webkit.org/show_bug.cgi?id=48310 + + Test: svg/custom/font-face-name-without-name-attr.svg + + * svg/SVGFontFaceElement.cpp: + (WebCore::SVGFontFaceElement::rebuildFontFace): Don't create src + property if the src value list is empty. + * svg/SVGFontFaceSrcElement.cpp: + (WebCore::SVGFontFaceSrcElement::srcValue): Don't add empty src + values to the src value list. + +2010-10-27 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Allow AudioDSPKernel to function without an AudioDSPKernelProcessor + https://bugs.webkit.org/show_bug.cgi?id=48472 + + No new tests since audio API is not yet implemented. + + * platform/audio/AudioDSPKernel.h: + (WebCore::AudioDSPKernel::AudioDSPKernel): + (WebCore::AudioDSPKernel::sampleRate): + +2010-10-27 Enrica Casucci <enrica@apple.com> + + Reviewed by Alexey Proskuryakov. + + Support Appkit key bindings and custom key bindings in WebKit2 + https://bugs.webkit.org/show_bug.cgi?id=48271 + <rdar://problem/7660723> + + * dom/KeyboardEvent.h: + (WebCore::KeypressCommand::KeypressCommand): Added default constructor and modified assert for text + insertion command constructor to support WebKit2 scenarios. + The default constructor is needed to support the generated WebKit2 message processing code. + +2010-10-26 Darin Adler <darin@apple.com> + + Reviewed by Sam Weinig. + + WebKitTestRunner needs to support layoutTestController.dumpBackForwardList + https://bugs.webkit.org/show_bug.cgi?id=42322 + rdar://problem/8193631 + + WebKitTestRunner needs to support layoutTestController.clearBackForwardList + https://bugs.webkit.org/show_bug.cgi?id=42333 + rdar://problem/8193643 + + * WebCore.exp.in: Updated exports. + + * history/BackForwardList.h: Added comments about future refactoring. + Moved functions that are not called inside WebCore into a separate + section, to be removed later. Added an isActive function to replace the + use of enabled() and entries(). + + * history/BackForwardListImpl.h: Removed isBackForwardListImpl. + Marked virtual function overrides virtual explicitly, except for the + ones that will be non-virtual once we make the changes above. + Added the isActive function. + + * history/PageCache.cpp: + (WebCore::logCanCachePageDecision): Use isActive. + (WebCore::PageCache::canCache): Ditto. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::checkDidPerformFirstNavigation): Check + using currentItem, backItem, and forwardItem instead of + using entries. + + * page/Settings.cpp: + (WebCore::Settings::setUsesPageCache): Loop through the back/forward + list entries using backListCount and forwardListCount instead of + using entries. + +2010-10-27 Chris Rogers <crogers@google.com> + + Reviewed by Chris Marrin. + + Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit + https://bugs.webkit.org/show_bug.cgi?id=48279 + + No new tests since flag is disabled. + + * Configurations/FeatureDefines.xcconfig: + +2010-10-27 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Add AudioResamplerKernel files + https://bugs.webkit.org/show_bug.cgi?id=47624 + + No new tests since audio API is not yet implemented. + + * platform/audio/AudioResamplerKernel.cpp: Added. + (WebCore::AudioResamplerKernel::AudioResamplerKernel): + (WebCore::AudioResamplerKernel::getSourcePointer): + (WebCore::AudioResamplerKernel::process): + (WebCore::AudioResamplerKernel::reset): + (WebCore::AudioResamplerKernel::rate): + * platform/audio/AudioResamplerKernel.h: Added. + +2010-10-27 Adam Barth <abarth@webkit.org> + + Reviewed by Ojan Vafai. + + REGRESSION(66511): CORDYS Process Factory doesn't work + https://bugs.webkit.org/show_bug.cgi?id=48453 + + When Ojan refactored this function in 66511, he missed an "else", + which causes us to generated HIERARCHY_REQUEST_ERR in some cases where + we're not supposed to. This patch restores the "else" behavior (using + an early return) and adds a test for the cases that caused problems in + the field. + + Test: fast/dom/allowed-children.html + + * dom/Node.cpp: + (WebCore::isChildTypeAllowed): + +2010-10-27 Beth Dakin <bdakin@apple.com> + + Reviewed by Darin Adler. + + Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit + SPI to scale a WebView + -and corresponding- + <rdar://problem/8107667> + + This patch adds SPI to Mac WebKit that scales the page by the given + scale factor. The scale factor is factored into the RenderStyle's + transform. + + Set the current pageScale for the document. + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::styleForDocument): + + Frame keeps track of the page scale factor. When + scalePage() is called, it modifies the RenderView's style to + include a transform of the appropriate scale and forces a style + recalc. + * page/Frame.cpp: + (WebCore::Frame::Frame): + (WebCore::Frame::scalePage): + * page/Frame.h: + (WebCore::Frame::pageScaleFactor): + * WebCore.exp.in: + + Add a scale to the transformation matrix. + * rendering/style/RenderStyle.cpp: + (WebCore::RenderStyle::setPageScaleTransform): + * rendering/style/RenderStyle.h: + +2010-10-27 Dan Bernstein <mitz@apple.com> + + Reviewed by Darin Adler. + + REGRESSION (r70335): Incorrect article layout in Safari Reader + https://bugs.webkit.org/show_bug.cgi?id=48436 + + * page/DOMWindow.cpp: + (WebCore::DOMWindow::getMatchedCSSRules): Return rules from all origins if the cross-origin + check is disabled. + * page/Settings.cpp: + (WebCore::Settings::Settings): Initialize m_crossOriginCheckInGetMatchedCSSRulesDisabled. + * page/Settings.h: + (WebCore::Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled): Added this accessor. + (WebCore::Settings::crossOriginCheckInGetMatchedCSSRulesDisabled): Ditto. + +2010-10-27 Zhenyao Mo <zmo@google.com> + + Reviewed by Kenneth Russell. + + refactor the nested large switch statements in GraphicsContext3DCG.cpp:getImageData() + https://bugs.webkit.org/show_bug.cgi?id=47027 + + * platform/graphics/GraphicsContext3D.cpp: + (WebCore::doPacking): ASSERT false if undefined format is passed in. + * platform/graphics/GraphicsContext3D.h: Add kSourceFormatUndefined enum. + * platform/graphics/cg/GraphicsContext3DCG.cpp: + (WebCore::getSourceDataFormat): Decide source data format from componentsPerPixel, alpha format, bitsPerComponet, etc. + (WebCore::GraphicsContext3D::getImageData): Refactor the code to use getSourceDataFormat and remove nested switches. + +2010-10-27 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Barth. + + Use WTF::StringHasher::createBlobHash where possible + https://bugs.webkit.org/show_bug.cgi?id=48228 + + Replace StringImpl::computeHash with StringHasher::createBlobHash. + This removes many duplicated code. + + * bindings/js/JSSVGPODTypeWrapper.h: + (WebCore::PODTypeWrapperCacheInfoHash::hash): + * page/SecurityOriginHash.h: + (WebCore::SecurityOriginHash::hash): + * platform/cf/SchedulePair.h: + (WebCore::SchedulePairHash::hash): + * platform/graphics/FontCache.cpp: + (WebCore::computeHash): + * platform/graphics/chromium/FontPlatformDataChromiumWin.h: + (WebCore::FontPlatformData::RefCountedHFONT::hash): + * platform/graphics/cocoa/FontPlatformData.h: + (WebCore::FontPlatformData::hash): + * platform/graphics/gtk/FontPlatformDataPango.h: + (WebCore::FontPlatformData::hash): + * platform/graphics/wince/FontPlatformData.cpp: + (WebCore::FixedSizeFontDataKeyHash::hash): + * platform/graphics/wx/FontPlatformDataWx.cpp: + (WebCore::FontPlatformData::FontPlatformData): + (WebCore::FontPlatformData::computeHash): + * plugins/PluginPackage.cpp: + (WebCore::PluginPackage::hash): + * plugins/win/PluginPackageWin.cpp: + (WebCore::PluginPackage::hash): + * svg/DeprecatedSVGAnimatedTemplate.h: + (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHash::hash): + * svg/properties/SVGAnimatedPropertyDescription.h: + (WebCore::SVGAnimatedPropertyDescriptionHash::hash): + +2010-10-27 Tony Chang <tony@chromium.org> + + Unreviewed, build fix after r70692. + + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::paintBorder): + +2010-10-27 Leandro Pereira <leandro@profusion.mobi> + + Unreviewed. Build fix after r70651. + + * CMakeListsEfl.txt: Add SoupURIUtils.cpp. + +2010-10-27 Crystal Zhang <haizhang@rim.com> + + Reviewed by Eric Carlson. + + https://bugs.webkit.org/show_bug.cgi?id=48446 + + Fix an issue where we were passing the wrong parameter + to MIMETypeRegistry::getMIMETypeForExtension(). + + * platform/MIMETypeRegistry.cpp: + +2010-10-27 David Hyatt <hyatt@apple.com> + + Reviewed by Beth Dakin. + + https://bugs.webkit.org/show_bug.cgi?id=48449 + + Make border drawing work correctly with vertical inline flows. The top and bottom edge have to be omitted + rather than the left and right edges. + + Also discovered that border-radius is broken with the new path-based-drawing code for all inline flows. This + is a regression from the old drawing code. I patched the code to be correct rather than clipping out stuff + that it shouldn't and applying border-radii on lines that don't even have them. + + Added fast/blockflow/border-vertical-lr.html and fast/borders/border-radius-inline-flow.html + + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::paintBorder): + (WebCore::RenderBoxModelObject::clipBorderSidePolygon): + * rendering/RenderBoxModelObject.h: + +2010-10-27 Martin Robinson <mrobinson@igalia.com> + + Reviewed by Gustavo Noronha Silva. + + [Cairo] Font fallback determination is very ineffecient + https://bugs.webkit.org/show_bug.cgi?id=42052 + + When choosing a fallback font in FontCache::getFontDataForCharacters, use FontConfig's + mechanism for searching the fallback list directly, instead of scanning the list manually. + If the font is a custom font or any other font with no FontConfig pattern associated with + it, as FontConfig for a font that can supply the missing glyphs. + + Test: platform/gtk/fonts/custom-font-missing-glyphs.html + + * platform/graphics/cairo/FontCacheFreeType.cpp: + (WebCore::createFontConfigPatternForCharacters): Added this helper which turns + a collection of unicode characters into a FontConfig pattern. + (WebCore::findBestFontGivenFallbacks): Using a FontConfig pattern created with th + above helper and a FcFontSet of fallback fonts, this helper will find a font in + the set which fulfills the requirments. + (WebCore::FontCache::getFontDataForCharacters): Given an existing font with missing + glyphs, either find an appropriate fallback font from the list of FontConfig fallbacks + or ask FontConfig directly for an appropriate font. + * platform/graphics/cairo/FontPlatformDataFreeType.h: Made a member mutable, as it is + initialized lazily. + +2010-10-27 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled + https://bugs.webkit.org/show_bug.cgi?id=48431 + + * inspector/front-end/AuditsPanel.js: + (WebInspector.AuditsPanel.prototype._reloadResources): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.prototype._createPanelEnabler): + (WebInspector.ResourcesPanel.prototype._enableResourceTracking): + +2010-10-27 Abhishek Arya <inferno@chromium.org> + + Reviewed by Dave Hyatt. + + Add a function to make sure child is allowed before adding to a + render view. + https://bugs.webkit.org/show_bug.cgi?id=48328 + + Test: fast/inline/inline-child-height-width-calc-crash.html + + * rendering/RenderView.cpp: + (WebCore::RenderView::isChildAllowed): + * rendering/RenderView.h: + +2010-10-27 Martin Robinson <mrobinson@igalia.com> + + Reviewed by Gustavo Noronha Silva. + + [GTK] r69296 includes a cast from GdkWindow* to GtkWindow* + https://bugs.webkit.org/show_bug.cgi?id=48445 + + Pass the pageClient GtkWidget* to gtk_xtbin_new instead of the + GdkWindow*. The pageClient is used to get the proper visual for the + plugin container widget. + + No new tests. This patch should prevent plugins/null-npp-getvalue-pointer.html + from crashing. + + * plugins/gtk/PluginViewGtk.cpp: + (WebCore::PluginView::platformStart): Pass the widget instead of the window. + * plugins/gtk/gtk2xtbin.c: Accept the widget instead of the window. + (gtk_xtbin_new): + * plugins/gtk/gtk2xtbin.h: Update the declaration. + +2010-10-27 Kwang Yul Seo <skyul@company100.net> + + Reviewed by James Robinson. + + [BREWMP] Port graphics backend + https://bugs.webkit.org/show_bug.cgi?id=40275 + + Add PLATFORM(BREWMP) guard to skia's FontCustomPlatformData + to share OS(LINUX) implementation. + + * loader/CachedFont.cpp: + * platform/graphics/skia/FontCustomPlatformData.cpp: + (WebCore::FontCustomPlatformData::~FontCustomPlatformData): + (WebCore::FontCustomPlatformData::fontPlatformData): + (WebCore::createFontCustomPlatformData): + * platform/graphics/skia/FontCustomPlatformData.h: + +2010-10-27 Satish Sampath <satish@chromium.org> + + Unreviewed, rolling out r70665. + http://trac.webkit.org/changeset/70665 + https://bugs.webkit.org/show_bug.cgi?id=47089 + + Need to address Alexey's review comments. + + * page/SpeechInput.cpp: + (WebCore::SpeechInput::startRecognition): + * page/SpeechInput.h: + * page/SpeechInputClient.h: + * platform/mock/SpeechInputClientMock.cpp: + (WebCore::SpeechInputClientMock::startRecognition): + (WebCore::SpeechInputClientMock::setRecognitionResult): + (WebCore::SpeechInputClientMock::timerFired): + * platform/mock/SpeechInputClientMock.h: + * rendering/TextControlInnerElements.cpp: + (WebCore::TextControlInnerElement::attachInnerElement): + (WebCore::SearchFieldCancelButtonElement::detach): + (WebCore::SpinButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::detach): + +2010-10-27 ZHenyao Mo <zmo@google.com> + + Reviewed by Kenneth Russell. + + Must enable GL_POINT_SPRITE in GraphicsContext3D implementations + https://bugs.webkit.org/show_bug.cgi?id=45908 + + * platform/graphics/mac/GraphicsContext3DMac.mm: Enable for Mac port. + (WebCore::GraphicsContext3D::GraphicsContext3D): + +2010-10-27 Leandro Gracia Gil <leandrogracia@google.com> + + Reviewed by Jeremy Orlow. + + Patch the current speech input implementation to use the nearest + language tag. The language is now passed to the startRecognition + methods so that language-specific recognition could be used. Also added + a second parameter to setMockSpeechInputResult for the language used in + speech recognition. + https://bugs.webkit.org/show_bug.cgi?id=47089 + + This is the 2nd of a 4-sided patch in Chromium and WebKit. For more + details see http://codereview.chromium.org/3615005/show and + http://codereview.chromium.org/3595018/show. The last of the 4 patches + depends also on the language tag validation provided by this patch: + https://bugs.webkit.org/show_bug.cgi?id=48225. + + Test: fast/speech/input-text-language-tag.html + + * page/SpeechInput.cpp: + (WebCore::SpeechInput::startRecognition): + * page/SpeechInput.h: + * page/SpeechInputClient.h: + * platform/mock/SpeechInputClientMock.cpp: + (WebCore::SpeechInputClientMock::startRecognition): + (WebCore::SpeechInputClientMock::setRecognitionResult): + (WebCore::SpeechInputClientMock::timerFired): + * platform/mock/SpeechInputClientMock.h: + * rendering/TextControlInnerElements.cpp: + (WebCore::TextControlInnerElement::attachInnerElement): + (WebCore::SearchFieldCancelButtonElement::detach): + (WebCore::SpinButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::detach): + +2010-10-27 David Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=48381 + + Make basic layer positioning work with vertical-lr writing-mode. + + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::paintChildren): + (WebCore::RenderBlock::paintFloats): + * rendering/RenderBox.cpp: + (WebCore::RenderBox::adjustForFlippedBlocksWritingMode): + (WebCore::RenderBox::locationOffsetIncludingFlipping): + * rendering/RenderBox.h: + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::updateLayerPosition): + +2010-10-27 Zhenyao Mo <zmo@google.com> + + Reviewed by Kenneth Russell. + + object-deletion-behaviour.html fails with mesa backend + https://bugs.webkit.org/show_bug.cgi?id=46667 + + * html/canvas/WebGLRenderingContext.cpp: + (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): If object_type is 0, we return early because object_name should be always be 0. + +2010-10-27 Zhenyao Mo <zmo@google.com> + + Reviewed by Kenneth Russell. + + If WebGL is running on top of a strict version of OpenGL ES it should make sure attribs have buffers assigned at all times + https://bugs.webkit.org/show_bug.cgi?id=47964 + + * html/canvas/WebGLRenderingContext.cpp: + (WebCore::WebGLRenderingContext::validateRenderingState): Minimum checking: if input <= 0, only check if each enabled vertex attribute is bound to a buffer. + (WebCore::WebGLRenderingContext::drawArrays): If underlying GL performs bounds checking, we still need to do the minimum checking using validateRenderingState. + (WebCore::WebGLRenderingContext::drawElements): Ditto. + * html/canvas/WebGLRenderingContext.h: Add a comment for input <= 0 in validateRenderingState. + +2010-10-27 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dan Bernstein. + + Accelerated animation with missing values in keyframes is broken + https://bugs.webkit.org/show_bug.cgi?id=48395 + + r66339 changed the behavior of keyframe animations such that if a property + is missing from a keyframe, the property will be interpolated between those + keyframes that do have a value for the property. If a value is missing + from the first or last keyframes, the element's unanimated style supplies + that value. + + However, accelerated animations had a bug where if a value was missing + from the first (and maybe subsequent) or last (and maybe preceding) keyframes, + the animation data given to the GraphicsLayer would be missing the style from the + first or final keyframe. + + Tests: animations/missing-values-first-keyframe.html + animations/missing-values-last-keyframe.html + + * rendering/RenderLayerBacking.cpp: + (WebCore::RenderLayerBacking::startAnimation): + +2010-10-27 Renata Hodovan <reni@inf.u-szeged.hu> + + Reviewed by Dirk Schulze. + + Calling the super class of RenderSVGImage::updateFromElement is missing + https://bugs.webkit.org/show_bug.cgi?id=48347 + + RenderSVGImage::updateFromElement is an inherited function of RenderSVGModelObject what needs calling its ancestor. + Lack of this call caused filters were not invalidated at SVGImage objects. + + No new tests, because this modification is covered by SVGFEConvolveMatrixElement's dynamic update tests. + + * rendering/RenderSVGImage.cpp: + (WebCore::RenderSVGImage::updateFromElement): + +2010-10-27 Justin Schuh <jschuh@chromium.org> + + Reviewed by Dirk Schulze. + + Ignore invalid blend modes + https://bugs.webkit.org/show_bug.cgi?id=48371 + + Test: svg/filters/feBlend-invalid-mode.xhtml + + * platform/graphics/filters/FEBlend.cpp: + (WebCore::FEBlend::apply): + +2010-10-27 Sergio Villar Senin <svillar@igalia.com> + + Reviewed by Martin Robinson. + + [Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails + https://bugs.webkit.org/show_bug.cgi?id=38956 + + Added a new utility function that turns SoupURIs into + KURLs. That addresses some issues with SoupURIs like for example + soup_uri_to_string ignoring the URI password. Basic authentication + using URL credentials should work now. + + * GNUmakefile.am: + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::ResourceHandle::start): + (WebCore::ResourceHandle::loadResourceSynchronously): + * platform/network/soup/ResourceRequestSoup.cpp: + (WebCore::ResourceRequest::updateFromSoupMessage): + * platform/network/soup/ResourceResponseSoup.cpp: + (WebCore::ResourceResponse::updateFromSoupMessage): + * platform/network/soup/SoupURIUtils.cpp: Added. + (WebCore::soupURIToKURL): + * platform/network/soup/SoupURIUtils.h: Added. + +2010-10-27 Ademar de Souza Reis Jr <ademar.reis@openbossa.org> + + Reviewed by Andreas Kling. + + Remove references to ancient QGVLauncher and QtLauncher + https://bugs.webkit.org/show_bug.cgi?id=48430 + + * manual-tests/plugins/windowed.html: change to QtTestBrowser + * manual-tests/plugins/windowless.html: ditto + +2010-10-27 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Csaba Osztrogonác. + + [WINCE] Buildfix after r70400. + https://bugs.webkit.org/show_bug.cgi?id=48419 + + * platform/wince/TemporaryLinkStubs.cpp: Added. + (WebCore::setCookieStoragePrivateBrowsingEnabled): + +2010-10-27 Satish Sampath <satish@chromium.org> + + Reviewed by Steve Block. + + Add runtime flag check before enabling speech input in code. + https://bugs.webkit.org/show_bug.cgi?id=48426 + + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check. + +2010-10-27 Adam Roben <aroben@apple.com> + + Only decompress pixel buffers when needed (and fix a crash in the + process) + + Fixes <http://webkit.org/b/48417> Crash when running + compositing/video/video-background-color.html on Windows + + Reviewed by Anders Carlsson. + + * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: + (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Only + decompress the pixel buffer when it has an incompatible format. This + also has the benefit of only decompressing the buffer when a + QTDecompressionSession has been created! (I assume this was just a typo + from when this code was added in r70252.) + +2010-10-27 Mario Sanchez Prada <msanchez@igalia.com> + + Reviewed by Martin Robinson. + + getTextAtOffset returns incorrect results if a link includes text and an image + https://bugs.webkit.org/show_bug.cgi?id=47365 + + Properly consider text under a non-text renderer in textForObject. + + We need to check all the children under a non-text renderer, if + any, to consider when current object is not a text object but some + of its children are, in order not to miss those portions of text + by not properly handling those situations. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (textForRenderer): New. Get the text for a RenderObject's children. + (textForObject): Use the new textForRenderer function. + +2010-10-26 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Rob Buis. + + Convert SVGRect to the new SVGPropertyTearOff concept + https://bugs.webkit.org/show_bug.cgi?id=48204 + + Convert the next SVG primitive type to use the SVGPropertyTearOff concept: SVGRect. + Added new test verifying that StrictTypeChecking is enabled for SVGRect. Refactor and share code between JSC/V8/ObjC generators. + + Test: svg/dom/SVGRect.html + + * GNUmakefile.am: Add SVGAnimatedRect.h to build. + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * bindings/scripts/CodeGenerator.pm: Refactor SVGPropertyTearOff handling, and share code between JSC/V8/ObjC generators. + * bindings/scripts/CodeGeneratorJS.pm: Ditto. + * bindings/scripts/CodeGeneratorObjC.pm: Ditto. + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedRect handling. + * svg/DeprecatedSVGAnimatedTemplate.h: Ditto. + * svg/SVGAngle.idl: Remove [SVGProperty] flag. + * svg/SVGAnimatedAngle.idl: Remove [SVGAnimatedProperty] flag. + * svg/SVGAnimatedLength.idl: Ditto. + * svg/SVGAnimatedLengthList.idl: Ditto. + * svg/SVGAnimatedRect.h: Added. + * svg/SVGFitToViewBox.h: SVGRect now uses the new tear off concept, adapt code. + * svg/SVGLength.idl: Remove [SVGProperty] flag. + * svg/SVGMarkerElement.h: + * svg/SVGPatternElement.h: + * svg/SVGRect.idl: Remove [PODType] flag, add StrictTypeChecking to all attributes. + * svg/SVGSVGElement.cpp: s/setViewBox/setViewBoxBaseValue/. + (WebCore::SVGSVGElement::currentView): + (WebCore::SVGSVGElement::inheritViewAttributes): + * svg/SVGSVGElement.h: + * svg/SVGSVGElement.idl: Remove [Immutable] flags for SVGRect types, no longer needed. + * svg/SVGSymbolElement.h: + * svg/SVGViewElement.h: + * svg/SVGViewSpec.cpp: Take a SVGElement as context element. + (WebCore::SVGViewSpec::SVGViewSpec): + * svg/SVGViewSpec.h: Ditto. + (WebCore::SVGViewSpec::contextElement): + * svg/SVGZoomEvent.idl: Remove [Immutable] flags for SVGRect types, no longer needed. + * svg/properties/SVGAnimatedPropertyMacros.h: Support declaring animated properties on non-SVGElement types (here: SVGViewSpec), just like the old macros handled it. + +2010-10-27 Pavel Podivilov <podivilov@chromium.org> + + Unreviewed, fix line endings in InspectorState.h + + * inspector/InspectorState.h: + +2010-10-27 Pavel Podivilov <podivilov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: move frontend settings to local storage + https://bugs.webkit.org/show_bug.cgi?id=47715 + + * inspector/Inspector.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::InspectorController): + (WebCore::InspectorController::didCommitLoad): + * inspector/InspectorController.h: + * inspector/InspectorState.cpp: + (WebCore::InspectorState::InspectorState): + * inspector/InspectorState.h: + * inspector/front-end/ConsoleView.js: + * inspector/front-end/EventListenersSidebarPane.js: + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel.prototype._createStatusbarButtons): + * inspector/front-end/Panel.js: + (WebInspector.Panel): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.prototype._createStatusbarButtons): + * inspector/front-end/Settings.js: + (WebInspector.Settings): + (WebInspector.Settings.prototype.installApplicationSetting): + (WebInspector.Settings.prototype.installProjectSetting): + (WebInspector.Settings.prototype._get): + (WebInspector.Settings.prototype._set): + (WebInspector.Settings.prototype._getProjectSetting): + (WebInspector.Settings.prototype._setProjectSetting): + (WebInspector.Settings.prototype._formatProjectKey): + * inspector/front-end/StylesSidebarPane.js: + * inspector/front-end/WatchExpressionsSidebarPane.js: + (WebInspector.WatchExpressionsSidebarPane): + (WebInspector.WatchExpressionsSidebarPane.prototype.reset): + * inspector/front-end/inspector.js: + (WebInspector.reset): + +2010-10-27 Andy Estes <aestes@apple.com> + + Reviewed by David Hyatt. + + Siblings of floated elements should be cleared below the float if they + are too wide to fit in the containing block. + https://bugs.webkit.org/show_bug.cgi?id=48396 + + Test: fast/block/float/clear-element-too-wide-for-containing-block.html + + WebKit did not clear elements adjacent to floats if they were wider than + the containing block, instead keeping them on the same line and allowing + them to spill out the right side of the containing block. We should + match the spec in this regard and clear the element below the float even + if it is too wide for the containing block. Doing this seems to also + match IE's and Firefox's behavior. + + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::getClearDelta): Continue to compute the clear + delta even if the child's minimum preferred width is greater than the + containing block's available width. + +2010-10-26 Rob Buis <rwlbuis@gmail.com> + + Reviewed by Nikolas Zimmermann. + + Title-Element has no popup on <svg>-Elements, but on <g> + https://bugs.webkit.org/show_bug.cgi?id=47669 + + Allow tooltips on non-root svg elements. + + No new tests. + + * svg/SVGStyledElement.cpp: + +2010-10-26 Dai Mikurube <dmikurube@google.com> + + Reviewed by Kent Tamura. + + constraint validation: stepMismatch (rounding error) + https://bugs.webkit.org/show_bug.cgi?id=48220 + + 1. Changed the computation to achieve difference from a integral + multiple of the allowed value step. + + The previous fmod(doubleValue, step) sometimes returned unacceptable + remainder. For example, + double doubleValue = 1.005; // Actually, near to 1.005 + double step = 0.005; // Actually, near to 0.005 + fmod(doubleValue, step) ==> (near to) 0.005 + It's a case that doubleValue is a little smaller than 1.005 and step is + a little larger than 0.005. + + 2. Changed the error threshold. + + Number values in HTML5 are expressed in IEEE 754 single-precision. + Too precise comparison sometimes leads unintended errors. + + For example, I found a case : + remainder = 0.00000000000000022204460 + acceptableError = 0.00000000000000007105427 + + * html/NumberInputType.cpp: + (WebCore::NumberInputType::stepMismatch): + +2010-10-26 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Add DelayNode files + https://bugs.webkit.org/show_bug.cgi?id=47516 + + No new tests since audio API is not yet implemented. + + * webaudio/DelayNode.cpp: Added. + (WebCore::DelayNode::DelayNode): + (WebCore::DelayNode::delayTime): + * webaudio/DelayNode.h: Added. + (WebCore::DelayNode::create): + (WebCore::DelayNode::delayProcessor): + * webaudio/DelayNode.idl: Added. + +2010-10-26 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + AudioContext and AudioNode followup changes for AudioNodeInput/AudioNodeOutput thread safety + https://bugs.webkit.org/show_bug.cgi?id=47504 + + No new tests since audio API is not yet implemented. + + * webaudio/AudioContext.cpp: + (WebCore::AudioContext::isAudioThread): + (WebCore::AudioContext::isGraphOwner): + (WebCore::AudioContext::handlePreRenderTasks): + (WebCore::AudioContext::handlePostRenderTasks): + (WebCore::AudioContext::deleteMarkedNodes): + (WebCore::AudioContext::markAudioNodeInputDirty): + (WebCore::AudioContext::markAudioNodeOutputDirty): + (WebCore::AudioContext::handleDirtyAudioNodeInputs): + (WebCore::AudioContext::handleDirtyAudioNodeOutputs): + * webaudio/AudioContext.h: + * webaudio/AudioNode.cpp: + * webaudio/AudioNode.h: + (WebCore::AudioNode::isMarkedForDeletion): + * webaudio/AudioNode.idl: + +2010-10-26 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Add DelayProcessor files + https://bugs.webkit.org/show_bug.cgi?id=47517 + + No new tests since audio API is not yet implemented. + + * webaudio/DelayProcessor.cpp: Added. + (WebCore::DelayProcessor::DelayProcessor): + (WebCore::DelayProcessor::~DelayProcessor): + (WebCore::DelayProcessor::createKernel): + * webaudio/DelayProcessor.h: Added. + (WebCore::DelayProcessor::delayTime): + +2010-10-26 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Add AudioNodeOutput files + https://bugs.webkit.org/show_bug.cgi?id=45581 + + No new tests since audio API is not yet implemented. + + * webaudio/AudioNodeOutput.cpp: Added. + (WebCore::AudioNodeOutput::AudioNodeOutput): + (WebCore::AudioNodeOutput::setNumberOfChannels): + (WebCore::AudioNodeOutput::setInternalBus): + (WebCore::AudioNodeOutput::updateRenderingState): + (WebCore::AudioNodeOutput::updateNumberOfChannels): + (WebCore::AudioNodeOutput::propagateChannelCount): + (WebCore::AudioNodeOutput::pull): + (WebCore::AudioNodeOutput::bus): + (WebCore::AudioNodeOutput::renderingFanOutCount): + (WebCore::AudioNodeOutput::fanOutCount): + (WebCore::AudioNodeOutput::addInput): + (WebCore::AudioNodeOutput::removeInput): + (WebCore::AudioNodeOutput::disconnectAllInputs): + (WebCore::AudioNodeOutput::disable): + (WebCore::AudioNodeOutput::enable): + * webaudio/AudioNodeOutput.h: Added. + (WebCore::AudioNodeOutput::node): + (WebCore::AudioNodeOutput::context): + (WebCore::AudioNodeOutput::numberOfChannels): + (WebCore::AudioNodeOutput::isChannelCountKnown): + +2010-10-26 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Add AudioNodeInput files + https://bugs.webkit.org/show_bug.cgi?id=45577 + + No new tests since audio API is not yet implemented. + + * webaudio/AudioNodeInput.cpp: Added. + (WebCore::AudioNodeInput::AudioNodeInput): + (WebCore::AudioNodeInput::connect): + (WebCore::AudioNodeInput::disconnect): + (WebCore::AudioNodeInput::disable): + (WebCore::AudioNodeInput::enable): + (WebCore::AudioNodeInput::changedOutputs): + (WebCore::AudioNodeInput::updateRenderingState): + (WebCore::AudioNodeInput::numberOfChannels): + (WebCore::AudioNodeInput::numberOfRenderingChannels): + (WebCore::AudioNodeInput::bus): + (WebCore::AudioNodeInput::internalSummingBus): + (WebCore::AudioNodeInput::sumAllConnections): + (WebCore::AudioNodeInput::pull): + * webaudio/AudioNodeInput.h: Added. + (WebCore::AudioNodeInput::node): + (WebCore::AudioNodeInput::context): + (WebCore::AudioNodeInput::numberOfRenderingConnections): + (WebCore::AudioNodeInput::renderingOutput): + (WebCore::AudioNodeInput::isConnected): + (WebCore::AudioNodeInput::numberOfConnections): + +2010-10-26 MORITA Hajime <morrita@google.com> + + Reviewed by Tony Chang. + + Rolling in r70512 again, added missing null-check to + Editor::isSpellCheckingEnabled(). + http://trac.webkit.org/changeset/70512 + + spellcheck='' should be the same as spellcheck="true" + https://bugs.webkit.org/show_bug.cgi?id=25539 + + * dom/Element.cpp: + (WebCore::Element::spellcheckAttributeState): + (WebCore::Element::isSpellCheckingEnabled): + * dom/Element.h: + * editing/Editor.cpp: + (WebCore::markMisspellingsOrBadGrammar): + (WebCore::Editor::isSpellCheckingEnabledInFocusedNode): + (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): + * editing/Editor.h: + * platform/ContextMenu.cpp: + (WebCore::ContextMenu::populate): + +2010-10-26 Brent Fulgham <bfulgham@webkit.org> + + Unreviewed build fixes. + + * WebCore.vcproj/WebCore.vcproj: Turn off several non-WinCairo + files. We don't support CoreAnimation! + * WebCore.vcproj/WebCoreCairo.vsprops: Add missing include path + for 'image-decoders/webp' + * platform/network/curl/CookieJarCurl.cpp: + (WebCore::setCookieStoragePrivateBrowsingEnabled): Add build stub. + +2010-10-26 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Kent Tamura. + + Crash in CompositeEditCommand::splitTreeToNode + https://bugs.webkit.org/show_bug.cgi?id=48349 + + The bug was caused by indentIntoBlockquote's passing null pointer to splitTreeToNode. + Fixed the crash by adding early exits. + + Test: editing/execCommand/indent-node-to-split-to-crash.html + + * editing/CompositeEditCommand.cpp: + (WebCore::CompositeEditCommand::splitTreeToNode): + * editing/IndentOutdentCommand.cpp: + (WebCore::IndentOutdentCommand::indentIntoBlockquote): + +2010-10-26 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Kent Tamura. + + REGRESSION(r67170): crash in removeImplicitlyStyledElement + https://bugs.webkit.org/show_bug.cgi?id=48389 + + Fixed the crash by adding a null pointer check. + + Test: editing/style/invalid-font-size.html + + * editing/ApplyStyleCommand.cpp: + (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): + +2010-10-26 Dimitri Glazkov <dglazkov@chromium.org> + + Unreviewed, rolling out r70573. + http://trac.webkit.org/changeset/70573 + https://bugs.webkit.org/show_bug.cgi?id=48204 + + Broke 39 tests on Chromium + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/scripts/CodeGenerator.pm: + * bindings/scripts/CodeGeneratorJS.pm: + * bindings/scripts/CodeGeneratorObjC.pm: + * bindings/scripts/CodeGeneratorV8.pm: + * svg/DeprecatedSVGAnimatedPropertyTraits.h: + * svg/DeprecatedSVGAnimatedTemplate.h: + * svg/SVGAngle.idl: + * svg/SVGAnimatedAngle.idl: + * svg/SVGAnimatedLength.idl: + * svg/SVGAnimatedLengthList.idl: + * svg/SVGAnimatedRect.h: Removed. + * svg/SVGFitToViewBox.h: + * svg/SVGLength.idl: + * svg/SVGMarkerElement.h: + * svg/SVGPatternElement.h: + * svg/SVGRect.idl: + * svg/SVGSVGElement.cpp: + (WebCore::SVGSVGElement::currentView): + (WebCore::SVGSVGElement::inheritViewAttributes): + * svg/SVGSVGElement.h: + * svg/SVGSVGElement.idl: + * svg/SVGSymbolElement.h: + * svg/SVGViewElement.h: + * svg/SVGViewSpec.cpp: + (WebCore::SVGViewSpec::SVGViewSpec): + * svg/SVGViewSpec.h: + (WebCore::SVGViewSpec::contextElement): + * svg/SVGZoomEvent.idl: + * svg/properties/SVGAnimatedPropertyMacros.h: + +2010-10-26 Anders Carlsson <andersca@apple.com> + + Fix 32-bit build. + + * platform/graphics/mac/FontMac.mm: + (WebCore::showGlyphsWithAdvances): + +2010-10-26 Jenn Braithwaite <jennb@chromium.org> + + Reviewed by Dmitry Titov. + + Resource tracking failure when trying to move a frame between documents + https://bugs.webkit.org/show_bug.cgi?id=44713 + + Test: fast/frames/iframe-reparenting-fail-load.html + + * loader/DocumentLoader.cpp: + (WebCore::DocumentLoader::transferLoadingResourcesFromPage): + Added method that notifies the client to update resource tracking for + loading resources that have been transferred to a different page. + * loader/DocumentLoader.h: + * loader/EmptyClients.h: + (WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage): + Empty method. + * loader/FrameLoader.h: + * loader/FrameLoader.cpp: + Added method that triggers resource tracking updates. This wraps + the DocumentLoader method as it appears DocumentLoader is opaque + to Frame. + * loader/FrameLoaderClient.h: + Added API to notify the client to update resource tracking for + a loading resource that has been transferred to a different page. + * page/Frame.cpp: + (WebCore::Frame::transferChildFrameToNewDocument): + Update resource tracking if page has changed. + +2010-10-26 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Rob Buis. + + Convert SVGRect to the new SVGPropertyTearOff concept + https://bugs.webkit.org/show_bug.cgi?id=48204 + + Convert the next SVG primitive type to use the SVGPropertyTearOff concept: SVGRect. + Added new test verifying that StrictTypeChecking is enabled for SVGRect. Refactor and share code between JSC/V8/ObjC generators. + + Test: svg/dom/SVGRect.html + + * GNUmakefile.am: Add SVGAnimatedRect.h to build. + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * bindings/scripts/CodeGenerator.pm: Refactor SVGPropertyTearOff handling, and share code between JSC/V8/ObjC generators. + * bindings/scripts/CodeGeneratorJS.pm: Ditto. + * bindings/scripts/CodeGeneratorObjC.pm: Ditto. + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedRect handling. + * svg/DeprecatedSVGAnimatedTemplate.h: Ditto. + * svg/SVGAngle.idl: Remove [SVGProperty] flag. + * svg/SVGAnimatedAngle.idl: Remove [SVGAnimatedProperty] flag. + * svg/SVGAnimatedLength.idl: Ditto. + * svg/SVGAnimatedLengthList.idl: Ditto. + * svg/SVGAnimatedRect.h: Added. + * svg/SVGFitToViewBox.h: SVGRect now uses the new tear off concept, adapt code. + * svg/SVGLength.idl: Remove [SVGProperty] flag. + * svg/SVGMarkerElement.h: + * svg/SVGPatternElement.h: + * svg/SVGRect.idl: Remove [PODType] flag, add StrictTypeChecking to all attributes. + * svg/SVGSVGElement.cpp: s/setViewBox/setViewBoxBaseValue/. + (WebCore::SVGSVGElement::currentView): + (WebCore::SVGSVGElement::inheritViewAttributes): + * svg/SVGSVGElement.h: + * svg/SVGSVGElement.idl: Remove [Immutable] flags for SVGRect types, no longer needed. + * svg/SVGSymbolElement.h: + * svg/SVGViewElement.h: + * svg/SVGViewSpec.cpp: Take a SVGElement as context element. + (WebCore::SVGViewSpec::SVGViewSpec): + * svg/SVGViewSpec.h: Ditto. + (WebCore::SVGViewSpec::contextElement): + * svg/SVGZoomEvent.idl: Remove [Immutable] flags for SVGRect types, no longer needed. + * svg/properties/SVGAnimatedPropertyMacros.h: Support declaring animated properties on non-SVGElement types (here: SVGViewSpec), just like the old macros handled it. + +2010-10-26 takano takumi <takano1@asia.apple.com> + + Reviewed by Dave Hyatt. + + Advances are wrong and glyphs are rotated improperly in vertical writing + https://bugs.webkit.org/show_bug.cgi?id=48315 + + We shouldn't use vertical metrics for Roman fonts. Also, we should rotate vertical variant + glyphs back on drawing as the whole run has already been rotated beforehand. + + * platform/graphics/cocoa/FontPlatformDataCocoa.mm: + (WebCore::FontPlatformData::FontPlatformData): Changed to ignore vertical orientation when the font doesn't support vertical metrics. + * platform/graphics/mac/FontMac.mm: + (WebCore::showGlyphsWithAdvances): Changed to rotate glyphs -90 degree for vertical variants. + (WebCore::Font::drawGlyphs): + +2010-10-26 Satish Sampath <satish@chromium.org> + + Reviewed by Jeremy Orlow. + + Add a 'grammar' attribute for speech input. + https://bugs.webkit.org/show_bug.cgi?id=48339 + + To differentiate between various types of speech input, we add a 'x-webkit-grammar' attribute to a + speech enabled input element. This is passed without validation to the speech recognizer. Typical values + could be "builtin:search", "builtin:dictation" and even an externally hosted SRGS grammar XML file URI. + It is up to the recognizer to interpret the value and use it as an aid in recognition. + + * bindings/generic/RuntimeEnabledFeatures.h: + (WebCore::RuntimeEnabledFeatures::webkitGrammarEnabled): + * html/HTMLAttributeNames.in: + * html/HTMLInputElement.idl: + * page/SpeechInput.cpp: + (WebCore::SpeechInput::startRecognition): + * page/SpeechInput.h: + * page/SpeechInputClient.h: + * platform/mock/SpeechInputClientMock.cpp: + (WebCore::SpeechInputClientMock::startRecognition): + * platform/mock/SpeechInputClientMock.h: + * rendering/TextControlInnerElements.cpp: + (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): + +2010-10-26 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: console does not work after two reloads. + https://bugs.webkit.org/show_bug.cgi?id=48318 + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::disconnectFrontend): + +2010-10-26 Pavel Podivilov <podivilov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: console doesn't work in closures when window is overrode + https://bugs.webkit.org/show_bug.cgi?id=48320 + + * inspector/front-end/InjectedScript.js: + (injectedScriptConstructor.): + +2010-10-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Fix an assert with QtPixmapInstance creation. + https://bugs.webkit.org/show_bug.cgi?id=48323 + + This places the newly refcounted QtPixmapInstance in a RefPtr + to prevent an assert on the first ref() call. + + * bridge/qt/qt_pixmapruntime.cpp: + (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject): + +2010-10-26 Kenichi Ishibashi <bashi@google.com> + + Reviewed by Kent Tamura. + + Input Method inserts conversion candidates unexpectedly + https://bugs.webkit.org/show_bug.cgi?id=46868 + + Calls updateStyleIfNeeded() before setting selection for the composition to + avoid inserting the previous composition text into a content editable element + which has an event handler that changes the style of the element. + + Test: platform/chromium/fast/text/chromium-mac-duplicate-ime-composition.html + + * editing/Editor.cpp: + (WebCore::Editor::setComposition): calls updateStyleIfNeeded() before setting selection. + +2010-10-26 Mario Sanchez Prada <msanchez@igalia.com> + + Reviewed by Chris Fleizach. + + [Gtk] Layout tables should indicate that they are not data tables via an object attribute + https://bugs.webkit.org/show_bug.cgi?id=35422 + + Set the 'layout-guess' attribute to 'true' for data tables. + + Reorganized some code in AccessibilityTable so now the function + isDataTable() is more coherent by just answering that very + specific question, regardless of whether the table is being + exposed or not to Assistive Technologies. + + Hence, now it's possible to make two questions separately instead + of just one, meaning that the new function isAccessibleTable() is + now what we formerly defined as the isDataTable() function. + + * accessibility/AccessibilityObject.h: + (WebCore::AccessibilityObject::isAccessibilityTable): + New function to allow asking tables both whether they are + exposed and whether they are data tables, which are different + questions whose answers might be the same in many situations, + but different sometimes (as it can happen in the GTK port). + * accessibility/AccessibilityTable.h: + * accessibility/AccessibilityTable.cpp: + (WebCore::AccessibilityTable::hasARIARole): + New, checks whether the table has a valid ARIA role. + (WebCore::AccessibilityTable::isAccessibilityTable): + New, returns the value of m_isAccessibilityTable. It's + basically the former isDataTable() function renamed. + (WebCore::AccessibilityTable::isDataTable): + Changed behaviour. Instead of just returning the value of + m_isAccessibilityTable as it did so far (which was confusing + because of that's not what the name suggests), focus on + checking whether it's a data table or not and return a bool + value accordingly. It's basically a rename of the former + isTableExposableThroughAccessibility() function, but withouth + the GTK-specific if-endif region (which didn't make sense + here now, because that was answering the question "is the table + exposed in the GTK port?", instead of "is it a data table?"). + (WebCore::AccessibilityTable::isTableExposableThroughAccessibility): + Uses the hasAriaRole(), and isDataTable() to determine whether + a table should be exposed or not. Also includes the GTK-specific + if-region coming from the former implementation of the function + isTableExposableThroughAccessibility() not to check whether it's + a data table in case the rest of the checks succeeded (all + tables are exposed in the GTK port). + (WebCore::AccessibilityTable::addChildren): + Replace usage of isDataTable() with isAccessibilityTable(), to + keep exactly the same behaviour happening before this patch. + (WebCore::AccessibilityTable::roleValue): Ditto. + (WebCore::AccessibilityTable::accessibilityIsIgnored): Ditto. + (WebCore::AccessibilityTable::title): Ditto. + + Updated usage of the former function isDataTable() everywhere + else, replacing it with the new isAccessibilityTable(), so keeping + exactly the same behaviour happening before this patch. + + * accessibility/AccessibilityARIAGrid.cpp: + (WebCore::AccessibilityARIAGrid::addChildren): + Use isAccessibilityTable() instead of isDataTable(). + * accessibility/AccessibilityARIAGridCell.cpp: + (WebCore::AccessibilityARIAGridCell::parentTable): Ditto. + * accessibility/AccessibilityARIAGridRow.cpp: + (WebCore::AccessibilityARIAGridRow::disclosedRows): Ditto. + (WebCore::AccessibilityARIAGridRow::disclosedByRow): Ditto. + (WebCore::AccessibilityARIAGridRow::parentTable): Ditto. + * accessibility/AccessibilityTableCell.cpp: + (WebCore::AccessibilityTableCell::isTableCell): + Use isAccessibilityTable() instead of isDataTable(). + * accessibility/AccessibilityTableHeaderContainer.cpp: + (WebCore::AccessibilityTableHeaderContainer::addChildren): Ditto. + * accessibility/AccessibilityTableRow.cpp: + (WebCore::AccessibilityTableRow::isTableRow): Ditto + * accessibility/mac/AccessibilityObjectWrapper.mm: + (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): + Use isAccessibilityTable() instead of isDataTable(). + (-[AccessibilityObjectWrapper accessibilityAttributeNames]): Ditto. + (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): Ditto. + (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]): Ditto. + (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]): Ditto. + (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): Ditto. + + Use the new function isAccessibilityTable() together with the + modified implementation of isDataTable() to set the 'layout-guess' + attribute when needed. + + * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: + (webkit_accessible_get_attributes): + Set the 'layout-guess' attribute to 'true' to help Assistive + Technologies guessing which tables are not data tables. + +2010-10-26 Chris Marrin <cmarrin@apple.com> + + Reviewed by Simon Fraser. + + Resuming animations causes webkitAnimationStart events to be fired + https://bugs.webkit.org/show_bug.cgi?id=46540 + + Added a flag that makes sure start animation event is only ever + fired once. + + Test: animations/suspend-resume-animation-events.html + + * page/animation/KeyframeAnimation.cpp: + (WebCore::KeyframeAnimation::KeyframeAnimation): + (WebCore::KeyframeAnimation::sendAnimationEvent): + * page/animation/KeyframeAnimation.h: + +2010-10-26 Abhishek Arya <inferno@chromium.org> + + Reviewed by Dimitri Glazkov. + + Added checks to ensure that events types are right before casting. + https://bugs.webkit.org/show_bug.cgi?id=48345 + + * html/ImageDocument.cpp: + (WebCore::ImageEventListener::handleEvent): + * inspector/InspectorDOMStorageResource.cpp: + (WebCore::InspectorDOMStorageResource::handleEvent): + +2010-10-26 Dai Mikurube <dmikurube@google.com> + + Reviewed by Kent Tamura. + + Number values for form controls should be in the range of IEEE 754 + single-precision floating point number + https://bugs.webkit.org/show_bug.cgi?id=48221 + + Changed the range of number values to fit in IEEE 754 single-precision + + * html/parser/HTMLParserIdioms.cpp: + (WebCore::parseToDoubleForNumberType): + * html/NumberInputType.cpp: + +2010-10-26 David Hyatt <hyatt@apple.com> + + Reviewed by Sam Weinig. + + https://bugs.webkit.org/show_bug.cgi?id=48157 + + Direction and writing-mode should propagate from the <body> to the <html> to the initial containing block. + Modify the existing code that propagates from the document element to also propagate from the body. + + Fix the buggy code that was trying to dirty the body when the view changed size if it stretched to fill the + viewport. The code didn't consider the root element, and it only worked with one axis. I pulled it + out of calculateScrollbarModesForLayout, since it should never have been put there in the first place. + + Added four new tests in fast/blockflow. + + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::initElement): + (WebCore::CSSStyleSelector::styleForDocument): + (WebCore::CSSStyleSelector::applyProperty): + * dom/Document.cpp: + (WebCore::Document::Document): + * dom/Document.h: + (WebCore::Document::directionSetOnDocumentElement): + (WebCore::Document::writingModeSetOnDocumentElement): + (WebCore::Document::setDirectionSetOnDocumentElement): + (WebCore::Document::setWritingModeSetOnDocumentElement): + * page/FrameView.cpp: + (WebCore::FrameView::calculateScrollbarModesForLayout): + (WebCore::FrameView::layout): + * rendering/RenderBox.cpp: + (WebCore::RenderBox::styleDidChange): + * rendering/RenderBox.h: + (WebCore::RenderBox::stretchesToViewport): + +2010-10-26 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by David Kilzer. + + Fix Cache::dumpStats formatting + https://bugs.webkit.org/show_bug.cgi?id=48286 + + This updates the column width in the dumpStats output to be wide enough + for all the titles. Previously one of the titles was too wide and crept + into later column space. + + * loader/Cache.cpp: + (WebCore::Cache::dumpStats): make columns 13 characters wide. + +2010-10-26 Alexey Marinichev <amarinichev@chromium.org> + + Reviewed by Kenneth Russell. + + [chromium] Check getGraphicsResetStatusARB and reinitialize the + renderer in an error is returned. + https://bugs.webkit.org/show_bug.cgi?id=47848 + + Tested by failure injection (stopping in the debugger and issuing a + jump as if an error has occurred). + + * platform/graphics/chromium/LayerChromium.cpp: + (WebCore::LayerChromium::setLayerRenderer): + * platform/graphics/chromium/LayerRendererChromium.h: + (WebCore::LayerRendererChromium::transferRootLayer): added + +2010-10-26 Pavel Feldman <pfeldman@chromium.org> + + Not reviewed. Touching inspector controller to kick gtk build, removing comments. + + * inspector/InspectorController.cpp: + * inspector/front-end/ResourceManager.js: + * inspector/front-end/ScriptsPanel.js: + +2010-10-26 Pavel Feldman <pfeldman@chromium.org> + + Web Inspector: continue making resources panel optional. + https://bugs.webkit.org/show_bug.cgi?id=48261 + + This refactoring makes console, audits and extensions tests pass while taking data from + resources panel. Network panel as a source is to follow. + + * inspector/front-end/AuditLauncherView.js: + (WebInspector.AuditLauncherView.prototype._createLauncherUI): + * inspector/front-end/AuditsPanel.js: + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype.addMessage): + * inspector/front-end/CookieItemsView.js: + (WebInspector.CookieItemsView.prototype._filterCookiesForDomain.populateResourcesForDocuments): + (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): + * inspector/front-end/ExtensionServer.js: + (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): + (WebInspector.ExtensionServer.prototype._onGetResources): + (WebInspector.ExtensionServer.prototype._onGetResourceContent): + * inspector/front-end/HAREntry.js: + (WebInspector.HARLog.prototype.build): + (WebInspector.HARLog.prototype.buildMainResourceTimings): + (WebInspector.HARLog.prototype._convertResource): + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel): + (WebInspector.NetworkPanel.prototype._reset): + (WebInspector.NetworkPanel.prototype.get resources): + (WebInspector.NetworkPanel.prototype.addResource): + * inspector/front-end/Resource.js: + (WebInspector.Resource.prototype.set category): + * inspector/front-end/ResourceCategory.js: + (WebInspector.ResourceCategory): + (WebInspector.ResourceCategory.prototype.toString): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager.prototype.identifierForInitialRequest): + (WebInspector.ResourceManager.prototype.willSendRequest): + (WebInspector.ResourceManager.prototype.didFinishLoading): + (WebInspector.ResourceManager.prototype.didFailLoading): + (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): + (WebInspector.ResourceManager.prototype.setOverrideContent): + (WebInspector.ResourceTreeModel.prototype._callForFrameResources): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel): + (WebInspector.ResourcesPanel.prototype.reset): + (WebInspector.ResourcesPanel.prototype.addResource): + (WebInspector.ResourcesPanel.prototype.removeResource): + (WebInspector.ResourcesPanel.prototype._toggleResourceTracking): + * inspector/front-end/ScriptsPanel.js: + (WebInspector.ScriptsPanel.prototype.addScript): + (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): + (WebInspector.ScriptsPanel.prototype._breakpointAdded): + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): + * inspector/front-end/inspector.js: + (WebInspector._updateFocusedNode): + (WebInspector.get networkResources): + (WebInspector.forAllResources): + (WebInspector.resourceForURL): + (WebInspector.updateResource): + (WebInspector.domContentEventFired): + (WebInspector.loadEventFired): + (WebInspector.removeResource): + (WebInspector.reset): + (WebInspector.displayNameForURL): + (WebInspector.linkifyStringAsFragment): + (WebInspector.resourceURLForRelatedNode.callback): + (WebInspector.resourceURLForRelatedNode): + +2010-10-26 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Steve Block. + Fix IndexedDB crashes + https://bugs.webkit.org/show_bug.cgi?id=48266 + + If IDBKey returns null, type conversion failed. Handle this case + in the bindings. + + Change UNKNOWN_ERR to be 1 since 0 is hard coded to mean no error. + This is just a stop-gap move until we get it figured out in standards + land. + + IDBObjectStore needs to handle null ranges. + + It's actually OK for m_transaction to be non-null when hitting the + destructor. We just need to then remove it from the set of pending + transactions. + + The transaction can become aborted in the middle of processing a + list of tasks. Fix this. + + All changes (except the last 2 races) are tested in LayoutTests. + I couldn't find a way to reliably reproduce the races. + + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/scripts/test/V8/V8TestObj.cpp: + (WebCore::TestObjInternal::idbKeyCallback): + * bindings/v8/IDBBindingUtilities.cpp: + (WebCore::createIDBKeyFromValue): + * storage/IDBDatabaseException.h: + * storage/IDBDatabaseException.idl: + * storage/IDBObjectStoreBackendImpl.cpp: + (WebCore::IDBObjectStoreBackendImpl::openCursorInternal): + * storage/IDBRequest.cpp: + (WebCore::IDBRequest::~IDBRequest): + (WebCore::IDBRequest::timerFired): + * storage/IDBTransactionBackendImpl.cpp: + (WebCore::IDBTransactionBackendImpl::taskTimerFired): + +2010-10-25 Andrey Kosyakov <caseq@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: Show cookie data in the request headers in network pane + https://bugs.webkit.org/show_bug.cgi?id=16531 + + * inspector/front-end/CookieItemsView.js: + (WebInspector.CookieItemsView): Factor out common cookies grid logic to CookiesTable + (WebInspector.CookieItemsView.prototype._populateDataGrid): + * inspector/front-end/CookieParser.js: Store cookie type (request/response) within a cookie. + (WebInspector.CookieParser.prototype.parseCookie): + (WebInspector.CookieParser.prototype.parseSetCookie): + (WebInspector.CookieParser.prototype._addCookie): + (WebInspector.Cookie): + * inspector/front-end/DataGrid.js: + (WebInspector.DataGrid.prototype.autoSizeColumns): Optionally, traverse nested nodes when looking for max field widths. + (WebInspector.DataGrid.prototype._enumerateChildren): + (WebInspector.DataGrid.prototype.updateWidths): Skip attempt to calculate column widths if grid is not attached to DOM tree yet. + * inspector/front-end/FontView.js: + (WebInspector.FontView.prototype.resize): + * inspector/front-end/ResourceView.js: + (WebInspector.ResourceView.prototype.resize): + (WebInspector.ResourceView.prototype._selectTab): + (WebInspector.ResourceView.prototype._selectCookiesTab): + (WebInspector.ResourceView.prototype._innerSelectContentTab): + (WebInspector.ResourceView.prototype._refreshRequestHeaders): + (WebInspector.ResourceView.prototype._refreshResponseHeaders): + (WebInspector.ResourceView.prototype._refreshHeaders): + (WebInspector.ResourceView.prototype._refreshCookies): + (WebInspector.ResourceCookiesTab): + (WebInspector.ResourceCookiesTab.prototype.set requestCookies): + (WebInspector.ResourceCookiesTab.prototype.set responseCookies): + (WebInspector.ResourceCookiesTab.prototype._populateDataGrid): + (WebInspector.ResourceCookiesTab.prototype._populateCookies): + (WebInspector.ResourceCookiesTab.prototype._createFolder): + * inspector/front-end/SourceView.js: + (WebInspector.SourceView.prototype.resize): + * inspector/front-end/inspector.css: + (.resource-view .resource-view-cookies): + (.resource-view.headers-visible .resource-view-cookies): + (.resource-view-cookies.table .data-grid): + (.resource-view-cookies .data-grid .row-group): + +2010-10-26 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r70518. + http://trac.webkit.org/changeset/70518 + https://bugs.webkit.org/show_bug.cgi?id=48332 + + Breaks inspector tests. (Requested by pfeldman on #webkit). + + * inspector/front-end/AuditLauncherView.js: + (WebInspector.AuditLauncherView.prototype._createLauncherUI): + * inspector/front-end/AuditsPanel.js: + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype.addMessage): + * inspector/front-end/CookieItemsView.js: + (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): + * inspector/front-end/ExtensionServer.js: + (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): + (WebInspector.ExtensionServer.prototype._onGetResources): + (WebInspector.ExtensionServer.prototype._onGetResourceContent): + * inspector/front-end/HAREntry.js: + (WebInspector.HARLog.prototype.build): + (WebInspector.HARLog.prototype.buildMainResourceTimings): + (WebInspector.HARLog.prototype._convertResource): + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel): + (WebInspector.NetworkPanel.prototype._reset): + (WebInspector.NetworkPanel.prototype.addResource): + * inspector/front-end/Resource.js: + (WebInspector.Resource.prototype.set category): + * inspector/front-end/ResourceCategory.js: + (WebInspector.ResourceCategory): + (WebInspector.ResourceCategory.prototype.toString): + (WebInspector.ResourceCategory.prototype.addResource): + (WebInspector.ResourceCategory.prototype.removeResource): + (WebInspector.ResourceCategory.prototype.removeAllResources): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager.prototype.identifierForInitialRequest): + (WebInspector.ResourceManager.prototype.willSendRequest): + (WebInspector.ResourceManager.prototype.didFinishLoading): + (WebInspector.ResourceManager.prototype.didFailLoading): + (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): + (WebInspector.ResourceManager.prototype.setOverrideContent): + (WebInspector.ResourceTreeModel.prototype._callForFrameResources): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel): + (WebInspector.ResourcesPanel.prototype.reset): + (WebInspector.ResourcesPanel.prototype.addResource): + (WebInspector.ResourcesPanel.prototype.removeResource): + (WebInspector.ResourcesPanel.prototype._toggleResourceTracking): + * inspector/front-end/ScriptsPanel.js: + (WebInspector.ScriptsPanel.prototype.addScript): + (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): + (WebInspector.ScriptsPanel.prototype._breakpointAdded): + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): + * inspector/front-end/inspector.js: + (WebInspector._updateFocusedNode): + (WebInspector.updateResource): + (WebInspector.domContentEventFired): + (WebInspector.loadEventFired): + (WebInspector.removeResource): + (WebInspector.reset): + (WebInspector.displayNameForURL): + (WebInspector.resourceForURL): + (WebInspector.linkifyStringAsFragment): + (WebInspector.resourceURLForRelatedNode): + +2010-10-26 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Steve Block. + + Quota for IndexedDB should be per origin not per database + https://bugs.webkit.org/show_bug.cgi?id=48064 + + Merge all databases for each origin into a single SQLiteDatabase. + + Replace the awkward metaData table with a Database table. + + Create a new IDBSQLiteDatabase class that wraps SQLiteDatabase + and implements weak pointer semantics for IDBFactory. It's ref + counted so multiple IDBDatabaseBackendImpls can share one. + + Fix uniqueness constraints that were overly conservitive. + + Get rid of the code that blows away existing data every time + the database is opened. + + Get rid of the fairly useless indexedDB manual test and replace + it with one that verifies data persists. + + Use name+origin (not just name) in our cache of IDBDatabaseBackend + objects (so one origin can't access anothers' data). + + Test: storage/indexeddb/duplicates.html + + * WebCore.gypi: + * manual-tests/indexed-database.html: Removed. + * manual-tests/indexeddb-persists.html: Added. + * storage/IDBDatabaseBackendImpl.cpp: + (WebCore::extractMetaData): + (WebCore::setMetaData): + (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): + (WebCore::IDBDatabaseBackendImpl::setDescription): + (WebCore::IDBDatabaseBackendImpl::sqliteDatabase): + (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal): + (WebCore::IDBDatabaseBackendImpl::setVersionInternal): + (WebCore::IDBDatabaseBackendImpl::loadObjectStores): + * storage/IDBDatabaseBackendImpl.h: + (WebCore::IDBDatabaseBackendImpl::create): + (WebCore::IDBDatabaseBackendImpl::id): + * storage/IDBFactoryBackendImpl.cpp: + (WebCore::IDBFactoryBackendImpl::removeSQLiteDatabase): + (WebCore::openSQLiteDatabase): + (WebCore::createTables): + (WebCore::IDBFactoryBackendImpl::open): + (WebCore::IDBFactoryBackendImpl::databaseFileName): + * storage/IDBFactoryBackendImpl.h: + * storage/IDBObjectStoreBackendImpl.cpp: + (WebCore::putObjectStoreData): + (WebCore::IDBObjectStoreBackendImpl::putInternal): + * storage/IDBSQLiteDatabase.cpp: Added. + (WebCore::IDBSQLiteDatabase::IDBSQLiteDatabase): + (WebCore::IDBSQLiteDatabase::~IDBSQLiteDatabase): + * storage/IDBSQLiteDatabase.h: Added. + (WebCore::IDBSQLiteDatabase::create): + (WebCore::IDBSQLiteDatabase::db): + +2010-10-20 Andrey Kosyakov <caseq@chromium.org> + + Reviewed by Yury Semikhatsky. + + Inspector needs to use cached resources to display image resources. + https://bugs.webkit.org/show_bug.cgi?id=16395 + + * inspector/Inspector.idl: Add base64Encode parameter to getContent + * inspector/InspectorResourceAgent.cpp: + (WebCore::InspectorResourceAgent::resourceContent): + * inspector/InspectorResourceAgent.h: + * inspector/front-end/ExtensionServer.js: + (WebInspector.ExtensionServer.prototype._onGetResourceContent): + * inspector/front-end/ImageView.js: + (WebInspector.ImageView.prototype.contentTabSelected.onResourceContent): + (WebInspector.ImageView.prototype.contentTabSelected): + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkDataGridNode.prototype._refreshNameCell.): + (WebInspector.NetworkDataGridNode.prototype._refreshNameCell): + * inspector/front-end/Resource.js: + (WebInspector.Resource): + (WebInspector.Resource.prototype.set finished): + (WebInspector.Resource.prototype.getContent): + (WebInspector.Resource.prototype.get contentURL): + (WebInspector.Resource.prototype._requestContent.onResourceContent): + (WebInspector.Resource.prototype._requestContent): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourceSidebarTreeElement.prototype.createIconElement.): + (WebInspector.ResourceSidebarTreeElement.prototype.createIconElement): + * inspector/front-end/Settings.js: Added useDataURLForResourceImageIcons + * inspector/front-end/SourceView.js: + (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): + +2010-10-26 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: continue making resources panel optional. + https://bugs.webkit.org/show_bug.cgi?id=48261 + + This refactoring makes console, audits and extensions tests pass while taking data from + resources panel. Network panel as a source is to follow. + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::connectFrontend): + * inspector/front-end/AuditLauncherView.js: + (WebInspector.AuditLauncherView.prototype._createLauncherUI): + * inspector/front-end/AuditsPanel.js: + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype.addMessage): + * inspector/front-end/CookieItemsView.js: + (WebInspector.CookieItemsView.prototype._filterCookiesForDomain.populateResourcesForDocuments): + (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): + * inspector/front-end/ExtensionServer.js: + (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): + (WebInspector.ExtensionServer.prototype._onGetResources): + (WebInspector.ExtensionServer.prototype._onGetResourceContent): + * inspector/front-end/HAREntry.js: + (WebInspector.HARLog.prototype.build): + (WebInspector.HARLog.prototype.buildMainResourceTimings): + (WebInspector.HARLog.prototype._convertResource): + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel): + (WebInspector.NetworkPanel.prototype._reset): + (WebInspector.NetworkPanel.prototype.get resources): + (WebInspector.NetworkPanel.prototype.addResource): + * inspector/front-end/Resource.js: + (WebInspector.Resource.prototype.set category): + * inspector/front-end/ResourceCategory.js: + (WebInspector.ResourceCategory): + (WebInspector.ResourceCategory.prototype.toString): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager.prototype.identifierForInitialRequest): + (WebInspector.ResourceManager.prototype.willSendRequest): + (WebInspector.ResourceManager.prototype.didFinishLoading): + (WebInspector.ResourceManager.prototype.didFailLoading): + (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): + (WebInspector.ResourceManager.prototype.setOverrideContent): + (WebInspector.ResourceTreeModel.prototype._callForFrameResources): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel): + (WebInspector.ResourcesPanel.prototype.reset): + (WebInspector.ResourcesPanel.prototype.addResource): + (WebInspector.ResourcesPanel.prototype.removeResource): + (WebInspector.ResourcesPanel.prototype._toggleResourceTracking): + * inspector/front-end/ScriptsPanel.js: + (WebInspector.ScriptsPanel.prototype.addScript): + (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): + (WebInspector.ScriptsPanel.prototype._breakpointAdded): + * inspector/front-end/Settings.js: + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): + * inspector/front-end/inspector.js: + (WebInspector._updateFocusedNode): + (WebInspector.get networkResources): + (WebInspector.forAllResources): + (WebInspector.resourceForURL): + (WebInspector.updateResource): + (WebInspector.domContentEventFired): + (WebInspector.loadEventFired): + (WebInspector.removeResource): + (WebInspector.reset): + (WebInspector.displayNameForURL): + (WebInspector.linkifyStringAsFragment): + (WebInspector.resourceURLForRelatedNode.callback): + (WebInspector.resourceURLForRelatedNode): + +2010-10-26 Abhishek Arya <inferno@chromium.org> + + Reviewed by Adam Barth. + + Protect the frame from being blown away in loadWithDocumentLoader function call. + dispatchBeforeLoadEvent can cause the frame to be freed, which gets later used in + continueLoadAfterNavigationPolicy call. + https://bugs.webkit.org/show_bug.cgi?id=48281 + + Test: fast/events/form-iframe-target-before-load-crash.html + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::loadWithDocumentLoader): + +2010-10-26 Xan Lopez <xlopez@igalia.com> + + Restore another mix-up in copy&paste error. Use height for the + vertical adjustments instead of width. + + * platform/gtk/ScrollViewGtk.cpp: + (WebCore::ScrollView::setVerticalAdjustment): + +2010-10-26 Xan Lopez <xlopez@igalia.com> + + Restore early return accidentally removed in previous + patch. Should make API tests pass again. + + * platform/gtk/ScrollViewGtk.cpp: + (WebCore::ScrollView::setHorizontalAdjustment): + (WebCore::ScrollView::setVerticalAdjustment): + +2010-10-26 Xan Lopez <xlopez@igalia.com> + + Reviewed by Martin Robinson. + + [GTK] Port to new GtkScrollable interface in GTK+ 3.x + https://bugs.webkit.org/show_bug.cgi?id=48202 + + The new GtkScrollable API sets the adjustments individually, so + adjust the code for this fact. + + * platform/ScrollView.h: + * platform/gtk/ScrollViewGtk.cpp: + (WebCore::ScrollView::setHorizontalAdjustment): new method to set the horizontal adjustment. + (WebCore::ScrollView::setVerticalAdjustment): new method to set the vertical adjustment. + (WebCore::ScrollView::setGtkAdjustments): make this just call the other two methods. + +2010-10-26 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r70512. + http://trac.webkit.org/changeset/70512 + https://bugs.webkit.org/show_bug.cgi?id=48314 + + crashes many tests (Requested by inferno-sec on #webkit). + + * dom/Element.cpp: + * dom/Element.h: + * editing/Editor.cpp: + (WebCore::markMisspellingsOrBadGrammar): + (WebCore::Editor::spellCheckingEnabledInFocusedNode): + (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): + * editing/Editor.h: + * platform/ContextMenu.cpp: + (WebCore::ContextMenu::populate): + +2010-10-24 MORITA Hajime <morrita@google.com> + + Reviewed by Tony Chang. + + spellcheck='' should be the same as spellcheck="true" + https://bugs.webkit.org/show_bug.cgi?id=25539 + + - Added a check for empty string and missing attribute. + - Extracted the check to Element::spellCheckingEnabled() + - Introduced SpellcheckAttributeState enum to represent the + states for spellcheck attributes. + + * dom/Element.cpp: + (WebCore::Element::spellcheckAttributeState): Added. + (WebCore::Element::isSpellCheckingEnabled): Added. + * dom/Element.h: + * editing/Editor.cpp: + (WebCore::markMisspellingsOrBadGrammar): + (WebCore::Editor::isSpellCheckingEnabledInFocusedNode): Renamed, partly extracted to Element::isSpellCheckingEnabled() + (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): + * editing/Editor.h: + * platform/ContextMenu.cpp: + (WebCore::ContextMenu::populate): + +2010-10-25 Kent Tamura <tkent@chromium.org> + + Reviewed by Darin Adler. + + Refactor HTMLInputElement: Move createRender(), appendFormData(), + saveFormControlState() and restoreFormControlState() to InputTypes. + https://bugs.webkit.org/show_bug.cgi?id=47834 + + This change adds BaseButtonInputType and BaseCheckableInputType. They + are super classes of some concrete InputType classes. + + No new tests. Just a code refactoring. + + * CMakeLists.txt: Add BaseButtonInputType and BaseCheckableInputType files. + * GNUmakefile.am: ditto. + * WebCore.gypi: ditto. + * WebCore.pro: ditto. + * WebCore.vcproj/WebCore.vcproj: ditto. + * WebCore.xcodeproj/project.pbxproj: ditto. + * html/BaseButtonInputType.cpp: Added. + (WebCore::BaseButtonInputType::appendFormData): + (WebCore::BaseButtonInputType::createRenderer): + * html/BaseButtonInputType.h: Added. + (WebCore::BaseButtonInputType::BaseButtonInputType): + * html/BaseCheckableInputType.cpp: Added. + (WebCore::BaseCheckableInputType::saveFormControlState): + (WebCore::BaseCheckableInputType::restoreFormControlState): + (WebCore::BaseCheckableInputType::appendFormData): + * html/BaseCheckableInputType.h: Added. + (WebCore::BaseCheckableInputType::BaseCheckableInputType): + * html/ButtonInputType.h: Change the super class. + (WebCore::ButtonInputType::ButtonInputType): + * html/CheckboxInputType.h: Change the super class. + (WebCore::CheckboxInputType::CheckboxInputType): + * html/FileInputType.cpp: + (WebCore::FileInputType::appendFormData): + (WebCore::FileInputType::createRenderer): + * html/FileInputType.h: Change the super class. + (WebCore::FileInputType::FileInputType): + * html/HTMLFormControlElement.h: + Make placeholderShouldBeVisible() public for access from TextFieldInputType. + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::saveFormControlState): + (WebCore::HTMLInputElement::restoreFormControlState): + (WebCore::HTMLInputElement::createRenderer): + (WebCore::HTMLInputElement::appendFormData): + * html/HTMLInputElement.h: + Add the following functions for ImageInputType and SubmitInputType. + (WebCore::HTMLInputElement::xPosition): + (WebCore::HTMLInputElement::yPosition): + * html/HiddenInputType.cpp: + (WebCore::HiddenInputType::createRenderer): + * html/HiddenInputType.h: + * html/ImageInputType.cpp: + (WebCore::ImageInputType::isFormDataAppendable): + (WebCore::ImageInputType::appendFormData): + (WebCore::ImageInputType::createRenderer): + * html/ImageInputType.h: Change the super class. + (WebCore::ImageInputType::ImageInputType): + * html/InputType.cpp: + (WebCore::InputType::saveFormControlState): + (WebCore::InputType::restoreFormControlState): + (WebCore::InputType::isFormDataAppendable): + (WebCore::InputType::appendFormData): + (WebCore::InputType::createRenderer): + * html/InputType.h: + * html/PasswordInputType.cpp: + (WebCore::PasswordInputType::saveFormControlState): + (WebCore::PasswordInputType::restoreFormControlState): + * html/PasswordInputType.h: + * html/RadioInputType.h: Change the super class. + (WebCore::RadioInputType::RadioInputType): + * html/RangeInputType.cpp: + (WebCore::RangeInputType::createRenderer): + * html/RangeInputType.h: + * html/ResetInputType.h: + (WebCore::ResetInputType::ResetInputType): + * html/SubmitInputType.cpp: + (WebCore::SubmitInputType::appendFormData): + * html/SubmitInputType.h: Change the super class. + (WebCore::SubmitInputType::SubmitInputType): + * html/TextFieldInputType.cpp: + (WebCore::TextFieldInputType::createRenderer): + * html/TextFieldInputType.h: + +2010-10-25 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dan Bernstein. + + Fix scrolling of noncomposited iframes within composited document + https://bugs.webkit.org/show_bug.cgi?id=47391 + + When an iframe that is painting into a compositing layer is scrolled, + we need to repaint via the RenderObject (which dirties the compositing layer contents), + rather than going out to hostWindow. + + Test: compositing/iframes/composited-iframe-scroll.html + + * page/FrameView.cpp: + (WebCore::FrameView::scrollContentsSlowPath): + * page/FrameView.h: + * platform/ScrollView.cpp: + (WebCore::ScrollView::scrollContents): + (WebCore::ScrollView::scrollContentsSlowPath): + * platform/ScrollView.h: + +2010-10-25 Ryosuke Niwa <rniwa@webkit.org> + + Unreviewed Qt build fix for r70496. + + * bridge/qt/qt_instance.cpp: + (JSC::Bindings::QtInstance::numberValue): + * bridge/qt/qt_pixmapruntime.cpp: + (JSC::Bindings::QtPixmapWidthField::valueFromInstance): + (JSC::Bindings::QtPixmapHeightField::valueFromInstance): + * bridge/qt/qt_runtime.cpp: + (JSC::Bindings::convertValueToQVariant): + (JSC::Bindings::convertQVariantToValue): + (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): + (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter): + +2010-10-25 Andy Estes <aestes@apple.com> + + Reviewed by Simon Fraser. + + Source change by Simon Fraser. + + Setting an element's visibility property to visible has no effect when + it has a hidden parent. + https://bugs.webkit.org/show_bug.cgi?id=48267 + + Test: fast/layers/visible-layer-with-hidden-parent.html + + When a layer is hidden, there is an optimization that removes it from + the layer tree. If the layer is made visible again, it would only mark + its own stacking context's z-order list as dirty. If there are hidden + parent layers, they need to be marked dirty as well so layers with + visible descendents are re-added to the layer tree. + + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::setHasVisibleContent): Dirty the z-order lists of + all parent stacking context render layers up to and including the first + visible stacking context. + +2010-10-25 Oliver Hunt <oliver@apple.com> + + Reviewed by Gavin Barraclough. + + Remove exec and globalData arguments from jsNumber + https://bugs.webkit.org/show_bug.cgi?id=48270 + + Mechanical removal of exec parameter to jsNumber. + + * bindings/js/JSAudioConstructor.cpp: + (WebCore::JSAudioConstructor::JSAudioConstructor): + * bindings/js/JSCSSStyleDeclarationCustom.cpp: + (WebCore::JSCSSStyleDeclaration::nameGetter): + * bindings/js/JSCoordinatesCustom.cpp: + (WebCore::JSCoordinates::altitude): + (WebCore::JSCoordinates::altitudeAccuracy): + (WebCore::JSCoordinates::heading): + (WebCore::JSCoordinates::speed): + * bindings/js/JSDOMWindowCustom.cpp: + (WebCore::JSDOMWindow::setTimeout): + (WebCore::JSDOMWindow::setInterval): + * bindings/js/JSDeviceMotionEventCustom.cpp: + (WebCore::createAccelerationObject): + (WebCore::createRotationRateObject): + (WebCore::JSDeviceMotionEvent::interval): + * bindings/js/JSDeviceOrientationEventCustom.cpp: + (WebCore::JSDeviceOrientationEvent::alpha): + (WebCore::JSDeviceOrientationEvent::beta): + (WebCore::JSDeviceOrientationEvent::gamma): + * bindings/js/JSGeolocationCustom.cpp: + (WebCore::JSGeolocation::watchPosition): + * bindings/js/JSHTMLInputElementCustom.cpp: + (WebCore::JSHTMLInputElement::selectionStart): + (WebCore::JSHTMLInputElement::selectionEnd): + * bindings/js/JSHTMLOptionsCollectionCustom.cpp: + (WebCore::JSHTMLOptionsCollection::length): + * bindings/js/JSIDBKeyCustom.cpp: + (WebCore::toJS): + * bindings/js/JSInjectedScriptHostCustom.cpp: + (WebCore::InjectedScriptHost::createInjectedScript): + (WebCore::JSInjectedScriptHost::pushNodePathToFrontend): + * bindings/js/JSOptionConstructor.cpp: + (WebCore::JSOptionConstructor::JSOptionConstructor): + * bindings/js/JSSQLResultSetRowListCustom.cpp: + (WebCore::JSSQLResultSetRowList::item): + * bindings/js/JSSVGLengthCustom.cpp: + (WebCore::JSSVGLength::value): + * bindings/js/JSScriptProfileNodeCustom.cpp: + (WebCore::JSScriptProfileNode::callUID): + * bindings/js/JSWebGLRenderingContextCustom.cpp: + (WebCore::toJS): + * bindings/js/JSWorkerContextCustom.cpp: + (WebCore::JSWorkerContext::setTimeout): + (WebCore::JSWorkerContext::setInterval): + * bindings/js/JSWorkerContextErrorHandler.cpp: + (WebCore::JSWorkerContextErrorHandler::handleEvent): + * bindings/js/ScriptFunctionCall.cpp: + (WebCore::ScriptCallArgumentHandler::appendArgument): + * bindings/js/SerializedScriptValue.cpp: + (WebCore::CloneDeserializer::readTerminal): + * bindings/scripts/CodeGeneratorJS.pm: + * bridge/c/c_instance.cpp: + (JSC::Bindings::CInstance::numberValue): + * bridge/c/c_utility.cpp: + (JSC::Bindings::convertNPVariantToValue): + * bridge/jni/jsc/JNIBridgeJSC.cpp: + (JavaField::valueFromInstance): + (JavaArray::valueAt): + * bridge/jni/jsc/JavaInstanceJSC.cpp: + (JavaInstance::numberValue): + (JavaInstance::invokeMethod): + * bridge/objc/objc_instance.mm: + (ObjcInstance::numberValue): + * bridge/objc/objc_utility.mm: + (JSC::Bindings::convertObjcValueToValue): + * bridge/runtime_array.cpp: + (JSC::RuntimeArray::lengthGetter): + * bridge/runtime_method.cpp: + (JSC::RuntimeMethod::lengthGetter): + +2010-10-21 Satish Sampath <satish@chromium.org> + + Reviewed by Jeremy Orlow. + + Allow embedder to pass on all the speech recognition results to the input element. + https://bugs.webkit.org/show_bug.cgi?id=48068 + + No new tests added as functionality has not changed, tests will be added in the next + patch where these results are exposed as an attribute to scripts. + + * Android.mk: Added new source files. + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.xcodeproj/project.pbxproj: + * page/SpeechInput.cpp: + (WebCore::SpeechInput::setRecognitionResult): Accept an array instead of a single string. + * page/SpeechInput.h: + * page/SpeechInputListener.h: + * page/SpeechInputResult.cpp: Added, defines a class for managing a speech input result. + (WebCore::SpeechInputResult::create): + (WebCore::SpeechInputResult::SpeechInputResult): + (WebCore::SpeechInputResult::confidence): + (WebCore::SpeechInputResult::utterance): + * page/SpeechInputResult.h: Added. + * platform/mock/SpeechInputClientMock.cpp: + (WebCore::SpeechInputClientMock::timerFired): + * rendering/TextControlInnerElements.cpp: + (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): + * rendering/TextControlInnerElements.h: + +2010-10-25 Jian Li <jianli@chromium.org> + + Reviewed by David Levin. + + Support appending an ArrayBuffer object in BlobBuilder + https://bugs.webkit.org/show_bug.cgi?id=47701 + + Test cases have been added to read-blob-test-cases.js. + + * fileapi/BlobBuilder.cpp: + (WebCore::BlobBuilder::getBuffer): + (WebCore::BlobBuilder::append): Removed bool return values since they + weren't used. + * fileapi/BlobBuilder.h: + * fileapi/BlobBuilder.idl: + +2010-10-25 No'am Rosenthal <noam.rosenthal@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Texmap] [Qt] Texture mapper initial implementation + https://bugs.webkit.org/show_bug.cgi?id=47070 + + Glue layer (WebCoreSupport) changes to allow connecting TextureMapper to a Qt PageClient, i.e. + a QWebView or a QGraphicsWebView. This enables the new type, TextureMapperPlatformLayer, to be recognized both by + the compositor and by the page client. + Note that this is temporarily an opt-in, under USE(TEXTURE_MAPPER) + + No new tests: the existing tests under LayoutTests/compositing already cover this. + + * platform/graphics/GraphicsLayer.h: + * platform/qt/QWebPageClient.h: + (QWebPageClient::setRootGraphicsLayer): + +2010-10-25 No'am Rosenthal <noam.rosenthal@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Texmap] [Qt] Texture mapper initial implementation + https://bugs.webkit.org/show_bug.cgi?id=47070 + + Add a config flag and a define (WTF_USE_TEXTURE_MAPPER) to WebCore, to enable opt-in compilation of texture-mapper with Qt. + + No new tests: WIP for a new implementation. + + * WebCore.pro: + +2010-10-25 Jian Li <jianli@chromium.org> + + Reviewed by David Levin. + + Calling FileReader.abort during reading could cause crash + https://bugs.webkit.org/show_bug.cgi?id=48163 + + Test: fast/files/file-reader-abort.html + + * fileapi/FileReader.cpp: + (WebCore::delayedAbort): + (WebCore::FileReader::abort): Schedule to do the abort later to work + around the case that abort() could be called from event handler. + (WebCore::FileReader::doAbort): + (WebCore::FileReader::didFail): Do not go with normal error handling + when we are in the process of aborting. + (WebCore::FileReader::failed): + (WebCore::FileReader::readyState): + * fileapi/FileReader.h: + +2010-10-25 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Roben. + + [WINCE] Buildfix for NetworkStateNotifier + https://bugs.webkit.org/show_bug.cgi?id=48240 + + WinCE does not support RegisterWaitForSingleObject, so disable it for now. + + * platform/network/win/NetworkStateNotifierWin.cpp: + (WebCore::NetworkStateNotifier::NetworkStateNotifier): + +2010-10-25 David Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=48257 + + Make "rl" and "bt" writing-modes work for blocks and lines. InlineTextBox is refactored to compute the correct + top left corner and left baseline edge once so that can be passed down to all the painting functions instead of + tx and ty. + + adjustment helpers have been added that can be called before painting children or lines and that fix up + the coordinates from flipped to physical. + + Added fast/blockflow/english-rl-text.html and fast/blockflow/english-bt-text.html + + * rendering/InlineBox.cpp: + (WebCore::InlineBox::adjustForFlippedBlocksWritingMode): + * rendering/InlineBox.h: + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::paintBoxDecorations): + (WebCore::InlineFlowBox::paintMask): + * rendering/InlineTextBox.cpp: + (WebCore::paintTextWithShadows): + (WebCore::InlineTextBox::paint): + (WebCore::InlineTextBox::paintSelection): + (WebCore::InlineTextBox::paintCompositionBackground): + (WebCore::InlineTextBox::paintDecoration): + (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): + (WebCore::InlineTextBox::paintTextMatchMarker): + (WebCore::InlineTextBox::computeRectForReplacementMarker): + (WebCore::InlineTextBox::paintDocumentMarkers): + (WebCore::InlineTextBox::paintCompositionUnderline): + * rendering/InlineTextBox.h: + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::paintChildren): + (WebCore::RenderBlock::paintFloats): + * rendering/RenderBox.cpp: + (WebCore::RenderBox::adjustForFlippedBlocksWritingMode): + * rendering/RenderBox.h: + * rendering/style/RenderStyle.h: + (WebCore::InheritedFlags::isFlippedBlocksWritingMode): + +2010-10-25 Ben Murdoch <benm@google.com> + + Reviewed by Steve Block. + + Build break with ENABLE(BLOB) and not ENABLE(3D_CANVAS) + https://bugs.webkit.org/show_bug.cgi?id=48243 + + Build fix only so no new tests. + + * bindings/generic/RuntimeEnabledFeatures.h: Guard appropriately. + * bindings/v8/custom/V8ArrayBufferViewCustom.h: ditto. + +2010-10-25 Cris Neckar <cdn@chromium.org> + + Reviewed by Dimitri Glazkov. + + Added check to ensure that events with the type "mousedown" are mouse events before dispatching. + https://bugs.webkit.org/show_bug.cgi?id=48159 + + Test: fast/events/keyboardevent-mousedown-crash.html + + * dom/Node.cpp: + (WebCore::Node::defaultEventHandler): + +2010-10-25 Kwang Yul Seo <skyul@company100.net> + + Unreviewed build fix for r70400. + + Add dummy setCookieStoragePrivateBrowsingEnabled. + + * platform/brew/TemporaryLinkStubs.cpp: Added. + (WebCore::setCookieStoragePrivateBrowsingEnabled): + +2010-10-25 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Roben. + + [WINCE] Use default implementation of AXObjectCache::platformGenerateAXID + https://bugs.webkit.org/show_bug.cgi?id=48239 + + WinCE does not support NotifyWinEvent, so use the default implementation. + + * accessibility/AXObjectCache.cpp: + +2010-10-25 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + Need WebKit2 API to figure out if a frame can provide source + <rdar://problem/8424632> + https://bugs.webkit.org/show_bug.cgi?id=48252 + + * WebCore.exp.in: + +2010-10-25 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r70451. + http://trac.webkit.org/changeset/70451 + https://bugs.webkit.org/show_bug.cgi?id=48249 + + Broke set-unloaded-frame-location.html under Qt (Requested by + caseq on #webkit). + + * ForwardingHeaders/wtf/text/TextPosition.h: Removed. + * bindings/js/ScriptSourceCode.h: + (WebCore::ScriptSourceCode::ScriptSourceCode): + * bindings/v8/ScheduledAction.cpp: + (WebCore::ScheduledAction::ScheduledAction): + * bindings/v8/ScriptController.cpp: + (WebCore::ScriptController::eventHandlerLineNumber): + (WebCore::ScriptController::eventHandlerColumnNumber): + * bindings/v8/ScriptController.h: + * bindings/v8/ScriptEventListener.cpp: + (WebCore::createAttributeEventListener): + * bindings/v8/ScriptSourceCode.h: + (WebCore::ScriptSourceCode::ScriptSourceCode): + (WebCore::ScriptSourceCode::startLine): + * bindings/v8/V8LazyEventListener.cpp: + (WebCore::V8LazyEventListener::V8LazyEventListener): + (WebCore::V8LazyEventListener::prepareListenerObject): + * bindings/v8/V8LazyEventListener.h: + (WebCore::V8LazyEventListener::create): + * bindings/v8/V8Proxy.cpp: + (WebCore::V8Proxy::compileScript): + (WebCore::V8Proxy::evaluate): + (WebCore::V8Proxy::runScript): + * bindings/v8/V8Proxy.h: + * bindings/v8/WorkerContextExecutionProxy.cpp: + (WebCore::WorkerContextExecutionProxy::evaluate): + (WebCore::WorkerContextExecutionProxy::runScript): + * bindings/v8/WorkerContextExecutionProxy.h: + * bindings/v8/WorkerScriptController.cpp: + (WebCore::WorkerScriptController::evaluate): + * dom/PendingScript.cpp: + (WebCore::PendingScript::releaseElementAndClear): + * dom/PendingScript.h: + (WebCore::PendingScript::PendingScript): + (WebCore::PendingScript::operator=): + (WebCore::PendingScript::startingLineNumber): + * dom/ScriptableDocumentParser.h: + * dom/XMLDocumentParser.h: + * dom/XMLDocumentParserLibxml2.cpp: + (WebCore::XMLDocumentParser::XMLDocumentParser): + (WebCore::XMLDocumentParser::startElementNs): + (WebCore::XMLDocumentParser::endElementNs): + (WebCore::XMLDocumentParser::lineNumber): + (WebCore::XMLDocumentParser::columnNumber): + * dom/XMLDocumentParserQt.cpp: + (WebCore::XMLDocumentParser::XMLDocumentParser): + (WebCore::XMLDocumentParser::parseStartElement): + (WebCore::XMLDocumentParser::parseEndElement): + * html/parser/HTMLDocumentParser.cpp: + (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): + (WebCore::HTMLDocumentParser::columnNumber): + * html/parser/HTMLDocumentParser.h: + * html/parser/HTMLScriptRunner.cpp: + (WebCore::HTMLScriptRunner::sourceFromPendingScript): + (WebCore::HTMLScriptRunner::execute): + (WebCore::HTMLScriptRunner::runScript): + * html/parser/HTMLScriptRunner.h: + * html/parser/HTMLTreeBuilder.cpp: + (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): + (WebCore::HTMLTreeBuilder::takeScriptToProcess): + (WebCore::HTMLTreeBuilder::processEndTag): + (WebCore::HTMLTreeBuilder::processScriptStartTag): + * html/parser/HTMLTreeBuilder.h: + +2010-10-25 Kwang Yul Seo <skyul@company100.net> + + Unreviewed build fix for r70095. + + Provide platformDefaultLanguage(). + + * platform/brew/LanguageBrew.cpp: Added. + (WebCore::platformDefaultLanguage): + * platform/brew/LocalizedStringsBrew.cpp: + +2010-10-25 Patrick Gansterer <paroga@webkit.org> + + Reviewed by David Kilzer. + + Replace _countof with WTF_ARRAY_LENGTH + https://bugs.webkit.org/show_bug.cgi?id=48229 + + * platform/win/FileSystemWin.cpp: + (WebCore::openTemporaryFile): + * platform/wince/FileSystemWinCE.cpp: + (WebCore::openTemporaryFile): + * plugins/win/PluginDatabaseWin.cpp: + (WebCore::addPluginPathsFromRegistry): + (WebCore::addWindowsMediaPlayerPluginDirectory): + (WebCore::addMacromediaPluginDirectories): + +2010-10-25 David Hyatt <hyatt@apple.com> + + Reviewed by Sam Weinig. + + https://bugs.webkit.org/show_bug.cgi?id=48246 + + Make selectionRect() on InlineTextBox give the right value for a vertical line. Selection is still too broken + to test anything though. + + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::selectionRect): + +2010-10-25 Benjamin Poulain <benjamin.poulain@nokia.com> + + Reviewed by Antonio Gomes. + + Typo in the TextureMapperGL + https://bugs.webkit.org/show_bug.cgi?id=48241 + + Fix the typo. + + * platform/graphics/opengl/TextureMapperGL.cpp: + (WebCore::TextureMapperGL::TextureMapperGL): + +2010-10-25 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: slowly make old resources panel optional (continued). + https://bugs.webkit.org/show_bug.cgi?id=48207 + + * inspector/front-end/Resource.js: + (WebInspector.Resource.prototype.set url): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel.prototype.get toolbarItemLabel): + (WebInspector.StoragePanel.prototype.showResource): + (WebInspector.StoragePanel.prototype.searchMatchFound): + (WebInspector.StoragePanel.prototype._findTreeElementForResource): + (WebInspector.StoragePanel.prototype._findTreeElementForResource.getParent): + (WebInspector.BaseStorageTreeElement.prototype.onattach): + * inspector/front-end/inspector.css: + (.storage.panel .sidebar): + (.storage.panel .sidebar li): + (.storage.panel .sidebar li.parent): + (.storage.panel .sidebar li.selected): + (.storage.panel .sidebar li .selection): + (.storage.panel .sidebar :focus li .selection): + (body.inactive .storage.panel .sidebar li .selection): + (.storage.panel .sidebar .icon): + +2010-10-25 No'am Rosenthal <noam.rosenthal@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Texmap] [Qt] Texture mapper initial implementation + This patch adds the OpenGL implementation of TextureMapper. See the other entries from bug 47070 for details. + https://bugs.webkit.org/show_bug.cgi?id=47070 + + No new tests. Part of a new implementation. + + * platform/graphics/opengl/TextureMapperGL.cpp: Added. + * platform/graphics/opengl/TextureMapperGL.h: Added. + +2010-10-25 Peter Rybin <peter.rybin@gmail.com> + + Reviewed by Adam Barth. + + HTML parser should provide script column position within HTML document to JavaScript engine + https://bugs.webkit.org/show_bug.cgi?id=45271 + + Replaces line number with TextPosition struct so that script engine + gets script starting line/column. + + * ForwardingHeaders/wtf/text/TextPosition.h: Added. + * bindings/js/ScriptSourceCode.h: + (WebCore::ScriptSourceCode::ScriptSourceCode): + * bindings/v8/ScheduledAction.cpp: + (WebCore::ScheduledAction::ScheduledAction): + * bindings/v8/ScriptController.cpp: + (WebCore::ScriptController::eventHandlerPosition): + * bindings/v8/ScriptController.h: + * bindings/v8/ScriptEventListener.cpp: + (WebCore::createAttributeEventListener): + * bindings/v8/ScriptSourceCode.h: + (WebCore::ScriptSourceCode::ScriptSourceCode): + (WebCore::ScriptSourceCode::startLine): + (WebCore::ScriptSourceCode::startPosition): + * bindings/v8/V8LazyEventListener.cpp: + (WebCore::V8LazyEventListener::V8LazyEventListener): + (WebCore::V8LazyEventListener::prepareListenerObject): + * bindings/v8/V8LazyEventListener.h: + (WebCore::V8LazyEventListener::create): + * bindings/v8/V8Proxy.cpp: + (WebCore::V8Proxy::compileScript): + (WebCore::V8Proxy::evaluate): + (WebCore::V8Proxy::runScript): + * bindings/v8/V8Proxy.h: + * bindings/v8/WorkerContextExecutionProxy.cpp: + (WebCore::WorkerContextExecutionProxy::evaluate): + (WebCore::WorkerContextExecutionProxy::runScript): + * bindings/v8/WorkerContextExecutionProxy.h: + * bindings/v8/WorkerScriptController.cpp: + (WebCore::WorkerScriptController::evaluate): + * dom/PendingScript.cpp: + (WebCore::PendingScript::releaseElementAndClear): + * dom/PendingScript.h: + (WebCore::PendingScript::PendingScript): + (WebCore::PendingScript::operator=): + (WebCore::PendingScript::startingPosition): + * dom/ScriptableDocumentParser.h: + * dom/XMLDocumentParser.h: + * dom/XMLDocumentParserLibxml2.cpp: + (WebCore::XMLDocumentParser::XMLDocumentParser): + (WebCore::XMLDocumentParser::startElementNs): + (WebCore::XMLDocumentParser::endElementNs): + (WebCore::XMLDocumentParser::lineNumber): + (WebCore::XMLDocumentParser::columnNumber): + (WebCore::XMLDocumentParser::textPosition): + (WebCore::XMLDocumentParser::textPositionOneBased): + * dom/XMLDocumentParserQt.cpp: + (WebCore::XMLDocumentParser::XMLDocumentParser): + (WebCore::XMLDocumentParser::textPosition): + (WebCore::XMLDocumentParser::parseStartElement): + (WebCore::XMLDocumentParser::parseEndElement): + * html/parser/HTMLDocumentParser.cpp: + (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): + (WebCore::HTMLDocumentParser::textPosition): + * html/parser/HTMLDocumentParser.h: + * html/parser/HTMLScriptRunner.cpp: + (WebCore::HTMLScriptRunner::sourceFromPendingScript): + (WebCore::HTMLScriptRunner::execute): + (WebCore::HTMLScriptRunner::runScript): + * html/parser/HTMLScriptRunner.h: + * html/parser/HTMLTreeBuilder.cpp: + (WebCore::uninitializedPositionValue1): + (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): + (WebCore::HTMLTreeBuilder::takeScriptToProcess): + (WebCore::HTMLTreeBuilder::processEndTag): + (WebCore::HTMLTreeBuilder::processScriptStartTag): + * html/parser/HTMLTreeBuilder.h: + +2010-10-24 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: slowly make old resources panel optional. + https://bugs.webkit.org/show_bug.cgi?id=48207 + + * inspector/front-end/AuditsPanel.js: + (WebInspector.AuditsPanel.prototype._reloadResources): + (WebInspector.AuditsPanel.prototype.show): + * inspector/front-end/ExtensionServer.js: + (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): + * inspector/front-end/ResourcesPanel.js: + * inspector/front-end/ScriptsPanel.js: + (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): + (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): + * inspector/front-end/inspector.js: + (WebInspector._createPanels): + (WebInspector.doLoadedDone.populateInspectorState): + (WebInspector.doLoadedDone): + (WebInspector.openResource): + (WebInspector.updateResource): + (WebInspector.domContentEventFired): + (WebInspector.loadEventFired): + (WebInspector.removeResource): + (WebInspector.displayNameForURL): + (WebInspector._choosePanelToShowSourceLine): + (WebInspector.doPerformSearch): + +2010-10-24 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: add support for errors, warnings and search to the storage panel. + https://bugs.webkit.org/show_bug.cgi?id=48206 + + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleView.prototype.addMessage): + (WebInspector.ConsoleView.prototype.clearMessages): + * inspector/front-end/Resource.js: + (WebInspector.Resource.prototype.set errors): + (WebInspector.Resource.prototype.set warnings): + (WebInspector.Resource.prototype.get searchMatches): + (WebInspector.Resource.prototype.set searchMatches): + (WebInspector.Resource.prototype.clearErrorsAndWarnings): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager): + (WebInspector.ResourceManager.prototype.identifierForInitialRequest): + (WebInspector.ResourceManager.prototype._createResource): + (WebInspector.ResourceManager.prototype._appendRedirect): + (WebInspector.ResourceManager.prototype.didReceiveResponse): + (WebInspector.ResourceManager.prototype.didFinishLoading): + (WebInspector.ResourceManager.prototype.didFailLoading): + (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): + (WebInspector.ResourceManager.prototype.didCommitLoadForFrame): + (WebInspector.ResourceManager.prototype.frameDetachedFromParent): + (WebInspector.ResourceManager.prototype._addFramesRecursively): + (WebInspector.ResourceManager.prototype.resourceForURL): + (WebInspector.ResourceManager.prototype.addConsoleMessage): + (WebInspector.ResourceManager.prototype.clearConsoleMessages): + (WebInspector.ResourceTreeModel): + (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): + (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): + (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): + (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): + (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): + (WebInspector.ResourceTreeModel.prototype._clearResources): + (WebInspector.ResourceTreeModel.prototype._bindResourceURL): + (WebInspector.ResourceTreeModel.prototype._unbindResourceURL): + (WebInspector.ResourceTreeModel.prototype.resourceForURL): + (WebInspector.ResourceTreeModel.prototype.forAllResources): + (WebInspector.ResourceTreeModel.prototype._callForFrameResources): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel): + (WebInspector.StoragePanel.prototype.get toolbarItemLabel): + (WebInspector.StoragePanel.prototype.reset): + (WebInspector.StoragePanel.prototype.removeFrame): + (WebInspector.StoragePanel.prototype.canShowSourceLine): + (WebInspector.StoragePanel.prototype.showSourceLine): + (WebInspector.StoragePanel.prototype.showResource): + (WebInspector.StoragePanel.prototype._showResourceView): + (WebInspector.StoragePanel.prototype.updateMainViewWidth): + (WebInspector.StoragePanel.prototype.get searchableViews.callback): + (WebInspector.StoragePanel.prototype.get searchableViews): + (WebInspector.StoragePanel.prototype._forAllResourceTreeElements): + (WebInspector.StoragePanel.prototype.searchMatchFound): + (WebInspector.StoragePanel.prototype.searchCanceled.callback): + (WebInspector.StoragePanel.prototype.searchCanceled): + (WebInspector.StoragePanel.prototype.performSearch): + (WebInspector.StoragePanel.prototype.showView): + (WebInspector.BaseStorageTreeElement.prototype.onattach): + (WebInspector.BaseStorageTreeElement.prototype.set titleText): + (WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle): + (WebInspector.FrameResourceTreeElement): + (WebInspector.FrameResourceTreeElement.prototype.onselect): + (WebInspector.FrameResourceTreeElement.prototype.ondblclick): + (WebInspector.FrameResourceTreeElement.prototype.onattach): + (WebInspector.FrameResourceTreeElement.prototype._ondragstart): + (WebInspector.FrameResourceTreeElement.prototype._setBubbleText): + (WebInspector.FrameResourceTreeElement.prototype._resetBubble): + (WebInspector.FrameResourceTreeElement.prototype._searchMatchesUpdated): + (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated): + * inspector/front-end/inspector.css: + (.storage.panel .sidebar): + (.storage.panel .outline-disclosure li): + (.storage.panel .outline-disclosure li.parent): + (.storage.panel .outline-disclosure li .selection): + (.storage.panel .outline-disclosure .icon): + (.storage.panel .base-storage-tree-element-title): + (.storage.panel .status): + (.storage.panel li .status .bubble): + (li .status): + (li .status:empty): + (li .status .bubble): + (li .status .bubble:empty): + (li.selected .status .bubble): + (:focus li.selected .status .bubble): + (body.inactive li.selected .status .bubble): + (li.selected .bubble.search-matches): + (:focus li.selected .bubble.search-matches): + (body.inactive li.selected .bubble.search-matches): + +2010-10-24 Csaba Osztrogonác <ossy@webkit.org> + + Reviewed by David Kilzer. + + Fix Qt minimal build break revealed by r70413. + https://bugs.webkit.org/show_bug.cgi?id=48185 + + * rendering/RenderMeter.h: Missing include added, needless include removed. + +2010-10-20 Kinuko Yasuda <kinuko@chromium.org> + + Reviewed by Jian Li. + + Renumber FileError/FileException error codes per latest File API spec changes + https://bugs.webkit.org/show_bug.cgi?id=47936 + + * bindings/js/JSDOMBinding.cpp: + (WebCore::setDOMException): Added FileExceptionType case. + * bindings/v8/V8Proxy.cpp: + (WebCore::V8Proxy::setDOMException): Added FileExceptionType case. + * dom/ExceptionCode.cpp: + (WebCore::getExceptionCodeDescription): Added code for FileException. + * dom/ExceptionCode.h: + * fileapi/AsyncFileWriterClient.h: + * fileapi/DirectoryEntry.cpp: + (WebCore::DirectoryEntry::getFile): + (WebCore::DirectoryEntry::getDirectory): + (WebCore::DirectoryEntry::removeRecursively): + * fileapi/DirectoryEntrySync.cpp: + (WebCore::DirectoryEntrySync::getFile): + (WebCore::DirectoryEntrySync::getDirectory): + (WebCore::DirectoryEntrySync::removeRecursively): + * fileapi/DirectoryReaderSync.cpp: + (WebCore::DirectoryReaderSync::readEntries): + * fileapi/Entry.cpp: + (WebCore::Entry::getMetadata): + (WebCore::Entry::moveTo): + (WebCore::Entry::copyTo): + (WebCore::Entry::remove): + (WebCore::Entry::getParent): + * fileapi/EntrySync.cpp: + (WebCore::EntrySync::getMetadata): + (WebCore::EntrySync::moveTo): + (WebCore::EntrySync::copyTo): + (WebCore::EntrySync::remove): + * fileapi/FileError.h: Added error code enum. + (WebCore::FileError::create): + (WebCore::FileError::code): + (WebCore::FileError::FileError): + * fileapi/FileError.idl: Rebased error code numbers. + * fileapi/FileException.h: Added exception code enum. + (WebCore::FileException::ErrorCodeToExceptionCode): Added. + * fileapi/FileException.idl: Rebased exception code numbers. + * fileapi/FileReader.cpp: + (WebCore::FileReader::abort): + (WebCore::FileReader::failed): + (WebCore::FileReader::httpStatusCodeToErrorCode): Changed from + httpStatuCodeToExceptionCode. + * fileapi/FileReader.h: + * fileapi/FileReaderSync.cpp: + (WebCore::FileReaderSyncLoader::start): + * fileapi/FileSystemCallbacks.cpp: + (WebCore::FileSystemCallbacksBase::didFail): + * fileapi/FileWriter.cpp: + (WebCore::FileWriter::write): + (WebCore::FileWriter::seek): + (WebCore::FileWriter::truncate): + (WebCore::FileWriter::abort): + (WebCore::FileWriter::didFail): + (WebCore::FileWriter::setError): + * fileapi/FileWriter.h: + * fileapi/SyncCallbackHelper.h: + (WebCore::SyncCallbackHelper::SyncCallbackHelper): + (WebCore::SyncCallbackHelper::getResult): + (WebCore::SyncCallbackHelper::setError): + * page/DOMWindow.cpp: + (WebCore::DOMWindow::requestFileSystem): + * workers/WorkerContext.cpp: + (WebCore::WorkerContext::requestFileSystem): + (WebCore::WorkerContext::requestFileSystemSync): + +2010-10-24 Dan Bernstein <mitz@apple.com> + + Reviewed by Anders Carlsson. + + Expose HitTestResult::absoluteMediaURL() via WebKit API + https://bugs.webkit.org/show_bug.cgi?id=48219 + + * WebCore.exp.in: Export HitTestResult::absoluteMediaURL(). + +2010-10-24 Sam Weinig <sam@webkit.org> + + Reviewed by Dan Bernstein. + + Need a way to determine the screen rect for a form control in WebKit2 + <rdar://problem/8530670> + https://bugs.webkit.org/show_bug.cgi?id=48216 + + * WebCore.exp.in: Add export. + * dom/Element.cpp: + (WebCore::Element::boundsInWindowSpace): + * dom/Element.h: + Add function to return the bounding box in window (in ScrollView terminology) space, + this is the same space as the root viewport. + +2010-10-24 Andreas Kling <kling@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] ImageBuffer::platformTransformColorSpace is unnecessarily slow + https://bugs.webkit.org/show_bug.cgi?id=48211 + + Grab the QImage::bits() and do direct access instead of going through + QImage::pixel() and QImage::setPixel(). + + This is a performance optimization, so no new tests. + + * platform/graphics/qt/ImageBufferQt.cpp: + (WebCore::ImageBuffer::platformTransformColorSpace): + +2010-10-24 Dirk Schulze <krit@webkit.org> + + Reviewed by Nikolas Zimmermann. + + Filter example Chiseled from SVG Wow! is slow + https://bugs.webkit.org/show_bug.cgi?id=48174 + + Use a pointer to the ByteArray instead of the ref counted CanvasPixelArray or ImageData directly + to access the data for pixel manipulation on SVG Filters or SVG Masker. This is a + performance increase since the recurring use of the -> operator can be avoided. + FEConvolveMatrix and FELighting still need to change in a followup patch. + + No functionality was changed. So, no new tests. + + * platform/graphics/filters/FEBlend.cpp: + (WebCore::FEBlend::apply): + * platform/graphics/filters/FEColorMatrix.cpp: + (WebCore::luminance): + (WebCore::effectType): + (WebCore::FEColorMatrix::apply): + * platform/graphics/filters/FEComponentTransfer.cpp: + (WebCore::FEComponentTransfer::apply): + * platform/graphics/filters/FEComposite.cpp: + (WebCore::arithmetic): + (WebCore::FEComposite::apply): + * platform/graphics/filters/FEDisplacementMap.cpp: + (WebCore::FEDisplacementMap::apply): + * platform/graphics/filters/FEGaussianBlur.cpp: + (WebCore::boxBlur): + (WebCore::FEGaussianBlur::apply): + * platform/graphics/filters/FEMorphology.cpp: + (WebCore::FEMorphology::apply): + * platform/graphics/filters/FETurbulence.cpp: + (WebCore::FETurbulence::apply): + * rendering/RenderSVGResourceMasker.cpp: + (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): + +2010-10-24 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Timothy Hatcher. + + Web Inspector: polish network panel UI. + https://bugs.webkit.org/show_bug.cgi?id=48205 + + * inspector/front-end/Images/frame.png: + * inspector/front-end/Images/networkIcon.png: + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel.prototype._createTable): + (WebInspector.NetworkPanel.prototype._setLargerResources): + (WebInspector.NetworkPanel.prototype._toggleGridMode): + * inspector/front-end/networkPanel.css: + (.network.panel .data-grid td): + (.network.panel .data-grid.small td): + (#network-views .resource-view.headers-visible .resource-view-content): + (#network-views.small .resource-view.headers-visible .resource-view-content): + (#network-views .resource-view-headers): + (#network-views.small .resource-view-headers): + (#network-views .resource-view .tabbed-pane-header): + (#network-views.small .resource-view .tabbed-pane-header): + +2010-10-24 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Dimitri Glazkov. + + Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly + https://bugs.webkit.org/show_bug.cgi?id=48179 + + Fix WebGL tests. Accept 'boolean' as valid numeric type in StrictTypeChecking mode. + + * bindings/scripts/CodeGeneratorJS.pm: + * bindings/scripts/CodeGeneratorV8.pm: + +2010-10-24 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Dirk Schulze. + + Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly + https://bugs.webkit.org/show_bug.cgi?id=48179 + + Speculative fix for the WebGL tests, I was not aware they're not run on Leopard, so I missed the breakage. + + * bindings/scripts/CodeGeneratorJS.pm: Restore the order of type checking in the 'StrictTypeChecking' code. + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + +2010-10-23 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Dirk Schulze. + + Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly + https://bugs.webkit.org/show_bug.cgi?id=48179 + + Rewrite SVGAngle to use the new SVGPropertyTearOff concept, and consume much less memory. + Down from two floats, one string and an ushort to one float and one ushort. Synchronize value/valueInSpecifiedUnits/valueAsString on demand. + + Adding an extensive SVGAngle test, that required to implement 'StrictTypeChecking' for attribute setters (was only implemented in V8/JSC for function cals so far). + + Test: svg/dom/SVGAngle.html + + * GNUmakefile.am: Add SVGAnimatedAngle.h to build. + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * bindings/scripts/CodeGenerator.pm: Split IsPrimitiveType in IsPrimitiveType and IsNumericType. + * bindings/scripts/CodeGeneratorJS.pm: Implement 'StrictTypeChecking' for setters and recognize SVGAngle as new SVGPropertyTearOff type. + * bindings/scripts/CodeGeneratorObjC.pm: Ditto. + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAngle handling. + * svg/DeprecatedSVGAnimatedTemplate.h: Remove SVGAnimatedAngle handling. + * svg/SVGAngle.cpp: Rewrite, to consume less memory and to operate more efficient. + * svg/SVGAngle.h: Ditto. + * svg/SVGAngle.idl: Add 'StrictTypeChecking' to the value/valueInSpecifiedUnits methods. + * svg/SVGAnimatedAngle.h: Added. + * svg/SVGAnimatedAngle.idl: Mark as [SVGAnimatedProperty]. + * svg/SVGMarkerElement.cpp: + (WebCore::SVGMarkerElement::parseMappedAttribute): SVGAngle::setValueAsString() now takes an ExceptionCode parameter. + * svg/SVGMarkerElement.h: s/ANIMATED_PROPERTY/ANIMATED_PROPERTY_NEW/ for the SVGAngle type. + * svg/SVGNumber.idl: Remove exception setter exceptions, which aren't needed. As we're now generating exception handlers in the bindings, it would lead to compile errors. + * svg/SVGPoint.idl: Ditto. + * svg/SVGRect.idl: Ditto. + * svg/SVGSVGElement.idl: Remove obsolete [SVGLiveProperty] flag. + +2010-10-23 Daniel Bates <dbates@rim.com> + + Reviewed by Adam Barth. + + Remove unused method HTMLFrameElementBase::setNameAndOpenURLCallback() + https://bugs.webkit.org/show_bug.cgi?id=48197 + + With the landing of the patch for bug #45365 in + changeset 67182 <http://trac.webkit.org/changeset/67182>, + HTMLFrameElementBase::setNameAndOpenURLCallback() is not needed. + Therefore, we remove it. + + Before changeset 67182, HTMLFrameElementBase::attach() set up a post-attach + callback to HTMLFrameElementBase::setNameAndOpenURLCallback(). Changeset 67182 + removed this callback. + + No functionality was changed. So, no new tests. + + * html/HTMLFrameElementBase.cpp: Remove HTMLFrameElementBase::setNameAndOpenURLCallback(). + * html/HTMLFrameElementBase.h: Ditto. + +2010-10-23 Xan Lopez <xlopez@igalia.com> + + Reviewed by Sam Weinig. + + Unify globalData APIs + https://bugs.webkit.org/show_bug.cgi?id=47969 + + Adapt code to JSGlobalObject::globalData returning a reference + instead of a pointer. + + * bindings/js/JSCallbackData.cpp: + (WebCore::JSCallbackData::invokeCallback): + * bindings/js/JSCustomXPathNSResolver.cpp: + (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI): + * bindings/js/JSEventListener.cpp: + (WebCore::JSEventListener::handleEvent): + * bindings/js/JSWorkerContextCustom.cpp: + (WebCore::JSWorkerContext::markChildren): + * bindings/js/JSWorkerContextErrorHandler.cpp: + (WebCore::JSWorkerContextErrorHandler::handleEvent): + * bindings/js/ScheduledAction.cpp: + (WebCore::ScheduledAction::executeFunctionInContext): + * bindings/js/WorkerScriptController.cpp: + (WebCore::WorkerScriptController::evaluate): + * bridge/NP_jsobject.cpp: + (_NPN_InvokeDefault): + (_NPN_Invoke): + (_NPN_Evaluate): + (_NPN_Construct): + +2010-10-23 Alexey Proskuryakov <ap@apple.com> + + Windows debug build fix. + + * platform/network/cf/CookieStorageCFNet.cpp: Include MainThread.h for isMainThread(). + +2010-10-23 Alexey Proskuryakov <ap@apple.com> + + Windows build fix. + + * platform/network/cf/CookieStorageCFNet.cpp: + (WebCore::setCookieStoragePrivateBrowsingEnabled): It's adoptCF, not adoptPtr. + +2010-10-23 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Anders Carlsson. + + https://bugs.webkit.org/show_bug.cgi?id=48083 + <rdar://problem/8489082> Need WebKit2 API for private browsing (48083) + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + Added CookieStorage.h to build files that contain headers. + + * WebCore.xcodeproj/project.pbxproj: Added CookieStorage.h and CookieStorageMac.mm. + + * WebCore.exp.in: Export _wkSetCookieStoragePrivateBrowsingEnabled (WebKit initializes WKSI + on WebCore's behalf). + + * platform/mac/WebCoreSystemInterface.h: + * platform/mac/WebCoreSystemInterface.mm: + More work for passing the function pointer down to WebCore. + + * page/Settings.cpp: (WebCore::Settings::setPrivateBrowsingEnabled): Tell cookie manager to + when to use private browsing mode. Note that although this is a per-page setting, it + actually has global effect. + + * page/Settings.h: Extended a comment about what private browsing does. + + * platform/android/TemporaryLinkStubs.cpp: (setCookieStoragePrivateBrowsingEnabled): + * platform/chromium/TemporaryLinkStubs.cpp: (WebCore::setCookieStoragePrivateBrowsingEnabled): + * platform/efl/TemporaryLinkStubs.cpp: (WebCore::setCookieStoragePrivateBrowsingEnabled): + * platform/gtk/TemporaryLinkStubs.cpp: (WebCore::setCookieStoragePrivateBrowsingEnabled): + * platform/haiku/TemporaryLinkStubs.cpp: (WebCore::setCookieStoragePrivateBrowsingEnabled): + * platform/qt/TemporaryLinkStubsQt.cpp: (WebCore::setCookieStoragePrivateBrowsingEnabled): + Added an empty implementation for ports that don't implement private browsing, or implement + it in ways I cannot discover. + + * platform/network/CookieStorage.h: Added. I'm not entirely sure how this is different from + CookieJar.h, just following a precedent already set by Windows port with CookieStorageWin.h. + + * platform/network/mac/CookieStorageMac.mm: Added. + (WebCore::setCookieStoragePrivateBrowsingEnabled): Call a WKSI function to enable private + browsing mode for cookies. + + * platform/network/cf/CookieStorageCFNet.cpp: + (WebCore::currentCookieStorage): Added ASSERT(isMainThread()). + (WebCore::setCurrentCookieStorage): Ditto. + (WebCore::setCookieStoragePrivateBrowsingEnabled): Set cookie storage to a private one + when in private browsing mode. ResourceHandle applies the storage to each individual request. + + * platform/network/cf/CookieStorageCFNet.h: Added a comment explaining that these functions + are only for WebKit1. + +2010-10-23 David Kilzer <ddkilzer@apple.com> + + <http://webkit.org/b/48181> Add missing include of MacErrors.h + + Reviewed by Alexey Proskuryakov. + + * platform/network/mac/FormDataStreamMac.mm: Added #import of + <MacErrors.h> for iOS since the formOpen() method uses "fnfErr", + which was added in r55670. The same header is included through + <CoreServices/CoreServices.h> on Mac OS X. + +2010-10-23 Patrick Gansterer <paroga@webkit.org> + + Reviewed by David Kilzer. + + [WINCE] Port COMPtr.h to WinCE + https://bugs.webkit.org/show_bug.cgi?id=48190 + + Don't include guiddef.h on WinCE. It's not required and only creates build problems. + + * platform/win/COMPtr.h: + +2010-10-23 Patrick Gansterer <paroga@webkit.org> + + Reviewed by David Kilzer. + + [WINCE] Rename SharedBitmap::createInstance to SharedBitmap::create + https://bugs.webkit.org/show_bug.cgi?id=48180 + + Also use better arguments for the create function. + + * platform/graphics/wince/GraphicsContextWinCE.cpp: + (WebCore::GraphicsContextPlatformPrivate::getTransparentLayerBitmap): + (WebCore::TransparentLayerDC::TransparentLayerDC): + (WebCore::GraphicsContext::drawFrameControl): + * platform/graphics/wince/ImageBufferWinCE.cpp: + (WebCore::ImageBufferData::ImageBufferData): + * platform/graphics/wince/ImageWinCE.cpp: + (WebCore::RGBA32Buffer::asNewNativeImage): + +2010-10-23 Dimitri Glazkov <dglazkov@chromium.org> + + Unreviewed, rolling out r70369. + http://trac.webkit.org/changeset/70369 + https://bugs.webkit.org/show_bug.cgi?id=47974 + + Caused weird artifacts in expected results. + + * WebCore.gyp/WebCore.gyp: + * WebCore.gypi: + * loader/CachedImage.cpp: + (WebCore::CachedImage::createImage): + * platform/graphics/ImageSource.h: + * platform/image-decoders/ImageDecoder.cpp: + (WebCore::RGBA32Buffer::operator=): + (WebCore::RGBA32Buffer::clear): + (WebCore::RGBA32Buffer::zeroFill): + (WebCore::RGBA32Buffer::copyBitmapData): + (WebCore::RGBA32Buffer::setSize): + * platform/image-decoders/ImageDecoder.h: + (WebCore::RGBA32Buffer::getAddr): + * platform/image-decoders/cairo/ImageDecoderCairo.cpp: + (WebCore::RGBA32Buffer::asNewNativeImage): + * platform/image-decoders/cg/ImageDecoderCG.cpp: Removed. + * platform/image-decoders/haiku/ImageDecoderHaiku.cpp: + (WebCore::RGBA32Buffer::asNewNativeImage): + * platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: + (WebCore::RGBA32Buffer::asNewNativeImage): + * platform/image-decoders/wx/ImageDecoderWx.cpp: + (WebCore::RGBA32Buffer::asNewNativeImage): + +2010-10-23 Adam Barth <abarth@webkit.org> + + Reviewed by Andreas Kling. + + WebP decoding hits ASSERT + https://bugs.webkit.org/show_bug.cgi?id=48168 + + Calling reserveCapacity only allocates the memory. It doesn't actually + set the length. When you try to access the zeroth element, you hit an + ASSERT. + + Covered by fast/images/webp-image-decoding.html in debug. + + * platform/image-decoders/webp/WEBPImageDecoder.cpp: + (WebCore::WEBPImageDecoder::decode): + +2010-10-23 Martin Robinson <mrobinson@igalia.com> + + Reviewed by Xan Lopez. + + [GTK] Menu list buttons do react properly to CSS styling + https://bugs.webkit.org/show_bug.cgi?id=48099 + + Correct the way that menu list buttons get their necessary padding from + GTK+. Instead of resetting the padding to these values, return them via + the popupInternalPadding* methods. Add implementations for *MenuListButton* + methods. + + * platform/gtk/RenderThemeGtk.cpp: + (WebCore::getComboBoxPadding): Added. + (WebCore::RenderThemeGtk::popupInternalPaddingLeft): Added. + (WebCore::RenderThemeGtk::popupInternalPaddingRight): Added. + (WebCore::RenderThemeGtk::popupInternalPaddingTop): Added. + (WebCore::RenderThemeGtk::popupInternalPaddingBottom): Added. + (WebCore::RenderThemeGtk::adjustMenuListStyle): Do not reset CSS + properties, instead rely on the poupInternalPadding* methods. + (WebCore::RenderThemeGtk::adjustMenuListButtonStyle): Added. + (WebCore::RenderThemeGtk::paintMenuListButton): Added. + * platform/gtk/RenderThemeGtk.h: Added new method declarations. + +2010-10-23 Patrick Gansterer <paroga@webkit.org> + + Reviewed by David Kilzer. + + Add Gradient::hasAlpha + https://bugs.webkit.org/show_bug.cgi?id=48183 + + WinCE can do some performance improvements if the gradient is opaque. + + * platform/graphics/Gradient.cpp: + (WebCore::Gradient::hasAlpha): + * platform/graphics/Gradient.h: + +2010-10-23 Gyuyoung Kim <gyuyoung.kim@samsung.com> + + Reviewed by David Kilzer. + + [EFL] Implement platformDefaultLanguage() + https://bugs.webkit.org/show_bug.cgi?id=48113 + + Implement the platformDefaultLanguage() function for EFL port. + + * platform/efl/LanguageEfl.cpp: + (WebCore::platformDefaultLanguage): + +2010-10-23 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r70367. + http://trac.webkit.org/changeset/70367 + https://bugs.webkit.org/show_bug.cgi?id=48176 + + It made 8-10 tests crash on Qt bot (Requested by Ossy on + #webkit). + + * loader/MainResourceLoader.cpp: + (WebCore::MainResourceLoader::MainResourceLoader): + (WebCore::MainResourceLoader::continueAfterContentPolicy): + (WebCore::MainResourceLoader::didReceiveResponse): + (WebCore::MainResourceLoader::setDefersLoading): + * loader/MainResourceLoader.h: + +2010-10-22 Andy Estes <aestes@apple.com> + + Reviewed by Adam Roben and Sam Weinig. + + WebKit shouldn't load a plug-in based on file extension if a MIME type + is specified. + https://bugs.webkit.org/show_bug.cgi?id=48046 + + The fix landed in r70332 only covered the Mac port. Implement this fix + for other ports as well. + + * plugins/PluginDatabase.cpp: + (WebCore::PluginDatabase::findPlugin): + +2010-10-21 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher. + (Eric reviewed the CoreGraphics interactions, Peter reviewed the image + decoder interaction, and Darin Fisher SGTMed the policy decision.) + + [chromium] Chromium Mac should use WebKit's image decoders + https://bugs.webkit.org/show_bug.cgi?id=47974 + + This patch teaches WebKit's image decoders how to talk to CoreGraphics. + This patch doesn't handle color profiles, but that will come in a + subsequent patch. + + * WebCore.gyp/WebCore.gyp: + * WebCore.gypi: + * loader/CachedImage.cpp: + (WebCore::CachedImage::createImage): + * platform/graphics/ImageSource.h: + * platform/image-decoders/ImageDecoder.cpp: + (WebCore::RGBA32Buffer::clear): + (WebCore::RGBA32Buffer::zeroFill): + (WebCore::RGBA32Buffer::copyBitmapData): + (WebCore::RGBA32Buffer::setSize): + * platform/image-decoders/ImageDecoder.h: + (WebCore::RGBA32Buffer::getAddr): + * platform/image-decoders/cg: Added. + * platform/image-decoders/cg/ImageDecoderCG.cpp: Added. + (WebCore::RGBA32Buffer::copyBitmapData): + (WebCore::RGBA32Buffer::setSize): + (WebCore::RGBA32Buffer::asNewNativeImage): + +2010-10-20 Anders Carlsson <andersca@apple.com> + + Reviewed by Adam Barth and Darin Adler. + + Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work + https://bugs.webkit.org/show_bug.cgi?id=48014 + <rdar://problem/8202716> + + * loader/MainResourceLoader.cpp: + (WebCore::MainResourceLoader::continueAfterContentPolicy): + Resume loading. + + (WebCore::MainResourceLoader::didReceiveResponse): + Defer loading until we hear back from the policy client. + +2010-10-22 James Robinson <jamesr@chromium.org> + + Reviewed by Dimitri Glazkov. + + REGRESSION(66391): http://ligth-arts.all-up.com/ crashes in EventHandler::selectCursor + https://bugs.webkit.org/show_bug.cgi?id=47942 + + Add checks for a NULL StyleImage in a CursorList. + + * css/CSSComputedStyleDeclaration.cpp: + (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::loadPendingImages): + * page/EventHandler.cpp: + (WebCore::EventHandler::selectCursor): + * rendering/style/CursorList.h: + (WebCore::CursorList::at): + * manual-tests/cursor-empty-url.html: Added. + * manual-tests/resources/cursor-empty-url.css: Added. + +2010-10-22 David Hyatt <hyatt@apple.com> + + Reviewed by Adele Peterson. + + https://bugs.webkit.org/show_bug.cgi?id=48156 + + Make vertical lines hit test properly and show a vertical i-beam cursor. Numerous bugs with overflow were discovered while getting this to work, + so these are in the patch as well. The broken layout tests are fixed by the overflow bug fixes as well (which just restore the old behavior). + + * page/EventHandler.cpp: + (WebCore::EventHandler::selectCursor): + * rendering/InlineBox.h: + (WebCore::InlineBox::width): + (WebCore::InlineBox::height): + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::placeBoxesInInlineDirection): + (WebCore::InlineFlowBox::computeBlockDirectionOverflow): + (WebCore::InlineFlowBox::nodeAtPoint): + * rendering/InlineFlowBox.h: + (WebCore::InlineFlowBox::logicalTopVisibleOverflow): + (WebCore::InlineFlowBox::logicalBottomVisibleOverflow): + (WebCore::InlineFlowBox::visibleOverflowRect): + (WebCore::InlineFlowBox::layoutOverflowRect): + (WebCore::InlineFlowBox::logicalTopLayoutOverflow): + (WebCore::InlineFlowBox::logicalBottomLayoutOverflow): + (WebCore::InlineFlowBox::visualOverflowRect): + (WebCore::InlineFlowBox::logicalTopVisualOverflow): + (WebCore::InlineFlowBox::logicalBottomVisualOverflow): + (WebCore::InlineFlowBox::setBlockDirectionOverflowPositions): + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::nodeAtPoint): + * rendering/RenderBox.cpp: + (WebCore::RenderBox::blockDirectionOverflow): + * rendering/RenderBox.h: + * rendering/RenderLineBoxList.cpp: + (WebCore::RenderLineBoxList::hitTest): + +2010-10-22 Dan Bernstein <mitz@apple.com> + + Reviewed by Anders Carlsson. + + <rdar://problem/8251616> Layout not updating in a subtree when a scrollbar is hidden in a flexbox descendant + https://bugs.webkit.org/show_bug.cgi?id=48154 + + Test: scrollbars/hidden-scrollbar-prevents-layout.html + + updateScrollInfoAfterLayout() calling setHasHorizontalScrollbar() caused updateScrollbarParts() + to call setChildNeedsLayout() on the overflow, because the RenderScrollbar was created with + the default thickness instead of the thickness specified in style. This led to the the overflow’s + parent to be re-marked for layout during its own parent’s finishDelayUpdateScrollInfo(), and + the result was that at the end of RenderView::layout(), there was a dirty renderer. + + * rendering/RenderScrollbar.cpp: + (WebCore::RenderScrollbar::RenderScrollbar): Set the frame size in the 'display: none' and + 'visibility: hidden' cases as well. + +2010-10-22 Patrick Gansterer <paroga@webkit.org> + + Unreviewed. + + [WINCE] Build fix after r70143. + + * platform/graphics/wince/ImageBufferWinCE.cpp: + (WebCore::ImageBuffer::ImageBuffer): + +2010-10-22 Adam Roben <aroben@apple.com> + + Windows build fix + + r70319 added Windows-native versions of the various platform/network + headers to platform/network/win. WebCoreGenerated was copying these + headers over the CFNetwork-specific versions in $WebKitOutputDir, + leading to the wrong headers being used in WebKit. + + This patch changes WebCoreGenerated not to copy any headers from + platform/network/win into $WebKitOutputDir. Instead, only headers from + platform/network/cf or platform/network/curl (as specified) are copied. + There were some CFNetwork-specific files still hanging around in + platform/network/win; these have been moved to platform/network/cf. + + * WebCore.vcproj/WebCore.vcproj: Updated for file moves and let VS + * format the file as it saw fit. + + * WebCore.vcproj/WebCoreGenerated.vcproj: Added the various scripts + * this project uses to make editing them easier. + + * WebCore.vcproj/copyForwardingHeaders.cmd: Changed not to copy any + * headers from platform/network/win. + + * platform/network/cf/CookieJarCFNet.cpp: Renamed from WebCore/platform/network/win/CookieJarCFNetWin.cpp. + * platform/network/cf/CookieStorageCFNet.cpp: Renamed from WebCore/platform/network/win/CookieStorageWin.cpp. + * platform/network/cf/CookieStorageCFNet.h: Renamed from WebCore/platform/network/win/CookieStorageWin.h. + + * platform/network/cf/ResourceHandleCFNet.cpp: Updated for rename. + + * platform/network/cf/AuthenticationChallenge.h: + * platform/network/cf/ResourceError.h: + * platform/network/cf/ResourceRequest.h: + * platform/network/cf/ResourceResponse.h: + * platform/network/cf/SocketStreamError.h: + * platform/network/cf/SocketStreamHandle.h: + Touched to force a re-copy. + +2010-10-22 Abhishek Arya <inferno@chromium.org> + + Reviewed by Dave Hyatt. + + Add code in getMatchedCSSRules to block cross origin access to stylesheet data. Prevent access + in Javascript to non author stylesheets. + https://bugs.webkit.org/show_bug.cgi?id=46853 + + Tests: http/tests/security/cross-origin-getMatchedCSSRules.html + http/tests/security/cross-origin-getMatchedCSSRules2.html + + * css/CSSRule.h: + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::matchRulesForList): + (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker): + (WebCore::CSSStyleSelector::styleRulesForElement): + (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): + * css/CSSStyleSelector.h: + * page/DOMWindow.cpp: + (WebCore::DOMWindow::getMatchedCSSRules): + * page/DOMWindow.idl: + +2010-10-22 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + WebKit2 needs to pass the current event modifier flags when requesting a new window + https://bugs.webkit.org/show_bug.cgi?id=48140 + + Store the NavigationAction used for the newWindowPolicyDecision in the PolicyCallback + so that it can be used after the decision has been made in further callbacks. + + * WebCore.exp.in: Fix export name for new function signature. + * loader/EmptyClients.h: + (WebCore::EmptyChromeClient::createWindow): + (WebCore::EmptyFrameLoaderClient::dispatchCreatePage): + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): + (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): + (WebCore::createWindow): + * loader/FrameLoader.h: + * loader/FrameLoaderClient.h: + * loader/PolicyCallback.cpp: + (WebCore::PolicyCallback::set): + (WebCore::PolicyCallback::call): + (WebCore::PolicyCallback::cancel): + * loader/PolicyCallback.h: + * loader/PolicyChecker.cpp: + (WebCore::PolicyChecker::checkNewWindowPolicy): + * page/Chrome.cpp: + (WebCore::Chrome::createWindow): + * page/Chrome.h: + * page/ChromeClient.h: + * page/ContextMenuController.cpp: + (WebCore::openNewWindow): + +2010-10-22 David Hyatt <hyatt@apple.com> + + Reviewed by Sam Weinig. + + https://bugs.webkit.org/show_bug.cgi?id=48149 + + Update block direction line overflow computation to be writing-mode-aware. + + * rendering/InlineBox.h: + (WebCore::InlineBox::logicalBottom): + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::computeBlockDirectionOverflow): + * rendering/InlineFlowBox.h: + (WebCore::InlineFlowBox::setInlineDirectionOverflowPositions): + (WebCore::InlineFlowBox::setBlockDirectionOverflowPositions): + * rendering/RenderBlockLineLayout.cpp: + (WebCore::RenderBlock::layoutInlineChildren): + * rendering/RenderBox.cpp: + (WebCore::RenderBox::blockDirectionOverflow): + * rendering/RenderBox.h: + * rendering/RootInlineBox.cpp: + (WebCore::RootInlineBox::addHighlightOverflow): + * rendering/style/RenderStyle.h: + (WebCore::InheritedFlags::getTextShadowBlockDirectionExtent): + (WebCore::InheritedFlags::getBoxShadowBlockDirectionExtent): + (WebCore::InheritedFlags::getShadowBlockDirectionExtent): + +2010-10-22 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + ASSERT while viewing Google C++ style guide + https://bugs.webkit.org/show_bug.cgi?id=48148 + + This code used to stop the parser twice. Instead of reaching in an + trying to stop the parser manually, we now just let close() do the work + for us. + + Test: fast/xsl/transform-to-html.xml + + * xml/XSLTProcessor.cpp: + (WebCore::XSLTProcessor::createDocumentFromSource): + +2010-10-22 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Roben. + + [WINCE] Implement GraphicsContext::(get|release)WindowsContext + https://bugs.webkit.org/show_bug.cgi?id=48136 + + * platform/graphics/wince/GraphicsContextWinCE.cpp: + (WebCore::GraphicsContext::getWindowsContext): + (WebCore::GraphicsContext::releaseWindowsContext): + +2010-10-22 Adam Roben <aroben@apple.com> + + Attempt to fix the Windows build + + * platform/network/win/CookieJarCFNetWin.cpp: Add a missing #include. + +2010-10-22 Cosmin Truta <ctruta@chromium.org> + + Reviewed by Dirk Schulze. + + getBoundingClientRect does not work with SVG <text> + https://bugs.webkit.org/show_bug.cgi?id=46775 + + Added back to SVGStyledTransformableElement overloads of the following + methods: nearestViewportElement, farthestViewportElement, getBBox. + This was necessary to appease the Visual C++ compiler, which warned on + inheritance via dominance. + + * svg/SVGStyledTransformableElement.cpp: + * svg/SVGStyledTransformableElement.h: + (SVGStyledTransformableElement::nearestViewportElement): + (SVGStyledTransformableElement::farthestViewportElement): + (SVGStyledTransformableElement::getBBox): + +2010-10-21 Chris Marrin <cmarrin@apple.com> + + Reviewed by Adam Roben. + + Content in <iframe> doesn't appear when going back to http://webkit.org/blog/386/3d-transforms/ + https://bugs.webkit.org/show_bug.cgi?id=32447 + + Added documentDidBecomeActive() when document comes back from cache to cause compositing + layers in iframes to be reattached. + + There is no layout test, but I added a manual test. This test is ready to be a layout test + but currently DRT disables the WebCore page cache, so the back/forward essentially do a + page load which does not exhibit the bug. + + * history/CachedFrame.cpp: + (WebCore::CachedFrameBase::restore): + * manual-tests/compositing/show-composited-iframe-on-back-button.html: Added. + +2010-10-22 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Roben. + + [WIN] Add Windows specific files for platform/network/win + https://bugs.webkit.org/show_bug.cgi?id=27376 + + * platform/network/win/AuthenticationChallenge.h: Added. + (WebCore::AuthenticationChallenge::AuthenticationChallenge): + * platform/network/win/ResourceError.h: Added. + (WebCore::ResourceError::ResourceError): + * platform/network/win/ResourceRequest.h: Added. + (WebCore::ResourceRequest::ResourceRequest): + (WebCore::ResourceRequest::doUpdatePlatformRequest): + (WebCore::ResourceRequest::doUpdateResourceRequest): + (WebCore::ResourceRequest::doPlatformCopyData): + (WebCore::ResourceRequest::doPlatformAdopt): + * platform/network/win/ResourceResponse.h: Added. + (WebCore::ResourceResponse::ResourceResponse): + (WebCore::ResourceResponse::doPlatformCopyData): + (WebCore::ResourceResponse::doPlatformAdopt): + +2010-10-22 Adam Barth <abarth@webkit.org> + + Unreviewed, rolling out r70290. + http://trac.webkit.org/changeset/70290 + https://bugs.webkit.org/show_bug.cgi?id=48111 + + Undelete Android build files. + + * Android.mk: Added. + +2010-10-22 Cosmin Truta <ctruta@chromium.org> + + Reviewed by Nikolas Zimmermann. + + getBoundingClientRect does not work with SVG <text> + https://bugs.webkit.org/show_bug.cgi?id=46775 + + Dispatched the calls from Element::getBoundingClientRect to getBBox + through SVGElement::boundingBox. + Recognized SVGTextElement in addition to SVGStyledLocatableElement + as a class that provides getBBox. + Fixed the result of zooming: adjusted the getBoundingClientRect rectangle + for absolute zoom, even for SVG elements. + + Additional cleanup task: + Removed redundant overloads of SVGStyledTransformableElement + methods: nearestViewportElement, farthestViewportElement, getBBox. + These methods are already inherited from SVGStyledLocatableElement. + + Test: css3/zoom-coords.xhtml + + * WebCore.xcodeproj/project.pbxproj: Set role of SVGLocatable.h to private. + * dom/Element.cpp: + (Element::getBoundingClientRect): Used SVGElement::boundingBox. + Adjusted coordinates for absolute zoom, for all kinds of elements. + * svg/SVGElement.cpp: + * svg/SVGElement.h: + (SVGElement::boundingBox): Added. + * svg/SVGStyledTransformableElement.cpp: + * svg/SVGStyledTransformableElement.h: + (SVGStyledTransformableElement::nearestViewportElement): Removed. + (SVGStyledTransformableElement::farthestViewportElement): Removed. + (SVGStyledTransformableElement::getBBox): Removed. + +2010-10-22 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Roben. + + [WIN] Add stubs for SocketStream classes + https://bugs.webkit.org/show_bug.cgi?id=47983 + + * platform/network/win/SocketStreamError.h: Copied from WebCore/platform/network/curl/SocketStreamError.h. + (WebCore::SocketStreamError::SocketStreamError): + * platform/network/win/SocketStreamHandle.h: Copied from WebCore/platform/network/curl/SocketStreamHandle.h. + (WebCore::SocketStreamHandle::create): + * platform/network/win/SocketStreamHandleWin.cpp: Copied from WebCore/platform/network/curl/SocketStreamHandleCurl.cpp. + +2010-10-22 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Roben. + + Disable cache in ResourceHandleWin + https://bugs.webkit.org/show_bug.cgi?id=48128 + + The caching of windows does not work correctly, so disable it for now. + + * platform/network/win/ResourceHandleWin.cpp: + (WebCore::ResourceHandle::start): + +2010-10-22 Jia Pu <jpu@apple.com> + + Reviewed by Dan Bernstein. + + Regression (r69548): cancelled autocorrection suggestion is still applied. + https://bugs.webkit.org/show_bug.cgi?id=48081 + <rdar://problem/8579765> + + The test requires a 0.3 second delay using setTimeout(). So we put it in manual-tests. + + * editing/Editor.cpp: + (WebCore::Editor::handleRejectedCorrection): Clear autocorrection info when user dismissed the panel. + * manual-tests/autocorrection/autocorrection-cancelled-by-ESC.html: Added. + +2010-10-22 Andreas Kling <kling@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Gtk] Fix canvas/philip/tests/2d.path.isPointInPath.nonfinite.html + https://bugs.webkit.org/show_bug.cgi?id=48133 + + * platform/graphics/cairo/PathCairo.cpp: + (WebCore::Path::contains): Return false if any x or y are nonfinite. + +2010-10-22 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: Implement property toggling in InspectorCSSAgent + + This change implements enablement/disablement and setting of style properties. + Disabled properties are persisted in the (top-level) scope of InspectorStyleSheet. + https://bugs.webkit.org/show_bug.cgi?id=47339 + + Drive-by: fixes for the Web Inspector Protocol format. + + * inspector/InspectorCSSAgent.cpp: + (WebCore::InspectorCSSAgent::getComputedStyleForNode2): + (WebCore::InspectorCSSAgent::getInheritedStylesForNode2): + (WebCore::InspectorCSSAgent::setPropertyText2): + (WebCore::InspectorCSSAgent::toggleProperty2): + (WebCore::InspectorCSSAgent::setRuleSelector2): + (WebCore::InspectorCSSAgent::buildObjectForAttributeStyles): + * inspector/InspectorCSSAgent.h: + * inspector/InspectorStyleSheet.cpp: + (WebCore::InspectorStyle::buildObjectForStyle): + (WebCore::InspectorStyle::setPropertyText): + (WebCore::InspectorStyle::toggleProperty): + (WebCore::InspectorStyle::disabledIndexByOrdinal): + (WebCore::InspectorStyle::styleText): + (WebCore::InspectorStyle::disableProperty): + (WebCore::InspectorStyle::enableProperty): + (WebCore::InspectorStyle::populateAllProperties): + (WebCore::InspectorStyle::populateObjectWithStyleProperties): + (WebCore::InspectorStyle::shiftDisabledProperties): + (WebCore::InspectorStyle::replacePropertyInStyleText): + (WebCore::InspectorStyle::shorthandValue): + (WebCore::InspectorStyle::shorthandPriority): + (WebCore::InspectorStyle::longhandProperties): + (WebCore::InspectorStyleSheet::setText): + (WebCore::InspectorStyleSheet::setRuleSelector): + (WebCore::InspectorStyleSheet::addRule): + (WebCore::InspectorStyleSheet::ruleForId): + (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): + (WebCore::InspectorStyleSheet::buildObjectForRule): + (WebCore::InspectorStyleSheet::buildObjectForStyle): + (WebCore::InspectorStyleSheet::setPropertyText): + (WebCore::InspectorStyleSheet::toggleProperty): + (WebCore::InspectorStyleSheet::styleForId): + (WebCore::InspectorStyleSheet::inspectorStyleForId): + (WebCore::InspectorStyleSheet::rememberInspectorStyle): + (WebCore::InspectorStyleSheet::forgetInspectorStyle): + (WebCore::InspectorStyleSheet::ruleOrStyleId): + (WebCore::InspectorStyleSheet::ensureText): + (WebCore::InspectorStyleSheet::setStyleText): + (WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle): + (WebCore::InspectorStyleSheet::ruleId): + (WebCore::InspectorStyleSheet::revalidateStyle): + (WebCore::InspectorStyleSheet::originalStyleSheetText): + (WebCore::InspectorStyleSheet::resourceStyleSheetText): + (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): + (WebCore::InspectorStyleSheetForInlineStyle::setStyleText): + (WebCore::InspectorStyleSheetForInlineStyle::inspectorStyleForId): + * inspector/InspectorStyleSheet.h: + (WebCore::InspectorCSSId::createFromParts): + (WebCore::InspectorCSSId::InspectorCSSId): + (WebCore::InspectorCSSId::styleSheetId): + (WebCore::InspectorCSSId::ordinal): + (WebCore::InspectorCSSId::isEmpty): + (WebCore::InspectorCSSId::asString): + (WebCore::InspectorStyleProperty::InspectorStyleProperty): + (WebCore::InspectorStyle::create): + (WebCore::InspectorStyle::InspectorStyle): + (WebCore::InspectorStyle::cssStyle): + (WebCore::InspectorStyle::hasDisabledProperties): + (WebCore::InspectorStyleSheet::styleId): + (WebCore::InspectorStyleSheetForInlineStyle::styleForId): + (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor): + (WebCore::InspectorStyleSheetForInlineStyle::rememberInspectorStyle): + (WebCore::InspectorStyleSheetForInlineStyle::forgetInspectorStyle): + +2010-10-22 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: update resources tree in storage panel upon network events. + https://bugs.webkit.org/show_bug.cgi?id=48121 + + * inspector/Inspector.idl: + * inspector/InspectorResourceAgent.cpp: + (WebCore::buildObjectForDocumentLoader): + (WebCore::buildObjectForFrameTree): + (WebCore::InspectorResourceAgent::didCommitLoad): + (WebCore::InspectorResourceAgent::frameDetachedFromParent): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager): + (WebInspector.ResourceManager.prototype._createResource): + (WebInspector.ResourceManager.prototype.didReceiveResponse): + (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): + (WebInspector.ResourceManager.prototype.didCommitLoadForFrame): + (WebInspector.ResourceManager.prototype._addResourceToStorageFrame): + (WebInspector.ResourceManager.prototype.frameDetachedFromParent): + (WebInspector.ResourceManager.prototype._clearResources): + (WebInspector.ResourceManager.prototype._processCachedResources): + (WebInspector.ResourceManager.prototype._addFramesRecursively): + (WebInspector.ResourceManager.getContents): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel.prototype.addOrUpdateFrame): + (WebInspector.StoragePanel.prototype.removeFrame): + (WebInspector.StoragePanel.prototype.addResourceToFrame): + (WebInspector.StoragePanel.prototype.removeResourcesFromFrame): + (WebInspector.BaseStorageTreeElement.prototype.onattach): + (WebInspector.BaseStorageTreeElement.prototype.onreveal): + (WebInspector.BaseStorageTreeElement.prototype.set titleText): + (WebInspector.FrameTreeElement): + (WebInspector.FrameTreeElement.prototype.onselect): + (WebInspector.FrameTreeElement.prototype.get displayName): + (WebInspector.FrameTreeElement.prototype.set displayName): + +2010-10-22 François Sausset <sausset@gmail.com> + + Reviewed by Kenneth Rohde Christiansen. + + Fix wrong xHeight() value for Apple Symbols font. + https://bugs.webkit.org/show_bug.cgi?id=41535 + + Test: mathml/xHeight.xhtml + + * platform/graphics/mac/SimpleFontDataMac.mm: + (WebCore::SimpleFontData::platformInit): + +2010-10-22 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Dirk Schulze. + + Further preparations to deploy the new SVGAnimatedProperty concept for the rest of the SVG datatypes + https://bugs.webkit.org/show_bug.cgi?id=48125 + + Model SVGListPropertyTearOff similar to SVGPropertyTearOff, allow it to be used for SVGXXXList datatypes, that are not animated. (SVGStringList) + Recognize all SVG primitive datatypes in SVGPropertyTraits. + Add a new - temporary - macro to support multiple animated properties that map to a single DOM attribute (kernelUnitLength attribute vs. kernelUnitLengthX/Y properties). + These macros will all be removed and expanded by their content, as soon as the transition to the new SVGAnimatedProperty concept is done. + + Doesn't affect any tests yet, as the code is still unused. + + * svg/properties/SVGAnimatedProperty.h: + (WebCore::SVGAnimatedProperty::lookupOrCreateWrapper): + (WebCore::SVGAnimatedProperty::lookupWrapper): + * svg/properties/SVGAnimatedPropertyMacros.h: + * svg/properties/SVGAnimatedPropertySynchronizer.h: + * svg/properties/SVGListPropertyTearOff.h: + (WebCore::SVGListPropertyTearOff::create): + (WebCore::SVGListPropertyTearOff::removeItemFromList): + (WebCore::SVGListPropertyTearOff::detachListWrappers): + (WebCore::SVGListPropertyTearOff::clear): + (WebCore::SVGListPropertyTearOff::numberOfItems): + (WebCore::SVGListPropertyTearOff::initialize): + (WebCore::SVGListPropertyTearOff::getItem): + (WebCore::SVGListPropertyTearOff::insertItemBefore): + (WebCore::SVGListPropertyTearOff::replaceItem): + (WebCore::SVGListPropertyTearOff::removeItem): + (WebCore::SVGListPropertyTearOff::appendItem): + (WebCore::SVGListPropertyTearOff::SVGListPropertyTearOff): + (WebCore::SVGListPropertyTearOff::~SVGListPropertyTearOff): + (WebCore::SVGListPropertyTearOff::commitChange): + * svg/properties/SVGPropertyTearOff.h: + * svg/properties/SVGPropertyTraits.h: + +2010-10-22 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r70301. + http://trac.webkit.org/changeset/70301 + https://bugs.webkit.org/show_bug.cgi?id=48126 + + "Lang attribute layout tests failing" (Requested by satish on + #webkit). + + * dom/Element.cpp: + (WebCore::Element::computeInheritedLanguage): + * page/SpeechInput.cpp: + (WebCore::SpeechInput::startRecognition): + * page/SpeechInput.h: + * page/SpeechInputClient.h: + * platform/mock/SpeechInputClientMock.cpp: + (WebCore::SpeechInputClientMock::startRecognition): + (WebCore::SpeechInputClientMock::setRecognitionResult): + (WebCore::SpeechInputClientMock::timerFired): + * platform/mock/SpeechInputClientMock.h: + * rendering/TextControlInnerElements.cpp: + (WebCore::TextControlInnerElement::attachInnerElement): + (WebCore::SearchFieldCancelButtonElement::detach): + (WebCore::SpinButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::detach): + +2010-10-22 Leandro Gracia Gil <leandrogracia@google.com> + + Reviewed by Jeremy Orlow. + + Patch the current speech input implementation to use and validate the + nearest language tag. The language is now passed to the startRecognition + methods so that language-specific recognition could be used. Also added + a second parameter to setMockSpeechInputResult for the language used in + speech recognition. + https://bugs.webkit.org/show_bug.cgi?id=47089 + + This is the 2nd of a 4-sided patch in Chromium and WebKit. For more + details see http://codereview.chromium.org/3615005/show and + http://codereview.chromium.org/3595018/show. + + Test: fast/speech/input-text-language-tag.html + + * dom/Element.cpp: + (WebCore::Element::computeInheritedLanguage): includes a brief character + validation for the BCP 47 language tag. + * page/SpeechInput.cpp: + (WebCore::SpeechInput::startRecognition): + * page/SpeechInput.h: + * page/SpeechInputClient.h: + * platform/mock/SpeechInputClientMock.cpp: + (WebCore::SpeechInputClientMock::startRecognition): + (WebCore::SpeechInputClientMock::setRecognitionResult): results are now + stored by language using a hash map. + (WebCore::SpeechInputClientMock::timerFired): + * platform/mock/SpeechInputClientMock.h: + * rendering/TextControlInnerElements.cpp: + (WebCore::TextControlInnerElement::attachInnerElement): + (WebCore::SearchFieldCancelButtonElement::detach): + (WebCore::SpinButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::detach): + +2010-10-21 Yury Semikhatsky <yurys@chromium.org> + + Unreviewed, rolling out r70298.WebKit win compilation failure. + http://trac.webkit.org/changeset/70298 + https://bugs.webkit.org/show_bug.cgi?id=48122 + +2010-10-21 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: decouple ScriptArguments from ScriptCallStack + https://bugs.webkit.org/show_bug.cgi?id=48058 + + ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8. + The factory functions that allow to create ScriptCallStack from VM-specific + objects are defined in ScriptCallStackFactory.cpp. + + ScriptArguments class is used for passing arguments from JS code to the native + part. + + No new tests. This refactoring is covered with existing Console tests. + + * WebCore.gypi: + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/ScriptCallFrame.cpp: Removed. + * bindings/js/ScriptCallFrame.h: Removed. + * bindings/js/ScriptCallStack.cpp: Removed. + * bindings/js/ScriptCallStack.h: Removed. + * bindings/js/ScriptCallStackFactory.cpp: Added. + (WebCore::createScriptCallStack): + (WebCore::createScriptArguments): + (WebCore::ScriptCallStack::stackTrace): + * bindings/js/ScriptCallStackFactory.h: Added. + * bindings/js/ScriptState.h: + (WebCore::ScriptStateProtectedPtr::get): + * bindings/scripts/CodeGeneratorJS.pm: + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/v8/ScriptCallFrame.cpp: Removed. + * bindings/v8/ScriptCallFrame.h: Removed. + * bindings/v8/ScriptCallStack.cpp: Removed. + * bindings/v8/ScriptCallStack.h: Removed. + * bindings/v8/ScriptCallStackFactory.cpp: Added. + (WebCore::toScriptCallFrame): + (WebCore::toScriptCallFramesVector): + (WebCore::createScriptCallStack): + (WebCore::createScriptArguments): + (WebCore::ScriptCallStack::stackTrace): + * bindings/v8/ScriptCallStackFactory.h: Added. + * bindings/v8/ScriptController.cpp: + (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions): + * bindings/v8/ScriptState.h: + (WebCore::ScriptStateProtectedPtr::get): + * bindings/v8/V8ConsoleMessage.cpp: + (WebCore::V8ConsoleMessage::handler): + (WebCore::V8ConsoleMessage::dispatchNow): + * bindings/v8/V8ConsoleMessage.h: + * bindings/v8/custom/V8ConsoleCustom.cpp: + (WebCore::V8Console::traceCallback): + (WebCore::V8Console::assertCallback): + * inspector/ConsoleMessage.cpp: + (WebCore::ConsoleMessage::ConsoleMessage): + (WebCore::ConsoleMessage::addToFrontend): + (WebCore::ConsoleMessage::updateRepeatCountInConsole): + (WebCore::ConsoleMessage::isEqual): + * inspector/ConsoleMessage.h: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::addMessageToConsole): + (WebCore::InspectorController::startGroup): + * inspector/InspectorController.h: + * inspector/ScriptArguments.cpp: Added. + (WebCore::ScriptArguments::ScriptArguments): + (WebCore::ScriptArguments::~ScriptArguments): + (WebCore::ScriptArguments::argumentAt): + (WebCore::ScriptArguments::globalState): + (WebCore::ScriptArguments::getFirstArgumentAsString): + (WebCore::ScriptArguments::isEqual): + * inspector/ScriptArguments.h: Added. + (WebCore::ScriptArguments::argumentCount): + * inspector/ScriptCallFrame.cpp: Added. + (WebCore::ScriptCallFrame::ScriptCallFrame): + (WebCore::ScriptCallFrame::~ScriptCallFrame): + (WebCore::ScriptCallFrame::isEqual): + (WebCore::ScriptCallFrame::buildInspectorObject): + * inspector/ScriptCallFrame.h: Added. + (WebCore::ScriptCallFrame::functionName): + (WebCore::ScriptCallFrame::sourceURL): + (WebCore::ScriptCallFrame::lineNumber): + * inspector/ScriptCallStack.cpp: Added. + (WebCore::ScriptCallStack::ScriptCallStack): + (WebCore::ScriptCallStack::~ScriptCallStack): + (WebCore::ScriptCallStack::at): + (WebCore::ScriptCallStack::size): + (WebCore::ScriptCallStack::isEqual): + (WebCore::ScriptCallStack::buildInspectorObject): + * inspector/ScriptCallStack.h: Added. + * page/Console.cpp: + (WebCore::Console::addMessage): + (WebCore::Console::debug): + (WebCore::Console::error): + (WebCore::Console::info): + (WebCore::Console::log): + (WebCore::Console::dir): + (WebCore::Console::dirxml): + (WebCore::Console::trace): + (WebCore::Console::assertCondition): + (WebCore::Console::count): + (WebCore::Console::markTimeline): + (WebCore::Console::profile): + (WebCore::Console::profileEnd): + (WebCore::Console::timeEnd): + (WebCore::Console::group): + (WebCore::Console::groupCollapsed): + (WebCore::Console::shouldCaptureFullStackTrace): + (WebCore::Console::warn): + * page/Console.h: + +2010-10-22 Benjamin Poulain <benjamin.poulain@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] All widgets are rendered incorrectly when rendered through a cache + https://bugs.webkit.org/show_bug.cgi?id=47767 + + When a widget is not available to the RenderTheme, default + value are used for the state. + + * platform/qt/RenderThemeQt.cpp: + (WebCore::initStyleOption): + (WebCore::RenderThemeQt::paintButton): + (WebCore::RenderThemeQt::paintTextField): + (WebCore::RenderThemeQt::paintMenuList): + (WebCore::RenderThemeQt::paintMenuListButton): + (WebCore::RenderThemeQt::paintProgressBar): + (WebCore::RenderThemeQt::paintSliderTrack): + +2010-10-22 Zoltan Herczeg <zherczeg@webkit.org> + + Reviewed by Dirk Schulze. + + Moving all bounding box related calculation to RenderSVGResourceFilterPrimitive + https://bugs.webkit.org/show_bug.cgi?id=47174 + + The primitive sub-region calculation was spread in many + files across in WebKit source code, and all of them are moved + to RenderSVGResourceFilterPrimitive, where they should be. + In this patch the calculation is a static method which will + be turned to a real member function in the near future. + + * platform/graphics/filters/FETile.cpp: + * platform/graphics/filters/FETile.h: + (WebCore::FETile::filterEffectType): + * platform/graphics/filters/Filter.h: + * platform/graphics/filters/FilterEffect.cpp: + * platform/graphics/filters/FilterEffect.h: + * rendering/RenderSVGResourceFilter.cpp: + (WebCore::RenderSVGResourceFilter::applyResource): + * rendering/RenderSVGResourceFilterPrimitive.cpp: + (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion): + * rendering/RenderSVGResourceFilterPrimitive.h: + (WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive): + * svg/graphics/filters/SVGFilter.cpp: + * svg/graphics/filters/SVGFilter.h: + (WebCore::SVGFilter::mapLocalRectToAbsoluteRect): + (WebCore::SVGFilter::targetBoundingBox): + +2010-10-21 Kwang Yul Seo <skyul@company100.net> + + Reviewed by Kent Tamura. + + [BREWMP] Add a String constructor which takes AECHAR* + https://bugs.webkit.org/show_bug.cgi?id=45043 + + Implement String(const AECHAR*) constructor. + + * platform/text/brew/StringBrew.cpp: Added. + (WTF::String::String): + +2010-10-21 James Simonsen <simonjam@chromium.org> + + Reviewed by Adam Barth. + + HTMLTreeBuilder's InForeignContent code needs a re-write + + Foreign Content mode was changed significantly by: + http://www.w3.org/Bugs/Public/show_bug.cgi?id=10314 + + The differences can be seen here: + http://html5.org/tools/web-apps-tracker?from=5520&to=5522 + + This bug addresses all spec changes in the diff except the select scope + changes, which have already been fixed in a separate bug. + + https://bugs.webkit.org/show_bug.cgi?id=46676 + + * html/parser/HTMLElementStack.cpp: + (WebCore::HTMLNames::isScopeMarker): Add foreign elements to list. + * html/parser/HTMLTreeBuilder.cpp: + (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): + (WebCore::HTMLTreeBuilder::processDoctypeToken): Switch mode before reprocessing any tokens. + (WebCore::HTMLTreeBuilder::processStartTagForInBody): Ditto. Remove secondary insertion mode. + (WebCore::HTMLTreeBuilder::processStartTagForInTable): Switch mode before reprocessing any tokens. + (WebCore::HTMLTreeBuilder::processStartTag): Ditto. Remove secondary insertion mode. + (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): Remove foreign var. Use hasTagName() instead of == localName() to fix bug with foreign elements. + (WebCore::HTMLTreeBuilder::processEndTagForInTableBody): Switch mode before reprocessing any tokens. + (WebCore::HTMLTreeBuilder::processEndTagForInRow): Ditto. + (WebCore::HTMLTreeBuilder::processEndTagForInCell): Ditto. + (WebCore::HTMLTreeBuilder::processEndTagForInBody): Ditto. + (WebCore::HTMLTreeBuilder::processEndTag): Ditto. + (WebCore::HTMLTreeBuilder::prepareToReprocessToken): Added. + (WebCore::HTMLTreeBuilder::reprocessStartTag): Added. + (WebCore::HTMLTreeBuilder::reprocessEndTag): Added. + (WebCore::HTMLTreeBuilder::processForeignContentUsingInBodyModeAndResetMode): Added. + (WebCore::HTMLTreeBuilder::resetForeignInsertionMode): Added. + (WebCore::HTMLTreeBuilder::processComment): Switch mode before reprocessing any tokens. + (WebCore::HTMLTreeBuilder::processCharacterBuffer): Ditto. + (WebCore::HTMLTreeBuilder::processEndOfFile): Ditto. + * html/parser/HTMLTreeBuilder.h: Functions and member for tracking potential switch from InForeignContentMode. + +2010-10-21 Adam Barth <abarth@webkit.org> + + Reviewed by David Levin. + + Remove Android build system + https://bugs.webkit.org/show_bug.cgi?id=48111 + + As far as I can tell, these files are not maintained. They are a + mantaince burden on the project. If folks would like to come out of + the woodwork and maintain these files, that's great. At the moment, + they seem like dead weight for the project. + + * Android.mk: Removed. + +2010-10-21 Kwang Yul Seo <skyul@company100.net> + + Reviewed by James Robinson. + + Make sure skia is not Chromium specific + https://bugs.webkit.org/show_bug.cgi?id=39672 + + GlyphPageTreeNodeLinux does not depend on Linux or Chromium. + Move GlyphPageTreeNodeLinux to platform/graphics/skia and rename it to + GlyphPageTreeNodeSkia.cpp so that other ports can use it. + + * WebCore.gyp/WebCore.gyp: + * WebCore.gypi: + * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Removed. + * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added. + +2010-10-21 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Tony Chang. + + removeFormat needs to be reimplemented + https://bugs.webkit.org/show_bug.cgi?id=43017 + + Reimplemented execCommand('RemoveFormat', false, null). New implementation removes + the same elements removed by Internet Explorer. Because WebKit supports StyleWithCSS + we also reset any editing styles to match that of the root editable element + while Internet Explorer does not remove any CSS styles. + + New implementation uses ApplyStyleCommand to remove appropriate elements and reset the style. + Added new constructor and member variable to ApplyStyleCommand to support mass-removal of elements + since it's inefficient to call ApplyStyleCommand on each element we're removing. + + To avoid an infinite loop in pushDownInlineStyleAroundNode when mass-removing, WebKit no longer + push down element one level at a time. Instead, we keep a stack of styled elements to be applied, + and apply wrap siblings of targetNode's ancestors by all of them at once. + + Tests: editing/execCommand/remove-format-elements.html + editing/execCommand/remove-format-multiple-elements.html + + * editing/ApplyStyleCommand.cpp: + (WebCore::ApplyStyleCommand::ApplyStyleCommand): Added; this version takes style and a function pointer + to a boolean function that determines which element needs to removed, and set m_removeOnly to true. + (WebCore::ApplyStyleCommand::doApply): Added support for m_isInlineElementToRemoveFunction. + (WebCore::ApplyStyleCommand::applyBlockStyle): Ditto. + (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Exits early if m_removeOnly is true. + (WebCore::ApplyStyleCommand::isStyledInlineElementToRemove): Added. + (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls isStyledInlineElementToRemove. + (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Ditto. + (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto. + (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): See above. + * editing/ApplyStyleCommand.h: + (WebCore::ApplyStyleCommand::create): Added. + * editing/RemoveFormatCommand.cpp: + (WebCore::isElementForRemoveFormatCommand): Added. + (WebCore::RemoveFormatCommand::doApply): Rewritten. + +2010-10-21 Tony Gentilcore <tonyg@chromium.org> + + Reviewed by Adam Barth. + + Ignore document.write() when it comes from a network task + https://bugs.webkit.org/show_bug.cgi?id=47560 + + This implements the update to the spec made by: + http://www.w3.org/Bugs/Public/show_bug.cgi?id=9767 + + It also matches the latest Firefox 4 beta. The notable change is that + document.write from a deferred script no longer works. This avoids + blowing the patch away. + + * dom/Document.cpp: + (WebCore::Document::Document): + (WebCore::Document::write): + * dom/Document.h: + (WebCore::DestructiveWriteCountIncrementer::DestructiveWriteCountIncrementer): + (WebCore::Document::ignoreDestructiveWriteCountIncrementer): + * dom/ScriptElement.cpp: + (WebCore::ScriptElement::insertedIntoDocument): + (WebCore::ScriptElementData::ScriptElementData): + (WebCore::ScriptElementData::evaluateScript): + * dom/ScriptElement.h: + * html/parser/HTMLScriptRunner.cpp: + (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): + +2010-10-21 Ryosuke Niwa <rniwa@webkit.org> + + Unreviewed Leopard build fix attempt. + + Explicitly cast the return value of deg2rad to float. + + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::paint): + +2010-10-21 Mihai Parparita <mihaip@chromium.org> + + Reviewed by James Robinson. + + [Chromium] Fix Chromium Mac build + https://bugs.webkit.org/show_bug.cgi?id=48096 + + Fix Chromium Mac build after r70225 (Chromium uses Core Text but is not + PLATFORM(MAC)). + + * platform/graphics/SimpleFontData.h: + +2010-10-21 Xiaomei Ji <xji@chromium.org> + + Reviewed by David Levin. + + Performance improvement for FontLinux. + https://bugs.webkit.org/show_bug.cgi?id=47019 + + Reduce the number of calls for the normalization function because converting + to NFC form is very expensive. + + Combine space normalization and character mirroring into one text scan. + + Test: platform/chromium/fast/text/font-linux-normalize.html + + * platform/graphics/chromium/FontLinux.cpp: + (WebCore::TextRunWalker::TextRunWalker): + (WebCore::TextRunWalker::~TextRunWalker): + (WebCore::TextRunWalker::getNormalizedTextRun): + (WebCore::TextRunWalker::normalizeSpacesAndMirrorChars): + +2010-10-21 David Hyatt <hyatt@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=48085 + + Make basic vertical text painting work. This includes the text itself, underlines, overlines, line-throughs and shadows. + + Added fast/blockflow/english-lr-text.html + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::paint): + * rendering/InlineFlowBox.h: + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::applyShadowToGraphicsContext): + (WebCore::paintTextWithShadows): + (WebCore::InlineTextBox::paint): + (WebCore::InlineTextBox::paintDecoration): + (WebCore::InlineTextBox::paintTextMatchMarker): + * rendering/InlineTextBox.h: + * rendering/svg/SVGInlineTextBox.cpp: + (WebCore::SVGInlineTextBox::paintTextWithShadows): + +2010-10-21 No'am Rosenthal <noam.rosenthal@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] When doing rendering through tiling, it seems the tiles are not initialized before rendering + https://bugs.webkit.org/show_bug.cgi?id=48070 + + No new tests. Auto-tests for Tiled Backing Store should be added, see bug 48082 + + * page/Frame.cpp: + (WebCore::Frame::tiledBackingStoreBackgroundColor): + * page/Frame.h: + * platform/graphics/TiledBackingStoreClient.h: + * platform/graphics/qt/TileQt.cpp: + (WebCore::Tile::updateBackBuffer): + +2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com> + + Reviewed by Martin Robinson. + + [GTK] Use GCharsetConverter instead of g_iconv in TextCodecGtk + https://bugs.webkit.org/show_bug.cgi?id=47896 + + It makes error handling easier. Fixes tests: + fast/encoding/invalid-multi-byte-over-consumption.html + fast/encoding/invalid-xml.html + fast/encoding/japanese-encoding-mix.html + when building with glib unicode + + * platform/text/gtk/TextCodecGtk.cpp: + (WebCore::TextCodecGtk::TextCodecGtk): + (WebCore::TextCodecGtk::~TextCodecGtk): + (WebCore::TextCodecGtk::createIConvDecoder): + (WebCore::TextCodecGtk::createIConvEncoder): + (WebCore::TextCodecGtk::decode): + (WebCore::TextCodecGtk::encode): + * platform/text/gtk/TextCodecGtk.h: + +2010-10-21 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Beth Dakin. + + AX: contenteditable nodes do not return correct AXSelectedText* attributes + https://bugs.webkit.org/show_bug.cgi?id=48080 + + The ariaSelectedDOMTextRange() method was not returning the correct values. + The fix is to return a plain text range that represents the current selection. + + Test: platform/mac/accessibility/content-editable-range-properties.html + + * accessibility/AccessibilityObject.h: + (WebCore::AccessibilityObject::accessibilityDescription): + * accessibility/AccessibilityRenderObject.cpp: + (WebCore::AccessibilityRenderObject::ariaSelectedTextRange): + (WebCore::AccessibilityRenderObject::selectedText): + (WebCore::AccessibilityRenderObject::selectedTextRange): + * accessibility/AccessibilityRenderObject.h: + +2010-10-20 Jer Noble <jer.noble@apple.com> + + Reviewed by Eric Carlson. + + Video -> Canvas doesn't work on Windows + https://bugs.webkit.org/show_bug.cgi?id=47996 + rdar://problem/7884690 + + * WebCore.vcproj/QTMovieWin.vcproj: Added QTDecompressionSession.{cpp,h} + * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: + (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Create a + QTDecompressionSession if necessary and convert the QTPixelBuffer + into a CG-compatible one. + * platform/graphics/win/QTDecompressionSession.cpp: Added. + * platform/graphics/win/QTDecompressionSession.h: Added. + * platform/graphics/win/QTPixelBuffer.cpp: + (SetNumberValue): Moved from QTMovieVisualContext. + (QTPixelBuffer::createPixelBufferAttributesDictionary): Moved from inside + QTMovieVisualContext::createPixelBufferOptionsDictionary(). + * platform/graphics/win/QTPixelBuffer.h: Moved the Type enum + from QTMovieVisualContext.h. + +2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com> + + Reviewed by Martin Robinson. + + [GTK] TextBreakIteratorGtk should initialize its internal index to 0 + https://bugs.webkit.org/show_bug.cgi?id=48065 + + It fixes the following tests when using glib unicode: + fast/forms/ValidityState-tooLong-input.html + fast/forms/ValidityState-tooLong-textarea.html + fast/forms/input-appearance-maxlength.html + fast/forms/input-implicit-length-limit.html + fast/forms/input-maxlength.html + fast/forms/textarea-live-pseudo-selectors.html + fast/forms/mailto/advanced-get.html + fast/forms/mailto/advanced-put.html + + * platform/text/gtk/TextBreakIteratorGtk.cpp: + (WebCore::setUpIterator): + +2010-10-21 takano takumi <takano1@asia.apple.com> + + Reviewed by Dan Bernstein. + + Need to swap glyphs for vertical writing + https://bugs.webkit.org/show_bug.cgi?id=46973 + + Made changes to pass the writing-mode orientation flag in RenderStyle down to FontPlatformData, + and ultimately to CoreText APIs in both font complex path and fast path. + + Tests: fast/text/international/vertical-text-glyph-test.html + fast/text/international/vertical-text-metrics-test.html + + * WebCore.exp.in: + * WebCore.xcodeproj/project.pbxproj: Added platform/graphics/FontOrientation.h. + * css/CSSFontFaceSource.cpp: + (WebCore::CSSFontFaceSource::getFontData): Added font orientation parameter to SimpleFontData. + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::applyProperty): Set appropriate font orientation to the font description + when writing-mode is being specified. + * loader/CachedFont.cpp: + (WebCore::CachedFont::platformDataFromCustomData): Made to pass font orientation to FontPlatformData. + * loader/CachedFont.h: + * platform/graphics/FontCache.cpp: Added font orientation to FontPlatformDataCacheKey + (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): + (WebCore::FontPlatformDataCacheKey::operator==): + (WebCore::computeHash): + (WebCore::FontCache::getCachedFontPlatformData): + * platform/graphics/FontDescription.h: Added font orientation support to FontDescription class + (WebCore::FontDescription::FontDescription): + (WebCore::FontDescription::orientation): + (WebCore::FontDescription::setOrientation): + (WebCore::FontDescription::operator==): + * platform/graphics/FontOrientation.h: Added. + * platform/graphics/SimpleFontData.h: + * platform/graphics/cairo/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/cairo/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/cocoa/FontPlatformData.h: Added font orientation support to FontPlatformData class + (WebCore::FontPlatformData::FontPlatformData): + (WebCore::FontPlatformData::orientation): + (WebCore::FontPlatformData::hash): + (WebCore::FontPlatformData::operator==): + * platform/graphics/cocoa/FontPlatformDataCocoa.mm: Added font orientation support + (WebCore::FontPlatformData::FontPlatformData): + (WebCore::FontPlatformData::operator=): + (WebCore::FontPlatformData::allowsLigatures): Don't allow ligatures when the font is vertical orientation. + (WebCore::FontPlatformData::description): + * platform/graphics/gtk/FontCustomPlatformDataPango.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/haiku/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/haiku/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/mac/FontCacheMac.mm: Added font orientation parameter when creating FontPlatformData object. + (WebCore::FontCache::getFontDataForCharacters): + (WebCore::FontCache::createFontPlatformData): + * platform/graphics/mac/FontCustomPlatformData.cpp: Added font orientation parameter when creating FontPlatformData object. + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/mac/FontCustomPlatformData.h: Changed to pass font orientation parameter to fontPlatformData() + * platform/graphics/mac/GlyphPageTreeNodeMac.cpp: + (WebCore::GlyphPage::fill): Changed to use CoreText to extract glyphs when the current font is vertical orientation. + CoreText automatically swaps glyphs with vertical variants when the font orientation is vertical. + * platform/graphics/mac/SimpleFontDataCoreText.cpp: Added vertical form attribute to the attribute dictionary for a CTLine. + (WebCore::SimpleFontData::getCFStringAttributes): + * platform/graphics/mac/SimpleFontDataMac.mm: + (WebCore::SimpleFontData::platformBoundsForGlyph): Changed to use CoreText (from CG) to support vertical metrics. + (WebCore::SimpleFontData::platformWidthForGlyph): Made to use CoreText, instead of wkGetGlyphTransformedAdvances, + to get vertical metrics when the font orientation is vertical. + * platform/graphics/qt/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/qt/FontCustomPlatformDataQt.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/skia/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/skia/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/win/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/win/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/win/FontCustomPlatformDataCairo.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/win/FontCustomPlatformDataCairo.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/wince/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/wince/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/wx/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/wx/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + +2010-10-21 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: provide resource tree in the Storage panel (behind the flag). + https://bugs.webkit.org/show_bug.cgi?id=48069 + + * WebCore.gypi: + * inspector/Inspector.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::frameDetachedFromParent): + * inspector/InspectorResourceAgent.cpp: + (WebCore::buildObjectForDocumentLoader): + (WebCore::buildObjectForFrameResource): + (WebCore::buildObjectForCachedResource): + (WebCore::populateObjectWithFrameResources): + (WebCore::InspectorResourceAgent::identifierForInitialRequest): + (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): + (WebCore::buildObjectForFrameTree): + (WebCore::InspectorResourceAgent::didCommitLoad): + (WebCore::InspectorResourceAgent::frameDetachedFromParent): + (WebCore::InspectorResourceAgent::cachedResources): + (WebCore::InspectorResourceAgent::resourceContent): + * inspector/InspectorResourceAgent.h: + * inspector/front-end/Images/frame.png: Added. + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel.prototype.refreshResource): + (WebInspector.NetworkPanel.prototype._showResource): + * inspector/front-end/Resource.js: + (WebInspector.Resource.Type.toString): + (WebInspector.Resource.prototype.getContents): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager): + (WebInspector.ResourceManager.prototype.identifierForInitialRequest): + (WebInspector.ResourceManager.prototype._createResource): + (WebInspector.ResourceManager.prototype.willSendRequest): + (WebInspector.ResourceManager.prototype._appendRedirect): + (WebInspector.ResourceManager.prototype.markResourceAsCached): + (WebInspector.ResourceManager.prototype.didReceiveResponse): + (WebInspector.ResourceManager.prototype._updateResourceWithResponse): + (WebInspector.ResourceManager.prototype.didReceiveContentLength): + (WebInspector.ResourceManager.prototype.didFinishLoading): + (WebInspector.ResourceManager.prototype.didFailLoading): + (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): + (WebInspector.ResourceManager.prototype._updateResourceWithCachedResource): + (WebInspector.ResourceManager.prototype.setOverrideContent): + (WebInspector.ResourceManager.prototype.didCommitLoadForFrame): + (WebInspector.ResourceManager.prototype.frameDetachedFromParent): + (WebInspector.ResourceManager.prototype._clearResources): + (WebInspector.ResourceManager.prototype.didCreateWebSocket): + (WebInspector.ResourceManager.prototype.willSendWebSocketHandshakeRequest): + (WebInspector.ResourceManager.prototype.didReceiveWebSocketHandshakeResponse): + (WebInspector.ResourceManager.prototype.didCloseWebSocket): + (WebInspector.ResourceManager.prototype._processCachedResources): + (WebInspector.ResourceManager.prototype._appendFramesRecursively.comparator): + (WebInspector.ResourceManager.prototype._appendFramesRecursively): + (WebInspector.ResourceManager.createResourceView): + (WebInspector.ResourceManager.resourceViewTypeMatchesResource): + (WebInspector.ResourceManager.resourceViewForResource): + (WebInspector.ResourceManager.getContents): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.ResourcesPanel.prototype.get searchableViews): + (WebInspector.ResourcesPanel.prototype.addMessageToResource): + (WebInspector.ResourcesPanel.prototype._recreateViewForResourceIfNeeded): + (WebInspector.ResourcesPanel.prototype.showResource): + (WebInspector.ResourcesPanel.prototype.sourceFrameForResource): + * inspector/front-end/ScriptsPanel.js: + (WebInspector.ScriptsPanel.prototype._showScriptOrResource): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel): + (WebInspector.StoragePanel.prototype.addFrame): + (WebInspector.StoragePanel.prototype.removeFrame): + (WebInspector.StoragePanel.prototype.addFrameResource): + (WebInspector.StoragePanel.prototype.removeFrameResources): + (WebInspector.StoragePanel.prototype.showResource): + (WebInspector.BaseStorageTreeElement.prototype.onattach): + (WebInspector.BaseStorageTreeElement.prototype.onreveal): + (WebInspector.FrameTreeElement): + (WebInspector.FrameTreeElement.prototype.onselect): + (WebInspector.FrameResourceTreeElement): + (WebInspector.FrameResourceTreeElement.prototype.onselect): + (WebInspector.FrameResourceTreeElement.prototype.onattach): + * inspector/front-end/WebKit.qrc: + * inspector/front-end/inspector.css: + (.frame-storage-tree-item .icon): + (.storage.panel .sidebar.outline-disclosure > ol): + (.resources-category-images .image-resource-icon-preview): + (.children.small .resources-category-images .image-resource-icon-preview): + * inspector/front-end/inspector.js: + +2010-10-21 David Kilzer <ddkilzer@apple.com> + + <http://webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types + + Reviewed by Adam Roben. + + Fixes the following warning: + + WARNING: Unknown file type 'sourcecode' for file 'CSSPrimitiveValue.idl'. + 1 issues found for WebCore/WebCore.xcodeproj/project.pbxproj. + + * WebCore.xcodeproj/project.pbxproj: Removed explicit file type + for CSSPrimitiveValue.idl to make it match other IDL files. + +2010-10-21 Yury Semikhatsky <yurys@chromium.org> + + Unreviewed. Revert r70232. Chromium compilation failure. + +2010-10-21 Yury Semikhatsky <yurys@chromium.org> + + Unreviewed. Revert r70233. Too many failures. + +2010-10-21 Yury Semikhatsky <yurys@chromium.org> + + Unreviewed. Remove references to deleted headers from WebCore.pro + + * WebCore.pro: + +2010-10-21 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: decouple ScriptArguments from ScriptCallStack + https://bugs.webkit.org/show_bug.cgi?id=48058 + + ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8. + The factory functions that allow to create ScriptCallStack from VM-specific + objects are defined in ScriptCallStackFactory.cpp. + + ScriptArguments class is used for passing arguments from JS code to the native + part. + + No new tests. This refactoring is covered with existing Console tests. + + * WebCore.gypi: + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/ScriptCallFrame.cpp: Removed. + * bindings/js/ScriptCallFrame.h: Removed. + * bindings/js/ScriptCallStack.cpp: Removed. + * bindings/js/ScriptCallStack.h: Removed. + * bindings/js/ScriptCallStackFactory.cpp: Added. + (WebCore::createScriptCallStack): + (WebCore::createScriptArguments): + (WebCore::ScriptCallStack::stackTrace): + * bindings/js/ScriptCallStackFactory.h: Added. + * bindings/js/ScriptState.h: + (WebCore::ScriptStateProtectedPtr::get): + * bindings/scripts/CodeGeneratorJS.pm: + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/v8/ScriptCallFrame.cpp: Removed. + * bindings/v8/ScriptCallFrame.h: Removed. + * bindings/v8/ScriptCallStack.cpp: Removed. + * bindings/v8/ScriptCallStack.h: Removed. + * bindings/v8/ScriptCallStackFactory.cpp: Added. + (WebCore::toScriptCallFrame): + (WebCore::toScriptCallFramesVector): + (WebCore::createScriptCallStack): + (WebCore::createScriptArguments): + (WebCore::ScriptCallStack::stackTrace): + * bindings/v8/ScriptCallStackFactory.h: Added. + * bindings/v8/ScriptController.cpp: + (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions): + * bindings/v8/ScriptState.h: + (WebCore::ScriptStateProtectedPtr::get): + * bindings/v8/V8ConsoleMessage.cpp: + (WebCore::V8ConsoleMessage::handler): + (WebCore::V8ConsoleMessage::dispatchNow): + * bindings/v8/V8ConsoleMessage.h: + * bindings/v8/custom/V8ConsoleCustom.cpp: + (WebCore::V8Console::traceCallback): + (WebCore::V8Console::assertCallback): + * inspector/ConsoleMessage.cpp: + (WebCore::ConsoleMessage::ConsoleMessage): + (WebCore::ConsoleMessage::addToFrontend): + (WebCore::ConsoleMessage::updateRepeatCountInConsole): + (WebCore::ConsoleMessage::isEqual): + * inspector/ConsoleMessage.h: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::addMessageToConsole): + (WebCore::InspectorController::startGroup): + * inspector/InspectorController.h: + * inspector/ScriptArguments.cpp: Added. + (WebCore::ScriptArguments::ScriptArguments): + (WebCore::ScriptArguments::~ScriptArguments): + (WebCore::ScriptArguments::argumentAt): + (WebCore::ScriptArguments::globalState): + (WebCore::ScriptArguments::getFirstArgumentAsString): + (WebCore::ScriptArguments::isEqual): + * inspector/ScriptArguments.h: Added. + (WebCore::ScriptArguments::argumentCount): + * inspector/ScriptCallFrame.cpp: Added. + (WebCore::ScriptCallFrame::ScriptCallFrame): + (WebCore::ScriptCallFrame::~ScriptCallFrame): + (WebCore::ScriptCallFrame::isEqual): + (WebCore::ScriptCallFrame::buildInspectorObject): + * inspector/ScriptCallFrame.h: Added. + (WebCore::ScriptCallFrame::functionName): + (WebCore::ScriptCallFrame::sourceURL): + (WebCore::ScriptCallFrame::lineNumber): + * inspector/ScriptCallStack.cpp: Added. + (WebCore::ScriptCallStack::ScriptCallStack): + (WebCore::ScriptCallStack::~ScriptCallStack): + (WebCore::ScriptCallStack::at): + (WebCore::ScriptCallStack::size): + (WebCore::ScriptCallStack::isEqual): + (WebCore::ScriptCallStack::buildInspectorObject): + * inspector/ScriptCallStack.h: Added. + * page/Console.cpp: + (WebCore::Console::addMessage): + (WebCore::Console::debug): + (WebCore::Console::error): + (WebCore::Console::info): + (WebCore::Console::log): + (WebCore::Console::dir): + (WebCore::Console::dirxml): + (WebCore::Console::trace): + (WebCore::Console::assertCondition): + (WebCore::Console::count): + (WebCore::Console::markTimeline): + (WebCore::Console::profile): + (WebCore::Console::profileEnd): + (WebCore::Console::timeEnd): + (WebCore::Console::group): + (WebCore::Console::groupCollapsed): + (WebCore::Console::shouldCaptureFullStackTrace): + (WebCore::Console::warn): + * page/Console.h: + +2010-10-21 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Chromium: use dedicated event listener type in EventListenerWrapper. + https://bugs.webkit.org/show_bug.cgi?id=48059 + + This change introduces new EventListener::Type NativeEventListenerType. + This new type is intended to be used by any code that wants to protect + itself from unsafe casts to particular event listener implementations. + + * dom/EventListener.h: + +2010-10-21 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r70225. + http://trac.webkit.org/changeset/70225 + https://bugs.webkit.org/show_bug.cgi?id=48061 + + Build breakage on Leopard. (Requested by pfeldman on #webkit). + + * WebCore.exp.in: + * WebCore.xcodeproj/project.pbxproj: + * css/CSSFontFaceSource.cpp: + (WebCore::CSSFontFaceSource::getFontData): + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::applyProperty): + * loader/CachedFont.cpp: + (WebCore::CachedFont::platformDataFromCustomData): + * loader/CachedFont.h: + * platform/graphics/FontCache.cpp: + (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): + (WebCore::FontPlatformDataCacheKey::operator==): + (WebCore::computeHash): + (WebCore::FontCache::getCachedFontPlatformData): + * platform/graphics/FontDescription.h: + (WebCore::FontDescription::FontDescription): + (WebCore::FontDescription::operator==): + * platform/graphics/FontOrientation.h: Removed. + * platform/graphics/SimpleFontData.h: + * platform/graphics/cairo/FontCustomPlatformData.cpp: + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/cairo/FontCustomPlatformData.h: + * platform/graphics/cocoa/FontPlatformData.h: + (WebCore::FontPlatformData::FontPlatformData): + (WebCore::FontPlatformData::hash): + (WebCore::FontPlatformData::operator==): + * platform/graphics/cocoa/FontPlatformDataCocoa.mm: + (WebCore::FontPlatformData::FontPlatformData): + (WebCore::FontPlatformData::operator=): + (WebCore::FontPlatformData::allowsLigatures): + (WebCore::FontPlatformData::description): + * platform/graphics/gtk/FontCustomPlatformDataPango.cpp: + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/haiku/FontCustomPlatformData.cpp: + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/haiku/FontCustomPlatformData.h: + * platform/graphics/mac/FontCacheMac.mm: + (WebCore::FontCache::getFontDataForCharacters): + (WebCore::FontCache::createFontPlatformData): + * platform/graphics/mac/FontCustomPlatformData.cpp: + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/mac/FontCustomPlatformData.h: + * platform/graphics/mac/GlyphPageTreeNodeMac.cpp: + (WebCore::GlyphPage::fill): + * platform/graphics/mac/SimpleFontDataCoreText.cpp: + (WebCore::SimpleFontData::getCFStringAttributes): + * platform/graphics/mac/SimpleFontDataMac.mm: + (WebCore::SimpleFontData::platformBoundsForGlyph): + (WebCore::SimpleFontData::platformWidthForGlyph): + * platform/graphics/qt/FontCustomPlatformData.h: + * platform/graphics/qt/FontCustomPlatformDataQt.cpp: + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/skia/FontCustomPlatformData.cpp: + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/skia/FontCustomPlatformData.h: + * platform/graphics/win/FontCustomPlatformData.cpp: + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/win/FontCustomPlatformData.h: + * platform/graphics/win/FontCustomPlatformDataCairo.cpp: + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/win/FontCustomPlatformDataCairo.h: + * platform/graphics/wince/FontCustomPlatformData.cpp: + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/wince/FontCustomPlatformData.h: + * platform/graphics/wx/FontCustomPlatformData.cpp: + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/wx/FontCustomPlatformData.h: + +2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com> + + Reviewed by Martin Robinson. + + [GTK] Tests LayoutTests/fast/encoding/utf-32* fail when using glib unicode + https://bugs.webkit.org/show_bug.cgi?id=47805 + + Register UTF-32 encodings in TextCodecGtk. + + * platform/text/gtk/TextCodecGtk.cpp: + (WebCore::TextCodecGtk::registerBaseEncodingNames): + (WebCore::TextCodecGtk::registerBaseCodecs): + +2010-10-21 Luiz Agostini <luiz.agostini@openbossa.org> + + Reviewed by Darin Adler. + + Adding MediaQueryListListener binding test cases + https://bugs.webkit.org/show_bug.cgi?id=48028 + + MediaQueryListListener type will need special handling of the code generators. Adding the test cases. + + * bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp: Added. + (WebDOMTestMediaQueryListListener::WebDOMTestMediaQueryListListenerPrivate::WebDOMTestMediaQueryListListenerPrivate): + (WebDOMTestMediaQueryListListener::WebDOMTestMediaQueryListListener): + (WebDOMTestMediaQueryListListener::operator=): + (WebDOMTestMediaQueryListListener::impl): + (WebDOMTestMediaQueryListListener::~WebDOMTestMediaQueryListListener): + (WebDOMTestMediaQueryListListener::method): + (toWebCore): + (toWebKit): + * bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.h: Added. + * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp: Added. + (WebKit::kit): + (webkit_dom_test_media_query_list_listener_method): + (WebKit::core): + (webkit_dom_test_media_query_list_listener_finalize): + (webkit_dom_test_media_query_list_listener_set_property): + (webkit_dom_test_media_query_list_listener_get_property): + (webkit_dom_test_media_query_list_listener_constructed): + (webkit_dom_test_media_query_list_listener_class_init): + (webkit_dom_test_media_query_list_listener_init): + (WebKit::wrapTestMediaQueryListListener): + * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h: Added. + * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h: Added. + * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Added. + (WebCore::JSTestMediaQueryListListenerConstructor::classInfo): + (WebCore::JSTestMediaQueryListListenerConstructor::createStructure): + (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor): + (WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot): + (WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor): + (WebCore::JSTestMediaQueryListListenerPrototype::self): + (WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot): + (WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor): + (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener): + (WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener): + (WebCore::JSTestMediaQueryListListener::createPrototype): + (WebCore::JSTestMediaQueryListListener::getOwnPropertySlot): + (WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor): + (WebCore::jsTestMediaQueryListListenerConstructor): + (WebCore::JSTestMediaQueryListListener::getConstructor): + (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): + (WebCore::toJS): + (WebCore::toTestMediaQueryListListener): + * bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Added. + (WebCore::JSTestMediaQueryListListener::classInfo): + (WebCore::JSTestMediaQueryListListener::createStructure): + (WebCore::JSTestMediaQueryListListener::impl): + (WebCore::JSTestMediaQueryListListenerPrototype::classInfo): + (WebCore::JSTestMediaQueryListListenerPrototype::createStructure): + (WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype): + * bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.h: Added. + * bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.mm: Added. + (-[DOMTestMediaQueryListListener dealloc]): + (-[DOMTestMediaQueryListListener finalize]): + (-[DOMTestMediaQueryListListener method:]): + (core): + (kit): + * bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h: Added. + * bindings/scripts/test/TestMediaQueryListListener.idl: Added. + * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Added. + (WebCore::TestMediaQueryListListenerInternal::V8_USE): + (WebCore::TestMediaQueryListListenerInternal::methodCallback): + (WebCore::ConfigureV8TestMediaQueryListListenerTemplate): + (WebCore::V8TestMediaQueryListListener::GetRawTemplate): + (WebCore::V8TestMediaQueryListListener::GetTemplate): + (WebCore::V8TestMediaQueryListListener::HasInstance): + (WebCore::V8TestMediaQueryListListener::wrapSlow): + (WebCore::V8TestMediaQueryListListener::derefObject): + * bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Added. + (WebCore::V8TestMediaQueryListListener::toNative): + (WebCore::V8TestMediaQueryListListener::wrap): + (WebCore::toV8): + +2010-10-21 takano takumi <takano1@asia.apple.com> + + Reviewed by Dan Bernstein. + + Need to swap glyphs for vertical writing + https://bugs.webkit.org/show_bug.cgi?id=46973 + + Made changes to pass the writing-mode orientation flag in RenderStyle down to FontPlatformData, + and ultimately to CoreText APIs in both font complex path and fast path. + + Tests: fast/text/international/vertical-text-glyph-test.html + fast/text/international/vertical-text-metrics-test.html + + * WebCore.exp.in: + * WebCore.xcodeproj/project.pbxproj: Added platform/graphics/FontOrientation.h. + * css/CSSFontFaceSource.cpp: + (WebCore::CSSFontFaceSource::getFontData): Added font orientation parameter to SimpleFontData. + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::applyProperty): Set appropriate font orientation to the font description + when writing-mode is being specified. + * loader/CachedFont.cpp: + (WebCore::CachedFont::platformDataFromCustomData): Made to pass font orientation to FontPlatformData. + * loader/CachedFont.h: + * platform/graphics/FontCache.cpp: Added font orientation to FontPlatformDataCacheKey + (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): + (WebCore::FontPlatformDataCacheKey::operator==): + (WebCore::computeHash): + (WebCore::FontCache::getCachedFontPlatformData): + * platform/graphics/FontDescription.h: Added font orientation support to FontDescription class + (WebCore::FontDescription::FontDescription): + (WebCore::FontDescription::orientation): + (WebCore::FontDescription::setOrientation): + (WebCore::FontDescription::operator==): + * platform/graphics/FontOrientation.h: Added. + * platform/graphics/SimpleFontData.h: + * platform/graphics/cairo/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/cairo/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/cocoa/FontPlatformData.h: Added font orientation support to FontPlatformData class + (WebCore::FontPlatformData::FontPlatformData): + (WebCore::FontPlatformData::orientation): + (WebCore::FontPlatformData::hash): + (WebCore::FontPlatformData::operator==): + * platform/graphics/cocoa/FontPlatformDataCocoa.mm: Added font orientation support + (WebCore::FontPlatformData::FontPlatformData): + (WebCore::FontPlatformData::operator=): + (WebCore::FontPlatformData::allowsLigatures): Don't allow ligatures when the font is vertical orientation. + (WebCore::FontPlatformData::description): + * platform/graphics/gtk/FontCustomPlatformDataPango.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/haiku/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/haiku/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/mac/FontCacheMac.mm: Added font orientation parameter when creating FontPlatformData object. + (WebCore::FontCache::getFontDataForCharacters): + (WebCore::FontCache::createFontPlatformData): + * platform/graphics/mac/FontCustomPlatformData.cpp: Added font orientation parameter when creating FontPlatformData object. + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/mac/FontCustomPlatformData.h: Changed to pass font orientation parameter to fontPlatformData() + * platform/graphics/mac/GlyphPageTreeNodeMac.cpp: + (WebCore::GlyphPage::fill): Changed to use CoreText to extract glyphs when the current font is vertical orientation. + CoreText automatically swaps glyphs with vertical variants when the font orientation is vertical. + * platform/graphics/mac/SimpleFontDataCoreText.cpp: Added vertical form attribute to the attribute dictionary for a CTLine. + (WebCore::SimpleFontData::getCFStringAttributes): + * platform/graphics/mac/SimpleFontDataMac.mm: + (WebCore::SimpleFontData::platformBoundsForGlyph): Changed to use CoreText (from CG) to support vertical metrics. + (WebCore::SimpleFontData::platformWidthForGlyph): Made to use CoreText, instead of wkGetGlyphTransformedAdvances, + to get vertical metrics when the font orientation is vertical. + * platform/graphics/qt/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/qt/FontCustomPlatformDataQt.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/skia/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/skia/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/win/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/win/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/win/FontCustomPlatformDataCairo.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/win/FontCustomPlatformDataCairo.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/wince/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/wince/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + * platform/graphics/wx/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() + (WebCore::FontCustomPlatformData::fontPlatformData): + * platform/graphics/wx/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData() + +2010-10-20 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Dirk Schulze. + + Redesign SVGAnimatedProperty concept to share "POD type wrappers" between all bindings (-> add ObjC SVG bindings) + https://bugs.webkit.org/show_bug.cgi?id=47905 + + Tests: svg/dom/SVGLengthList-appendItem.xhtml + svg/dom/SVGLengthList-basics.xhtml + svg/dom/SVGLengthList-getItem.xhtml + svg/dom/SVGLengthList-initialize.xhtml + svg/dom/SVGLengthList-insertItemBefore.xhtml + svg/dom/SVGLengthList-removeItem.xhtml + svg/dom/SVGLengthList-replaceItem.xhtml + svg/dom/SVGLengthList-xml-dom-modifications.xhtml + + Introduce a more lightweight, less intrusive way to expose SVGAnimated* DOM bindings. + + Concrete example: + The SVG DOM defines a 'SVGAnimatedLength' object, that's used to represent the x / y / width / height attributes of a 'SVGRectElement'. + Each 'SVGAnimatedLength' object exposes a baseVal (markup defined attribute value) and an animVal (reflects the current state during animations), + both of type 'SVGLength'. These objects are all _live_. That means you can do: + var foobar = rect.x.baseVal; foobar.value += 150; + + If we'd implement the SVG DOM straightforward, we'd have to store a refcounted SVGAnimatedLength object, containing two refcounted SVGLength objects + in SVGRectElement, for each of the x/y/width/height attributes. Our solution, to reduce memory footprint and increase performance is to store + SVGLength stack-allocated, non refcounted types in SVGRectElement for x/y/width/height, and don't implement the SVGAnimatedLength object at all. + + In the past the JS bindings had to expose wrappers for SVGAnimatedLength on their own, and wrap each SVGLength object in an object called JSSVGPODTypeWrapper<SVGLength>. + When JS changed the 'value' of the 'SVGLength', we constructed a copy of the SVGLength object, modified it, and called rectElement->setXBaseValue(newLength). + This is not efficient at all, as we have to construct several copies of the SVGLength object, utilize callbacks to propagate the value changes in the SVG DOM. + Furthermore, all bindings had to expose a similar concept, otherwhise SVG DOM wouldn't work. Up until now, only JSC and V8 bindings were available, that worked properly. + + The new SVGAnimatedProperty concept removes the need for JSSVGPODTypeWrapper (and friends like JSSVGContextCache, that associated a SVGLength with its SVGRectElement). + Instead a solution is offered, that all bindings can use simultaneously, without adding new types or special concepts like JSSVGPODTypeWrapper. + + It works like this: + A new refcounted SVGAnimatedProperty<PropertyType> template class is available, that stores a QualifiedName to associate the SVG DOM property with a XML DOM attribute. + It also stores a RefPtr to the SVGElement that created it. + + In SVGRectElement we still store SVGLength m_x/m_y/m_width/m_height members, and offer a new "xAnimated()" method which looks up or creates a SVGAnimatedProperty<SVGLength> + object. The JS/V8/ObjC bindings call this method whenever someone requests "rect.x/y/width/height", and a new wrapper is created, and stored in a HashMap. + + The SVGAnimatedProperty<PropertyType> is a base class for SVGAnimatedPropertyTearOff and SVGAnimatedListPropertyTearOff, the latter is used for all types of lists (SVGLengthList). + SVGAnimatedProperty contains two methods used in the bindings: SVGProperty* baseVal and SVGProperty* animVal. SVGProperty is a base class for SVGPropertyTearOff and + SVGListPropertyTearOff. Upon invocation of the baseVal/animVal methods a new SVG(List)PropertyTearOff object is created and stored in a RefPtr. + The SVGPropertyTearOff objects stores a _reference_ to the type it wraps. Concrete example: + When calling rect.x, a SVGAnimatedPropertyTearOff<SVGLength> is created, that stores a pointer to the SVGRectElement, and a SVGNames::xAttr. + When calling rect.x.baseVal, a SVGPropertyTearOf<SVGLength> is created, that stores a reference to the "m_x" member variable of the SVGRectElement. + Any changes applied to the SVGLength object, through the wrapper, are immediately live, as no copies are involved anymore, nor the need to fire any callback methods. + This is the key concept of the new tear offs, no copies, no callbacks, no virtual methods (except one, needed for lists, but it's a detail). + + The SVGAnimatedListPropertyTearOff and SVGListPropertyTearOff work the same, but for SVG*List objects. The whole SVG*List API is _removed_ from the SVG DOM classes + like SVGLengthList. It now inherits from Vector<SVGLength>, where it used to store a Vector<RefPtr<SVGListItem<SVGLength> > >. The SVGList API (insertItemBefore, appendItem, etc.) + is exposed through SVGListPropertyTearOff, and there's no need anymore for SVGLengthList to deal with it at all. + SVGLengthList is live just like most other SVG DOM object. Concrete example: + var item0 = text.x.baseVal.getItem(0); item0.value += 150; + + Previously we chose to store a refcounted SVGListItem object, which wrapped the SVGLength object, to achieve liveness. We could change a single list item from DOM + w/o copying the whole list. The drawback is that a simple type likeSVGLengthList, was heavy to store, as it contained a list of RefPtrs around a wrapper object + around the real object 'SVGLength'. This complexity is completly gone. + + The SVGListPropertyTearOff<SVGLengthList> stores a reference to the SVGLengthList object (eg. SVGTextElement::m_x) and maintains a list of SVGPropertyTearOff<SVGLength> + wrappers, that are created when necessary (getItem(2), will create a wrapper around the third list item), and cached. These SVGPropertyTearOff<SVGLength> objects + store references to the SVGLength object _in the SVGLengthList_. One has to be extra carefully, to keep those lists synchronized. + The SVGLengthList API is fully implemented for the first time, including moving items between lists, and is extensively tested with 8 new testcases. + + This patch only changed SVGLength/SVGLengthList to the new concept. All other types remain using the old DeprecatedSVGAnimatedProperty* concept. + This will change in follow-up patches. + + * GNUmakefile.am: Add new files from svg/properties to build. + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * bindings/js/JSSVGLengthCustom.cpp: Adapt to context cache removal for SVGLength. + (WebCore::JSSVGLength::value): + (WebCore::JSSVGLength::convertToSpecifiedUnits): + * bindings/scripts/CodeGenerator.pm: Add new isSVGNewStyleAnimatedProperty() helper method, return true for "SVGAnimatedLength" and "SVGAnimatedLengthList". + * bindings/scripts/CodeGeneratorJS.pm: Generate new style SVG JS bindings, that don't need JSSVGContextCache / JSSVGPODTypeWrapper. + * bindings/scripts/CodeGeneratorObjC.pm: Ditto. (+ Finally expose a working set of SVG DOM API for Objective C). + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + * bindings/v8/custom/V8SVGLengthCustom.cpp: Adapt to context cache removal for SVGLength. + (WebCore::V8SVGLength::valueAccessorGetter): + (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback): + * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: + (WebCore::extractFloatValuesFromSVGLengthList): SVGLengthList is a POD type now, passed as const reference. + * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove handling for SVGLength/SVGLengthList, those are converted to the new SVGAnimatedProperty design now. + * svg/DeprecatedSVGAnimatedTemplate.h: Ditto. + * svg/SVGAnimatedLength.h: Added. + * svg/SVGAnimatedLength.idl: Mark as [SVGAnimatedProperty]. + * svg/SVGAnimatedLengthList.h: Added. + * svg/SVGAnimatedLengthList.idl: Mark as [SVGAnimatedProperty]. + * svg/SVGCircleElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ until the transition to the new concept is finished. + * svg/SVGCursorElement.h: Ditto. + * svg/SVGEllipseElement.h: Ditto. + * svg/SVGFilterElement.h: Ditto. + * svg/SVGFilterPrimitiveStandardAttributes.h: Ditto. + * svg/SVGForeignObjectElement.h: Ditto. + * svg/SVGImageElement.h: Ditto. + * svg/SVGLength.idl: Mark as [SVGProperty]. + * svg/SVGLengthList.cpp: Use Vector API (appendItem -> append). No need to ever use the SVGList API internally. SVGLengthList is a Vector<SVGLength> now. + (WebCore::SVGLengthList::parse): + (WebCore::SVGLengthList::valueAsString): + * svg/SVGLengthList.h: Inherit from Vector<SVGLength> - not from the SVGList base class. It's a simple, non-refcounted POD type now. + (WebCore::SVGLengthList::SVGLengthList): + * svg/SVGLengthList.idl: Mark as [SVGListProperty]. + * svg/SVGLineElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ until the transition to the new concept is finished. + * svg/SVGLinearGradientElement.h: Ditto. + * svg/SVGMarkerElement.h: Ditto. + * svg/SVGMaskElement.h: Ditto. + * svg/SVGPatternElement.h: Ditto. + * svg/SVGRadialGradientElement.h: Ditto. + * svg/SVGRectElement.h: Ditto. + * svg/SVGSVGElement.h: Ditto. + * svg/SVGSVGElement.idl: Mark createSVGLength() as [SVGLiveProperty] - a wrapper for the returned object has to be created. + * svg/SVGTextContentElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ until the transition to the new concept is finished. + * svg/SVGTextPathElement.h: Ditto. + * svg/SVGTextPositioningElement.cpp: + (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): + (WebCore::SVGTextPositioningElement::parseMappedAttribute): Detach wrappers pointing to the old x/y/dx/dy list, if the underlying list changes via XML DOM. + (WebCore::listContainsRelativeValue): Adapt to SVGLengthList interface changes, it's a POD type now. + * svg/SVGTextPositioningElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_LIST_PROPERTY_NEW/ until the transition to the new concept is finished. + * svg/SVGUseElement.h: + * svg/properties/SVGAnimatedListPropertyTearOff.h: Added. + * svg/properties/SVGAnimatedProperty.h: Added. This is the base class for SVGAnimatedPropertyTearOff and SVGAnimatedListPropertyTearOff. + * svg/properties/SVGAnimatedPropertyDescription.h: Added. Refactored from DeprecatedSVGAnimatedProperty.h. + * svg/properties/SVGAnimatedPropertyMacros.h: Added. These macros will be _removed_ as soon as the transition to the new concept is finished. + * svg/properties/SVGAnimatedPropertyTearOff.h: Added. + * svg/properties/SVGListPropertyTearOff.h: Added. + * svg/properties/SVGProperty.h: Added. This is the base class for SVGPropertyTearOff and SVGListPropertyTearOff. + * svg/properties/SVGPropertyTearOff.h: Added. + * svg/properties/SVGPropertyTraits.h: Added. + +2010-10-21 Alex Milowski <alex@milowski.com> + + Reviewed by Kenneth Rohde Christiansen. + + Changed the layout algorithm for rows to avoid unnecessary recursion + into child rows. This solves the long rendering time experienced in + https://bugs.webkit.org/show_bug.cgi?id=43462 as well as reports in + various other bugs. The change in the algorithm required some + tweaks to other rendering objects to make sure that the baseline + alignment still works. + + In addition, an attempt was made to go through the various + rendering objects for MathML and reduce unnecessary calls that + mark the tree in need of layout. + + * mathml/RenderMathMLFenced.cpp: + * mathml/RenderMathMLFenced.h: + * mathml/RenderMathMLFraction.cpp: + (WebCore::RenderMathMLFraction::layout): + * mathml/RenderMathMLOperator.cpp: + (WebCore::RenderMathMLOperator::stretchToHeight): + * mathml/RenderMathMLRoot.cpp: + (WebCore::RenderMathMLRoot::layout): + * mathml/RenderMathMLRow.cpp: + (WebCore::RenderMathMLRow::layout): + * mathml/RenderMathMLRow.h: + (WebCore::RenderMathMLRow::stretchToHeight): + * mathml/RenderMathMLSubSup.cpp: + (WebCore::RenderMathMLSubSup::addChild): + (WebCore::RenderMathMLSubSup::stretchToHeight): + (WebCore::RenderMathMLSubSup::nonOperatorHeight): + (WebCore::RenderMathMLSubSup::layout): + (WebCore::RenderMathMLSubSup::baselinePosition): + * mathml/RenderMathMLUnderOver.cpp: + (WebCore::RenderMathMLUnderOver::stretchToHeight): + (WebCore::RenderMathMLUnderOver::layout): + (WebCore::RenderMathMLUnderOver::nonOperatorHeight): + * mathml/mathtags.in: + +2010-10-21 Evan Martin <evan@chromium.org> + + Reviewed by Tony Chang. + + sqlite: show extended error codes in error logs + https://bugs.webkit.org/show_bug.cgi?id=47859 + + SQLite can provide "extended" error codes, where extra information + about the error is potentially encoded in the high bits of the error + code. It's only off by default in case older apps rely on equality + testing on the older error codes, which WebKit doesn't do. + + * platform/sql/SQLiteDatabase.cpp: + (WebCore::SQLiteDatabase::open): + * platform/sql/SQLiteStatement.cpp: + (WebCore::SQLiteStatement::step): + +2010-10-21 Yuta Kitamura <yutak@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: Handle WebSocket events via InspectorInstrumentation + https://bugs.webkit.org/show_bug.cgi?id=47968 + + * inspector/InspectorInstrumentation.cpp: + (WebCore::InspectorInstrumentation::didCreateWebSocketImpl): + (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): + (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): + (WebCore::InspectorInstrumentation::didCloseWebSocketImpl): + * inspector/InspectorInstrumentation.h: + (WebCore::InspectorInstrumentation::didCreateWebSocket): + (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): + (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): + (WebCore::InspectorInstrumentation::didCloseWebSocket): + * websockets/WebSocketChannel.cpp: + (WebCore::WebSocketChannel::WebSocketChannel): + Now we do not depend on InspectorController to generate a resource identifier. + (WebCore::WebSocketChannel::disconnect): + Check if m_identifier is valid in case we could not obtain an identifier. + (WebCore::WebSocketChannel::didOpen): + (WebCore::WebSocketChannel::didClose): + (WebCore::WebSocketChannel::processBuffer): + * websockets/WebSocketChannel.h: + +2010-10-20 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: Convert sidebar into the browsing tree in the Storage panel. + https://bugs.webkit.org/show_bug.cgi?id=47988 + + * English.lproj/localizedStrings.js: + * inspector/front-end/ApplicationCacheItemsView.js: + (WebInspector.ApplicationCacheItemsView): + * inspector/front-end/ConsoleView.js: + (WebInspector.ConsoleMessage.prototype._formatMessage): + * inspector/front-end/CookieItemsView.js: + (WebInspector.CookieItemsView): + * inspector/front-end/DatabaseTableView.js: + (WebInspector.DatabaseTableView.prototype._queryFinished): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel): + (WebInspector.StoragePanel.prototype.reset): + (WebInspector.StoragePanel.prototype.addDatabase): + (WebInspector.StoragePanel.prototype.addCookieDomain): + (WebInspector.StoragePanel.prototype.addDOMStorage): + (WebInspector.StoragePanel.prototype.addApplicationCache): + (WebInspector.StoragePanel.prototype.showDatabase): + (WebInspector.StoragePanel.prototype.showDOMStorage): + (WebInspector.StoragePanel.prototype.showCookies): + (WebInspector.StoragePanel.prototype.showApplicationCache): + (WebInspector.StoragePanel.prototype.showCategoryView): + (WebInspector.StoragePanel.prototype._innerShowView): + (WebInspector.BaseStorageTreeElement): + (WebInspector.BaseStorageTreeElement.prototype.onattach): + (WebInspector.StorageCategoryTreeElement): + (WebInspector.StorageCategoryTreeElement.prototype.onselect): + (WebInspector.DatabaseTreeElement): + (WebInspector.DatabaseTreeElement.prototype.onselect): + (WebInspector.DatabaseTreeElement.prototype.onpopulate.tableNamesCallback): + (WebInspector.DatabaseTreeElement.prototype.onpopulate): + (WebInspector.DatabaseTableTreeElement): + (WebInspector.DatabaseTableTreeElement.prototype.onselect): + (WebInspector.DOMStorageTreeElement): + (WebInspector.DOMStorageTreeElement.prototype.onselect): + (WebInspector.CookieTreeElement): + (WebInspector.CookieTreeElement.prototype.onselect): + (WebInspector.ApplicationCacheTreeElement): + (WebInspector.ApplicationCacheTreeElement.prototype.onselect): + (WebInspector.StorageCategoryView): + (WebInspector.StorageCategoryView.prototype.setText): + * inspector/front-end/inspector.css: + (.properties-tree ol): + (.properties-tree ol.expanded): + (.database-storage-tree-item .icon): + (.database-table-storage-tree-item .icon): + (.domstorage-storage-tree-item.local-storage .icon): + (.domstorage-storage-tree-item.session-storage .icon): + (.cookie-storage-tree-item .icon): + (.application-cache-storage-tree-item .icon): + (.storage.panel .sidebar): + (.storage.panel .outline-disclosure > ol): + (.storage.panel .outline-disclosure li): + (.storage.panel .outline-disclosure li .selection): + (.storage.panel .sidebar-resizer-vertical): + (.storage-base-tree-element-title): + (.storage.panel .outline-disclosure ol): + (.storage.panel .outline-disclosure li.selected): + (.storage.panel .outline-disclosure .icon): + (.storage-empty-view, .storage-view.table .storage-table-error): + +2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com> + + Reviewed by Martin Robinson. + + [GTK] Replace encodings multi-dimensional array with calls to registrar method + https://bugs.webkit.org/show_bug.cgi?id=47990 + + * platform/text/gtk/TextCodecGtk.cpp: + (WebCore::isEncodingAvailable): + (WebCore::registerEncodingNameIfAvailable): + (WebCore::registerEncodingAliasIfAvailable): + (WebCore::registerCodecIfAvailable): + (WebCore::TextCodecGtk::registerBaseEncodingNames): + (WebCore::TextCodecGtk::registerBaseCodecs): + (WebCore::TextCodecGtk::registerExtendedEncodingNames): + (WebCore::TextCodecGtk::registerExtendedCodecs): + (WebCore::TextCodecGtk::createIConvDecoder): + (WebCore::TextCodecGtk::createIConvEncoder): + * platform/text/gtk/TextCodecGtk.h: + 2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r70040. @@ -318,7 +7303,7 @@ (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach): -2010-10-19 Leandro Gracia Gil <leandrogracia@google.com> +2010-10-20 Leandro Gracia Gil <leandrogracia@google.com> Reviewed by Jeremy Orlow. |