1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
3099
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
3143
3144
3145
3146
3147
3148
3149
3150
3151
3152
3153
3154
3155
3156
3157
3158
3159
3160
3161
3162
3163
3164
3165
3166
3167
3168
3169
3170
3171
3172
3173
3174
3175
3176
3177
3178
3179
3180
3181
3182
3183
3184
3185
3186
3187
3188
3189
3190
3191
3192
3193
3194
3195
3196
3197
3198
3199
3200
3201
3202
3203
3204
3205
3206
3207
3208
3209
3210
3211
3212
3213
3214
3215
3216
3217
3218
3219
3220
3221
3222
3223
3224
3225
3226
3227
3228
3229
3230
3231
3232
3233
3234
3235
3236
3237
3238
3239
3240
3241
3242
3243
3244
3245
3246
3247
3248
3249
3250
3251
3252
3253
3254
3255
3256
3257
3258
3259
3260
3261
3262
3263
3264
3265
3266
3267
3268
3269
3270
3271
3272
3273
3274
3275
3276
3277
3278
3279
3280
3281
3282
3283
3284
3285
3286
3287
3288
3289
3290
3291
3292
3293
3294
3295
3296
3297
3298
3299
3300
3301
3302
3303
3304
3305
3306
3307
3308
3309
3310
3311
3312
3313
3314
3315
3316
3317
3318
3319
3320
3321
3322
3323
3324
3325
3326
3327
3328
3329
3330
3331
3332
3333
3334
3335
3336
3337
3338
3339
3340
3341
3342
3343
3344
3345
3346
3347
3348
3349
3350
3351
3352
3353
3354
3355
3356
3357
3358
3359
3360
3361
3362
3363
3364
3365
3366
3367
3368
3369
3370
3371
3372
3373
3374
3375
3376
3377
3378
3379
3380
3381
3382
3383
3384
3385
3386
3387
3388
3389
3390
3391
3392
3393
3394
3395
3396
3397
3398
3399
3400
3401
3402
3403
3404
3405
3406
3407
3408
3409
3410
3411
3412
3413
3414
3415
3416
3417
3418
3419
3420
3421
3422
3423
3424
3425
3426
3427
3428
3429
3430
3431
3432
3433
3434
3435
3436
3437
3438
3439
3440
3441
3442
3443
3444
3445
3446
3447
3448
3449
3450
3451
3452
3453
3454
3455
3456
3457
3458
3459
3460
3461
3462
3463
3464
3465
3466
3467
3468
3469
3470
3471
3472
3473
3474
3475
3476
3477
3478
3479
3480
3481
3482
3483
3484
3485
3486
3487
3488
3489
3490
3491
3492
3493
3494
3495
3496
3497
3498
3499
3500
3501
3502
3503
3504
3505
3506
3507
3508
3509
3510
3511
3512
3513
3514
3515
3516
3517
3518
3519
3520
3521
3522
3523
3524
3525
3526
3527
3528
3529
3530
3531
3532
3533
3534
3535
3536
3537
3538
3539
3540
3541
3542
3543
3544
3545
3546
3547
3548
3549
3550
3551
3552
3553
3554
3555
3556
3557
3558
3559
3560
3561
3562
3563
3564
3565
3566
3567
3568
3569
3570
3571
3572
3573
3574
3575
3576
3577
3578
3579
3580
3581
3582
3583
3584
3585
3586
3587
3588
3589
3590
3591
3592
3593
3594
3595
3596
3597
3598
3599
3600
3601
3602
3603
3604
3605
3606
3607
3608
3609
3610
3611
3612
3613
3614
3615
3616
3617
3618
3619
3620
3621
3622
3623
3624
3625
3626
3627
3628
3629
3630
3631
3632
3633
3634
3635
3636
3637
3638
3639
3640
3641
3642
3643
3644
3645
3646
3647
3648
3649
3650
3651
3652
3653
3654
3655
3656
3657
3658
3659
3660
3661
3662
3663
3664
3665
3666
3667
3668
3669
3670
3671
3672
3673
3674
3675
3676
3677
3678
3679
3680
3681
3682
3683
3684
3685
3686
3687
3688
3689
3690
3691
3692
3693
3694
3695
3696
3697
3698
3699
3700
3701
3702
3703
3704
3705
3706
3707
3708
3709
3710
3711
3712
3713
3714
3715
3716
3717
3718
3719
3720
3721
3722
3723
3724
3725
3726
3727
3728
3729
3730
3731
3732
3733
3734
3735
3736
3737
3738
3739
3740
3741
3742
3743
3744
3745
3746
3747
3748
3749
3750
3751
3752
3753
3754
3755
3756
3757
3758
3759
3760
3761
3762
3763
3764
3765
3766
3767
3768
3769
3770
3771
3772
3773
3774
3775
3776
3777
3778
3779
3780
3781
3782
3783
3784
3785
3786
3787
3788
3789
3790
3791
3792
3793
3794
3795
3796
3797
3798
3799
3800
3801
3802
3803
3804
3805
3806
3807
3808
3809
3810
3811
3812
3813
3814
3815
3816
3817
3818
3819
3820
3821
3822
3823
3824
3825
3826
3827
3828
3829
3830
3831
3832
3833
3834
3835
3836
3837
3838
3839
3840
3841
3842
3843
3844
3845
3846
3847
3848
3849
3850
3851
3852
3853
3854
3855
3856
3857
3858
3859
3860
3861
3862
3863
3864
3865
3866
3867
3868
3869
3870
3871
3872
3873
3874
3875
3876
3877
3878
3879
3880
3881
3882
3883
3884
3885
3886
3887
3888
3889
3890
3891
3892
3893
3894
3895
3896
3897
3898
3899
3900
3901
3902
3903
3904
3905
3906
3907
3908
3909
3910
3911
3912
3913
3914
3915
3916
3917
3918
3919
3920
3921
3922
3923
3924
3925
3926
3927
3928
3929
3930
3931
3932
3933
3934
3935
3936
3937
3938
3939
3940
3941
3942
3943
3944
3945
3946
3947
3948
3949
3950
3951
3952
3953
3954
3955
3956
3957
3958
3959
3960
3961
3962
3963
3964
3965
3966
3967
3968
3969
3970
3971
3972
3973
3974
3975
3976
3977
3978
3979
3980
3981
3982
3983
3984
3985
3986
3987
3988
3989
3990
3991
3992
3993
3994
3995
3996
3997
3998
3999
4000
4001
4002
4003
4004
4005
4006
4007
4008
4009
4010
4011
4012
4013
4014
4015
4016
4017
4018
4019
4020
4021
4022
4023
4024
4025
4026
4027
4028
4029
4030
4031
4032
4033
4034
4035
4036
4037
4038
4039
4040
4041
4042
4043
4044
4045
4046
4047
4048
4049
4050
4051
4052
4053
4054
4055
4056
4057
4058
4059
4060
4061
4062
4063
4064
4065
4066
4067
4068
4069
4070
4071
4072
4073
4074
4075
4076
4077
4078
4079
4080
4081
4082
4083
4084
4085
4086
4087
4088
4089
4090
4091
4092
4093
4094
4095
4096
4097
4098
4099
4100
4101
4102
4103
4104
4105
4106
4107
4108
4109
4110
4111
4112
4113
4114
4115
4116
4117
4118
4119
4120
4121
4122
4123
4124
4125
4126
4127
4128
4129
4130
4131
4132
4133
4134
4135
4136
4137
4138
4139
4140
4141
4142
4143
4144
4145
4146
4147
4148
4149
4150
4151
4152
4153
4154
4155
4156
4157
4158
4159
4160
4161
4162
4163
4164
4165
4166
4167
4168
4169
4170
4171
4172
4173
4174
4175
4176
4177
4178
4179
4180
4181
4182
4183
4184
4185
4186
4187
4188
4189
4190
4191
4192
4193
4194
4195
4196
4197
4198
4199
4200
4201
4202
4203
4204
4205
4206
4207
4208
4209
4210
4211
4212
4213
4214
4215
4216
4217
4218
4219
4220
4221
4222
4223
4224
4225
4226
4227
4228
4229
4230
4231
4232
4233
4234
4235
4236
4237
4238
4239
4240
4241
4242
4243
4244
4245
4246
4247
4248
4249
4250
4251
4252
4253
4254
4255
4256
4257
4258
4259
4260
4261
4262
4263
4264
4265
4266
4267
4268
4269
4270
4271
4272
4273
4274
4275
4276
4277
4278
4279
4280
4281
4282
4283
4284
4285
4286
4287
4288
4289
4290
4291
4292
4293
4294
4295
4296
4297
4298
4299
4300
4301
4302
4303
4304
4305
4306
4307
4308
4309
4310
4311
4312
4313
4314
4315
4316
4317
4318
4319
4320
4321
4322
4323
4324
4325
4326
4327
4328
4329
4330
4331
4332
4333
4334
4335
4336
4337
4338
4339
4340
4341
4342
4343
4344
4345
4346
4347
4348
4349
4350
4351
4352
4353
4354
4355
4356
4357
4358
4359
4360
4361
4362
4363
4364
4365
4366
4367
4368
4369
4370
4371
4372
4373
4374
4375
4376
4377
4378
4379
4380
4381
4382
4383
4384
4385
4386
4387
4388
4389
4390
4391
4392
4393
4394
4395
4396
4397
4398
4399
4400
4401
4402
4403
4404
4405
4406
4407
4408
4409
4410
4411
4412
4413
4414
4415
4416
4417
4418
4419
4420
4421
4422
4423
4424
4425
4426
4427
4428
4429
4430
4431
4432
4433
4434
4435
4436
4437
4438
4439
4440
4441
4442
4443
4444
4445
4446
4447
4448
4449
4450
4451
4452
4453
4454
4455
4456
4457
4458
4459
4460
4461
4462
4463
4464
4465
4466
4467
4468
4469
4470
4471
4472
4473
4474
4475
4476
4477
4478
4479
4480
4481
4482
4483
4484
4485
4486
4487
4488
4489
4490
4491
4492
4493
4494
4495
4496
4497
4498
4499
4500
4501
4502
4503
4504
4505
4506
4507
4508
4509
4510
4511
4512
4513
4514
4515
4516
4517
4518
4519
4520
4521
4522
4523
4524
4525
4526
4527
4528
4529
4530
4531
4532
4533
4534
4535
4536
4537
4538
4539
4540
4541
4542
4543
4544
4545
4546
4547
4548
4549
4550
4551
4552
4553
4554
4555
4556
4557
4558
4559
4560
4561
4562
4563
4564
4565
4566
4567
4568
4569
4570
4571
4572
4573
4574
4575
4576
4577
4578
4579
4580
4581
4582
4583
4584
4585
4586
4587
4588
4589
4590
4591
4592
4593
4594
4595
4596
4597
4598
4599
4600
4601
4602
4603
4604
4605
4606
4607
4608
4609
4610
4611
4612
4613
4614
4615
4616
4617
4618
4619
4620
4621
4622
4623
4624
4625
4626
4627
4628
4629
4630
4631
4632
4633
4634
4635
4636
4637
4638
4639
4640
4641
4642
4643
4644
4645
4646
4647
4648
4649
4650
4651
4652
4653
4654
4655
4656
4657
4658
4659
4660
4661
4662
4663
4664
4665
4666
4667
4668
4669
4670
4671
4672
4673
4674
4675
4676
4677
4678
4679
4680
4681
4682
4683
4684
4685
4686
4687
4688
4689
4690
4691
4692
4693
4694
4695
4696
4697
4698
4699
4700
4701
4702
4703
4704
4705
4706
4707
4708
4709
4710
4711
4712
4713
4714
4715
4716
4717
4718
4719
4720
4721
4722
4723
4724
4725
4726
4727
4728
4729
4730
4731
4732
4733
4734
4735
4736
4737
4738
4739
4740
4741
4742
4743
4744
4745
4746
4747
4748
4749
4750
4751
4752
4753
4754
4755
4756
4757
4758
4759
4760
4761
4762
4763
4764
4765
4766
4767
4768
4769
4770
4771
4772
4773
4774
4775
4776
4777
4778
4779
4780
4781
4782
4783
4784
4785
4786
4787
4788
4789
4790
4791
4792
4793
4794
4795
4796
4797
4798
4799
4800
4801
4802
4803
4804
4805
4806
4807
4808
4809
4810
4811
4812
4813
4814
4815
4816
4817
4818
4819
4820
4821
4822
4823
4824
4825
4826
4827
4828
4829
4830
4831
4832
4833
4834
4835
4836
4837
4838
4839
4840
4841
4842
4843
4844
4845
4846
4847
4848
4849
4850
4851
4852
4853
4854
4855
4856
4857
4858
4859
4860
4861
4862
4863
4864
4865
4866
4867
4868
4869
4870
4871
4872
4873
4874
4875
4876
4877
4878
4879
4880
4881
4882
4883
4884
4885
4886
4887
4888
4889
4890
4891
4892
4893
4894
4895
4896
4897
4898
4899
4900
4901
4902
4903
4904
4905
4906
4907
4908
4909
4910
4911
4912
4913
4914
4915
4916
4917
4918
4919
4920
4921
4922
4923
4924
4925
4926
4927
4928
4929
4930
4931
4932
4933
4934
4935
4936
4937
4938
4939
4940
4941
4942
4943
4944
4945
4946
4947
4948
4949
4950
4951
4952
4953
4954
4955
4956
4957
4958
4959
4960
4961
4962
4963
4964
4965
4966
4967
4968
4969
4970
4971
4972
4973
4974
4975
4976
4977
4978
4979
4980
4981
4982
4983
4984
4985
4986
4987
4988
4989
4990
4991
4992
4993
4994
4995
4996
4997
4998
4999
5000
5001
5002
5003
5004
5005
5006
5007
5008
5009
5010
5011
5012
5013
5014
5015
5016
5017
5018
5019
5020
5021
5022
5023
5024
5025
5026
5027
5028
5029
5030
5031
5032
5033
5034
5035
5036
5037
5038
5039
5040
5041
5042
5043
5044
5045
5046
5047
5048
5049
5050
5051
5052
5053
5054
5055
5056
5057
5058
5059
5060
5061
5062
5063
5064
5065
5066
5067
5068
5069
5070
5071
5072
5073
5074
5075
5076
5077
5078
5079
5080
5081
5082
5083
5084
5085
5086
5087
5088
5089
5090
5091
5092
5093
5094
5095
5096
5097
5098
5099
5100
5101
5102
5103
5104
5105
5106
5107
5108
5109
5110
5111
5112
5113
5114
5115
5116
5117
5118
5119
5120
5121
5122
5123
5124
5125
5126
5127
5128
5129
5130
5131
5132
5133
5134
5135
5136
5137
5138
5139
5140
5141
5142
5143
5144
5145
5146
5147
5148
5149
5150
5151
5152
5153
5154
5155
5156
5157
5158
5159
5160
5161
5162
5163
5164
5165
5166
5167
5168
5169
5170
5171
5172
5173
5174
5175
5176
5177
5178
5179
5180
5181
5182
5183
5184
5185
5186
5187
5188
5189
5190
5191
5192
5193
5194
5195
5196
5197
5198
5199
5200
5201
5202
5203
5204
5205
5206
5207
5208
5209
5210
5211
5212
5213
5214
5215
5216
5217
5218
5219
5220
5221
5222
5223
5224
5225
5226
5227
5228
5229
5230
5231
5232
5233
5234
5235
5236
5237
5238
5239
5240
5241
5242
5243
5244
5245
5246
5247
5248
5249
5250
5251
5252
5253
5254
5255
5256
5257
5258
5259
5260
5261
5262
5263
5264
5265
5266
5267
5268
5269
5270
5271
5272
5273
5274
5275
5276
5277
5278
5279
5280
5281
5282
5283
5284
5285
5286
5287
5288
5289
5290
5291
5292
5293
5294
5295
5296
5297
5298
5299
5300
5301
5302
5303
5304
5305
5306
5307
5308
5309
5310
5311
5312
5313
5314
5315
5316
5317
5318
5319
5320
5321
5322
5323
5324
5325
5326
5327
5328
5329
5330
5331
5332
5333
5334
5335
5336
5337
5338
5339
5340
5341
5342
5343
5344
5345
5346
5347
5348
5349
5350
5351
5352
5353
5354
5355
5356
5357
5358
5359
5360
5361
5362
5363
5364
5365
5366
5367
5368
5369
5370
5371
5372
5373
5374
5375
5376
5377
5378
5379
5380
5381
5382
5383
5384
5385
5386
5387
5388
5389
5390
5391
5392
5393
5394
5395
5396
5397
5398
5399
5400
5401
5402
5403
5404
5405
5406
5407
5408
5409
5410
5411
5412
5413
5414
5415
5416
5417
5418
5419
5420
5421
5422
5423
5424
5425
5426
5427
5428
5429
5430
5431
5432
5433
5434
5435
5436
5437
5438
5439
5440
5441
5442
5443
5444
5445
5446
5447
5448
5449
5450
5451
5452
5453
5454
5455
5456
5457
5458
5459
5460
5461
5462
5463
5464
5465
5466
5467
5468
5469
5470
5471
5472
5473
5474
5475
5476
5477
5478
5479
5480
5481
5482
5483
5484
5485
5486
5487
5488
5489
5490
5491
5492
5493
5494
5495
5496
5497
5498
5499
5500
5501
5502
5503
5504
5505
5506
5507
5508
5509
5510
5511
5512
5513
5514
5515
5516
5517
5518
5519
5520
5521
5522
5523
5524
5525
5526
5527
5528
5529
5530
5531
5532
5533
5534
5535
5536
5537
5538
5539
5540
5541
5542
5543
5544
5545
5546
5547
5548
5549
5550
5551
5552
5553
5554
5555
5556
5557
5558
5559
5560
5561
5562
5563
5564
5565
5566
5567
5568
5569
5570
5571
5572
5573
5574
5575
5576
5577
5578
5579
5580
5581
5582
5583
5584
5585
5586
5587
5588
5589
5590
5591
5592
5593
5594
5595
5596
5597
5598
5599
5600
5601
5602
5603
5604
5605
5606
5607
5608
5609
5610
5611
5612
5613
5614
5615
5616
5617
5618
5619
5620
5621
5622
5623
5624
5625
5626
5627
5628
5629
5630
5631
5632
5633
5634
5635
5636
5637
5638
5639
5640
5641
5642
5643
5644
5645
5646
5647
5648
5649
5650
5651
5652
5653
5654
5655
5656
5657
5658
5659
5660
5661
5662
5663
5664
5665
5666
5667
5668
5669
5670
5671
5672
5673
5674
5675
5676
5677
5678
5679
5680
5681
5682
5683
5684
5685
5686
5687
5688
5689
5690
5691
5692
5693
5694
5695
5696
5697
5698
5699
5700
5701
5702
5703
5704
5705
5706
5707
5708
5709
5710
5711
5712
5713
5714
5715
5716
5717
5718
5719
5720
5721
5722
5723
5724
5725
5726
5727
5728
5729
5730
5731
5732
5733
5734
5735
5736
5737
5738
5739
5740
5741
5742
5743
5744
5745
5746
5747
5748
5749
5750
5751
5752
5753
5754
5755
5756
5757
5758
5759
5760
5761
5762
5763
5764
5765
5766
5767
5768
5769
5770
5771
5772
5773
5774
5775
5776
5777
5778
5779
5780
5781
5782
5783
5784
5785
5786
5787
5788
5789
5790
5791
5792
5793
5794
5795
5796
5797
5798
5799
5800
5801
5802
5803
5804
5805
5806
5807
5808
5809
5810
5811
5812
5813
5814
5815
5816
5817
5818
5819
5820
5821
5822
5823
5824
5825
5826
5827
5828
5829
5830
5831
5832
5833
5834
5835
5836
5837
5838
5839
5840
5841
5842
5843
5844
5845
5846
5847
5848
5849
5850
5851
5852
5853
5854
5855
5856
5857
5858
5859
5860
5861
5862
5863
5864
5865
5866
5867
5868
5869
5870
5871
5872
5873
5874
5875
5876
5877
5878
5879
5880
5881
5882
5883
5884
5885
5886
5887
5888
5889
5890
5891
5892
5893
5894
5895
5896
5897
5898
5899
5900
5901
5902
5903
5904
5905
5906
5907
5908
5909
5910
5911
5912
5913
5914
5915
5916
5917
5918
5919
5920
5921
5922
5923
5924
5925
5926
5927
5928
5929
5930
5931
5932
5933
5934
5935
5936
5937
5938
5939
5940
5941
5942
5943
5944
5945
5946
5947
5948
5949
5950
5951
5952
5953
5954
5955
5956
5957
5958
5959
5960
5961
5962
5963
5964
5965
5966
5967
5968
5969
5970
5971
5972
5973
5974
5975
5976
5977
5978
5979
5980
5981
5982
5983
5984
5985
5986
5987
5988
5989
5990
5991
5992
5993
5994
5995
5996
5997
5998
5999
6000
6001
6002
6003
6004
6005
6006
6007
6008
6009
6010
6011
6012
6013
6014
6015
6016
6017
6018
6019
6020
6021
6022
6023
6024
6025
6026
6027
6028
6029
6030
6031
6032
6033
6034
6035
6036
6037
6038
6039
6040
6041
6042
6043
6044
6045
6046
6047
6048
6049
6050
6051
6052
6053
6054
6055
6056
6057
6058
6059
6060
6061
6062
6063
6064
6065
6066
6067
6068
6069
6070
6071
6072
6073
6074
6075
6076
6077
6078
6079
6080
6081
6082
6083
6084
6085
6086
6087
6088
6089
6090
6091
6092
6093
6094
6095
6096
6097
6098
6099
6100
6101
6102
6103
6104
6105
6106
6107
6108
6109
6110
6111
6112
6113
6114
6115
6116
6117
6118
6119
6120
6121
6122
6123
6124
6125
6126
6127
6128
6129
6130
6131
6132
6133
6134
6135
6136
6137
6138
6139
6140
6141
6142
6143
6144
6145
6146
6147
6148
6149
6150
6151
6152
6153
6154
6155
6156
6157
6158
6159
6160
6161
6162
6163
6164
6165
6166
6167
6168
6169
6170
6171
6172
6173
6174
6175
6176
6177
6178
6179
6180
6181
6182
6183
6184
6185
6186
6187
6188
6189
6190
6191
6192
6193
6194
6195
6196
6197
6198
6199
6200
6201
6202
6203
6204
6205
6206
6207
6208
6209
6210
6211
6212
6213
6214
6215
6216
6217
6218
6219
6220
6221
6222
6223
6224
6225
6226
6227
6228
6229
6230
6231
6232
6233
6234
6235
6236
6237
6238
6239
6240
6241
6242
6243
6244
6245
6246
6247
6248
6249
6250
6251
6252
6253
6254
6255
6256
6257
6258
6259
6260
6261
6262
6263
6264
6265
6266
6267
6268
6269
6270
6271
6272
6273
6274
6275
6276
6277
6278
6279
6280
6281
6282
6283
6284
6285
6286
6287
6288
6289
6290
6291
6292
6293
6294
6295
6296
6297
6298
6299
6300
6301
6302
6303
6304
6305
6306
6307
6308
6309
6310
6311
6312
6313
6314
6315
6316
6317
6318
6319
6320
6321
6322
6323
6324
6325
6326
6327
6328
6329
6330
6331
6332
6333
6334
6335
6336
6337
6338
6339
6340
6341
6342
6343
6344
6345
6346
6347
6348
6349
6350
6351
6352
6353
6354
6355
6356
6357
6358
6359
6360
6361
6362
6363
6364
6365
6366
6367
6368
6369
6370
6371
6372
6373
6374
6375
6376
6377
6378
6379
6380
6381
6382
6383
6384
6385
6386
6387
6388
6389
6390
6391
6392
6393
6394
6395
6396
6397
6398
6399
6400
6401
6402
6403
6404
6405
6406
6407
6408
6409
6410
6411
6412
6413
6414
6415
6416
6417
6418
6419
6420
6421
6422
6423
6424
6425
6426
6427
6428
6429
6430
6431
6432
6433
6434
6435
6436
6437
6438
6439
6440
6441
6442
6443
6444
6445
6446
6447
6448
6449
6450
6451
6452
6453
6454
6455
6456
6457
6458
6459
6460
6461
6462
6463
6464
6465
6466
6467
6468
6469
6470
6471
6472
6473
6474
6475
6476
6477
6478
6479
6480
6481
6482
6483
6484
6485
6486
6487
6488
6489
6490
6491
6492
6493
6494
6495
6496
6497
6498
6499
6500
6501
6502
6503
6504
6505
6506
6507
6508
6509
6510
6511
6512
6513
6514
6515
6516
6517
6518
6519
6520
6521
6522
6523
6524
6525
6526
6527
6528
6529
6530
6531
6532
6533
6534
6535
6536
6537
6538
6539
6540
6541
6542
6543
6544
6545
6546
6547
6548
6549
6550
6551
6552
6553
6554
6555
6556
6557
6558
6559
6560
6561
6562
6563
6564
6565
6566
6567
6568
6569
6570
6571
6572
6573
6574
6575
6576
6577
6578
6579
6580
6581
6582
6583
6584
6585
6586
6587
6588
6589
6590
6591
6592
6593
6594
6595
6596
6597
6598
6599
6600
6601
6602
6603
6604
6605
6606
6607
6608
6609
6610
6611
6612
6613
6614
6615
6616
6617
6618
6619
6620
6621
6622
6623
6624
6625
6626
6627
6628
6629
6630
6631
6632
6633
6634
6635
6636
6637
6638
6639
6640
6641
6642
6643
6644
6645
6646
6647
6648
6649
6650
6651
6652
6653
6654
6655
6656
6657
6658
6659
6660
6661
6662
6663
6664
6665
6666
6667
6668
6669
6670
6671
6672
6673
6674
6675
6676
6677
6678
6679
6680
6681
6682
6683
6684
6685
6686
6687
6688
6689
6690
6691
6692
6693
6694
6695
6696
6697
6698
6699
6700
6701
6702
6703
6704
6705
6706
6707
6708
6709
6710
6711
6712
6713
6714
6715
6716
6717
6718
6719
6720
6721
6722
6723
6724
6725
6726
6727
6728
6729
6730
6731
6732
6733
6734
6735
6736
6737
6738
6739
6740
6741
6742
6743
6744
6745
6746
6747
6748
6749
6750
6751
6752
6753
6754
6755
6756
6757
6758
6759
6760
6761
6762
6763
6764
6765
6766
6767
6768
6769
6770
6771
6772
6773
6774
6775
6776
6777
6778
6779
6780
6781
6782
6783
6784
6785
6786
6787
6788
6789
6790
6791
6792
6793
6794
6795
6796
6797
6798
6799
6800
6801
6802
6803
6804
6805
6806
6807
6808
6809
6810
6811
6812
6813
6814
6815
6816
6817
6818
6819
6820
6821
6822
6823
6824
6825
6826
6827
6828
6829
6830
6831
6832
6833
6834
6835
6836
6837
6838
6839
6840
6841
6842
6843
6844
6845
6846
6847
6848
6849
6850
6851
6852
6853
6854
6855
6856
6857
6858
6859
6860
6861
6862
6863
6864
6865
6866
6867
6868
6869
6870
6871
6872
6873
6874
6875
6876
6877
6878
6879
6880
6881
6882
6883
6884
6885
6886
6887
6888
6889
6890
6891
6892
6893
6894
6895
6896
6897
6898
6899
6900
6901
6902
6903
6904
6905
6906
6907
6908
6909
6910
6911
6912
6913
6914
6915
6916
6917
6918
6919
6920
6921
6922
6923
6924
6925
6926
6927
6928
6929
6930
6931
6932
6933
6934
6935
6936
6937
6938
6939
6940
6941
6942
6943
6944
6945
6946
6947
6948
6949
6950
6951
6952
6953
6954
6955
6956
6957
6958
6959
6960
6961
6962
6963
6964
6965
6966
6967
6968
6969
6970
6971
6972
6973
6974
6975
6976
6977
6978
6979
6980
6981
6982
6983
6984
6985
6986
6987
6988
6989
6990
6991
6992
6993
6994
6995
6996
6997
6998
6999
7000
7001
7002
7003
7004
7005
7006
7007
7008
7009
7010
7011
7012
7013
7014
7015
7016
7017
7018
7019
7020
7021
7022
7023
7024
7025
7026
7027
7028
7029
7030
7031
7032
7033
7034
7035
7036
7037
7038
7039
7040
7041
7042
7043
7044
7045
7046
7047
7048
7049
7050
7051
7052
7053
7054
7055
7056
7057
7058
7059
7060
7061
7062
7063
7064
7065
7066
7067
7068
7069
7070
7071
7072
7073
7074
7075
7076
7077
7078
7079
7080
7081
7082
7083
7084
7085
7086
7087
7088
7089
7090
7091
7092
7093
7094
7095
7096
7097
7098
7099
7100
7101
7102
7103
7104
7105
7106
7107
7108
7109
7110
7111
7112
7113
7114
7115
7116
7117
7118
7119
7120
7121
7122
7123
7124
7125
7126
7127
7128
7129
7130
7131
7132
7133
7134
7135
7136
7137
7138
7139
7140
7141
7142
7143
7144
7145
7146
7147
7148
7149
7150
7151
7152
7153
7154
7155
7156
7157
7158
7159
7160
7161
7162
7163
7164
7165
7166
7167
7168
7169
7170
7171
7172
7173
7174
7175
7176
7177
7178
7179
7180
7181
7182
7183
7184
7185
7186
7187
7188
7189
7190
7191
7192
7193
7194
7195
7196
7197
7198
7199
7200
7201
7202
7203
7204
7205
7206
7207
7208
7209
7210
7211
7212
7213
7214
7215
7216
7217
7218
7219
7220
7221
7222
7223
7224
7225
7226
7227
7228
7229
7230
7231
7232
7233
7234
7235
7236
7237
7238
7239
7240
7241
7242
7243
7244
7245
7246
7247
7248
7249
7250
7251
7252
7253
7254
7255
7256
7257
7258
7259
7260
7261
7262
7263
7264
7265
7266
7267
7268
7269
7270
7271
7272
7273
7274
7275
7276
7277
7278
7279
7280
7281
7282
7283
7284
7285
7286
7287
7288
7289
7290
7291
7292
7293
7294
7295
7296
7297
7298
7299
7300
7301
7302
7303
7304
7305
7306
7307
7308
7309
7310
7311
7312
7313
7314
7315
7316
7317
7318
7319
7320
7321
7322
7323
7324
7325
7326
7327
7328
7329
7330
7331
7332
7333
7334
7335
7336
7337
7338
7339
7340
7341
7342
7343
7344
7345
7346
7347
7348
7349
7350
7351
7352
7353
7354
7355
7356
7357
7358
7359
7360
7361
7362
7363
7364
7365
7366
7367
7368
7369
7370
7371
7372
7373
7374
7375
7376
7377
7378
7379
7380
7381
7382
7383
7384
7385
7386
7387
7388
7389
7390
7391
7392
7393
7394
7395
7396
7397
7398
7399
7400
7401
7402
7403
7404
7405
7406
7407
7408
7409
7410
7411
7412
7413
7414
7415
7416
7417
7418
7419
7420
7421
7422
7423
7424
7425
7426
7427
7428
7429
7430
7431
7432
7433
7434
7435
7436
7437
7438
7439
7440
7441
7442
7443
7444
7445
7446
7447
7448
7449
7450
7451
7452
7453
7454
7455
7456
7457
7458
7459
7460
7461
7462
7463
7464
7465
7466
7467
7468
7469
7470
7471
7472
7473
7474
7475
7476
7477
7478
7479
7480
7481
7482
7483
7484
7485
7486
7487
7488
7489
7490
7491
7492
7493
7494
7495
7496
7497
7498
7499
7500
7501
7502
7503
7504
7505
7506
7507
7508
7509
7510
7511
7512
7513
7514
7515
7516
7517
7518
7519
7520
7521
7522
7523
7524
7525
7526
7527
7528
7529
7530
7531
7532
7533
7534
7535
7536
7537
7538
7539
7540
7541
7542
7543
7544
7545
7546
7547
7548
7549
7550
7551
7552
7553
7554
7555
7556
7557
7558
7559
7560
7561
7562
7563
7564
7565
7566
7567
7568
7569
7570
7571
7572
7573
7574
7575
7576
7577
7578
7579
7580
7581
7582
7583
7584
7585
7586
7587
7588
7589
7590
7591
7592
7593
7594
7595
7596
7597
7598
7599
7600
7601
7602
7603
7604
7605
7606
7607
7608
7609
7610
7611
7612
7613
7614
7615
7616
7617
7618
7619
7620
7621
7622
7623
7624
7625
7626
7627
7628
7629
7630
7631
7632
7633
7634
7635
7636
7637
7638
7639
7640
7641
7642
7643
7644
7645
7646
7647
7648
7649
7650
7651
7652
7653
7654
7655
7656
7657
7658
7659
7660
7661
7662
7663
7664
7665
7666
7667
7668
7669
7670
7671
7672
7673
7674
7675
7676
7677
7678
7679
7680
7681
7682
7683
7684
7685
7686
7687
7688
7689
7690
7691
7692
7693
7694
7695
7696
7697
7698
7699
7700
7701
7702
7703
7704
7705
7706
7707
7708
7709
7710
7711
7712
7713
7714
7715
7716
7717
7718
7719
7720
7721
7722
7723
7724
7725
7726
7727
7728
7729
7730
7731
7732
7733
7734
7735
7736
7737
7738
7739
7740
7741
7742
7743
7744
7745
7746
7747
7748
7749
7750
7751
7752
7753
7754
7755
7756
7757
7758
7759
7760
7761
7762
7763
7764
7765
7766
7767
7768
7769
7770
7771
7772
7773
7774
7775
7776
7777
7778
7779
7780
7781
7782
7783
7784
7785
7786
7787
7788
7789
7790
7791
7792
7793
7794
7795
7796
7797
7798
7799
7800
7801
7802
7803
7804
7805
7806
7807
7808
7809
7810
7811
7812
7813
7814
7815
7816
7817
7818
7819
7820
7821
7822
7823
7824
7825
7826
7827
7828
7829
7830
7831
7832
7833
7834
7835
7836
7837
7838
7839
7840
7841
7842
7843
7844
7845
7846
7847
7848
7849
7850
7851
7852
7853
7854
7855
7856
7857
7858
7859
7860
7861
7862
7863
7864
7865
7866
7867
7868
7869
7870
7871
7872
7873
7874
7875
7876
7877
7878
7879
7880
7881
7882
7883
7884
7885
7886
7887
7888
7889
7890
7891
7892
7893
7894
7895
7896
7897
7898
7899
7900
7901
7902
7903
7904
7905
7906
7907
7908
7909
7910
7911
7912
7913
7914
7915
7916
7917
7918
7919
7920
7921
7922
7923
7924
7925
7926
7927
7928
7929
7930
7931
7932
7933
7934
7935
7936
7937
7938
7939
7940
7941
7942
7943
7944
7945
7946
7947
7948
7949
7950
7951
7952
7953
7954
7955
7956
7957
7958
7959
7960
7961
7962
7963
7964
7965
7966
7967
7968
7969
7970
7971
7972
7973
7974
7975
7976
7977
7978
7979
7980
7981
7982
7983
7984
7985
7986
7987
7988
7989
7990
7991
7992
7993
7994
7995
7996
7997
7998
7999
8000
8001
8002
8003
8004
8005
8006
8007
8008
8009
8010
8011
8012
8013
8014
8015
8016
8017
8018
8019
8020
8021
8022
8023
8024
8025
8026
8027
8028
8029
8030
8031
8032
8033
8034
8035
8036
8037
8038
8039
8040
8041
8042
8043
8044
8045
8046
8047
8048
8049
8050
8051
8052
8053
8054
8055
8056
8057
8058
8059
8060
8061
8062
8063
8064
8065
8066
8067
8068
8069
8070
8071
8072
8073
8074
8075
8076
8077
8078
8079
8080
8081
8082
8083
8084
8085
8086
8087
8088
8089
8090
8091
8092
8093
8094
8095
8096
8097
8098
8099
8100
8101
8102
8103
8104
8105
8106
8107
8108
8109
8110
8111
8112
8113
8114
8115
8116
8117
8118
8119
8120
8121
8122
8123
8124
8125
8126
8127
8128
8129
8130
8131
8132
8133
8134
8135
8136
8137
8138
8139
8140
8141
8142
8143
8144
8145
8146
8147
8148
8149
8150
8151
8152
8153
8154
8155
8156
8157
8158
8159
8160
8161
8162
8163
8164
8165
8166
8167
8168
8169
8170
8171
8172
8173
8174
8175
8176
8177
8178
8179
8180
8181
8182
8183
8184
8185
8186
8187
8188
8189
8190
8191
8192
8193
8194
8195
8196
8197
8198
8199
8200
8201
8202
8203
8204
8205
8206
8207
8208
8209
8210
8211
8212
8213
8214
8215
8216
8217
8218
8219
8220
8221
8222
8223
8224
8225
8226
8227
8228
8229
8230
8231
8232
8233
8234
8235
8236
8237
8238
8239
8240
8241
8242
8243
8244
8245
8246
8247
8248
8249
8250
8251
8252
8253
8254
8255
8256
8257
8258
8259
8260
8261
8262
8263
8264
8265
8266
8267
8268
8269
8270
8271
8272
8273
8274
8275
8276
8277
8278
8279
8280
8281
8282
8283
8284
8285
8286
8287
8288
8289
8290
8291
8292
8293
8294
8295
8296
8297
8298
8299
8300
8301
8302
8303
8304
8305
8306
8307
8308
8309
8310
8311
8312
8313
8314
8315
8316
8317
8318
8319
8320
8321
8322
8323
8324
8325
8326
8327
8328
8329
8330
8331
8332
8333
8334
8335
8336
8337
8338
8339
8340
8341
8342
8343
8344
8345
8346
8347
8348
8349
8350
8351
8352
8353
8354
8355
8356
8357
8358
8359
8360
8361
8362
8363
8364
8365
8366
8367
8368
8369
8370
8371
8372
8373
8374
8375
8376
8377
8378
8379
8380
8381
8382
8383
8384
8385
8386
8387
8388
8389
8390
8391
8392
8393
8394
8395
8396
8397
8398
8399
8400
8401
8402
8403
8404
8405
8406
8407
8408
8409
8410
8411
8412
8413
8414
8415
8416
8417
8418
8419
8420
8421
8422
8423
8424
8425
8426
8427
8428
8429
8430
8431
8432
8433
8434
8435
8436
8437
8438
8439
8440
8441
8442
8443
8444
8445
8446
8447
8448
8449
8450
8451
8452
8453
8454
8455
8456
8457
8458
8459
8460
8461
8462
8463
8464
8465
8466
8467
8468
8469
8470
8471
8472
8473
8474
8475
8476
8477
8478
8479
8480
8481
8482
8483
8484
8485
8486
8487
8488
8489
8490
8491
8492
8493
8494
8495
8496
8497
8498
8499
8500
8501
8502
8503
8504
8505
8506
8507
8508
8509
8510
8511
8512
8513
8514
8515
8516
8517
8518
8519
8520
8521
8522
8523
8524
8525
8526
8527
8528
8529
8530
8531
8532
8533
8534
8535
8536
8537
8538
8539
8540
8541
8542
8543
8544
8545
8546
8547
8548
8549
8550
8551
8552
8553
8554
8555
8556
8557
8558
8559
8560
8561
8562
8563
8564
8565
8566
8567
8568
8569
8570
8571
8572
8573
8574
8575
8576
8577
8578
8579
8580
8581
8582
8583
8584
8585
8586
8587
8588
8589
8590
8591
8592
8593
8594
8595
8596
8597
8598
8599
8600
8601
8602
8603
8604
8605
8606
8607
8608
8609
8610
8611
8612
8613
8614
8615
8616
8617
8618
8619
8620
8621
8622
8623
8624
8625
8626
8627
8628
8629
8630
8631
8632
8633
8634
8635
8636
8637
8638
8639
8640
8641
8642
8643
8644
8645
8646
8647
8648
8649
8650
8651
8652
8653
8654
8655
8656
8657
8658
8659
8660
8661
8662
8663
8664
8665
8666
8667
8668
8669
8670
8671
8672
8673
8674
8675
8676
8677
8678
8679
8680
8681
8682
8683
8684
8685
8686
8687
8688
8689
8690
8691
8692
8693
8694
8695
8696
8697
8698
8699
8700
8701
8702
8703
8704
8705
8706
8707
8708
8709
8710
8711
8712
8713
8714
8715
8716
8717
8718
8719
8720
8721
8722
8723
8724
8725
8726
8727
8728
8729
8730
8731
8732
8733
8734
8735
8736
8737
8738
8739
8740
8741
8742
8743
8744
8745
8746
8747
8748
8749
8750
8751
8752
8753
8754
8755
8756
8757
8758
8759
8760
8761
8762
8763
8764
8765
8766
8767
8768
8769
8770
8771
8772
8773
8774
8775
8776
8777
8778
8779
8780
8781
8782
8783
8784
8785
8786
8787
8788
8789
8790
8791
8792
8793
8794
8795
8796
8797
8798
8799
8800
8801
8802
8803
8804
8805
8806
8807
8808
8809
8810
8811
8812
8813
8814
8815
8816
8817
8818
8819
8820
8821
8822
8823
8824
8825
8826
8827
8828
8829
8830
8831
8832
8833
8834
8835
8836
8837
8838
8839
8840
8841
8842
8843
8844
8845
8846
8847
8848
8849
8850
8851
8852
8853
8854
8855
8856
8857
8858
8859
8860
8861
8862
8863
8864
8865
8866
8867
8868
8869
8870
8871
8872
8873
8874
8875
8876
8877
8878
8879
8880
8881
8882
8883
8884
8885
8886
8887
8888
8889
8890
8891
8892
8893
8894
8895
8896
8897
8898
8899
8900
8901
8902
8903
8904
8905
8906
8907
8908
8909
8910
8911
8912
8913
8914
8915
8916
8917
8918
8919
8920
8921
8922
8923
8924
8925
8926
8927
8928
8929
8930
8931
8932
8933
8934
8935
8936
8937
8938
8939
8940
8941
8942
8943
8944
8945
8946
8947
8948
8949
8950
8951
8952
8953
8954
8955
8956
8957
8958
8959
8960
8961
8962
8963
8964
8965
8966
8967
8968
8969
8970
8971
8972
8973
8974
8975
8976
8977
8978
8979
8980
8981
8982
8983
8984
8985
8986
8987
8988
8989
8990
8991
8992
8993
8994
8995
8996
8997
8998
8999
9000
9001
9002
9003
9004
9005
9006
9007
9008
9009
9010
9011
9012
9013
9014
9015
9016
9017
9018
9019
9020
9021
9022
9023
9024
9025
9026
9027
9028
9029
9030
9031
9032
9033
9034
9035
9036
9037
9038
9039
9040
9041
9042
9043
9044
9045
9046
9047
9048
9049
9050
9051
9052
9053
9054
9055
9056
9057
9058
9059
9060
9061
9062
9063
9064
9065
9066
9067
9068
9069
9070
9071
9072
9073
9074
9075
9076
9077
9078
9079
9080
9081
9082
9083
9084
9085
9086
9087
9088
9089
9090
9091
9092
9093
9094
9095
9096
9097
9098
9099
9100
9101
9102
9103
9104
9105
9106
9107
9108
9109
9110
9111
9112
9113
9114
9115
9116
9117
9118
9119
9120
9121
9122
9123
9124
9125
9126
9127
9128
9129
9130
9131
9132
9133
9134
9135
9136
9137
9138
9139
9140
9141
9142
9143
9144
9145
9146
9147
9148
9149
9150
9151
9152
9153
9154
9155
9156
9157
9158
9159
9160
9161
9162
9163
9164
9165
9166
9167
9168
9169
9170
9171
9172
9173
9174
9175
9176
9177
9178
9179
9180
9181
9182
9183
9184
9185
9186
9187
9188
9189
9190
9191
9192
9193
9194
9195
9196
9197
9198
9199
9200
9201
9202
9203
9204
9205
9206
9207
9208
9209
9210
9211
9212
9213
9214
9215
9216
9217
9218
9219
9220
9221
9222
9223
9224
9225
9226
9227
9228
9229
9230
9231
9232
9233
9234
9235
9236
9237
9238
9239
9240
9241
9242
9243
9244
9245
9246
9247
9248
9249
9250
9251
9252
9253
9254
9255
9256
9257
9258
9259
9260
9261
9262
9263
9264
9265
9266
9267
9268
9269
9270
9271
9272
9273
9274
9275
9276
9277
9278
9279
9280
9281
9282
9283
9284
9285
9286
9287
9288
9289
9290
9291
9292
9293
9294
9295
9296
9297
9298
9299
9300
9301
9302
9303
9304
9305
9306
9307
9308
9309
9310
9311
9312
9313
9314
9315
9316
9317
9318
9319
9320
9321
9322
9323
9324
9325
9326
9327
9328
9329
9330
9331
9332
9333
9334
9335
9336
9337
9338
9339
9340
9341
9342
9343
9344
9345
9346
9347
9348
9349
9350
9351
9352
9353
9354
9355
9356
9357
9358
9359
9360
9361
9362
9363
9364
9365
9366
9367
9368
9369
9370
9371
9372
9373
9374
9375
9376
9377
9378
9379
9380
9381
9382
9383
9384
9385
9386
9387
9388
9389
9390
9391
9392
9393
9394
9395
9396
9397
9398
9399
9400
9401
9402
9403
9404
9405
9406
9407
9408
9409
9410
9411
9412
9413
9414
9415
9416
9417
9418
9419
9420
9421
9422
9423
9424
9425
9426
9427
9428
9429
9430
9431
9432
9433
9434
9435
9436
9437
9438
9439
9440
9441
9442
9443
9444
9445
9446
9447
9448
9449
9450
9451
9452
9453
9454
9455
9456
9457
9458
9459
9460
9461
9462
9463
9464
9465
9466
9467
9468
9469
9470
9471
9472
9473
9474
9475
9476
9477
9478
9479
9480
9481
9482
9483
9484
9485
9486
9487
9488
9489
9490
9491
9492
9493
9494
9495
9496
9497
9498
9499
9500
9501
9502
9503
9504
9505
9506
9507
9508
9509
9510
9511
9512
9513
9514
9515
9516
9517
9518
9519
9520
9521
9522
9523
9524
9525
9526
9527
9528
9529
9530
9531
9532
9533
9534
9535
9536
9537
9538
9539
9540
9541
9542
9543
9544
9545
9546
9547
9548
9549
9550
9551
9552
9553
9554
9555
9556
9557
9558
9559
9560
9561
9562
9563
9564
9565
9566
9567
9568
9569
9570
9571
9572
9573
9574
9575
9576
9577
9578
9579
9580
9581
9582
9583
9584
9585
9586
9587
9588
9589
9590
9591
9592
9593
9594
9595
9596
9597
9598
9599
9600
9601
9602
9603
9604
9605
9606
9607
9608
9609
9610
9611
9612
9613
9614
9615
9616
9617
9618
9619
9620
9621
9622
9623
9624
9625
9626
9627
9628
9629
9630
9631
9632
9633
9634
9635
9636
9637
9638
9639
9640
9641
9642
9643
9644
9645
9646
9647
9648
9649
9650
9651
9652
9653
9654
9655
9656
9657
9658
9659
9660
9661
9662
9663
9664
9665
9666
9667
9668
9669
9670
9671
9672
9673
9674
9675
9676
9677
9678
9679
9680
9681
9682
9683
9684
9685
9686
9687
9688
9689
9690
9691
9692
9693
9694
9695
9696
9697
9698
9699
9700
9701
9702
9703
9704
9705
9706
9707
9708
9709
9710
9711
9712
9713
9714
9715
9716
9717
9718
9719
9720
9721
9722
9723
9724
9725
9726
9727
9728
9729
9730
9731
9732
9733
9734
9735
9736
9737
9738
9739
9740
9741
9742
9743
9744
9745
9746
9747
9748
9749
9750
9751
9752
9753
9754
9755
9756
9757
9758
9759
9760
9761
9762
9763
9764
9765
9766
9767
9768
9769
9770
9771
9772
9773
9774
9775
9776
9777
9778
9779
9780
9781
9782
9783
9784
9785
9786
9787
9788
9789
9790
9791
9792
9793
9794
9795
9796
9797
9798
9799
9800
9801
9802
9803
9804
9805
9806
9807
9808
9809
9810
9811
9812
9813
9814
9815
9816
9817
9818
9819
9820
9821
9822
9823
9824
9825
9826
9827
9828
9829
9830
9831
9832
9833
9834
9835
9836
9837
9838
9839
9840
9841
9842
9843
9844
9845
9846
9847
9848
9849
9850
9851
9852
9853
9854
9855
9856
9857
9858
9859
9860
9861
9862
9863
9864
9865
9866
9867
9868
9869
9870
9871
9872
9873
9874
9875
9876
9877
9878
9879
9880
9881
9882
9883
9884
9885
9886
9887
9888
9889
9890
9891
9892
9893
9894
9895
9896
9897
9898
9899
9900
9901
9902
9903
9904
9905
9906
9907
9908
9909
9910
9911
9912
9913
9914
9915
9916
9917
9918
9919
9920
9921
9922
9923
9924
9925
9926
9927
9928
9929
9930
9931
9932
9933
9934
9935
9936
9937
9938
9939
9940
9941
9942
9943
9944
9945
9946
9947
9948
9949
9950
9951
9952
9953
9954
9955
9956
9957
9958
9959
9960
9961
9962
9963
9964
9965
9966
9967
9968
9969
9970
9971
9972
9973
9974
9975
9976
9977
9978
9979
9980
9981
9982
9983
9984
9985
9986
9987
9988
9989
9990
9991
9992
9993
9994
9995
9996
9997
9998
9999
10000
10001
10002
10003
10004
10005
10006
10007
10008
10009
10010
10011
10012
10013
10014
10015
10016
10017
10018
10019
10020
10021
10022
10023
10024
10025
10026
10027
10028
10029
10030
10031
10032
10033
10034
10035
10036
10037
10038
10039
10040
10041
10042
10043
10044
10045
10046
10047
10048
10049
10050
10051
10052
10053
10054
10055
10056
10057
10058
10059
10060
10061
10062
10063
10064
10065
10066
10067
10068
10069
10070
10071
10072
10073
10074
10075
10076
10077
10078
10079
10080
10081
10082
10083
10084
10085
10086
10087
10088
10089
10090
10091
10092
10093
10094
10095
10096
10097
10098
10099
10100
10101
10102
10103
10104
10105
10106
10107
10108
10109
10110
10111
10112
10113
10114
10115
10116
10117
10118
10119
10120
10121
10122
10123
10124
10125
10126
10127
10128
10129
10130
10131
10132
10133
10134
10135
10136
10137
10138
10139
10140
10141
10142
10143
10144
10145
10146
10147
10148
10149
10150
10151
10152
10153
10154
10155
10156
10157
10158
10159
10160
10161
10162
10163
10164
10165
10166
10167
10168
10169
10170
10171
10172
10173
10174
10175
10176
10177
10178
10179
10180
10181
10182
10183
10184
10185
10186
10187
10188
10189
10190
10191
10192
10193
10194
10195
10196
10197
10198
10199
10200
10201
10202
10203
10204
10205
10206
10207
10208
10209
10210
10211
10212
10213
10214
10215
10216
10217
10218
10219
10220
10221
10222
10223
10224
10225
10226
10227
10228
10229
10230
10231
10232
10233
10234
10235
10236
10237
10238
10239
10240
10241
10242
10243
10244
10245
10246
10247
10248
10249
10250
10251
10252
10253
10254
10255
10256
10257
10258
10259
10260
10261
10262
10263
10264
10265
10266
10267
10268
10269
10270
10271
10272
10273
10274
10275
10276
10277
10278
10279
10280
10281
10282
10283
10284
10285
10286
10287
10288
10289
10290
10291
10292
10293
10294
10295
10296
10297
10298
10299
10300
10301
10302
10303
10304
10305
10306
10307
10308
10309
10310
10311
10312
10313
10314
10315
10316
10317
10318
10319
10320
10321
10322
10323
10324
10325
10326
10327
10328
10329
10330
10331
10332
10333
10334
10335
10336
10337
10338
10339
10340
10341
10342
10343
10344
10345
10346
10347
10348
10349
10350
10351
10352
10353
10354
10355
10356
10357
10358
10359
10360
10361
10362
10363
10364
10365
10366
10367
10368
10369
10370
10371
10372
10373
10374
10375
10376
10377
10378
10379
10380
10381
10382
10383
10384
10385
10386
10387
10388
10389
10390
10391
10392
10393
10394
10395
10396
10397
10398
10399
10400
10401
10402
10403
10404
10405
10406
10407
10408
10409
10410
10411
10412
10413
10414
10415
10416
10417
10418
10419
10420
10421
10422
10423
10424
10425
10426
10427
10428
10429
10430
10431
10432
10433
10434
10435
10436
10437
10438
10439
10440
10441
10442
10443
10444
10445
10446
10447
10448
10449
10450
10451
10452
10453
10454
10455
10456
10457
10458
10459
10460
10461
10462
10463
10464
10465
10466
10467
10468
10469
10470
10471
10472
10473
10474
10475
10476
10477
10478
10479
10480
10481
10482
10483
10484
10485
10486
10487
10488
10489
10490
10491
10492
10493
10494
10495
10496
10497
10498
10499
10500
10501
10502
10503
10504
10505
10506
10507
10508
10509
10510
10511
10512
10513
10514
10515
10516
10517
10518
10519
10520
10521
10522
10523
10524
10525
10526
10527
10528
10529
10530
10531
10532
10533
10534
10535
10536
10537
10538
10539
10540
10541
10542
10543
10544
10545
10546
10547
10548
10549
10550
10551
10552
10553
10554
10555
10556
10557
10558
10559
10560
10561
10562
10563
10564
10565
10566
10567
10568
10569
10570
10571
10572
10573
10574
10575
10576
10577
10578
10579
10580
10581
10582
10583
10584
10585
10586
10587
10588
10589
10590
10591
10592
10593
10594
10595
10596
10597
10598
10599
10600
10601
10602
10603
10604
10605
10606
10607
10608
10609
10610
10611
10612
10613
10614
10615
10616
10617
10618
10619
10620
10621
10622
10623
10624
10625
10626
10627
10628
10629
10630
10631
10632
10633
10634
10635
10636
10637
10638
10639
10640
10641
10642
10643
10644
10645
10646
10647
10648
10649
10650
10651
10652
10653
10654
10655
10656
10657
10658
10659
10660
10661
10662
10663
10664
10665
10666
10667
10668
10669
10670
10671
10672
10673
10674
10675
10676
10677
10678
10679
10680
10681
10682
10683
10684
10685
10686
10687
10688
10689
10690
10691
10692
10693
10694
10695
10696
10697
10698
10699
10700
10701
10702
10703
10704
10705
10706
10707
10708
10709
10710
10711
10712
10713
10714
10715
10716
10717
10718
10719
10720
10721
10722
10723
10724
10725
10726
10727
10728
10729
10730
10731
10732
10733
10734
10735
10736
10737
10738
10739
10740
10741
10742
10743
10744
10745
10746
10747
10748
10749
10750
10751
10752
10753
10754
10755
10756
10757
10758
10759
10760
10761
10762
10763
10764
10765
10766
10767
10768
10769
10770
10771
10772
10773
10774
10775
10776
10777
10778
10779
10780
10781
10782
10783
10784
10785
10786
10787
10788
10789
10790
10791
10792
10793
10794
10795
10796
10797
10798
10799
10800
10801
10802
10803
10804
10805
10806
10807
10808
10809
10810
10811
10812
10813
10814
10815
10816
10817
10818
10819
10820
10821
10822
10823
10824
10825
10826
10827
10828
10829
10830
10831
10832
10833
10834
10835
10836
10837
10838
10839
10840
10841
10842
10843
10844
10845
10846
10847
10848
10849
10850
10851
10852
10853
10854
10855
10856
10857
10858
10859
10860
10861
10862
10863
10864
10865
10866
10867
10868
10869
10870
10871
10872
10873
10874
10875
10876
10877
10878
10879
10880
10881
10882
10883
10884
10885
10886
10887
10888
10889
10890
10891
10892
10893
10894
10895
10896
10897
10898
10899
10900
10901
10902
10903
10904
10905
10906
10907
10908
10909
10910
10911
10912
10913
10914
10915
10916
10917
10918
10919
10920
10921
10922
10923
10924
10925
10926
10927
10928
10929
10930
10931
10932
10933
10934
10935
10936
10937
10938
10939
10940
10941
10942
10943
10944
10945
10946
10947
10948
10949
10950
10951
10952
10953
10954
10955
10956
10957
10958
10959
10960
10961
10962
10963
10964
10965
10966
10967
10968
10969
10970
10971
10972
10973
10974
10975
10976
10977
10978
10979
10980
10981
10982
10983
10984
10985
10986
10987
10988
10989
10990
10991
10992
10993
10994
10995
10996
10997
10998
10999
11000
11001
11002
11003
11004
11005
11006
11007
11008
11009
11010
11011
11012
11013
11014
11015
11016
11017
11018
11019
11020
11021
11022
11023
11024
11025
11026
11027
11028
11029
11030
11031
11032
11033
11034
11035
11036
11037
11038
11039
11040
11041
11042
11043
11044
11045
11046
11047
11048
11049
11050
11051
11052
11053
11054
11055
11056
11057
11058
11059
11060
11061
11062
11063
11064
11065
11066
11067
11068
11069
11070
11071
11072
11073
11074
11075
11076
11077
11078
11079
11080
11081
11082
11083
11084
11085
11086
11087
11088
11089
11090
11091
11092
11093
11094
11095
11096
11097
11098
11099
11100
11101
11102
11103
11104
11105
11106
11107
11108
11109
11110
11111
11112
11113
11114
11115
11116
11117
11118
11119
11120
11121
11122
11123
11124
11125
11126
11127
11128
11129
11130
11131
11132
11133
11134
11135
11136
11137
11138
11139
11140
11141
11142
11143
11144
11145
11146
11147
11148
11149
11150
11151
11152
11153
11154
11155
11156
11157
11158
11159
11160
11161
11162
11163
11164
11165
11166
11167
11168
11169
11170
11171
11172
11173
11174
11175
11176
11177
11178
11179
11180
11181
11182
11183
11184
11185
11186
11187
11188
11189
11190
11191
11192
11193
11194
11195
11196
11197
11198
11199
11200
11201
11202
11203
11204
11205
11206
11207
11208
11209
11210
11211
11212
11213
11214
11215
11216
11217
11218
11219
11220
11221
11222
11223
11224
11225
11226
11227
11228
11229
11230
11231
11232
11233
11234
11235
11236
11237
11238
11239
11240
11241
11242
11243
11244
11245
11246
11247
11248
11249
11250
11251
11252
11253
11254
11255
11256
11257
11258
11259
11260
11261
11262
11263
11264
11265
11266
11267
11268
11269
11270
11271
11272
11273
11274
11275
11276
11277
11278
11279
11280
11281
11282
11283
11284
11285
11286
11287
11288
11289
11290
11291
11292
11293
11294
11295
11296
11297
11298
11299
11300
11301
11302
11303
11304
11305
11306
11307
11308
11309
11310
11311
11312
11313
11314
11315
11316
11317
11318
11319
11320
11321
11322
11323
11324
11325
11326
11327
11328
11329
11330
11331
11332
11333
11334
11335
11336
11337
11338
11339
11340
11341
11342
11343
11344
11345
11346
11347
11348
11349
11350
11351
11352
11353
11354
11355
11356
11357
11358
11359
11360
11361
11362
11363
11364
11365
11366
11367
11368
11369
11370
11371
11372
11373
11374
11375
11376
11377
11378
11379
11380
11381
11382
11383
11384
11385
11386
11387
11388
11389
11390
11391
11392
11393
11394
11395
11396
11397
11398
11399
11400
11401
11402
11403
11404
11405
11406
11407
11408
11409
11410
11411
11412
11413
11414
11415
11416
11417
11418
11419
11420
11421
11422
11423
11424
11425
11426
11427
11428
11429
11430
11431
11432
11433
11434
11435
11436
11437
11438
11439
11440
11441
11442
11443
11444
11445
11446
11447
11448
11449
11450
11451
11452
11453
11454
11455
11456
11457
11458
11459
11460
11461
11462
11463
11464
11465
11466
11467
11468
11469
11470
11471
11472
11473
11474
11475
11476
11477
11478
11479
11480
11481
11482
11483
11484
11485
11486
11487
11488
11489
11490
11491
11492
11493
11494
11495
11496
11497
11498
11499
11500
11501
11502
11503
11504
11505
11506
11507
11508
11509
11510
11511
11512
11513
11514
11515
11516
11517
11518
11519
11520
11521
11522
11523
11524
11525
11526
11527
11528
11529
11530
11531
11532
11533
11534
11535
11536
11537
11538
11539
11540
11541
11542
11543
11544
11545
11546
11547
11548
11549
11550
11551
11552
11553
11554
11555
11556
11557
11558
11559
11560
11561
11562
11563
11564
11565
11566
11567
11568
11569
11570
11571
11572
11573
11574
11575
11576
11577
11578
11579
11580
11581
11582
11583
11584
11585
11586
11587
11588
11589
11590
11591
11592
11593
11594
11595
11596
11597
11598
11599
11600
11601
11602
11603
11604
11605
11606
11607
11608
11609
11610
11611
11612
11613
11614
11615
11616
11617
11618
11619
11620
11621
11622
11623
11624
11625
11626
11627
11628
11629
11630
11631
11632
11633
11634
11635
11636
11637
11638
11639
11640
11641
11642
11643
11644
11645
11646
11647
11648
11649
11650
11651
11652
11653
11654
11655
11656
11657
11658
11659
11660
11661
11662
11663
11664
11665
11666
11667
11668
11669
11670
11671
11672
11673
11674
11675
11676
11677
11678
11679
11680
11681
11682
11683
11684
11685
11686
11687
11688
11689
11690
11691
11692
11693
11694
11695
11696
11697
11698
11699
11700
11701
11702
11703
11704
11705
11706
11707
11708
11709
11710
11711
11712
11713
11714
11715
11716
11717
11718
11719
11720
11721
11722
11723
11724
11725
11726
11727
11728
11729
11730
11731
11732
11733
11734
11735
11736
11737
11738
11739
11740
11741
11742
11743
11744
11745
11746
11747
11748
11749
11750
11751
11752
11753
11754
11755
11756
11757
11758
11759
11760
11761
11762
11763
11764
11765
11766
11767
11768
11769
11770
11771
11772
11773
11774
11775
11776
11777
11778
11779
11780
11781
11782
11783
11784
11785
11786
11787
11788
11789
11790
11791
11792
11793
11794
11795
11796
11797
11798
11799
11800
11801
11802
11803
11804
11805
11806
11807
11808
11809
11810
11811
11812
11813
11814
11815
11816
11817
11818
11819
11820
11821
11822
11823
11824
11825
11826
11827
11828
11829
11830
11831
11832
11833
11834
11835
11836
11837
11838
11839
11840
11841
11842
11843
11844
11845
11846
11847
11848
11849
11850
11851
11852
11853
11854
11855
11856
11857
11858
11859
11860
11861
11862
11863
11864
11865
11866
11867
11868
11869
11870
11871
11872
11873
11874
11875
11876
11877
11878
11879
11880
11881
11882
11883
11884
11885
11886
11887
11888
11889
11890
11891
11892
11893
11894
11895
11896
11897
11898
11899
11900
11901
11902
11903
11904
11905
11906
11907
11908
11909
11910
11911
11912
11913
11914
11915
11916
11917
11918
11919
11920
11921
11922
11923
11924
11925
11926
11927
11928
11929
11930
11931
11932
11933
11934
11935
11936
11937
11938
11939
11940
11941
11942
11943
11944
11945
11946
11947
11948
11949
11950
11951
11952
11953
11954
11955
11956
11957
11958
11959
11960
11961
11962
11963
11964
11965
11966
11967
11968
11969
11970
11971
11972
11973
11974
11975
11976
11977
11978
11979
11980
11981
11982
11983
11984
11985
11986
11987
11988
11989
11990
11991
11992
11993
11994
11995
11996
11997
11998
11999
12000
12001
12002
12003
12004
12005
12006
12007
12008
12009
12010
12011
12012
12013
12014
12015
12016
12017
12018
12019
12020
12021
12022
12023
12024
12025
12026
12027
12028
12029
12030
12031
12032
12033
12034
12035
12036
12037
12038
12039
12040
12041
12042
12043
12044
12045
12046
12047
12048
12049
12050
12051
12052
12053
12054
12055
12056
12057
12058
12059
12060
12061
12062
12063
12064
12065
12066
12067
12068
12069
12070
12071
12072
12073
12074
12075
12076
12077
12078
12079
12080
12081
12082
12083
12084
12085
12086
12087
12088
12089
12090
12091
12092
12093
12094
12095
12096
12097
12098
12099
12100
12101
12102
12103
12104
12105
12106
12107
12108
12109
12110
12111
12112
12113
12114
12115
12116
12117
12118
12119
12120
12121
12122
12123
12124
12125
12126
12127
12128
12129
12130
12131
12132
12133
12134
12135
12136
12137
12138
12139
12140
12141
12142
12143
12144
12145
12146
12147
12148
12149
12150
12151
12152
12153
12154
12155
12156
12157
12158
12159
12160
12161
12162
12163
12164
12165
12166
12167
12168
12169
12170
12171
12172
12173
12174
12175
12176
12177
12178
12179
12180
12181
12182
12183
12184
12185
12186
12187
12188
12189
12190
12191
12192
12193
12194
12195
12196
12197
12198
12199
12200
12201
12202
12203
12204
12205
12206
12207
12208
12209
12210
12211
12212
12213
12214
12215
12216
12217
12218
12219
12220
12221
12222
12223
12224
12225
12226
12227
12228
12229
12230
12231
12232
12233
12234
12235
12236
12237
12238
12239
12240
12241
12242
12243
12244
12245
12246
12247
12248
12249
12250
12251
12252
12253
12254
12255
12256
12257
12258
12259
12260
12261
12262
12263
12264
12265
12266
12267
12268
12269
12270
12271
12272
12273
12274
12275
12276
12277
12278
12279
12280
12281
12282
12283
12284
12285
12286
12287
12288
12289
12290
12291
12292
12293
12294
12295
12296
12297
12298
12299
12300
12301
12302
12303
12304
12305
12306
12307
12308
12309
12310
12311
12312
12313
12314
12315
12316
12317
12318
12319
12320
12321
12322
12323
12324
12325
12326
12327
12328
12329
12330
12331
12332
12333
12334
12335
12336
12337
12338
12339
12340
12341
12342
12343
12344
12345
12346
12347
12348
12349
12350
12351
12352
12353
12354
12355
12356
12357
12358
12359
12360
12361
12362
12363
12364
12365
12366
12367
12368
12369
12370
12371
12372
12373
12374
12375
12376
12377
12378
12379
12380
12381
12382
12383
12384
12385
12386
12387
12388
12389
12390
12391
12392
12393
12394
12395
12396
12397
12398
12399
12400
12401
12402
12403
12404
12405
12406
12407
12408
12409
12410
12411
12412
12413
12414
12415
12416
12417
12418
12419
12420
12421
12422
12423
12424
12425
12426
12427
12428
12429
12430
12431
12432
12433
12434
12435
12436
12437
12438
12439
12440
12441
12442
12443
12444
12445
12446
12447
12448
12449
12450
12451
12452
12453
12454
12455
12456
12457
12458
12459
12460
12461
12462
12463
12464
12465
12466
12467
12468
12469
12470
12471
12472
12473
12474
12475
12476
12477
12478
12479
12480
12481
12482
12483
12484
12485
12486
12487
12488
12489
12490
12491
12492
12493
12494
12495
12496
12497
12498
12499
12500
12501
12502
12503
12504
12505
12506
12507
12508
12509
12510
12511
12512
12513
12514
12515
12516
12517
12518
12519
12520
12521
12522
12523
12524
12525
12526
12527
12528
12529
12530
12531
12532
12533
12534
12535
12536
12537
12538
12539
12540
12541
12542
12543
12544
12545
12546
12547
12548
12549
12550
12551
12552
12553
12554
12555
12556
12557
12558
12559
12560
12561
12562
12563
12564
12565
12566
12567
12568
12569
12570
12571
12572
12573
12574
12575
12576
12577
12578
12579
12580
12581
12582
12583
12584
12585
12586
12587
12588
12589
12590
12591
12592
12593
12594
12595
12596
12597
12598
12599
12600
12601
12602
12603
12604
12605
12606
12607
12608
12609
12610
12611
12612
12613
12614
12615
12616
12617
12618
12619
12620
12621
12622
12623
12624
12625
12626
12627
12628
12629
12630
12631
12632
12633
12634
12635
12636
12637
12638
12639
12640
12641
12642
12643
12644
12645
12646
12647
12648
12649
12650
12651
12652
12653
12654
12655
12656
12657
12658
12659
12660
12661
12662
12663
12664
12665
12666
12667
12668
12669
12670
12671
12672
12673
12674
12675
12676
12677
12678
12679
12680
12681
12682
12683
12684
12685
12686
12687
12688
12689
12690
12691
12692
12693
12694
12695
12696
12697
12698
12699
12700
12701
12702
12703
12704
12705
12706
12707
12708
12709
12710
12711
12712
12713
12714
12715
12716
12717
12718
12719
12720
12721
12722
12723
12724
12725
12726
12727
12728
12729
12730
12731
12732
12733
12734
12735
12736
12737
12738
12739
12740
12741
12742
12743
12744
12745
12746
12747
12748
12749
12750
12751
12752
12753
12754
12755
12756
12757
12758
12759
12760
12761
12762
12763
12764
12765
12766
12767
12768
12769
12770
12771
12772
12773
12774
12775
12776
12777
12778
12779
12780
12781
12782
12783
12784
12785
12786
12787
12788
12789
12790
12791
12792
12793
12794
12795
12796
12797
12798
12799
12800
12801
12802
12803
12804
12805
12806
12807
12808
12809
12810
12811
12812
12813
12814
12815
12816
12817
12818
12819
12820
12821
12822
12823
12824
12825
12826
12827
12828
12829
12830
12831
12832
12833
12834
12835
12836
12837
12838
12839
12840
12841
12842
12843
12844
12845
12846
12847
12848
12849
12850
12851
12852
12853
12854
12855
12856
12857
12858
12859
12860
12861
12862
12863
12864
12865
12866
12867
12868
12869
12870
12871
12872
12873
12874
12875
12876
12877
12878
12879
12880
12881
12882
12883
12884
12885
12886
12887
12888
12889
12890
12891
12892
12893
12894
12895
12896
12897
12898
12899
12900
12901
12902
12903
12904
12905
12906
12907
12908
12909
12910
12911
12912
12913
12914
12915
12916
12917
12918
12919
12920
12921
12922
12923
12924
12925
12926
12927
12928
12929
12930
12931
12932
12933
12934
12935
12936
12937
12938
12939
12940
12941
12942
12943
12944
12945
12946
12947
12948
12949
12950
12951
12952
12953
12954
12955
12956
12957
12958
12959
12960
12961
12962
12963
12964
12965
12966
12967
12968
12969
12970
12971
12972
12973
12974
12975
12976
12977
12978
12979
12980
12981
12982
12983
12984
12985
12986
12987
12988
12989
12990
12991
12992
12993
12994
12995
12996
12997
12998
12999
13000
13001
13002
13003
13004
13005
13006
13007
13008
13009
13010
13011
13012
13013
13014
13015
13016
13017
13018
13019
13020
13021
13022
13023
13024
13025
13026
13027
13028
13029
13030
13031
13032
13033
13034
13035
13036
13037
13038
13039
13040
13041
13042
13043
13044
13045
13046
13047
13048
13049
13050
13051
13052
13053
13054
13055
13056
13057
13058
13059
13060
13061
13062
13063
13064
13065
13066
13067
13068
13069
13070
13071
13072
13073
13074
13075
13076
13077
13078
13079
13080
13081
13082
13083
13084
13085
13086
13087
13088
13089
13090
13091
13092
13093
13094
13095
13096
13097
13098
13099
13100
13101
13102
13103
13104
13105
13106
13107
13108
13109
13110
13111
13112
13113
13114
13115
13116
13117
13118
13119
13120
13121
13122
13123
13124
13125
13126
13127
13128
13129
13130
13131
13132
13133
13134
13135
13136
13137
13138
13139
13140
13141
13142
13143
13144
13145
13146
13147
13148
13149
13150
13151
13152
13153
13154
13155
13156
13157
13158
13159
13160
13161
13162
13163
13164
13165
13166
13167
13168
13169
13170
13171
13172
13173
13174
13175
13176
13177
13178
13179
13180
13181
13182
13183
13184
13185
13186
13187
13188
13189
13190
13191
13192
13193
13194
13195
13196
13197
13198
13199
13200
13201
13202
13203
13204
13205
13206
13207
13208
13209
13210
13211
13212
13213
13214
13215
13216
13217
13218
13219
13220
13221
13222
13223
13224
13225
13226
13227
13228
13229
13230
13231
13232
13233
13234
13235
13236
13237
13238
13239
13240
13241
13242
13243
13244
13245
13246
13247
13248
13249
13250
13251
13252
13253
13254
13255
13256
13257
13258
13259
13260
13261
13262
13263
13264
13265
13266
13267
13268
13269
13270
13271
13272
13273
13274
13275
13276
13277
13278
13279
13280
13281
13282
13283
13284
13285
13286
13287
13288
13289
13290
13291
13292
13293
13294
13295
13296
13297
13298
13299
13300
13301
13302
13303
13304
13305
13306
13307
13308
13309
13310
13311
13312
13313
13314
13315
13316
13317
13318
13319
13320
13321
13322
13323
13324
13325
13326
13327
13328
13329
13330
13331
13332
13333
13334
13335
13336
13337
13338
13339
13340
13341
13342
13343
13344
13345
13346
13347
13348
13349
13350
13351
13352
13353
13354
13355
13356
13357
13358
13359
13360
13361
13362
13363
13364
13365
13366
13367
13368
13369
13370
13371
13372
13373
13374
13375
13376
13377
13378
13379
13380
13381
13382
13383
13384
13385
13386
13387
13388
13389
13390
13391
13392
13393
13394
13395
13396
13397
13398
13399
13400
13401
13402
13403
13404
13405
13406
13407
13408
13409
13410
13411
13412
13413
13414
13415
13416
13417
13418
13419
13420
13421
13422
13423
13424
13425
13426
13427
13428
13429
13430
13431
13432
13433
13434
13435
13436
13437
13438
13439
13440
13441
13442
13443
13444
13445
13446
13447
13448
13449
13450
13451
13452
13453
13454
13455
13456
13457
13458
13459
13460
13461
13462
13463
13464
13465
13466
13467
13468
13469
13470
13471
13472
13473
13474
13475
13476
13477
13478
13479
13480
13481
13482
13483
13484
13485
13486
13487
13488
13489
13490
13491
13492
13493
13494
13495
13496
13497
13498
13499
13500
13501
13502
13503
13504
13505
13506
13507
13508
13509
13510
13511
13512
13513
13514
13515
13516
13517
13518
13519
13520
13521
13522
13523
13524
13525
13526
13527
13528
13529
13530
13531
13532
13533
13534
13535
13536
13537
13538
13539
13540
13541
13542
13543
13544
13545
13546
13547
13548
13549
13550
13551
13552
13553
13554
13555
13556
13557
13558
13559
13560
13561
13562
13563
13564
13565
13566
13567
13568
13569
13570
13571
13572
13573
13574
13575
13576
13577
13578
13579
13580
13581
13582
13583
13584
13585
13586
13587
13588
13589
13590
13591
13592
13593
13594
13595
13596
13597
13598
13599
13600
13601
13602
13603
13604
13605
13606
13607
13608
13609
13610
13611
13612
13613
13614
13615
13616
13617
13618
13619
13620
13621
13622
13623
13624
13625
13626
13627
13628
13629
13630
13631
13632
13633
13634
13635
13636
13637
13638
13639
13640
13641
13642
13643
13644
13645
13646
13647
13648
13649
13650
13651
13652
13653
13654
13655
13656
13657
13658
13659
13660
13661
13662
13663
13664
13665
13666
13667
13668
13669
13670
13671
13672
13673
13674
13675
13676
13677
13678
13679
13680
13681
13682
13683
13684
13685
13686
13687
13688
13689
13690
13691
13692
13693
13694
13695
13696
13697
13698
13699
13700
13701
13702
13703
13704
13705
13706
13707
13708
13709
13710
13711
13712
13713
13714
13715
13716
13717
13718
13719
13720
13721
13722
13723
13724
13725
13726
13727
13728
13729
13730
13731
13732
13733
13734
13735
13736
13737
13738
13739
13740
13741
13742
13743
13744
13745
13746
13747
13748
13749
13750
13751
13752
13753
13754
13755
13756
13757
13758
13759
13760
13761
13762
13763
13764
13765
13766
13767
13768
13769
13770
13771
13772
13773
13774
13775
13776
13777
13778
13779
13780
13781
13782
13783
13784
13785
13786
13787
13788
13789
13790
13791
13792
13793
13794
13795
13796
13797
13798
13799
13800
13801
13802
13803
13804
13805
13806
13807
13808
13809
13810
13811
13812
13813
13814
13815
13816
13817
13818
13819
13820
13821
13822
13823
13824
13825
13826
13827
13828
13829
13830
13831
13832
13833
13834
13835
13836
13837
13838
13839
13840
13841
13842
13843
13844
13845
13846
13847
13848
13849
13850
13851
13852
13853
13854
13855
13856
13857
13858
13859
13860
13861
13862
13863
13864
13865
13866
13867
13868
13869
13870
13871
13872
13873
13874
13875
13876
13877
13878
13879
13880
13881
13882
13883
13884
13885
13886
13887
13888
13889
13890
13891
13892
13893
13894
13895
13896
13897
13898
13899
13900
13901
13902
13903
13904
13905
13906
13907
13908
13909
13910
13911
13912
13913
13914
13915
13916
13917
13918
13919
13920
13921
13922
13923
13924
13925
13926
13927
13928
13929
13930
13931
13932
13933
13934
13935
13936
13937
13938
13939
13940
13941
13942
13943
13944
13945
13946
13947
13948
13949
13950
13951
13952
13953
13954
13955
13956
13957
13958
13959
13960
13961
13962
13963
13964
13965
13966
13967
13968
13969
13970
13971
13972
13973
13974
13975
13976
13977
13978
13979
13980
13981
13982
13983
13984
13985
13986
13987
13988
13989
13990
13991
13992
13993
13994
13995
13996
13997
13998
13999
14000
14001
14002
14003
14004
14005
14006
14007
14008
14009
14010
14011
14012
14013
14014
14015
14016
14017
14018
14019
14020
14021
14022
14023
14024
14025
14026
14027
14028
14029
14030
14031
14032
14033
14034
14035
14036
14037
14038
14039
14040
14041
14042
14043
14044
14045
14046
14047
14048
14049
14050
14051
14052
14053
14054
14055
14056
14057
14058
14059
14060
14061
14062
14063
14064
14065
14066
14067
14068
14069
14070
14071
14072
14073
14074
14075
14076
14077
14078
14079
14080
14081
14082
14083
14084
14085
14086
14087
14088
14089
14090
14091
14092
14093
14094
14095
14096
14097
14098
14099
14100
14101
14102
14103
14104
14105
14106
14107
14108
14109
14110
14111
14112
14113
14114
14115
14116
14117
14118
14119
14120
14121
14122
14123
14124
14125
14126
14127
14128
14129
14130
14131
14132
14133
14134
14135
14136
14137
14138
14139
14140
14141
14142
14143
14144
14145
14146
14147
14148
14149
14150
14151
14152
14153
14154
14155
14156
14157
14158
14159
14160
14161
14162
14163
14164
14165
14166
14167
14168
14169
14170
14171
14172
14173
14174
14175
14176
14177
14178
14179
14180
14181
14182
14183
14184
14185
14186
14187
14188
14189
14190
14191
14192
14193
14194
14195
14196
14197
14198
14199
14200
14201
14202
14203
14204
14205
14206
14207
14208
14209
14210
14211
14212
14213
14214
14215
14216
14217
14218
14219
14220
14221
14222
14223
14224
14225
14226
14227
14228
14229
14230
14231
14232
14233
14234
14235
14236
14237
14238
14239
14240
14241
14242
14243
14244
14245
14246
14247
14248
14249
14250
14251
14252
14253
14254
14255
14256
14257
14258
14259
14260
14261
14262
14263
14264
14265
14266
14267
14268
14269
14270
14271
14272
14273
14274
14275
14276
14277
14278
14279
14280
14281
14282
14283
14284
14285
14286
14287
14288
14289
14290
14291
14292
14293
14294
14295
14296
14297
14298
14299
14300
14301
14302
14303
14304
14305
14306
14307
14308
14309
14310
14311
14312
14313
14314
14315
14316
14317
14318
14319
14320
14321
14322
14323
14324
14325
14326
14327
14328
14329
14330
14331
14332
14333
14334
14335
14336
14337
14338
14339
14340
14341
14342
14343
14344
14345
14346
14347
14348
14349
14350
14351
14352
14353
14354
14355
14356
14357
14358
14359
14360
14361
14362
14363
14364
14365
14366
14367
14368
14369
14370
14371
14372
14373
14374
14375
14376
14377
14378
14379
14380
14381
14382
14383
14384
14385
14386
14387
14388
14389
14390
14391
14392
14393
14394
14395
14396
14397
14398
14399
14400
14401
14402
14403
14404
14405
14406
14407
14408
14409
14410
14411
14412
14413
14414
14415
14416
14417
14418
14419
14420
14421
14422
14423
14424
14425
14426
14427
14428
14429
14430
14431
14432
14433
14434
14435
14436
14437
14438
14439
14440
14441
14442
14443
14444
14445
14446
14447
14448
14449
14450
14451
14452
14453
14454
14455
14456
14457
14458
14459
14460
14461
14462
14463
14464
14465
14466
14467
14468
14469
14470
14471
14472
14473
14474
14475
14476
14477
14478
14479
14480
14481
14482
14483
14484
14485
14486
14487
14488
14489
14490
14491
14492
14493
14494
14495
14496
14497
14498
14499
14500
14501
14502
14503
14504
14505
14506
14507
14508
14509
14510
14511
14512
14513
14514
14515
14516
14517
14518
14519
14520
14521
14522
14523
14524
14525
14526
14527
14528
14529
14530
14531
14532
14533
14534
14535
14536
14537
14538
14539
14540
14541
14542
14543
14544
14545
14546
14547
14548
14549
14550
14551
14552
14553
14554
14555
14556
14557
14558
14559
14560
14561
14562
14563
14564
14565
14566
14567
14568
14569
14570
14571
14572
14573
14574
14575
14576
14577
14578
14579
14580
14581
14582
14583
14584
14585
14586
14587
14588
14589
14590
14591
14592
14593
14594
14595
14596
14597
14598
14599
14600
14601
14602
14603
14604
14605
14606
14607
14608
14609
14610
14611
14612
14613
14614
14615
14616
14617
14618
14619
14620
14621
14622
14623
14624
14625
14626
14627
14628
14629
14630
14631
14632
14633
14634
14635
14636
14637
14638
14639
14640
14641
14642
14643
14644
14645
14646
14647
14648
14649
14650
14651
14652
14653
14654
14655
14656
14657
14658
14659
14660
14661
14662
14663
14664
14665
14666
14667
14668
14669
14670
14671
14672
14673
14674
14675
14676
14677
14678
14679
14680
14681
14682
14683
14684
14685
14686
14687
14688
14689
14690
14691
14692
14693
14694
14695
14696
14697
14698
14699
14700
14701
14702
14703
14704
14705
14706
14707
14708
14709
14710
14711
14712
14713
14714
14715
14716
14717
14718
14719
14720
14721
14722
14723
14724
14725
14726
14727
14728
14729
14730
14731
14732
14733
14734
14735
14736
14737
14738
14739
14740
14741
14742
14743
14744
14745
14746
14747
14748
14749
14750
14751
14752
14753
14754
14755
14756
14757
14758
14759
14760
14761
14762
14763
14764
14765
14766
14767
14768
14769
14770
14771
14772
14773
14774
14775
14776
14777
14778
14779
14780
14781
14782
14783
14784
14785
14786
14787
14788
14789
14790
14791
14792
14793
14794
14795
14796
14797
14798
14799
14800
14801
14802
14803
14804
14805
14806
14807
14808
14809
14810
14811
14812
14813
14814
14815
14816
14817
14818
14819
14820
14821
14822
14823
14824
14825
14826
14827
14828
14829
14830
14831
14832
14833
14834
14835
14836
14837
14838
14839
14840
14841
14842
14843
14844
14845
14846
14847
14848
14849
14850
14851
14852
14853
14854
14855
14856
14857
14858
14859
14860
14861
14862
14863
14864
14865
14866
14867
14868
14869
14870
14871
14872
14873
14874
14875
14876
14877
14878
14879
14880
14881
14882
14883
14884
14885
14886
14887
14888
14889
14890
14891
14892
14893
14894
14895
14896
14897
14898
14899
14900
14901
14902
14903
14904
14905
14906
14907
14908
14909
14910
14911
14912
14913
14914
14915
14916
14917
14918
14919
14920
14921
14922
14923
14924
14925
14926
14927
14928
14929
14930
14931
14932
14933
14934
14935
14936
14937
14938
14939
14940
14941
14942
14943
14944
14945
14946
14947
14948
14949
14950
14951
14952
14953
14954
14955
14956
14957
14958
14959
14960
14961
14962
14963
14964
14965
14966
14967
14968
14969
14970
14971
14972
14973
14974
14975
14976
14977
14978
14979
14980
14981
14982
14983
14984
14985
14986
14987
14988
14989
14990
14991
14992
14993
14994
14995
14996
14997
14998
14999
15000
15001
15002
15003
15004
15005
15006
15007
15008
15009
15010
15011
15012
15013
15014
15015
15016
15017
15018
15019
15020
15021
15022
15023
15024
15025
15026
15027
15028
15029
15030
15031
15032
15033
15034
15035
15036
15037
15038
15039
15040
15041
15042
15043
15044
15045
15046
15047
15048
15049
15050
15051
15052
15053
15054
15055
15056
15057
15058
15059
15060
15061
15062
15063
15064
15065
15066
15067
15068
15069
15070
15071
15072
15073
15074
15075
15076
15077
15078
15079
15080
15081
15082
15083
15084
15085
15086
15087
15088
15089
15090
15091
15092
15093
15094
15095
15096
15097
15098
15099
15100
15101
15102
15103
15104
15105
15106
15107
15108
15109
15110
15111
15112
15113
15114
15115
15116
15117
15118
15119
15120
15121
15122
15123
15124
15125
15126
15127
15128
15129
15130
15131
15132
15133
15134
15135
15136
15137
15138
15139
15140
15141
15142
15143
15144
15145
15146
15147
15148
15149
15150
15151
15152
15153
15154
15155
15156
15157
15158
15159
15160
15161
15162
15163
15164
15165
15166
15167
15168
15169
15170
15171
15172
15173
15174
15175
15176
15177
15178
15179
15180
15181
15182
15183
15184
15185
15186
15187
15188
15189
15190
15191
15192
15193
15194
15195
15196
15197
15198
15199
15200
15201
15202
15203
15204
15205
15206
15207
15208
15209
15210
15211
15212
15213
15214
15215
15216
15217
15218
15219
15220
15221
15222
15223
15224
15225
15226
15227
15228
15229
15230
15231
15232
15233
15234
15235
15236
15237
15238
15239
15240
15241
15242
15243
15244
15245
15246
15247
15248
15249
15250
15251
15252
15253
15254
15255
15256
15257
15258
15259
15260
15261
15262
15263
15264
15265
15266
15267
15268
15269
15270
15271
15272
15273
15274
15275
15276
15277
15278
15279
15280
15281
15282
15283
15284
15285
15286
15287
15288
15289
15290
15291
15292
15293
15294
15295
15296
15297
15298
15299
15300
15301
15302
15303
15304
15305
15306
15307
15308
15309
15310
15311
15312
15313
15314
15315
15316
15317
15318
15319
15320
15321
15322
15323
15324
15325
15326
15327
15328
15329
15330
15331
15332
15333
15334
15335
15336
15337
15338
15339
15340
15341
15342
15343
15344
15345
15346
15347
15348
15349
15350
15351
15352
15353
15354
15355
15356
15357
15358
15359
15360
15361
15362
15363
15364
15365
15366
15367
15368
15369
15370
15371
15372
15373
15374
15375
15376
15377
15378
15379
15380
15381
15382
15383
15384
15385
15386
15387
15388
15389
15390
15391
15392
15393
15394
15395
15396
15397
15398
15399
15400
15401
15402
15403
15404
15405
15406
15407
15408
15409
15410
15411
15412
15413
15414
15415
15416
15417
15418
15419
15420
15421
15422
15423
15424
15425
15426
15427
15428
15429
15430
15431
15432
15433
15434
15435
15436
15437
15438
15439
15440
15441
15442
15443
15444
15445
15446
15447
15448
15449
15450
15451
15452
15453
15454
15455
15456
15457
15458
15459
15460
15461
15462
15463
15464
15465
15466
15467
15468
15469
15470
15471
15472
15473
15474
15475
15476
15477
15478
15479
15480
15481
15482
15483
15484
15485
15486
15487
15488
15489
15490
15491
15492
15493
15494
15495
15496
15497
15498
15499
15500
15501
15502
15503
15504
15505
15506
15507
15508
15509
15510
15511
15512
15513
15514
15515
15516
15517
15518
15519
15520
15521
15522
15523
15524
15525
15526
15527
15528
15529
15530
15531
15532
15533
15534
15535
15536
15537
15538
15539
15540
15541
15542
15543
15544
15545
15546
15547
15548
15549
15550
15551
15552
15553
15554
15555
15556
15557
15558
15559
15560
15561
15562
15563
15564
15565
15566
15567
15568
15569
15570
15571
15572
15573
15574
15575
15576
15577
15578
15579
15580
15581
15582
15583
15584
15585
15586
15587
15588
15589
15590
15591
15592
15593
15594
15595
15596
15597
15598
15599
15600
15601
15602
15603
15604
15605
15606
15607
15608
15609
15610
15611
15612
15613
15614
15615
15616
15617
15618
15619
15620
15621
15622
15623
15624
15625
15626
15627
15628
15629
15630
15631
15632
15633
15634
15635
15636
15637
15638
15639
15640
15641
15642
15643
15644
15645
15646
15647
15648
15649
15650
15651
15652
15653
15654
15655
15656
15657
15658
15659
15660
15661
15662
15663
15664
15665
15666
15667
15668
15669
15670
15671
15672
15673
15674
15675
15676
15677
15678
15679
15680
15681
15682
15683
15684
15685
15686
15687
15688
15689
15690
15691
15692
15693
15694
15695
15696
15697
15698
15699
15700
15701
15702
15703
15704
15705
15706
15707
15708
15709
15710
15711
15712
15713
15714
15715
15716
15717
15718
15719
15720
15721
15722
15723
15724
15725
15726
15727
15728
15729
15730
15731
15732
15733
15734
15735
15736
15737
15738
15739
15740
15741
15742
15743
15744
15745
15746
15747
15748
15749
15750
15751
15752
15753
15754
15755
15756
15757
15758
15759
15760
15761
15762
15763
15764
15765
15766
15767
15768
15769
15770
15771
15772
15773
15774
15775
15776
15777
15778
15779
15780
15781
15782
15783
15784
15785
15786
15787
15788
15789
15790
15791
15792
15793
15794
15795
15796
15797
15798
15799
15800
15801
15802
15803
15804
15805
15806
15807
15808
15809
15810
15811
15812
15813
15814
15815
15816
15817
15818
15819
15820
15821
15822
15823
15824
15825
15826
15827
15828
15829
15830
15831
15832
15833
15834
15835
15836
15837
15838
15839
15840
15841
15842
15843
15844
15845
15846
15847
15848
15849
15850
15851
15852
15853
15854
15855
15856
15857
15858
15859
15860
15861
15862
15863
15864
15865
15866
15867
15868
15869
15870
15871
15872
15873
15874
15875
15876
15877
15878
15879
15880
15881
15882
15883
15884
15885
15886
15887
15888
15889
15890
15891
15892
15893
15894
15895
15896
15897
15898
15899
15900
15901
15902
15903
15904
15905
15906
15907
15908
15909
15910
15911
15912
15913
15914
15915
15916
15917
15918
15919
15920
15921
15922
15923
15924
15925
15926
15927
15928
15929
15930
15931
15932
15933
15934
15935
15936
15937
15938
15939
15940
15941
15942
15943
15944
15945
15946
15947
15948
15949
15950
15951
15952
15953
15954
15955
15956
15957
15958
15959
15960
15961
15962
15963
15964
15965
15966
15967
15968
15969
15970
15971
15972
15973
15974
15975
15976
15977
15978
15979
15980
15981
15982
15983
15984
15985
15986
15987
15988
15989
15990
15991
15992
15993
15994
15995
15996
15997
15998
15999
16000
16001
16002
16003
16004
16005
16006
16007
16008
16009
16010
16011
16012
16013
16014
16015
16016
16017
16018
16019
16020
16021
16022
16023
16024
16025
16026
16027
16028
16029
16030
16031
16032
16033
16034
16035
16036
16037
16038
16039
16040
16041
16042
16043
16044
16045
16046
16047
16048
16049
16050
16051
16052
16053
16054
16055
16056
16057
16058
16059
16060
16061
16062
16063
16064
16065
16066
16067
16068
16069
16070
16071
16072
16073
16074
16075
16076
16077
16078
16079
16080
16081
16082
16083
16084
16085
16086
16087
16088
16089
16090
16091
16092
16093
16094
16095
16096
16097
16098
16099
16100
16101
16102
16103
16104
16105
16106
16107
16108
16109
16110
16111
16112
16113
16114
16115
16116
16117
16118
16119
16120
16121
16122
16123
16124
16125
16126
16127
16128
16129
16130
16131
16132
16133
16134
16135
16136
16137
16138
16139
16140
16141
16142
16143
16144
16145
16146
16147
16148
16149
16150
16151
16152
16153
16154
16155
16156
16157
16158
16159
16160
16161
16162
16163
16164
16165
16166
16167
16168
16169
16170
16171
16172
16173
16174
16175
16176
16177
16178
16179
16180
16181
16182
16183
16184
16185
16186
16187
16188
16189
16190
16191
16192
16193
16194
16195
16196
16197
16198
16199
16200
16201
16202
16203
16204
16205
16206
16207
16208
16209
16210
16211
16212
16213
16214
16215
16216
16217
16218
16219
16220
16221
16222
16223
16224
16225
16226
16227
16228
16229
16230
16231
16232
16233
16234
16235
16236
16237
16238
16239
16240
16241
16242
16243
16244
16245
16246
16247
16248
16249
16250
16251
16252
16253
16254
16255
16256
16257
16258
16259
16260
16261
16262
16263
16264
16265
16266
16267
16268
16269
16270
16271
16272
16273
16274
16275
16276
16277
16278
16279
16280
16281
16282
16283
16284
16285
16286
16287
16288
16289
16290
16291
16292
16293
16294
16295
16296
16297
16298
16299
16300
16301
16302
16303
16304
16305
16306
16307
16308
16309
16310
16311
16312
16313
16314
16315
16316
16317
16318
16319
16320
16321
16322
16323
16324
16325
16326
16327
16328
16329
16330
16331
16332
16333
16334
16335
16336
16337
16338
16339
16340
16341
16342
16343
16344
16345
16346
16347
16348
16349
16350
16351
16352
16353
16354
16355
16356
16357
16358
16359
16360
16361
16362
16363
16364
16365
16366
16367
16368
16369
16370
16371
16372
16373
16374
16375
16376
16377
16378
16379
16380
16381
16382
16383
16384
16385
16386
16387
16388
16389
16390
16391
16392
16393
16394
16395
16396
16397
16398
16399
16400
16401
16402
16403
16404
16405
16406
16407
16408
16409
16410
16411
16412
16413
16414
16415
16416
16417
16418
16419
16420
16421
16422
16423
16424
16425
16426
16427
16428
16429
16430
16431
16432
16433
16434
16435
16436
16437
16438
16439
16440
16441
16442
16443
16444
16445
16446
16447
16448
16449
16450
16451
16452
16453
16454
16455
16456
16457
16458
16459
16460
16461
16462
16463
16464
16465
16466
16467
16468
16469
16470
16471
16472
16473
16474
16475
16476
16477
16478
16479
16480
16481
16482
16483
16484
16485
16486
16487
16488
16489
16490
16491
16492
16493
16494
16495
16496
16497
16498
16499
16500
16501
16502
16503
16504
16505
16506
16507
16508
16509
16510
16511
16512
16513
16514
16515
16516
16517
16518
16519
16520
16521
16522
16523
16524
16525
16526
16527
16528
16529
16530
16531
16532
16533
16534
16535
16536
16537
16538
16539
16540
16541
16542
16543
16544
16545
16546
16547
16548
16549
16550
16551
16552
16553
16554
16555
16556
16557
16558
16559
16560
16561
16562
16563
16564
16565
16566
16567
16568
16569
16570
16571
16572
16573
16574
16575
16576
16577
16578
16579
16580
16581
16582
16583
16584
16585
16586
16587
16588
16589
16590
16591
16592
16593
16594
16595
16596
16597
16598
16599
16600
16601
16602
16603
16604
16605
16606
16607
16608
16609
16610
16611
16612
16613
16614
16615
16616
16617
16618
16619
16620
16621
16622
16623
16624
16625
16626
16627
16628
16629
16630
16631
16632
16633
16634
16635
16636
16637
16638
16639
16640
16641
16642
16643
16644
16645
16646
16647
16648
16649
16650
16651
16652
16653
16654
16655
16656
16657
16658
16659
16660
16661
16662
16663
16664
16665
16666
16667
16668
16669
16670
16671
16672
16673
16674
16675
16676
16677
16678
16679
16680
16681
16682
16683
16684
16685
16686
16687
16688
16689
16690
16691
16692
16693
16694
16695
16696
16697
16698
16699
16700
16701
16702
16703
16704
16705
16706
16707
16708
16709
16710
16711
16712
16713
16714
16715
16716
16717
16718
16719
16720
16721
16722
16723
16724
16725
16726
16727
16728
16729
16730
16731
16732
16733
16734
16735
16736
16737
16738
16739
16740
16741
16742
16743
16744
16745
16746
16747
16748
16749
16750
16751
16752
16753
16754
16755
16756
16757
16758
16759
16760
16761
16762
16763
16764
16765
16766
16767
16768
16769
16770
16771
16772
16773
16774
16775
16776
16777
16778
16779
16780
16781
16782
16783
16784
16785
16786
16787
16788
16789
16790
16791
16792
16793
16794
16795
16796
16797
16798
16799
16800
16801
16802
16803
16804
16805
16806
16807
16808
16809
16810
16811
16812
16813
16814
16815
16816
16817
16818
16819
16820
16821
16822
16823
16824
16825
16826
16827
16828
16829
16830
16831
16832
16833
16834
16835
16836
16837
16838
16839
16840
16841
16842
16843
16844
16845
16846
16847
16848
16849
16850
16851
16852
16853
16854
16855
16856
16857
16858
16859
16860
16861
16862
16863
16864
16865
16866
16867
16868
16869
16870
16871
16872
16873
16874
16875
16876
16877
16878
16879
16880
16881
16882
16883
16884
16885
16886
16887
16888
16889
16890
16891
16892
16893
16894
16895
16896
16897
16898
16899
16900
16901
16902
16903
16904
16905
16906
16907
16908
16909
16910
16911
16912
16913
16914
16915
16916
16917
16918
16919
16920
16921
16922
16923
16924
16925
16926
16927
16928
16929
16930
16931
16932
16933
16934
16935
16936
16937
16938
16939
16940
16941
16942
16943
16944
16945
16946
16947
16948
16949
16950
16951
16952
16953
16954
16955
16956
16957
16958
16959
16960
16961
16962
16963
16964
16965
16966
16967
16968
16969
16970
16971
16972
16973
16974
16975
16976
16977
16978
16979
16980
16981
16982
16983
16984
16985
16986
16987
16988
16989
16990
16991
16992
16993
16994
16995
16996
16997
16998
16999
17000
17001
17002
17003
17004
17005
17006
17007
17008
17009
17010
17011
17012
17013
17014
17015
17016
17017
17018
17019
17020
17021
17022
17023
17024
17025
17026
17027
17028
17029
17030
17031
17032
17033
17034
17035
17036
17037
17038
17039
17040
17041
17042
17043
17044
17045
17046
17047
17048
17049
17050
17051
17052
17053
17054
17055
17056
17057
17058
17059
17060
17061
17062
17063
17064
17065
17066
17067
17068
17069
17070
17071
17072
17073
17074
17075
17076
17077
17078
17079
17080
17081
17082
17083
17084
17085
17086
17087
17088
17089
17090
17091
17092
17093
17094
17095
17096
17097
17098
17099
17100
17101
17102
17103
17104
17105
17106
17107
17108
17109
17110
17111
17112
17113
17114
17115
17116
17117
17118
17119
17120
17121
17122
17123
17124
17125
17126
17127
17128
17129
17130
17131
17132
17133
17134
17135
17136
17137
17138
17139
17140
17141
17142
17143
17144
17145
17146
17147
17148
17149
17150
17151
17152
17153
17154
17155
17156
17157
17158
17159
17160
17161
17162
17163
17164
17165
17166
17167
17168
17169
17170
17171
17172
17173
17174
17175
17176
17177
17178
17179
17180
17181
17182
17183
17184
17185
17186
17187
17188
17189
17190
17191
17192
17193
17194
17195
17196
17197
17198
17199
17200
17201
17202
17203
17204
17205
17206
17207
17208
17209
17210
17211
17212
17213
17214
17215
17216
17217
17218
17219
17220
17221
17222
17223
17224
17225
17226
17227
17228
17229
17230
17231
17232
17233
17234
17235
17236
17237
17238
17239
17240
17241
17242
17243
17244
17245
17246
17247
17248
17249
17250
17251
17252
17253
17254
17255
17256
17257
17258
17259
17260
17261
17262
17263
17264
17265
17266
17267
17268
17269
17270
17271
17272
17273
17274
17275
17276
17277
17278
17279
17280
17281
17282
17283
17284
17285
17286
17287
17288
17289
17290
17291
17292
17293
17294
17295
17296
17297
17298
17299
17300
17301
17302
17303
17304
17305
17306
17307
17308
17309
17310
17311
17312
17313
17314
17315
17316
17317
17318
17319
17320
17321
17322
17323
17324
17325
17326
17327
17328
17329
17330
17331
17332
17333
17334
17335
17336
17337
17338
17339
17340
17341
17342
17343
17344
17345
17346
17347
17348
17349
17350
17351
17352
17353
17354
17355
17356
17357
17358
17359
17360
17361
17362
17363
17364
17365
17366
17367
17368
17369
17370
17371
17372
17373
17374
17375
17376
17377
17378
17379
17380
17381
17382
17383
17384
17385
17386
17387
17388
17389
17390
17391
17392
17393
17394
17395
17396
17397
17398
17399
17400
17401
17402
17403
17404
17405
17406
17407
17408
17409
17410
17411
17412
17413
17414
17415
17416
17417
17418
17419
17420
17421
17422
17423
17424
17425
17426
17427
17428
17429
17430
17431
17432
17433
17434
17435
17436
17437
17438
17439
17440
17441
17442
17443
17444
17445
17446
17447
17448
17449
17450
17451
17452
17453
17454
17455
17456
17457
17458
17459
17460
17461
17462
17463
17464
17465
17466
17467
17468
17469
17470
17471
17472
17473
17474
17475
17476
17477
17478
17479
17480
17481
17482
17483
17484
17485
17486
17487
17488
17489
17490
17491
17492
17493
17494
17495
17496
17497
17498
17499
17500
17501
17502
17503
17504
17505
17506
17507
17508
17509
17510
17511
17512
17513
17514
17515
17516
17517
17518
17519
17520
17521
17522
17523
17524
17525
17526
17527
17528
17529
17530
17531
17532
17533
17534
17535
17536
17537
17538
17539
17540
17541
17542
17543
17544
17545
17546
17547
17548
17549
17550
17551
17552
17553
17554
17555
17556
17557
17558
17559
17560
17561
17562
17563
17564
17565
17566
17567
17568
17569
17570
17571
17572
17573
17574
17575
17576
17577
17578
17579
17580
17581
17582
17583
17584
17585
17586
17587
17588
17589
17590
17591
17592
17593
17594
17595
17596
17597
17598
17599
17600
17601
17602
17603
17604
17605
17606
17607
17608
17609
17610
17611
17612
17613
17614
17615
17616
17617
17618
17619
17620
17621
17622
17623
17624
17625
17626
17627
17628
17629
17630
17631
17632
17633
17634
17635
17636
17637
17638
17639
17640
17641
17642
17643
17644
17645
17646
17647
17648
17649
17650
17651
17652
17653
17654
17655
17656
17657
17658
17659
17660
17661
17662
17663
17664
17665
17666
17667
17668
17669
17670
17671
17672
17673
17674
17675
17676
17677
17678
17679
17680
17681
17682
17683
17684
17685
17686
17687
17688
17689
17690
17691
17692
17693
17694
17695
17696
17697
17698
17699
17700
17701
17702
17703
17704
17705
17706
17707
17708
17709
17710
17711
17712
17713
17714
17715
17716
17717
17718
17719
17720
17721
17722
17723
17724
17725
17726
17727
17728
17729
17730
17731
17732
17733
17734
17735
17736
17737
17738
17739
17740
17741
17742
17743
17744
17745
17746
17747
17748
17749
17750
17751
17752
17753
17754
17755
17756
17757
17758
17759
17760
17761
17762
17763
17764
17765
17766
17767
17768
17769
17770
17771
17772
17773
17774
17775
17776
17777
17778
17779
17780
17781
17782
17783
17784
17785
17786
17787
17788
17789
17790
17791
17792
17793
17794
17795
17796
17797
17798
17799
17800
17801
17802
17803
17804
17805
17806
17807
17808
17809
17810
17811
17812
17813
17814
17815
17816
17817
17818
17819
17820
17821
17822
17823
17824
17825
17826
17827
17828
17829
17830
17831
17832
17833
17834
17835
17836
17837
17838
17839
17840
17841
17842
17843
17844
17845
17846
17847
17848
17849
17850
17851
17852
17853
17854
17855
17856
17857
17858
17859
17860
17861
17862
17863
17864
17865
17866
17867
17868
17869
17870
17871
17872
17873
17874
17875
17876
17877
17878
17879
17880
17881
17882
17883
17884
17885
17886
17887
17888
17889
17890
|
2010-10-20 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/47754> New script to verify explicit source file types in Xcode project files
Reviewed by Darin Adler.
The script parses an Xcode project file and makes sure the file
extension matches the explicit file type set for all source
files. Note that the majority of source files will have their
type set by Xcode, so the script doesn't check them since there
is no need to second-guess Xcode.
* Scripts/check-Xcode-source-file-types: Added. Code borrowed
heavily from sort-Xcode-project-file.
2010-10-20 Adam Roben <aroben@apple.com>
Windows build fix
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added missing #include.
2010-10-20 Adam Roben <aroben@apple.com>
Qt test fix
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Added
PassDifferentNPPStruct.cpp.
2010-10-20 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=48027
Add ability to test injected bundle API using TestWebKitAPI
* TestWebKitAPI/InjectedBundleController.cpp: Added.
* TestWebKitAPI/InjectedBundleController.h: Added.
Shared main object for bundle functionality.
* TestWebKitAPI/InjectedBundleMain.cpp: Added.
Bundle entry point.
* TestWebKitAPI/InjectedBundleTest.h: Added.
Base class for which the bundle portion of a test derives from.
* TestWebKitAPI/PlatformUtilities.h:
* TestWebKitAPI/PlatformUtilities.cpp: Added.
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::URLForNonExistentResource):
Add helper to create a context with the shared injected bundle,
and send the initial message to set up the test.
* TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Added.
* TestWebKitAPI/InjectedBundle-Info.plist: Added.
Add mac configuration files.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add the new files.
* TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Added.
* TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Added.
Add a simple initial bundle test.
2010-10-20 Eric Seidel <eric@webkit.org>
Unreviewed. Fixing /release-patch url used by the EWS bots.
EWS should test patches with r+
https://bugs.webkit.org/show_bug.cgi?id=35460
* Scripts/webkitpy/common/net/statusserver.py:
- I changed the URL during development, and 404s are
intentionally silenced during release_patch.
2010-10-14 Adam Roben <aroben@apple.com>
Test that passing a different NPP struct back to the browser doesn't
cause an assertion failure
Test for <http://webkit.org/b/47690> <rdar://problem/8553020>
Assertion failure in NetscapePlugin::fromNPP when using Shockwave in
WebKit2
Reviewed by John Sullivan.
* DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: Copied from WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp.
(PassDifferentNPPStruct::PassDifferentNPPStruct): Initialize our
members.
(PassDifferentNPPStruct::NPP_SetWindow): Pass a different NPP to the
browser than the one it gave us in NPP_New and see if it works.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Added PassDifferentNPPStruct.
2010-10-19 Adam Roben <aroben@apple.com>
Gently nudge old-run-webkit-tests toward working with Win32 Perl
This makes old-run-webkit-tests able to build DRT and find all the
tests to run. It even invokes DRT and passes it the list of tests. But
DRT ends up hung blocking on I/O.
Fixes <http://webkit.org/b/47961> Get old-run-webkit-tests mostly
working with Win32 Perl
Reviewed by David Kilzer.
* Scripts/old-run-webkit-tests:
- Use File::Spec instead of manually concatenating paths
- Use dirname instead of manually stripping off the base name
- Use isCygwin/isWindows/isAppleWinWebKit more judiciously
- Explicitly invoke Perl when running Perl scripts
- Quote paths when using them in regular expressions to allow them
to include characters that have special meanings in regular
expressions
* Scripts/run-webkit-tests: Use File::Spec instead of manually
concatenating paths.
* Scripts/webkitdirs.pm:
- Remove the unused $windowsTmpPath variable
- Use isCygwin/isWindows/isAppleWinWebKit more judiciously
- Only pass paths to cygpath when using Cygwin Perl
- Only use pdevenv when using Cygwin Perl, for now
2010-10-20 Daniel Bates <dbates@rim.com>
Reviewed by Martin Robinson.
Add Git-support to do-file-rename
https://bugs.webkit.org/show_bug.cgi?id=48015
Also, abstracts the SCM move/rename functionality in do-file-rename and
do-webcore-rename into a common function VCSUtils::scmMoveOrRenameFile().
Currently, do-file-rename is hard coded to assume the SCM is Subversion.
Instead, we should abstract the rename logic to be SCM-independent. This
will allow us to add Git support as well move such functionality into
our SCM library VCSUtils, where it can be shared by do-webcore-rename.
* Scripts/VCSUtils.pm:
- Added function scmMoveOrRenameFile.
* Scripts/do-file-rename: Modified to call VCSUtils::scmMoveOrRenameFile().
* Scripts/do-webcore-rename: Ditto.
2010-10-20 Adam Roben <aroben@apple.com>
Fix old-run-webkit-tests when there's a space in the path to DRT
Reviewed by Jon Honeycutt.
* Scripts/old-run-webkit-tests: Quote the path to DRT before executing
it.
2010-10-20 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Regression in chromium_gpu_unittests after r70175
https://bugs.webkit.org/show_bug.cgi?id=48008
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2010-10-20 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback
https://bugs.webkit.org/show_bug.cgi?id=48005
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2010-10-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch doesn't get along with git rm
https://bugs.webkit.org/show_bug.cgi?id=47940
Turns out we need to pass "--" to tell git this is a path.
* Scripts/webkitpy/common/checkout/scm.py:
2010-10-20 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Fix layoutTestController.getJsObjectCount
Qt Bridge doesn't know size_t so pass result as unsigned int.
Unskip fast/dom/gc-10.html
https://bugs.webkit.org/show_bug.cgi?id=47931
* DumpRenderTree/qt/GCControllerQt.cpp:
(GCController::getJSObjectCount):
* DumpRenderTree/qt/GCControllerQt.h:
2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70149.
http://trac.webkit.org/changeset/70149
https://bugs.webkit.org/show_bug.cgi?id=47989
"Build breaks in mac and win" (Requested by satish on
#webkit).
* DumpRenderTree/LayoutTestController.cpp:
(setMockSpeechInputResultCallback):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setMockSpeechInputResult):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setMockSpeechInputResult):
2010-10-19 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Added a second parameter to setMockSpeechInputResult for
the language used in speech input.
https://bugs.webkit.org/show_bug.cgi?id=47089
* DumpRenderTree/LayoutTestController.cpp:
(setMockSpeechInputResultCallback):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setMockSpeechInputResult):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setMockSpeechInputResult):
2010-10-19 Adam Roben <aroben@apple.com>
Teach update-webkit-support-libs about the new versioning of
WebKitSupportLibrary
Fixes <http://webkit.org/b/47915> update-webkit-support-libs should
check version numbers instead of modification times
Reviewed by Sam Weinig.
* Scripts/update-webkit-support-libs: Fetch the expected version
number from developer.apple.com, then compare with the version number
of the extracted library and of the zipped library to see if anything
needs to be done. Removed code that tracked the modified timestamp of
the library, as it is no longer needed.
2010-10-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
EWS should test patches with r+
https://bugs.webkit.org/show_bug.cgi?id=35460
* QueueStatusServer/handlers/submittoews.py:
* QueueStatusServer/model/queues.py:
* Scripts/webkitpy/tool/bot/patchcollection.py: Removed.
* Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Removed.
* Scripts/webkitpy/tool/commands/queues.py:
2010-10-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach feeder-queue how to feed the EWS bots
https://bugs.webkit.org/show_bug.cgi?id=47943
queues.webkit.org already knew how to accept EWS submissions
via /submit-to-ews. This teaches the feeder queue how to post
to that page with any new r? patches it sees.
* QueueStatusServer/model/activeworkitems_unitest.py: Added.
- More unit testing is always a good thing.
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/common/net/statusserver.py:
* Scripts/webkitpy/tool/bot/feeders.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed, just fixing test-webkitpy. I'm really on a roll today.
commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935
Fix test-webkitpy and unittest NetworkTransaction.
* Scripts/webkitpy/common/net/networktransaction.py:
* Scripts/webkitpy/common/net/networktransaction_unittest.py:
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed.
commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935
Turns out ClientForm gets upset if passed an int() instead of a string type.
Yay for untestable code.
* Scripts/webkitpy/common/net/statusserver.py:
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed. Will get Adam's commentary after his meeting
for now this gets the commit-cluster back running.
commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935
I taught NetworkTransaction the basics of 404 handling.
We'll want to go back and teach it how to handle urllib2 404's too
and then deploy it to the places that want it.
* QueueStatusServer/handlers/releasepatch.py:
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/networktransaction.py:
* Scripts/webkitpy/common/net/statusserver.py:
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed. Fixing typos in my previous commit.
Make patch release explicit and not a magic part of "retry" status
https://bugs.webkit.org/show_bug.cgi?id=47909
All of these typos again due to our inability to unit
test much of this code. I added one unit test where
possible. activeworkitems_unittest.py will be in a separate patch.
* QueueStatusServer/handlers/releasepatch.py:
* QueueStatusServer/main.py:
* QueueStatusServer/model/activeworkitems.py:
* QueueStatusServer/model/workitems.py:
* QueueStatusServer/model/workitems_unittest.py:
* QueueStatusServer/templates/releasepatch.html:
* Scripts/webkitpy/common/net/statusserver.py:
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Use webkit's TestNetscapePlugIn in DRT mac
https://bugs.webkit.org/show_bug.cgi?id=47850
* DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked
because we're going to name our plugin WebKitTestNetscapePlugIn
temporarily until the chromium forked plugin goes away.
2010-10-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make patch release explicit and not a magic part of "retry" status
https://bugs.webkit.org/show_bug.cgi?id=47909
This moves us another step closer to running r+ patches on the EWS bots.
Currently all bots just spam /update-work-items with their list of current
work items. queues.webkit.org uses that data for display. As part of making
the EWS run r+ patches, we're moving the official list of patches-to-process
into the server, and feeding them out to bots one at a time. We need to be
able to remove patches from the queues one at a time instead of just spamming
/update-work-items with a new complete list. That's what this patch adds.
* QueueStatusServer/handlers/nextpatch.py:
* QueueStatusServer/handlers/queuestatus.py:
* QueueStatusServer/handlers/releasepatch.py: Added.
* QueueStatusServer/handlers/statusbubble_unittest.py:
- Fix a typo causing test failure. This was not caught by the bots
because they don't have AppEngineLauncher installed and thus don't run
the QueueStatusServer tests.
* QueueStatusServer/handlers/updatestatus.py:
* QueueStatusServer/model/activeworkitems.py:
* QueueStatusServer/templates/releasepatch.html: Added.
* Scripts/webkitpy/common/net/statusserver.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-10-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
cr-mac bubble has caused status bubbles to wrap
https://bugs.webkit.org/show_bug.cgi?id=47928
We now have too many EWSes to fit in the bugs.webkit.org
status-bubble iframe when more than a couple EWS builds are pending.
To fix this I've reduced the space taken up by queue position,
and also moved cr-mac to the end of the list (since it's going to be
triple-digits for a while).
* QueueStatusServer/model/queues.py:
* QueueStatusServer/templates/statusbubble.html:
2010-10-19 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
https://bugs.webkit.org/show_bug.cgi?id=47874
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] DumpRenderTree shouldn't put '.' in include path
https://bugs.webkit.org/show_bug.cgi?id=47877
Fix include paths.
* DumpRenderTree/chromium/AccessibilityController.cpp:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/chromium/CppBoundClass.cpp:
* DumpRenderTree/chromium/CppVariant.cpp:
* DumpRenderTree/chromium/CppVariant.h:
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
* DumpRenderTree/chromium/DRTDevToolsClient.h:
* DumpRenderTree/chromium/EventSender.cpp:
* DumpRenderTree/chromium/EventSender.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/MockSpellCheck.cpp:
* DumpRenderTree/chromium/NotificationPresenter.cpp:
* DumpRenderTree/chromium/NotificationPresenter.h:
* DumpRenderTree/chromium/PlainTextController.cpp:
* DumpRenderTree/chromium/Task.cpp:
* DumpRenderTree/chromium/TestNavigationController.h:
* DumpRenderTree/chromium/TestShell.cpp:
* DumpRenderTree/chromium/TestWebWorker.h:
* DumpRenderTree/chromium/TextInputController.cpp:
* DumpRenderTree/chromium/WebPreferences.cpp:
* DumpRenderTree/chromium/WebPreferences.h:
* DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
* DumpRenderTree/chromium/WebThemeEngineDRT.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
2010-10-19 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Need to include WKErrorRef in the WKPageDidFail... functions
https://bugs.webkit.org/show_bug.cgi?id=47871
Update tools for new parameter in failure callbacks.
* MiniBrowser/mac/BrowserWindowController.m:
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
* TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] WebKit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47897
Qt WebKit2 MacOS build fix.
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/qt/TestControllerQt.cpp:
2010-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch stats the filesystem too many times
https://bugs.webkit.org/show_bug.cgi?id=47883
This patch attempts to cache the list of changed files more agressively
and to use that list to compute the diff instead of stating the file
system again.
* Scripts/webkitpy/common/checkout/api.py:
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/editchangelog.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
2010-10-19 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly
Reviewed by Darin Adler.
* Scripts/sort-Xcode-project-file:
- Don't print an error message about missing arguments when
-h|--help is used.
- Allow Xcode project files to be specified as Project.xcodeproj
instead of Project.xcodeproj/project.pbxproj.
2010-10-18 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Andreas Kling.
[Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
https://bugs.webkit.org/show_bug.cgi?id=47809
Connecting a call to load from the loadFinished signal can cause
re-entrance crashes in WebCore. This patch uses a timer to do so,
also giving some time to subsequent frames to finish loading.
* QtTestBrowser/urlloader.cpp:
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::checkIfFinished):
(UrlLoader::frameLoadStarted):
(UrlLoader::frameLoadFinished):
* QtTestBrowser/urlloader.h:
2010-10-19 Sergio Villar Senín <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/history tests are failing
https://bugs.webkit.org/show_bug.cgi?id=36173
Clear the history each time a test is run. Return the actual
history item count when calling
LayoutTestController::webHistoryItemCount
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::webHistoryItemCount):
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Chromium Mac EWS to the list of queues at queues.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=47878
* QueueStatusServer/model/queues.py:
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queues.webkit.org/next_patch is always 404
https://bugs.webkit.org/show_bug.cgi?id=47881
With the addition of the Queue class, I changed most of the
code to lookup WorkItems using get_or_insert with a key_name
instead of WorkItems.all().filter(queue_name=).
Because the new get_or_insert code uses an explicit key_name
(which is obviously different from the previously autogenerated
ones), there were new WorkItem records created for each queue.
However, some parts of the code still use WorkItems.all().filter,
thus some parts were getting the new record and some parts the old record.
The same basic bug was occurring with ActiveWorkItems, because I
changed the key_name for that class as well.
To fix this I've moved more of the code over to using Queue.*work_items.
I've also enabled the datastore_admin (new in GAE 1.3.8) so that
we can go delete the old WorkItems records.
I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).
* QueueStatusServer/app.yaml:
* QueueStatusServer/handlers/queuestatus.py:
* QueueStatusServer/handlers/recentstatus.py:
* QueueStatusServer/handlers/updatestatus.py:
* QueueStatusServer/handlers/updateworkitems.py:
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Correct a bunch of typos in QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47880
These are all due to our complete lack of unit testing in QueueStatusServer.
I added a couple unit tests to cover a few of these fixes, but most of these
are still only caught by actually running the application.
* QueueStatusServer/handlers/nextpatch.py:
* QueueStatusServer/handlers/statusbubble.py:
* QueueStatusServer/handlers/statusbubble_unittest.py: Added.
* QueueStatusServer/handlers/updateworkitems.py:
* QueueStatusServer/model/attachment.py:
* QueueStatusServer/model/queuepropertymixin.py:
* QueueStatusServer/model/queuepropertymixin_unittest.py:
* QueueStatusServer/model/workitems.py:
* QueueStatusServer/model/workitems_unittest.py: Added.
2010-10-18 Adam Barth <abarth@webkit.org>
Disable this test because it's failing on the bots and the authors
aren't around to fix it.
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CC authors of flaky tests when the commit-queue hits a flaky test
https://bugs.webkit.org/show_bug.cgi?id=47872
* Scripts/webkitpy/common/checkout/api.py:
* Scripts/webkitpy/common/net/layouttestresults.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to run a chromium-mac-ews builder
https://bugs.webkit.org/show_bug.cgi?id=47876
Since we can't run Mac OS X in a VM, we need to only run committer patches.
There was a multiple inheritance problem which was holding this patch back,
but I decided to just ignore the problem and go with a functional hack for now.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Tony Chang.
Regression in run_webkit_tests_unittest from r70017
https://bugs.webkit.org/show_bug.cgi?id=47875
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement webkit-patch suggest-reviewers
https://bugs.webkit.org/show_bug.cgi?id=47866
* Scripts/webkitpy/common/checkout/api.py:
- The main logic. We look at the last five changes to each
modified (non-ChangeLog) file and collect up the reviewers of
those changes as well as the authors of those changes who are
reviewers.
* Scripts/webkitpy/common/checkout/api_unittest.py:
- Test the logic with some fun mocks.
* Scripts/webkitpy/common/checkout/scm.py:
- Fix a bug when you have local git commits.
* Scripts/webkitpy/common/checkout/scm_unittest.py:
- Test that the bug is fixed.
* Scripts/webkitpy/tool/commands/queries.py:
- Add the query.
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867
* Scripts/webkitpy/layout_tests/port/base.py:
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to submit patches to the EWS bots
https://bugs.webkit.org/show_bug.cgi?id=47869
* QueueStatusServer/handlers/nextpatch.py:
- Move more logic into Queue, so that it can be shared with SubmitToEWS.
* QueueStatusServer/handlers/queuestatus.py:
- Fix two typos from a previous commit.
* QueueStatusServer/handlers/submittoews.py: Added.
* QueueStatusServer/handlers/updatestatus.py:
- Use the new is_retry_request method to share this (hacky) code with SubmitToEWS
* QueueStatusServer/main.py:
- Add /submit-to-ews
* QueueStatusServer/model/queuepropertymixin.py:
- Fix circular imports caused by adding Queue.work_items()
* QueueStatusServer/model/queues.py:
- Add work_items() and active_work_items()
* QueueStatusServer/model/queuestatus.py:
* QueueStatusServer/model/workitems.py:
- Add transaction-safe add/remove methods.
* QueueStatusServer/templates/submittoews.html: Added.
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Deploy Queue class in more places throughout QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47855
I also caught two typos from the previous change. Unfortunately
I don't yet know how to unittest request handlers yet.
* QueueStatusServer/handlers/dashboard.py:
* QueueStatusServer/handlers/statusbubble.py:
* QueueStatusServer/handlers/updateworkitems.py:
* QueueStatusServer/model/activeworkitems.py:
* QueueStatusServer/model/attachment.py:
* QueueStatusServer/model/queuepropertymixin.py: Added.
* QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
* QueueStatusServer/model/queuestatus.py:
* QueueStatusServer/model/workitems.py:
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
scm.py should be able tell us what revisions made changes to a given file
https://bugs.webkit.org/show_bug.cgi?id=47863
Look again, your SCM.py can now log files.
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
2010-10-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
new-run-webkit-tests: clean up the options-parsing code in the port
classes.
This change modifies the Port interface to have a get_option() and
set_option_default() method for accessing the options argument
passed to the constructor. If the constructor is not passed an
options argument, we default to a MockOptions() argument from
mocktool, which has the same semantics we want.
Note that there is a disadvantage to port.get_option('foo') over
port._options.foo, which is that you lose some of the checking
for whether 'foo' is set (typos result in the default value, not
an exception being raised. This is desired in this case, since the
Port class is not allowed to assume that options does have any
particular values set, and so this change ensures that all of
the subclasses are following the same, intended, logic.
Arguably this is the wrong semantics to have, and the Port
classes should be able to assume a default set of
attributes/arguments, but that change will need to wait for a
different CL where we can modify new-run-webkit-tests to pull a
list of arguments from the port factory routines.
Also, add unit tests for webkitpy.tool.mocktool.MockOptions .
https://bugs.webkit.org/show_bug.cgi?id=47510
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
* Scripts/webkitpy/tool/mocktool_unittest.py: Added.
2010-10-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Re-submit a revised version of r69638 - enabling new-run-webkit-tests
under cygwin. The initial version had a bug in base:uri_to_test_name
that was causing tests to fail. This version corrects that bug, but
also makes the code safer by calling cygpath more reliably, and
leaving a long-running cygpath process open.
This patch also corrects a couple of minor bugs in http_lock_unittest,
chromium_unittest, and dedpulicate_tests_unittest that showed up
while testing this.
https://bugs.webkit.org/show_bug.cgi?id=47220
* Scripts/webkitpy/common/system/path.py:
* Scripts/webkitpy/common/system/path_unittest.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Queue class and add minimal unittesting of QueueStatusServer code
https://bugs.webkit.org/show_bug.cgi?id=47847
* QueueStatusServer/handlers/dashboard.py:
* QueueStatusServer/handlers/queuestatus.py:
* QueueStatusServer/handlers/recentstatus.py:
* QueueStatusServer/handlers/statusbubble.py:
* QueueStatusServer/handlers/updateworkitems.py:
* QueueStatusServer/model/attachment.py:
* QueueStatusServer/model/queues.py:
* QueueStatusServer/model/queues_unittest.py: Added.
* QueueStatusServer/model/svnrevision.py:
* Scripts/test-webkitpy:
* Scripts/webkitpy/test/main.py:
2010-10-18 Anders Carlsson <andersca@apple.com>
Fix build.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventCarbon):
2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Eric Seidel.
Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.
https://bugs.webkit.org/show_bug.cgi?id=40784
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventCarbon):
2010-10-18 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
check-webkit-style should treat the GObject binding directory like other GTK directories.
https://bugs.webkit.org/show_bug.cgi?id=47796
* Scripts/webkitpy/style/checker.py: Added the GObject binding directory
with the other gtk directories (and fixed typo).
2010-10-18 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
check-webkit-style needs to ignore underscores in opcode names and vm_throw
https://bugs.webkit.org/show_bug.cgi?id=47789
* Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
* Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
2010-10-18 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659
Moved hasSpellingMarkers() from TextInputController to
LayoutTestController. Currently the implementation is available
only for Mac and for Chromium.
* DumpRenderTree/LayoutTestController.cpp:
(hasSpellingMarkerCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::hasSpellingMarker):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/TextInputController.cpp:
(TextInputController::TextInputController):
(TextInputController::makeAttributedString):
* DumpRenderTree/chromium/TextInputController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::hasSpellingMarker):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::hasSpellingMarker):
* DumpRenderTree/mac/TextInputController.m:
(+[TextInputController isSelectorExcludedFromWebScript:]):
(+[TextInputController webScriptNameForSelector:]):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::hasSpellingMarker):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::hasSpellingMarker):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::hasSpellingMarker):
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
commit-queue's flaky test notice is very Pythony
https://bugs.webkit.org/show_bug.cgi?id=47790
This patch make the list of tests delimted by \n instead of just
converting the array to a string.
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-10-14 Antonio Gomes <agomes@rim.com>
Reviewed by Martin Robinson and Xan Lopez.
[Gtk]: DRT does not support frame flattening testing
https://bugs.webkit.org/show_bug.cgi?id=38650
Implement DRT's support for toggling on/off frame flattening
support.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setFrameFlatteningEnabled):
2010-10-15 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
mocktool.MockOptions is inheriting from Mock, which has the side
effect of defaulting any attribute to another MockObject. So,
MockOptions().foo would always evaluate to true. This was
covering over bugs in the unit tests, and is probably the wrong
default behavior for anything attempting to mock out the options
argument returned from optparse.parse_args().
This patch changes the default behavior. The new MockOptions()
class takes an optional list of keyword parameters to set; this
patch doesn't use that feature but the fix for bug 47510 will.
Also, this patch just fills in the default values necessary to
get all of the tests to pass; I didn't stare at each test by
hand to determine the "right" values. We can either fix that in
subsequent patches or let me know if we want to do that now (and
give me some guidance on what those values might want to be).
https://bugs.webkit.org/show_bug.cgi?id=47709
* Scripts/webkitpy/tool/commands/commandtest.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2010-10-15 Simon Fraser <simon.fraser@apple.com>
Fix the build; need to add new slot to PageUIClient callbacks.
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
2010-10-15 Simon Fraser <simon.fraser@apple.com>
Add Matt Delaney to committers.py.
* Scripts/webkitpy/common/config/committers.py:
2010-10-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633
* DumpRenderTree/DumpRenderTree.gypi: files to compile
* DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
(NP_GetEntryPoints):
(NPP_New):
(NPP_Destroy):
(NPP_HandleEvent):
(NPP_GetValue):
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
2010-10-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
build-webkit: Should die when make fails when build a CMake project
https://bugs.webkit.org/show_bug.cgi?id=47726
* Scripts/webkitdirs.pm: If make fails, die immediately.
2010-10-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69809.
http://trac.webkit.org/changeset/69809
https://bugs.webkit.org/show_bug.cgi?id=47725
Broke chromium mac compile (Requested by japhet on #webkit).
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NP_GetEntryPoints):
(NPP_New):
(NPP_Destroy):
(NPP_HandleEvent):
(NPP_GetValue):
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
2010-10-15 Adam Barth <abarth@webkit.org>
Reviewed by Adam Barth.
test-webkitpy fails on Linux
https://bugs.webkit.org/show_bug.cgi?id=47713
The old code failed on Linux because the MacPort tries to read
something out of platform that doesn't make sense on Linux.
* Scripts/webkitpy/tool/mocktool.py:
2010-10-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WTR is sloooow
https://bugs.webkit.org/show_bug.cgi?id=47695
* WebKitTestRunner/qt/TestControllerQt.cpp:
Change the timer interval of RunUntilConditionLoop from
50 milliseconds to 1 to avoid wasting time after the
test had been finished.
2010-10-14 Eric Seidel <eric@webkit.org>
Unreviewed, just fixing an exception seen on the commit-queue.
I should have unit tested this function before.
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-10-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should not fail patches due to flaky tests
https://bugs.webkit.org/show_bug.cgi?id=47647
This patch makes it so that the *same* flaky test has to fail
twice in a row to have a false negative from a flaky test.
If different flaky tests fail (or if a test fails and then passes
in a second run) then we will warn in the bug that we encountered
a flaky test.
This patch grew to include moving port off of steps onto tool
(which Adam wrote and then I integrated), as well as removing the
use of tool from CommitQueueTask.
* Scripts/webkitpy/common/config/ports.py:
- Added a layout_test_results_path method. This covers old-run-webkit-tests
but doesn't cover NRWT. This is probably not the long term solution, but
putting this knowledge on port makes more sense than in LayoutTestResults.
* Scripts/webkitpy/common/net/buildbot.py:
- LayoutTestResults shouldn't know how to fetch from the network, make
the Build code do that instead.
* Scripts/webkitpy/common/net/buildbot_unittest.py:
- Code style fix.
* Scripts/webkitpy/common/net/layouttestresults.py:
- Remove code for reading from the network.
* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- Test the new entrypoint.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Make the delegate interface explicit.
- Remove the _tool member, since using the delegate for
everything is cleaner.
- Teach the testing logic how to deal with flaky tests.
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Update to match the CommitQueueTask changes.
* Scripts/webkitpy/tool/commands/queues.py:
- Use the new CommitQueueTaskDelegate interface.
* Scripts/webkitpy/tool/commands/queues_unittest.py:
- Fix the SecondThoughtsCommitQueue test which was broken.
- Add a new test to make sure the flaky test reporting works.
* Scripts/webkitpy/tool/main.py:
- Store the port on the tool object.
* Scripts/webkitpy/tool/mocktool.py:
- Add a port() accessor to MockTool
* Scripts/webkitpy/tool/steps/abstractstep.py:
- Move port() off of Step and onto Tool.
* Scripts/webkitpy/tool/steps/build.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
- Two tests with the same name! only the latter was being run.
* Scripts/webkitpy/tool/steps/update.py:
2010-10-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests will now handle missing Ruby installs (or
missing PrettyPatch scripts) more cleanly - previously this
would be detected when we actually tried to create the diff, and
the error message was obscure. Now we'll log a warning up front
and otherwise be silent.
This change also refactors some global variables to be class or
instance variables to be slightly more testable and more
modular. There are no cases where we create lots of port objects
and can't afford to test for configurations repeatedly, so
there's no performance concern here.
https://bugs.webkit.org/show_bug.cgi?id=47466
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
2010-10-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Form controls do not respect GTK+ font size
https://bugs.webkit.org/show_bug.cgi?id=47134
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings): Initialize the font control size when running
DumpRenderTree to a standard value.
2010-10-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633
* DumpRenderTree/DumpRenderTree.gypi: files to compile
* DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
(NP_GetEntryPoints):
(NPP_New):
(NPP_Destroy):
(NPP_HandleEvent):
(NPP_GetValue):
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
2010-10-14 Victor Wang <victorw@chromium.org>
Reviewed by Nate Chapin.
[Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.
https://bugs.webkit.org/show_bug.cgi?id=47686
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2010-10-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
test-webkitpy spews Delegate terminated queue messages
https://bugs.webkit.org/show_bug.cgi?id=47678
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2010-10-14 Adam Roben <aroben@apple.com>
Test that pressing the Alt key generates a WM_SYSCOMMAND message
Test for <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
the Alt key when MiniBrowser's WKView is focused doesn't send focus to
the menu bar
Reviewed by Steve Falkenburg.
* TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added
TestWebKitAPI/win to the include path so that WindowMessageObserver
can be found.
* TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and
Windows-specific members.
(TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
Added this simple setter.
* TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.
(TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
Initialize our lone data member.
(TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
Simple getter.
(TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
when a WM_SYSCOMMAND message is received.
(TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
WM_SYSKEYUP message is not handled.
(TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
pressing the Alt key and check that a WM_SYSCOMMAND message got sent
to the WKView's parent window.
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
member function so it could access PlatformWebView::wndProc. Use
PlatformWebView::wndProc as the WNDPROC.
(TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
data member and pass the this pointer to CreateWindowEx so we can
store it on the HWND.
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
constants from here to the top of the file.
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
the same messages that Notepad receives when you press the Alt key.
(TestWebKitAPI::PlatformWebView::wndProc): Added.
- When WM_CREATE is received, we set the PlatformWebView instance
pointer as a property on the HWND so we can access it later.
- For other messages, we try to get the PlatformWebView instance
pointer from the HWND property.
- When WM_NCDESTROY is received (which is the last message we will
receive), we remove the PlatformWebView instance property.
- Pass messages to the parent window's message observer, if there is
one.
- Pass all messages through to ::DefWindowProcW.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver
and AltKeyGeneratesWMSysCommand.
* TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be
used to observe messages sent to one or more windows.
2010-10-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Holger Freyther.
[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
https://bugs.webkit.org/show_bug.cgi?id=47033
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings): Added this method which initializes XSettings
font settings to consistent values before running a test. For the one test
in which we need subpixel aliasing turned on, do that.
(initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings.
(runTest): Pass the testURL to initializeFonts.
2010-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
https://bugs.webkit.org/show_bug.cgi?id=47655
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:
2010-10-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
beat diff_parser with the ugly stick
https://bugs.webkit.org/show_bug.cgi?id=47626
* Scripts/webkitpy/common/checkout/diff_parser.py:
* Scripts/webkitpy/style/patchreader.py:
* Scripts/webkitpy/style/patchreader_unittest.py:
2010-10-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Break LayoutTestResults out into its own file
https://bugs.webkit.org/show_bug.cgi?id=47637
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/buildbot_unittest.py:
* Scripts/webkitpy/common/net/layouttestresults.py: Added.
* Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
2010-10-13 Adam Barth <abarth@webkit.org>
Unreviewed.
Chromium port can't run JavaScriptCore tests
https://bugs.webkit.org/show_bug.cgi?id=47654
This lets webkit-patch build-and-test work on Chromium.
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/tool/steps/runtests.py:
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make --port a global option and pass the port information to the commit-queue subprocess
https://bugs.webkit.org/show_bug.cgi?id=47650
This patch paves the way to run the commit-queue on a non-Mac port.
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/tool/steps/options.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/update.py:
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Introduce the ChromiumXVFBPort for running commit-queue on EC2
https://bugs.webkit.org/show_bug.cgi?id=47653
I'm not entirely sure this is the best way to do this, but we need to
run the tests under XVFB on EC2 because the EC2 instances don't have a
real monitor hooked up. This patch adds a ChromiumXVFBPort that runs
that way. The idea is that XVFB is like a platform for the Chromium
port, but we don't have a real notion of platform separate from port.
* Scripts/webkitpy/common/config/ports.py:
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
Add include paths for the new soup HTTP cache code.
* GNUmakefile.am: Add paths for the new soup HTTP cache code.
2010-10-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Antonio Gomes.
[Qt] QtTestBrowser shows two Url input fields
https://bugs.webkit.org/show_bug.cgi?id=47613
* QtTestBrowser/mainwindow.cpp:
(MainWindow::MainWindow):
(MainWindow::buildUI):
2010-10-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tony Chang.
[gdb] Add pretty-print supports for UString, Identifier and JSString
https://bugs.webkit.org/show_bug.cgi?id=47601
* gdb/webkit.py:
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add list of Ubuntu packages needed by the EWS bots
https://bugs.webkit.org/show_bug.cgi?id=47628
I've been copy/pasting this list between bots, but it's better to have
this checked in.
* EWSTools/ubuntu-ews-packages: Added.
2010-10-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Csaba Osztrogonác.
[EFL] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=47290
* BuildSlaveSupport/build.webkit.org-config/config.json: Add an
entry for a release build of the EFL port.
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
flag to build the EFL port.
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Csaba Osztrogonác.
webkit-patch build shouldn't need --build to actually build!
https://bugs.webkit.org/show_bug.cgi?id=47438
Yeah, requiring --build for the build command is really dumb. We did
this originally because the build step is usually optional in other
commands. We don't have a good way of reversing the default for an
option in one command. This approach is slightly hacky since --build
still shows up as an option on the help page, but at least it makes
progress. Passing --build is harmless, so the EWS bots shouldn't
explode because of this change.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-10-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69638.
http://trac.webkit.org/changeset/69638
https://bugs.webkit.org/show_bug.cgi?id=47595
"Broke win and chromium-win bots" (Requested by dglazkov on
#webkit).
* Scripts/webkitpy/common/system/path.py:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-10-13 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
First step towards client-based Geolocation in Chromium. Build
fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
https://bugs.webkit.org/show_bug.cgi?id=47586
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
2010-10-13 Adam Roben <aroben@apple.com>
Test that pressing the spacebar in a text field does not scroll the
document
Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
REGRESSION: Pressing spacebar in a text field in WebKit2 does not
insert a space, scrolls the page instead
Reviewed by Sam Weinig.
* TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
* TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/copy-resources.cmd:
Added new files.
* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
(TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
We use this to track what the result of calling into JavaScript was.
(TestWebKitAPI::didFinishLoadForFrame): Records when the page
finishes loading.
(TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
event is not handled.
(TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
executing and whether the result matched our expectation.
(TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
(TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
complete, and returns whether we got back the expected result.
(TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
spacebar inside a text field does not scroll the document and that
pressing it outside the text field does scroll the document.
* TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::isKeyDown): Checks the event's type.
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
code from DRT's EventSendingController.
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::isKeyDown): Checks the message's type.
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
same messages that get sent when you press spacebar in Notepad.
2010-10-13 Adam Roben <aroben@apple.com>
Fix a couple of issues with the TestWebKitAPI build
* TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
* TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
Fixed a typo.
* TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
to set our output and intermediate directories so that we don't spew
files into the source tree.
2010-10-13 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
WTR should accept relative paths
https://bugs.webkit.org/show_bug.cgi?id=47486
* WebKitTestRunner/StringFunctions.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::createWKURL): Moved from StringFunctions.h since it is
used only here. Extend relative paths to absolute.
2010-10-12 Adam Roben <aroben@apple.com>
Make TestWebKitAPI work on Windows
Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
Reviewed by Sam Weinig.
* Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
* Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
run on Windows.
(runTest): Added code to run TestWebKitAPI.exe on Windows and to die
on unsupported platforms.
(populateTests): Added code to run TestWebKitAPI.exe on Windows and to
die on other platforms. Extracted some formerly-Mac-specific code to
be cross-platform and made it handle any style of line-endings.
* TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
Links against CFLite.
* TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
Contains most properties for the project.
* TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
Added. Links against CoreFoundation.
* TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
section and moved the cross-platform section after the
platform-specific parts.
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
(TestWebKitAPI::Util::run): Runs a normal message pump until we're
done.
(TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
(TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
resource path.
(TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
WKURL.
* TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
(TestWebKitAPI::registerWindowClass):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
This was mostly copied from WebKitTestRunner's PlatformWebView.
* TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
build-api-tests script.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
TestWebKitAPI.exe.
* TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
through to copy-resources.cmd.
* TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
or deletes resources from TestWebKitAPI.resources.
* TestWebKitAPI/win/main.cpp: Added.
(main): Calls through to TestsController.
2010-10-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Support viewport configuration and add new arguments for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=47084
Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
needs to be modified according to the changes.
* EWebLauncher/main.c:
(on_viewport_changed):
2010-10-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
This patch enables new-run-webkit-tests (in particular the
chromium-win port) to run under Cygwin as well as Win32. Mostly
this just required some conversions from cygwin paths to Win32
paths when we spawn off Win32 binaries like test_shell.
https://bugs.webkit.org/show_bug.cgi?id=47220
* Scripts/webkitpy/common/system/path.py:
- Expose the cygpath() function for path conversion
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- shift filename->uri conversion in the TestInfo objects to the
dump_render_tree thread
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
- use cygpath()
2010-10-12 Yuta Kitamura <yutak@chromium.org>
Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-10-12 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
When a provisional load fails, the provisional URL returned
from WKFrameCopyProvisionalURL should be empty
<rdar://problem/8540878>
https://bugs.webkit.org/show_bug.cgi?id=47546
Add test.
* TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2010-10-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Start fleshing out find page overlays
https://bugs.webkit.org/show_bug.cgi?id=47559
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController find:]):
Pass kWKFindOptionsShowOverlay to WKPageFindString.
2010-10-12 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] editing/input/emacs-ctrl-o.html
ctrl-o is bound to a sequence of commands on Mac, namely:
insertParagraphSeparator then moveLeft. In the DRT, we just interpret
ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
result we only issue one command, so don't generate the change in caret
position that results in the extra editing delegate messages.
So for the sake of not managing suspicious-looking differences, just
make DRT issue the appropriate edit commands to pass the test.
https://bugs.webkit.org/show_bug.cgi?id=47548
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::keyDown):
2010-10-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a simple Find UI to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=47553
* MiniBrowser/mac/BrowserWindow.xib:
Add Find panel.
* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController performFindPanelAction:]):
Show the find panel.
(-[BrowserWindowController find:]):
Tell the WKPageRef to find the given string.
2010-10-12 Tony Chang <tony@chromium.org>
Unreviewed, fixing DRT compile on Windows after r69586.
* DumpRenderTree/chromium/WebThemeEngineDRT.h:
2010-10-12 Tony Chang <tony@chromium.org>
Unreviewed, trying to fix NRWT on Windows.
* Scripts/webkitpy/layout_tests/port/http_lock.py:
2010-10-12 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WTR] Checking the path of the injected bundle is bogus
https://bugs.webkit.org/show_bug.cgi?id=47541
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::isExistingLibrary): Added (static helper).
Extend the path with the appropriate suffix(es) on the
platform and check that the file exists.
(WTR::TestController::initializeInjectedBundlePath):
There were two bugs with the path checking:
- the condition should have been inverted
- QLibrary::fileName does not give back the filename
with the library suffix so we cannot check
that existance of the file this way.
2010-10-12 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Tony Chang.
Implement http locking in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=47072
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-10-12 Mark Rowe <mrowe@apple.com>
Fix the 32-bit WebKit2 build.
* MiniBrowser/mac/BrowserWindowController.m:
(getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
(setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
2010-10-11 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
https://bugs.webkit.org/show_bug.cgi?id=47513
bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
which doesn't actually work.
* Scripts/webkitpy/common/config/committers.py:
2010-10-11 Prasad Tammana <prasadt@chromium.org>
Reviewed by Dmitry Titov.
Added support for showModalDialog on chromium port.
Implement showModalDialog for Layout tests for chromium port
https://bugs.webkit.org/show_bug.cgi?id=46759
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
(WebViewHost::runModal): Start a nested message loop and remember that.
(WebViewHost::WebViewHost): Initialize m_inModalLoop.
* DumpRenderTree/chromium/WebViewHost.h: Add m_inModalLoop.
2010-10-11 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Cleanup font selection code for the Freetype backend
https://bugs.webkit.org/show_bug.cgi?id=47503
Update DRT to set values for the cursive and fantasy font families, so
that we can generate consistent results for tests that use these families.
Add some missing information to fonts.conf.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Always set the fantasy and cursive font
family names.
* DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
to our default serif font. Eventually we may want to import or require some "real"
fonts, but this should at least ensure consistent rendering during test runs. Also
add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
Finally, add a missing oblique specification for DejaVu Serif, which was resulting
in some incorrect baselines for the synthetic oblique test.
2010-10-11 Adam Barth <abarth@webkit.org>
Unreviewed.
Fix sheriffbot not to crash when there are failing tests. It turns out
Python sets don't support the + operator. We need to use union
instead. There's a more elegant way to do this in Python 2.6, but we
need this code to work in 2.5.
* Scripts/webkitpy/common/net/failuremap.py:
* Scripts/webkitpy/common/net/failuremap_unittest.py:
2010-10-10 Robert Hogan <robert@webkit.org>
Unreviewed, fix failing test from r69468.
[Qt] Put all DRT-created pages in a page group
Fix on r69468.
Because we don't delete closed pages immediately in DRT we need
to remove them from the page group explicitly instead.
Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
https://bugs.webkit.org/show_bug.cgi?id=47469
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::windowCloseRequested):
2010-10-10 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Adam Barth.
commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
EFL-EWS bot is up and running.
https://bugs.webkit.org/show_bug.cgi?id=47277
* QueueStatusServer/handlers/statusbubble.py:
2010-10-10 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Put all DRT-created pages in a page group
https://bugs.webkit.org/show_bug.cgi?id=47469
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::createWindow):
2010-10-09 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
<rdar://problem/8173667>
https://bugs.webkit.org/show_bug.cgi?id=47461
* TestWebKitAPI/PlatformUtilities.h:
* TestWebKitAPI/Test.h:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
(TestWebKitAPI::TEST):
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::URLForNonExistentResource):
Adds a test for the frame load state after a failed provisional load. I wanted to test
the frame load state after a committed load failed, but I don't believe that is possible
to do without hooking up the http server to serve a long loading page.
2010-10-09 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
<rdar://problem/8447690>
https://bugs.webkit.org/show_bug.cgi?id=47459
* MiniBrowser/mac/BrowserWindowController.m:
(runBeforeUnloadConfirmPanel):
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
2010-10-09 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Need implementation of ChromeClient windowRect related functions.
<rdar://problem/8469476>
https://bugs.webkit.org/show_bug.cgi?id=47386
* MiniBrowser/mac/BrowserWindowController.m:
(getWindowFrame):
(setWindowFrame):
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
2010-10-08 Adam Barth <abarth@webkit.org>
Unreviewed (Eric is on vacation in this change is trivial).
Add a "clean" command to webkit-patch to clean the working directory
https://bugs.webkit.org/show_bug.cgi?id=47436
This command is useful when using SVN because "svn revert" leaves
unversioned files behind.
* Scripts/webkitpy/tool/commands/download.py:
2010-10-08 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt] Add missing limits.h include since the Qt version currently
ran on the bot does need that.
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2010-10-08 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Turn on building WTR
https://bugs.webkit.org/show_bug.cgi?id=47349
* Scripts/webkitdirs.pm:
2010-10-08 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt] TestController needs its platform dependent methods
https://bugs.webkit.org/show_bug.cgi?id=47413
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::initializeInjectedBundlePath):
If the WTR_INJECTEDBUNDLE_PATH environmental variable is
set then use that otherwise use the path where the bundle
lives in a normal trunk build.
(WTR::TestController::initializeTestPluginDirectory):
Set the bundle's value. It is not used currently.
(WTR::TestController::platformInitializeContext):
* WebKitTestRunner/qt/WebKitTestRunner.pro:
2010-10-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
WTR: Prevent sending the Done message twice on test timeout.
https://bugs.webkit.org/show_bug.cgi?id=47410
When InjectedBundle::done() calls stopLoading, this may trigger
InjectedBundlePage::didFailLoadWithErrorForFrame which calls
InjectedBundle::done() itself later in the stack.
This would output the timeout failure message twice and confuse
the run-webkit-tests script.
This patch adds a third state, Stopping, which prevents WebCore
errors to trigger done() when testing is over.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::done):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2010-10-08 Andras Becsi <abecsi@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
Original code by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=47402
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
(WTR::activateFonts):
2010-10-08 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=47401
* Scripts/build-webkittestrunner:
* Scripts/old-run-webkit-tests:
2010-10-07 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WTR first compile: fix compile issues.
https://bugs.webkit.org/show_bug.cgi?id=47343
* WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
* WebKitTestRunner/TestController.cpp:
* WebKitTestRunner/TestInvocation.cpp:
2010-10-07 Antonio Gomes <agomes@rim.com>
Reviewed by Simon Fraser.
[Mac] [DRT] implement setSpatialNavigationEnabled
https://bugs.webkit.org/show_bug.cgi?id=47291
Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
so it can track regression on the existing implementation and future improvements
we are making.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setSpatialNavigationEnabled):
2010-10-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
rebaseline-chromium-webkit-tests relied on the filename_to_uri()
hook in the Port infrastructure to generate URIs for the files
in its summary HTML report; however, that method is supposed to only
be used for test files (and should really be renamed), so this would
crash.
This change adds a new "path" module to the system package with a
routine called abspath_to_uri() that handles converting paths to
file: URIs independently of anything in the layout_tests package,
and changes the code to use this. At some point in the near future
the layout_tests/port/* code should use this as well.
This change also deletes a bunch of unused code and fixes some
comments in rebaseline_chromium_webkit_tests.py.
https://bugs.webkit.org/show_bug.cgi?id=47319
* Scripts/webkitpy/common/system/path.py: Added.
* Scripts/webkitpy/common/system/path_unittest.py: Added.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2010-10-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216
Fix my latest commit, as it contained some bad changes from a merge gone wrong.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeFonts): Also initialize the DevaVu Sans font.
2010-10-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=47227
Update DRT to use the renamed methods.
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::beginDragWithFiles):
* DumpRenderTree/chromium/WebViewHost.cpp:
(addDRTFakeFileToDataObject):
2010-10-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a WKPageFindClient, hook up WKPageCountStringMatches
https://bugs.webkit.org/show_bug.cgi?id=47373
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Remove hard coded paths.
* TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
(TestWebKitAPI::TEST):
Fix expected result.
* TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didCountStringMatches):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/find.html: Added.
Add test for WKPageCountStringMatches.
2010-09-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Chris Fleizach.
[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216
* DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
for DejaVu Serif when there is no bold version available. This is necessary to
properly test the property in layout tests.
2010-10-07 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>, Andras Becsi <abecsi@webkit.org>, Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add WTR's InjectedBundle build files.
https://bugs.webkit.org/show_bug.cgi?id=47333
* Scripts/webkitdirs.pm:
* WebKitTestRunner/DerivedSources.pro: Added.
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
* WebKitTestRunner/WebKitTestRunner.pro: Added.
* WebKitTestRunner/qt/DerivedSources.pro: Removed.
Content merged in ../DerivedSources.pro
2010-10-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69315.
http://trac.webkit.org/changeset/69315
https://bugs.webkit.org/show_bug.cgi?id=47363
Forgot to add the new files (Requested by kbalazs on #webkit).
* Scripts/webkitdirs.pm:
* WebKitTestRunner/qt/DerivedSources.pro: Added.
2010-10-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Change API tester to ask the executable for the list of all
tests instead of relying on the directory structure.
https://bugs.webkit.org/show_bug.cgi?id=47359
* Scripts/run-test-webkit-api: Added.
* Scripts/webkitdirs.pm:
Add additional script to just launch the api tester with the correct settings.
* Scripts/run-api-tests:
Change to use the new --dump-tests options to build the list of tests and change
output to reflect a (suite, testcase) tuple for each test. Also adds some color.
* TestWebKitAPI/Test.h:
(TestWebKitAPI::Test::Register::Register):
* TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/WKString.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
(TestWebKitAPI::TEST):
Give each test a suite name in addition to the test name.
* TestWebKitAPI/TestsController.cpp:
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
* TestWebKitAPI/TestsController.h:
* TestWebKitAPI/mac/main.mm:
(main):
Add option to print all registered tests.
2010-10-07 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>, Andras Becsi <abecsi@webkit.org>, Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add WTR's InjectedBundle build files.
https://bugs.webkit.org/show_bug.cgi?id=47333
* Scripts/webkitdirs.pm:
* WebKitTestRunner/DerivedSources.pro: Added.
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
* WebKitTestRunner/WebKitTestRunner.pro: Added.
* WebKitTestRunner/qt/DerivedSources.pro: Removed.
Content merged in ../DerivedSources.pro
2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed. Do a renaming that was recommended by the reviewer
(Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::RunUntilConditionLoop::start):
(WTR::RunUntilConditionLoop::RunUntilConditionLoop):
(WTR::TestController::runUntil):
2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Watchdog timer implementation for WTR
https://bugs.webkit.org/show_bug.cgi?id=47337
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
the definition of the timer type to a typedef.
* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
Timer implementation with QTimer and a helper QObject class.
(WTR::WatchdogTimerHelper::instance):
(WTR::WatchdogTimerHelper::timerFired):
(WTR::WatchdogTimerHelper::WatchdogTimerHelper):
(WTR::LayoutTestController::platformInitialize):
(WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed buildfix for 69297 again
* WebKitTestRunner/TestController.cpp:
(WTR::blankURL):
2010-10-07 Balazs Kelemen <Balazs Kelemen>
Unreviewed trivial build fix for r69297
* WebKitTestRunner/TestController.cpp:
(WTR::blankURL):
2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner should be portable
https://bugs.webkit.org/show_bug.cgi?id=45393
Use only the WebKit API for working with urls.
* WebKitTestRunner/StringFunctions.h:
(WTR::createWKURL):
* WebKitTestRunner/TestController.cpp:
(WTR::blankURL):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::didFinishLoadForFrame):
2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
https://bugs.webkit.org/show_bug.cgi?id=47332
* DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
(createBitmapContextFromWebView):
2010-10-06 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Remove unused accessibility functions from webkit.
https://bugs.webkit.org/attachment.cgi?bugid=46707
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::postAccessibilityNotification):
* DumpRenderTree/chromium/WebViewHost.h:
2010-10-06 Lucas Forschler <lforschler@apple.com>
Reviewed by Adam Roben.
Fix the sunspider-compare-results to actually use the passed in value for $root.
* Scripts/sunspider-compare-results:
2010-10-06 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Runloop implementation for WTR
https://bugs.webkit.org/show_bug.cgi?id=47280
* WebKitTestRunner/qt/TestControllerQt.cpp:
Implemented TestController::runUntil by a timerEvent
and a QEventLoop. We step into the event loop from runUntil.
While we are waiting in the loop a timerEvent is periodically
checking the value of the condition. Once the condition has
becoming true the timerEvent wakes us up.
(WTR::RunUntilLoop::start):
(WTR::RunUntilLoop::RunUntilLoop):
(WTR::RunUntilLoop::run):
(WTR::RunUntilLoop::timerEvent):
(WTR::TestController::platformInitialize):
(WTR::TestController::runUntil):
* WebKitTestRunner/qt/main.cpp:
Start the main event loop first and creating the TestController later.
(Launcher::Launcher):
(Launcher::~Launcher):
(Launcher::launch): Creating the TestController.
(main): Setting up a timer for calling Launcher::launch from
the main event loop.
2010-10-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kenneth Russell.
new-run-webkit-tests: fix typo in chromium-gpu that was trying to
enable 'accelerated-composting' instead of 'accelerated-compositing'.
https://bugs.webkit.org/show_bug.cgi?id=47312
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2010-10-06 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] PlatformWebView implementation for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=47276
The implementation follows the way how
we use the API in MiniBrowser.
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WebView::wkView):
(WTR::WebView::~WebView):
(WTR::WebView::WebView):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
* WebKitTestRunner/qt/WebKitTestRunner.pro:
2010-10-06 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add WebKitTestRunner's build files
https://bugs.webkit.org/show_bug.cgi?id=44155
Parts was taken by Zoltan Horvath's patch.
* Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
* Scripts/webkitdirs.pm: Make the generated files needed by WTR.
* WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
PlatformWKView and PlatformWindow (void* for now).
Buildfix the case when __APPLE__ is not defined.
* WebKitTestRunner/qt/DerivedSources.pro: Added.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
Empty stub implementation.
(WTR::registerWindowClass):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
* WebKitTestRunner/qt/TestControllerQt.cpp: Added.
Empty stub implementation.
(WTR::registerWindowClass):
(WTR::TestController::runUntil):
(WTR::TestController::platformInitialize):
(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):
(WTR::TestController::platformInitializeContext):
* WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
* WebKitTestRunner/qt/main.cpp: Added.
(main):
2010-10-06 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r69202.
http://trac.webkit.org/changeset/69202
https://bugs.webkit.org/show_bug.cgi?id=46937
Broke compile of test_shell
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::beginDragWithFiles):
* DumpRenderTree/chromium/WebViewHost.cpp:
(addDRTFakeFileToDataObject):
2010-10-06 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=46937
Update DRT to use the renamed methods.
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::beginDragWithFiles):
* DumpRenderTree/chromium/WebViewHost.cpp:
(addDRTFakeFileToDataObject):
2010-10-06 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/47270> Move WebArchive serialization code into its own file
Reviewed by Adam Roben.
This is the first step in making webarchive tests work on
Windows.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
new files to the project.
* DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
to WebArchiveDumpSupport.mm.
* DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
* DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
(serializeWebArchiveToXML):
2010-10-05 Daniel Bates <dbates@rim.com>
Reviewed by David Kilzer.
Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=46058
Make VCSUtils::fixChangeLogPatch() return a reference to a hash
structure so as to support returning additional information
about a change log diff.
Currently, VCSUtils::fixChangeLogPatch() returns a string that
represents the change log diff. Towards supporting the return
of additional information, such as whether the change log diff
inserts an entry at the top of the ChangeLog file, we need to
make VCSUtils::fixChangeLogPatch() return a reference to hash
structure.
* Scripts/VCSUtils.pm:
- Modified fixChangeLogPatch() to return a reference to a
hash structure.
- Added documentation to fixChangeLogPatch().
- Modified call site in mergeChangeLogs() as necessary.
* Scripts/svn-apply:
- Modified call site in patch() as necessary.
* Scripts/svn-create-patch:
- Modified call site in generateDiff() as necessary.
* Scripts/svn-unapply:
- Modified call site in patch() as necessary.
* Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
- Modified the unit tests as necessary.
2010-10-05 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
fix the link to the expected image on windows
https://bugs.webkit.org/show_bug.cgi?id=47228
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
windows, the file must be opened in binary mode when writing
binary data.
2010-10-05 Adam Barth <abarth@webkit.org>
Update expected result of unittest to match Tony's change below.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2010-10-05 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai (over the shoulder).
Paper over errors in image_diff so we don't crash the whole test run.
* Scripts/webkitpy/layout_tests/port/chromium.py:
2010-10-05 Tony Chang <tony@chromium.org>
Unreviewed, make shutil.rmtree more resiliant to errors
since windows was raising WindowsError: The process cannot access the file because it
is being used by another process.
* Scripts/webkitpy/layout_tests/port/chromium.py:
2010-10-05 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] fix image diffing in NRWT
https://bugs.webkit.org/show_bug.cgi?id=47128
* Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
NamedTemporaryFile since it doesn't work on Windows.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2010-10-05 Kenneth Russell <kbr@google.com>
Reviewed by Tony Chang.
[chromium] Implement layerTreeAsText in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=47216
Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
make it callable from DumpRenderTree.
No new tests; verified with existing compositor layout tests.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::layerTreeAsText):
* DumpRenderTree/chromium/LayoutTestController.h:
2010-10-05 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build correction.
* DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
property sheet so proper libraries are linked.
2010-10-05 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix url conversion in QWebHistory
Converting from KURL to WFT::String to QUrl does not
permit proper percent encoding later.
https://bugs.webkit.org/show_bug.cgi?id=47048
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::dumpHistoryItem):
2010-10-05 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r68966?): All dumpAsText test fail on WebKit2
https://bugs.webkit.org/show_bug.cgi?id=47188
<rdar://problem/8514104>
When constructing the std::string, use the real string length instead of the maximum buffer size.
* TestWebKitAPI/PlatformUtilities.h:
(TestWebKitAPI::Util::toSTD):
* WebKitTestRunner/StringFunctions.h:
(WTR::toSTD):
2010-10-04 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add MIMEType accessor to WKFrame
<rdar://problem/8347683>
https://bugs.webkit.org/show_bug.cgi?id=47138
* TestWebKitAPI/PlatformUtilities.h:
(TestWebKitAPI::Util::toSTD):
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
(TestWebKitAPI::didStartProvisionalLoadForFrame):
(TestWebKitAPI::didCommitLoadForFrame):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
(TestWebKitAPI::didStartProvisionalLoadForFrame):
(TestWebKitAPI::didCommitLoadForFrame):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
* TestWebKitAPI/Tests/WebKit2/icon.png: Added.
* TestWebKitAPI/Tests/WebKit2/simple.html: Added.
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::createURLForResource):
2010-10-05 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Ojan Vafai.
[NRWT] Rename current_dir to current_group because it's not a directory
https://bugs.webkit.org/show_bug.cgi?id=47169
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-10-04 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
which can't always be done. This test uses tempfile.mkdtemp(), which
should be safe.
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-10-04 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Add missing "from __future__ import with_statement" that was
breaking test-webkitpy on the Leopard bots (broke in r69040).
* Scripts/webkitpy/layout_tests/port/google_chrome.py:
2010-10-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69066.
http://trac.webkit.org/changeset/69066
https://bugs.webkit.org/show_bug.cgi?id=47163
Made NRWT reliability worse. (Requested by tkent on #webkit).
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2010-10-04 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Tony Chang.
[NRWT] Reverse the http tests to alphabetical order.
https://bugs.webkit.org/show_bug.cgi?id=47075
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-10-04 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
We need to queue back and forward navigations in the DRT from the
LayoutTestController so that maybeDump() knows about them.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::queueBackNavigation):
(LayoutTestController::queueForwardNavigation):
2010-10-04 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix image diffing in NRWT
https://bugs.webkit.org/show_bug.cgi?id=47128
* Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
temp file and check the image_diff error code more carefully
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2010-10-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
aroben's change in r68792 actually broke new-run-webkit-tests when
running the DRT code path. His change was intended to fix the
way we were converting windows paths to URIs when running under
Cygwin (the paths were getting one too many "/" on the front).
However, the change ended up breaking the chromium_win port, which
had slightly different logic.
This patch removes the port-specific code and adds tests to make
sure we're getting the behavior we expect. The Port object no longer
exposes a get_absolute_path() method that can be used outside of
of converting test filenames, because it's unreliable otherwise
(we don't have the right context to know which conversion is intended).
https://bugs.webkit.org/show_bug.cgi?id=47140
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-10-04 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Handle crash introduced in r69040 if we are not running in a
Chromium checkout.
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2010-10-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Add a way for us to have test expectations that are specific to the
official builds of Google Chrome (as opposed to Chromium). This change
looks for an additional "test_expectations_chrome.txt" file in
Chromium's repository (webkit/tools/layout_tests), and uses the
concatenation of that file and the regular test_expectations.txt
file for test overrides.
https://bugs.webkit.org/show_bug.cgi?id=46854
* Scripts/webkitpy/layout_tests/port/google_chrome.py:
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2010-10-04 Simon Fraser <simon.fraser@apple.com>
Color tests in the list based on existing pass/fail result.
Fix the summary data to account for htmlOnly and nonHTML tests.
* CSSTestSuiteHarness/harness/harness.css:
(#test-list > option.pass):
(#test-list > option.fail):
(#test-list > option.skipped):
* CSSTestSuiteHarness/harness/harness.js:
(Test):
(Test.prototype.statusForFormat):
(TestSuite.prototype.fillTestList):
(TestSuite.prototype.updateTestList):
(TestSuite.prototype.recordResult):
(TestSuite.prototype.markTestCompleted):
(TestSuite.prototype.countTestsWithFlag):
(TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
(TestSuite.prototype.queryDatabaseForSummary):
2010-10-04 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AX: doAXRangeForLine does not work
https://bugs.webkit.org/show_bug.cgi?id=47101
DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
* DumpRenderTree/AccessibilityUIElement.cpp:
(rangeForLineCallback):
(AccessibilityUIElement::rangeForLine):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::rangeForLine):
2010-10-04 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-10-04 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add ability to set the CacheModel in Webkit2
https://bugs.webkit.org/show_bug.cgi?id=47066
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]): Opt minibrowser into
a PrimaryWebBrowser cache model.
2010-10-03 Simon Fraser <simon.fraser@apple.com>
Make sure to enter all tests when creating the database
for the first time.
When migrating to a new version of the suite, be sure to
sync up the database and testinfo.data by removing old
tests, and inserting new ones.
* CSSTestSuiteHarness/harness/harness.js:
(TestSuite.prototype.openDatabase.creation):
(TestSuite.prototype.databaseCreated):
(TestSuite.prototype.populateDatabaseFromTestInfoData):
(TestSuite.prototype.insertTest):
2010-10-03 Simon Fraser <simon.fraser@apple.com>
More work on treating HTML4 and XHTML1 independently; when
changing the format, rebuild the test list, and update the
numbers in the chapter popup.
* CSSTestSuiteHarness/harness/harness.js:
(Test):
(Test.prototype.runForFormat):
(Test.prototype.completedForFormat):
(ChapterSection):
(ChapterSection.prototype.countTests):
(Chapter):
(Chapter.prototype.description):
(Chapter.prototype.countTests):
(Chapter.prototype.testCount):
(Chapter.prototype.untestedCount):
(TestSuite.prototype.buildChapters):
(TestSuite.prototype.loadCurrentTest):
(TestSuite.prototype.updateProgressLabel):
(TestSuite.prototype.processFlags):
(TestSuite.prototype.formatChanged):
2010-10-03 Simon Fraser <simon.fraser@apple.com>
Update test suite version 20101001.
Handle database migration, and delete tests from the db that are
not present in testinfo.data.
Load about:blank into the test frame before the test url, to make
missing tests more obvious.
* CSSTestSuiteHarness/harness/harness.js:
(TestSuite.prototype.loadTest):
(TestSuite.prototype.openDatabase.creation):
(TestSuite.prototype.openDatabase.migration1_0To1_1):
(TestSuite.prototype.openDatabase.if.return):
(TestSuite.prototype.databaseReady):
(TestSuite.prototype.populateDatabaseFromTestInfoData):
(TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
(TestSuite.prototype.syncDatabaseWithTestInfoData):
2010-10-02 Simon Fraser <simon.fraser@apple.com>
Add the ability to jump to a specific test.
* CSSTestSuiteHarness/harness/harness.html:
* CSSTestSuiteHarness/harness/harness.js:
(TestSuite.prototype.goToTestByName):
(TestSuite.prototype.switchToFormat):
2010-10-02 Simon Fraser <simon.fraser@apple.com>
For a ref test, load the ref in the same format (HTML4 vs XHTML1)
as the test.
* CSSTestSuiteHarness/harness/harness.js:
(TestSuite.prototype.loadRef):
2010-10-02 Simon Fraser <simon.fraser@apple.com>
Update the UI to reflect the fact that each test needs to be tested
in both HTML4 and XHTML1 format.
* CSSTestSuiteHarness/harness/harness.js:
(Test):
(Chapter.prototype.description):
(Chapter.prototype.untestedCount):
(TestSuite.prototype.fillChapterPopup):
(TestSuite.prototype.updateChapterPopup):
(TestSuite.prototype.fillTestList):
(TestSuite.prototype.updateTestList):
(TestSuite.prototype.goToNextIncompleteTest):
(TestSuite.prototype.firstIncompleteTestIndex):
(TestSuite.prototype.recordResult):
(TestSuite.prototype.formatChanged):
(TestSuite.prototype.markTestCompleted):
(TestSuite.prototype.resetTestStatus):
2010-10-01 Simon Fraser <simon.fraser@apple.com>
Add the ability to remove results for re-testing, and
to import results.
* CSSTestSuiteHarness/harness/harness.css:
(.custom button):
(#overlay):
(#overlay.visible):
(.overlay-contents):
(.overlay-contents textarea):
(.overlay-contents .buttons):
(.overlay-contents .note):
(.overlay-contents .buttons button):
* CSSTestSuiteHarness/harness/harness.html:
* CSSTestSuiteHarness/harness/harness.js:
(TestSuite.prototype.importResults):
(TestSuite.prototype.clearResults):
(TestSuite.prototype.markTestCompleted):
(TestSuite.prototype.resetTestStatus):
(TestSuite.prototype.storeTestResult):
(TestSuite.prototype.importTestResults):
(TestSuite.prototype.clearTestResults):
2010-10-01 Sam Weinig <sam@webkit.org>
Reviewed by Jon Honeycutt.
Deploy the new WKString functions to remove most uses of CF from
the WebKitTestRunner.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::done):
* WebKitTestRunner/StringFunctions.h:
(WTR::toWK):
(WTR::toJS):
(WTR::toSTD):
(WTR::operator<<):
(WTR::copyURLString):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::didFinishLoadForFrame):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2010-10-01 Mihai Parparita <mihaip@chromium.org>
Unreviewed TestResultsServer change.
Add files introduced by http://crrev.com/61273 to the list of dashboard
files to update.
* TestResultServer/handlers/dashboardhandler.py:
2010-10-01 Brian Weinstein <bweinstein@apple.com>
Build Fix for Windows.
* WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
ForwardingHeaders to the include path.
2010-10-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKString.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
(TestWebKitAPI::TEST):
2010-10-01 Sam Weinig <sam@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Add additional WKString API
https://bugs.webkit.org/show_bug.cgi?id=46958
Add basic WKStringRef tests.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
2010-10-01 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Add makefile for TestWebKitAPI and call it from the base makefile.
* Makefile:
* TestWebKitAPI/Makefile: Added.
2010-10-01 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Remove unnecessary ForwardingHeaders from test runners.
https://bugs.webkit.org/show_bug.cgi?id=47010
* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/ForwardingHeaders: Removed.
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/ForwardingHeaders: Removed.
2010-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebSocket tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=46956
Update these tools to understand how to run the WebSocket tests off the
Apache server.
* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/websocket_server.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-10-01 Adam Roben <aroben@apple.com>
Encode Executive command arguments using UTF-8 on Cygwin
Cygwin's Python's os.execv doesn't support unicode command arguments.
Cygwin's execv expects arguments to be encoded using the current code
page. But code pages are limited in what characters they can handle,
and our tests include characters that the English code page can't
handle. So for now we'll just encode everything in UTF-8 on Cygwin,
which can handle all characters but might confuse some commands, for
expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
good enough, but we can deal with that when the problem arises.
Reviewed by Adam Barth.
Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
fails on Windows
* Scripts/webkitpy/common/system/executive.py:
(Executive._run_command_with_teed_output):
(Executive.run_command):
On Cygwin, encode arguments using UTF-8.
2010-10-01 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Add simple API tester for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=46953
This adds a very simple testing infrastructure for testing APIs exposed
through the WebKit project. It consists of two parts: 1) a project that
builds the all the tests 2) a script that searches the tests directory and
calls the tester once for each test.
This adds the infrastructure and two tests:
- Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
- Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
This currently only works on the mac, but is designed to be easily ported
to any platform.
* Scripts/run-api-tests: Added.
* Scripts/build-api-tests: Added.
Scripts to build/run the tests.
* TestWebKitAPI: Added.
* TestWebKitAPI/Configurations: Added.
* TestWebKitAPI/Configurations/Base.xcconfig: Added.
* TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
* TestWebKitAPI/ForwardingHeaders: Added.
* TestWebKitAPI/ForwardingHeaders/wtf: Added.
* TestWebKitAPI/PlatformUtilities.h: Added.
* TestWebKitAPI/PlatformWebView.h: Added.
(TestWebKitAPI::PlatformWebView::platformView):
* TestWebKitAPI/StringFunctions.h: Added.
* TestWebKitAPI/Test.h: Added.
(TestWebKitAPI::Test::~Test):
(TestWebKitAPI::Test::name):
(TestWebKitAPI::Test::Register::Register):
(TestWebKitAPI::Test::Register::create):
(TestWebKitAPI::Test::Test):
* TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
* TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
* TestWebKitAPI/TestsController.cpp: Added.
(TestWebKitAPI::TestsController::shared):
(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::testFailed):
(TestWebKitAPI::TestsController::registerCreateTestFunction):
* TestWebKitAPI/TestsController.h: Added.
* TestWebKitAPI/mac: Added.
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::createURLForResource):
* TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::focus):
* TestWebKitAPI/mac/main.mm: Added.
Infrastructure.
* TestWebKitAPI/Tests: Added.
* TestWebKitAPI/Tests/WTF: Added.
* TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
* TestWebKitAPI/Tests/WebKit2: Added.
* TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
(TestWebKitAPI::State::State):
* TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
Proof of concept tests.
2010-10-01 Adam Roben <aroben@apple.com>
Don't assume AccessibleObjectFromEvent succeeds
Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
DumpRenderTree!notificationListenerProc when running
plugins/access-after-page-destroyed.html
Reviewed by Sam Weinig.
* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(notificationListenerProc): Check both the return value of
AccessibleObjectFromEvent and the object it returns, as MSDN
recommends.
2010-10-01 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Tony Chang.
[NRWT] Put the http and websocket tests first in the test list.
https://bugs.webkit.org/show_bug.cgi?id=46453
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-10-01 Fady Samuel <fsamuel@chromium.org>
Unreviewed, adding myself to the committer list.
* Scripts/webkitpy/common/config/committers.py:
2010-10-01 Adam Roben <aroben@apple.com>
Test NPN_GetValue(NPNVnetscapeWindow)
Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
Right-clicking on windowless Flash plugin in WebKit2 makes a context
menu appear in the bottom-right corner of the screen
Reviewed by Anders Carlsson.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_GetValue): Added. Calls through to the browser.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
* DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
(GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
(GetValueNetscapeWindow::NPP_SetWindow): Test that
NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
isn't our HWND.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Added GetValueNetscapeWindow.
2010-10-01 Andreas Kling <andreas.kling@nokia.com>
Unreviewed, adding my webkit.org identity to reviewer list.
* Scripts/webkitpy/common/config/committers.py:
2010-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The WebSocket server should flush its logs
https://bugs.webkit.org/show_bug.cgi?id=46946
The WebSocket server logs are truncated because the driver just
terminates the child. It should run Python without buffering so we can
see the end of the log.
* Scripts/webkitpy/layout_tests/port/websocket_server.py:
2010-09-30 Simon Fraser <simon.fraser@apple.com>
Add a button to jump to the next untested test.
* CSSTestSuiteHarness/harness/harness.css:
(.test-type):
(.name > button):
* CSSTestSuiteHarness/harness/harness.html:
* CSSTestSuiteHarness/harness/harness.js:
(Chapter.prototype.description):
(Chapter.prototype.untestedCount):
(TestSuite.prototype.testInfoDataLoaded):
(TestSuite.prototype.fillChapterPopup):
(TestSuite.prototype.updateChapterPopup):
(TestSuite.prototype.buildTestListForChapter):
(TestSuite.prototype.goToNextIncompleteTest):
(TestSuite.prototype.firstIncompleteTestIndex):
(TestSuite.prototype.testCompletionStateChanged):
2010-09-29 Jon Honeycutt <jhoneycutt@apple.com>
WebKit2 on Windows should use Windows fonts for the various standard
font families
https://bugs.webkit.org/show_bug.cgi?id=43499
<rdar://problem/8272758>
Reviewed by Adam Roben.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Use the Mac fonts for running tests. This matches DRT behavior.
2010-09-30 Adam Barth <abarth@webkit.org>
Third attempt. We need a better integration test environment.
* Scripts/webkitpy/common/net/failuremap.py:
* Scripts/webkitpy/common/net/failuremap_unittest.py:
2010-09-30 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Support for PlainTextController
Unskip editing/text-iterator/basic-iteration.html
https://bugs.webkit.org/show_bug.cgi?id=38805
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::initJSObjects):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
(PlainTextController::PlainTextController):
(PlainTextController::plainText):
* DumpRenderTree/qt/PlainTextControllerQt.h: Added.
2010-09-30 Adam Barth <abarth@webkit.org>
Unreviewed. Second attempt to fix sheriffbot.
* Scripts/webkitpy/common/net/buildbot.py:
2010-09-30 Adam Barth <abarth@webkit.org>
Unreviewed.
This patch should stop the sheriffbot from throwing an exception.
* Scripts/webkitpy/common/net/buildbot.py:
2010-09-30 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
https://bugs.webkit.org/show_bug.cgi?id=46926
* BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows
Release Tests, and two bots running Windows Debug Tests, instead of four running both.
2010-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch find-flaky-tests should print results URLs
https://bugs.webkit.org/show_bug.cgi?id=46917
Printing out the results URL makes find-flaky-tests more actionable
because you can see what happens when a test fails. The output from
the script is still pretty noisy, but it seems useful.
* Scripts/webkitpy/tool/commands/queries.py:
2010-09-30 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Make 2D accelerated canvas rendering build on Mac
https://bugs.webkit.org/show_bug.cgi?id=46007
Added ACCELERATED_2D_CANVAS to build-webkit
* Scripts/build-webkit:
2010-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
https://bugs.webkit.org/show_bug.cgi?id=46849
Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.
Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setAcceleratedCompositingEnabled):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::scheduleComposite):
* DumpRenderTree/chromium/WebViewHost.h:
2010-09-30 Adam Roben <aroben@apple.com>
Ensure that QueueEngine cleans up its log files when its delegate
tells it to stop processing work
Reviewed by Adam Barth.
Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
Windows
* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run): Stop ourselves normally (including cleaning up log
files) when the delegate tells us to stop processing work.
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate.__init__): Moved code here from
RaisingDelegate.__init__.
(LoggingDelegate.expeced_callbacks): Added the stop_work_queue
callback.
(LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
(RaisingDelegate.__init__): Removed code that LoggingDelegate takes
care of for us now.
(QueueEngineTest.test_trivial): Make sure we got the expected stop
message.
(QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
remove the callbacks that are related to processing a single work
item, rather than removing all callbacks after a certain point, as
there are now more callbacks we expect to receive at the end.
2010-09-30 Adam Roben <aroben@apple.com>
Fix path -> URL conversion on Cygwin
Reviewed by Adam Barth.
Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
assuming paths already have a leading slash.
2010-09-30 Adam Roben <aroben@apple.com>
Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
be called more than once
The NPP_SetWindow call made when the plugin is torn down was confusing
us, and was causing us to spew an error into the next test.
Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
(r68520): plugins/access-after-page-destroyed.html failing on Windows
Reviewed by Anders Carlsson.
* DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
(WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
Initialize member.
(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
this isn't the first time this is called.
2010-09-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch upload warns that I'm using Xcode when I'm not
https://bugs.webkit.org/show_bug.cgi?id=46869
String.find returns -1 when not found, so switched to "in".
* Scripts/webkitpy/common/system/user.py:
* Scripts/webkitpy/common/system/user_unittest.py:
2010-09-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch failure-reason dies if non-trunk commits are in the blame range
https://bugs.webkit.org/show_bug.cgi?id=46866
I also made failure-reason use RegressionWindow in a cleaner way.
* Scripts/webkitpy/tool/commands/queries.py:
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch find-flaky-tests
https://bugs.webkit.org/show_bug.cgi?id=46876
This command helps us find flaky tests so we can squash them.
* Scripts/webkitpy/tool/commands/queries.py:
2010-09-29 Simon Fraser <simon.fraser@apple.com>
Fix export to use '?' instead of 'null' for
tests with no results.
* CSSTestSuiteHarness/harness/harness.js:
2010-09-29 Simon Fraser <simon.fraser@apple.com>
Add a warning when a test requires special steps.
Add a Print Preview button for 'paged' tests that
brings up the print dialog, allowing the user to
judge paged media tests.
* CSSTestSuiteHarness/harness/harness.css:
* CSSTestSuiteHarness/harness/harness.html:
* CSSTestSuiteHarness/harness/harness.js:
(TestSuite.prototype.loadTest):
(TestSuite.prototype.processFlags):
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove revisions_casuing_failures
https://bugs.webkit.org/show_bug.cgi?id=46872
This function exists only to be unit tested.
* Scripts/webkitpy/common/net/failuremap.py:
* Scripts/webkitpy/common/net/failuremap_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
SheriffBot should post the list of failing tests to bugs
https://bugs.webkit.org/show_bug.cgi?id=46871
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/failuremap.py:
* Scripts/webkitpy/common/net/regressionwindow.py:
* Scripts/webkitpy/tool/bot/sheriff.py:
* Scripts/webkitpy/tool/bot/sheriff_unittest.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-09-29 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
[WinCairo] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=46360
* BuildSlaveSupport/build.webkit.org-config/config.json: Add
entries for a debug build of the WinCairo port.
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
platform flag to configuration for wincairo (like gtk, chromium, etc.)
* Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
* Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move more SheriffBot smarts into FailureMap
https://bugs.webkit.org/show_bug.cgi?id=46703
This patch pushes the FailureMap model object further into the
SheriffBot machine. In addition, it moves a couple operations on this
object from SheriffBot itself to the model.
Eventually, FailureMap will be the canonical context object for
SheriffBot operations. FailureMap represents a map of the current
failures on the bots that might require remediation.
* Scripts/webkitpy/common/net/failuremap.py:
* Scripts/webkitpy/common/net/regressionwindow.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-09-29 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
https://bugs.webkit.org/show_bug.cgi?id=46829
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::DRTDevToolsClient):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::postAccessibilityNotification):
(WebViewHost::WebViewHost):
2010-09-29 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827
* DumpRenderTree/AccessibilityUIElement.cpp:
(speakCallback):
(AccessibilityUIElement::speak):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::speak):
2010-09-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Record bot ID when updating queue status
https://bugs.webkit.org/show_bug.cgi?id=46764
Since we now have multiple bots handling patches from the commit queue,
we need to differentiate status updates from them, so that we can group
the queue status page in a less confusing way.
* QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
* QueueStatusServer/model/queuestatus.py: Add bot_id property
* QueueStatusServer/templates/updatestatus.html: Add bot_id input
* Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
* Scripts/webkitpy/common/net/statusserver.py: Add bot_id
* Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
* Scripts/webkitpy/tool/main.py: Add --bot-id
* Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
2010-09-29 Simon Fraser <simon.fraser@apple.com>
No review.
References always refert to a file in .xht format, even
for HTML tests, so fix their loading.
* CSSTestSuiteHarness/harness/harness.js:
(TestSuite.prototype.loadRef):
2010-09-28 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=41292
Add a new parameter to the test plugin to allow specifying a script
and a mouse/keyboard event. The specified script will be evaluated
in the browser when the specified event is received by the plugin.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginAllocate):
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
(handleEventCarbon):
(handleEventCocoa):
2010-09-28 Simon Fraser <simon.fraser@apple.com>
Fix export by adding missing argument.
* CSSTestSuiteHarness/harness/harness.js:
(TestSuite.prototype.showResultsForAllTests):
2010-09-28 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix, add missing import.
* wx/packaging/build-win-installer.py:
2010-09-28 Simon Fraser <simon.fraser@apple.com>
No review
Show which tests have been run by dimming them out in the test list.
Adjust some element sizes.
* CSSTestSuiteHarness/harness/harness.css:
(#test-list > option.untested):
(#test-list > option.completed):
(#output):
(.output-options):
* CSSTestSuiteHarness/harness/harness.js:
(Test):
(TestSuite.prototype.fillTestList):
(TestSuite.prototype.updateTestList):
(TestSuite.prototype.setSelectedChapter):
(TestSuite.prototype.recordResult):
(TestSuite.prototype.markTestCompleted):
(TestSuite.prototype.testCompletionStateChanged):
(TestSuite.prototype.loadTestStatus):
2010-09-28 Simon Fraser <simon.fraser@apple.com>
No review.
Implement export of various queries on the test database, sharing
code with that which displays results inline.
* CSSTestSuiteHarness/harness/harness.js:
():
(TestSuite.prototype.exportResultsCompletion.var):
(TestSuite.prototype.exportResultsCompletion):
(TestSuite.prototype.showResultsForCompletedTests):
(TestSuite.prototype.exportResultsForCompletedTests):
(TestSuite.prototype.showResultsForAllTests):
(TestSuite.prototype.exportResultsForAllTests):
(TestSuite.prototype.exportResultsForTestsNotRun):
(TestSuite.prototype.exportResultsForTestsWithStatus):
(TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
2010-09-28 Simon Fraser <simon.fraser@apple.com>
No review.
Work around uncertainty about the order of database
transactions when creating the database, so that we don't
try to query the table before it has been created.
* CSSTestSuiteHarness/harness/harness.js:
(TestSuite):
(TestSuite.prototype.databaseCreated):
(TestSuite.prototype.storeTestResult):
(TestSuite.prototype.populateDatabaseFromTestInfoData):
(TestSuite.prototype.queryDatabaseForTestsWithStatus):
(TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
(TestSuite.prototype.queryDatabaseForCompletedTests):
(TestSuite.prototype.queryDatabaseForTestsNotRun):
2010-09-28 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
add python keyring support to webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=41269
* Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
the python keyring module
* Scripts/webkitpy/common/net/credentials_unittest.py:
* Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
* Scripts/webkitpy/common/system/user_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-09-28 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
https://bugs.webkit.org/show_bug.cgi?id=46740
* DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
fonts which can be used to fully test FontConfig rendering settings.
2010-09-28 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[gtk] Fedora has a different path for the liberation fonts
https://bugs.webkit.org/show_bug.cgi?id=46709
When searching for DRT fonts, also look in the path where those fonts
are commonly found on Fedora systems.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeFonts): Include logic for looking for Fedora-style font paths.
2010-09-28 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
run-webkit-tests needs an updated list of directories with webgl tests
https://bugs.webkit.org/show_bug.cgi?id=46747
Update the list of directories containing WebGL tests and a unit test
which depends on this list.
* Scripts/old-run-webkit-tests: Update the list of directories.
* Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
2010-09-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Introduce FailureMap to summaries the failures status of all the bots
https://bugs.webkit.org/show_bug.cgi?id=46700
This patch gives the SheriffBot a handle on the list of failing tests.
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/failuremap.py: Added.
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-09-28 Adam Roben <aroben@apple.com>
Update for the addition of WKPageUIClient::didNotHandleKeyEvent
Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
tell a WebKit2 client application that a key event was not handled
Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
2010-09-28 Simon Fraser <simon.fraser@apple.com>
Unreviewed.
Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
for the test order, but instead use information from testinfo.data.
* CSSTestSuiteHarness/harness/harness.html:
* CSSTestSuiteHarness/harness/harness.js:
2010-09-28 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix, don't try to get the svn revision from the git repo when packaging,
it causes the process to hang on the gitorious repo.
* wx/packaging/build-mac-installer.py:
* wx/packaging/build-win-installer.py:
2010-09-28 Adam Roben <aroben@apple.com>
Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
called
Reviewed by Anders Carlsson.
Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
Full-page Adobe Reader does not paint until window is resized
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
this level.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
NPP_SetWindow.
* DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
the plugin's HWND has a non-zero size and that its size/position
matches that specified in the NPWindow.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow): Call through to the PluginTest.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
the files as it saw fit.
2010-09-28 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Remove support for Qt 4.5
https://bugs.webkit.org/show_bug.cgi?id=46718
Remove the code for versions of Qt prior to 4.6.
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::addTouchPoint):
(EventSender::updateTouchPoint):
(EventSender::setTouchModifier):
(EventSender::touchStart):
(EventSender::touchMove):
(EventSender::touchEnd):
(EventSender::clearTouchPoints):
(EventSender::releaseTouchPoint):
(EventSender::sendTouchEvent):
* DumpRenderTree/qt/EventSenderQt.h:
* DumpRenderTree/qt/TextInputControllerQt.cpp:
(TextInputController::setMarkedText):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
(LauncherWindow::sendTouchEvent):
(LauncherWindow::eventFilter):
(LauncherWindow::applyZoom):
(LauncherWindow::setTouchMocking):
* QtTestBrowser/launcherwindow.h:
* QtTestBrowser/utils.cpp:
(urlFromUserInput):
* QtTestBrowser/webview.cpp:
(WebViewGraphicsBased::animatedFlip):
(WebViewGraphicsBased::animatedYFlip):
* QtTestBrowser/webview.h:
(WebViewGraphicsBased::setYRotation):
2010-09-28 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Andreas Kling.
Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
which should point to wcecompat installation. Needs wcecompat
library from http://github.com/mauricek/wcecompat .
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2010-09-28 Daniel Bates <dbates@rim.com>
Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
<https://bugs.webkit.org/show_bug.cgi?id=39136>
Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
In particular, this change caused Sheriffbot to raise an exception when
trying to parse the bug id on a bug page. We need to look into this
some more.
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/common/net/bugzilla_unittest.py:
* Scripts/webkitpy/tool/bot/sheriff.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/steps/closebug.py:
* Scripts/webkitpy/tool/steps/obsoletepatches.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2010-09-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move RegressionWindow further up the dependency chain
https://bugs.webkit.org/show_bug.cgi?id=46698
Baby steps towards pushing this information into bug posts.
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/buildbot_unittest.py:
* Scripts/webkitpy/common/net/regressionwindow.py:
* Scripts/webkitpy/tool/commands/queries.py:
2010-09-27 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
sheriffbot can't roll out security patches
https://bugs.webkit.org/show_bug.cgi?id=39136
Make SheriffBot determine if it's authorized to view a bug
whose change it wants to rollout before it tries to rollout
the change.
Moreover, make both webkit-patch and Sheriffbot provide human-
readable error messages when they are not authorized to view
a bug and when a bug number is invalid.
Currently, Sheriffbot does not parse Bugzilla bugs for
<bug error="...">, which indicates an error when retrieving
a bug. In particular, error="NotPermitted" if a person (or bot)
is not authorized to view a bug. For such error="NotPermitted" bugs,
Sheriffbot raises an exception when parsing the bug report and
this exception does not explicitly indicate Sheriffbot's lack
of authorization. Instead, Sheriffbot should explicitly check
for the presence <bug error="..."> before operating on a bug
and error with a human-readable message if it's not permitted
to view it.
* Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
* Scripts/webkitpy/common/net/bugzilla_unittest.py:
- Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
- Added unit test test_bug_parsing_for_bugzilla_not_found_error().
- Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
* Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
* Scripts/webkitpy/tool/commands/download.py: Ditto.
* Scripts/webkitpy/tool/commands/queues.py: Ditto.
* Scripts/webkitpy/tool/commands/upload.py: Ditto.
* Scripts/webkitpy/tool/steps/closebug.py: Ditto.
* Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
* Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
2010-09-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Expose more more failure information from Buildbot to SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=46697
This patch moves the information about what tests failured closer to
SheriffBot. There are still a couple more patches to go before
SheriffBot can post this information to bugs, but this is a step in
that direction. Yay for unit tests, which caught some bugs in earlier
versions of this patch.
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/buildbot_unittest.py:
* Scripts/webkitpy/common/net/regressionwindow.py: Added.
* Scripts/webkitpy/tool/commands/queries.py:
2010-09-27 Eric Seidel <eric@webkit.org>
Unreviewed. Fixing 500 error seen in the status server.
It turns out that a = b = []; b.append(1); then a[0] will be 1!
This should have been obvious to me, I guess, but it was not what I was expecting.
* QueueStatusServer/model/activeworkitems.py:
2010-09-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue should reject patches that fail to land
https://bugs.webkit.org/show_bug.cgi?id=46694
This can happen, for example, if there's no reviewer. Without this
patch, we'll keep retrying the patch.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2010-09-27 Simon Fraser <simon.fraser@apple.com>
Rubber-stamped by Adele Peterson.
Add a harness for running the CSS 2.1 test suite.
This harness assumes that you've got a local a copy of the suite
adjacent to the 'harness' directory.
The harness lets you go through the tests in chapter order,
denoting pass/fail/skipped for each test.
It uses a client-side database to store the results of testing.
* CSSTestSuiteHarness/harness/harness.css: Added.
* CSSTestSuiteHarness/harness/harness.html: Added.
* CSSTestSuiteHarness/harness/harness.js: Added.
2010-09-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Patch locks should expire if a patch is marked for retry
https://bugs.webkit.org/show_bug.cgi?id=46682
This was part Adam's original CommitQueueTask design,
but support for it was missing from the server.
I added the support, but triggering lock-release based on this
special "retry" status feels a bit strange so I added a FIXME.
I also changed the text in queuestatus.html to say "Lock Acquired"
since "Last Activity" isn't really true. We only update the lock
date when the patch is started, not on every status update.
I also noticed an exception in next-patch, which I fixed by re-writing
the unzip logic in activeworkitems.py again.
* QueueStatusServer/handlers/updatestatus.py:
* QueueStatusServer/model/activeworkitems.py:
* QueueStatusServer/templates/queuestatus.html:
2010-09-27 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] fix a warning when compiling DRT on 32-bit linux
https://bugs.webkit.org/show_bug.cgi?id=46641
* DumpRenderTree/chromium/TestEventPrinter.cpp:
(DRTPrinter::handleImage):
2010-09-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queue-status should report when the patch was last locked to a queue
https://bugs.webkit.org/show_bug.cgi?id=46674
This isn't necessarily the best way to expose this information
but having this accessible via the web interface is very
useful until we come up with a nicer way to display this.
I also cleaned up the code in activeworkitems.py a little
to use list comprehensions and to have the code work with
pairs instead of two lists at once. Eventually I think those
item/time pairs need to be their own little helper class.
* QueueStatusServer/handlers/queuestatus.py:
* QueueStatusServer/model/activeworkitems.py:
* QueueStatusServer/templates/queuestatus.html:
2010-09-27 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] fix detection of missing fonts on DRT
https://bugs.webkit.org/show_bug.cgi?id=46651
* DumpRenderTree/chromium/TestShellGtk.cpp:
(setupFontconfig): Only print an error message if lohit isn't found in both locations.
2010-09-27 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
add webkit unit tests to the chromium testers
https://bugs.webkit.org/show_bug.cgi?id=46669
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
2010-09-27 Kwang Yul Seo <skyul@company100.net>
Unreviewed.
Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-09-27 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
https://bugs.webkit.org/show_bug.cgi?id=46634
Use OutputCapture to prevent console spam (and also check for expected
output).
* Scripts/webkitpy/common/system/user_unittest.py:
2010-09-27 Eric Seidel <eric@webkit.org>
Reviewed by James Robinson.
start-commit-queue should abort any rebases in progress
https://bugs.webkit.org/show_bug.cgi?id=46640
webkit-patch commit-queue would do this itself, but this just
helps ensure that the commit-queue script is properly updated
before we run it (in the case where a previous rebase is in
progress the git svn rebase would not work before we run the
commit-queue).
* EWSTools/start-commit-queue.sh:
2010-09-18 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Clean up the DRT fonts.conf and switch to Liberation
https://bugs.webkit.org/show_bug.cgi?id=46038
Switch to Liberation fonts for GTK+ layout tests. This will make our
test results metric-compatible with many Windows/Chromium results. It
also simplifies the fonts.conf that we load and prepares the way for
fixing many font bugs.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeFonts): Initialize a known list of fonts instead of loading
every font in the WEBKIT_TESTFONTS directory.
* DumpRenderTree/gtk/fonts.conf: Removed.
* DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
* DumpRenderTree/gtk/fonts/fonts.conf: Added.
* GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
we can load both fonts.conf and AHEM____.TTF from this location.
* Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
it is no longer used.
2010-09-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-httpd fails if Perl is not installed
https://bugs.webkit.org/show_bug.cgi?id=46602
Make Port._read_configuration catch all exceptions, since trying to run
perl (because of _webkit_build_directory) when it's not installed throws
a WindowsError or OSError, not an IOError (this became an issue after
r68268, since ChromiumPort ends up calling Port.default_configuration in
its constructor, which means that we're ending up on this codepath in
non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
new-run-webkit-httpd).
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
2010-09-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446
Add a setting API to set local storage database path.
* EWebLauncher/main.c:
(on_key_down):
(browserCreate):
(main):
2010-09-26 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
https://bugs.webkit.org/show_bug.cgi?id=46587
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2010-09-26 Antonio Gomes <agomes@rim.com>
Reviewed by Kenneth Rohde Christiansen.
DRT/Mac nodesFromRect support
[Mac][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46580
Implements LayoutTestController::nodesFromRect for Mac DRT, and
adding stubs for GTK+ and Windows.
* DumpRenderTree/LayoutTestController.cpp:
(nodesFromRectCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::LayoutTestController::nodesFromRect):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::nodesFromRect):
2010-09-25 Nicolas Weber <thakis@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=46555
Fix typo in prepare-ChangeLog's help output.
* Scripts/prepare-ChangeLog:
2010-09-24 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
<rdar://problem/8359279>
https://bugs.webkit.org/show_bug.cgi?id=46546
* MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):
(-[BrowserWindowController awakeFromNib]):
* MiniBrowser/win/BrowserView.cpp:
(mouseDidMoveOverElement):
(BrowserView::create):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Allow rebaselines for webkit-patch rebaseline to be chosen
https://bugs.webkit.org/show_bug.cgi?id=46407
Instead of always rebaselining all failing tests, allow a subset to be
chosen.
* Scripts/webkitpy/common/system/user.py:
* Scripts/webkitpy/tool/commands/rebaseline.py:
2010-09-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
[chromium] Implement TextInputController::firstRectForCharacterRange
https://bugs.webkit.org/show_bug.cgi?id=38100
Implemented TextInputController::firstRectForCharacterRange for chromium platform.
No new tests are added since we need to implement the same feature in chromium side
in order to enable any tests that uses this function.
* DumpRenderTree/chromium/TextInputController.cpp:
(TextInputController::firstRectForCharacterRange): Added.
2010-09-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue reports land failures as "PASS"
https://bugs.webkit.org/show_bug.cgi?id=46530
We were ignoring the return value of land instead of passing it back to
CommitQueue. Of course, this was the one case I forgot to test!
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2010-09-24 Kenichi Ishibashi <bashi@google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests prints out nothing when build-dumprendertree fails
https://bugs.webkit.org/show_bug.cgi?id=37563
Print error message when build-dumprendertree fails.
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
NRWT doesn't respect config set with set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=46278
Use Port.default_configuration() instead of hardcoding Release in
ChromiumPort configuration initialization, so that we still inherit the
configuration set by set-webkit-configuration.
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2010-09-24 Chang Shu <chang.shu@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Fix the code to check file existence.
https://bugs.webkit.org/show_bug.cgi?id=46465
* QtTestBrowser/main.cpp:
(main):
2010-09-23 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r68232.
http://trac.webkit.org/changeset/68232
Broken NRWT on the canary bots.
* Scripts/webkitpy/layout_tests/port/chromium.py:
2010-09-23 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
r68008 broke new-run-webkit-tests in that the chromium ports no
longer respect set-webkit-configuration. The correct fix for this
is being pursued in bug 46278 (along with a bunch of unit tests),
but in the meantime I'm reverting the particular lines that broke
things. This was tested by hand.
* Scripts/webkitpy/layout_tests/port/chromium.py:
2010-09-23 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2 API: Need way to know when a frame is removed from the hierarchy
<rdar://problem/8414062>
https://bugs.webkit.org/show_bug.cgi?id=46432
* MiniBrowser/mac/BrowserWindowController.m:
(didRemoveFrameFromHierarchy):
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
2010-09-23 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
https://bugs.webkit.org/show_bug.cgi?id=46426
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::sampleSVGAnimationForElementAtTime):
* DumpRenderTree/chromium/LayoutTestController.h:
2010-09-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Nate Chapin.
[GTK] r68199 introduced two test failures
https://bugs.webkit.org/show_bug.cgi?id=46424
Fix a regression handling preference overrides that are attached to boolean properties.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
so we must check for that when converting a string to a boolean.
2010-09-23 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Levin.
Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
https://bugs.webkit.org/show_bug.cgi?id=46406
This breaks when the method is called with specified size of data (image data), and the
buffer hasn't yet reached this size.
* Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
index larger than 0.
2010-09-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Nate Chapin.
[GTK] Some tests from r68174 fail on the GTK+ bots
https://bugs.webkit.org/show_bug.cgi?id=46396
Simplify LayoutTestController::overridePreference to make it easier for
people unfamiliar with the code to keep the list of preferences up to date.
Add the conversion for enable-hyperlink-auditing.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference): Use a simple if-else block to determine
out the property name for overrridePreference. Also simplify the logic for setting
string properties. Add the conversion for enable-hyperlink-auditing.
2010-09-23 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] add caretBrowsingEnabled to WebSettings and DRT
https://bugs.webkit.org/show_bug.cgi?id=46388
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::overridePreference):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
2010-09-23 Nate Chapin <japhet@chromium.org>
Reviewed by Darin Fisher.
Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
https://bugs.webkit.org/show_bug.cgi?id=30458
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::overridePreference):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference):
2010-09-21 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=46208
This flag allows the layout tests to be run with or without accelerated
2D canvas rendering.
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
Declare the new flag string, and check for it on startup.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
Add a boolean for the new flag, in order to preserve its value over
preferences reset.
(TestShell::resetWebSettings):
Set the new flag to the stored value on reset.
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setAccelerated2dCanvasEnabled):
Add an accessor for the new flag.
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
Initialize the new flag to false.
(WebPreferences::applyTo):
Copy the flag's value to the WebSettings.
* DumpRenderTree/chromium/WebPreferences.h:
Add the new flag.
2010-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Refactor QtWebKitPlatformPlugin interface
Make it easier to keep source-compability for the
QtWebKitPlatformPlugin interface, and run qmake
on the example (but not build) for convenience.
https://bugs.webkit.org/show_bug.cgi?id=46345
* Scripts/webkitdirs.pm:
2010-09-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Tweak some status messages that Eric thought were confusing
https://bugs.webkit.org/show_bug.cgi?id=46342
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-09-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix comm-queue typo
https://bugs.webkit.org/show_bug.cgi?id=46339
We were missing a "self". The real problem is that we didn't have an
integration test for the failure case.
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-09-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue should log more detailed messages to the QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=46333
When I created CommitQueueTask, I removed most of the previous logging.
This patch adds back more detailed logging so folks can see their patch
progress through the queue.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-09-22 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
[Chromium] User style layout tests don't pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=46069
Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
behavior from other ports.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::addUserStyleSheet):
2010-09-22 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Martin Robinson.
[WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
https://bugs.webkit.org/show_bug.cgi?id=46303.
* MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
* MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
property sheet.
* MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
* MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
appropriate property sheet for the build types.
* WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
configuration to use appropriate property sheet for CoreFoundation
and CFLite-style builds.
2010-09-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Optimize commit-queue performance for green trees
https://bugs.webkit.org/show_bug.cgi?id=46254
This patch redesigns the controller logic for the commit-queue. In the
new design, the controller exercises much finer-grained control over
the landing process. In particular:
- Patches that fail to apply now get rejected almost immediately.
- Patches that fail to build get rejects after two builds (instead of
three builds and one test run).
- Patches that run into a flaky test now get accepted after one build
and two test runs instead of three full build-and-test runs.
The main cost of these optimizations is that we don't find out the tree
has a failing test until the very end of the process, but if the tree
has a busted test, there's not much we can do anyway. We might as well
burn commit-queue resources spinning optimisticly.
* Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
* Scripts/webkitpy/tool/commands/queues.py:
2010-09-22 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Martin Robinson.
[WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
https://bugs.webkit.org/show_bug.cgi?id=46303.
* DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
WinCairo build.
* WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
* WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
build targets that use the new InjectedBundleCFLite.vsprops file.
2010-09-22 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix bustage of rebaseline-chromium-webkit-tests resulting from
r67974. Really need better unit tests for this tool :(
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2010-09-22 Adam Roben <aroben@apple.com>
Unbreak test-webkitpy
* Scripts/webkitpy/test/main.py:
(Tester.run_tests): Add a line that mysteriously got deleted.
2010-09-22 Adam Roben <aroben@apple.com>
Make test-webkitpy test WebKit2's scripts
These scripts can't be in WebKitTools due to limitations of Apple's
build process. But that doesn't mean we can't test them!
Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
WebKit2/Scripts
Reviewed by Adam Barth.
* Scripts/test-webkitpy:
(_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
Now takes an external_package_paths parameter and cleans both webkitpy
and any external packages.
(init): Added an external_package_paths parameter which we pass along
to _clean_packages_with_test.
(top level): Add WebKit2/Scripts/webkit2 as our only external package
and pass it along to init and Tester.run_tests.
* Scripts/webkitpy/test/main.py:
(Tester.run_tests): Added an optional external_package_paths
parameter. We modify sys.path so that the external packages can be
imported, and search for unittest files inside all external packages
in addition to inside webkitpy.
2010-09-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: r68063 broke linux python tests
Add a missing "from __future__ import with_statement" to this
new file; the perils of testing only on the Mac and by review :(
https://bugs.webkit.org/show_bug.cgi?id=46293
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2010-09-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Add a 'chromium-gpu' set of ports that will test the accelerated
GPU paths. This patch adds:
- support for the '--accelerated-compositing' and
'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
'no-' flags)
- adds a new set of Ports that will look under
platform/chromium-gpu-$OS/ for baselines before looking in the
regular chromium search path
- adds a new test_expectations.txt file in platform/chromium-gpu
that skips all but the tests we actually want to run with
acceleration.
This patch will allow us to run both with and without acceleration
and to change the defaults for both the regular and -gpu options
as the code evolves.
We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
each test bot.
https://bugs.webkit.org/show_bug.cgi?id=46225
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
2010-09-22 Jamey Hicks <jamey.hicks@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Web Inspector: Remote Web Inspector support for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=43988
Runs a web debug server on port specified by QtTestBrowser
argument -remote-inspector-port. Property
_q_webInspectorServerPort of the QWebPage instance will be set
according to the argument. All pages with that property set will
be remotely inspectable.
URL for remote inspection of first QWebPage is
http://localhost:9222/webkit/inspector/inspector.html?page=1
where 1 is the number of the QWebPage instance.
The base URL yields an index page with links to the individual inspectors:
http://localhost:9222/
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::init):
* QtTestBrowser/launcherwindow.h:
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
2010-09-22 Adam Roben <aroben@apple.com>
Fix webkit-patch failure-reason now that build.webkit.org has been
updated
Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
every time
Reviewed by Eric Seidel.
* Scripts/webkitpy/common/net/buildbot.py:
(BuildBot._file_cell_text): Added. Travels down the firstChild chain
looking for an element that contains text, then returns it.
(BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
text out of the cells. This way it doesn't matter whether the cells
have <b> children (as for cells in directory rows) or not (as for
cells in file rows)
(BuildBot._parse_twisted_directory_listing): Look for rows that have
the "directory" or "file" class, rather than rows with any class,
since header rows now have a class attribute.
* Scripts/webkitpy/common/net/buildbot_unittest.py:
(BuildBotTest._example_directory_listing): Updated to more closely
match the markup that build.webkit.org is producing now.
2010-09-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
new-run-webkit-tests: fix bug introduced in r68008 where if you
specify --chromium and no --platform, and you're running on
windows, you use the 'chromium-win' port by default instead of the
version-specific port. This breaks the buildbots.
It will be good for this refactoring to settle down so I can
rewrite the logic for default ports and the unit tests to be
clearer (and the testing more comprehensive).
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
2010-09-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Modify the Port interface to take only a series of keyword arguments
in the constructor, and modify Port/factory.get() to accomodate that,
and to accept user=XXX as an argument so we can pass
webkitpy.common.system.user.User objects in.
Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
to use the common routine in webkitpy.common.system.user.open_url()
to display HTML files.
There was a routine in the Port interface to do the same thing,
but I see no need for a port-specific hook for this, since it is
something that will always be executed by the host environment
and displaying web pages has nothing to do with running layout tests.
Note that new-run-webkit-tests used to use test_shell to display
the page; this is potentially useful so that you can actually click
from a result to the broken page; however, since DumpRenderTree
doesn't support this functionality, it will be going away eventually.
https://bugs.webkit.org/show_bug.cgi?id=46128
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/google_chrome.py:
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
* Scripts/webkitpy/layout_tests/port/gtk.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/win.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-09-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Get fresh theme when running EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=46210
If user tried to run EWebLauncher outside of the build tree, it would
not find the theme and fallback to the installed one. However, since
EWebLauncher is not installed, we always want to take the theme from
the just compiled source code. If user had never installed WebKit's
EFL port it could even receive a segv since no theme would be found.
Now EWebLauncher does not fallback to the installed theme and CMake
gives as DATA_DIR the directory of the theme it has just built.
* CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
EWebLauncher.
* EWebLauncher/main.c: Use only the theme from build director. Do not
fallback to others as this could hide real bugs.
(quit):
(browserCreate):
(findThemePath):
(main):
2010-09-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Don't pass the --test-shell arg to the Chromium Mac port of DRT;
it just confuses it.
https://bugs.webkit.org/show_bug.cgi?id=46230
* Scripts/webkitpy/layout_tests/port/webkit.py:
2010-09-21 Lucas Forschler <lforschler@apple.com>
Reviewed by Stephanie Lewis.
Make a new buildbot for Leopard Debug Test
* BuildSlaveSupport/build.webkit.org-config/config.json:
2010-09-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix breakage of Chromium Mac DRT port caused by r67905.
https://bugs.webkit.org/show_bug.cgi?id=46230
* Scripts/webkitpy/layout_tests/port/webkit.py:
2010-09-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Add missing import of 'tempfile'.
* Scripts/webkitpy/layout_tests/port/chromium.py:
2010-09-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: pull the list of tests from the Port, and
make it possible to run with no actual test files in the filesystem.
This set of changes allows us to delete the special
webkitpy/layout_tests/data directory and test the generic code without
touching the filesystem (except to write results). This speeds up
test-webkitpy substantially.
This also cleans up and removes several code paths in the generic
code and fixes some minor bugs, notably in the test_expectations
parsing, which was previously fragile if the tests weren't present.
We also change the way we diff image results to be able to do so
in memory, without relying on files. This slows down chromium
test_shell, which always writes images to files, but should speed
up DRT and ImageDiff-based implementations slightly.
Note that pulling the list of tests to run from the Port will allow
ports to specify what tests to run as an inclusive list; previously
you could only do this as an exclusive list by using a
test_expectations file or Skipped files; nothing actually uses this
feature yet and it's unclear if it should be used.
Note that there are no functional changes -- apart from now
always printing out the location of the checksum file when we are
tracing test runs -- and the total number of lines of non-test code
actually drops by two.
There is some more cleanup that can be done in the Port/Driver
interface and in some handling of filenames, but I'll save that
for another change.
https://bugs.webkit.org/show_bug.cgi?id=45801
* Scripts/webkitpy/layout_tests/data/*: Removed.
- no longer need special mock layout_tests_directory in the
repository.
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
- add code to display missing text files, checksums when tracing
- update to not look at the filesystem directly.
* Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- add more unit tests
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- remove tests_are_present flag
- update with changes in Port interface - no longer access
the filesystem directly, although we still use os.path for
filename manipulation.
* Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
- add more unit tests
* Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
- renamed to port/test_files.py
* Scripts/webkitpy/layout_tests/port/base.py:
- change diff_image() to expect actual image data, not filenames
- add expected_checksum(), expected_image(), expected_text() to
return the content of the files so that we don't need a filesystem
- add path_exists(), path_isdir() for filesystem-like access.
- add test_dirs() to keep clobber-test-results from needing to
actually look at a real layout tests dir
- add tests() to return the list of tests to run on the port
(calls port/test_files to do the work).
- add update_baseline() to be able to save new baselines
- add uri_to_test_name() from port/dryrun.py so we can easily check
filename_to_uri()
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
- add more unit tests
* Scripts/webkitpy/layout_tests/port/chromium.py:
- change diff_image() to accept image content, not filenames.
This will be slower for test_shell/image_diff, but faster
for DRT/ImageDiff.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- add more unit tests
* Scripts/webkitpy/layout_tests/port/dryrun.py:
- simplify greatly
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
- add more unit tests
* Scripts/webkitpy/layout_tests/port/test.py:
- massive rewrite to use in-script list of tests and expectations
* Scripts/webkitpy/layout_tests/port/test_files.py:
- rename from layout_package/test_files.
* Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
- add unit tests
* Scripts/webkitpy/layout_tests/port/webkit.py:
- update diff_image() to take image contents, not files. Should
make things slightly faster.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- update with changes to diff_image()
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
- update with changes to diff_image()
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- remove tests_are_present from test_expectations
- pull the list of tests from port.tests() instead
of calling test_files.py directly.
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- update unit tests
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- update with changes to
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- update with change in Port interface
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- update with change in Port interface
* Scripts/webkitpy/style/checkers/test_expectations.py:
- remove the tests_are_present flag
2010-09-21 Anders Carlsson <andersca@apple.com>
Disable logging.
* MiniBrowser/mac/MiniBrowser_Prefix.pch:
2010-09-21 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
add a script for running webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=46014
* Scripts/run-chromium-webkit-unit-tests: Added.
2010-09-21 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Martin Robinson.
Fix linking problems on Windows.
https://bugs.webkit.org/show_bug.cgi?id=45844
* GNUmakefile.am: link the executables with winmm.dll
2010-09-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
feeder-queue svn updates more often than needed
https://bugs.webkit.org/show_bug.cgi?id=46171
We don't need to poll SVN every time we feed the feeders. Rather, we
can count on the wrapper shell script to auto-update the queue.
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-09-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Andreas Kling.
[Qt] Add robot loader timeout and extra time options.
https://bugs.webkit.org/show_bug.cgi?id=46172
[-robot-timeout <s>]: Load the next page after s seconds if the current
page didn't finish loading.
[-robot-extra-time <s>]: Wait s seconds after the current page finished
loading before loading the next one. This should allow some time for the
page's JavaScript to execute.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::applyPrefs):
* QtTestBrowser/main.cpp:
(LauncherApplication::robotTimeout):
(LauncherApplication::robotExtraTime):
(LauncherApplication::LauncherApplication):
(LauncherApplication::handleUserOptions):
(main):
* QtTestBrowser/urlloader.cpp:
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::loadUrlList):
* QtTestBrowser/urlloader.h:
2010-09-21 Pavel Podivilov <podivilov@chromium.org>
Unreviewed.
Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-09-20 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.
* DumpRenderTree/gtk/EventSender.cpp:
(getMenuItemTitleCallback):
(setMenuItemTitleCallback):
(menuItemClickCallback):
(getMenuItemClass):
(contextClickCallback):
2010-09-20 Hayato Ito <hayato@chromium.org>
Unreviewed.
Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The tool member variable should be called _tool
https://bugs.webkit.org/show_bug.cgi?id=46160
Created by find-and-replace.
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/openbugs.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/rebaseline.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/multicommandtool.py:
2010-09-20 Adam Barth <abarth@webkit.org>
I ran the tests before landing but ignored the fact that they failed. :(
* Scripts/webkitpy/tool/commands/queues.py:
2010-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a feeder queue that polls bugs.webkit.org for the commit-cluster
https://bugs.webkit.org/show_bug.cgi?id=46141
The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
list of work items on the status server. The individual commit-cluster
nodes then grab the patches from the server and process them.
* Scripts/webkitpy/tool/bot/feeders.py: Added.
* Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
2010-09-20 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Darin Adler.
build-webkit: Add support for CMake build system
https://bugs.webkit.org/show_bug.cgi?id=44979
* Scripts/build-webkit: Add "--efl" command-line option to build the
EFL port of WebKit.
* Scripts/webkitdirs.pm: Define buildCMakeProject() and
buildEflCMakeProject() subroutines.
2010-09-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: refactor command line args getting passed to DRT
This change cleans up some argument parsing between functions to get
rid of some overlapping data structures. There should be no functional
changes in this patch; it is pure refactoring in preparation for
landing the Chrome GPU port and adding a generic way to pass
args to DRT/TestShell.
https://bugs.webkit.org/show_bug.cgi?id=46135
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- pass the options argument explicitly to the threads and drivers,
also consolidate the passing of options to the driver.
- pass options directly to process_output() to remove a couple
parameters (minor cleanup).
* Scripts/webkitpy/layout_tests/port/base.py:
- pass the options argument to Port.create_driver().
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
- update Port.create_driver() test
* Scripts/webkitpy/layout_tests/port/chromium.py:
- pass the options argument to Port.create_driver(), and clean up
building of the cmd line for DRT.
* Scripts/webkitpy/layout_tests/port/dryrun.py:
- pass the options argument to Port.create_driver()
* Scripts/webkitpy/layout_tests/port/test.py:
- pass the options argument to Port.create_driver()
* Scripts/webkitpy/layout_tests/port/webkit.py:
- pass the options argument to Port.create_driver(), and clean up
building of the cmd line for DRT.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- consolidate args in _get_dump_render_tree_args and rename to
_get_test_args(); move all of the command-line args to the
Port implementations.
2010-09-20 Andrew Wilson <atwilson@chromium.org>
Revert change which was accidentally committed along with some expectation changes.
* Scripts/webkitpy/layout_tests/port/base.py:
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Add explicit --force-patch flag to webkitpy tools
https://bugs.webkit.org/show_bug.cgi?id=46103
It wasn't obvious until I read the applypatch.py source code that
--non-interfactive implies passing --force to patch. Add --force-patch
as an alias to the flag, so that this behavior is more discoverable.
* Scripts/webkitpy/tool/steps/applypatch.py:
* Scripts/webkitpy/tool/steps/options.py:
2010-09-20 Eric Seidel <eric@webkit.org>
Unreviewed, adding a line which got dropped and is trivially correct (and tested).
commit-queue can't land patches
https://bugs.webkit.org/show_bug.cgi?id=46138
Add a line of code I forgot in my last commit.
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/common/net/bugzilla_unittest.py:
2010-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The commit-cluster bots still race to lock patch_ids
https://bugs.webkit.org/show_bug.cgi?id=46130
It turns out we need to use a transaction object to make the
read/modify/write lock operation atomic. From reading the AppEngine
documentation, I think this patch should do what we want. It's hard to
test locally because the test instance isn't distributed in the same
way the production instance is.
* QueueStatusServer/handlers/nextpatch.py:
* QueueStatusServer/model/activeworkitems.py: Added.
2010-09-20 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961
Implement WebKitUsePreHTML5ParserQuirks preference.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
to false after a test finishes.
2010-09-20 Adam Roben <aroben@apple.com>
Windows build fix
* MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
$(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
we'll pick up the most recent versions of the headers.
2010-09-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should check commit-queue+ again just before committing
https://bugs.webkit.org/show_bug.cgi?id=32679
Added a _revalidate_patch check, right before landing.
Since _revalidate_patch passes the patch_id from the work item
back to bugzilla, I had to fix all of the previous queue tests to
use valid attachment ids (that's the majority of this change).
In order to validate that the bug was still open, I had to teach
bugzilla.Bug about open/closed states.
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-09-20 Mihai Parparita <mihaip@chromium.org>
Unreviewed.
Adding myself as a comitter.
* Scripts/webkitpy/common/config/committers.py:
2010-09-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Two instances of commit-queue try to process the same patch
https://bugs.webkit.org/show_bug.cgi?id=46113
This patch makes next-patch atomic so that the server won't vend the
same patch twice in the same hour.
* QueueStatusServer/handlers/nextpatch.py:
2010-09-20 Adam Roben <aroben@apple.com>
Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
We were previously trying to use a CFRunLoopTimer, but since Windows
doesn't use CFRunLoop on most threads this doesn't work. Now we use a
Windows-style timer on Windows.
I also replaced all uses of "watchdog" with "watchdog timer".
Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
watchdog timer doesn't work on Windows
Reviewed by Anders Carlsson.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): Updated for rename.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
platform-specific functions.
(WTR::LayoutTestController::LayoutTestController): Added call to
platformInitialize.
(WTR::LayoutTestController::waitUntilDone): Changed to call
initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
right in this function.
(WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
rename.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
members needed to support the watchdog timer abstraction. Replaced
some "watchdog"s with "watchdog timer".
* WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
Added.
(WTR::LayoutTestController::platformInitialize): Does nothing on this
platform.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
from LayoutTestController.cpp and changed to use an early return.
(WTR::waitUntilDoneWatchdogTimerFired): Moved here from
LayoutTestController.cpp.
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
Moved code here from LayoutTestController::waitUntilDone and changed
to use an early return.
* WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
Added.
(WTR::LayoutTestController::platformInitialize): Initialize our
watchdog timer.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
Kills and clears the watchdog timer.
(WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
LayoutTestController member function of the same name.
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
Added. Sets up the timer if it isn't already set.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
LayoutTestControllerMac.mm.
* WebKitTestRunner/win/InjectedBundle.vcproj: Added
LayoutTestControllerWin.cpp.
2010-09-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] fast/forms/listbox-selection.html fails
https://bugs.webkit.org/show_bug.cgi?id=45942
Use the gdkModifersFromJSValue helper to parse all appropriate modifier
strings in keyDownCallback.
* DumpRenderTree/gtk/EventSender.cpp:
(keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the
modifier parsing logic.
2010-09-19 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2 decidePolicyForNavigationAction should include mouse button information
<rdar://problem/8413165>
https://bugs.webkit.org/show_bug.cgi?id=46060
* MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
2010-09-19 Daniel Bates <dbates@rim.com>
Reviewed by Martin Robinson.
Add unit tests for diffs that delete or modify a change log entry
or describe changes that are far apart
https://bugs.webkit.org/show_bug.cgi?id=46046
Add additional unit tests to test change log diffs that contain
deletions or changes that are far apart from each other in the
ChangeLog file.
* Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
- Added the following unit tests:
"fixChangeLogPatch: [no change] In-place change."
"fixChangeLogPatch: [no change] Remove first entry."
"fixChangeLogPatch: [no change] Remove entry in the middle."
"fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
2010-09-19 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054
The new one acts like WKBundleNodeHandleRef and allows for getting a
wrapper in a specific world for the handle.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::propertyValue):
(WTR::propertyValueDouble):
(WTR::propertyValueInt):
(WTR::numericWindowPropertyValue):
(WTR::toStr):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2010-09-19 Kent Tamura <tkent@chromium.org>
Unreviewed. Fix WebGL test regressions by r67809.
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
2010-09-19 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
[DRT/Chromium] Fix a WebSettings handling bug
https://bugs.webkit.org/show_bug.cgi?id=45945
Before this change, Chromium DRT reset WebSettings for every new
window. It was wrong.
If new window is not the first one, we have to apply the same
settings as the first window. So, we introduce WebPreference to
store the current settings, and apply it to new windows. It's same
as test_shell's behavior.
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/LayoutTestController.cpp:
Use WebPreferences instead of WebSettings.
(LayoutTestController::setUserStyleSheetEnabled):
(LayoutTestController::setUserStyleSheetLocation):
(LayoutTestController::setAuthorAndUserStylesEnabled):
(LayoutTestController::setPopupBlockingEnabled):
(LayoutTestController::disableImageLoading):
(LayoutTestController::setJavaScriptCanAccessClipboard):
(LayoutTestController::setXSSAuditorEnabled):
(LayoutTestController::setAllowUniversalAccessFromFileURLs):
(LayoutTestController::setAllowFileAccessFromFileURLs):
(LayoutTestController::overridePreference):
(LayoutTestController::setEditingBehavior):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetWebSettings): Use WebPreferences.
(TestShell::runFileTest): ditto.
(TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
* DumpRenderTree/chromium/TestShell.h:
(TestShell::preferences):
(TestShell::applyPreferences):
* DumpRenderTree/chromium/WebPreferences.cpp: Added.
* DumpRenderTree/chromium/WebPreferences.h: Added.
2010-09-18 Prasad Tammana <prasadt@chromium.org>
Reviewed by David Levin.
update-webkit --chromium spitting out a spurious error
https://bugs.webkit.org/show_bug.cgi?id=45868
* Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
2010-09-18 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Improve/unify the PageLoadClient interfaces
https://bugs.webkit.org/show_bug.cgi?id=46043
* MiniBrowser/mac/BrowserWindowController.m:
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didReceiveTitleForFrame):
(didFirstLayoutForFrame):
(didFirstVisuallyNonEmptyLayoutForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didFinishLoadForFrame):
* WebKitTestRunner/TestController.h:
2010-09-17 Eric Seidel <eric@webkit.org>
Unreviewed. Adding a shell script I use to run the
commit-queue. Now that multiple machines run the cq,
it makes sense to share the script between them.
* EWSTools/start-commit-queue.sh: Added.
2010-09-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Jon Honeycutt.
The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
slightly harder to read, so this reverts the previous background colors for various
states, making it easier to read.
* BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(.success):
(.failure):
(.warnings):
(.exception):
(.start,.running,td.building):
(.offline,td.offline):
2010-09-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67692.
http://trac.webkit.org/changeset/67692
https://bugs.webkit.org/show_bug.cgi?id=46011
broke layout test dashboard (Requested by johnny_g on
#webkit).
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-09-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Oliver Hunt.
Style bot complains about cairo forward declaration naming
https://bugs.webkit.org/show_bug.cgi?id=45867
Exclude Cairo forward declarations from indentifiers with underscores checks.
* Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2010-09-16 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Ojan Vafai.
Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=45408
This change also tries to remove duplicated upload_results_json methods
in run_webkit_tests.py and json_results_generator.py.
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-09-16 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
[Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
all page specific stuff to the UI.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
* QtTestBrowser/mainwindow.cpp:
(MainWindow::MainWindow):
(MainWindow::buildUI):
(MainWindow::setPage):
* QtTestBrowser/mainwindow.h:
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
object will move to the qgraphicsscene instead of the qgraphicsview.
* QtTestBrowser/webview.cpp:
(WebViewGraphicsBased::setPage):
(WebViewGraphicsBased::setResizesToContents):
(WebViewGraphicsBased::resizeEvent):
(WebViewGraphicsBased::animatedFlip):
* QtTestBrowser/webview.h:
(WebViewGraphicsBased::setItemCacheMode):
(WebViewGraphicsBased::itemCacheMode):
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
We usually separate methods whose body are larger than a few lines from the class definition.
* QtTestBrowser/webview.h:
(WebViewGraphicsBased::yRotation):
(WebViewGraphicsBased::setYRotation):
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Make initializeView method of LauncherWindow private.
No one else needs to be able to call it but LauncherWindow.
Also moving the declation of isGraphicsBased method down in the same file, in order
to better group related methods.
* QtTestBrowser/launcherwindow.h:
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Make the getter 'page' method of MainWindow const.
* QtTestBrowser/mainwindow.cpp:
(MainWindow::page):
* QtTestBrowser/mainwindow.h:
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Remove useless parameter from MainWindow class' constructor.
The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
not referred in the constructor body and does not make much sense.
* QtTestBrowser/mainwindow.cpp:
(MainWindow::MainWindow):
* QtTestBrowser/mainwindow.h:
2010-09-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42151
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(WorkItemLoadHTMLString::WorkItemLoadHTMLString):
(WorkItemLoadHTMLString::run):
(LayoutTestController::queueLoadHTMLString):
(LayoutTestController::reset):
(LayoutTestController::setDeferMainResourceDataLoad):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::deferMainResourceDataLoad):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didCreateDataSource):
2010-09-16 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Add script to synchronize WebKit and Khronos WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=42336
* Scripts/update-webgl-conformance-tests: Added.
* Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
* Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
2010-09-16 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add support for sending synchronous messages from the InjectedBundle to the WKContext
<rdar://problem/8365320>
https://bugs.webkit.org/show_bug.cgi?id=44785
* MiniBrowser/mac/AppDelegate.m:
(didReceiveSynchronousMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didCreatePage):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
2010-09-16 Leonid Ebril <leonid.ebril@nokia.com>
Reviewed by Andreas Kling.
[Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
https://bugs.webkit.org/show_bug.cgi?id=45885
Avoid creation of an additional window for screenshot to prevent overlapping with original window.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::screenshot):
2010-09-16 Anders Carlsson <andersca@apple.com>
Fix clang++ build.
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController resetZoom:]):
Remove trailing semicolons.
2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67628.
http://trac.webkit.org/changeset/67628
https://bugs.webkit.org/show_bug.cgi?id=45904
broke the build (Requested by eric_carlson on #webkit).
* DumpRenderTree/gtk/EventSender.cpp:
(contextClickCallback):
2010-09-16 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed.
Adding myself as a comitter.
* Scripts/webkitpy/common/config/committers.py:
2010-09-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.
* DumpRenderTree/gtk/EventSender.cpp:
(getMenuItemTitleCallback):
(setMenuItemTitleCallback):
(menuItemClickCallback):
(getMenuItemClass):
(contextClickCallback):
2010-09-14 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson and Martin Robinson.
[GTK] eventSender.contextClick() should return the contents of the context menu
https://bugs.webkit.org/show_bug.cgi?id=39102
Make the eventSender use the new private WebKitGtk+ API to
retrieve the context-menu item titles and store them in an array.
* DumpRenderTree/gtk/EventSender.cpp:
(contextClickCallback):
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
* Scripts/build-webkit:
2010-09-16 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support globalhistory tests
https://bugs.webkit.org/show_bug.cgi?id=45774
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::isGlobalHistoryTest):
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::dumpHistoryCallbacks):
(LayoutTestController::removeAllVisitedLinks):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-09-10 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709
* Scripts/webkitpy/layout_tests/deduplicate_tests.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2010-09-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] sort testing methods in DRT
https://bugs.webkit.org/show_bug.cgi?id=45850
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/TextInputController.cpp:
(TextInputController::TextInputController):
2010-09-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
CQ status shows items out of order
https://bugs.webkit.org/show_bug.cgi?id=45846
Only group consecutive status items with the same patch ID into the same
group, so that overall item ordering is preserved.
Also don't indent status items that only have a single item in their
group.
* QueueStatusServer/handlers/queuestatus.py:
* QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
* QueueStatusServer/templates/queuestatus.html:
2010-09-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add queue start/stop messages
https://bugs.webkit.org/show_bug.cgi?id=45853
I ended up needing to clean up a bunch of our unit testing
in order to test this new code path nicely.
There are also a few PEP8 changes needed to pass check-webkit-style.
* Scripts/webkitpy/tool/bot/queueengine.py:
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2010-09-15 Simon Fraser <simon.fraser@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=45849
WKURLCreateWithCFURL crashes with null url
Fix MiniBrowser crash when the url is not parseable.
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController fetch:]):
2010-09-15 Patrick Gansterer <paroga@paroga.com>
Unreviewed.
Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-09-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to run more than one commit-queue instance
https://bugs.webkit.org/show_bug.cgi?id=45786
Mostly we need to make sure the two (or more) instances get
different patches to work on. To do this, I re-worked
the code responsible for getting the next work item to
round trip through the status server. The status server only
vends patches from the work items list, only if those patches
have not had status reported for them in the last hour.
This is another step towards making all queues go through the
status server, thus making it possible to run more than one
instance of various EWS bots (as requested in bug 44292).
The webkitpy changes are already covered by existing unit tests.
The QueueStatusSever sadly has no testing infrastructure yet. :(
* QueueStatusServer/handlers/nextpatch.py: Added.
* QueueStatusServer/index.yaml:
* QueueStatusServer/main.py:
* Scripts/webkitpy/tool/commands/queues.py:
2010-09-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
https://bugs.webkit.org/show_bug.cgi?id=45791
Force filenames to be raw bytes before running difflib.unified_diff.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
2010-09-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
https://bugs.webkit.org/show_bug.cgi?id=35247
The main issue when changing the views is that the plugins and any other components that
depend on view specific attributes such as the native window id are not teared down.
Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
we decided to work around this in QtTestBrowser by making toggling between QWebView
and QGraphicsWebView also re-create the page.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
* QtTestBrowser/mainwindow.h:
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Send webkit accessibility notifications to Chromium
https://bugs.webkit.org/show_bug.cgi?id=45156
Move printf inside shouldDumpAccessibilityNotifications check.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::postAccessibilityNotification):
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=45768
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
2010-09-14 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix, add newly added directories to the directory list.
* wx/build/settings.py:
2010-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=45785
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::propertyValue):
(WTR::numericWindowPropertyValue):
(WTR::dumpPath):
(WTR::toStr):
(WTR::operator<<):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2010-09-14 Adam Barth <abarth@webkit.org>
Fix two typos in commit-queue. The first is harmless. The second
causes the queue to reject patches when the build is broken. :(
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::postAccessibilityNotification):
* DumpRenderTree/chromium/WebViewHost.h:
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue is slow during the day
https://bugs.webkit.org/show_bug.cgi?id=45780
Thanks to the new logging, we've noticed that checkout-is-out-of-date
errors in the first pass of landing don't retry the land. Instead,
they're treated as failures and cause the commit-queue to do two more
builds before really trying to land the patch. Worse, in the second
build, we can get bitten by a flaky test.
This patch takes a slightly different approach to the commit-queue's
main control logic. We now use a separate subprocess for building and
testing and for landing. This means we should very rarely see the
checkout-is-out-of-date error, and when we do see it, we should retry
more quickly. If my understanding is correct, this should be a big
speed win for the commit-queue.
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/chromium/LayoutTestController.h:
2010-09-14 Csaba Osztrogonác <ossy@webkit.org>
Adding myself as a reviewer.
* Scripts/webkitpy/common/config/committers.py:
2010-09-14 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
https://bugs.webkit.org/show_bug.cgi?id=45736
Build-webkit has showed a warning when WebKitBuild didn't exist, add
an additional condition to avoid it.
* Scripts/build-webkit:
2010-09-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should log when it's retrying due to checkout out of date error
https://bugs.webkit.org/show_bug.cgi?id=45725
This will allow us to better track how often we see these errors
and how long it takes the queue to recover from them.
In order to pass the tests, I had to correct an error
from a previous change. The UnitTestPort should not have
ever been using the base port method as that will read
a file from disk. If the unit tests haven't passed the contents
it should raise an IOError as though the file doesn't exist.
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-09-13 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Upload results when cq patch landing fails
https://bugs.webkit.org/show_bug.cgi?id=45683
Include script errors when CommitQueue._land fails.
* Scripts/webkitpy/tool/commands/queues.py:
2010-09-13 Chris Fleizach <cfleizach@apple.com>
Reviewed by David Kilzer.
AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
https://bugs.webkit.org/show_bug.cgi?id=45548
* DumpRenderTree/AccessibilityUIElement.cpp:
(isIgnoredCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isIgnored):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isIgnored):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::isIgnored):
2010-09-13 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Andreas Kling.
jscPath() is incorrect in Windows' cmd.exe shell
https://bugs.webkit.org/show_bug.cgi?id=45651
* Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
2010-09-13 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
https://bugs.webkit.org/show_bug.cgi?id=43807
* DumpRenderTree/AccessibilityUIElement.cpp:
(textMarkerForPointCallback):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::textMarkerForPoint):
2010-09-13 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] build-webkit: Add --v8 option to build against V8
Note that V8 is picked up from QtScript, so this currently requires building
against the experimental qt-script-v8 branch.
* Scripts/build-webkit:
2010-09-13 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Add WebDeviceOrientationClientMock::create() and use it from DRT.
https://bugs.webkit.org/show_bug.cgi?id=45650
Do not use the WebDeviceOrientationClientMock constructor directly,
but use the create() member function.
This should fix the linker errors for the multi-DLL Chromium DRT build.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setMockDeviceOrientation):
(LayoutTestController::deviceOrientationClient):
2010-08-27 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Antti Koivisto.
Add support for testing the viewport meta tag algorithm,
based on the following draft spec:
http://people.opera.com/rune/TR/ED-css-viewport-20100806/
Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::dumpConfigurationForViewport):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-09-12 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
https://bugs.webkit.org/show_bug.cgi?id=45517
Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
* DumpRenderTree/chromium/ImageDiff.cpp:
(Image::craeteFromStdin):
(Image::createFromFilename):
(diffImages):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dumpImage):
2010-09-10 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441
Added TextInputController::hasSpellingMarker().
* DumpRenderTree/chromium/TextInputController.cpp:
(TextInputController::TextInputController):
(TextInputController::hasSpellingMarker):
* DumpRenderTree/chromium/TextInputController.h:
2010-09-12 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
My last change accidentally contained a local change to the
rebaselinig script; webkit-patch land picked it up without telling
me and committed it :(
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2010-09-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Attempt to fix Windows MiniBrowser build (untested)
https://bugs.webkit.org/show_bug.cgi?id=45609
* MiniBrowser/win/BrowserView.cpp:
(runJavaScriptConfirm):
(runJavaScriptPrompt):
2010-09-11 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Fix zoom related tests when testing WebKit2.
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
2010-09-11 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
<rdar://problem/8359252>
https://bugs.webkit.org/show_bug.cgi?id=45605
* MiniBrowser/mac/BrowserWindowController.m:
(setStatusText):
(contentsSizeChanged):
(-[BrowserWindowController awakeFromNib]):
* MiniBrowser/win/BrowserView.cpp:
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(setStatusText):
(contentsSizeChanged):
(BrowserView::create):
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
2010-09-11 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Add callback mechanism for the getting the source of a frame
<rdar://problem/8364681>
https://bugs.webkit.org/show_bug.cgi?id=45604
Add ability to dump the main frame's source to the console.
* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController dumpSourceToConsole:]):
* MiniBrowser/mac/MainMenu.xib:
2010-09-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Remove unneeded Empty Queue messages
https://bugs.webkit.org/show_bug.cgi?id=45602
We already have a /gc job to delete these.
recentstatus.py is already smart enough to use the
most recent of the workitems last update or the most recent status,
so removing these should not change the _last_status_date() return
value more than a few milliseconds.
These messages just spam the recent status log.
* Scripts/webkitpy/tool/commands/queues.py:
2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Fix Python exception when generating synthetic patch IDs
https://bugs.webkit.org/show_bug.cgi?id=45592
Can't concatenate strings and numbers directly.
* QueueStatusServer/handlers/queuestatus.py:
2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Group statuses in queue status by patch ID
https://bugs.webkit.org/show_bug.cgi?id=45588
Group statuses by patch ID so that the status page is easier
to scan.
* QueueStatusServer/handlers/queuestatus.py:
* QueueStatusServer/stylesheets/dashboard.css:
(.status-group):
(.status-bug):
(.status-group ul):
(.status-group ul li):
(.status-group ul li:hover):
(.status-cell):
(.status-cell:hover):
(.status-cell.pass):
(.status-cell.fail):
(.status-cell.pending):
(.status-cell.error):
* QueueStatusServer/templates/dashboard.html:
* QueueStatusServer/templates/queuestatus.html:
2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45479
Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
implementation in ResourceLoadDelegate in the Mac port).
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::dumpResourceResponseMIMETypes):
(LayoutTestController::reset):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::setShouldDumpResourceResponseMIMETypes):
(LayoutTestController::shouldDumpResourceResponseMIMETypes):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::shouldDumpResourceResponseMIMETypes):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveResponse):
2010-09-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queues.webkit.org should expose /remote_api for data upload/download
https://bugs.webkit.org/show_bug.cgi?id=45559
* QueueStatusServer/app.yaml:
- /remote_api is a standard app-engine service which allows use of
the bulk uploader for data upload/download. Exposing this
(for admin access only) allows us to use
2010-09-10 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Add zoom support to WebKit2 API
<rdar://problem/7660657>
https://bugs.webkit.org/show_bug.cgi?id=45585
- Add zoom options to MiniBrowser that mimic Safari's options using
the new WebKit2 zoom APIs.
- Switch uses of float for the zoom APIs to use double.
* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithPageNamespace:]):
(-[BrowserWindowController validateMenuItem:]):
(-[BrowserWindowController validateUserInterfaceItem:]):
(-[BrowserWindowController currentZoomFactor]):
(-[BrowserWindowController setCurrentZoomFactor:]):
(-[BrowserWindowController canZoomIn]):
(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController canZoomOut]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController canResetZoom]):
(-[BrowserWindowController resetZoom:]):
(-[BrowserWindowController toggleZoomMode:]):
* MiniBrowser/mac/MainMenu.xib:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
2010-09-10 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix crash in DRT in standalone mode
https://bugs.webkit.org/show_bug.cgi?id=45454
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2010-09-10 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
Precursor to <rdar://problem/7660657>
https://bugs.webkit.org/show_bug.cgi?id=45522
Update for changes to the Bundle API to allow separate control of page and text zoom
levels.
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset):
2010-09-10 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Support click event for notifications
https://bugs.webkit.org/show_bug.cgi?id=44836
Add support for simulateDesktopNotificationClick by calling
back to DumpRenderTreeSupportQt.cpp.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::simulateDesktopNotificationClick):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-09-10 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
Update queue status when patches fail their first land attempt
https://bugs.webkit.org/show_bug.cgi?id=45583
Add a few more _update_status calls to make it more obvious if a patch is
being retried because tests failed.
* Scripts/webkitpy/tool/commands/queues.py:
2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Andreas Kling.
[Qt] MiniBrowser crashes with multiply windows when closing one of them
https://bugs.webkit.org/show_bug.cgi?id=45536
* MiniBrowser/qt/BrowserView.cpp:
(BrowserView::BrowserView): Reference the context instead of adopting it
because it can be shared across different views.
2010-09-10 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r67241.
http://trac.webkit.org/changeset/67241
https://bugs.webkit.org/show_bug.cgi?id=44709
Accidentally committed.
* Scripts/webkitpy/layout_tests/deduplicate_tests.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2010-09-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709
* Scripts/webkitpy/layout_tests/deduplicate_tests.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2010-09-10 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r67216.
http://trac.webkit.org/changeset/67216
https://bugs.webkit.org/show_bug.cgi?id=44709
Broke
* Scripts/webkitpy/layout_tests/deduplicate_tests.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2010-09-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709
* Scripts/webkitpy/layout_tests/deduplicate_tests.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2010-09-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=45460
This enables DumpRenderTree to run layout tests for DeviceOrientation.
Also declare the LayoutTestController destructor out-of-line.
Otherwise the implicit destructor would cause compiler errors because
of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::~LayoutTestController):
(LayoutTestController::setMockDeviceOrientation):
(LayoutTestController::deviceOrientationClient):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::deviceOrientationClient):
* DumpRenderTree/chromium/WebViewHost.h:
2010-09-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67119.
http://trac.webkit.org/changeset/67119
https://bugs.webkit.org/show_bug.cgi?id=45505
Extra newlines in results (Requested by tony^work on #webkit).
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/TestShell.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(printResponseDescription):
(printNodeDescription):
(printRangeDescription):
(WebViewHost::shouldBeginEditing):
(WebViewHost::shouldEndEditing):
(WebViewHost::shouldInsertNode):
(WebViewHost::shouldChangeSelectedRange):
(WebViewHost::shouldDeleteRange):
(WebViewHost::shouldApplyStyle):
(WebViewHost::didBeginEditing):
(WebViewHost::didChangeSelection):
(WebViewHost::didChangeContents):
(WebViewHost::didEndEditing):
(WebViewHost::decidePolicyForNavigation):
(WebViewHost::didCancelClientRedirect):
(WebViewHost::didStartProvisionalLoad):
(WebViewHost::didReceiveServerRedirectForProvisionalLoad):
(WebViewHost::didFailProvisionalLoad):
(WebViewHost::didCommitProvisionalLoad):
(WebViewHost::didFinishDocumentLoad):
(WebViewHost::didHandleOnloadEvents):
(WebViewHost::didFailLoad):
(WebViewHost::didFinishLoad):
(WebViewHost::didChangeLocationWithinPage):
(WebViewHost::willSendRequest):
(WebViewHost::didReceiveResponse):
(WebViewHost::didFinishResourceLoad):
(WebViewHost::didFailResourceLoad):
(WebViewHost::didDisplayInsecureContent):
(WebViewHost::didRunInsecureContent):
(WebViewHost::printFrameDescription):
2010-09-09 Michael Saboff <msaboff@apple.com>
Unreviewed, adding myself to committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-09-09 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45479
Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
implementation in ResourceLoadDelegate in the Mac port).
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::dumpResourceResponseMIMETypes):
(LayoutTestController::reset):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::setShouldDumpResourceResponseMIMETypes):
(LayoutTestController::shouldDumpResourceResponseMIMETypes):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::shouldDumpResourceResponseMIMETypes):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveResponse):
2010-09-09 Mihai Parparita <mihaip@chromium.org>
Reviewed by Daniel Bates.
svn-apply tries to delete directories it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=45424
isDirectoryEmptyForRemoval had the wrong check. If an item in the
directory is itself a directory, then the directory is definitely
not empty.
* Scripts/svn-apply:
2010-09-09 Chris Fleizach <cfleizach@apple.com>
Fixing GTK and windows build failure.
AX: Support AccessibilityTextMarkers in DRT
https://bugs.webkit.org/show_bug.cgi?id=44778
* DumpRenderTree/AccessibilityTextMarker.h:
(AccessibilityTextMarker::platformTextMarker):
(AccessibilityTextMarkerRange::platformTextMarkerRange):
* DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
(AccessibilityTextMarker::platformTextMarker):
(AccessibilityTextMarkerRange::platformTextMarkerRange):
2010-09-09 Chris Fleizach <cfleizach@apple.com>
Reviewed by David Kilzer.
AX: Support AccessibilityTextMarkers in DRT
https://bugs.webkit.org/show_bug.cgi?id=44778
Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers
that WebCore uses when vending information about its VisiblePositions through AX.
There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
methods for encapsulating and checking equality.
This will allow future bug fixes in the text marker system to be adequately tested.
* DumpRenderTree/AccessibilityTextMarker.cpp: Added.
(toTextMarker):
(isMarkerEqualCallback):
(markerFinalize):
(AccessibilityTextMarker::makeJSAccessibilityTextMarker):
(AccessibilityTextMarker::getJSClass):
(toTextMarkerRange):
(isMarkerRangeEqualCallback):
(markerRangeFinalize):
(AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
(AccessibilityTextMarkerRange::getJSClass):
* DumpRenderTree/AccessibilityTextMarker.h: Added.
(AccessibilityTextMarker::platformTextMarker):
(AccessibilityTextMarkerRange::platformTextMarkerRange):
(AccessibilityTextMarker::AccessibilityTextMarker):
(AccessibilityTextMarker::~AccessibilityTextMarker):
(AccessibilityTextMarker::isEqual):
(AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
(AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
(AccessibilityTextMarkerRange::isEqual):
* DumpRenderTree/AccessibilityUIElement.cpp:
(textMarkerRangeForElementCallback):
(textMarkerRangeLengthCallback):
(textMarkerRangeForMarkersCallback):
(startTextMarkerForTextMarkerRangeCallback):
(endTextMarkerForTextMarkerRangeCallback):
(accessibilityElementForTextMarkerCallback):
(AccessibilityUIElement::textMarkerRangeForElement):
(AccessibilityUIElement::textMarkerRangeLength):
(AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(AccessibilityUIElement::accessibilityElementForTextMarker):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
(AccessibilityTextMarker::AccessibilityTextMarker):
(AccessibilityTextMarker::~AccessibilityTextMarker):
(AccessibilityTextMarker::isEqual):
(AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
(AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
(AccessibilityTextMarkerRange::isEqual):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::textMarkerRangeForElement):
(AccessibilityUIElement::textMarkerRangeLength):
(AccessibilityUIElement::textMarkerRangeForMarkers):
(AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(AccessibilityUIElement::accessibilityElementForTextMarker):
* DumpRenderTree/win/DumpRenderTree.vcproj:
2010-08-25 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
don't delete duplicates needed because of intermediate results
https://bugs.webkit.org/show_bug.cgi?id=44653
Also, output the full path so we can pipe the output to rm.
* Scripts/webkitpy/layout_tests/deduplicate_tests.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2010-09-09 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Andreas Kling.
[Qt] MiniBrowser does not starts properly
https://bugs.webkit.org/show_bug.cgi?id=45459
Do not try set up the first window by calling newWindow on a
newly created BrowserWindow since it creates a new object.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
* MiniBrowser/qt/main.cpp:
(main):
2010-09-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Get ImageDiff building on Win32
https://bugs.webkit.org/show_bug.cgi?id=45353
* DumpRenderTree/gtk/ImageDiff.cpp:
(main): Switch from using strtok to g_strsplit.
2010-09-09 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Andreas Kling.
[Qt] Modify load method of MiniBrowser's BrowserView class
https://bugs.webkit.org/show_bug.cgi?id=45442
Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
* MiniBrowser/qt/BrowserView.cpp:
(BrowserView::load):
* MiniBrowser/qt/BrowserView.h:
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::load):
2010-09-09 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
fix show_results in new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=45413
* Scripts/webkitpy/layout_tests/port/chromium.py:
2010-09-08 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
[Chromium] Fix test results server to make sure
it does not have corrupted data.
results.json file size coulbe be >1M and we split
the data into multiple data store entries in this
case. This patch fixes the issue that the data may
be corrupted if data store error happens in the middle
of saving multiple entries.
https://bugs.webkit.org/show_bug.cgi?id=45063
* TestResultServer/model/datastorefile.py:
2010-09-08 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Fix ignoring return value warning in case of gcc 4.4.4
https://bugs.webkit.org/show_bug.cgi?id=45384
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(testPostURLFile):
If fwrite have written zero byte then the testPostURLFile function
returns with false as tempFile can't be opened.
* DumpRenderTree/qt/ImageDiff.cpp:
(main):
Put fwrite function into an if condition without body to avoid
warning. It is safe because this function writes to the stdout.
2010-09-08 Satish Sampath <satish@chromium.org>
Unreviewed, adding myself to committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-09-08 Hans Wennborg <hans@chromium.org>
Unreviewed.
Adding myself as a committer in committers.py.
* Scripts/webkitpy/common/config/committers.py:
2010-09-08 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Refactor MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=45173
Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
* MiniBrowser/qt/BrowserView.cpp: Added.
(createNewPage):
(BrowserView::BrowserView):
(BrowserView::resizeEvent):
(BrowserView::load):
(BrowserView::view):
* MiniBrowser/qt/BrowserView.h: Added.
(BrowserView::~BrowserView):
* MiniBrowser/qt/BrowserWindow.cpp:
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.pro:
2010-09-08 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Rename DocLoader to CachedResourceLoader because that's what it does.
* Scripts/do-webcore-rename:
2010-09-07 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Ojan Vafai.
Enable incremental results.json generation for non-layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45315
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.) Also add a code to upload results json files to the app-engine server. Need a chromium change to actually start the uploading.
* TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
2010-09-07 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix
Missed one test in mac_unittest.py in previous change; for some
reason the method is listed twice. I will fix both for now, but will
figure this out in a later, not-time-sensitive patch.
https://bugs.webkit.org/show_bug.cgi?id=45357
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2010-09-07 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
test-webkitpy: Fix load error of
webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
* Scripts/webkitpy/layout_tests/port/server_process.py:
Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
and we don't use server_process.py on Win32 Python. However
unittest.py tries to load everything in a module.
2010-09-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kent Tamura.
Fix regression introduced in previous change to new-run-webkit-tests
(bug 45090) to not try to run unittests for the Mac implementation
of the Port interface if we aren't running on a Mac.
Also fix the overrides implementation mock in the chromium unittests
to fix the case where there are overrides checked in that cause
problems.
https://bugs.webkit.org/show_bug.cgi?id=45357
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
2010-09-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: still more unit tests
Clean up and remove unnecessary code. Biggest notable change is
moving the chromium-specific imagediff code from port/base to
port/chromium.
Add more unit tests for run_webkit_tests.py, port/base.py,
port/factory.py, port/dryrun.py, and
layout_package/dump_render_tree_thread.py
This covers almost all of the generic and test code paths except for
a few error paths involving invalid or port-specific command line
arguments, and the code path for uploading results files to the
buildbots.
https://bugs.webkit.org/show_bug.cgi?id=45090
* Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
* Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
* Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
* Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
* Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
* Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
* Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
* Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
* Scripts/webkitpy/layout_tests/port/server_process.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-09-07 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192
Adds a selector on ObjCController for testing
-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
its different uses.
* DumpRenderTree/mac/ObjCController.m:
(+[ObjCController isSelectorExcludedFromWebScript:]):
(+[ObjCController webScriptNameForSelector:]):
(-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
2010-09-07 James Robinson <jamesr@chromium.org>
Rubber-stamped by Dimitri Glazkov.
Move myself from the committer to the reviewer list.
* Scripts/webkitpy/common/config/committers.py:
2010-09-07 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
[chromium] Make a public flag for how DRT generates bitmaps on Linux
https://bugs.webkit.org/show_bug.cgi?id=45133
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dumpImage):
2010-09-07 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Implement --check-layout-test-sys-deps
https://bugs.webkit.org/show_bug.cgi?id=45283
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
* DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
* DumpRenderTree/chromium/TestShellGtk.cpp:
(checkLayoutTestSystemDependencies): Add an empty implementation.
* DumpRenderTree/chromium/TestShellMac.mm:
(checkLayoutTestSystemDependencies): Add an empty implementation.
* DumpRenderTree/chromium/TestShellWin.cpp:
(checkLayoutTestSystemDependencies): Port similar function of test_shell.
2010-09-07 Jessie Berlin <jberlin@apple.com>
Unreviewed. Mac build fix.
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didClearWindowObjectForFrame):
2010-09-07 Jessie Berlin <jberlin@apple.com>
Reviewed by Darin Adler.
Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
https://bugs.webkit.org/show_bug.cgi?id=45217
Make WebKitTestRunner work with this change.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didClearWindowForFrame):
Make sure the ScriptWorld here is the normal world, since that is no longer being done in
WebFrameLoaderClient.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2010-09-07 Philippe Normand <pnormand@igalia.com>
Unreviewed, build fix.
webkit-patch command to find the ports covering a specific layout test
https://bugs.webkit.org/show_bug.cgi?id=42832
* Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
tests are present when building the expectations. This is needed
for the unittests.
2010-09-06 Philippe Normand <pnormand@igalia.com>
Reviewed by Adam Barth.
webkit-patch command to find the ports covering a specific layout test
https://bugs.webkit.org/show_bug.cgi?id=42832
To use it: webkit-patch skipped-ports some/layout/test.html
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/commands/queries_unittest.py:
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-09-07 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Eric Seidel.
[NRWT] Add temp directory to all running drivers.
https://bugs.webkit.org/show_bug.cgi?id=45261
* Scripts/webkitpy/layout_tests/port/webkit.py:
2010-09-06 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
[Chromium/DRT] Empty out user stylesheet after each test run.
https://bugs.webkit.org/show_bug.cgi?id=45282
This should significantly cut down on the number of the mysterious flaky tests
whose diffs looked like the page was blown up to a very lage size. This
was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
which set the base body font to 100px.
Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
the same thread failed.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetWebSettings): Set user stylesheet to an empty URL.
2010-09-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Do not generate pixel results for text/plain resources
https://bugs.webkit.org/show_bug.cgi?id=45253
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
2010-09-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Kent Tamura.
print out correct error when a DRT thread dies in NRWT
https://bugs.webkit.org/show_bug.cgi?id=45281
Not sure why, but with the parens, python 2.6.5 on Linux
gives an error that raise takes 5 arguments and 0 were given.
Didn't test other platforms or python versions, but putting it
all on one line fixes it and correctly prints the exception
from the DRT thread.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-09-06 Eric Seidel <eric@webkit.org>
Unreviewed, just adding some emails from lists.webkit.org.
Update committers.py to include emails from lists.webkit.org
as found by the validate-committer-lists script.
* Scripts/webkitpy/common/config/committers.py:
2010-09-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Small code cleanup in DumpRenderTreeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=45213
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
have to surround the invocation with #ifdefs.
(useLongRunningServerMode): Added.
(runTestingServerLoop): Added.
(initializeGlobalsFromCommandLineOptions): Added.
(runTest): Removed ifdefs.
(main): Use new helper functions.
2010-09-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] EventSender should support modifier keys with mouseDown and mouseUp events
https://bugs.webkit.org/show_bug.cgi?id=45235
Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
methods of the EventSender.
* DumpRenderTree/gtk/EventSender.cpp:
(prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
with the current modifiers.
(contextClickCallback): Always send no modifiers when preparing the mouse event.
(gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
(mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
(mouseUpCallback): Ditto.
2010-09-05 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
https://bugs.webkit.org/show_bug.cgi?id=45155
* DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
(EventSender::handleMouseWheel):
2010-09-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
https://bugs.webkit.org/show_bug.cgi?id=45179
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
2010-09-05 Andreas Kling <andreas.kling@nokia.com>
Rubber-stamped by Daniel Bates.
Adding myself as reviewer.
* Scripts/webkitpy/common/config/committers.py:
2010-09-04 Daniel Bates <dbates@rim.com>
Reviewed by Martin Robinson.
Teach svn-apply/unapply about svn:mergeinfo
https://bugs.webkit.org/show_bug.cgi?id=45236
Recognize the svn:mergeinfo property and ignore it for now.
Currently, svn-apply/unapply recognize only '+' and '-'
property changes within a diff. We should add support
to recognize "Merged" and "Reverse-merged" changes as well.
Because svn:mergeinfo is metadata that is used only by SVN
and tends to be error-prone and/or nuisance (*), we will ignore
it for now.
(*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
* Scripts/VCSUtils.pm:
- Modified parseSvnProperty() to recognize "Merged" and
"Reverse-merged" as the start of a property value.
* Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
- Added the following unit tests:
"simple: add svn:mergeinfo"
"simple: delete svn:mergeinfo"
"simple: modified svn:mergeinfo"
* Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
- Added the following unit tests:
"simple: add svn:mergeinfo"
"simple: delete svn:mergeinfo"
"simple: modified svn:mergeinfo"
"simple: modified svn:mergeinfo using SVN 1.4 syntax"
"'Merged' change followed by 'Merged' change"
"'Reverse-merged' change followed by 'Reverse-merged' change"
* Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
- Added the following unit tests:
"'Merged' change"
"'Reverse-merged' change"
"'Reverse-merged' change followed by 'Merge' change"
"'Merged' change followed by 'Merge' change"
"'Reverse-merged' change followed by 'Reverse-merged' change"
"'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Move test browser to WebKitTools directory
https://bugs.webkit.org/show_bug.cgi?id=45212
Follow other ports like QT and GTK which moved the test browser to
WebKitTools directory.
* CMakeListsEfl.txt: Added.
* EWebLauncher/main.c: Added.
(print_history):
(zoom_level_set):
(on_ecore_evas_resize):
(title_set):
(viewport_set):
(on_title_changed):
(on_progress):
(on_load_finished):
(on_toolbars_visible_set):
(on_toolbars_visible_get):
(on_statusbar_visible_set):
(on_statusbar_visible_get):
(on_scrollbars_visible_set):
(on_scrollbars_visible_get):
(on_menubar_visible_set):
(on_menubar_visible_get):
(on_tooltip_text_set):
(on_inputmethod_changed):
(on_viewport_changed):
(on_mouse_down):
(on_focus_out):
(on_focus_in):
(on_resized):
(on_key_down):
(on_browser_del):
(on_closeWindow):
(quit):
(browserCreate):
(browserDestroy):
(closeWindow):
(main_signal_exit):
(findThemePath):
(main):
2010-09-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
Set project dependencies so that they build serially. This fixes
issues when running run-webkit-tests if DRT is not built yet.
* DumpRenderTree/DumpRenderTree.sln:
2010-09-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
Fix reading configuraiton in NWRT to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=45180
* Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
with the file otherwise.
2010-09-03 Chris Rogers <crogers@google.com>
Unreviewed
Add myself to the committers list
https://bugs.webkit.org/show_bug.cgi?id=45189
* Scripts/webkitpy/common/config/committers.py:
2010-09-03 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
https://bugs.webkit.org/show_bug.cgi?id=45137
* Scripts/webkitpy/layout_tests/port/lighttpd.conf:
2010-09-03 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Add feature detection support to NRWT.
https://bugs.webkit.org/show_bug.cgi?id=41842
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
2010-09-03 Hironori Bono <hbono@chromium.org>
Reviewed by Kent Tamura.
Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
and implements it for Mac.
https://bugs.webkit.org/show_bug.cgi?id=41832
* DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
and bind it so we can call it from JavaScript.
(+[TextInputController isSelectorExcludedFromWebScript:]):
(+[TextInputController webScriptNameForSelector:]):
(-[TextInputController hasSpellingMarker:length:]):
2010-09-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add a unit test for commit-queue retries
https://bugs.webkit.org/show_bug.cgi?id=45162
I think commit-queue retries are not correctly avoiding
build and test on retries. So I started testing the code.
Unfortunately this test did not find the bug. But now
that we have the test we might as well keep it.
I also fixed a broken import in validate-committer-lists.
* Scripts/validate-committer-lists:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-09-02 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove dependency to base/task.h and base/timer.h
https://bugs.webkit.org/show_bug.cgi?id=45091
Task.{cpp,h} introduces a simpler version of Chromium
base/task.h. It doesn't have TupleN and Method.
* DumpRenderTree/DumpRenderTree.gypi:
Add Task.cpp and Task.h
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
(DRTDevToolsAgent::DRTDevToolsAgent):
(DRTDevToolsAgent::reset):
(DRTDevToolsAgent::asyncCall):
(DRTDevToolsAgent::frontendLoaded):
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
(DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::DRTDevToolsClient):
(DRTDevToolsClient::~DRTDevToolsClient):
(DRTDevToolsClient::reset):
(DRTDevToolsClient::asyncCall):
* DumpRenderTree/chromium/DRTDevToolsClient.h:
(DRTDevToolsClient::taskList): Added to use MethodTask<T>.
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::reset):
(EventSender::scheduleAsynchronousClick):
* DumpRenderTree/chromium/EventSender.h:
(EventSender::taskList): Added to use MethodTask<T>.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::WorkQueue::processWorkSoon):
(LayoutTestController::waitUntilDone):
(LayoutTestController::notifyDone):
(LayoutTestController::reset):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::taskList): Added to use MethodTask<T>.
(LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
* DumpRenderTree/chromium/NotificationPresenter.cpp:
(deferredDisplayDispatch):
(NotificationPresenter::show):
* DumpRenderTree/chromium/Task.cpp: Added.
* DumpRenderTree/chromium/Task.h: Added.
2010-09-02 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
https://bugs.webkit.org/show_bug.cgi?id=43181
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMockDeviceOrientation):
2010-08-31 Adam Roben <aroben@apple.com>
Fix flashiness when resizing the browser window on Windows
Reviewed by Sam Weinig.
* MiniBrowser/win/BrowserWindow.cpp:
(BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
periodically fill the window with white.
2010-09-02 Peter Kasting <pkasting@google.com>
Reviewed by Dimitri Glazkov.
Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
https://bugs.webkit.org/show_bug.cgi?id=45073
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::mouseScrollBy):
(EventSender::continuousMouseScrollBy):
(EventSender::sendCurrentTouchEvent):
(EventSender::handleMouseWheel):
* DumpRenderTree/chromium/EventSender.h:
* DumpRenderTree/gtk/EventSender.cpp:
(mouseScrollByCallback):
(continuousMouseScrollByCallback):
2010-09-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Land a patched version of r66542 - change TestRunner to have an
separate cleanup method and fix the ordering of cleanup between
TestRunner and the printing module, and then wrap everything in a
try/finally block to ensure reliable cleanup without needing to
rely on stuff happening in the destructor of the TestRunner.
Also refactor run_webkit_tests.run() to be much smaller and cleaner
by creating a bunch of helper methods and moving more stuff into
the TestRunner class.
This fixes the crash at the end of the linux test run of
new-run-webkit-tests (and undoes the rollout in 66547).
https://bugs.webkit.org/show_bug.cgi?id=44902
* Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
* Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
* Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-09-01 Mark Rowe <mrowe@apple.com>
Reviewed by Adam Roben.
Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
2010-09-01 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
and WebKitTestRunner.
* BuildSlaveSupport/win/kill-old-processes:
2010-09-01 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
[Qt] Remove obsolete include path from DumpRenderTree.pro
* DumpRenderTree/qt/DumpRenderTree.pro:
2010-09-01 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] QWebPage::allowGeolocationRequest should be async API
https://bugs.webkit.org/show_bug.cgi?id=41364
Implements new async API for geolocation permission similar to
Notification. WebPage maintains list of geolocation permission request
QtWebkit and set's when LayoutTestController gets the access from test JS
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::resetSettings):
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::cancelPermission):
(WebCore::WebPage::permissionSet):
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::geolocationPermissionSet):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::setGeolocationPermission):
(LayoutTestController::setGeolocationPermissionCommon):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-09-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Antti Koivisto.
[Qt] Auto-generate WebKit2 forwarding headers
https://bugs.webkit.org/show_bug.cgi?id=44692
* MiniBrowser/qt/BrowserWindow.h: use source style includes
* MiniBrowser/qt/MiniBrowser.pro: add missing include paths
* Scripts/enumerate-included-framework-headers: Removed.
2010-08-31 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Adam Barth.
Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
https://bugs.webkit.org/show_bug.cgi?id=44789
* Scripts/webkitpy/common/net/bugzilla.py:
2010-08-31 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Adam Barth.
ews: Add support for EFL-EWS
https://bugs.webkit.org/show_bug.cgi?id=44982
* QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
* Scripts/webkitpy/common/config/ports.py: Define a EflPort class
and add it to the ports dict.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
EflEWS class.
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
a test case for the EFL EWS.
2010-08-31 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=42195
<rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
makes WebProcess use a different value for this preference than UIProcess thinks it uses.
* WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
which forgets its override.
2010-08-31 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
WebKitTestRunner needs layoutTestController.addUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=42680
WebKitTestRunner needs layoutTestController.addUserScript
https://bugs.webkit.org/show_bug.cgi?id=42681
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::addUserScript):
(WTR::LayoutTestController::addUserStyleSheet):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2010-08-31 Dirk Pranke <dpranke@chromium.org>
Unreviewed, rolling out r66542.
http://trac.webkit.org/changeset/66542
https://bugs.webkit.org/show_bug.cgi?id=44902
r66542 - the weird logging dependencies in Python stuck again ...
* Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
* Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
* Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
* Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
* Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-08-31 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Tony Chang.
Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::markerTextForListItem):
* DumpRenderTree/chromium/LayoutTestController.h:
2010-08-31 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: add more unit tests
Add more unit tests for new-run-webkit-tests; we now cover all but
the most obscure code paths in the generic code. We still need to
add coverage for the http server and web socket paths, and add better
coverage of the platform-specific logic. Note that the rebaselining
tool is still not well tested.
Also clean up some of the configuration logic for the printing
module and the way it interacts with the Python logging module; that
is a crufty interface, to be certain.
https://bugs.webkit.org/show_bug.cgi?id=44902
* Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
* Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
* Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-08-31 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
* Scripts/check-for-global-initializers: Add a file that ends up having global initializers
in a debug build when built with certain compilers.
2010-08-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Isolate all GTK+ typedefs into one file
https://bugs.webkit.org/show_bug.cgi?id=44900
* DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
2010-08-31 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Show more status on queue status pages
https://bugs.webkit.org/show_bug.cgi?id=44938
I upped the number of status lines from 6 to 15 --
this has been bugging me for a while...
I also disabled showing the chromium-win EWS queue
since it's been down for almost 5 months now.
* QueueStatusServer/handlers/dashboard.py:
* QueueStatusServer/handlers/queuestatus.py:
* QueueStatusServer/model/queues.py:
2010-08-31 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Read command line arguments and open them as URLs in new windows
https://bugs.webkit.org/show_bug.cgi?id=44944
Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
* MiniBrowser/qt/main.cpp:
(main):
2010-08-31 Adrian Perez <aperez@igalia.com>
Reviewed by Martin Robinson.
Support scripts to run Buildbot slaves under daemontools (gtk related)
https://bugs.webkit.org/show_bug.cgi?id=40053
* BuildSlaveSupport/gtk: Added.
* BuildSlaveSupport/gtk/README: Added.
* BuildSlaveSupport/gtk/buildbot: Added.
* BuildSlaveSupport/gtk/buildbot/log: Added.
* BuildSlaveSupport/gtk/buildbot/log/run: Added.
* BuildSlaveSupport/gtk/buildbot/run: Added.
* BuildSlaveSupport/gtk/crashmon: Added.
* BuildSlaveSupport/gtk/crashmon/crashmon: Added.
* BuildSlaveSupport/gtk/crashmon/log: Added.
* BuildSlaveSupport/gtk/crashmon/log/run: Added.
* BuildSlaveSupport/gtk/crashmon/run: Added.
* BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
* BuildSlaveSupport/gtk/pulseaudio: Added.
* BuildSlaveSupport/gtk/pulseaudio/run: Added.
* BuildSlaveSupport/gtk/xvfb: Added.
* BuildSlaveSupport/gtk/xvfb/log: Added.
* BuildSlaveSupport/gtk/xvfb/log/run: Added.
* BuildSlaveSupport/gtk/xvfb/run: Added.
2010-08-27 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Notifications should support a click event.
Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
can be simulated during a layout test. Requires storing a list of active
notifications so that they can be referred to later for clicking.
https://bugs.webkit.org/show_bug.cgi?id=44800
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::simulateDesktopNotificationClick):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/NotificationPresenter.cpp:
(NotificationPresenter::simulateClick):
(NotificationPresenter::show):
(NotificationPresenter::cancel):
(NotificationPresenter::objectDestroyed):
* DumpRenderTree/chromium/NotificationPresenter.h:
2010-08-30 Alice Liu <alice.liu@apple.com>
Reviewed by Darin Adler.
Add missing parts of didFinishDocumentLoadForFrame
https://bugs.webkit.org/show_bug.cgi?id=44913
* MiniBrowser/mac/BrowserWindowController.m:
(didFinishDocumentLoadForFrame): Added
(-[BrowserWindowController awakeFromNib]): Updated struct
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize): Updated struct
2010-08-30 Vangelis Kokkevis <vangelis@chromium.org>
Unreviewed: Add myself to the list of Committers.
* Scripts/webkitpy/common/config/committers.py:
2010-08-30 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Fix fast/notifications/notifications-display-close-events.html failure
https://bugs.webkit.org/show_bug.cgi?id=44585
Apply http://crrev.com/48893. We should dispatch display events
asynchronously.
* DumpRenderTree/chromium/NotificationPresenter.cpp:
(deferredDisplayDispatch):
(NotificationPresenter::show):
2010-08-30 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
allow ports with windowed plugins to support windowless plugin tests
https://bugs.webkit.org/show_bug.cgi?id=40730
Ports that implement plugins windowed by default need to have a way of
supporting plugin tests that assume the plugin is windowless. Add this
feature to the tests and support it in the webkit test plugin. Also
add mouse and keyboard event logging to the webkit-test plugin on Unix.
Unskip the following tests on Qt:
plugins/mouse-events.html
plugins/keyboard-events.html
plugins/mouse-events-fixedpos.html
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginSetProperty):
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_handle_event):
2010-08-30 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix after addition of fileapi directory in WebCore.
* wx/build/settings.py:
2010-08-30 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed compilation error, now that we have included the
GtkVersioning.h we have to remove some version dependent code from
EventSender.
* DumpRenderTree/gtk/EventSender.cpp:
2010-08-30 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
are deprecated
https://bugs.webkit.org/show_bug.cgi?id=44787
We have replaced GtkVersioning.cpp with GtkVersioning.c and
created a function (getDefaultGDKPointerDevice) to get the pointer
of the window with the new APIs. We added that function to DRT and
copyandpaste unit test.
* DumpRenderTree/gtk/EventSender.cpp:
(prepareMouseButtonEvent):
(mouseMoveToCallback):
(keyDownCallback):
* GNUmakefile.am:
2010-08-30 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add new window menu to MiniBrowser
Implement newWindow function and add a menu item for opening new window in MiniBrowser.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/main.cpp:
(main):
2010-08-29 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
Make failing the download step fail the build
https://bugs.webkit.org/show_bug.cgi?id=44298
If the download step fails on a test bot, this ensures that
the build goes red instead of only the download step going red
and the overall build staying green.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
2010-08-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove dependency to base/keyboard_codes.h
https://bugs.webkit.org/show_bug.cgi?id=44847
* DumpRenderTree/chromium/EventSender.cpp:
Use webkit_support::VKEY_* instead of base::VKEY_*.
2010-08-29 Darin Adler <darin@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=40589
* Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
function names.
2010-08-26 Holger Hans Peter Freyther <holger@moiji-mobile.com>
Reviewed by Darin Adler.
[iExploder] Add new CSS Properties and HTML Attributes
https://bugs.webkit.org/show_bug.cgi?id=44746
Updated the files with the update-iexploder-cssproperties script
and manually readded the -webkit-binding CSS Property to the list.
* iExploder/htdocs/cssproperties.in:
* iExploder/htdocs/htmlattrs.in:
* iExploder/htdocs/htmltags.in:
2010-08-26 Holger Hans Peter Freyther <holger@moiji-mobile.com>
Reviewed by Darin Adler.
Fix Coverage build after the addition of ANGLE
https://bugs.webkit.org/show_bug.cgi?id=44744
ANGLE is using libtool to build a static library and the version of
libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
parameters. The easiest way to handle this is to not build ANGLE with
coverage information.
This is achieved by applying the XCode options for each project
separately and exclude ANGLE.
* Scripts/build-webkit: Remove -framework AppKit due link errors.
* Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
2010-08-28 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix after directory addition.
* wx/build/settings.py:
2010-08-28 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472
* DumpRenderTree/chromium/AccessibilityController.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::reset):
(AccessibilityController::getRootElement):
(AccessibilityController::dumpAccessibilityNotifications):
* DumpRenderTree/chromium/AccessibilityController.h:
(AccessibilityController::shouldDumpAccessibilityNotifications):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didChangeAccessibilityObjectChildren):
* DumpRenderTree/chromium/WebViewHost.h:
2010-08-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update commit-queue failure message
https://bugs.webkit.org/show_bug.cgi?id=44798
The commit-queue auto-restarts itself and has for a very long time.
No need for people to email me to request a restart anymore.
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/common/net/bugzilla_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-07-27 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795
Added basic full screen support to DumpRenderTree: when a webView requests
that DumpRenderTree go "full screen", just call the provided callback listener object's
will/did Enter/Exit full screen methods. Also, register a new user default which
enables full screen support.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:supportsFullscreenForElement:]):
(-[UIDelegate webView:enterFullscreenForElement:listener:]):
(-[UIDelegate webView:exitFullscreenForElement:listener:]):
2010-08-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Unreviewed. Add myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-08-27 Kent Tamura <tkent@chromium.org>
Reviewed by Pavel Feldman.
[DRT/Chromium] Fix inspector test failures
https://bugs.webkit.org/show_bug.cgi?id=44748
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
(DRTDevToolsAgent::createClientMessageLoop):
Returns a valid WebKitClientMessageLoop instance
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
2010-08-26 Jon Honeycutt <jhoneycutt@apple.com>
Add Windows WebKit2 Tester to buildbot
<rdar://problem/7887703>
Reviewed by Dan Bernstein.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2010-08-26 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42152
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
(LoadHTMLStringItem::invoke): Implementation using
webkit_web_frame_load_string().
2010-08-25 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/8334338> run-webkit-tests sometimes hangs when using
WebKitTestRunner (44331)
Reviewed by Darin Adler.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
The hang occurs when WebKitTestRunner begins launching the WebKit2
web process then exits before it finishes launching. Work around this by
looking for the --print-supported-features argument and exiting without
creating the web process.
2010-08-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: add rebaselining tests for test_expectations
This patch adds more unit tests for the rebaselining code in the
test_expectations module. It doesn't add any tests for
rebaseline_chromium_webkit_tests itself; that will come some other
time.
https://bugs.webkit.org/show_bug.cgi?id=44648
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2010-08-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
Ignore new soup API that we decided to merge into the soup backend
while it is being cooked. It follows the libsoup style, and will
be removed from WebKit as soon as it is merged into libsoup.
* Scripts/webkitpy/style/checker.py:
2010-08-26 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DumpRenderTree runs only one test from command mode
https://bugs.webkit.org/show_bug.cgi?id=44012
Enables support to run multiple test files and single
folder containing html files in stand alone mode
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::processArgsLine):
(WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(WebCore::DumpRenderTree::setStandAloneMode):
(WebCore::DumpRenderTree::isStandAloneMode):
* DumpRenderTree/qt/main.cpp:
(main):
2010-08-25 Martin Robinson <mrobinson@igalia.com>
Updating webkitpy test expectations.
* Scripts/webkitpy/tool/steps/steps_unittest.py:
2010-08-25 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
fix the always squash git config
https://bugs.webkit.org/show_bug.cgi?id=44651
Fix help text and apparently underscores are not allowed
in git config keys.
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/tool/steps/commit.py:
2010-08-25 Darin Adler <darin@apple.com>
Reviewed by John Sullivan.
* Scripts/commit-log-editor: Fix perl warning for people who have no
value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
2010-08-25 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
stop blocking commits when the bots are red
https://bugs.webkit.org/show_bug.cgi?id=44644
This check currently is just annoying. It doesn't actually
help keep the tree green. We can always add it back later
if we decide the tree is generally more green.
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
2010-08-25 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
https://bugs.webkit.org/show_bug.cgi?id=38912
I know of nothing else to do but skip all media tests for the cq.
* Scripts/webkitpy/tool/steps/runtests.py:
2010-08-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: add more unit tests for test_expectations
This adds unit tests to cover (almost?) all of the non-rebaselining
functionality.
https://bugs.webkit.org/show_bug.cgi?id=44579
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2010-08-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: add more unit tests
This change adds more unit tests for the image_diff, test_failures,
and test_files modules, bringing them to 100% coverage (and adds a
couple tests to run_webkit_tests while we're at it).
This test also turns on the "dryrun" port for testing when run on
the mac, increasing coverage in a few other places.
https://bugs.webkit.org/show_bug.cgi?id=44578
* Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
* Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
* Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
* Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
* Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-08-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: add more unit tests for layout_package/printing.py
This change adds more unit tests to get the test coverage to 100%
for the printing module. This code is actually pretty crufty and
has some layering violations that need to be cleaned up but I'll
save that for another CL after we get all the unit tests written and
we fix the multithreading issues. At least now we'll be able to tell
if we break things.
https://bugs.webkit.org/show_bug.cgi?id=44576
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
* Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2010-08-25 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
new-run-webkit-tests should respect set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=44633
Moves the getting of the configuration into the base Port so that
chromium ports use it as well. In the downstream chromium port,
this should still just return Release.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
2010-08-25 Tony Chang <tony@chromium.org>
Not reviewed, changing svn props for a script.
* Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
2010-08-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove WebKit2 from core builders
https://bugs.webkit.org/show_bug.cgi?id=44625
This builder was added to the core builders by accident. It doesn't
appear to be green enough to be a core builder yet.
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/buildbot_unittest.py:
2010-08-19 Adam Roben <aroben@apple.com>
Test that NP_Initialize and NP_GetEntryPoints are called in the
correct order
The order differs between Mac and Windows (see r38858).
Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
NP_Initialize when loading QuickTime when running
plugins/embed-attributes-setting.html in WebKit2 on Windows
Reviewed by John Sullivan.
* DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
a boolean to record whether NP_GetEntryPoints has been called.
(NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
called yet. This matches Flash and QuickTime's behavior.
(NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
yet. This matches Silverlight's behavior.
2010-08-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
Cairo and EFL port shouldn't depend on glib.
https://bugs.webkit.org/show_bug.cgi?id=44354
Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
adoptPlatformRef.
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isSelected):
2010-08-25 Ojan Vafai <ojan@chromium.org>
Fix order of Timothy's email address. The script, and
other tools all assume that the first email is the bugzilla address.
* Scripts/webkitpy/common/config/committers.py:
2010-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Pavel Feldman.
[DRT/Chromium] Fix 26 inspector test crashes
https://bugs.webkit.org/show_bug.cgi?id=44580
- DRTDevToolsAgent has a reference to the main WebView. So we
should not clear it in closeDevTools() and should clear it in
~TestShell().
- DRTDevToolsClient has a reference to a DevTools WebView and no
way to update it. So we should delete DRTDevToolsClient instances
in closeDevTools().
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::~TestShell):
(TestShell::closeDevTools):
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
https://bugs.webkit.org/show_bug.cgi?id=44584
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue and EWS bots should report all failures
https://bugs.webkit.org/show_bug.cgi?id=41820
Right now commit-queue/EWS only report failures when the
patch under testing fails. We should report all failures
to the status server so that we can diagnose when the bots
are wedged w/o needing to log into the machines.
I also reduced the amount of data we upload since we've seen
timeouts during status upload.
* Scripts/webkitpy/common/system/executive.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Remove HTML5 parser testing infrastructure now that we don't need it
https://bugs.webkit.org/show_bug.cgi?id=44581
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
(initializeGlobalsFromCommandLineOptions):
* Scripts/old-run-webkit-tests:
* Scripts/test-html5-parser: Removed.
2010-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Fix 28 inspector test crashes
https://bugs.webkit.org/show_bug.cgi?id=44574
Reset DevToolsClient and DevToolsAgent before closing a DevTools
WebView in order to avoid accessing to a deleted WebView instance.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::closeDevTools):
2010-08-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: clean up code for test_types, test_failures
Add a bunch of unit tests for webkitpy.layout_tests.test_types and
webkitpy.layout_tests.layout_package.test_failures, and remove
some dead code and otherwise clean up things.
https://bugs.webkit.org/show_bug.cgi?id=44559
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2010-08-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: revise unit testing strategy for test failures
This change revamps the way we store test data for new-run-webkit-tests.
Previously we had a few copies of test files from the main test tree.
Now we have a bunch of completely fake test data and use the test
data to generate different kinds of test failures, getting
much better coverage.
https://bugs.webkit.org/show_bug.cgi?id=44556
* Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
* Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
* Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
* Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
* Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
* Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
* Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
* Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
* Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
* Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
* Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
* Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
* Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
* Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
* Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
* Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2010-08-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
speed up new-run-webkit-tests unit tests
Add a --no-record-results flag that turns off generating the JSON
results file on every test run. Generating the file requires us to
fetch the old results down from the bots, which can be slow. This
flag is off by default.
Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
These changes together shorten the test cycle from ~4.5s to ~1.5s
- a 3x speedup.
https://bugs.webkit.org/show_bug.cgi?id=44553
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-08-24 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] fix the platform result fallback order on mac/win
https://bugs.webkit.org/show_bug.cgi?id=44483
* Scripts/webkitpy/layout_tests/port/google_chrome.py:
2010-08-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Set a device to the event struct when building with GTK+ 3.x, it's
mandatory.
* DumpRenderTree/gtk/EventSender.cpp:
(keyDownCallback):
2010-08-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
https://bugs.webkit.org/show_bug.cgi?id=44534
Fix two double-frees introduced in my previous commit.
* DumpRenderTree/gtk/EventSender.cpp:
(contextClickCallback): Copy the event before using it again.
(keyDownCallback): Ditto.
2010-08-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
https://bugs.webkit.org/show_bug.cgi?id=44534
* DumpRenderTree/gtk/EventSender.cpp:
(prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
when setting it on the event. It is dereferenced by gdk_event_free(...).
(contextClickCallback): Ditto.
(mouseDownCallback): Ditto.
(mouseUpCallback): Ditto.
(mouseMoveToCallback): Ditto.
(mouseWheelToCallback): Ditto.
(sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
(dispatchEvent): Ditto. Also free the event when we are done with it.
(keyDownCallback): Use gdk_event_new and reference the GdkWindow.
2010-08-24 Andras Becsi <abecsi@webkit.org>
[Qt] WebKit2 build fix.
* Scripts/enumerate-included-framework-headers:
Remove stray global option form sed.
2010-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Jeremy Orlow.
[DRT/Chromium] Support for IndexedDB tests
https://bugs.webkit.org/show_bug.cgi?id=44490
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Enable IndexedDB.
2010-08-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
https://bugs.webkit.org/show_bug.cgi?id=44465
Initialize the axes field of mouse button and motion events to null.
This is the value that should be used for events originating from the
mouse device.
* DumpRenderTree/gtk/EventSender.cpp:
(prepareMouseButtonEvent): Initalize button event axes field to null.
(mouseMoveToCallback): Initialize motion event axes field to null.
2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65703.
http://trac.webkit.org/changeset/65703
https://bugs.webkit.org/show_bug.cgi?id=44460
"Causing lots of crashes on Snow Leopard when running the
layout tests" (Requested by eseidel2 on #webkit).
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NP_Initialize):
(NP_GetEntryPoints):
2010-08-23 Jon Honeycutt <jhoneycutt@apple.com>
Layout tests do not run when using WebKitTestRunner in a Debug build.
https://bugs.webkit.org/show_bug.cgi?id=44409
Reviewed by Dan Bernstein.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeInjectedBundlePath):
Use InjectedBundle_debug.dll when building Debug.
2010-08-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
https://bugs.webkit.org/show_bug.cgi?id=42026
If a GTK+ 3.x build is present return that as the library to use,
otherwise fallback to the GTK+ 2.x build.
* Scripts/webkitdirs.pm:
2010-08-23 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Find needed forwarding headers for WebKit2 automatically
https://bugs.webkit.org/show_bug.cgi?id=44336
* MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
The new script does not satisfy the needs of this file however using normal includes
is generally better here.
* MiniBrowser/qt/MiniBrowser.pro: Added include paths.
* Scripts/enumerate-included-framework-headers: Enumerates headers included from the
given frameworks by files in the current directory (and subdirectories).
In the future this needs to be rewritten in perl for being able to use on Windows.
2010-08-22 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
https://bugs.webkit.org/show_bug.cgi?id=43010
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::applyPrefs):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
2010-08-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Remove specialized retain/release functions in favor of a single one for WKTypeRefs
https://bugs.webkit.org/show_bug.cgi?id=44386
* MiniBrowser/mac/AppDelegate.m:
(didRecieveMessageFromInjectedBundle):
(didNavigateWithNavigationData):
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate applicationWillTerminate:]):
* MiniBrowser/mac/BrowserStatisticsWindowController.m:
(-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
(-[BrowserStatisticsWindowController dealloc]):
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithPageNamespace:]):
(-[BrowserWindowController fetch:]):
(-[BrowserWindowController windowWillClose:]):
(-[BrowserWindowController applicationTerminating]):
(closePage):
(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didClearWindowObjectForFrame):
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::goToURL):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::~PlatformWebView):
2010-08-20 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
WebKit does not build with Python 2.3
https://bugs.webkit.org/show_bug.cgi?id=44373
Replaced the function sorted() by a call to sort()
on the entry list.
The function sorted() has been added to Python 2.4.
The function method sort() of List works with older
versions of Python.
* Scripts/create-html-entity-table:
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Pavel Feldman.
Web Inspector: Inspector tests were disabled for GTK.
https://bugs.webkit.org/show_bug.cgi?id=43977
* Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
path before running tests.
2010-08-20 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
svn-apply doesn't detect empty line with Windows line endings
after property value
https://bugs.webkit.org/show_bug.cgi?id=43981
Part 2 of 2
Add unit tests that were not landed in the first commit.
* Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Added the following test cases:
"SVN: binary file (isBinary true) using Windows line endings"
"SVN: property diff, followed by file change diff using Windows line endings"
"SVN: two consecutive property diffs using Windows line endings"
"SVN: binary file with executable bit change usng Windows line endings"
"SVN: binary file followed by property change on different file using Windows line endings"
"SVN: binary file followed by file change on different file using Windows line endings"
"SVN: file change diff with property change, followed by property change diff using Windows line endings"
"SVN: file change diff with property change, followed by file change diff using Windows line endings"
* Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
- Added the following test cases:
"add svn:executable, followed by empty line and start of next diff using Windows line endings"
"add svn:executable, followed by empty line and start of next property diff using Windows line endings"
"multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
"multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
"add svn:executable, followed by empty line and start of binary patch using Windows line endings"
"multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
"multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
"single-line '+' with trailing new line using Windows line endings"
"single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
"single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
"multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
* Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
- Added the following test cases:
"single-line '-' change followed by empty line with Windows line endings"
"multi-line '+' change and start of binary patch with Windows line endings"
2010-08-20 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
svn-apply doesn't detect empty line with Windows line endings
after property value
https://bugs.webkit.org/show_bug.cgi?id=43981
Fixes an issue where an empty line following the property value
in an SVN property change diff would not be detected if it had
Windows line endings (i.e. ended in CRLF). Hence it was consumed
as if it was part of a multi-line property value.
* Scripts/VCSUtils.pm:
- Modified parseSvnPropertyValue() to detect empty line
with Windows line endings.
- Added toWindowsLineEndings().
* Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Added the following test cases:
"SVN: binary file (isBinary true) using Windows line endings"
"SVN: property diff, followed by file change diff using Windows line endings"
"SVN: two consecutive property diffs using Windows line endings"
"SVN: binary file with executable bit change usng Windows line endings"
"SVN: binary file followed by property change on different file using Windows line endings"
"SVN: binary file followed by file change on different file using Windows line endings"
"SVN: file change diff with property change, followed by property change diff using Windows line endings"
"SVN: file change diff with property change, followed by file change diff using Windows line endings"
* Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
- Added the following test cases:
"add svn:executable, followed by empty line and start of next diff using Windows line endings"
"add svn:executable, followed by empty line and start of next property diff using Windows line endings"
"multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
"multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
"add svn:executable, followed by empty line and start of binary patch using Windows line endings"
"multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
"multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
"single-line '+' with trailing new line using Windows line endings"
"single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
"single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
"multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
* Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
- Added the following test cases:
"single-line '-' change followed by empty line with Windows line endings"
"multi-line '+' change and start of binary patch with Windows line endings"
2010-08-19 David Kilzer <ddkilzer@apple.com>
BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
* MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction): Updated method signature.
(decidePolicyForNewWindowAction): Updated method signature.
2010-08-19 Adam Roben <aroben@apple.com>
Test that NP_Initialize and NP_GetEntryPoints are called in the
correct order
The order differs between Mac and Windows (see r38858).
Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
NP_Initialize when loading QuickTime when running
plugins/embed-attributes-setting.html in WebKit2 on Windows
Reviewed by Sam Weinig.
* DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
a boolean to record whether NP_GetEntryPoints has been called.
(NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
called yet. This matches Flash and QuickTime's behavior. Crash on Mac
if NP_GetEntryPoints has been called already. This matches
Silverlight's behavior.
2010-08-19 Adam Roben <aroben@apple.com>
Make build-webkittestrunner build TestNetscapePlugIn on Windows
Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
Reviewed by Sam Weinig.
* WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
Threaded it in between ImageDiff and InjectedBundleGenerated.
2010-08-19 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
install rietveld's upload script from a versioned url
https://bugs.webkit.org/show_bug.cgi?id=44291
autoinstall expects the file at a given URL to never change.
In order to be able to update the file, we need to be able to
change the path.
* Scripts/webkitpy/thirdparty/__init__.py:
2010-08-19 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
add --webkit_patch_id to reitveld uploads
https://bugs.webkit.org/show_bug.cgi?id=44289
This is the first step in having rietveld store which
patches have been uploaded and getting rid of the
in-rietveld flag.
* Scripts/webkitpy/common/net/rietveld.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/postcodereview.py:
2010-08-19 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Adjust my status from committer to reviewer
https://bugs.webkit.org/show_bug.cgi?id=44277
* Scripts/webkitpy/common/config/committers.py:
2010-08-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: remove injected script fetcher from test harness.
https://bugs.webkit.org/show_bug.cgi?id=44266
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
2010-08-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: There is no need in resource-based InjectedScript.js source.
Now that we populate front-end after its onload handler, we don't need
to install injected script early. Exposing injected script source on the WebCore
level here.
https://bugs.webkit.org/show_bug.cgi?id=44029
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
(DRTDevToolsAgent::runtimePropertyChanged):
(DRTDevToolsAgent::delayedFrontendLoaded):
(DRTDevToolsAgent::frontendLoaded):
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
2010-08-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen.
[Gtk] Enable view mode media feature layout test
https://bugs.webkit.org/show_bug.cgi?id=43278
Add view mode media feature testing infrastructure, and add
placeholder methods for the other platforms'
LayoutTestControllers.
* DumpRenderTree/LayoutTestController.cpp:
(setViewModeMediaFeatureCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setViewModeMediaFeature):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setViewModeMediaFeature):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setViewModeMediaFeature):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setViewModeMediaFeature):
2010-08-18 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Make it so the WebKit2 test slave runs the WebKit2 tests
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
2010-08-18 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Make run-webkit-tests --webkit-test-runner build DumpRenderTree
in addition to WebKitTestRunner to get the DumpRenderTreeSupport
module and the TestNetscapePlugin.
* Scripts/old-run-webkit-tests:
2010-08-18 Adam Roben <aroben@apple.com>
Fix hang when saving crash logs on Windows
* Scripts/old-run-webkit-tests:
(setUpWindowsCrashLogSaving):
(END):
Pass -s to regtool so it will write the Auto value as a string instead
of as a number. This was causing a "do you want to debug?" dialog to
appear.
2010-08-17 Victor Wang <victorw@chromium.org>
Unreviewed. Fixed chromium incremental test json upload.
Quote builder name and test results server in url.
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2010-08-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
https://bugs.webkit.org/show_bug.cgi?id=44124
Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard
Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
Symbian dependencies.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::init):
(LauncherWindow::toggleFullScreenMode):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/mainwindow.cpp:
(MainWindow::buildUI):
2010-08-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
new-run-webkit-tests: remove --show-sources option
--show-sources is pretty much obsolete with --trace everything, so
I'm removing it.
Also rename a couple of methods in the TestTextDiff class to make their
intended visibility (private) more obvious.
https://bugs.webkit.org/show_bug.cgi?id=44143
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2010-08-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
This code bit-rotted at some point more than a year ago, and nobody seems
to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
should support instead, making this flag unnecessary anyway.
https://bugs.webkit.org/show_bug.cgi?id=44141
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
2010-08-17 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
Update json results generator to have incremental json including
results for tests that pass in current run but failed before.
https://bugs.webkit.org/show_bug.cgi?id=44119
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-08-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
fix test-webkitpy, add easy way to find a checkout root
test-webkitpy currently doesn't work right if run from someplace other
than the checkout root, and it spews a bunch of debug logging because
the deduplicate_tests tests contaminates the test environment.
This patch cleans up the deduplicate_tests unit tests, and creates
two new methods in scm.py: find_checkout_root() and default_scm(),
both of which use a single algorithm for guessing what checkout root
to use if you aren't explicitly told one from a path.
https://bugs.webkit.org/show_bug.cgi?id=44001
* Scripts/deduplicate-tests:
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
* Scripts/webkitpy/tool/main.py:
2010-08-17 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
Add support to the test results server for downloading json that
contains test list only.
This is for json results generator to generate incremental json
results so that it includes results not only for tests failed in
current run, but also tests failed before.
Also set the results type to "N" (no data) instead of "P" (pass)
if test results cannot be found in incremental json file.
https://bugs.webkit.org/show_bug.cgi?id=44117
* TestResultServer/handlers/testfilehandler.py:
* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:
2010-08-17 Adam Roben <aroben@apple.com>
Use the right path style
* Scripts/old-run-webkit-tests:
2010-08-17 Adam Roben <aroben@apple.com>
Fix typo
* Scripts/old-run-webkit-tests:
2010-08-17 Adam Roben <aroben@apple.com>
Don't hang when running run-webkit-tests as a non-Administrator on
Vista/7
* Scripts/old-run-webkit-tests:
(setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
post-mortem debugger, rather than using NTSD itself. The latter waits
for user input when it fails to set the registry values; the former
does not.
2010-08-17 Adam Roben <aroben@apple.com>
Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
save crash logs on Windows
The crash logs are saved to /tmp/layout-test-results and have names
like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
Unfortunately, crashes in the WebKit2 web process are recorded as
time-outs by run-webkit-tests. Fixing this is covered by
<http://webkit.org/b/44121>.
Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
DumpRenderTree should save a stack trace and/or dump file when it
crashes
Reviewed by Sam Weinig.
* DumpRenderTree/win/DumpRenderTree.cpp:
(exceptionFilter):
(main):
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::exceptionFilter):
(WTR::TestController::platformInitialize):
These changes set up an exception filter that prints #CRASHED to
stderr, then lets the exception propagate normally. This allows
run-webkit-tests to detect when we've crashed even when a post-mortem
debugger attaches to the process.
* Scripts/old-run-webkit-tests:
(top level): Declared some variables used by the crash-log-saving
code.
(openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
that the post-mortem debugger has access to it.
(toCygwinPath): Added. This is the opposite of toWindowsPath.
(readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
stderr, consider it a crash.
(setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
debugger, then sets ntsd as the post-mortem debugger. ntsd is
configured to save a crash log and then quit automatically.
(END): Added. Restores the previous post-mortem debugger when the
script exits.
2010-08-17 Victor Wang <victorw@chromium.org>
Reviewed by ojan@chromium.org.
Update test results server:
1. Normalize test results and times after merging (prune tests where
all runs pass or do not have data, truncate all test items to max
number of builds)
2. times should be int not string.
3. when inserting a new test item, should keep old data regardless
whether or not they have same item type with new one.
https://bugs.webkit.org/show_bug.cgi?id=43861
* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:
2010-08-16 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add WebKit2 Mac tester to buildbot.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
2010-08-16 Paul Sawaya <psawaya@apple.com>
Reviewed by Chris Marrin.
Added shader validation via ANGLE
https://bugs.webkit.org/show_bug.cgi?id=42405
Added ANGLE to webkit build
* Scripts/build-webkit:
2010-08-16 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix, do not build WebCore as a convenience library as this leads to
errors in the Win build w/export symbols and causes problems with DOM bindings
debugging in gdb.
* DumpRenderTree/wscript:
* Scripts/build-webkit:
* wx/browser/wscript:
* wx/build/settings.py:
* wx/build/waf_extensions.py:
2010-08-16 Dan Bernstein <mitz@apple.com>
Build fix.
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage): Initialize the contentsSizeChanged member.
(WTR::TestController::initialize): Ditto.
2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Handle content size change in WebKit2
Re-landing after fix.
https://bugs.webkit.org/show_bug.cgi?id=43198
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65419.
http://trac.webkit.org/changeset/65419
https://bugs.webkit.org/show_bug.cgi?id=44053
Broke the Windows build (Requested by bbandix on #webkit).
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Handle content size change in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=43198
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2010-08-16 Ariya Hidayat <ariya@sencha.com>
Add my new email address to committers.py.
* Scripts/webkitpy/common/config/committers.py:
2010-08-16 Zoltan Horvath <zoltan@webkit.org>
Add my old e-mail addresses to committers.py.
* Scripts/webkitpy/common/config/committers.py:
2010-08-15 Jon Honeycutt <jhoneycutt@apple.com>
WebEditorClient::didBeginEditing is never called in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42939
Reviewed by Sam Weinig.
* WebKitTestRunner/PlatformWebView.h:
Declare focus().
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Focus the PlatformWebView.
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::focus):
Stubbed.
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::focus):
Focus the view.
2010-08-15 Jon Honeycutt <jhoneycutt@apple.com>
run-webkit-tests should not strip editing callbacks when using
WebKitTestRunner on Windows
https://bugs.webkit.org/show_bug.cgi?id=44000
Reviewed by Mark Rowe.
* Scripts/old-run-webkit-tests:
Leave $stripEditingCallbacks undefined until we look for command-line
arguments. If using WebKit2, set it to 0 if not explicity set on the
command line. Later, set it to isCygwin() to match old behavior if it is
not yet defined.
2010-08-15 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
* wx/build/settings.py:
2010-08-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Kenneth Rohde Christiansen.
[GTK] autogen.sh not executed if build-webkit options change
https://bugs.webkit.org/show_bug.cgi?id=42266
Rerun autogen.sh in situations where the arguments to build-webkit have
changed since the previous build. This will fix some issues on the bots
where the build does not notice changes to default build-webkit arguments.
* Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
2010-08-14 Eric Seidel <eric@webkit.org>
Unreviewed. Another fix to support python 2.3.
Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949
* Scripts/webkitpy/thirdparty/simplejson/decoder.py:
- It looks like our simplejson is version 1.7.3 which
should be python 2.3 compatible. But someone modified
our copy slightly from the original source.
I've removed the relative import in hopes this fixes
the problem.
2010-08-13 Eric Seidel <eric@webkit.org>
Unreviewed. Build fix only.
Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949
* Scripts/create-html-entity-table:
- Hack sys.path to avoid executing 2.5 dependent python
on systems (like chromium-win and Tiger) which do not have 2.5 python.
2010-08-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename some concepts in HTML entity search to be more self-documenting
https://bugs.webkit.org/show_bug.cgi?id=44004
Reflect name change in generator script.
* Scripts/create-html-entity-table:
2010-08-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949
A script for generating the C++ state data structure describing all the
entities from a JSON description.
* Scripts/create-html-entity-table: Added.
2010-08-13 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
check for exceptions on all threads, not just the first thread.
This change also changes the logging behavior for wedged threads
to only dump the stacks of threads that are actually wedged.
Refactor the thread classes in the dump_render_tree_thread module
to make the contract between TestRunner and TestShellThread clearer.
Added a bunch of unit tests.
https://bugs.webkit.org/show_bug.cgi?id=38561
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2010-08-13 Kenichi Ishibashi <bashi@google.com>
Reviewed by Shinichiro Hamaji.
Add test_expectations.txt syntax checker to check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=43899
Just utilizing layout_tests/layout_package/test_expectations.py for checking
the syntax of test_expectations.txt.
This change also moves tab checking class from style/checkers/text.py to
style/checkers/common.py for sharing code.
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checkers/common.py:
* Scripts/webkitpy/style/checkers/common_unittest.py:
* Scripts/webkitpy/style/checkers/test_expectations.py: Added.
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
* Scripts/webkitpy/style/checkers/text.py:
* Scripts/webkitpy/style_references.py:
2010-08-12 Jon Honeycutt <jhoneycutt@apple.com>
WebKitTestRunner does not correctly resize WebView for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=43945
Reviewed by Sam Weinig.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::sizeWebViewForCurrentTest):
Allow for a Windows-style path.
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::resizeTo):
Call SetWindowPos to resize the view window.
2010-08-12 David Levin <levin@chromium.org>
Build break fix.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): Removed usage
of a variable that doesn't exist in the class.
2010-08-12 Jon Honeycutt <jhoneycutt@apple.com>
WebKitTestRunner needs to run tests without using native controls
https://bugs.webkit.org/show_bug.cgi?id=43772
Reviewed by Sam Weinig.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
Call platformInitializeContext().
* WebKitTestRunner/TestController.h:
Declare platformInitializeContext().
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformInitializeContext):
Stubbed.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitializeContext):
Call WKContextSetShouldPaintNativeControls() to disable native control
drawing.
2010-08-12 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
WebKitTestRunner should be more aggressive about ensuring consistent state between tests
https://bugs.webkit.org/show_bug.cgi?id=43653
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::isTestRunning):
(WTR::InjectedBundle::):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::stopLoading):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
Don't do any work if we are not currently running a test.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
* WebKitTestRunner/StringFunctions.h:
(WTR::toCF):
Add conversion function for WKURLRef -> CFURLRef
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::runTest):
(WTR::TestController::didFinishLoadForFrame):
* WebKitTestRunner/TestController.h:
(WTR::TestController::):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
* WebKitTestRunner/TestInvocation.h:
Move resetting code to TestController.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::runUntil):
* WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::runUntil):
* WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
Move runUntil to TestController.
2010-08-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed.
Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-08-12 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
Merge pretty printers for gdb.
https://bugs.webkit.org/show_bug.cgi?id=43850
We need to update webcore.py because basic string classes have moved to WTF from WebCore.
It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
webcore.py is left for backward compatibility.
* gdb/webcore.py:
* gdb/webkit.py: Added.
* gdb/wtf.py: Removed.
2010-08-11 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] add google-chrome layout test result directories
https://bugs.webkit.org/show_bug.cgi?id=43889
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2010-08-11 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Disable accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=43894
Disable accelerated compositing because DRT is not ready for
it. This change fixes hundreds of test crashes on Windows and
Linux.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetWebSettings):
2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Adding my Collabora personality to the list.
* Scripts/webkitpy/common/config/committers.py:
2010-08-11 Martin Robinson <mrobinson@igalia.com>
Adding myself as a reviewer.
* Scripts/webkitpy/common/config/committers.py:
2010-08-11 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Perl warnings when running commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=43856
Fixes Perl warnings introduced by the patch for Bug #40548.
Perl doesn't have symbolic names for True/False. Instead, we
should use boolean values. Moreover, the variable installedEditorApplication
is not be used and should be renamed builtEditorApplication so that it
uses the existing machinery to set the commit log editor application.
* Scripts/commit-log-editor:
2010-08-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Trying waiting for httpd lock in the EWS
https://bugs.webkit.org/show_bug.cgi?id=43833
If this works, we can probably run the tests on the mac-ews, which
would be very exciting. :)
* Scripts/webkitpy/tool/steps/runtests.py:
2010-08-11 Marcus Bulach <bulach@chromium.org>
Reviewed by Eric Seidel.
Check in a script to list redundant test outputs.
https://bugs.webkit.org/show_bug.cgi?id=37630
If e.g. platform/mac-leopard is missing an expected test output, we
fall back on platform/mac. This means it's possible to grow redundant
test outputs, where we have the same expected data in both a platform
directory and another platform it falls back on.
(original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
* Scripts/deduplicate-tests: Added.
* Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
2010-08-11 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
https://bugs.webkit.org/show_bug.cgi?id=43853
LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
to slots at all.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::animatedFlip):
(LauncherWindow::animatedYFlip):
* QtTestBrowser/launcherwindow.h:
2010-08-11 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Hausmann.
[Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
https://bugs.webkit.org/show_bug.cgi?id=43851
All window options data (including the bool holding if the view is either QWebView or
QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
getting broken.
Patch addresses this issue.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::toggleWebView):
(LauncherWindow::toggleAcceleratedCompositing):
2010-08-10 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
https://bugs.webkit.org/show_bug.cgi?id=43831
Only instantiate QStateMachine and friends associated to the YRotation action on demand.
* QtTestBrowser/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::animatedYFlip):
2010-08-11 Darin Adler <darin@apple.com>
Reviewed by John Sullivan.
Improved editor options for prepare-ChangeLog and commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=40548
* Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
values like "xed --launch --wait" work properly.
* Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
use a command line tool with the $openChangeLogs feature.
2010-08-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove InjectDispatch.js
https://bugs.webkit.org/show_bug.cgi?id=43835
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
2010-08-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
webkit-patch should refuse to run under Win32 Python
https://bugs.webkit.org/show_bug.cgi?id=40962
Given that there are lots of places in webkit-patch's code that
assume unix-style filenames (forward slashes), webkit-patch fails
with weird file-not-found errors when run under a native windows
Python. It would be nice if we just trapped this and errored out
at the beginning, rather than producing unpredictable errors.
* Scripts/webkit-patch:
2010-08-10 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
Chromium build fix for r65107.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):
2010-08-10 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/tests/media/video-cookie.html fails
https://bugs.webkit.org/show_bug.cgi?id=42240
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setAlwaysAcceptCookies): create the
SoupCookieJar if it does not exist. Otherwise the accept policy
won't be set.
2010-08-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Oliver Hunt.
Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733
Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
Calls functions with the same names on AnimationController for the
mainFrame.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/LayoutTestController.cpp:
(suspendAnimationsCallback):
(resumeAnimationsCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):
2010-08-10 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Ojan Vafai.
[Chromium/DRT] Enable saving layout test results.
https://bugs.webkit.org/show_bug.cgi?id=43796
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
parameters to the new-run-webkit-tests, including the name
of the test results server.
2010-08-10 Jian Li <jianli@chromium.org>
More chromium build fix.
* DumpRenderTree/chromium/MockSpellCheck.cpp:
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):
* DumpRenderTree/chromium/NotificationPresenter.cpp:
(NotificationPresenter::grantPermission):
(NotificationPresenter::show):
(NotificationPresenter::checkPermission):
2010-08-10 Jian Li <jianli@chromium.org>
Chromium build fix.
* DumpRenderTree/chromium/MockSpellCheck.cpp:
* DumpRenderTree/chromium/NotificationPresenter.cpp:
2010-08-10 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
Update test results server merge logic so the aggregated
results and times are updated for tests that are
in aggragated json but not in incremental json.
Also update unittest to test this case.
https://bugs.webkit.org/show_bug.cgi?id=43769
* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:
2010-08-09 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QtTestBrowser: proper set scene rect
When resizesToContents is ON scene's rect is set to the boundary of
the mainFrame. However, navigating to other web page should keep resizing
scene's rect according to the new document loaded. Patch addresses this issue.
Now resizesToContents and scrolling properly work on QtTestBrowser.
* QtTestBrowser/webview.cpp:
(WebViewGraphicsBased::setPage):
(WebViewGraphicsBased::contentsSizeChanged):
(WebViewGraphicsBased::setResizesToContents):
(WebViewGraphicsBased::resizeEvent):
* QtTestBrowser/webview.h:
2010-08-09 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QtTestBrowser: Clean up LauncherWindow code.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
(LauncherWindow::init): Fixed comments.
(LauncherWindow::applyPrefs): Move the method around.
(LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
2010-08-09 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
It gets control+0 the same visual effect as control++ or control-.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::toggleZoomTextOnly):
2010-08-09 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QtTestBrowser:: make m_zoomLevels a static member.
Not all instances of LauncherWindow need its own m_zoomLevel.
* QtTestBrowser/launcherwindow.cpp:
* QtTestBrowser/launcherwindow.h:
2010-08-09 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add zoom support for injected bundle
https://bugs.webkit.org/show_bug.cgi?id=43759
Use zoom factor SPI to implement zoom related eventSender functions.
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
2010-08-09 Gavin Barraclough <barraclough@apple.com>
Speculative chromium build fix III.
* DumpRenderTree/chromium/MockSpellCheck.h:
* DumpRenderTree/chromium/NotificationPresenter.h:
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost::addClearHeader):
(WebViewHost::clearHeaders):
2010-08-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
increase the number of test results that we save
https://bugs.webkit.org/show_bug.cgi?id=43763
Now that we do incremental uploads, we can increase the number of
results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2010-08-09 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] DRT error print statement incorrectly tries to print a FILE*
https://bugs.webkit.org/show_bug.cgi?id=43747
* DumpRenderTree/chromium/ImageDiff.cpp:
(writeFile): pass the correct pointer.
2010-08-09 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
Upload incremental test results json to server by default.
https://bugs.webkit.org/show_bug.cgi?id=43743
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-08-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
EWS bots wait 2 minutes between patches
https://bugs.webkit.org/show_bug.cgi?id=43731
* Scripts/webkitpy/tool/bot/queueengine.py:
- Don't sleep after failures. This was a hold-over from
an earlier design.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- EWS bots were not properly reporting true/false from process_work_item.
They were always returning None, thus false, thus always logging
as a failure and sleeping 2 minutes after each patch.
2010-08-09 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Stub out EventSender for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=43703
* WebKitTestRunner/DerivedSources.make:
* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
Add ability to pass javascript arguments to the wrapped object.
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
(WTR::EventSendingController::create):
(WTR::EventSendingController::EventSendingController):
(WTR::EventSendingController::~EventSendingController):
(WTR::EventSendingController::wrapperClass):
(WTR::setExceptionForString):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::contextClick):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
(WTR::EventSendingController::makeWindowObject):
* WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::reset):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::eventSendingController):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didClearWindowForFrame):
Add stubbed out EventSenderController.
* WebKitTestRunner/InjectedBundle/GCController.h:
Remove incorrect comment.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:
Add new files.
2010-08-08 Kent Tamura <tkent@chromium.org>
Unreviewed, trivial fix.
Fix "WindowsError: [Error 32] The process cannot access the file
because it is being used by another process" introduced by r64959.
* BuildSlaveSupport/test-result-archive:
2010-08-08 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
Chromium buildbot: Avoid "zip" command dependency
https://bugs.webkit.org/show_bug.cgi?id=43470
* BuildSlaveSupport/test-result-archive:
For Chromium port, creates a zip archive with zipfile package of Python
instead of external "zip" command. We'd like to avoid additional
command installation.
2010-08-08 Jon Honeycutt <jhoneycutt@apple.com>
WebKitTestRunner should add the QuickTime dir to the PATH environment
variable
https://bugs.webkit.org/show_bug.cgi?id=43686
Reviewed by Dan Bernstein.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::addQTDirToPATH):
Copied from DRT.
(WTR::TestController::platformInitialize):
Call addQTDirToPath().
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
Link to shlwapi.lib for SHGetValue.
2010-08-07 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
WebKitTestRunner needs layoutTestController.dumpTitleChanges
<rdar://problem/8213861>
https://bugs.webkit.org/show_bug.cgi?id=42683
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpTitleChanges):
(WTR::LayoutTestController::shouldDumpTitleChanges):
2010-08-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKitTestRunner needs to print onunload handler information
<rdar://problem/8213831>
https://bugs.webkit.org/show_bug.cgi?id=42703
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::operator<<):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2010-08-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add additional loader client functions need to complete WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=43684
Remove unnecessary and jarring underscores as well.
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didClearWindowObjectForFrame):
(didCreatePage):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2010-08-07 Dan Bernstein <mitz@apple.com>
Build fix.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
to JSGCController.{cpp,h} relative to the build root.
2010-08-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKitTestRunner needs GCController
<rdar://problem/8213834>
https://bugs.webkit.org/show_bug.cgi?id=42701
* WebKitTestRunner/DerivedSources.make:
* WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
* WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
(WTR::setProperty):
* WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
(WTR::GCController::create):
(WTR::GCController::GCController):
(WTR::GCController::~GCController):
(WTR::GCController::wrapperClass):
(WTR::GCController::collect):
(WTR::GCController::collectOnAlternateThread):
(WTR::GCController::getJSObjectCount):
(WTR::GCController::makeWindowObject):
* WebKitTestRunner/InjectedBundle/GCController.h: Added.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::reset):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::bundle):
(WTR::InjectedBundle::gcController):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didClearWindowForFrame):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::keepWebHistory):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:
2010-08-05 Jon Honeycutt <jhoneycutt@apple.com>
WebKitTestRunner needs to be able to set the font smoothing type
https://bugs.webkit.org/show_bug.cgi?id=43406
Reviewed by Adam Roben.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set the font smoothing level to
kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
2010-08-06 Jon Honeycutt <jhoneycutt@apple.com>
Fix a missed variable rename.
Unreviewed.
* Scripts/old-run-webkit-tests:
2010-08-06 Jon Honeycutt <jhoneycutt@apple.com>
mac-wk2/Skipped should be used on Windows when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=43494
Reviewed by Adam Roben.
* Scripts/old-run-webkit-tests:
If the platform is win-wk2, also read the mac-wk2 skipped list.
2010-08-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Should revoke scheduled tasks
https://bugs.webkit.org/show_bug.cgi?id=43560
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
(DRTDevToolsAgent::reset): Calls RevokeAll().
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::reset): Calls RevokeAll().
* DumpRenderTree/chromium/DRTDevToolsClient.h:
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::reset): Calls RevokeAll().
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset): Calls RevokeAll().
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
2010-08-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Fix the DRT build on Mac OS X
* DumpRenderTree/qt/DumpRenderTree.pro:
2010-08-06 Jochen Eisinger <jochen@chromium.org>
Reviewed by Pavel Feldman.
Rietvield's upload.py moved to a different location.
https://bugs.webkit.org/show_bug.cgi?id=43613
* Scripts/webkitpy/thirdparty/__init__.py:
2010-05-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
QueueStatusServer needs better queue-status pages
https://bugs.webkit.org/show_bug.cgi?id=39562
The primary goal of this patch is to display queue
positions somewhere on the site so that it's easier
for commit-queue users to know when their pach will
be landed. I also tried to improve the root page
to be more useful than the previous wall of status text.
* QueueStatusServer/handlers/recentstatus.py:
* QueueStatusServer/main.py:
* QueueStatusServer/model/queues.py:
* QueueStatusServer/templates/recentstatus.html:
2010-08-05 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
Add option to generate/upload incremental json results to test result server.
Also refactor the json results generator unittest code to test
incremental and aggregated json results.
https://bugs.webkit.org/show_bug.cgi?id=43519
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-08-05 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Unify blob related feature defines to ENABLE(BLOB).
https://bugs.webkit.org/show_bug.cgi?id=43081
* Scripts/build-webkit:
2010-08-05 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Add speech input controller mock in WebKit and a layout test.
https://bugs.webkit.org/show_bug.cgi?id=43477
Added LayoutTestController::setMockSpeechInputResultCallback method.
* DumpRenderTree/LayoutTestController.cpp:
(setMockSpeechInputResultCallback): Wrapper invoking the member function.
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setMockSpeechInputResult): Sets the mock result.
(LayoutTestController::speechInputController): Creates the mock controller.
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::speechInputController): Creates the mock controller.
* DumpRenderTree/chromium/WebViewHost.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setMockSpeechInputResult): dummy method.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMockSpeechInputResult): dummy method.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setMockSpeechInputResult): dummy method.
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
(LayoutTestController::setMockSpeechInputResult):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
(LayoutTestController::setMockSpeechInputResult):
2010-08-04 Adam Roben <aroben@apple.com>
Fix the path to TestNetscapePlugin's directory on Windows
Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
load TestNetscapePlugin
Reviewed by Jon Honeycutt.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeTestPluginDirectory):
TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
next to WebKitTestRunner.exe. Previously we were passing the directory
that contains WebKitTestRunner.exe. Also fixed some leaks.
2010-08-05 Kenichi Ishibashi <bashi@google.com>
Reviewed by Shinichiro Hamaji.
check-webkit-style returns non-zero when patch is entirely minus lines.
https://bugs.webkit.org/show_bug.cgi?id=38169
* Scripts/check-webkit-style:
Check whether a patch contains modified files that are entirely minus lines.
* Scripts/webkitpy/style/filereader.py:
Add a variable that holds number of files that contain only deleted lines.
* Scripts/webkitpy/style/patchreader.py:
Count up modified files that contain only deleted lines.
2010-08-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
DevTools: get rid of delayed command dispatching on front-end side.
https://bugs.webkit.org/show_bug.cgi?id=43479
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
(DRTDevToolsAgent::detach):
(DRTDevToolsAgent::frontendLoaded):
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::~DRTDevToolsClient):
(DRTDevToolsClient::sendFrontendLoaded):
* DumpRenderTree/chromium/DRTDevToolsClient.h:
2010-08-04 Kenichi Ishibashi <bashi@google.com>
Reviewed by Shinichiro Hamaji.
Fixes check-webkit-style false positive on "new uint32_t."
https://bugs.webkit.org/show_bug.cgi?id=43077
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
2010-08-04 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove base/linked_ptr.h dependency
https://bugs.webkit.org/show_bug.cgi?id=43472
Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
We need to use RefPtr<> because m_pendingEntry points an object in
m_entries or not in m_entries.
* DumpRenderTree/chromium/TestNavigationController.cpp:
(TestNavigationEntry::create): Added.
(TestNavigationController::activeEntry):
(TestNavigationController::didNavigateToEntry):
(TestNavigationController::discardPendingEntry):
(TestNavigationController::insertEntry):
(TestNavigationController::navigateToPendingEntry):
* DumpRenderTree/chromium/TestNavigationController.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::loadURLForFrame):
Use TestNavigationEntry::create().
(WebViewHost::updateURL):
Use RefPtr<>.
(WebViewHost::updateSessionHistory):
Remove unnecessary static_cast<>.
2010-08-04 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Fix a problem that "archived test results" step doesn't work on Chromium buildbots
https://bugs.webkit.org/show_bug.cgi?id=43333
* BuildSlaveSupport/test-result-archive:
- Make layoutTestResultsDir local and pass it to archiveTestResults()
- Adjust layoutTestResultsDir for Chromium
2010-08-04 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
NRWT: websocket_server startup detection failure
https://bugs.webkit.org/show_bug.cgi?id=43466
* Scripts/webkitpy/layout_tests/port/websocket_server.py:
Increase timeout value: 5 second -> 10 second
2010-08-04 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
-. Add result.json incremental merging functionality to test results app engine.
-. blobstore is not suitable for AE data merging and there is no API to
programatically edit existing blob or write a new one yet, so replace blobstore
with datastore. If file is oversize (>1000*1000 bytes), store file data in
multiple datastore entries.
-. Fix styles.
Test: jsonresults_unittest to test merging logics.
https://bugs.webkit.org/show_bug.cgi?id=38599
* TestResultServer/handlers/dashboardhandler.py:
* TestResultServer/handlers/menu.py:
* TestResultServer/handlers/testfilehandler.py:
* TestResultServer/main.py:
* TestResultServer/model/dashboardfile.py:
* TestResultServer/model/datastorefile.py: Added.
* TestResultServer/model/jsonresults.py: Added.
* TestResultServer/model/jsonresults_unittest.py: Added.
* TestResultServer/model/testfile.py:
* TestResultServer/templates/uploadform.html:
2010-08-04 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
[Qt] [QtTestBrowser] Remove unneeded QAction class members
https://bugs.webkit.org/show_bug.cgi?id=43518
LauncherWindow class has two totally unneeded class members: m_flopAnimated and
m_flipYAnimated. Also, in initializeView method there are some dead code block
trying to connect them at the wrong time, when they have not been instanciated.
This patch:
- removes the two cited class members in favor of local variables in createChrome method;
- removes the dead code block.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
* QtTestBrowser/launcherwindow.h:
2010-08-04 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Hausmann and Kenneth Christiansen.
[Qt] [QtTestBrowser] Clean up static and global menu state controls
https://bugs.webkit.org/show_bug.cgi?id=43448
After LauncherWindow class was refactored out of from main.cpp, all global variables that
were hanging in main.cpp became temporarily public static class members of newly added
LauncherWindow class. This design was not properly handling the initial purpose of the
global variables: newly created launcher windows should inherit the settings of the originating
one.
In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
comprises all data needed to handling the goal described above.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
holding all user settings configured in the menus and command line.
It also receices an optional QGraphicsScene points in case we are doing
a "Clone Window".
(LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
value.
(LauncherWindow::initializeView): Ditto.
(LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
(LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
apply the preferences is provided by m_userData.
(LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
(LauncherWindow::toggleResizesToContents): Ditto.
(LauncherWindow::toggleWebGL): Ditto.
(LauncherWindow::toggleFrameFlattening): Ditto.
(LauncherWindow::toggleQGLWidgetViewport): Ditto.
(LauncherWindow::changeViewportUpdateMode): Ditto.
(LauncherWindow::showFPS): Ditto.
(LauncherWindow::newWindow): Changed to pass the userData.
(LauncherWindow::cloneWindow): Ditto.
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/main.cpp:
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):
(main):
2010-08-04 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix for gcc not importing all symbols from convenience libraries.
Works on 10.6 only for Mac until the build system is reworked.
* wx/build/settings.py:
2010-08-04 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Change wording in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=43241
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
2010-08-04 Aaron Boodman <aa@chromium.org>
Reviewed by Eric Seidel.
prepare-ChangeLog fails mysteriously if curl doesn't support ssl
https://bugs.webkit.org/show_bug.cgi?id=43460
* Scripts/prepare-ChangeLog:
2010-08-03 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[DRT] Assertion failed when drag and move a draggable element.
https://bugs.webkit.org/show_bug.cgi?id=41695
mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
But Cocoa doesn't call mouseDragged() until dragging is done.
Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
on UIDelegate failed when mouseDragged() is called during dragging.
This change eliminated the mouseDragged() call when dragging begins,
which is implicated by draggingInfo instance.
* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseMoveToX:Y:]):
Test: fast/events/dragging-mouse-moves.html
2010-08-02 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
https://bugs.webkit.org/show_bug.cgi?id=40002
The code in LayoutTestController::setGeolocationPermission() was moved to
setGeolocationPermissionCommon() to allow each port to provide its own
implementation of setGeolocationPermission().
For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
new permission, so it can call back to WebCore if permission requests are in
progress and are waiting for a response. A minor fix to the Mac
MockGeolocationProvider was also required to make sure that the mock provider
calls back to WebCore when it is first started.
For other ports, LayoutTestController::setGeolocationPermission() is not
implemented.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::setGeolocationPermissionCommon):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setGeolocationPermission):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setGeolocationPermission):
* DumpRenderTree/mac/MockGeolocationProvider.mm:
(-[MockGeolocationProvider registerWebView:]):
* DumpRenderTree/mac/UIDelegate.h:
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
(-[UIDelegate setGeolocationPermission:]):
(-[UIDelegate dealloc]):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setGeolocationPermission):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setGeolocationPermission):
2010-08-03 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Implement --testshell-startup-dialog
https://bugs.webkit.org/show_bug.cgi?id=40616
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main): Check --testshell-startup-dialog, and call openStartUpDialog()
if it is specfied.
* DumpRenderTree/chromium/TestShell.h:
Declare openStartUpDialog().
* DumpRenderTree/chromium/TestShellGtk.cpp:
(openStartupDialog):
* DumpRenderTree/chromium/TestShellMac.mm:
(openStartupDialog):
* DumpRenderTree/chromium/TestShellWin.cpp:
(openStartupDialog):
2010-08-03 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove dependency of base/md5.h
https://bugs.webkit.org/show_bug.cgi?id=43403
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dumpImage): Use wtf/MD5.h
2010-08-03 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by David Kilzer.
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
Part 6 - LayoutTest and Cleanup
Allow tests to delete application caches and set application cache
origin quotas, so they can be tested.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
(clearAllApplicationCachesCallback): should delete all application caches.
(setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
(LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
Mac implementation.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::clearAllApplicationCaches): delete application caches.
(LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
(-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
Stub implementations for other platforms.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::setApplicationCacheOriginQuota):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::setApplicationCacheOriginQuota):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::setApplicationCacheOriginQuota):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::setApplicationCacheOriginQuota):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::setApplicationCacheOriginQuota):
2010-08-03 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by David Kilzer.
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
Change old style calls to make use of the managers.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setDatabaseQuota):
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2010-08-03 Mark Rowe <mrowe@apple.com>
Add a new Leopard build slave to run the release tests.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2010-08-03 Jon Honeycutt <jhoneycutt@apple.com>
WebKitTestRunner needs to activate the Mac font ascent hack
https://bugs.webkit.org/show_bug.cgi?id=43404
Reviewed by Darin Adler.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize):
Call WKBundleActivateMacFontAscentHack().
2010-08-03 Alex Milowski <alex@milowski.com>
Reviewed by Beth Dakin.
Changed the default for MathML support so that is is enabled by default.
* Scripts/build-webkit:
2010-08-03 Sam Weinig <sam@webkit.org>
Roll r64566 back in this time with all the overloads in place..
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::shouldInsertNode):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
* WebKitTestRunner/StringFunctions.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010-08-03 Sam Weinig <sam@webkit.org>
Rollout r64566. It broke all the WebKit2 tests.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::operator<<):
(WTR::InjectedBundlePage::shouldInsertNode):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
* WebKitTestRunner/StringFunctions.h: Removed.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::createWKURL):
(WTR::WKStringToUTF8):
(WTR::TestInvocation::resetPreferencesToConsistentValues):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010-08-03 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WTR: Move all the utility functions for working with strings to a shared header.
https://bugs.webkit.org/show_bug.cgi?id=43386
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::shouldInsertNode):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
* WebKitTestRunner/StringFunctions.h: Added.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010-08-02 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
[Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
https://bugs.webkit.org/show_bug.cgi?id=43168
QGraphicsWebView resizesToContents property has to work together with QWebPage's
setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::applyPrefs):
* QtTestBrowser/webview.cpp:
(WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
needed when toggle resizesToContents on/off.
(WebViewGraphicsBased::resizeEvent):
* QtTestBrowser/webview.h:
(WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
(WebViewGraphicsBased::customLayoutSize): Getter helper.
2010-08-03 Jochen Eisinger <jochen@chromium.org>
Unreviewed. Adding myself as committer.
* Scripts/webkitpy/common/config/committers.py:
2010-08-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: Get rid of DevTools RPC.
https://bugs.webkit.org/show_bug.cgi?id=43335
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
(DRTDevToolsAgent::sendMessageToInspectorFrontend):
(DRTDevToolsAgent::call):
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
(DRTDevToolsCallArgs::DRTDevToolsCallArgs):
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::sendMessageToBackend):
(DRTDevToolsClient::call):
* DumpRenderTree/chromium/DRTDevToolsClient.h:
2010-08-02 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove dependencies to some Chromium headers
https://bugs.webkit.org/show_bug.cgi?id=43396
* DumpRenderTree/chromium/CppVariant.h:
Remove base/basictypes.h because webkit_support.h contains it.
* DumpRenderTree/chromium/EventSender.cpp:
(getCurrentEventTimeSec): Use new wrapper function.
* DumpRenderTree/chromium/TestNavigationController.h:
Remove base/basictypes.h because webkit_support.h contains it.
* DumpRenderTree/chromium/TestShell.cpp:
(dumpHistoryItem): Use new wrapper function.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::cancelledError): Use new wrapper function.
(WebViewHost::didFailResourceLoad): Use new wrapper function.
2010-08-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT implement execCommand()
https://bugs.webkit.org/show_bug.cgi?id=35351
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
(LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
(LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
2010-08-02 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
* Scripts/old-run-webkit-tests:
2010-08-02 Jon Honeycutt <jhoneycutt@apple.com>
WebKitTestRunner needs to support loading custom fonts (via the
WEBKIT_TESTFONTS environment variable)
https://bugs.webkit.org/show_bug.cgi?id=42782
Reviewed by Adam Roben.
* WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
(WTR::fontsPath):
Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
as this directory doesn't appear to be created anymore.
(WTR::activateFonts):
Loop through the fonts, and call AddFontResourceExW() for each.
2010-08-02 Jon Honeycutt <jhoneycutt@apple.com>
Restore the WebKitTestRunner.sln that was removed, and remove the
correct one.
Rubber-stamped by Sam Weinig.
* WebKitTestRunner/WebKitTestRunner.sln: Added.
* WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
2010-08-02 Jon Honeycutt <jhoneycutt@apple.com>
Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
Remove the unused WebKitTestRunner.sln.
Reviewed by Sam Weinig.
* WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
* WebKitTestRunner/WebKitTestRunner.sln: Removed.
* WebKitTestRunner/win/InjectedBundle.vcproj: Added.
* WebKitTestRunner/win/WebKitTestRunner.sln:
2010-08-02 Sam Weinig <sam@webkit.org>
Fix the windows build.
* WebKitTestRunner/win/main.cpp:
2010-07-29 Jon Honeycutt <jhoneycutt@apple.com>
Add a Skipped list on Windows, and have run-webkit-tests respect it.
Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
there are zero tests failing
https://bugs.webkit.org/show_bug.cgi?id=43374
Reviewed by Adam Roben.
* Scripts/old-run-webkit-tests:
If using WebKitTestRunner and Apple Windows WebKit, set the platform to
win-wk2. When building the result hierarchy, if the platform is win-wk2,
add it first to the list of platforms.
2010-08-02 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.setCanOpenWindows
https://bugs.webkit.org/show_bug.cgi?id=42321
WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
https://bugs.webkit.org/show_bug.cgi?id=42779
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
waiting for the first call to didCreatePage.
(WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
is created. Put other pages into a map.
(WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
of the main page.
(WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
the main page.
* WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
closeOtherPages functions.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
the main page affect dumping.
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): Initialize the new
m_shouldCloseExtraWindows member.
(WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
(WTR::LayoutTestController::windowCount): Added.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
windowCount, shouldCloseExtraWindowsAfterRunningTest, and
m_shouldCloseExtraWindows.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::shared): Return a pointer to the shared copy, but
don't allocate and leak it. This seemed cleaner than adding an explicit
finalize call to go along with the explicit initialize call.
(WTR::TestController::TestController): Added calls to the initialize and
run function, which are now done automatically.
(WTR::TestController::~TestController): Added, since it's called now.
(WTR::closeOtherPage): Added. Used to close pages other than the main page.
(WTR::createOtherPage): Added. Used to create pages other than the main page.
(WTR::TestController::initialize): Added code to set up createOtherPage.
(WTR::TestController::run): Removed unused return value.
* WebKitTestRunner/TestController.h: Made constructor and destructor public,
and initialize and run private. Changed m_mainWebView to be an OwnPtr.
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
to avoid releasing the window twice. Another way to handle it would be to
remove the release, but this approach is slightly more robust because it works
even if some other code calls the close method an extra time.
* WebKitTestRunner/mac/main.mm:
(main): Use a stack-allocated TestController object instead of calling
initalize and run on a globally allocated one.
2010-08-02 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
add myself to the reviewers list
https://bugs.webkit.org/show_bug.cgi?id=43366
* Scripts/webkitpy/common/config/committers.py:
2010-08-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Cache JSNPObjects and fix bugs in the object map
https://bugs.webkit.org/show_bug.cgi?id=43368
Test that we correctly throw exceptions when trying to do things to a JSObject that used to
wrap an NPObject that came from a plug-in that is now destroyed.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
(PluginTest::Object::getProperty):
(PluginTest::Object::NP_GetProperty):
(PluginTest::Object::npClass):
* DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
(NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
(NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* GNUmakefile.am:
2010-08-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Gtk] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=35170
Add support to all event senders for simulating keypad insert
and print screen keys.
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::keyDown): Add support for generating keypad insert and print screen.
* DumpRenderTree/gtk/EventSender.cpp:
(keyDownCallback): Ditto.
* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::keyDown): Ditto.
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback): Ditto.
2010-08-02 Martin Robinson <mrobinson@igalia.com>
Build fix for building against development versions of GTK+. GTK 2.22
has not yet been released, so these function definitions must be conditionalized
on the development version.
* DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
2010-08-02 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] use ChromiumDriver on Linux when running webkit tests
https://bugs.webkit.org/show_bug.cgi?id=43273
* Scripts/webkitpy/layout_tests/port/chromium.py:
2010-08-02 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Always initialize GTK
https://bugs.webkit.org/show_bug.cgi?id=43327
Call gtk_init() in order to fix plugin test crash.
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main): Pass argc/argv to platformInit().
* DumpRenderTree/chromium/TestShell.h:
* DumpRenderTree/chromium/TestShellGtk.cpp:
(platformInit): Update parameters, call gtk_init().
* DumpRenderTree/chromium/TestShellMac.mm:
(platformInit): Update parameters.
* DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit): Update parameters.
2010-08-02 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Generate forwarding headers for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=43336
* Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
2010-08-02 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Kent Tamura.
WebSocket server should start with SO_REUSEADDR
https://bugs.webkit.org/show_bug.cgi?id=43329
Pulls in pywebsocket-0.5.2.
pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
http://code.google.com/p/pywebsocket/source/detail?r=273
* Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
2010-08-01 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove string_util.h dependency
https://bugs.webkit.org/show_bug.cgi?id=43312
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::pathToLocalResource):
Use string::find() instead of StartsWithASCII().
(LayoutTestController::cppVariantToInt32):
Use strtol() instead of StringToNumber().
2010-08-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add ability to reset frame names for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=43316
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::reset):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2010-08-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement NPN_RemoveProperty
https://bugs.webkit.org/show_bug.cgi?id=43315
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Add NPRuntimeRemoveProperty.cpp
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_GetStringIdentifier):
(PluginTest::NPN_GetIntIdentifier):
(PluginTest::NPN_RemoveProperty):
Add NPN_ helpers.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
Support more NPClass functions.
* DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
(NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
Test for NPN_RemoveProperty.
(NPRuntimeRemoveProperty::TestObject::hasMethod):
(NPRuntimeRemoveProperty::TestObject::invoke):
Add a testRemoveProperty method.
(NPRuntimeRemoveProperty::NPP_GetValue):
Return the test object.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* GNUmakefile.am:
Add NPRuntimeRemoveProperty.cpp
2010-07-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add an NPObject class template helper to TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=43288
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
Add some template magic to be able to figure out if a class has a member function of a given type.
(PluginTest::Object::create):
Create an object.
(PluginTest::Object::invokeDefault):
Add dummy function, this should never be called.
(PluginTest::Object::Object):
Initialize m_pluginTest to 0.
(PluginTest::Object::~Object):
Add virtual destructor.
(PluginTest::Object::NP_Allocate):
Create a new object.
(PluginTest::Object::NP_Deallocate):
Delete the object.
(PluginTest::Object::NP_InvokeDefault):
Call invokeDefault.
(PluginTest::Object::npClass):
Initialize the NPClass struct.
* DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
(DocumentOpenInDestroyStream::NPP_DestroyStream):
Move this inline.
* DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
(PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
(PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
Use the PluginTest::Object class template.
2010-07-31 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
Add back WKBundleFrameCopyInnerText to fix ~50 test failures
due to SVGElements not having the innerText function.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpFrameText):
2010-07-30 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
Add structured message passing from the injected bundle to UIProcess
* MiniBrowser/mac/AppDelegate.m:
(didRecieveMessageFromInjectedBundle):
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didClearWindowForFrame):
(didRecieveMessage):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::didReceiveMessage):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/TestInvocation.h:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010-07-30 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
Make WKArrayRef more usable.
Remove now unnecessary const_casts.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpDescendantFrameScrollPositions):
(WTR::dumpDescendantFramesText):
2010-07-30 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
Add first pass of structured message passing.
Update Minibrowser and WebKitTestRunner to work with the new post message
function.
* MiniBrowser/mac/AppDelegate.m:
(didRecieveMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):
* MiniBrowser/mac/MiniBrowser_Prefix.pch:
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didReceiveTitleForFrame):
(didClearWindowForFrame):
(didCreatePage):
(willDestroyPage):
(didRecieveMessage):
(WKBundleInitialize):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::_didReceiveMessage):
(WTR::InjectedBundle::didReceiveMessage):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010-07-30 Anders Carlsson <andersca@apple.com>
Try to fix the layout test failures.
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_get_value):
2010-07-29 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Replace plugins/npruntime/bindings-test.html with a more sophisticated test
https://bugs.webkit.org/show_bug.cgi?id=43232
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Add PluginScriptableNPObjectInvokeDefault.cpp.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
Remove invokeDefault callback function.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::create):
Move this to the top of the file.
(PluginTest::NPP_GetValue):
Add default implementation.
(PluginTest::NPN_CreateObject):
Add NPN_ wrapper.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
(PluginTest::identifier):
Add identifier getter.
* DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
(DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
Add "using namespace std".
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_GetValue):
Give PluginTest a chance to return a value.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* GNUmakefile.am:
Add PluginScriptableNPObjectInvokeDefault.cpp.
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_get_value):
Give PluginTest a chance to return a value.
2010-07-30 Steve Block <steveblock@google.com>
Reviewed by Steve Block.
Add LayoutTestController methods to test DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39589
* DumpRenderTree/LayoutTestController.cpp:
(setMockDeviceOrientationCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setMockDeviceOrientation):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setMockDeviceOrientation):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMockDeviceOrientation):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setMockDeviceOrientation):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setMockDeviceOrientation):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setMockDeviceOrientation):
* Scripts/build-webkit:
2010-07-29 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
[Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
https://bugs.webkit.org/show_bug.cgi?id=43209
When -resizes-to-content was being passed as a command line parameter it was simply
not being set (although the corresponding menu item was marked as ON).
User had to toggle the menu OFF and then ON again for it to take place.
Reason: LauncherWindow::applyPrefs method sets many user options passed in from
the command line, but not resizesToContents. Patch addresses that.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::applyPrefs):
(LauncherWindow::toggleResizesToContents):
* QtTestBrowser/webview.h:
(WebViewGraphicsBased::resizesToContents):
2010-07-29 Antonio Gomes <tonikitoo@webkit.org>
Rubber-stamped by Simon Fraser.
[Qt] QtTestBrowser: more method grouping and clean ups.
Moving blocks of code around. Basically grouping related methods close to each.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
(LauncherWindow::changeViewportUpdateMode):
(LauncherWindow::showFPS):
(LauncherWindow::newWindow):
(LauncherWindow::cloneWindow):
* QtTestBrowser/launcherwindow.h:
2010-07-30 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Tor Arne Vestbø.
[QT][Symbian] QtTestBrowser missing location capabilities
https://bugs.webkit.org/show_bug.cgi?id=43235
QtTestBrowser missing capabilities to use QtMobility::QLocation.
* QtTestBrowser/QtTestBrowser.pro:
2010-07-29 Anders Carlsson <andersca@apple.com>
Add PluginTest.cpp
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2010-07-29 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Update download URLs for python irclib package; the old URLs
pointed at a specific mirror host and not the general sourceforge
URLs.
https://bugs.webkit.org/show_bug.cgi?id=43228
* Scripts/webkitpy/thirdparty/__init__.py:
2010-07-29 Anders Carlsson <andersca@apple.com>
Fix typo.
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2010-07-29 Anders Carlsson <andersca@apple.com>
Another attempt at fixing the Qt and GTK+ build.
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_stream):
2010-07-29 Anders Carlsson <andersca@apple.com>
Another build fix attempt.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
* GNUmakefile.am:
2010-07-29 Anders Carlsson <andersca@apple.com>
Try to fix Windows and Unix builds.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_stream):
2010-07-29 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Refactor TestNetscapePlugin so tests can be split in separate files
https://bugs.webkit.org/show_bug.cgi?id=43220
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginAllocate):
Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
(PluginTest::PluginTest):
Initialize m_npp and the test identifier.
(PluginTest::createTestFunctions):
Return the map from identifiers to createTest functions.
(PluginTest::registerCreateTestFunction):
Insert the identifier and create function pair in the map.
(PluginTest::create):
Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
(PluginTest::Register::Register):
Helper class template for registering plug-in tests.
(PluginTest::Register::create):
Create a new test of the given type.
* DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
(DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
(NPP_DestroyStream):
Call the plug-in test NPP_DestroyStream member function.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
2010-07-29 Martin Robinson <mrobinson@igalia.com>
Unreviewed build fix.
Add missing second argument to assert_lint in new style checker tests.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
2010-07-29 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
check-webkit-style shouldn't complain about NPAPI functions
https://bugs.webkit.org/show_bug.cgi?id=43211
Allow underscores in functions that start with NPN_, NPP_ or NP_.
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
2010-07-29 Victor Wang <victorw@chromium.org>
Unreviewed, rolling out r64270.
http://trac.webkit.org/changeset/64270
https://bugs.webkit.org/show_bug.cgi?id=39589
The patch breaks chromium webkit unittest
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
* Scripts/build-webkit:
2010-07-29 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
[Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
https://bugs.webkit.org/show_bug.cgi?id=43199
There is no sense in keeping WebPage method definitions in main.cpp once
webpage.cpp already exists.
No behavior change.
* QtTestBrowser/main.cpp:
* QtTestBrowser/webpage.cpp:
(WebPage::createWindow):
(WebPage::createPlugin):
2010-07-29 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
[Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
https://bugs.webkit.org/show_bug.cgi?id=43170
Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
launcherwindow.{cpp|h}
No behavior change.
Also changed all global static variables (named "gXXX") from main.cpp to
static public variables of the LauncherWindow class.
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/launcherwindow.cpp: Added.
* QtTestBrowser/launcherwindow.h: Added.
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
(main):
2010-07-29 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Build fix for building against GTK+ 3.x. GSEAL requires that we
access internals of the GdkDragContext via methods. For older versions
of GTK+, define those methods.
* DumpRenderTree/gtk/EventSender.cpp:
(gdk_drag_context_get_selected_action): Added.
(gdk_drag_context_get_actions): Added.
(dispatchEvent): Use the two new accessor methods.
2010-07-29 Adam Roben <aroben@apple.com>
Always say "plugins directory" when referring to a directory
containing one or more plugins
Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
directory" when it means "plugins directory"
Reviewed by John Sullivan.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize): Updated for rename.
2010-07-29 Adam Roben <aroben@apple.com>
Always say "directory" when referring to a plugin directory
Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
when it means "plugin directory"
Reviewed by John Sullivan.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize): Updated for renames.
* WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
m_testPluginDirectory.
(WTR::TestController::testPluginDirectory): Renamed from
testPluginPath.
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::initializeTestPluginDirectory):
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeTestPluginDirectory):
Renamed from initializeTestPluginPath and updated for rename.
2010-07-29 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Antonio Gomes.
Initialize all members of NPClass struct.
https://bugs.webkit.org/show_bug.cgi?id=43193
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2010-07-29 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Antonio Gomes.
Warning fix on platforms where XP_MACOSX is undefined.
https://bugs.webkit.org/show_bug.cgi?id=43192
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
2010-07-29 Adam Roben <aroben@apple.com>
Give find-included-framework-headers our standard license
* Scripts/find-included-framework-headers: Used the license from
WebCore/LICENSE-APPLE.
2010-07-29 Adam Roben <aroben@apple.com>
Speed up find-included-framework-headers
We only do one invocation of find now, no longer pipe to grep, and
replace uniq with sort -u.
Also added a license header.
* Scripts/find-included-framework-headers:
2010-07-29 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Add LayoutTestController methods to test DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39589
* DumpRenderTree/LayoutTestController.cpp:
(setMockDeviceOrientationCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setMockDeviceOrientation):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMockDeviceOrientation):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setMockDeviceOrientation):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setMockDeviceOrientation):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setMockDeviceOrientation):
* Scripts/build-webkit:
2010-07-28 Kenichi Ishibashi <bashi@google.com>
Reviewed by Shinichiro Hamaji.
Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
check-webkit-style gives false positives in single-line functions.
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
2010-07-28 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.execCommand
<https://bugs.webkit.org/show_bug.cgi?id=42538>
WebKitTestRunner needs layoutTestController.isCommandEnabled
<https://bugs.webkit.org/show_bug.cgi?id=42671>
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Added execCommand and isCommandEnabled.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::execCommand): Added.
(WTR::LayoutTestController::isCommandEnabled): Added.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2010-07-28 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Introduce drt_expectations.txt for NRWT
https://bugs.webkit.org/show_bug.cgi?id=43123
Introduce LayoutTests/platform/chromium/drt_expectations.txt,
which overrides test expectations only for DumpRenderTree, in
order to manage what problems are investigated.
This change will be reverted when we switch to DRT completely.
* Scripts/webkitpy/layout_tests/port/chromium.py:
Add drt_expectations.txt content to the result of
test_expectations_overrides() if --use-drt is specified.
2010-07-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
First pass at visited link support for WK2
https://bugs.webkit.org/show_bug.cgi?id=43157
* MiniBrowser/mac/AppDelegate.m:
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
(populateVisitedLinks): Added for the new version of the HistoryClient.
(-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
2010-07-28 Robin Dunn <robin@alldunn.com>
Reviewed by Kevin Ollivier.
Add DOM bindings support for wx port.
* DumpRenderTree/wscript:
* wx/browser/wscript:
* wx/build/settings.py:
2010-07-28 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] cleanup temp files left by Linux DRT
https://bugs.webkit.org/show_bug.cgi?id=43062
* BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
* BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
by crashed DRTs
2010-07-28 Antonio Gomes <tonikitoo@webkit.org>
Rubber-stamped by Kenneth Christiansen.
More Developer menu items reordering.
Grouping related menu items together, visually and logically (in the code).
No behavior change.
* QtTestBrowser/main.cpp:
(LauncherWindow::createChrome):
2010-07-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Ojan Vafai.
Add FILE_SYSTEM build flag for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=42915
* Scripts/build-webkit:
2010-07-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by David Levin.
Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
https://bugs.webkit.org/show_bug.cgi?id=43090
* Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
2010-07-27 Kent Tamura <tkent@chromium.org>
Unreviewed, trivial typo fix.
* Scripts/webkitpy/layout_tests/port/chromium.py:
Fix a wrong method name committed by r64109.
2010-07-27 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
Clean up handling of strings at the WebKit2 API layer.
* MiniBrowser/mac/BrowserWindowController.m:
(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(didNavigateWithNavigationData):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(_didClearWindowForFrame):
2010-07-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
https://bugs.webkit.org/show_bug.cgi?id=42984
squash and no_squash have been intentionally erroring for a couple weeks now.
But post-commits was just broken. Just remove squash/no_squash.
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/options.py:
2010-07-27 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
* wx/build/settings.py:
2010-07-27 Adam Roben <aroben@apple.com>
Mac build fix
* MiniBrowser/mac/BrowserWindowController.m:
(processDidExit):
(-[BrowserWindowController awakeFromNib]):
Added processDidExit support.
2010-07-26 Antonio Gomes <tonikitoo@webkit.org>
Rubber-stamped by Simon Hausmann.
[Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
Move some less useful menu items on Developers menu from the top to the bottom, so
QGraphicsView menu goes to the top, and becomes more quickly accessible.
* QtTestBrowser/main.cpp:
(LauncherWindow::createChrome):
2010-07-26 Adam Roben <aroben@apple.com>
Fix the path to InjectedBundle.dll in Debug_Internal builds
Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
InjectedBundle.dll in the Debug_Internal configuration
Reviewed by Anders Carlsson.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeInjectedBundlePath): Add the _debug
suffix only in Debug_All builds.
2010-07-25 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42947
Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw
error. Without which dumpRenderTree crashes.
* Scripts/old-run-webkit-tests:
2010-07-27 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=42956
[DRT/Chromium] Fix "out of sync" assertion error
Fix an assertion error on Windows like the following:
100721 20:16:46 chromium.py:386 CRITICAL Test got out of sync:
|file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
|file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
* Scripts/webkitpy/layout_tests/port/chromium.py:
If the url matches with "file:///[a-z]:", does case-ignore comparison.
GURL capitalize the driver letter of a file: URL.
2010-07-26 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.counterValueForElementById
https://bugs.webkit.org/show_bug.cgi?id=42537
WebKitTestRunner needs layoutTestController.markerTextForListItem
https://bugs.webkit.org/show_bug.cgi?id=42549
* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
Fixed _paramterExpression typo. Improved support for string type as a
return value, so we don't try to include DOMString.h and we can convert
the string to a JSValue by calling JSValueMakeStringOrNull.
* WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
Added JSValueMakeStringOrNull, used by the code generator.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Added counterValueForElementById and markerTextForListItem.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
Moved constant to the top of the file.
(WTR::toCF): Added. Converts strings to CFStringRef.
(WTR::toWK): Added. Converts strings to WKStringRef.
(WTR::toJS): Added. Converts strings to JSStringRef.
(WTR::setProperty): Moved this function to the top of the file
rather than having it down where it's used inside the class. Also
renamed it so it's a separate function rather than an overload of
JSObjectSetProperty.
(WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
Should move it somewhere we can share it.
(WTR::propertyObject): Ditto.
(WTR::getElementById): Added. Calls getElementById through the magic
of JavaScript.
(WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
Chagned to use toWK instead of four local variables.
(WTR::LayoutTestController::counterValueForElementById): Added.
Calls WKBundleFrameCopyCounterValue.
(WTR::LayoutTestController::markerTextForListItem): Added.
Calls WKBundleFrameCopyMarkerText.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
Added counterValueForElementById and markerTextForListItem.
2010-07-26 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] The EventSender should support simulating drop events
https://bugs.webkit.org/show_bug.cgi?id=39844
Add initial dropping support to the GTK+ EventSender.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(createWebView): Listen for some new drag-and-drop signals.
* DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
(dispatchEvent):
Detect situations where a drag is either starting or ending and massage
GTK+ into sending the appropriate signals to the WebView.
(replaySavedEvents): Remove comment.
(makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
(dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
(dragEndCallback): Clear the currentDragSourceContext when a drag ends.
(dragFailedCallback): Disable the GTK+ drag failed animation.
* DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
2010-07-26 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
svn-unapply warns of uninitialized variable when unapplying
a patch that describes an svn move operation
https://bugs.webkit.org/show_bug.cgi?id=42036
Fixes Perl uninitialized variable warnings when un-applying
a patch that moves a file.
* Scripts/svn-unapply:
- Modified patch() so that it initializes $patch to the empty
string when we don't have svnConvertedText (such as when
reversing a diff that represents a svn copy/move operation).
2010-07-26 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Move some non-APIish functions into private headers.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2010-07-26 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
Add prompt and confirm client functions to WebKit2
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
2010-07-26 Adam Roben <aroben@apple.com>
Windows build fix
* MiniBrowser/MiniBrowser.vcproj:
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
Removed empty attributes so the values will be picked up from the
vsprops files. (Also removed a couple of attributes that accidentally
duplicated values from the vsprops files.)
2010-07-26 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Touch MiniBrowser's stdafx to fix the build.
* MiniBrowser/win/stdafx.h:
2010-07-26 Hayato Ito <hayato@chromium.org>
Reviewed by Shinichiro Hamaji.
Add pretty printer of WTF::Vector for GDB 7.
https://bugs.webkit.org/show_bug.cgi?id=40909
* gdb/wtf.py: Added.
2010-07-26 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix feature detection regexp
We were missing the last feature
* Scripts/webkitdirs.pm:
2010-07-25 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
https://bugs.webkit.org/show_bug.cgi?id=42326
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Added dumpSelectionRect.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
does nothing because its purpose is to change pixel test output and
we do not have pixel tests implemented yet.
2010-07-25 Darin Adler <darin@apple.com>
Reviewed by Maciej Stachowiak.
WebKitTestRunner needs to support layoutTestController.keepWebHistory
https://bugs.webkit.org/show_bug.cgi?id=42323
Added keepWebHistory and computedStyleIncludingVisitedInfo.
Also fixed misspellings of the word "receive".
Also tweaked the names of some of the LayoutTestController members.
* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
Added support for a type named "object" that is passed and returns as
a JSValueRef.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
put setAcceptsEditing up nearer the top.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
(WTR::InjectedBundle::initialize): Ditto.
(WTR::InjectedBundle::didReceiveMessage): Ditto.
(WTR::InjectedBundle::reset): Reset the state of visited links between
tests. Also eliminated the unused argument to the LayoutTestController
create function.
(WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
* WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
instead of acceptsEditing.
(WTR::InjectedBundlePage::shouldEndEditing): Ditto.
(WTR::InjectedBundlePage::shouldInsertNode): Ditto.
(WTR::InjectedBundlePage::shouldInsertText): Ditto.
(WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
(WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
(WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::create): Removed uneeded argument.
(WTR::LayoutTestController::LayoutTestController): Removed unneeded
argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
(WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
about the fact that this works on the main frame.
(WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
(WTR::LayoutTestController::keepWebHistory): Added.
(WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
(WTR::JSObjectSetProperty): Added. Helper to make the function below
cleaner.
(WTR::LayoutTestController::makeWindowObject): Changed to use the
overload of JSObjectSetProperty above.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
match above.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize): Fixed mispellings of receive.
(WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
(WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
* WebKitTestRunner/TestController.h: Ditto.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
* WebKitTestRunner/TestInvocation.h: Ditto.
2010-07-25 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
Step 2 - add the rest of editing delegates.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::operator<<): Fixed to not crash when range is null.
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_shouldEndEditing):
(WTR::InjectedBundlePage::_shouldInsertNode):
(WTR::InjectedBundlePage::_shouldInsertText):
(WTR::InjectedBundlePage::_shouldDeleteRange):
(WTR::InjectedBundlePage::_shouldChangeSelectedRange):
(WTR::InjectedBundlePage::_shouldApplyStyle):
(WTR::InjectedBundlePage::_didBeginEditing):
(WTR::InjectedBundlePage::_didEndEditing):
(WTR::InjectedBundlePage::_didChange):
(WTR::InjectedBundlePage::_didChangeSelection):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2010-07-24 Chris Fleizach <cfleizach@apple.com>
Reviewed by David Kilzer.
AX: need a layout test testing misspelled words in attributed strings
https://bugs.webkit.org/show_bug.cgi?id=42899
* DumpRenderTree/AccessibilityUIElement.cpp:
(attributedStringForRangeCallback):
(attributedStringRangeIsMisspelledCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
2010-07-23 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
Reviewed by Mark Rowe.
* Scripts/check-for-inappropriate-files-in-framework: Added
check for the SHALLOW_BUNDLE environment variable so that the
script will work with iOS WebKit builds.
* Scripts/check-for-webkit-framework-include-consistency: Ditto.
2010-07-22 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42847
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::operator<<): Replaced the WKStringToUTF8 function with
a set of overloaded stream operators.
(WTR::dumpPath): Changed to use ostringstream and return a string.
(WTR::propertyValue): Added.
(WTR::propertyObject): Added.
(WTR::propertyString): Added.
(WTR::numericWindowPropertyValue): Changed to call propertyValue.
(WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
since we now have suitable streaming functions.
(WTR::dumpFrameText): Use propertyObject and propertyString instead of
WKBundleFrameCopyInnerText.
(WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
since we now have suitable streaming functions.
(WTR::InjectedBundlePage::dump): Ditto.
(WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
(WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
2010-07-22 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig and Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
fixed, but this makes difference one line smaller on many editing tests.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Added dumpEditingCallbacks() and setAcceptsEditing().
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
(WTR::operator<<): Print a range.
(WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
clients.
(WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
(WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
calls.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpEditingCallbacks):
(WTR::LayoutTestController::setAcceptsEditing):
(WTR::LayoutTestController::acceptsEditing):
(WTR::LayoutTestController::shouldDumpEditingCallbacks):
Store m_acceptsEditing and m_dumpEditingCallbacks.
2010-07-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] QtWebKit needs public API for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=41413
Update DumpRenderTree and QtTestBrowser to use the new API.
Add new DRT API to flag that notifications permission requests should be ignored.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::checkPermission):
(WebCore::WebPage::cancelRequestsForPermission):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::ignoreDesktopNotificationPermissionRequests):
(LayoutTestController::checkDesktopNotificationPermission):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::ignoreReqestForPermission):
* QtTestBrowser/main.cpp:
(LauncherWindow::LauncherWindow):
* QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
(WebPage::requestPermission):
(WebPage::checkPermission):
(WebPage::cancelRequestsForPermission):
* QtTestBrowser/webpage.h:
2010-07-22 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
https://bugs.webkit.org/show_bug.cgi?id=42325
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Added dumpChildFramesAsText.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpFrameText): Added.
(WTR::dumpDescendantFramesText): Added.
(WTR::InjectedBundlePage::dumpAllFramesText): Added.
(WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
instead of the shouldDumpAsText function, and added a case for AllFramesText.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
m_whatToDump.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
and shouldDumpSourceAsWebArchive. Added whatToDump.
2010-07-22 Adam Roben <aroben@apple.com>
Windows build fix
Inspired by r63881.
* MiniBrowser/MiniBrowser.vcproj:
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
Removed pre- and post-build events so they will be inherited from the
vsprops files.
2010-07-21 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
(WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
Changed to a file-internal function instead of a member function.
(WTR::dumpDescendantFrameScrollPositions): Added.
(WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
(WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
appropriate. Also streamlined all the WKStringToUTF8 call sites.
(WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
(WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): Initialize
m_shouldDumpAllFrameScrollPositions.
(WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
shouldDumpFrameScrollPositions.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
2010-07-21 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support dumping of scroll position
https://bugs.webkit.org/show_bug.cgi?id=42514
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
instead of JSContextRef.
(WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
(WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
(WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
(WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
instead of JSContextRef.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
returns false.
(WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
returns false.
(WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
the logic in DumpRenderTree.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
* WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
2010-07-21 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
* wx/build/settings.py:
2010-07-21 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_willAddMessageToConsole):
(WTR::InjectedBundlePage::_willSetStatusbarText):
(WTR::InjectedBundlePage::_willRunJavaScriptAlert):
(WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2010-07-21 Adam Roben <aroben@apple.com>
Give InjectedBundle our standard set of configurations (minus the
*_Cairo variants)
InjectedBundle's Debug_All configuration was the same as is Debug
configuration, and it was missing a Debug_Internal configuration.
Fixes <http://webkit.org/b/42749> InjectedBundle's build
configurations are screwy
Reviewed by Darin Adler.
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
debug_internal.vsprops and debug_all.vsprops to the Debug_All
configuration. Added a Debug_Internal configuration.
* WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
variant of InjectedBundle when we're using the Debug_Internal solution
configuration.
2010-07-21 Adam Roben <aroben@apple.com>
Move InjectedBundle's settings to a vsprops file
This will make it easier to change settings for all configurations,
and to add new configurations.
Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
files
Reviewed by Darin Adler.
* WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
Moved settings here...
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
here.
2010-07-21 Adam Roben <aroben@apple.com>
Give MiniBrowser our standard set of configurations (minus the *_Cairo
variants)
MiniBrowser already had a configuration called "Release", but it was
using mostly the same settings as Debug. And its Debug configuration
was using the settings that Debug_Internal should be using.
Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
are screwy
Reviewed by Darin Adler.
* MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
the Debug configuration. Remove debug.vsprops and
debug_internal.vsprops from the Release configuration and replace them
with release.vsprops. Added Debug_Internal and Debug_All
configurations.
2010-07-21 Adam Roben <aroben@apple.com>
Move MiniBrowser's settings to a vsprops file
This will make it easier to change settings for all configurations,
and to add new configurations.
MiniBrowser should use vsprops files
https://bugs.webkit.org/show_bug.cgi?id=42745
Reviewed by Darin Adler.
* MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
settings here...
* MiniBrowser/MiniBrowser.vcproj: ...from here.
2010-07-21 Adam Roben <aroben@apple.com>
Fix compiler warnings when building MiniBrowser
Also cleaned up the .vcproj a bit.
Fixes <http://webkit.org/b/42743>.
Reviewed by Darin Adler.
* MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
already defined in .vsprops files. This also fixes a warning about
/EDITANDCONTINUE being incompatible with /SAFESEH.
* MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
being redefined. (I think this will also get us closer to building
with VC++ Express.)
2010-07-20 Sam Weinig <sam@webkit.org>
Reviewed by Jon Honeycutt.
Fix obvious typo.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
2010-07-20 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] by default, dumpAsText should disable pixel results
https://bugs.webkit.org/show_bug.cgi?id=42715
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
2010-07-20 Adam Roben <aroben@apple.com>
Windows build fix
* MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
WebKit.lib instead of the old, dusty WebKit2.lib.
2010-07-20 Adam Roben <aroben@apple.com>
Stop linking WebKitTestRunner against getopt
Use of getopt was removed in r63700.
Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
getopt, but doesn't need to
Reviewed by Sam Weinig.
* WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
from all configurations.
2010-07-20 Adam Roben <aroben@apple.com>
Make run-webkit-tests --webkit-test-runner "work" on Windows
WebKitTestRunner crashes on launch, but at least the scripts build and
launch it!
Fixes <http://webkit.org/b/42709> run-webkit-tests
--webkit-test-runner bails with an error on Windows
Reviewed by Anders Carlsson.
* Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
Windows.
* WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
projects (from first-built to last-built): FindSafari, ImageDiff,
InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
2010-07-20 Adam Roben <aroben@apple.com>
Change build-webkit back to building WebKit.sln on Windows
WebKit.sln builds all the same projects as WebKit2.sln, and the latter
is being removed.
Rubber-stamped in advance by Steve Falkenburg.
* Scripts/build-webkit:
2010-07-20 Adam Roben <aroben@apple.com>
Windows build fix
* MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
2010-07-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Geoffrey Garen.
WebScriptObject Should Allow Safely Checking For Key Existence
https://bugs.webkit.org/show_bug.cgi?id=42613
Normal ObjCController workflow for a WebScriptObject test.
* DumpRenderTree/mac/ObjCController.m:
(+[ObjCController isSelectorExcludedFromWebScript:]):
(+[ObjCController webScriptNameForSelector:]):
(-[ObjCController testHasWebScriptKey:]):
2010-07-20 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=42118
Disable compositing/webgl tests if WebGL is not enabled
* Scripts/old-run-webkit-tests:
2010-07-20 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Adler.
Print additional information about exception if failed to connect to apache (in verbose mode).
https://bugs.webkit.org/show_bug.cgi?id=42627
* Scripts/webkitpy/layout_tests/port/http_server_base.py:
2010-07-20 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] only pass --force to gclient sync if explicitly stated
https://bugs.webkit.org/show_bug.cgi?id=42581
* BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
always pass --force since it's hard to do manual cleanups
* Scripts/update-webkit-chromium: only pass --force if --force is
passed in
2010-07-19 Anders Carlsson <andersca@apple.com>
Fix build.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Paths of generated files should be relative to the build product.
2010-07-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930
Implements DRT support for markerTextForListItem in the Windows port.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::markerTextForListItem): Implemented.
2010-07-19 Jessie Berlin <jberlin@apple.com>
Windows build fix. Unreviewed.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeTestPluginPath):
2010-07-19 Sam Weinig <sam@webkit.org>
Reviewed by Jon Honeycutt.
Remove dependency on getopt from WebKitTestRunner.
- Simplify options parsing and eliminate unused options.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
* WebKitTestRunner/TestController.h:
(WTR::TestController::testPluginPath):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):
2010-07-19 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Antonio Gomes.
[Qt] MiniBrowser: Progress indication at address bar
https://bugs.webkit.org/show_bug.cgi?id=42565
Make possible to see load progress at address bar based on
QtTestBrowser solution
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::loadProgress):
* MiniBrowser/qt/BrowserWindow.h:
2010-07-19 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
https://bugs.webkit.org/show_bug.cgi?id=42564
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserView::load):
(BrowserWindow::BrowserWindow):
(BrowserWindow::titleChanged):
(BrowserWindow::urlChanged):
* MiniBrowser/qt/BrowserWindow.h:
2010-07-19 Sam Weinig <weinig@apple.com>
Reviewed by Adam Roben.
Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/DebugRelease.xcconfig:
* WebKitTestRunner/DerivedSources.make: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
* WebKitTestRunner/InjectedBundle/Bindings: Added.
* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
* WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
(WTR::JSWrappable::~JSWrappable):
* WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):
* WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
(WTR::toJS):
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
* WebKitTestRunner/win/build-generated-files.sh: Added.
2010-07-19 Mark Rowe <mrowe@apple.com>
Clean up the buildbot configuration a little.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2010-07-19 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42118
Disable WebGL on Leopard for now.
LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
software OpenGL driver on machines without this support.
* Scripts/build-webkit:
2010-07-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Brady Eidson.
Fix MiniBrowser to update URL as you browse
https://bugs.webkit.org/show_bug.cgi?id=42591
Hook up various loading notifications to update the URL bar in MiniBrowser.
* MiniBrowser/mac/BrowserWindowController.m:
(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFailLoadWithErrorForFrame):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
(-[BrowserWindowController didStartProvisionalLoadForFrame:]):
(-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
(-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
(-[BrowserWindowController didFailLoadWithErrorForFrame:]):
(-[BrowserWindowController didCommitLoadForFrame:]):
2010-07-19 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::didReceiveAuthenticationChallenge):
It's important to know whether an auth sheet appeared. Added logging to "no preset credentials"
case.
2010-07-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63671.
http://trac.webkit.org/changeset/63671
https://bugs.webkit.org/show_bug.cgi?id=42575
broke windows (Requested by weinig on #webkit).
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/DebugRelease.xcconfig:
* WebKitTestRunner/DerivedSources.make: Removed.
* WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
* WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
* WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
* WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setWaitToDump):
(WTR::displayCallback):
(WTR::dumpAsTextCallback):
(WTR::dumpStatusCallbacksCallback):
(WTR::waitUntilDoneCallback):
(WTR::notifyDoneCallback):
(WTR::numberOfActiveAnimationsCallback):
(WTR::pauseAnimationAtTimeOnElementWithIdCallback):
(WTR::repaintSweepHorizontallyCallback):
(WTR::testRepaintCallback):
(WTR::layoutTestControllerObjectFinalize):
(WTR::LayoutTestController::makeWindowObject):
(WTR::LayoutTestController::getJSClass):
(WTR::LayoutTestController::staticFunctions):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::setDumpAsText):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::setDumpStatusCallbacks):
(WTR::LayoutTestController::setTestRepaint):
(WTR::LayoutTestController::setTestRepaintSweepHorizontally):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010-07-19 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/DebugRelease.xcconfig:
* WebKitTestRunner/DerivedSources.make: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
* WebKitTestRunner/InjectedBundle/Bindings: Added.
* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
* WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
(WTR::JSWrappable::~JSWrappable):
* WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):
* WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
(WTR::toJS):
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010-07-19 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
fix chromium linux compile on ubuntu maverick
https://bugs.webkit.org/show_bug.cgi?id=42528
* Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
2010-07-19 Adam Roben <aroben@apple.com>
When dumping a response's MIME type, print its URL's last path
component rather than its suitable-for-test-result form
This matches the Mac behavior.
Fixes <http://webkit.org/b/42276>
http/tests/loading/preload-slow-loading.php and
http/tests/mime/uppercase-mime-type.html fail on Windows
Reviewed by Anders Carlsson.
* DumpRenderTree/win/DumpRenderTree.cpp:
(urlSuitableForTestResult): Moved code to actually extract the last
path component from here...
(lastPathComponent): ...to here.
* DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
component, rather than its suitable-for-test-result form, to match
Mac.
2010-07-19 Anders carlsson <andersca@apple.com>
Reviewed by Adam Roben.
WebKit2 does not have application cache
https://bugs.webkit.org/show_bug.cgi?id=42552
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set up default preferences. Right now just enables the web application cache.
(WTR::TestInvocation::invoke):
Call resetPreferencesToConsistentValues.
* WebKitTestRunner/TestInvocation.h:
2010-07-19 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Roben.
Fix NewRunWebKitTests to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=41180
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
Specifying python explicitly.
2010-07-18 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Add dumping of statusbar text to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42516
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_setStatusbarText):
(WTR::InjectedBundlePage::setStatusbarText):
Dump the statusbar text.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
Initialize m_dumpStatusCallbacks to false.
(WTR::dumpStatusCallbacksCallback):
Implement JSC callback.
(WTR::LayoutTestController::staticFunctions):
Add dumpStatusCallbacks.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::setDumpStatusCallbacks):
Add setter and getter for m_dumpStatusCallbacks.
2010-07-17 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
Get the test plug-in path and set it on the context.
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::initializeInjectedBundlePath):
Simplify this code by using NSBundle.
(WTR::TestController::testPluginPath):
Return the test plug-in path.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::testPluginPath):
Ditto.
2010-07-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach webkitpy about queues.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=42492
* Scripts/webkitpy/common/net/statusserver.py:
2010-07-16 Ada Chan <adachan@apple.com>
Reviewed by Alice Liu.
Fix Windows build.
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2010-07-16 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=42482
<rdar://problem/8197701>
Add notification of when the BackForwardList changes
to aid invalidation of Back/Forward related UI elements.
* MiniBrowser/mac/BrowserWindowController.m:
(_didStartProvisionalLoadForFrame):
(_didCommitLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didChangeBackForwardList):
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010-07-16 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] <input type=number> UI implementation for Windows
https://bugs.webkit.org/show_bug.cgi?id=42259
* DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
(WebThemeEngineDRT::paintSpinButton):
Added. Check state consistency and use existing arrow painting code.
* DumpRenderTree/chromium/WebThemeEngineDRT.h:
2010-07-16 Alice Liu <alice.liu@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=42430
Make WebKitTestRunner on Windows actually load and run a test
* WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize.
(WKBundleInitialize):
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added. Output is a dll.
* WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows
(WTR::createWKURL):
* WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match
other existing checks, and avoid including Platform.h
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::registerWindowClass): Added.
(WTR::PlatformWebView::PlatformWebView): Implemented.
(WTR::PlatformWebView::~PlatformWebView): Implemented.
(WTR::PlatformWebView::page): Implemented.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build
configuration specific path to InjectedBundle.dll.
* WebKitTestRunner/win/TestInvocationWin.cpp:
(WTR::TestInvocation::runUntil): Implemented.
* WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project.
* WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies.
2010-07-16 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Make revalidation of back/forward work a little better with page loads
https://bugs.webkit.org/show_bug.cgi?id=42470
* MiniBrowser/mac/BrowserWindow.xib:
* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController validateToolbar]):
(_didStartProvisionalLoadForFrame):
(_didCommitLoadForFrame):
(_didFailLoadWithErrorForFrame):
2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add possibility to dumpAsText and generate a pixel test result
https://bugs.webkit.org/show_bug.cgi?id=42374
Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode.
setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests.
This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result.
At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test.
Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled.
(Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything)
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(dumpAsTextAndPixelsCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpAsTextAndPixels):
(LayoutTestController::setDumpAsTextAndPixels):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::dumpAsTextAndPixels):
(LayoutTestController::reset):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::shouldDumpAsTextAndPixels):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dump):
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump):
* DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/win/DumpRenderTree.cpp:
(dump):
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(dump):
2010-07-16 Kent Hansen <kent.hansen@nokia.com>
Unreviewed. Adding myself as committer.
* Scripts/webkitpy/common/config/committers.py:
2010-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Another uneviewed attempt to fix build.
Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createPagedBitmapContext):
2010-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed tiger build fix.
Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContext):
(createBitmapContextFromWebView):
2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed build fix.
Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011
* DumpRenderTree/PixelDumpSupport.cpp:
(dumpWebViewAsPixelsAndCompareWithExpected):
2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011
* DumpRenderTree/PixelDumpSupport.cpp:
(dumpWebViewAsPixelsAndCompareWithExpected):
* DumpRenderTree/PixelDumpSupport.h:
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContext): This function was added to share bitmap context creation code.
(createBitmapContextFromWebView):
(createPagedBitmapContext):
2010-07-15 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
Pull in pywebsocket-0.5.1
https://bugs.webkit.org/show_bug.cgi?id=42353
pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test
in Chromium. There is no other functional change.
(*) http://code.google.com/p/pywebsocket/source/detail?r=265
* Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version to 0.5.1.
2010-07-15 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Add toolbar and toolbar item validation for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=42422
* MiniBrowser/MBToolbarItem.h: Added.
* MiniBrowser/MBToolbarItem.m: Added.
(-[MBToolbarItem validate]):
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController validateUserInterfaceItem:]):
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/BrowserWindow.xib:
2010-07-15 Victor Wang <victorw@chromium.org>
Unreviewed, add victorw irc nickname to committer list.
* Scripts/webkitpy/common/config/committers.py:
2010-07-15 Adam Roben <aroben@apple.com>
Make killing Apache more reliable (on both Mac and Windows)
We previously had two ways of determining whether we had succeeded in
killing Apache:
1) checking the return value of kill(0, $apachePID)
2) checking whether Apache's PID file still exists
On Cygwin, Apache doesn't always delete its PID file when it exits,
making (2) unreliable. We unfortunately misdiagnosed this as an
impotency of Perl's kill function, which led to r63177 and r63355.
Now that we know that the real problem is that Apache doesn't always
delete its PID file on Windows, we can make a much better fix: always
use method (1) to determine whether we've killed Apache.
Fixes <http://webkit.org/b/42415> Killing Apache is unreliable,
leading to regression test failures (and general annoyance).
Reviewed by Anders Carlsson.
* Scripts/webkitperl/httpd.pm:
(openHTTPD): Moved killing code from here to killHTTPD. Added a call
to delete the PID file in case Apache doesn't do this itself when
killed. Our later logic relies on the PID file being deleted after
this point.
(closeHTTPD): Removed killing logic and changed to just call killHTTPD
instead. killHTTPD's logic is a bit different from the logic we had
here, for the reasons stated above.
(killHTTPD): Added. Code came from openHTTPD.
(handleInterrupt): Bonus fix for Mac: don't hang when pressing Ctrl-C!
On Mac, don't try to kill Apache when we receive a signal, as Apache
will already have been killed by this point (though for some reason
this isn't detected by our killing logic in killHTTPD). On Cygwin, we
still need to kill Apache manually.
2010-07-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=42399
Update MiniBrowser for WKFrameNavigationType
* MiniBrowser/mac/BrowserWindowController.m:
(_decidePolicyForNavigationAction):
(_decidePolicyForNewWindowAction):
2010-07-15 Stephanie Lewis <slewis@apple.com>
Reviewed by Geoff Garen.
http://bugs.webkit.org/show_bug.cgi?id=42406
Make SunSpider work better with roots.
* Scripts/sunspider-compare-results: fix argument bug
* Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level.
2010-07-15 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Hook up back/forward in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=42397
* MiniBrowser/mac/BrowserWindow.xib:
* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController goBack:]):
(-[BrowserWindowController goForward:]):
2010-07-15 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
[Mac] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37929
Implements DRT support for markerTextForListItem in the Mac port.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::markerTextForListItem): Implemented.
2010-07-15 Adam Barth <abarth@webkit.org>
Unreviewed.
Update the port names to be more specific. Before this patch,
port-specific results for Mac would end up in the wrong place.
* Scripts/webkitpy/tool/commands/rebaseline.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2010-07-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
WebKit needs a rebaselining tool (finally)
https://bugs.webkit.org/show_bug.cgi?id=42339
This is a very basic rebaselining tool. It's not
quite as fancy as chromium's as it will only handle
updating failing results. It cannot yet handle adding new
results, or updating results where the results should not
replace existing results.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/tool/commands/__init__.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/commands/rebaseline.py: Added.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added.
2010-07-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63352.
http://trac.webkit.org/changeset/63352
https://bugs.webkit.org/show_bug.cgi?id=42341
Broke plugin-initiate-popup-window.html and plugin-javascript-
access.html on snow leopard (Requested by abarth on #webkit).
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginAllocate):
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
(handleEventCarbon):
(handleEventCocoa):
2010-07-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2010-07-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63346.
http://trac.webkit.org/changeset/63346
https://bugs.webkit.org/show_bug.cgi?id=42295
Broke lots of tests, some of which probably just need new
results (Requested by aroben on #webkit).
* DumpRenderTree/win/DumpRenderTree.cpp:
(urlSuitableForTestResult):
2010-07-14 Adam Roben <aroben@apple.com>
Speed up killing of Apache on Windows
Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting
run-webkit-tests) takes a long time on Windows
Reviewed by Darin Adler and Jon Honeycutt.
* Scripts/webkitperl/httpd.pm:
(closeHTTPD): Use taskkill to kill Apache and its child processes.
Perl's kill seems ineffectual. We were already using taskkill, but
only after trying kill 20 times. Since kill never works, let's just
skip it entirely.
2010-07-14 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=41292
Add a new parameter to the test plugin to allow to specify a script and a
mouse/keyboard event. The specified script will be evaluated in the browser
when the specified event is received by the plugin.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginAllocate):
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
(handleEventCarbon):
(handleEventCocoa):
2010-07-14 Adam Roben <aroben@apple.com>
Make urlSuitableForTestResult work for http: URLs, too
Fixes <http://webkit.org/b/42276>
http/tests/loading/preload-slow-loading.php and
http/tests/mime/uppercase-mime-type.html fail on Windows.
Reviewed by Darin Adler.
* DumpRenderTree/win/DumpRenderTree.cpp:
(urlSuitableForTestResult): Don't bail if the URL starts with http://.
We want this function to work for those URLs, too!
2010-07-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
https://bugs.webkit.org/show_bug.cgi?id=42227
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): Initialize new bool
members.
(WTR::LayoutTestController::display): Dummy method.
(WTR::displayCallback): Call the dummy.
(WTR::repaintSweepHorizontallyCallback): ditto
(WTR::testRepaintCallback): ditto
(WTR::LayoutTestController::staticFunctions): Expose new methods.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does
nothing).
(WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto
2010-07-13 Andreas Kling <andreas.kling@nokia.com>
Unreviewed. Adding myself as committer.
* Scripts/webkitpy/common/config/committers.py:
2010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Darin Adler.
Prevent assertion/duplicate loads for non-deferred subtitute-data loads
https://bugs.webkit.org/show_bug.cgi?id=30879
MainResourceLoader uses the member m_initialRequest to store requests for future
deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
have to clear this request so that subsequent entries into the loader will not
start yet another load.
This can happen as a result of a PageGroupLoadDeferrer going out of scope when
returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
but only in the case of using both substitute-data and non-deferred main resource
load together. That's why two new DRT functions were added:
* queueLoadHTMLString()
* setDeferMainResourceLoad()
The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(queueLoadHTMLStringCallback):
(setDeferMainResourceDataLoadCallback):
(LayoutTestController::staticFunctions):
(LayoutTestController::queueLoadHTMLString):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::deferMainResourceDataLoad):
(LayoutTestController::setDeferMainResourceDataLoad):
* DumpRenderTree/WorkQueueItem.h:
(LoadHTMLStringItem::LoadHTMLStringItem):
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
(LoadHTMLStringItem::invoke):
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
* DumpRenderTree/mac/WorkQueueItemMac.mm:
(LoadHTMLStringItem::invoke):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::setDeferMainResourceDataLoad):
(LayoutTestController::queueLoadHTMLString):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/qt/WorkQueueItemQt.cpp:
(LoadHTMLStringItem::invoke):
* DumpRenderTree/qt/WorkQueueItemQt.h:
(LoadHTMLStringItem::LoadHTMLStringItem):
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::willSendRequest):
* DumpRenderTree/win/WorkQueueItemWin.cpp:
(LoadHTMLStringItem::invoke):
* DumpRenderTree/wx/WorkQueueItemWx.cpp:
(LoadHTMLStringItem::invoke):
2010-07-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Nikolas Zimmermann.
Activate test fonts for layout tests in WebKitTestRunner (on Mac)
https://bugs.webkit.org/show_bug.cgi?id=42153
* WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize): Activate fonts on startup.
* WebKitTestRunner/InjectedBundle/mac: Added.
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
(WTR::activateFonts): Activate our fonts.
* WebKitTestRunner/InjectedBundle/win: Added.
* WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
(WTR::activateFonts): Dummy version.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
add more files.
* WebKitTestRunner/fonts: Added.
* WebKitTestRunner/fonts/AHEM____.TTF: Added.
* WebKitTestRunner/fonts/ColorBits-A.png: Added.
* WebKitTestRunner/fonts/ColorBits.ttf: Added.
* WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
* WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
* WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
* WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
* WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
* WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
* WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
* WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
* WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
* WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
* WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
2010-07-13 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Eric Seidel.
Remove check-header-includes, as it didn't turn out to be very useful.
https://bugs.webkit.org/show_bug.cgi?id=41970
* Scripts/check-header-includes: Removed.
2010-07-12 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej Stachowiak.
Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
https://bugs.webkit.org/show_bug.cgi?id=40922
Always build WebKit2 on Windows. Necessary since our WebKit build on
Windows is packaged into a DLL with WebKit2.
* Scripts/build-webkit: Always build WebKit2 on Windows.
2010-07-12 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
One http test timing out on Windows can cause all future tests to time out
https://bugs.webkit.org/show_bug.cgi?id=42146
There have been multiple times on the Windows bots where one http test timing out causes all future
http tests to time out. This is because the httpd process becomes unresponsive. When an http test
times out, we should restart httpd on Cygwin to prevent this.
* Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
* Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
using kill fails.
2010-07-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Remove use of auto_ptr in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42134
Replaced auto_ptr with PassOwnPtr / OwnPtr.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::WKStringToUTF8):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::addMessageToConsole):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::WKStringToUTF8):
(WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
2010-07-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
https://bugs.webkit.org/show_bug.cgi?id=42132
* Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
platform directories.
2010-07-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Make WebKitTestRunner resize the view specially for the W3C SVG tests.
https://bugs.webkit.org/show_bug.cgi?id=42126
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation): Store the path as a C
string for later use.
(WTR::TestInvocation::~TestInvocation):
(WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
size, depending on whether this is a W3C SVG test.
(WTR::TestInvocation::invoke): Call the size function.
* WebKitTestRunner/TestInvocation.h:
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::resizeTo): Implement.
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::resizeTo): Placeholder.
2010-07-12 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
Ensure DRT loads GAIL (Gtk+ module), for a11y tests
https://bugs.webkit.org/show_bug.cgi?id=38648
Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port
* Scripts/old-run-webkit-tests:
2010-07-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[GTK] Support pixel tests
https://bugs.webkit.org/show_bug.cgi?id=31518
Finish support for pixel tests on GTK+.
* DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
works on CoreFoundation systems) and add missing cstdio include.
* DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
(computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
by the ANSI standard and this fails on Linux, so unroll the loop here.
* DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
(BitmapContext::BitmapContext): There is no reason to check the value of the
m_context member in the constructor and it certainly should not be freed. Instead
just initialize it with the incoming value.
* DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
(dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
dump pixels.
* DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
(createBitmapContextFromWebView):
* GNUmakefile.am: Add new files to the build.
2010-07-12 Adam Barth <abarth@webkit.org>
Unreviewed.
Remove stray "raise e" that got included in a previous patch. This
caused the EWS bots to turn red instead of purple when a patch failed
to apply.
* Scripts/webkitpy/tool/commands/stepsequence.py:
2010-07-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63101.
http://trac.webkit.org/changeset/63101
https://bugs.webkit.org/show_bug.cgi?id=42103
Broke one API test (Requested by xan_ on #webkit).
* Scripts/old-run-webkit-tests:
2010-07-12 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
Fix crashes in Windows DumpRenderTree.
* DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
again on a destroyed sender.
2010-07-12 Adam Roben <aroben@apple.com>
Windows failure-to-launch fix
* DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
we already do for CoreFoundation, CFNetwork, etc.
2010-07-12 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
Ensure DRT loads GAIL (Gtk+ module), for a11y tests
https://bugs.webkit.org/show_bug.cgi?id=38648
Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port
* Scripts/old-run-webkit-tests:
2010-07-09 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::didReceiveAuthenticationChallenge):
Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
the Cancel button.
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=42082
* QtTestBrowser/main.cpp:
(LauncherWindow::createChrome):
* QtTestBrowser/mainwindow.cpp:
(MainWindow::openLocation):
* QtTestBrowser/mainwindow.h:
2010-07-12 Adam Roben <aroben@apple.com>
Make the Python autoinstaller not use a dead SourceForge server
Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
offline SourceForge server
Reviewed by Anders Carlsson.
* Scripts/webkitpy/thirdparty/__init__.py: Use
surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
which seems to be down.
2010-07-12 Adam Roben <aroben@apple.com>
Make run-webkit-tests print how many tests timed out when exiting
early
The number of timed-out tests is taken into account when deciding
whether to exit early. Leaving it out of the output just makes the
script look buggy (because it might say something like "Exiting early
after 0 crashes.").
Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
messages when exiting early due to crashes and time-outs
Reviewed by Anders Carlsson.
* Scripts/old-run-webkit-tests:
(stopRunningTestsEarlyIfNeeded): When stopping, print the number of
timed-out tests, too.
2010-07-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement animation-related methods for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42053
Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
animation tests were hanging otherwise.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::numberOfActiveAnimations):
(WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(WTR::numberOfActiveAnimationsCallback):
(WTR::pauseAnimationAtTimeOnElementWithIdCallback):
(WTR::LayoutTestController::staticFunctions):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2010-07-11 Daniel Bates <dbates@rim.com>
Reviewed by David Kilzer.
Enable executable support for svn-apply and svn-unapply
https://bugs.webkit.org/show_bug.cgi?id=39409
Connect up the Git and SVN executable bit support in parseDiff() so that
executable bit changes are propagated via the returned diff hash to the
patch function in svn-apply and svn-unapply.
* Scripts/VCSUtils.pm:
- Modified parseDiff() to call parseSvnDiffProperties when
it finds the start of an SVN property change diff.
- Removed FIXME comment above parseSvnDiffProperties() since
it is now being used by parseDiff().
- Export method scmToggleExecutableBit() now that we added the
executableBitDelta hash key. (This should have been exported
when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
* Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Updated results for:
"rename (with executable bit change)"
- Test value of executableBitDelta (now that we have support).
"SVN: binary file (isBinary true)"
- Remove the property change diff from svnConvertedText. We plan
to remove svnConvertedText in the future. So, we decided
against adding such support to any new code, such as the
property parsing routines. Therefore, we do not keep SVN
converted text for property change diffs.
- Added unit tests:
"SVN: file change diff with property change diff"
"SVN: file change diff, followed by property change diff on different file"
"SVN: property diff, followed by file change diff"
"SVN: copied file with property change"
"SVN: two consecutive property diffs"
"SVN: binary file with executable bit change"
"SVN: binary file followed by property change on different file"
"SVN: binary file followed by file change on different file"
"SVN: file change diff with property change, followed by property change diff"
"SVN: file change diff with property change, followed by file change diff"
2010-07-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement waitUntilDone and notifyDone for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42049
With this fix, most of the DOM tests pass.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didCreatePage): Track the main page. Not
a great way to do it in the future case where we may get multiple
pages - we really need a way to send it over from the ui process.
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::page): A way to get the main page.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
are loading.
(WTR::InjectedBundlePage::dump): Factor into a method so this can be
called by the layout test controller. Also, cancel any pending watchdogs.
(WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
to false.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate
the watchdog.
(WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
(WTR::LayoutTestController::setWaitToDump): Set the flag.
(WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
where waitUntilDone times out.
(WTR::LayoutTestController::notifyDone): Dump, if loading is done.
(WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
(WTR::notifyDoneCallback): JS glue for notifyDone.
(WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
to the layoutController.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
2010-07-09 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Dan Bernstein.
Windows testers running Windows 7 were hanging during test_kill_process. Changing the
number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
slow down the tests).
* Scripts/webkitpy/common/system/executive.py:
2010-07-09 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Mac build fix
https://bugs.webkit.org/show_bug.cgi?id=41967
Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2010-07-09 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Antonio Gomes.
[Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
https://bugs.webkit.org/show_bug.cgi?id=41966
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
2010-07-09 Leon Clarke <leonclarke@google.com>
Reviewed by Adam Barth.
add support for link prefetching
https://bugs.webkit.org/show_bug.cgi?id=3652
* Scripts/build-webkit:
2010-07-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
r63004 broke some python tests
https://bugs.webkit.org/show_bug.cgi?id=42007
AbstractStep now checks options.no_squash and options.squash, so
they needed to have real values. Mock would return an object for those,
which would then act as if the values were True.
* Scripts/webkitpy/tool/commands/commandtest.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/stepsequence.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
* Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
* Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
2010-07-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
--squash should go away and become the default
https://bugs.webkit.org/show_bug.cgi?id=39624
If there are local commits and working copy changes, then prompt the user
whether to continue. Setting git config webkit-patch.commit_should_always_squash
true bypasses the prompt.
--git-commit=HEAD.. operates on working copy changes only.
--git-commit=committish operates on a range of commits as a single commit.
e.g. --git-commit=HEAD only operates on the HEAD commit.
--git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
--no-squash and --squash are left in with descriptive error messages if used.
* Scripts/check-webkit-style:
* Scripts/webkitpy/common/checkout/api.py:
* Scripts/webkitpy/common/checkout/api_unittest.py:
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
* Scripts/webkitpy/common/net/rietveld.py:
* Scripts/webkitpy/common/system/user.py:
* Scripts/webkitpy/style/optparser.py:
* Scripts/webkitpy/style_references.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
* Scripts/webkitpy/tool/steps/checkstyle.py:
* Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
* Scripts/webkitpy/tool/steps/commit.py:
* Scripts/webkitpy/tool/steps/options.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
* Scripts/webkitpy/tool/steps/validatereviewer.py:
2010-07-09 Mark Rowe <mrowe@apple.com>
Add two new Windows test build slaves.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2010-07-09 Albert J. Wong <ajwong@chromium.org>
Reviewed by David Levin.
rebaseline_chromium_webkit_tests missing --use_drt option on linux
https://bugs.webkit.org/show_bug.cgi?id=41985
This adds in the --use_drt option for rebaseline_chromium_webkit_tests
so that it works on linux. This is essentially a "compile-fix" for the
script.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2010-07-09 Nico Weber <thakis@chromium.org>
Unreviewed. Adding myself as committer.
* Scripts/webkitpy/common/config/committers.py:
2010-07-09 David Kilzer <ddkilzer@apple.com>
Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
This reverts commit r62692.
* Scripts/commit-log-editor:
2010-07-08 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Ojan Vafai.
cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
https://bugs.webkit.org/show_bug.cgi?id=38693
Introduced a new base class JSONResultsGeneratorBase that doesn't
have any dependency on layout_tests packages.
Turned JSONResultsGenerator into a wrapper class of the base class
so that the old code can work with it during the cleanup.
Added json_results_generator_unittest.py.
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
2010-07-09 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Marking myself as a committer.
* Scripts/webkitpy/common/config/committers.py:
2010-07-09 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Antti Koivisto.
Implement MiniBrowser for Qt.
https://bugs.webkit.org/show_bug.cgi?id=40233
* MiniBrowser/qt/BrowserWindow.cpp: Added.
(createNewPage):
(BrowserView::BrowserView):
(BrowserView::resizeEvent):
(BrowserView::load):
(BrowserView::view):
(BrowserWindow::BrowserWindow):
(BrowserWindow::load):
(BrowserWindow::changeLocation):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h: Added.
(BrowserView::~BrowserView):
* MiniBrowser/qt/MiniBrowser.pro: Added.
* MiniBrowser/qt/main.cpp: Added.
(main):
2010-07-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Introduce the Qt autotest launcher.
Qt autotests should be executed more frequently, ideally by the Qt
build bot. This is the first step to provide the tests more accessible.
[Qt] It should be easier to run all Qt's autotests.
https://bugs.webkit.org/show_bug.cgi?id=31625
* Scripts/run-qtwebkit-tests: Added.
2010-07-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue should merge to TOT when checkout needs update
https://bugs.webkit.org/show_bug.cgi?id=41944
There are a bunch of different designs that are possible here. This
one merges to top of tree by cleaning out the working copy and
re-applying the patch. Once you decide to merge that way, you need to
decide who's going to retry. In this patch, we retry in the child
process instead of plumbing the failure reason to the master process.
This patch is difficult to test end-to-end, but hopefully it will work.
:)
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/stepsequence.py:
* Scripts/webkitpy/tool/multicommandtool.py:
* Scripts/webkitpy/tool/multicommandtool_unittest.py:
2010-07-09 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Darin Adler.
Add a script to check for unnecessary includes in header files.
https://bugs.webkit.org/show_bug.cgi?id=41894
* Scripts/check-header-includes: Added.
2010-07-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add --html5-treebuilder option to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=41922
We're down to one or two regressions in the HTML5lib test suite. It's
getting to be time to look at fixing LayoutTests.
* Scripts/old-run-webkit-tests:
2010-07-08 Simon Fraser <simon.fraser@apple.com>
Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
in the drawing model never getting set on Tiger.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
2010-07-08 Aaron Boodman <aa@chromium.org>
Reviewed by Timothy Hatcher.
Add the ability for user scripts and user styles to affect just the top frame.
https://bugs.webkit.org/show_bug.cgi?id=41529
* DumpRenderTree/LayoutTestController.h: Added new allFrames param.
* DumpRenderTree/LayoutTestController.cpp: Ditto.
(addUserScriptCallback):
(addUserStyleSheetCallback):
* DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
* DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
* DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
2010-07-08 Adele Peterson <adele@apple.com>
Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
<rdar://problem/8158561> Missing plug-in indicator should have a pressed state
Log when the missing plugin button is pressed.
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:didPressMissingPluginButton:]):
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::QueryInterface):
(UIDelegate::createWebViewWithRequest):
(UIDelegate::drawBackground):
(UIDelegate::decidePolicyForGeolocationRequest):
(UIDelegate::didPressMissingPluginButton):
* DumpRenderTree/win/UIDelegate.h:
2010-07-08 Simon Fraser <simon.fraser@apple.com>
Fix the Tiger build.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
2010-07-08 Simon Fraser <simon.fraser@apple.com>
Fix windows build.
#ifdef code for Mac.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
2010-07-08 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Allow the TestPlugin to use Core Animation rendering for testing
https://bugs.webkit.org/show_bug.cgi?id=41872
Add the ability for the TestPlugin to use the CoreAnimation rendering model
when available, based on the "drawingmodel" attribute of the embed tag:
drawingmodel="coreanimation"
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
when building on Tiger. Add a void* coreAnimationLayer member.
* DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
(createCoreAnimationLayer): Obj-C method to create the CALayer.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New): Look for the drawingmodel attribute to decide which drawing
model to use.
(NPP_Destroy): Release the CALayer if we have one.
(NPP_GetValue): Return the retained CALayer.
2010-07-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Support pixel tests
https://bugs.webkit.org/show_bug.cgi?id=31518
Convert this file from CRLF to NL line endings. It will soon
be used on more than just the WinCairo platform.
* DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
(writeFunction):
(printPNG):
(computeMD5HashStringForBitmapContext):
(dumpBitmap):
2010-07-08 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Enable Data Execution Prevention for our test harnesses on Windows
https://bugs.webkit.org/show_bug.cgi?id=41882
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/ImageDiff.vcproj:
* WebKitAPITest/WebKitAPITest.vcproj:
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
2010-07-07 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add DRT support for pageProperty etc.
https://bugs.webkit.org/show_bug.cgi?id=41584
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::isPageBoxVisible):
(LayoutTestController::pageSizeAndMarginsInPixels):
(LayoutTestController::pageProperty):
(LayoutTestController::addUserStyleSheet):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-07-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Remove a warnings from the ImageDiff build by using the proper
printf format string for the gsize data type.
* DumpRenderTree/gtk/ImageDiff.cpp:
(printImage): Use the proper printf format string for the gsize data type.
2010-07-08 Alice Liu <alice.liu@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=41653
Add new WebKitTestRunner project for Windows
* WebKitTestRunner/WebKitTestRunnerPrefix.h:
Similar to how it's done in DumpRenderTree, define max and min early
on so that they don't get replaced by a macro requiring 2 arguments.
* WebKitTestRunner/win: Added.
* WebKitTestRunner/win/WebKitTestRunner.sln: Added.
* WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
* WebKitTestRunner/win/main.cpp: Added.
(main): Implemented
Added these files with stubbed out functions:
* WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::page):
* WebKitTestRunner/win/TestControllerWin.cpp: Added.
(WTR::TestController::initializeInjectedBundlePath):
* WebKitTestRunner/win/TestInvocationWin.cpp: Added.
(WTR::TestInvocation::runUntil):
2010-07-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Implement ImageDiff and add it to the build system
https://bugs.webkit.org/show_bug.cgi?id=41779
Add the initial implementation of the ImageDiff tool for the GTK+
port. This is an essential tool for doing pixel tests. The implementation
is based on the Mac and Chromium ports.
* DumpRenderTree/gtk/ImageDiff.cpp: Added.
(readPixbufFromStdin): Added.
(differenceImageFromDifferenceBuffer): Ditto.
(calculateDifference): Ditto.
(printImage): Ditto.
(printImageDifferences): Ditto.
(main): Ditto.
* GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
2010-07-08 Jay Civelli <jcivelli@chromium.org>
Unreviewed. Adding myself as a committer.
* Scripts/webkitpy/common/config/committers.py:
2010-07-08 Adam Roben <aroben@apple.com>
Make Windows stop running tests from platform/mac
r62742 made a change (at my suggestion!) that caused us to start
looking for tests in platform/mac, rather than just looking for
expected results in platform/mac. This patch just undoes that part of
r62742.
Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
tests from platform/mac, but shouldn't
Reviewed by Antti Koivisto and Anders Carlsson.
* Scripts/old-run-webkit-tests:
(top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
so we won't look in those directories for tests to run.
(expectedDirectoryForTest): Added back code from pre-r62742 to look in
platform/mac-snowleopard and platform/mac for expected results.
2010-07-08 Antonio Gomes <tonikitoo@webkit.org>
Unreviewed. Adding myself as a reviewer.
* Scripts/webkitpy/common/config/committers.py:
2010-07-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Update my e-mail in committers.py
* Scripts/webkitpy/common/config/committers.py:
2010-07-07 Daniel Bates <dbates@rim.com>
Reviewed by Dumitru Daniliuc.
VCSUtils.pm complains about uninitialized value $newLine
https://bugs.webkit.org/show_bug.cgi?id=41333
Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
an array when fixing a change log entry that overlaps with an earlier
entry. In particular, when a patch contains a change log entry inserted
earlier in the change log file, but after an entry with the same author
and date.
* Scripts/VCSUtils.pm:
- Added for-loop constraint to fixChangeLogPatch() so that it does not
read off the end of the @overlappingLines array.
* Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
2010-07-07 Anders Carlsson <andersca@apple.com>
Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
2010-07-07 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
[DRT/Chromium] Support for indeterminate checkbox
https://bugs.webkit.org/show_bug.cgi?id=41747
Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
* DumpRenderTree/chromium/WebThemeControlDRT.cpp:
(WebThemeControlDRT::draw):
* DumpRenderTree/chromium/WebThemeControlDRT.h:
(WebThemeControlDRT::):
* DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
(WebThemeEngineDRT::paintButton):
2010-07-07 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Clean up MiniBrowser Xcode project.
- Use xcconfig files.
- Rename plists to canonical Info.plist
- Remove localizations.
* MiniBrowser/Configurations: Added.
* MiniBrowser/Configurations/Base.xcconfig: Added.
* MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
* MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
* MiniBrowser/Configurations/WebBundle.xcconfig: Added.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/WebBundle-Info.plist: Removed.
* MiniBrowser/mac/BrowserStatisticsWindowController.m:
(-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
* MiniBrowser/mac/BrowserWindow.xib: Added.
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithPageNamespace:]):
* MiniBrowser/mac/English.lproj: Removed.
* MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
* MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
* MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
* MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
* MiniBrowser/mac/MainMenu.xib: Added.
* MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
* MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
2010-07-07 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Fix two regressions
https://bugs.webkit.org/show_bug.cgi?id=41745
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::paintInvalidatedRegion):
Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
and svg/custom/use-on-g-containing-foreignObject-and-image.svg
though test_shell does it twice. Probably DRT needs it because
DRT delays painting as possible.
2010-07-07 Anders Carlsson <andersca@apple.com>
Try to fix build.
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_destroy_stream):
2010-07-07 Anders Carlsson <andersca@apple.com>
Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_stream):
(webkit_test_plugin_destroy_stream):
(webkit_test_plugin_write_ready):
(webkit_test_plugin_write):
2010-07-07 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Don't hard code the Mac OS X 10.6 SDK for MiniBrowser.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2010-07-07 Anders Carlsson <andersca@apple.com>
Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
(NPP_HandleEvent):
2010-07-07 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Need to have a way to specify different results for Windows XP and 7
https://bugs.webkit.org/show_bug.cgi?id=41776
Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
subdirectories, so we can have different results for tests on Windows XP, Windows
Vista, and Windows 7.
Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
This matches the behavior of the mac.
* Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
or Vista, try looking in other win-* subdirectories before win.
* Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
we are running.
2010-07-07 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
https://bugs.webkit.org/show_bug.cgi?id=41753
The original code of the following functions in
test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
ASSERT_NOT_REACHED(). The program shouldn't stop at these
functions.
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::activateWindow):
(DRTDevToolsClient::closeWindow):
(DRTDevToolsClient::dockWindow):
(DRTDevToolsClient::undockWindow):
2010-07-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
https://bugs.webkit.org/show_bug.cgi?id=41821
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginGetProperty):
(pluginSetProperty):
(pluginAllocate):
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
Add and initialize the returnNegativeOneFromWrite property.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_NewStream):
Set the stream type to NP_NORMAL so we'll get write callbacks.
(NPP_DestroyStream):
Treat the onstreamdestroy attribute as a function name and not a string.
(NPP_WriteReady):
Have this return a nonzero value.
(NPP_Write):
If returnNegativeOneFromWrite is true return -1.
2010-07-07 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
latest version is selected by default, and allows the version to be specified.
* wx/build/settings.py:
2010-07-07 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
https://bugs.webkit.org/show_bug.cgi?id=41810
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::selectedTextRange):
2010-07-07 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Build fix after r62700.
* GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
source file locations.
2010-07-07 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
https://bugs.webkit.org/show_bug.cgi?id=41814
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* Scripts/old-run-webkit-tests:
2010-07-07 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
add --exit-after-n-crashes to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=41811
Change the bots at build.webkit.org to use --exit-after-n-crashes
instead of --exit-after-n-failures since we want to be able to have
more than 20 failures on those bots, but more than 20 crashes means
something should be rolled out.
* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-07-07 Brian Weinstein <bweinstein@apple.com>
Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
TestNetscapePlugin project, because this was removed from the tree.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2010-07-07 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Unify Mac and Windows TestNetscapePlugin main.cpp files
https://bugs.webkit.org/show_bug.cgi?id=41798
* DumpRenderTree/DumpRenderTree.sln:
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(strcasecmp):
(NP_Initialize):
(NP_GetEntryPoints):
(NP_Shutdown):
(NPP_New):
(NPP_Destroy):
(NPP_HandleEvent):
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
2010-07-07 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix. pageProperty needs to return a value.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::pageProperty):
2010-07-07 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
Reviewed by Anders Carlsson.
For both svn and git, commit-log-editor is invoked from the root
of the working directory. Unlike svn, git returns a list of
changed files that are relative to the directory where the
command was invoked. This caused the ChangeLog file in the root
directory to be read instead of the ChangeLog in the current
directory.
The fix is to use $ENV{PWD} as the base directory when fixing
the path to the ChangeLog files. With svn, this has no net
effect since $ENV{PWD} is the root of the working directory and
the ChangeLog paths are already relative to that directory.
With git, $ENV{PWD} is the directory that the commit was invoked
from, which fixes the ChangeLog paths so that the correct files
are read when creating the commit log entry.
Note that the call to makeFilePathRelative() was supposed to
address this issue, but it doesn't because (a) it does nothing
with svn working directories by design, and (b) it does nothing
with git working directories because it's invoked when the
current directory is the root of the working directory, thus
giving no relative path.
* Scripts/commit-log-editor: Removed call to
makeFilePathRelative() since since it does nothing. Moved code
to fix up $changeLog path so that it's fixed before trying to
open the file, and use $ENV{PWD} as the base path. Also use
canonicalizePath() to clean up paths with "../" in them.
2010-07-07 Anders Carlsson <andersca@apple.com>
Another attempt at fixing the Qt build.
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2010-07-07 Anders Carlsson <andersca@apple.com>
Try to fix Qt build.
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2010-07-07 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
https://bugs.webkit.org/show_bug.cgi?id=41781
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
* DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
* DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
* DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
* DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
* DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2010-07-07 Andras Becsi <abecsi@webkit.org>
Unreviewed trivial fix.
Remove DUMPRENDERTREE_TEMP environment variable from NRWT
which was checked in accidentally in r62635.
* Scripts/webkitpy/layout_tests/port/webkit.py:
2010-07-07 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Pass port specific environment to server process.
https://bugs.webkit.org/show_bug.cgi?id=41593
* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
2010-07-06 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
Fix a wrong dup detection of rebaseline-chromium-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=41644
rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
tolerance. We don't need tolerance for rebaseline.
* Scripts/webkitpy/layout_tests/port/base.py:
Add optional tolerance parameter to diff_image().
* Scripts/webkitpy/layout_tests/port/test.py:
Add optional tolerance parameter to diff_image().
* Scripts/webkitpy/layout_tests/port/webkit.py:
Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
diff_files() always calls diff_image() with tolerance=0.
diff_files() is used only by rebaseline-chromium-webkit-tests.
2010-07-06 Sam Weinig <sam@webkit.org>
Fix MiniBrowser build.
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
2010-07-06 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add support for dumping the contents of messages to the console to WebKitTestRunner
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_addMessageToConsole):
(WTR::InjectedBundlePage::addMessageToConsole):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2010-07-06 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
Add dumpAsText support for WebKitTestRunner
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
API to dump the main frames text.
2010-07-06 Darin Adler <darin@apple.com>
Fix Chromium build.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didCreateDataSource): Call leakPtr instead of release.
(WebViewHost::didNavigateWithinPage): Ditto.
(WebViewHost::updateURL): Ditto.
2010-07-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] build-webkit should not run autogen.sh unconditionally
https://bugs.webkit.org/show_bug.cgi?id=41704
* Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
some very minor cleanup.
2010-07-06 Darin Adler <darin@apple.com>
Try to fix Chromium build.
* DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
2010-07-06 Darin Adler <darin@apple.com>
Fix build.
* WebKitAPITest/TestsController.cpp:
(WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
2010-07-06 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=40558
Upstream DevTools for Chromium DRT.
(original Chromium files rev. 51287)
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
(DRTDevToolsAgent::DRTDevToolsAgent):
(DRTDevToolsAgent::setWebView):
(DRTDevToolsAgent::sendMessageToFrontend):
(DRTDevToolsAgent::forceRepaint):
(DRTDevToolsAgent::runtimeFeatureStateChanged):
(DRTDevToolsAgent::injectedScriptSource):
(DRTDevToolsAgent::injectedScriptDispatcherSource):
(DRTDevToolsAgent::debuggerScriptSource):
(DRTDevToolsAgent::asyncCall):
(DRTDevToolsAgent::call):
(DRTDevToolsAgent::webDevToolsAgent):
(DRTDevToolsAgent::attach):
(DRTDevToolsAgent::detach):
(DRTDevToolsAgent::setTimelineProfilingEnabled):
(DRTDevToolsAgent::evaluateInWebInspector):
(DRTDevToolsAgent::dispatchMessageLoop):
* DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
(DRTDevToolsAgent::~DRTDevToolsAgent):
(DRTDevToolsAgent::hostIdentifier):
* DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
* DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
(DRTDevToolsCallArgs::DRTDevToolsCallArgs):
(DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
(DRTDevToolsCallArgs::callsCount):
* DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
(DRTDevToolsClient::DRTDevToolsClient):
(DRTDevToolsClient::~DRTDevToolsClient):
(DRTDevToolsClient::sendMessageToAgent):
(DRTDevToolsClient::sendDebuggerCommandToAgent):
(DRTDevToolsClient::activateWindow):
(DRTDevToolsClient::closeWindow):
(DRTDevToolsClient::dockWindow):
(DRTDevToolsClient::undockWindow):
(DRTDevToolsClient::asyncCall):
(DRTDevToolsClient::call):
(DRTDevToolsClient::allMessagesProcessed):
* DumpRenderTree/chromium/DRTDevToolsClient.h:
* DumpRenderTree/chromium/EventSender.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::closeWebInspector):
(LayoutTestController::setTimelineProfilingEnabled):
(LayoutTestController::evaluateInWebInspector):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::~TestShell):
(TestShell::createDRTDevToolsClient):
(TestShell::showDevTools):
(TestShell::closeDevTools):
(TestShell::runFileTest):
(TestShell::createNewWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::drtDevToolsAgent):
(TestShell::drtDevToolsClient):
* DumpRenderTree/chromium/config.h:
2010-07-06 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Don't pass image hash to DRT when pixel tests are disabled.
https://bugs.webkit.org/show_bug.cgi?id=41597
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2010-07-05 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
https://bugs.webkit.org/show_bug.cgi?id=41612
* Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
2010-07-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
We should be able to specify a bug to block for webkit-patch upload
https://bugs.webkit.org/show_bug.cgi?id=41648
This will be useful for working on the HTML5 parser.
* Scripts/webkitpy/tool/steps/createbug.py:
* Scripts/webkitpy/tool/steps/options.py:
2010-07-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Oliver Hunt.
The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
https://bugs.webkit.org/show_bug.cgi?id=41017
* Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
* Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
2010-07-04 MORITA Hajime <morrita@google.com>
rebaseline-chromium-webkit-tests: UnicodeDecodeError
https://bugs.webkit.org/show_bug.cgi?id=41589
* run() method can result non-utf-8 bytes, that causes utf-8
decoding fail. Fixed to disable decoding.
* Fixed Git.find_checkout_root() to make a test pass.
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
2010-07-03 Patrick Gansterer <paroga@paroga.com>
Reviewed by Simon Hausmann.
[Qt] Fix DumpRenderTree userStyleSheet handling.
https://bugs.webkit.org/show_bug.cgi?id=41570
DumpRenderTree did only set the userStyleSheet at
layoutTestController.setUserStyleSheetEnabled().
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::setUserStyleSheetLocation):
(LayoutTestController::setUserStyleSheetEnabled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-07-03 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] support dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=41088
Unskip:
http/tests/navigation/anchor-subframeload.html
http/tests/navigation/relativeanchor-frames.html
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::dumpFrameScrollPosition):
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::shouldDumpChildFrameScrollPositions):
(LayoutTestController::dumpChildFrameScrollPositions):
2010-07-02 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
* Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
* Scripts/debug-webkittestrunner: Removed.
* Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
* Scripts/run-webkittestrunner: Removed.
2010-07-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
Some http tests fail on Windows with Cygwin 1.7
https://bugs.webkit.org/show_bug.cgi?id=41537
With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if
SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
2010-06-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109
The JavaScriptCore cppflags used to include the top-level DerivedSources directory
allowing the tools to build as a side-effect. Now that the top-level directory
is no longer in the list of JavaScriptCore includes, include it explicitly.
* GNUmakefile.am:
2010-07-01 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make context menus show up in the right place in QTestBrowser
Context menus were shown at scene-relative coordinates for
QGraphicsWebView while QMenu expects them to be global. The
change to the QWidget case was to get rid of the mapToGlobal.
* QtTestBrowser/webview.cpp:
2010-07-01 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] dump frames in ascending alphabetical order of title
https://bugs.webkit.org/show_bug.cgi?id=41261
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::dumpHistoryItem):
2010-07-01 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Fix the GTK+ build after r62278.
* Scripts/webkitdirs.pm: If the make arguments have already been specified,
let them override the automatic CPU detection for autotools builds.
2010-07-01 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Fix the Windows build after r62278.
* Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
2010-07-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] build-webkit does not detect the number of CPUs
https://bugs.webkit.org/show_bug.cgi?id=41469
Pass the appropriate -j<#> flag to make when building autotools builds.
This causes make to spawn that many number of child processes for doing
parallel builds.
* Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
of CPUs. This makes the script work across more platforms.
* Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
number of CPUs across several platforms. Use this new function to determine the appropriate
arguments to pass to make for doing parallel builds with autotools build files.
2010-07-01 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Laszlo Gombos.
[Qt][Symbian] Bumped up the maximum heap size to 96MB
* QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
and use the one from WebKit.pri instead.
2010-07-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Promote webkit-patch land-safely to main help
https://bugs.webkit.org/show_bug.cgi?id=41446
I've been using this command a bunch and recommending it to folks. We
should show it in main help as it's past the experimental phase.
* Scripts/webkitpy/tool/commands/upload.py:
2010-06-28 MORITA Hajime <morrita@google.com>
Reviewed by Shinichiro Hamaji.
rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
https://bugs.webkit.org/show_bug.cgi?id=38775
- Introduced SCM.show_head() and SCM.diff_for_file().
- Replaced direct svn invocations with newly implement SCM methods.
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2010-06-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Allow MiniBrowser to open local files
https://bugs.webkit.org/show_bug.cgi?id=41104
Wire up the openDocument: message with an NSOpenPanel, so we can open
local files.
Also change the xib so that the window remembers its size.
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate frontmostBrowserWindowController]):
(-[BrowserAppDelegate openDocument:]):
(-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
* MiniBrowser/mac/English.lproj/BrowserWindow.xib:
2010-06-30 Sam Weinig <sam@webkit.org>
Rubber-stamped by Anders Carlsson.
Add debug-webkittestrunner and cleanup related scripts.
* Scripts/debug-webkittestrunner: Added.
* Scripts/run-webkittestrunner:
* Scripts/webkitdirs.pm:
2010-06-30 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix after recent changes to LayoutTestController.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::pageSizeAndMarginsInPixels):
2010-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
Make WebKitTestRunner work with more than one test at a time.
This converts WebKitTestRunner to a similar model as DumpRenderTree,
where there is a single WKView and each test is run it, rather than
the design I was using where each test got its own WKView.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didRecieveMessage):
(WTR::InjectedBundle::reset):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::runTest):
(WTR::TestController::_didRecieveMessageFromInjectedBundle):
(WTR::TestController::didRecieveMessageFromInjectedBundle):
* WebKitTestRunner/TestController.h:
(WTR::TestController::mainWebView):
(WTR::TestController::pageNamespace):
(WTR::TestController::context):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
* WebKitTestRunner/TestInvocation.h:
2010-06-30 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
https://bugs.webkit.org/show_bug.cgi?id=40446
We quickly run out of memory on Symbian when loading web pages. This is
caused by the default heap size, which is not suited for a web browser.
This change bumps the max heap size to 32MB.
* QtTestBrowser/QtTestBrowser.pro:
2010-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch land allow the user to continue even if the builders are red
https://bugs.webkit.org/show_bug.cgi?id=41395
I don't think it's good that we've been teaching people
to always pass --ignore-builders. At least land is now
useable w/o --ignore-builders.
* Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
2010-06-29 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] support dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=41260
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::dumpResourceResponseMIMETypes):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-06-29 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Resize scene when Qt DRT WebPage receives a geometry change request
https://bugs.webkit.org/show_bug.cgi?id=41173
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::setViewGeometry):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
2010-06-29 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Deal with postEvent in case of graphics based DRT
https://bugs.webkit.org/show_bug.cgi?id=41174
QGraphicsScene does not have a postEvent method, so make scene
send the event, in case of graphics based DRT, and delete it after that.
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::scheduleAsynchronousClick):
(EventSender::replaySavedEvents):
(EventSender::postEvent):
* DumpRenderTree/qt/EventSenderQt.h:
2010-06-29 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=41172
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::switchFocus):
2010-06-29 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Make DRT more coherent with other ports to allow reusing more tests
https://bugs.webkit.org/show_bug.cgi?id=40009
Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
are used when returning those values, for coherency with other ports.
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::role):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
2010-06-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r62106.
http://trac.webkit.org/changeset/62106
https://bugs.webkit.org/show_bug.cgi?id=41346
"Broke editing tests" (Requested by xan_ on #webkit).
* Scripts/old-run-webkit-tests:
2010-06-29 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
Ensure DRT loads GAIL (Gtk+ module), for a11y tests
https://bugs.webkit.org/show_bug.cgi?id=38648
Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port
* Scripts/old-run-webkit-tests:
2010-06-28 Adam Barth <abarth@webkit.org>
Unreviewed.
Switch test-html5-parser back to using runner.html.
* Scripts/test-html5-parser:
2010-06-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Restore webkit-runner.html for use with new tree builder
https://bugs.webkit.org/show_bug.cgi?id=41317
For now, we just want to run webkit-runner when we test-html5-parser.
* Scripts/test-html5-parser:
2010-06-23 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100
* Scripts/build-webkit:
2010-06-28 Gustavo Noronha Silva <gns@gnome.org>
Rubber-stamped by Xan Lopez.
Update webkitdirs's knowledge of our library's name.
* Scripts/webkitdirs.pm:
2010-06-28 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
Build up WebKitTestRunner output in the InjectedBundle
Simplify WebKitTestRunner by building up the output in the InjectedBundle
and sending it over postMessage when done, instead of using the async
WKPageRenderTreeExternalRepresentation.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::didRecieveMessage):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::os):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::WKStringToUTF8):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::WKStringToUTF8):
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::initializeMainWebView):
(WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
(WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
* WebKitTestRunner/TestInvocation.h:
2010-06-28 Robert Hogan <robert@webkit.org>
Unreviewed, rolling out r62021.
http://trac.webkit.org/changeset/62021
https://bugs.webkit.org/show_bug.cgi?id=41261
Broke http/navigation tests among other
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::dumpFramesAsText):
2010-06-28 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add run-webkittestrunner to run WebKitTestRunner with the appropriate
environment.
* Scripts/run-webkittestrunner: Added.
* Scripts/webkitdirs.pm:
2010-06-28 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] dump frames in ascending alphabetical order of title
https://bugs.webkit.org/show_bug.cgi?id=41261
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::dumpFramesAsText):
2010-06-28 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] dump bf history of child windows
https://bugs.webkit.org/show_bug.cgi?id=41266
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::dumpBackForwardList):
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
2010-06-28 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
WebKit2: Add frame API for InjectedBundle code
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(_didClearWindowForFrame):
2010-06-28 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
https://bugs.webkit.org/show_bug.cgi?id=38597
Fix behavior so reload button really acts as a load and a reload button.
* QtTestBrowser/mainwindow.cpp:
(MainWindow::changeLocation):
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851
Fix build with GSEAL enabled.
* DumpRenderTree/gtk/EventSender.cpp:
(gtk_widget_get_window):
(prepareMouseButtonEvent):
(mouseMoveToCallback):
(mouseWheelToCallback):
(keyDownCallback):
2010-06-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253
Adapt build system for 3.x support.
* GNUmakefile.am:
2010-06-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Simon Hausmann.
[QT][S60] build-webkit scripts picks wrong make spec for windows build
https://bugs.webkit.org/show_bug.cgi?id=41198
Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds.
* Scripts/webkitdirs.pm:
(determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
2010-06-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to test the new HTML5 TreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41276
Adam was concerned that someone might make their port
depend on this setting (I guess we had some trouble with that
with the HTML5Parser setting), so I littered the code with warnings.
test-html5-parser now tests this code path.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
(initializeGlobalsFromCommandLineOptions):
* Scripts/test-html5-parser:
2010-06-27 MORITA Hajime <morrita@google.com>
Unreviewed.
Some never-called @staticmethods touched self.
Fixed it to replace these self with a class.
* Scripts/webkitpy/common/checkout/scm.py:
2010-06-27 MORITA Hajime <morrita@google.com>
Unreviewed.
Fixed exception raising syntax that is pointed out at
https://bugs.webkit.org/show_bug.cgi?id=41153
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
Removed a bad line that I accidentally checked-in at last revision.
2010-06-24 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
rebaseline-chromium-webkit-tests should add or remove files to local git repository
https://bugs.webkit.org/show_bug.cgi?id=41153
- Added SCM.add() and SCM.remove()
- Replaced "svn add" and "svn remove"
rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
- add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
for debugging purpose.
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2010-06-25 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Improve default value handling for page format properties.
https://bugs.webkit.org/show_bug.cgi?id=41150
* DumpRenderTree/LayoutTestController.cpp:
(parsePageNumber):
(parsePageNumberSizeMarings):
(pageSizeAndMarginsInPixelsCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::pageSizeAndMarginsInPixels):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::pageSizeAndMarginsInPixels):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::pageSizeAndMarginsInPixels):
2010-06-21 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Support for setCustomPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=39564
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setCustomPolicyDelegate):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-06-26 Robert Hogan <robert@webkit.org>
Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
exported.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2010-06-26 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Dimitri Glazkov.
Add a build-webkit option for enabling Web Timing support.
https://bugs.webkit.org/show_bug.cgi?id=38924
* Scripts/build-webkit:
2010-06-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
https://bugs.webkit.org/show_bug.cgi?id=38597
Make the reload button act as a load button as well.
* QtTestBrowser/mainwindow.cpp:
(MainWindow::buildUI):
(MainWindow::changeLocation):
2010-06-25 Prasad Tammana <prasadt@chromium.org>
Reviewed by Dmitry Titov.
Add empty abortModal() method to all platforms.
https://bugs.webkit.org/show_bug.cgi?id=40864
Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
platform independent LayoutTestController code. Without this change, layout tests using LayoutTestController tests
that use abortModal will become mac specific which is not desirable.
* DumpRenderTree/LayoutTestController.cpp:
(abortModalCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::abortModal):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::abortModal):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::abortModal):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::abortModal):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::abortModal):
2010-06-25 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
(WTR::InjectedBundle::shared):
(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::_didCreatePage):
(WTR::InjectedBundle::_willDestroyPage):
(WTR::InjectedBundle::_didRecieveMessage):
(WTR::InjectedBundle::initialize):
(WTR::InjectedBundle::didCreatePage):
(WTR::InjectedBundle::willDestroyPage):
(WTR::InjectedBundle::didRecieveMessage):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
(WTR::InjectedBundle::layoutTestController):
* WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
(WKBundleInitialize):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::~InjectedBundlePage):
(WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::_didCommitLoadForFrame):
(WTR::InjectedBundlePage::_didFinishLoadForFrame):
(WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::_didReceiveTitleForFrame):
(WTR::InjectedBundlePage::_didClearWindowForFrame):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
(WTR::InjectedBundlePage::page):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
(WTR::LayoutTestController::create):
(WTR::LayoutTestController::LayoutTestController):
(WTR::LayoutTestController::~LayoutTestController):
(WTR::dumpAsTextCallback):
(WTR::layoutTestControllerObjectFinalize):
(WTR::LayoutTestController::makeWindowObject):
(WTR::LayoutTestController::getJSClass):
(WTR::LayoutTestController::staticFunctions):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::setDumpAsText):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010-06-25 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Make WebKitTestRunner really work with run-webkit-tests.
- Add Forwarding headers to allow some cleanup.
* WebKitTestRunner/ForwardingHeaders: Added.
* WebKitTestRunner/ForwardingHeaders/wtf: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
* WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dump): Dump the right number of #EOFs.
* WebKitTestRunner/TestInvocation.h:
2010-06-25 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add support for WebKitTestRunner to old-run-webkit-tests
- Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
* Scripts/build-webkittestrunner: Added.
* Scripts/old-run-webkit-tests:
2010-06-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Incremental build failed on Chromium ews
https://bugs.webkit.org/show_bug.cgi?id=41011
The division of responsibility between update-webkit --chromium and
build-webkit --chromium is slightly unclear. In this patch, we make
build-webkit --chromium also update DEPS and re-run GYP in case the
developer has changed either since they updated.
This change is also helpful for the EWS, which wants to update DEPS and
re-run GYP after applying patches, but the EWS doesn't want to run
update-webkit --chromium because it has a dirty working copy.
* Scripts/webkitdirs.pm:
2010-06-25 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Support evaluateScriptInIsolatedWorld()
https://bugs.webkit.org/show_bug.cgi?id=40079
Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
Remove QWebScriptWorld from exported headers.
Confine support to DumpRenderTreeSupportQt so that the tests can pass.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::evaluateScriptInIsolatedWorld):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-06-25 Anders Carlsson <andersca@apple.com>
Revert accidental part and add a newline.
* MiniBrowser/mac/AppDelegate.m:
* MiniBrowser/mac/MiniBrowser_Prefix.pch:
2010-06-25 Anders Carlsson <andersca@apple.com>
Rubber-stamped by Dan Bernstein.
Add a LOG macro that expands to a no-op by default.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/AppDelegate.m:
(_didRecieveMessageFromInjectedBundle):
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController windowShouldClose:]):
(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFinishLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didReceiveTitleForFrame):
(_didFirstLayoutForFrame):
(_didFirstVisuallyNonEmptyLayoutForFrame):
(_didBecomeUnresponsive):
(_didBecomeResponsive):
(_decidePolicyForNavigationAction):
(_decidePolicyForNewWindowAction):
(_createNewPage):
(_showPage):
(_closePage):
(_didNavigateWithNavigationData):
(_didPerformClientRedirect):
(_didPerformServerRedirect):
(_didUpdateHistoryTitle):
* MiniBrowser/mac/MiniBrowser_Prefix.pch:
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(_didClearWindowForFrame):
(_didCreatePage):
(_willDestroyPage):
(_didRecieveMessage):
2010-06-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue is taking too long to land patches because of red trees
https://bugs.webkit.org/show_bug.cgi?id=41194
Instead of checking for the tree to be green, we'll just spin hot
trying to land patches. This is probably too extreme in ignoring the
tree, but I think we should try it for a while to see if we have
trouble. That will help us find the right balance.
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
2010-06-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Clean up the use of gdk_window_get_root_coords in EventSender
https://bugs.webkit.org/show_bug.cgi?id=40843
Define the version for old GTK+s in a way that is forward-compatible
and clean up the logic a bit.
* DumpRenderTree/gtk/EventSender.cpp:
(gdk_window_get_root_coords): Renamed and cleaned up.
(prepareMouseButtonEvent): Remove #ifdefs.
(mouseMoveToCallback): Remove #ifdefs.
2010-06-24 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Fix NewRunWebKitTests to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=41180
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
because Windows fails to understand what we're asking of it.
2010-06-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] The url passed to the WebView during layout tests is invalid
https://bugs.webkit.org/show_bug.cgi?id=40832
Set the test URL to the full real file URL and do a small cleanup.
Previously a URL like file://relative/path/to/test.html was passed
to the WebView. This malformed file URL would be returned by
webkit_web_view_get_url and webkit_web_frame_get_url.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
(shouldOpenWebInspector): Change to take a const string& as the argument.
(shouldEnableDeveloperExtras): Change to take a const string& as the argument.
(runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
2010-06-24 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix WebKitTestRunner Makefile typos.
* WebKitTestRunner/Makefile:
2010-06-24 Adele Peterson <adele@apple.com>
Reviewed by Eric Carlson.
DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
https://bugs.webkit.org/show_bug.cgi?id=41085
* DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
2010-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
Add new WebKitTestRunner project (ie. DRT for WebKit2).
- Mac only.
- run-webkit-tests has not been modified to call it yet.
- Only dumps the render tree at this time.
* WebKitTestRunner: Added.
* WebKitTestRunner/Configurations: Added.
* WebKitTestRunner/Configurations/Base.xcconfig: Added.
* WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
* WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
* WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
* WebKitTestRunner/InjectedBundle: Added.
* WebKitTestRunner/InjectedBundle-Info.plist: Added.
* WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFinishLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didReceiveTitleForFrame):
(_didClearWindow):
(_didCreatePage):
(_willDestroyPage):
(_didRecieveMessage):
(WKBundleInitialize):
* WebKitTestRunner/Makefile: Added.
* WebKitTestRunner/PlatformWebView.h: Added.
(WTR::PlatformWebView::platformView):
* WebKitTestRunner/TestController.cpp: Added.
(WTR::TestController::shared):
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
(WTR::TestController::runTestingServerLoop):
(WTR::TestController::run):
* WebKitTestRunner/TestController.h: Added.
(WTR::TestController::verbose):
(WTR::TestController::injectedBundlePath):
* WebKitTestRunner/TestInvocation.cpp: Added.
(WTR::createWKURL):
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dump):
(WTR::TestInvocation::initializeMainWebView):
(WTR::TestInvocation::didStartProvisionalLoadForFrame):
(WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
(WTR::TestInvocation::didCommitLoadForFrame):
(WTR::TestInvocation::didFinishLoadForFrame):
(WTR::TestInvocation::didFailLoadForFrame):
(WTR::TestInvocation::renderTreeExternalRepresentationFunction):
(WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
* WebKitTestRunner/TestInvocation.h: Added.
* WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
* WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
* WebKitTestRunner/mac: Added.
* WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::page):
* WebKitTestRunner/mac/TestInvocationMac.mm: Added.
(WTR::TestInvocation::runUntil):
* WebKitTestRunner/mac/main.mm: Added.
(main):
2010-06-24 Luiz Agostini <luiz.agostini@openbossa.org>
Unreviewed. Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-06-23 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::isPageBoxVisible):
(LayoutTestController::pageAreaRectInPixels):
(LayoutTestController::preferredPageSizeInPixels):
* wx/build/settings.py:
2010-06-23 James Robinson <jamesr@chromium.org>
Unreviewed. Add my IRC handle to committers.py so the sheriffbot can yell at me.
* Scripts/webkitpy/common/config/committers.py:
2010-06-23 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Correct Chromium test configuration
https://bugs.webkit.org/show_bug.cgi?id=41057
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
- Add "--use-drt" option for NRWT. It is required for Chromium and
ignored for other platforms.
- Skip JSC test on Chromium
* BuildSlaveSupport/test-result-archive:
Add Chromium support.
2010-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
WebKit2: Flesh out more of the InjectedBundle client API
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFinishLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didReceiveTitleForFrame):
(_didClearWindowForFrame):
(_didCreatePage):
(_willDestroyPage):
(WKBundleInitialize):
2010-06-23 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Implement page format data programming interface.
Add methods for testing.
https://bugs.webkit.org/show_bug.cgi?id=37538
* DumpRenderTree/LayoutTestController.cpp:
(parsePageNumber):
(isPageBoxVisibleCallback):
(pageAreaRectInPixelsCallback):
(preferredPageSizeInPixelsCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::isPageBoxVisible):
(LayoutTestController::pageAreaRectInPixels):
(LayoutTestController::preferredPageSizeInPixels):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::isPageBoxVisible):
(LayoutTestController::pageAreaRectInPixels):
(LayoutTestController::preferredPageSizeInPixels):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::isPageBoxVisible):
(LayoutTestController::pageAreaRectInPixels):
(LayoutTestController::preferredPageSizeInPixels):
2010-06-23 Sam Magnuson <smagnuson@netflix.com>
Reviewed by Shinichiro Hamaji.
Follow proper convention for if/switch/while as I've discovered
them to be through my review processes.
https://bugs.webkit.org/show_bug.cgi?id=40723
Modified test so that if( foo ) is not allowed as it appears not
to be the accepted convention.
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
2010-06-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Run clean-header-guards to fix some header guards
https://bugs.webkit.org/show_bug.cgi?id=41044
No functional changes, thus no tests.
This entire change was generated by running
clean-header-guards, and then reverting changes
to files which shouldn't be changed. Those which
are left all should be updated.
Some of these changes are just fixing 755 permissions
to be 644, since it seems various files have the wrong
execute bit which don't need it. clean-header-guards
made those (welcome) permission fixes unintentionally.
* DumpRenderTree/chromium/WebThemeControlDRT.h:
* DumpRenderTree/chromium/WebThemeEngineDRT.h:
* QtTestBrowser/fpstimer.h:
2010-06-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename HTMLDocumentParser to LegacyHTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=41043
Update the hash.
* Scripts/do-webcore-rename:
2010-06-22 Sam Magnuson <smagnuson@netflix.com>
Reviewed by Shinichiro Hamaji.
Follow proper convention for variable declaration spacing.
https://bugs.webkit.org/show_bug.cgi?id=40724
Modified test so that 'int a;' is not allowed.
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
2010-06-22 Eric Seidel <eric@webkit.org>
Unreviewed. Add Tony Gentilcore now that he's a committer.
* Scripts/webkitpy/common/config/committers.py:
2010-06-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Remove Gtk 64-Release bot from core since it's broken
https://bugs.webkit.org/show_bug.cgi?id=41022
This bot alone has been responsible for more than 72 hours of
commit-queue blockage in the last week. The bot is broken -- keeps
losing its display server or similar. Until the Gtk folks can fix the
bot, we need to remove it from core. The WebKit community can't keep
it green as is.
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/buildbot_unittest.py:
2010-06-21 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Eric Seidel.
Fix the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=40972
* DumpRenderTree/win/ImageDiff.vcproj:
2010-06-21 Prasad Tammana <prasadt@chromium.org>
Reviewed by Darin Adler, Dmitry Titov.
DumpRenderTree should allow tests with modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=35350
* DumpRenderTree/LayoutTestController.cpp:
(abortModalCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.
* DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
2010-06-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=40948
Have the script look in WebKit2.
* Scripts/do-webcore-rename:
2010-06-21 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.
https://bugs.webkit.org/show_bug.cgi?id=33344
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::addDisallowedURL):
2010-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
Add message passing support to the WebKit2 API.
- Add some test messages.
* MiniBrowser/mac/AppDelegate.m:
(_didRecieveMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(_didClearWindow):
(_didCreatePage):
(_didRecieveMessage):
(WKBundleInitialize):
2010-06-21 Drew Wilson <atwilson@chromium.org>
Unreviewed.
Rolling back 61551 and 61555 due to test failures.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setEditingBehavior):
* DumpRenderTree/mac/UIDelegate.mm:
2010-06-21 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Make DumpRenderTree build with clang++
* DumpRenderTree/mac/DumpRenderTreePasteboard.m:
(-[LocalPasteboard setPropertyList:forType:]):
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
(-[DumpRenderTreeWindow keyDown:]):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::elementDoesAutoCompleteForElementWithId):
(LayoutTestController::isCommandEnabled):
2010-06-21 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878
* Scripts/build-webkit:
2010-06-21 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Initialization for http/tests/loading/
https://bugs.webkit.org/show_bug.cgi?id=40902
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::runFileTest):
2010-06-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Unreviewed.
Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-06-20 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add --allow-external-pages option
https://bugs.webkit.org/show_bug.cgi?id=40762
Add --allow-external-pages introduced by Chromium r45403.
http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::allowExternalPages):
(TestShell::setAllowExternalPages):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willSendRequest):
2010-06-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Adam Barth.
Sheriffbot: Should allow "r" in SVN_REVISION
https://bugs.webkit.org/show_bug.cgi?id=40889
* Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
2010-06-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Dimitri Glazkov.
Python Tests Fail after r61508
https://bugs.webkit.org/show_bug.cgi?id=40891
Test's regex list needed to be updated to match the new
regex list in the source code. Added new bots to the
example_buildbots list.
Regex list fixed in r61512. Updated bot list.
* Scripts/webkitpy/common/net/buildbot_unittest.py:
2010-06-20 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
* Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2010-06-19 Justin Schuh <jschuh@chromium.org>
Unreviewed.
Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-06-19 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
Add ability to have a WebProcess per WebContext.
Move to use new shared contexts API.
* MiniBrowser/mac/AppDelegate.h:
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate getCurrentPageNamespace]):
(-[BrowserAppDelegate validateMenuItem:]):
(-[BrowserAppDelegate _setProcessModel:]):
(-[BrowserAppDelegate setSharedProcessProcessModel:]):
(-[BrowserAppDelegate setSharedThreadProcessModel:]):
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
2010-06-02 Robert Hogan <robert@webkit.org>
Reviewed by Adam Barth.
[Qt] Support evaluateScriptInIsolatedWorld()
https://bugs.webkit.org/show_bug.cgi?id=40079
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add three more non-core Chromium builders to start testing DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=40335
* BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
2010-06-18 Drew Wilson <atwilson@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::reset):
Changed obsolete call to clearName() to use setName(WebString()) instead.
2010-06-18 Sam Weinig <weinig@apple.com>
Rolling http://trac.webkit.org/changeset/61297 back in.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
* MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
(_didClearWindow):
(_didCreatePage):
(WKBundleInitialize):
2010-06-18 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=40803
TestNetscapePlugin has an incorrect implementation of "property" property
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
pass a static string back, it's going to be released by NPAPI implementation.
2010-06-18 Leandro Pereira <leandro@profusion.mobi>
Unreviewed.
Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
2010-06-17 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] cleanup redundant DEPS value and remove buildbot cleanup code
https://bugs.webkit.org/show_bug.cgi?id=40615
* Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
2010-06-17 Ada Chan <adachan@apple.com>
Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
* MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2010-06-17 Darin Adler <darin@apple.com>
One more try at fix for Chromium build.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Use set again instead of =.
2010-06-17 Darin Adler <darin@apple.com>
Fix Chromium build.
I didn't realize that neither Chromium nor Qt share the DumpRenderTree
code with all the other platforms! Wow, that should be fixed at some point.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Changed back to using "new".
* DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
2010-06-17 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt build fix.
LayoutTestController in the Qt DRT is not using refs :)
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
2010-06-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Use adoptRef and create functions in more code paths
https://bugs.webkit.org/show_bug.cgi?id=40760
* DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::create): Added.
* DumpRenderTree/LayoutTestController.h: Declare the create function.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Use create instead of new.
* DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest): Use RefPtr and create instead of OwnPtr and new.
* DumpRenderTree/mac/DumpRenderTree.mm:
(runTest): Use RefPtr and create instead of OwnPtr and new.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
instead of new.
* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest): Use RefPtr and create instead of OwnPtr and new.
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(runTest): Use RefPtr and create instead of OwnPtr and new.
(MyApp::OnInit): Removed unneeded code to delete the layout
test controller. This is done during each test.
2010-06-17 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
[DRT/Chromium] Fix a bug of Windows pixel tests
https://bugs.webkit.org/show_bug.cgi?id=40763
* DumpRenderTree/chromium/TestEventPrinter.cpp:
(TestShellPrinter::handleImage):
2010-06-16 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
[DRT/Chromium] Fix crash on Mac Release
https://bugs.webkit.org/show_bug.cgi?id=40759
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::paintRect): We should not use m_canvas directly because
it is created lazily in canvas().
2010-06-16 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix after new method addition.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::pageProperty):
2010-06-16 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Set current working directory for each of tests
https://bugs.webkit.org/show_bug.cgi?id=40668
This change fixes tests with eventSender.beginDragWithFiles().
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(runTest):
2010-06-16 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] r60803 broke media/controls-drag-timebar.html
https://bugs.webkit.org/show_bug.cgi?id=40269
Only queue events while the mouse button is down, if drag mode is enabled. Some
tests may disable drag mode, to prevent the queuing of events in this situation.
* DumpRenderTree/gtk/EventSender.cpp:
(sendOrQueueEvent): Only queue events here if dragMode is true.
2010-06-16 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
https://bugs.webkit.org/show_bug.cgi?id=40600
* DumpRenderTree/gtk/EventSender.cpp:
(prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
2010-06-16 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add a hidden land-cowboy command to webkit-patch to help land quick
build fixes.
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
2010-06-16 Adam Roben <aroben@apple.com>
Convert console messages to UTF-8 before printing them
Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
http/tests/security/xssAuditor/embed-tag-null-char.html and
http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
Windows. (I can't test the fix because Apache is crashing on my
computer.)
Reviewed by Alexey Proskuryakov.
* DumpRenderTree/win/DumpRenderTree.cpp:
(toUTF8): Extracted the code into an overload that takes a wide string
and a length, then added an overload that takes a wstring.
* DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
overload.
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
UTF-8 instead of letting printf convert to the current code page.
2010-06-16 Drew Wilson <atwilson@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):
Migrate to new createView() API.
* DumpRenderTree/chromium/WebViewHost.h:
Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
2010-06-16 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Scroll wheel event support to graphics based DRT
https://bugs.webkit.org/show_bug.cgi?id=40577
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::continuousMouseScrollBy):
(EventSender::createGraphicsSceneWheelEvent):
* DumpRenderTree/qt/EventSenderQt.h:
2010-06-16 Adam Roben <aroben@apple.com>
Remove a stray newline from the Windows version of TestNetscapePlugin
Reviewed by Alexey Proskuryakov.
Fixes <http://webkit.org/b/40728>
plugins/geturlnotify-during-document-teardown.html fails on Windows
* DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_Destroy): Removed extra newline that the Mac version doesn't
have.
2010-06-16 Adam Roben <aroben@apple.com>
Respect LayoutTestController::isPrinting on Windows
This gets some printing tests closer to passing (like
printing/page-rule-in-media-query.html).
Fixes <http://webkit.org/b/40727>.
Reviewed by Dan Bernstein.
* DumpRenderTree/win/DumpRenderTree.cpp:
(dump): Pass LayoutTestController::isPrinting to
IWebFramePrivate::renderTreeAsExternalRepresentation.
2010-06-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650
* DumpRenderTree/mac/DumpRenderTree.mm:
(initializeGlobalsFromCommandLineOptions):
2010-06-10 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Implement render style selection for pages to support CSS3 Paged Media.
https://bugs.webkit.org/show_bug.cgi?id=35961
* DumpRenderTree/LayoutTestController.cpp:
(parsePagePropertyParameters):
(pagePropertyCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::pageProperty):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::pageProperty):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::pageProperty):
2010-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
WebKit2: Add mechanism to inject code into the WebProcess on startup
Add initial InjectedBundle support.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/WebBundle-Info.plist: Added.
Add test InjectedBundle to the project.
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
Get the path to the WebBundle from the the main bundle and pass it to the new
WKContextCreateWithInjectedBundlePath function.
* MiniBrowser/mac/BrowserWindowController.m:
(_didChangeProgress):
Fix the build. This has been broken for a while.
* MiniBrowser/mac/WebBundle: Added.
* MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
(_didCreatePage):
(WKBundleInitialize):
Add really basic InjectedBundle.
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Darin Adler.
Adding myself to the reviewers list.
https://bugs.webkit.org/show_bug.cgi?id=40693
* Scripts/webkitpy/common/config/committers.py:
2010-06-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Switch to using GIO methods instead of realpath in GtkLauncher to determine
the file URI. This should remove warnings about realpath being undefined
when compiling with '-ansi'.
* GtkLauncher/main.c:
(filenameToURL): Use GIO instead of realpath to determine file URI.
2010-06-15 Adam Roben <aroben@apple.com>
Remove the redundant set-apple-windows-environment-variables script
Apparently update-webkit does this for you these days.
Rubber-stamped by Steve Falkenburg.
* Scripts/set-apple-windows-environment-variables: Removed.
2010-06-14 Adam Roben <aroben@apple.com>
Add a script to set the WebKitOutputDir and WebKitLibrariesDir
environment variables
Fixes <http://webkit.org/b/40595>.
Reviewed by Steve Falkenburg.
* Scripts/set-apple-windows-environment-variables: Added.
(to_windows_path): Passes the passed-in path through cygpath to
generate a Windows-style path.
(main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
variables to their defaults, if they aren't already set.
2010-06-14 Adam Roben <aroben@apple.com>
Speed up run-safari/debug-safari on Windows
Fixes <http://webkit.org/b/40586>.
Reviewed by Steve Falkenburg.
* Scripts/webkitdirs.pm:
(runSafari): When debugging, set up the environment to run Safari
using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
actually launch the debugger. When not debugging, just run WebKit.exe
and it will do the rest for us.
2010-06-15 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT EventSender support to graphics context events
https://bugs.webkit.org/show_bug.cgi?id=40324
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::contextClick):
2010-06-14 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
[chromium] checkout chromium third_party directly
https://bugs.webkit.org/show_bug.cgi?id=40556
* Scripts/update-webkit-chromium: some migration code for the bots
2010-06-14 Alexey Proskuryakov <ap@apple.com>
Chromium build fix.
* DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
2010-06-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=40529
eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
event for "delete" - it had virtual key code from forward delete, and text from backspace.
Fixed "delete" to mean forward delete.
* DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
* DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
* DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
Mac DRT confusion has propagated to other platforms, fixing those.
2010-06-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Small GtkLauncher build fix for some systems.
* GtkLauncher/main.c: Add <limit.h> include.
2010-06-14 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] navigator.geolocation support for Qt port
https://bugs.webkit.org/show_bug.cgi?id=39724
Implementation for geolocation cases to DumpRenderTreeQt
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::allowGeolocationRequest):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setGeolocationPermission):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setMockGeolocationPosition):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::isGeolocationPermissionSet):
(LayoutTestController::geolocationPermission):
2010-06-13 Nathan Lawrence <nlawrence@apple.com>
Reviewed by Darin Adler.
Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
be a way of overwriting the Xcode system path. Making
$WEBKITOUTPUTDIR take precedence over the system default would make
this possible.
* Scripts/webkitdirs.pm:
2010-06-13 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: link won't return linked element if URL contains #
https://bugs.webkit.org/show_bug.cgi?id=40192
* DumpRenderTree/AccessibilityUIElement.cpp:
(linkedUIElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::linkedUIElementAtIndex):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::linkedUIElementAtIndex):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::linkedUIElementAtIndex):
2010-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
https://bugs.webkit.org/show_bug.cgi?id=39550
This can cause an extra request to bugs.webkit.org durig upload, but it
shouldn't be too bad. Also, this won't work if you remove the
boilerplate created by prepare-ChangeLog.
* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
2010-06-08 Robert Hogan <robert@webkit.org>
Reviewed by Eric Seidel.
[Qt] Add support for callShouldCloseOnWebView() to DRT
https://bugs.webkit.org/show_bug.cgi?id=40330
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::callShouldCloseOnWebView):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::setCallCloseOnWebViews):
2010-06-12 Eric Seidel <eric@webkit.org>
Reviewed by Daniel Bates.
do-webcore-rename should have a --verbose option
https://bugs.webkit.org/show_bug.cgi?id=40497
* Scripts/do-webcore-rename:
- Unified how we handle skipping files/directories
this will allow us to "black list" certain files and
directories when performing renames.
- Made do-webcore-rename log what it's skipping when passed --verbose.
2010-06-12 Darin Adler <darin@apple.com>
* Scripts/run-bindings-tests: Fixed a typo in a message.
2010-06-12 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
https://bugs.webkit.org/show_bug.cgi?id=40402
_build_path() of each Chromium port check existence of build path
of Chromium checkout first, then check existence of build path of
WebKit-only checkout.
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
2010-06-12 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Back-forward list dumping is incorrect
https://bugs.webkit.org/show_bug.cgi?id=36392
Support dumping child history items in DRT.
Unskip:
fast/loader/frame-src-change-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::dumpHistoryItem):
2010-06-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
upload all patches that lack in-rietveld to rietveld
https://bugs.webkit.org/show_bug.cgi?id=40444
If it's a patch, then we'll try to upload it as long as it
doesn't have in-rietveld set. No longer set in-rietveld? since
it's not needed.
* Scripts/webkitpy/common/net/bugzilla.py:
2010-06-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Fisher.
Fix rietveld upload when message length > 100 characters
https://bugs.webkit.org/show_bug.cgi?id=40457
* Scripts/webkitpy/common/net/rietveld.py:
2010-06-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] There should be a way to enable popups in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=40427
* QtTestBrowser/main.cpp:
(LauncherWindow::toggleJavascriptCanOpenWindows):
(LauncherWindow::createChrome):
2010-06-10 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Make SheriffBot more chatty
https://bugs.webkit.org/show_bug.cgi?id=40463
People seem to like to talk to SheriffBot, so let's make him chat back.
* Scripts/webkitpy/thirdparty/__init__.py:
* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
* Scripts/webkitpy/tool/bot/sheriffircbot.py:
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2010-06-10 Brian Weinstein <bweinstein@apple.com>
Reviewed by Darin Adler.
Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
WEXITSTATUS on $result instead of just comparing $result to 0.
* Scripts/update-webkit-auxiliary-libs:
2010-06-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Alexey Proskuryakov.
don't use Exception.message as it's deprecated in python 2.6+
https://bugs.webkit.org/show_bug.cgi?id=40449
* Scripts/webkitpy/tool/commands/queues.py:
2010-06-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix handle_script_error in rietveld upload queue and add testing for handle_script_error
https://bugs.webkit.org/show_bug.cgi?id=40436
* Scripts/webkitpy/common/system/outputcapture.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-06-10 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Simon Hausmann.
[Qt] *All* WebGL layout tests fail!
https://bugs.webkit.org/show_bug.cgi?id=40296
Added test for WebKitWebGLEnabled to
LayoutTestController::overridePreference().
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference):
2010-06-10 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT EventSender support to graphics mouse events activation
https://bugs.webkit.org/show_bug.cgi?id=40017
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::mouseDown):
(EventSender::mouseUp):
(EventSender::mouseMoveTo):
(EventSender::keyDown):
(EventSender::contextClick):
(EventSender::sendTouchEvent):
(EventSender::sendOrQueueEvent):
(EventSender::eventFilter):
(EventSender::createGraphicsSceneMouseEvent):
(EventSender::sendEvent):
* DumpRenderTree/qt/EventSenderQt.h:
(EventSender::isGraphicsBased):
2010-06-09 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
webkit-patch upload fails for security bugs because there's no rietveld flag
https://bugs.webkit.org/show_bug.cgi?id=40309
There's probably a more elegant way of seeing whether the form control
exists, but this seems to work.
* Scripts/webkitpy/common/net/bugzilla.py:
2010-06-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
make rietveld upload faster and avoid posting to bug on errors
https://bugs.webkit.org/show_bug.cgi?id=40389
Only grab the first item of the upload queue instead of trying
to compute the whole list upfront (which is O(n) bugzilla lookups!).
Also, don't post comments to the bug when uploading fails.
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/stepsequence.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-06-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
Rietveld upload queue fails when setting in-rietveld flag
https://bugs.webkit.org/show_bug.cgi?id=40371
Make the comment arguments to set_flag_on_attachment optional
and add it to the MockBugzilla.
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/tool/bot/queueengine.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
2010-06-09 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Rename FloatArray to Float32Array
https://bugs.webkit.org/show_bug.cgi?id=40323
Used do-webcore-rename to perform renaming. Manually undid
incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
all layout tests on Safari; built Chromium and ran selected WebGL
tests.
* Scripts/do-webcore-rename:
2010-06-08 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
https://bugs.webkit.org/show_bug.cgi?id=40285
* Scripts/webkitdirs.pm:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2010-06-03 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Tamura Kent.
Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
https://bugs.webkit.org/show_bug.cgi?id=40052
Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
* DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
(WebKit::):
(WebKit::WebThemeControlDRT::WebThemeControlDRT):
(WebKit::WebThemeControlDRT::~WebThemeControlDRT):
(WebKit::WebThemeControlDRT::box):
(WebKit::WebThemeControlDRT::line):
(WebKit::WebThemeControlDRT::triangle):
(WebKit::WebThemeControlDRT::roundRect):
(WebKit::WebThemeControlDRT::oval):
(WebKit::WebThemeControlDRT::circle):
(WebKit::WebThemeControlDRT::nestedBoxes):
(WebKit::WebThemeControlDRT::markState):
(WebKit::WebThemeControlDRT::draw):
(WebKit::WebThemeControlDRT::drawTextField):
(WebKit::WebThemeControlDRT::drawProgressBar):
* DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
(WebKit::WebThemeControlDRT::):
* DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
(WebKit::):
(WebKit::WebThemeEngineDRT::paintButton):
(WebKit::WebThemeEngineDRT::paintMenuList):
(WebKit::WebThemeEngineDRT::paintScrollbarArrow):
(WebKit::WebThemeEngineDRT::paintScrollbarThumb):
(WebKit::WebThemeEngineDRT::paintScrollbarTrack):
(WebKit::WebThemeEngineDRT::paintTextField):
(WebKit::WebThemeEngineDRT::paintTrackbar):
(WebKit::WebThemeEngineDRT::paintProgressBar):
* DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
(WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
2010-06-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60878.
http://trac.webkit.org/changeset/60878
https://bugs.webkit.org/show_bug.cgi?id=40349
broke linux build (Requested by tony^work on #webkit).
* Scripts/webkitdirs.pm:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2010-06-08 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
https://bugs.webkit.org/show_bug.cgi?id=40285
* Scripts/webkitdirs.pm:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2010-06-08 Kenneth Russell <kbr@google.com>
Unreviewed, build fix.
Fix build breakage from 38145
https://bugs.webkit.org/show_bug.cgi?id=40346
The fix for bug 38145 broke the Chromium Win build because
Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
change log2(x) to log(x) / log(2). Built and ran WebGL layout
tests in Safari on Mac OS X. Changed download mirrors for
python-irclib to working ones.
* Scripts/webkitpy/thirdparty/__init__.py:
2010-06-08 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058
* Scripts/old-run-webkit-tests:
use sourceDir() to find ensure-valid-python in checkPythonVersion()
2010-06-08 Andras Becsi <abecsi@webkit.org>
Unreviewed buildfix after r60479.
[GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
versions other than 2.17.3.
* DumpRenderTree/gtk/EventSender.cpp:
(getRootCoords):
2010-06-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Oliver Hunt.
[GTK] Mouse movement should not trigger a replay of saved events in the event sender
https://bugs.webkit.org/show_bug.cgi?id=40267
When a mouse button is down, automatically queue mouse motion events and
do not play them back until the mouse button is released. This matches the
behavior of other ports' EventSenders.
* DumpRenderTree/gtk/EventSender.cpp:
(mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
(sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
2010-06-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Sam Weinig.
Add CPP bindings generator
https://bugs.webkit.org/show_bug.cgi?id=38279
Integrate CPP bindings in run-bindings-tests.
* Scripts/run-bindings-tests:
2010-06-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Ojan Vafai.
Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
https://bugs.webkit.org/show_bug.cgi?id=40183
* Scripts/webkitpy/tool/steps/preparechangelog.py:
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Add my new email and IRC nick to committers.py.
* Scripts/webkitpy/common/config/committers.py:
2010-06-04 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed.
Revert changes in json_results_generator.py's _get_svn_revision.
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] GtkLauncher should support relative file paths
https://bugs.webkit.org/show_bug.cgi?id=39944
Allow GtkLauncher to handle relative file paths passed via command-line arguments.
* GtkLauncher/main.c:
(filename_to_url): Added.
(main): Try to resolve arguments as relative file URLs first.
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
https://bugs.webkit.org/show_bug.cgi?id=40182
Instead of invoking signal handlers directly via g_signal_emit_by_name, call
gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
without breaking DRT.
* DumpRenderTree/gtk/EventSender.cpp:
(dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
(keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
2010-06-04 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
Make the editing/spelling/context-menu-suggestions.html test more robust
https://bugs.webkit.org/show_bug.cgi?id=40178
Change the contextClick method to return an array of strings describing the context menu items.
* DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController contextClick]):
2010-06-03 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Shinichiro Hamaji.
Clean up chromium-specific code from json_results_generator.py.
https://bugs.webkit.org/show_bug.cgi?id=39665
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
2010-06-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Utilize new takeFirst() method where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=40089
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::replaySavedEvents):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::WorkQueue::processWork):
(LayoutTestController::WorkQueue::reset):
2010-06-04 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
[Qt] QtTestLauncher should allow notifications by default.
https://bugs.webkit.org/show_bug.cgi?id=40078
* QtTestBrowser/main.cpp:
(NotificationsPermissionController::NotificationsPermissionController):
(NotificationsPermissionController::checkPermission):
(NotificationsPermissionController::requestPermission):
(LauncherWindow::LauncherWindow):
2010-06-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Detect whether the user's environment can open a browser.
https://bugs.webkit.org/show_bug.cgi?id=40136
Some environments like cygwin silently fail webbrowser.open() causing
webkit-patch upload not to display any diff. This detects environments
where webbrowser.open() would fail by testing if webbrowser.get()
raises an exception.
* Scripts/webkitpy/common/system/user.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/confirmdiff.py:
2010-06-03 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
Add dependencies required to link with VS Express 2005.
https://bugs.webkit.org/show_bug.cgi?id=40038
Visual Studio implicitly links against these libs.
VC++ Express does not.
* WebKitAPITest/WebKitAPITestCommon.vsprops:
* WinLauncher/WinLauncher.vcproj:
2010-06-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
https://bugs.webkit.org/show_bug.cgi?id=40105
* Scripts/webkitpy/layout_tests/port/websocket_server.py:
- kill pywebsocket process when url is not alive and the process is not
terminated, not to leave pywebsocket server running.
- fix codecs.open parameters.
2010-06-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058
* Scripts/ensure-valid-python:
- Perl 5.8 doesn't have File::Temp->newdir(). Use File::Temp->tempdir() instead.
- Add --check-only and --help option.
- --check-only option only checks python version and don't try to install Python 2.5.
- Set executable bit.
* Scripts/old-run-webkit-tests:
- Check if it can run the websocket tests by calling ensure-valid-python --check-only.
2010-05-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
https://bugs.webkit.org/show_bug.cgi?id=38918
Patches with in-rietveld? get uploaded to rietveld and get marked
in-rietveld+. If the upload fails, they are marked in-rietveld-
and an error is logged to the bug, like the commit-queue.
Also, get rid of --fancy-review and the ability to upload to rietveld
using webkit-patch upload/post.
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/common/net/bugzilla_unittest.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/options.py:
* Scripts/webkitpy/tool/steps/postcodereview.py:
2010-05-24 Ojan Vafai <ojan@chromium.org>
Reviewed by Chris Jerdonek.
many webkit-patch commands fail in a non-svn tracking git checkout
https://bugs.webkit.org/show_bug.cgi?id=38156
If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
If neither exists, then error out. This makes webkit-patch work
for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
to checkout webkit. The fallback to master is for people who don't
do the steps on that page for tracking svn.
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
2010-06-03 Mike Fenton <mifenton@rim.com>
Unreviewed.
Reverse e-mail for myself in committers.py to correspond with bugzilla account.
* Scripts/webkitpy/common/config/committers.py:
2010-06-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: a number of fixes that make InspectorController
happy with null redirects.
https://bugs.webkit.org/show_bug.cgi?id=40109
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
* DumpRenderTree/mac/DumpRenderTree.mm:
(runTest):
* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest):
2010-06-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Shinichiro Hamaji.
[Qt] Fix compilation with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=38324
* QtTestBrowser/main.cpp:
(LauncherWindow::init):
2010-06-02 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make possible run DRT with QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=40016
Make possible to use a environment variable for switching backend.
Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
(WebCore::DumpRenderTree::DumpRenderTree):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(WebCore::DumpRenderTree::setGraphicsBased):
(WebCore::DumpRenderTree::isGraphicsBased):
(WebCore::WebViewGraphicsBased::graphicsView):
(WebCore::WebViewGraphicsBased::setPage):
* Scripts/old-run-webkit-tests:
2010-06-02 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Eric Seidel.
Slave lost shouldn't be recognized as build failed.
https://bugs.webkit.org/show_bug.cgi?id=39282
* Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
* Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
2010-06-01 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix the lifecycle of notification objects
https://bugs.webkit.org/show_bug.cgi?id=40003
Remove the dependency of notifications on QWebPage.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::requestPermissionCallback):
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::requestPermission):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60559.
http://trac.webkit.org/changeset/60559
https://bugs.webkit.org/show_bug.cgi?id=40055
It broke python unit test (Requested by Ossy on #webkit).
* Scripts/webkitpy/common/net/buildbot.py:
2010-06-02 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Eric Seidel.
Slave lost shouldn't be recognized as build failed.
https://bugs.webkit.org/show_bug.cgi?id=39282
* Scripts/webkitpy/common/net/buildbot.py:
2010-06-02 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Fix crash caused when assigned_to is disabled
https://bugs.webkit.org/show_bug.cgi?id=40039
* Scripts/webkitpy/common/net/bugzilla.py:
2010-06-02 Sterling Swigart <sswigart@google.com>
Reviewed by David Levin.
Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906
* Scripts/build-webkit:
2010-06-01 Raine Makelainen <raine.makelainen@nokia.com>
Reviewed by Simon Hausmann.
Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::resetSettings):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setJavaScriptCanAccessClipboard):
2010-06-01 Alexey Proskuryakov <ap@apple.com>
Reviewed by Mark Rowe.
A nicer Tiger build fix.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/mac/Configurations/Base.xcconfig:
Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
2010-06-01 Alexey Proskuryakov <ap@apple.com>
A real Tiger build fix.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
for all configurations, not just debug.
2010-06-01 Alexey Proskuryakov <ap@apple.com>
Tiger build fix.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
2010-06-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Get more mouse tests passing
https://bugs.webkit.org/show_bug.cgi?id=39040
Reproduce the logic from the Windows EventSender for mapping
button numbers to GDK button numbers. Move this logic to the
prepareMouseButtonEvent helper.
* DumpRenderTree/gtk/EventSender.cpp:
(prepareMouseButtonEvent): Reproduce Windows logic.
(contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
(mouseDownCallback): Ditto.
(mouseUpCallback): Ditto.
2010-06-01 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=39434
REGRESSION (r59811): Geolocation callbacks cannot be created
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider.
(resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
into subsequent tests.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
(LayoutTestController::setMockGeolocationError): Ditto.
* DumpRenderTree/mac/MockGeolocationProvider.h: Added.
* DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
(+[MockGeolocationProvider shared]):
(-[MockGeolocationProvider dealloc]):
(-[MockGeolocationProvider setPosition:]):
(-[MockGeolocationProvider setError:]):
(-[MockGeolocationProvider registerWebView:]):
(-[MockGeolocationProvider unregisterWebView:]):
(-[MockGeolocationProvider lastPosition]):
(-[MockGeolocationProvider stopTimer]):
(-[MockGeolocationProvider timerFired]):
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
This delegate method must send a response. I'm not sure what the two-stage check is supposed
to achieve, it seems unnecessary.
2010-05-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853
WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
the GDK event queue entirely, we simply do not send the extra event.
* DumpRenderTree/gtk/EventSender.cpp:
(mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
(dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
2010-06-01 Martin Robinson <mrobinson@igalia.com>
Not reviewed. Build fix.
Fix GTK+ build caused by a bad merge.
* DumpRenderTree/gtk/EventSender.cpp:
(prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
2010-06-01 Martin Robinson <mrobinson@webkit.org>
Reviewed by Xan Lopez.
[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853
Small EventSender cleanups. Consolidate some common code. Style fixes.
* DumpRenderTree/gtk/EventSender.cpp:
(prepareMouseButtonEvent): Added.
(contextClickCallback): Use prepareMouseButtonEvent.
(mouseDownCallback): Use prepareMouseButtonEvent.
(mouseUpCallback): Use prepareMouseButtonEvent.
(mouseMoveToCallback): Small style fix.
2010-06-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853
Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
to pause for a specified amount of time. It is used in the processing of drag-
-and-drop data as well as to separate distinct mouse double-clicks in some tests.
This patch enables tests that rely on the latter behavior to pass.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
* DumpRenderTree/gtk/EventSender.cpp:
(leapForwardCallback): Add support for adjusting the time offset on leapForward().
(contextClickCallback): Use sendOrQueueEvent.
(updateClickCount): Take the time offset into account when counting clicks.
(mouseDownCallback): Use sendOrQueueEvent.
(getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
(mouseUpCallback): Use sendOrQueueEvent.
(mouseMoveToCallback): Ditto.
(mouseWheelToCallback): Ditto.
(sendOrQueueEvent): Added.
(dispatchEvent): Added.
(replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
(makeEventSender): Only initialize the EventSender when loading the top frame.
* DumpRenderTree/gtk/EventSender.h: Ditto.
2010-06-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=39101
Work around timing issues for render tree dumps by pumping the
main loop before doing the dump. Resize events are asynchronous
in GTK+, so sometimes resize requests are still pending when DRT
dumps the tree.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump): Pump the main loop before dumping the render tree.
2010-05-31 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Fix crash of a test after another test with multiple windows
https://bugs.webkit.org/show_bug.cgi?id=39942
If a test opens multiple windows, focuses on non-main window, and
the focused window is closed, TestShell::m_focusedWidget points a
deleted object.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::closeWindow): Clear m_focusedWidget.
2010-05-30 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
new-run-webkit-tests: Support DRT on Chromium-win
https://bugs.webkit.org/show_bug.cgi?id=39810
Add --test-shell flag to DRT/Chromium, and it changes DRT so that
it behaves like test_shell about command analysis, printing
format, pixel dumping, and timeout handling.
chromium.py and chromium_win.py supports the --test-shell flag and
DRT/Chromium-win binary names.
* DumpRenderTree/DumpRenderTree.gypi: Add new files.
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(runTest): Support for test_shell-style command.
(main): Introduce --test-shell.
* DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
* DumpRenderTree/chromium/TestEventPrinter.h: Added.
TestEventPrinter class manages stdio output and image output.
TestEventPrinter.cpp has two implementations; DRTPrinter and
TestShellPrinter.
* DumpRenderTree/chromium/TestShell.cpp:
Some changes for TestEventPrinter.
(TestShell::TestShell):
(TestShell::runFileTest):
(TestShell::testTimedOut):
(TestShell::dump):
(TestShell::dumpImage):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::printer):
(TestShell::layoutTestTimeout):
(TestShell::layoutTestTimeoutForWatchDog):
(TestShell::setLayoutTestTimeout):
* DumpRenderTree/chromium/TestShellWin.cpp:
(watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
2010-05-30 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
https://bugs.webkit.org/show_bug.cgi?id=36004
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
Scrollbar::pixelsPerLineStep() for DRT testing.
(EventSender::mouseScrollBy): Added
(EventSender::continuousMouseScrollBy): Added
* DumpRenderTree/qt/EventSenderQt.h:
2010-05-28 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
https://bugs.webkit.org/show_bug.cgi?id=39546
One sublty is that we want to wait for the user to finish editing the
ChangeLog before moving on to the next step. That means we want to pass
-W to open. However, if the user is using Xcode to edit the ChangeLog,
we don't want them to have to exit the Xcode application. For this reason,
we create a new instance of the application with -n.
Overall, xed seems like a better solution, so we recommend that too.
* Scripts/webkitpy/common/system/user.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/editchangelog.py:
2010-05-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
threads are wedged. Also, the script will print the results of the
tests completed when the interrupt occurs.
https://bugs.webkit.org/show_bug.cgi?id=33238
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
* Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2010-05-28 Darin Adler <darin@apple.com>
Ignore more Python messiness.
* Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
* Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
* Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
* Scripts/webkitpy/test: Added property svn:ignore.
* Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
2010-05-28 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
Adding myself as a reviewer.
* Scripts/webkitpy/common/config/committers.py:
2010-05-28 Chris Fleizach <cfleizach@apple.com>
Build fix. No review.
AX: need to catch NSAccessibilityExceptions in DRT
https://bugs.webkit.org/show_bug.cgi?id=39881
It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::selectedTextRange):
2010-05-28 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: need to catch NSAccessibilityExceptions in DRT
https://bugs.webkit.org/show_bug.cgi?id=39881
Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but
because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
So DRT should wrap exception handlers around its AX related calls.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(attributesOfElement):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::isAttributeSettable):
(AccessibilityUIElement::isAttributeSupported):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::isActionSupported):
(AccessibilityUIElement::isEnabled):
(AccessibilityUIElement::isRequired):
(AccessibilityUIElement::isSelected):
(AccessibilityUIElement::isExpanded):
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::indexInTable):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::setSelectedTextRange):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):
(AccessibilityUIElement::showMenu):
(AccessibilityUIElement::press):
(AccessibilityUIElement::url):
(AccessibilityUIElement::hasPopup):
2010-05-28 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Pass all web notification layout tests
https://bugs.webkit.org/show_bug.cgi?id=39146
Mimic Chromium's test_shell security model in Qt's DRT.
It makes a list of origins which were granted permission to display
notifications, and only those origins can display notifications.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::checkPermissionCallback):
(WebCore::requestPermissionCallback):
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::checkPermission):
(WebCore::DumpRenderTree::requestPermission):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::checkDesktopNotificationPermission):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-05-27 Philippe Normand <pnormand@igalia.com>
Reviewed by Shinichiro Hamaji.
check-webkit-style complains about use of NULL in GTK function calls that require sentinels
https://bugs.webkit.org/show_bug.cgi?id=39372
Don't warn about NULL in g_*() calls. Zero can't be used instead
for calls like g_build_filename and g_object_get/set.
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
2010-05-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Platform plugin example
https://bugs.webkit.org/show_bug.cgi?id=39489
Exempting directory WebKit/qt/examples/ from style guide.
* Scripts/webkitpy/style/checker.py:
2010-05-26 Philippe Normand <pnormand@igalia.com>
Reviewed by David Levin.
[style] Allow usage of NULL in gst_*_many()
https://bugs.webkit.org/show_bug.cgi?id=39740
Don't warn if NULL is used by gst_*_many() functions. Zero can't
be used for the reason explained in Bug 32858.
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
2010-05-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update script to run the normal version of the parser tests.
* Scripts/test-html5-parser:
2010-05-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add HTML5 parser support to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=39815
* Scripts/old-run-webkit-tests:
2010-05-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5 lexer not ASSERT when resuming partial parses
https://bugs.webkit.org/show_bug.cgi?id=39755
Add webkit-resumer.html to the HTML5 parser test suite.
* Scripts/test-html5-parser:
2010-05-24 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] setup fonts on chromium linux DRT
https://bugs.webkit.org/show_bug.cgi?id=39644
* DumpRenderTree/chromium/TestShellGtk.cpp:
(setupFontconfig):
(platformInit):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::paintRect): Fix a bug where in release builds, we didn't initialize m_canvas.
* DumpRenderTree/chromium/fonts.conf: Added.
2010-05-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Re-commit r58765 - it had been rolled out to see if it was causing
a perf regression (in r59787 and r59789), but that does not seem to
have been the case.
https://bugs.webkit.org/show_bug.cgi?id=39605
* DumpRenderTree/chromium/NotificationPresenter.cpp:
(NotificationPresenter::show):
2010-05-25 Ojan Vafai <ojan@chromium.org>
Reviewed by Chris Jerdonek.
remove suppression of rietveld logging
https://bugs.webkit.org/show_bug.cgi?id=39693
Now that we only upload to rietveld explicitly, e.g. on the bot
or via webkit-patch post-attachment-to-rietveld, we should print
all the rietveld logging. It was suppressed before to avoid making
webkit-patch upload too noisy.
* Scripts/webkitpy/common/net/rietveld.py:
2010-05-25 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ojan Vafai.
[Qt] Expose the editing behavior setting in DRT to test all editing code paths
https://bugs.webkit.org/show_bug.cgi?id=39680
Implement LayoutTestController::setEditingBehavior in Qt's DRT.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setEditingBehavior):
2010-05-25 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setEditingBehavior):
* wx/build/settings.py:
2010-05-24 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
editingBehavior settings needs to be set back to a reasonable default between tests
https://bugs.webkit.org/show_bug.cgi?id=39433
Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
so that the serialized version of the setting stays in sync with expectations.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetWebSettings):
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
2010-05-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch land calls scm.changed_files 4 times!
https://bugs.webkit.org/show_bug.cgi?id=39584
* Scripts/webkitpy/tool/commands/download_unittest.py:
- Assert that we don't call modified_changelogs too often.
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
- Use cached changelogs list instead of calling modified_changelogs directly.
* Scripts/webkitpy/tool/steps/validatereviewer.py:
- ditto.
2010-05-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Import layout_test_helper for Windows
https://bugs.webkit.org/show_bug.cgi?id=39581
Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
* DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
2010-05-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Reset frame name
https://bugs.webkit.org/show_bug.cgi?id=39586
This change fixes about 70 unexpected results.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::reset):
2010-05-24 Marcus Bulach <bulach@chromium.org>
Reviewed by Kent Tamura.
[chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
https://bugs.webkit.org/show_bug.cgi?id=39587
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::geolocationService):
2010-05-24 Robert Hogan <robert@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] DRT Support for removeOriginAccessWhitelistEntry
Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
[Qt] DRT Support for removeOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=39565
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::removeOriginAccessWhitelistEntry):
2010-05-24 Marcus Bulach <bulach@google.com>
Reviewed by Ojan Vafai.
_svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
https://bugs.webkit.org/show_bug.cgi?id=39603
* Scripts/webkitpy/common/checkout/scm.py:
== Rolled over to ChangeLog-2010-05-24 ==
|