summaryrefslogtreecommitdiffstats
path: root/services
diff options
context:
space:
mode:
authorGlenn Kasten <gkasten@google.com>2015-03-04 00:05:07 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2015-03-04 00:05:08 +0000
commit0331cf73db5087311089e01f5d31bb4026e54e6a (patch)
treec20054736d6a1de501a5a43e416cd9a7005114f1 /services
parent27697a3d51b3e6c3c6619fdb8249af5885629610 (diff)
parent8a0554c63dc40a2a7c066b03041079ec9eb220e5 (diff)
downloadframeworks_av-0331cf73db5087311089e01f5d31bb4026e54e6a.zip
frameworks_av-0331cf73db5087311089e01f5d31bb4026e54e6a.tar.gz
frameworks_av-0331cf73db5087311089e01f5d31bb4026e54e6a.tar.bz2
Merge "Pull up comment to superclass"
Diffstat (limited to 'services')
-rw-r--r--services/audioflinger/FastMixerDumpState.h6
-rw-r--r--services/audioflinger/FastThreadDumpState.h7
2 files changed, 6 insertions, 7 deletions
diff --git a/services/audioflinger/FastMixerDumpState.h b/services/audioflinger/FastMixerDumpState.h
index 1ef86fd..ac15e7c 100644
--- a/services/audioflinger/FastMixerDumpState.h
+++ b/services/audioflinger/FastMixerDumpState.h
@@ -59,12 +59,6 @@ struct FastTrackDump {
size_t mFramesReady; // most recent value only; no long-term statistics kept
};
-// The FastMixerDumpState keeps a cache of FastMixer statistics that can be logged by dumpsys.
-// Each individual native word-sized field is accessed atomically. But the
-// overall structure is non-atomic, that is there may be an inconsistency between fields.
-// No barriers or locks are used for either writing or reading.
-// Only POD types are permitted, and the contents shouldn't be trusted (i.e. do range checks).
-// It has a different lifetime than the FastMixer, and so it can't be a member of FastMixer.
struct FastMixerDumpState : FastThreadDumpState {
FastMixerDumpState();
/*virtual*/ ~FastMixerDumpState();
diff --git a/services/audioflinger/FastThreadDumpState.h b/services/audioflinger/FastThreadDumpState.h
index bbca7da..1ce0914 100644
--- a/services/audioflinger/FastThreadDumpState.h
+++ b/services/audioflinger/FastThreadDumpState.h
@@ -22,7 +22,12 @@
namespace android {
-// FIXME extract common part of comment at FastMixerDumpState
+// The FastThreadDumpState keeps a cache of FastThread statistics that can be logged by dumpsys.
+// Each individual native word-sized field is accessed atomically. But the
+// overall structure is non-atomic, that is there may be an inconsistency between fields.
+// No barriers or locks are used for either writing or reading.
+// Only POD types are permitted, and the contents shouldn't be trusted (i.e. do range checks).
+// It has a different lifetime than the FastThread, and so it can't be a member of FastThread.
struct FastThreadDumpState {
FastThreadDumpState();
/*virtual*/ ~FastThreadDumpState();