summaryrefslogtreecommitdiffstats
path: root/services
diff options
context:
space:
mode:
authorGlenn Kasten <gkasten@google.com>2013-12-03 09:06:43 -0800
committerEric Laurent <elaurent@google.com>2014-03-05 14:10:41 -0800
commitd812fc012298470a1b8120e6d60a24b0b1d48047 (patch)
treebf3c68ea3a908a0792e766714cd9d54f98ebfb46 /services
parent88876fb4eb8365343f2a9ca0e8f53148ca38b845 (diff)
downloadframeworks_av-d812fc012298470a1b8120e6d60a24b0b1d48047.zip
frameworks_av-d812fc012298470a1b8120e6d60a24b0b1d48047.tar.gz
frameworks_av-d812fc012298470a1b8120e6d60a24b0b1d48047.tar.bz2
Increase kFastTrackMultiplier from 1 to 2
Bug: 11967381 Change-Id: Iedec06280aa745d9df5d661f4916940cede9c191
Diffstat (limited to 'services')
-rw-r--r--services/audioflinger/Threads.cpp14
1 files changed, 7 insertions, 7 deletions
diff --git a/services/audioflinger/Threads.cpp b/services/audioflinger/Threads.cpp
index 4f1c01d..3d657b3 100644
--- a/services/audioflinger/Threads.cpp
+++ b/services/audioflinger/Threads.cpp
@@ -135,12 +135,12 @@ static const int kPriorityFastMixer = 3;
// IAudioFlinger::createTrack() reports back to client the total size of shared memory area
// for the track. The client then sub-divides this into smaller buffers for its use.
-// Currently the client uses double-buffering by default, but doesn't tell us about that.
-// So for now we just assume that client is double-buffered.
-// FIXME It would be better for client to tell AudioFlinger whether it wants double-buffering or
-// N-buffering, so AudioFlinger could allocate the right amount of memory.
+// Currently the client uses N-buffering by default, but doesn't tell us about the value of N.
+// So for now we just assume that client is double-buffered for fast tracks.
+// FIXME It would be better for client to tell AudioFlinger the value of N,
+// so AudioFlinger could allocate the right amount of memory.
// See the client's minBufCount and mNotificationFramesAct calculations for details.
-static const int kFastTrackMultiplier = 1;
+static const int kFastTrackMultiplier = 2;
// ----------------------------------------------------------------------------
@@ -1210,7 +1210,7 @@ sp<AudioFlinger::PlaybackThread::Track> AudioFlinger::PlaybackThread::createTrac
(
(tid != -1) &&
((frameCount == 0) ||
- (frameCount >= (mFrameCount * kFastTrackMultiplier)))
+ (frameCount >= mFrameCount))
)
) &&
// PCM data
@@ -4687,7 +4687,7 @@ sp<AudioFlinger::RecordThread::RecordTrack> AudioFlinger::RecordThread::createR
(
(tid != -1) &&
((frameCount == 0) ||
- (frameCount >= (mFrameCount * kFastTrackMultiplier)))
+ (frameCount >= mFrameCount))
) &&
// FIXME when record supports non-PCM data, also check for audio_is_linear_pcm(format)
// mono or stereo