summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLeon Scroggins III <scroggo@google.com>2015-06-02 13:12:12 +0000
committerAndroid Git Automerger <android-git-automerger@android.com>2015-06-02 13:12:12 +0000
commit5b751c80070a6c790fd386808be2a4258e37e69a (patch)
tree5e5392eb48eab7aeb9d3a9ff5c4f437c8d54d86b
parent425d7c8713679ce9799139f7f91c6a45caa3b486 (diff)
parent7496e153f4308b39df9c53615770f44f593c3504 (diff)
downloadframeworks_base-5b751c80070a6c790fd386808be2a4258e37e69a.zip
frameworks_base-5b751c80070a6c790fd386808be2a4258e37e69a.tar.gz
frameworks_base-5b751c80070a6c790fd386808be2a4258e37e69a.tar.bz2
am 7496e153: am 0d208173: DO NOT MERGE: Ensure that unparcelling Region only reads the expected number of bytes
* commit '7496e153f4308b39df9c53615770f44f593c3504': DO NOT MERGE: Ensure that unparcelling Region only reads the expected number of bytes
-rw-r--r--core/jni/android/graphics/Region.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/core/jni/android/graphics/Region.cpp b/core/jni/android/graphics/Region.cpp
index 6b99de8..ec4d8bf 100644
--- a/core/jni/android/graphics/Region.cpp
+++ b/core/jni/android/graphics/Region.cpp
@@ -218,7 +218,12 @@ static jlong Region_createFromParcel(JNIEnv* env, jobject clazz, jobject parcel)
return NULL;
}
SkRegion* region = new SkRegion;
- region->readFromMemory(regionData, size);
+ size_t actualSize = region->readFromMemory(regionData, size);
+
+ if (size != actualSize) {
+ delete region;
+ return NULL;
+ }
return reinterpret_cast<jlong>(region);
}