diff options
| author | Christopher Tate <ctate@google.com> | 2015-01-08 18:42:33 -0800 |
|---|---|---|
| committer | Christopher Tate <ctate@google.com> | 2015-01-14 16:36:30 -0800 |
| commit | 43a4a8c777fbb8f71540ac7fbe82674489ef557b (patch) | |
| tree | ab4f4b3a27124b244aa8b3cbb013c674da07731d /include | |
| parent | a2fa3d219bc148c196b0eb3cf7b3b1bd453e830b (diff) | |
| download | frameworks_base-43a4a8c777fbb8f71540ac7fbe82674489ef557b.zip frameworks_base-43a4a8c777fbb8f71540ac7fbe82674489ef557b.tar.gz frameworks_base-43a4a8c777fbb8f71540ac7fbe82674489ef557b.tar.bz2 | |
Fix redundant file backups
We'd observed a bug in which an unchanged file was nevertheless
being redundantly transmitted for backup on every backup pass.
The underlying issue turns out to have been the FileBackupHelper
base implementation's logic for diffing the prior-state file
set against the current state, in the case when there had been
deletions of prior files. In addition, there was also a
parallel bug in which file checksums were not calculated
properly in some cases, leading to at least one additional
redundant backup of the file in question.
Bug 18694053
Change-Id: Ie0dec06486b5fef4624561737019569c85d6b2a0
Diffstat (limited to 'include')
| -rw-r--r-- | include/androidfw/BackupHelpers.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/androidfw/BackupHelpers.h b/include/androidfw/BackupHelpers.h index 1bb04a7..0841af6 100644 --- a/include/androidfw/BackupHelpers.h +++ b/include/androidfw/BackupHelpers.h @@ -152,7 +152,7 @@ private: KeyedVector<String8,FileRec> m_files; }; -#define TEST_BACKUP_HELPERS 1 +//#define TEST_BACKUP_HELPERS 1 #if TEST_BACKUP_HELPERS int backup_helper_test_empty(); |