summaryrefslogtreecommitdiffstats
path: root/libs
diff options
context:
space:
mode:
authorJamie Gennis <jgennis@google.com>2011-10-30 18:10:41 -0700
committerJamie Gennis <jgennis@google.com>2011-10-31 18:48:31 -0700
commit94c1f148bb655a3dd3c2a2167476239b41305ff0 (patch)
tree0a7bf345bb97a55b7cdcfa2c29d1493734027e92 /libs
parent62015f5d0d1104dfc682b3eb3b6c0be4f63b985a (diff)
downloadframeworks_base-94c1f148bb655a3dd3c2a2167476239b41305ff0.zip
frameworks_base-94c1f148bb655a3dd3c2a2167476239b41305ff0.tar.gz
frameworks_base-94c1f148bb655a3dd3c2a2167476239b41305ff0.tar.bz2
BlobCache: remove the mutex locking
This change removes the mutex from the BlobCache class. The caller must be responsible for thread synchronization in order to properly implement the Flattenable interface, which is coming soon. Otherwise would be the potential for the cache contents to change between the call to the getFlattenedSize and flatten methods. Because the caller must do this synchronization anyway there's no reason to also some synchronization inside BlobCache. Change-Id: Ie1f4f6f82b78744f46a41ce863cac0cad276a20e
Diffstat (limited to 'libs')
-rw-r--r--libs/utils/BlobCache.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/libs/utils/BlobCache.cpp b/libs/utils/BlobCache.cpp
index 590576a..15155b2 100644
--- a/libs/utils/BlobCache.cpp
+++ b/libs/utils/BlobCache.cpp
@@ -67,7 +67,6 @@ void BlobCache::set(const void* key, size_t keySize, const void* value,
return;
}
- Mutex::Autolock lock(mMutex);
sp<Blob> dummyKey(new Blob(key, keySize, false));
CacheEntry dummyEntry(dummyKey, NULL);
@@ -129,7 +128,6 @@ size_t BlobCache::get(const void* key, size_t keySize, void* value,
keySize, mMaxKeySize);
return 0;
}
- Mutex::Autolock lock(mMutex);
sp<Blob> dummyKey(new Blob(key, keySize, false));
CacheEntry dummyEntry(dummyKey, NULL);
ssize_t index = mCacheEntries.indexOf(dummyEntry);