diff options
author | Jonathan Corbet <corbet@lwn.net> | 2009-02-01 14:52:56 -0700 |
---|---|---|
committer | Jonathan Corbet <corbet@lwn.net> | 2009-03-16 08:34:35 -0600 |
commit | 60aa49243d09afc873f082567d2e3c16634ced84 (patch) | |
tree | bb7c8d9668b35a3aa4e90d0a62500ac9d3e67f7f /drivers/char/sonypi.c | |
parent | 76398425bb06b07cc3a3b1ce169c67dc9d6874ed (diff) | |
download | kernel_samsung_smdk4412-60aa49243d09afc873f082567d2e3c16634ced84.zip kernel_samsung_smdk4412-60aa49243d09afc873f082567d2e3c16634ced84.tar.gz kernel_samsung_smdk4412-60aa49243d09afc873f082567d2e3c16634ced84.tar.bz2 |
Rationalize fasync return values
Most fasync implementations do something like:
return fasync_helper(...);
But fasync_helper() will return a positive value at times - a feature used
in at least one place. Thus, a number of other drivers do:
err = fasync_helper(...);
if (err < 0)
return err;
return 0;
In the interests of consistency and more concise code, it makes sense to
map positive return values onto zero where ->fasync() is called.
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Diffstat (limited to 'drivers/char/sonypi.c')
-rw-r--r-- | drivers/char/sonypi.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c index f437443..fd3dced 100644 --- a/drivers/char/sonypi.c +++ b/drivers/char/sonypi.c @@ -888,12 +888,7 @@ found: static int sonypi_misc_fasync(int fd, struct file *filp, int on) { - int retval; - - retval = fasync_helper(fd, filp, on, &sonypi_device.fifo_async); - if (retval < 0) - return retval; - return 0; + return fasync_helper(fd, filp, on, &sonypi_device.fifo_async); } static int sonypi_misc_release(struct inode *inode, struct file *file) |